Re: [PATCH ipsec] xfrmi: drop ignore_df check before updating pmtu

2020-08-10 Thread Bram Yvakh
>>> and just run ping on it. ping sets DF, we want an exception >>> to be created, but this test prevents it. >>> >>> >> As I said dropping the test currently doesn't make sense to me. >> I would expect that the 'ignore_df' flag is not set on the device, and >> if it's set then I would

Re: [PATCH ipsec] xfrmi: drop ignore_df check before updating pmtu

2020-08-07 Thread Bram Yvakh
On 7/08/2020 16:47, Sabrina Dubroca wrote: > 2020-08-04, 14:32:56 +0200, Bram Yvakh wrote: > >> On 4/08/2020 11:37, Sabrina Dubroca wrote: >> >>> diff --git a/net/xfrm/xfrm_interface.c b/net/xfrm/xfrm_interface.c >>> index b615729812e5..ad

Re: [PATCH ipsec] xfrmi: drop ignore_df check before updating pmtu

2020-08-04 Thread Bram Yvakh
On 4/08/2020 11:37, Sabrina Dubroca wrote: > xfrm interfaces currently test for !skb->ignore_df when deciding > whether to update the pmtu on the skb's dst. Because of this, no pmtu > exception is created when we do something like: > > ping -s 1438 > > By dropping this check, the pmtu exceptio