[PATCH -next] e1000e: Fix 'defined but not used' warning

2021-03-19 Thread Bixuan Cui
Fix the warning while disable CONFIG_PM_SLEEP: drivers/net/ethernet/intel/e1000e/netdev.c:6926:12: warning: ‘e1000e_pm_prepare’ defined but not used [-Wunused-function] static int e1000e_pm_prepare(struct device *dev) ^ Signed-off-by: Bixuan Cui --- drivers/net

[PATCH v3] net: ice: Fix pointer cast warnings

2020-09-22 Thread Bixuan Cui
different size Signed-off-by: Bixuan Cui Tested-by: Aaron Brown --- v3->v2: add 'Tested-by: Aaron Brown ' v2->v1: add fix: ice_flow.h:198:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define ICE_FLOW_ENTRY_PTR(h) ((struct ice_flow_entry *)(h

Re: [PATCH -next v2] net: ice: Fix pointer cast warnings

2020-09-22 Thread Bixuan Cui
ping~ On 2020/7/31 18:07, Bixuan Cui wrote: > pointers should be casted to unsigned long to avoid > -Wpointer-to-int-cast warnings: > > drivers/net/ethernet/intel/ice/ice_flow.h:197:33: warning: > cast from pointer to integer of different size > drivers/net/ethernet/intel/

[PATCH -next v2] net: ice: Fix pointer cast warnings

2020-07-31 Thread Bixuan Cui
different size Signed-off-by: Bixuan Cui --- v2->v1: add fix: ice_flow.h:198:32: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] #define ICE_FLOW_ENTRY_PTR(h) ((struct ice_flow_entry *)(h)) drivers/net/ethernet/intel/ice/ice_flow.h | 4 ++-- 1 file changed

[PATCH -next] net: ice: Fix pointer cast warnings

2020-07-31 Thread Bixuan Cui
pointers should be casted to unsigned long to avoid -Wpointer-to-int-cast warnings: drivers/net/ethernet/intel/ice/ice_flow.h:197:33: warning: cast from pointer to integer of different size Signed-off-by: Bixuan Cui --- drivers/net/ethernet/intel/ice/ice_flow.h | 2 +- 1 file changed, 1

Re: [PATCH v2] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX

2020-07-21 Thread Bixuan Cui
On 2020/7/21 9:38, David Miller wrote: > From: Bixuan Cui > Date: Mon, 20 Jul 2020 09:58:39 +0800 > >> Fix the warning: [-Werror=-Wframe-larger-than=] >> >> drivers/net/ethernet/neterion/vxge/vxge-main.c: >> In function'VXGE_COMPLETE_VPATH_TX.isra.37&#

[PATCH v2] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX

2020-07-19 Thread Bixuan Cui
ETED to 16 is appropriate that won't have much impact on performance and functionality. Signed-off-by: Bixuan Cui Signed-off-by: Stephen Hemminger --- v2: Dropping the NR_SKB_COMPLETED to 16. drivers/net/ethernet/neterion/vxge/vxge-main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

Re: [PATCH] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX

2020-07-19 Thread Bixuan Cui
On 2020/7/20 1:05, Stephen Hemminger wrote: > On Thu, 16 Jul 2020 17:32:47 + > Bixuan Cui wrote: > >> Fix the warning: [-Werror=-Wframe-larger-than=] >> >> drivers/net/ethernet/neterion/vxge/vxge-main.c: >> In function'VXGE_COMPLETE_VPATH_TX.isra.37&#

Re: [PATCH] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX

2020-07-16 Thread Bixuan Cui
On 2020/7/16 17:46, Joe Perches wrote: > I doubt this is a good idea. > Check the callers interrupt status. yes, it's not good idea to alloc memory in interrupt handler, I will think more while fix warning. :) Thanks.

[PATCH] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX

2020-07-16 Thread Bixuan Cui
Fix the warning: [-Werror=-Wframe-larger-than=] drivers/net/ethernet/neterion/vxge/vxge-main.c: In function'VXGE_COMPLETE_VPATH_TX.isra.37': drivers/net/ethernet/neterion/vxge/vxge-main.c:119:1: warning: the frame size of 1056 bytes is larger than 1024 bytes Signed-off-by: