Re: [PATCH net] sunrpc: fix UDP memory accounting

2016-08-31 Thread Benjamin Coddington
On 31 Aug 2016, at 7:45, Paolo Abeni wrote: > On Tue, 2016-08-30 at 12:28 -0400, Benjamin Coddington wrote: >> On 25 Aug 2016, at 12:42, Paolo Abeni wrote: >> >>> The commit f9b2ee714c5c ("SUNRPC: Move UDP receive data path >>> into a workqueue

Re: [PATCH net] sunrpc: fix UDP memory accounting

2016-08-30 Thread Benjamin Coddington
On 25 Aug 2016, at 12:42, Paolo Abeni wrote: The commit f9b2ee714c5c ("SUNRPC: Move UDP receive data path into a workqueue context"), as a side effect, moved the skb_free_datagram() call outside the scope of the related socket lock, but UDP sockets require such lock to be held for proper memory

Re: [RFC] Is it a bug for nfs on udp6 mode or kernel?

2016-04-13 Thread Benjamin Coddington
On Wed, 13 Apr 2016, Ding Tianhong wrote: > Hi everyone: > > I have met this problem when I try to test udp6 for nfs connection, my > environment is: > > Server: > kernel: 4.1.15 > IP:::36/64 > MTU:1500 > Setting: /etc/exports:/home/nfs *(rw,sync,no_subtree_check,no_root_squash) > > Client: >

Re: NFS/TCP/IPv6 acting strangely in 4.2

2015-09-17 Thread Benjamin Coddington
ocket to > xs_tcp_setup_socket, meaning that the socket will be unlocked before we > know that it has finished trying to connect. The following patch is based on > an initial patch by Russell King to ensure that we delay clearing the > XPRT_SOCK_CONNECTING flag until we either know that we