Re: [PATCH v2 1/5] perf record: Set PERF_RECORD_PERIOD if attr->freq is set.

> On 28-Jul-2020, at 9:33 PM, Arnaldo Carvalho de Melo wrote: > > Em Tue, Jul 28, 2020 at 05:43:47PM +0200, Jiri Olsa escreveu: >> On Tue, Jul 28, 2020 at 01:57:30AM -0700, Ian Rogers wrote: >>> From: David Sharp >>> >>> evsel__config() would only set PERF_RECORD_PERIOD if it set attr->freq

Re: [PATCH] perf record: Set PERF_RECORD_SAMPLE if attr->freq is set.

> On 27-Jul-2020, at 12:29 PM, Ian Rogers wrote: > > From: David Sharp > > evsel__config() would only set PERF_RECORD_SAMPLE if it set attr->freq Hi Ian, Commit message says PERF_RECORD_SAMPLE. But since we are setting period here, it has to say “PERF_SAMPLE_PERIOD” ? Thanks Athira >