Hi Andrew,
> > +static int mlxbf_gige_phy_enable_interrupt(struct phy_device *phydev)
> > +{
> > + int err = 0;
> > +
> > + if (phydev->drv->ack_interrupt)
> > + err = phydev->drv->ack_interrupt(phydev);
> > + if (err < 0)
> > + return err;
> > +
> > + phydev->interrupt
> > +static int mlxbf_gige_get_link_ksettings(struct net_device *netdev,
> > +struct ethtool_link_ksettings
> *link_ksettings) {
> > + struct phy_device *phydev = netdev->phydev;
> > + u32 supported, advertising;
> phy_ethtool_ksettings_get() and maybe phy_e
> > + The second generation BlueField SoC from Mellanox Technologies
> > + supports an out-of-band Gigabit Ethernet management port to the
> > + Arm subsystem.
>
> You might want to additionally select the PHY driver you are using.
>
It is preferable to not set a specific PHY driver h
> -Original Message-
> From: Andrew Lunn
> Sent: Tuesday, August 11, 2020 4:07 PM
> To: Asmaa Mnebhi
> Cc: David Thompson ;
> netdev@vger.kernel.org; da...@davemloft.net; k...@kernel.org; Jiri
> Pirko ; Asmaa Mnebhi
> Subject: Re: [PATCH net-next] Add Me
Hi Andrew,
Thanks again for your feedback.
> > + /* Finally check if this interrupt is from PHY device.
> > +* Return if it is not.
> > +*/
> > + val = readl(priv->gpio_io +
> > + MLXBF_GIGE_GPIO_CAUSE_OR_CAUSE_EVTEN0);
> > + if (!(val & priv->phy_int_gpio_mask))
>
> -Original Message-
> From: Andrew Lunn
> Sent: Friday, July 31, 2020 9:15 PM
> To: Asmaa Mnebhi
> Cc: David Thompson ;
> netdev@vger.kernel.org; da...@davemloft.net; k...@kernel.org; Jiri Pirko
>
> Subject: Re: [PATCH net-next] Add Mellanox BlueField
> -Original Message-
> From: Andrew Lunn
> Sent: Friday, July 31, 2020 3:55 PM
> To: Asmaa Mnebhi
> Cc: David Thompson ;
> netdev@vger.kernel.org; da...@davemloft.net; k...@kernel.org; Jiri
> Pirko
> Subject: Re: [PATCH net-next] Add Mellanox BlueField G