On Fri, 19 Aug 2016, Eric Dumazet wrote:
> On Fri, 2016-08-19 at 18:41 +0200, Andrew Yourtchenko wrote:
> > This allows "ip -6 route save" to save the expiry for the routes
> > that have it, such that it can be correctly restored later by
> > "ip -6 rou
Hello,
Thanks for the review and feedback, one small clarification below.
On Fri, 19 Aug 2016, Sergei Shtylyov wrote:
> Hello.
>
> On 08/19/2016 07:41 PM, Andrew Yourtchenko wrote:
>
> > Fix the flags for RA-derived routes that were saved
> > via "ip -6 rou
ady
existing code in rtm_to_fib6_config.
The expiry was already being saved as part of RTA_CACHEINFO
in rtnl_put_cacheinfo(), but adding code to generate RTF_EXPIRES upon save
looked more appropriate than redundant cherrypicking from
RTA_CACHEINFO upon restore.
Signed-off-by: Andrew Yourtchenko
---
aved routes, set the RTF_ADDRCONF
to indicate that the source of the route was originally
a router advertisement, and set the RTF_DEFAULT or RTF_ROUTEINFO
flag depending on prefix length. This can be considered a
sister change of f0396f60d7c165018c9b203fb9b89fb224835578, in
the other direction.
S
irst column
after the opening parenthesis of the function call, using
appropriate number of TABs (and SPC only at the end, if needed).
[1] v1: http://marc.info/?l=linux-netdev&m=147135599322286&w=2
Andrew Yourtchenko (2):
ipv6: save route expiry in RTA_EXPIRES if RTF_EXPIRES s
aved routes, set the RTF_ADDRCONF
to indicate that the source of the route was originally
a router advertisement, and set the RTF_DEFAULT or RTF_ROUTEINFO
flag depending on prefix length. This can be considered a
sister change of f0396f60d7c165018c9b203fb9b89fb224835578, in
the other direction.
S
tion symmetric
to that done in f0396f60d7c165018c9b203fb9b89fb224835578.
Tested both net and net-next with the patches.
Andrew Yourtchenko (2):
ipv6: save route expiry in RTA_EXPIRES if RTF_EXPIRES set
ipv6: fixup RTF_* flags when restoring RTPROT_RA route from rtnetlink
net/ipv6/route.c | 18 ++
1 file changed, 18 insertions(+)
--
2.7.4
ady
existing code in rtm_to_fib6_config.
The expiry was already being saved as part of RTA_CACHEINFO
in rtnl_put_cacheinfo(), but adding code to generate RTF_EXPIRES upon save
looked more appropriate than redundant cherrypicking from
RTA_CACHEINFO upon restore.
Signed-off-by: Andrew Yourtchenko
---