Re: [PATCH] allow dctcp alpha to drop to zero

2015-10-20 Thread Andrew Shewmaker
On Mon, Oct 19, 2015 at 8:01 AM, Florian Westphal wrote: > Andrew Shewmaker wrote: >> If alpha is strictly reduced by alpha >> dctcp_shift_g and if alpha is less >> than 1 << dctcp_shift_g, then alpha may never reach zero. For example, >> given shift_g=4 and

[PATCH] allow dctcp alpha to drop to zero

2015-10-18 Thread Andrew Shewmaker
If alpha is strictly reduced by alpha >> dctcp_shift_g and if alpha is less than 1 << dctcp_shift_g, then alpha may never reach zero. For example, given shift_g=4 and alpha=15, alpha >> dctcp_shift_g yields 0 and alpha remains 15. The effect isn't noticeable in this case below cwnd=137, but could g

Re: [PATCH net-next 2/7] tcp: track min RTT using windowed min-filter

2015-10-18 Thread Andrew Shewmaker
On Wed, Oct 14, 2015 at 02:28:00AM -0700, Andrew Shewmaker wrote: > On Fri, Oct 16, 2015 at 09:57:42PM -0700, Yuchung Cheng wrote: > ... > > diff --git a/include/linux/tcp.h b/include/linux/tcp.h > > index 86a7eda..90edef5 100644 > > --- a/include/linux/tcp.h >

Re: [PATCH net-next 2/7] tcp: track min RTT using windowed min-filter

2015-10-18 Thread Andrew Shewmaker
On Sun, Oct 18, 2015 at 10:33:41AM -0400, Neal Cardwell wrote: > On Wed, Oct 14, 2015 at 5:28 AM, Andrew Shewmaker wrote: > >> diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c > >> index 38743e5..e177386 100644 > >> --- a/net/ipv4/tcp_input.c &

Re: [PATCH net-next 2/7] tcp: track min RTT using windowed min-filter

2015-10-18 Thread Andrew Shewmaker
rtt_us); > } This didn't apply to net-next for me. I see seq_rtt_us instead of rtt_us and a check on the existence of tp->srtt_us. Maybe I've misapplied the patch? I'll try again and test the patch series against the bad behavior I mentioned above as soon as I can. Hopefully t