.debian.org/872990
Reported-by: Pavel Lyulchenko
Signed-off-by: Andreas Henriksson
---
man/man8/ss.8 | 4 ++--
misc/ss.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/man/man8/ss.8 b/man/man8/ss.8
index 81de69de..3bec97f0 100644
--- a/man/man8/ss.8
+++ b/ma
dreas Henriksson
On Sun, Jan 03, 2016 at 07:39:33PM +0100, Andreas Henriksson wrote:
> In case the commented out line was longer than the buffer size,
> the remaining part was previously not properly skipped.
>
> With this fix we should now continue ignoring lines starting with #
> unt
This is a followup to a previous commit 61170fd88d264c
"get rid of unnecessary fgets() buffer size limitation".
If fgets guarantees buffer will be null terminated in the
given size, then we can also drop the explicit termination.
Signed-off-by: Andreas Henriksson
---
misc/arpd.c | 1
In case the commented out line was longer than the buffer size,
the remaining part was previously not properly skipped.
With this fix we should now continue ignoring lines starting with #
until we find a newline character.
Signed-off-by: Andreas Henriksson
---
misc/arpd.c | 14
potential unlikely long comment handling bug spotted in
nearby code.
Signed-off-by: Andreas Henriksson
---
misc/arpd.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/misc/arpd.c b/misc/arpd.c
index 6bb9bd1..3be700d 100644
--- a/misc/arpd.c
+++ b/misc/arpd.c
@@ -702,
27;s the latest addition:
commit 3c904bb5933257533f4afecf805ca5a548a8e885
Author: Andreas Henriksson <[EMAIL PROTECTED]>
Date: Fri Feb 22 13:57:10 2008 +0100
Fix typo (syntax error) in ip(8) manpage.
Caught by lintian (debian package checker).
diff --git a/man/man8/ip.8 b/man/ma
On tor, 2008-01-10 at 20:54 +0100, Andreas Henriksson wrote:
> An additional patch will be provided in a followup mail (not available in
> Debian) that was created by request from Patrick McHardy. This one makes max
> rounds configurable (and 0 means try to infinity, so you can re
ee commit 660818498d0f5a3f52c05355a3e82c23f670fcc1
Where the comment seems to be wrong about "Limit ip route flush...",
since it's actually "ip neigh flush" that's being modified.
[3]: Read thread from here on:
http://www.spinics.net/lists/netdev/msg44920.h
Sorry. The pref and prio options are actually synonyms.
This reverts part of commit 576c63ee59de3f18bec4ebd8181a5a395f268d03.
Signed-off-by: Andreas Henriksson <[EMAIL PROTECTED]>
--- a/ip/iprule.c
+++ b/ip/iprule.c
@@ -38,7 +38,7 @@ static void usage(void)
{
fprintf(stderr, &quo
commit 355e1438f73602fbac029d28891dfa889471b679
Author: Andreas Henriksson <[EMAIL PROTECTED]>
Date: Wed Jan 2 23:21:59 2008 +0100
Add synonyms for ip rule options to ip(8) manpage.
See:
http://bugs.debian.org/433507
http://bugs.debian.org/213673
diff --git a/man/man
On ons, 2008-01-02 at 00:39 +0100, Andreas Henriksson wrote:
[...]
> Commands like "tc filter add dev ppp0 parent : protocol ip prio 50
> u32 match ip src 0.0.0.0/0 police rate 4mbit burst 10k drop flowid :1"
> apparently no longer works. The flowid is not accepted anymore.
2.git;a=commitdiff;h=720a2e8d990707749b2cafa77ab3cd2b8241ec47
I guess the flowid is invalid syntax, but that it just got ignored
instead of caught before...
Could you please have a look and tell me what you think about this?
--
Regards,
Andreas Henriksson
--
To unsubscribe from this list: send the line "u
uot;,
+ .data = &ip_rt_mc_src_strict,
+ .maxlen = sizeof(int),
+ .mode = 0644,
+ .proc_handler = &ipv4_doint_and_flush,
+ .strategy = &ipv4_doint_and_flush_strategy,
+ },
On Tue, Dec 11, 2007 at 05:14:06PM -0800, Stephen Hemminger wrote:
> On Sun, 09 Dec 2007 18:10:22 +0100
> Andreas Henriksson <[EMAIL PROTECTED]> wrote:
> > I think both previous patches where broken on big-endian platforms.
> > Here's an updated patch again. I'
On lör, 2007-12-08 at 00:41 +0100, Andreas Henriksson wrote:
> On tor, 2007-12-06 at 11:53 -0800, Stephen Hemminger wrote:
> > On Tue, 4 Dec 2007 14:58:18 +0100
> > Andreas Henriksson <[EMAIL PROTECTED]> wrote:
> >
> > > Suggested patch for allowing ne
On tor, 2007-12-06 at 11:53 -0800, Stephen Hemminger wrote:
> On Tue, 4 Dec 2007 14:58:18 +0100
> Andreas Henriksson <[EMAIL PROTECTED]> wrote:
>
> > Suggested patch for allowing netmask to be specified in dotted quad format.
> > See http://bugs.debian.org/357172
&g
Suggested patch for allowing netmask to be specified in dotted quad format.
See http://bugs.debian.org/357172
(Known problem: this will not prevent some invalid syntaxes,
ie. "255.0.255.0" will be treated as "255.255.255.0")
Comments? Suggestions? Improvements?
Signed-off-by
On Tue, Oct 23, 2007 at 05:08:10PM +0200, Patrick McHardy wrote:
> Andreas Henriksson wrote:
> >On Tue, Oct 23, 2007 at 04:38:06PM +0200, Patrick McHardy wrote:
> >>Almost - the default behaviour shouldn't change IMO. Also please
> >>send a complete patch
r advocating not selecting the "loop forever" as the
default choice.
--
Regards,
Andreas Henriksson
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, Oct 21, 2007 at 07:48:21PM +0200, Patrick McHardy wrote:
> Andreas Henriksson wrote:
> >-for (;;) {
> >+while (round < MAX_ROUNDS) {
> > if (rtnl_wilddump_request(&rth, filter.family,
> >
On Sun, Oct 21, 2007 at 07:48:21PM +0200, Patrick McHardy wrote:
> Andreas Henriksson wrote:
> >-for (;;) {
> >+while (round < MAX_ROUNDS) {
> > if (rtnl_wilddump_request(&rth, filter.family,
> >
]>
Date: Thu Oct 18 16:06:08 2007 +0200
ss(8) manpage formatting breaks EXAMPLE
Remove not needed quotes around path which breaks manpage formatting.
Spotted and original patch by Justin Pryzby, fixed by Andreas Henriksson.
http://bugs.debian.org/443071
diff -
e ones in
the tree which doesn't come from the upstream branch and send them out...
Have a nice weekend!
--
Regards,
Andreas Henriksson
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
s
Any chance you forgot to push the tags out to the public repo?
(Which you seem to have to do explicitly in git.)
--
Regards,
Andreas Henriksson
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http:
doesn't seem to work:
git://git.kernel.org/pub/network/iproute2/iproute2.git
Using this url works though:
git://git.kernel.org/pub/scm/linux/kernel/git/shemminger/iproute2.git
(These are the urls from a previous mail you sent me Just wanted to
notify you in case something was broken with th
ug script removed)
5 - MISSING (o_key vs i_key, From: Herbert Xu)
6 - applied and REVERTED (Remove reference to tc-filters, From: Andreas Barth)
7 - MISSING (tc -batch broken lines and comments fix, From: Andreas Henriksson)
8 - applied
9 - applied
10 - dropped (broken mpath support removed)
11 - a
me, but
there's no error message...
./ip/ip is the "vanilla" and /sbin/ip is debians version.
$ sudo ./ip/ip link set skif name ""
$ echo $?
0
$ sudo /sbin/ip link set skif name ""
"" is not valid device identifier
$ echo $?
255
Reporting the error is pro
d for it then feel free to remove it.
--
Regards,
Andreas Henriksson
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
tc_core_time2big only used in tc/q_netem.c where it gets passed an unsigned.
Signed-off-by: Andreas Henriksson <[EMAIL PROTECTED]>
---
tc/tc_core.c |2 +-
tc/tc_core.h |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tc/tc_core.c b/tc/tc_core.c
index 8c3a2ac..1
tc_core_time2big only used in tc/q_netem.c where it gets passed an unsigned.
Signed-off-by: Andreas Henriksson <[EMAIL PROTECTED]>
---
tc/tc_core.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tc/tc_core.c b/tc/tc_core.c
index 8c3a2ac..1365e08 100644
--
2 variables, so this
change should be safe to make but hasn't been tested as extensively as the
time2tick patch.
Signed-off-by: Andreas Henriksson <[EMAIL PROTECTED]>
---
tc/tc_core.c |4 ++--
tc/tc_core.h |4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tc
From: Alexander Wirt <[EMAIL PROTECTED]>
Signed-off-by: Andreas Henriksson <[EMAIL PROTECTED]>
---
man/man8/ip.8 |2 ++
man/man8/tc.8 |3 ++-
2 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/man/man8/ip.8 b/man/man8/ip.8
index 153123a..8fd6d52 100644
--- a/m
The helper functions gets passed an unsigned int, which gets cast to long
and overflows. See http://bugs.debian.org/175462
Signed-off-by: Andreas Henriksson <[EMAIL PROTECTED]>
---
tc/tc_core.c |4 ++--
tc/tc_core.h |4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff -
in tc-htb(8) manpage (mininum -> minimum).
Fix typo in tc-cbq-details(8) manpage (occured -> occurred).
Signed-off-by: Andreas Henriksson <[EMAIL PROTECTED]>
---
ip/ipaddress.c|2 +-
man/man3/libnetlink.3 |2 +-
man/man8/ip.8 |2 +-
man/man8/ss
From: Alexander Wirt <[EMAIL PROTECTED]>
Add src option to route help text (http://bugs.debian.org/226142).
Add prio option to rule prio help text (http://bugs.debian.org/213673).
Signed-off-by: Andreas Henriksson <[EMAIL PROTECTED]>
---
ip/iproute.c |2 +-
ip/iprule.c |2
o be "header" and will not recognise "header". The right
symbolic values seem to be link, network, transport. Here is a patch
that changes the help/usage screen to match the code.
(http://bugs.debian.org/438653)
Signed-off-by: Andreas Henriksson <[EMAIL PROTECTED]>
---
tc/em_c
From: Herbert Xu <[EMAIL PROTECTED]>
If a dotted quad ikey is specified for GRE tunnels, it gets set as the
okey instead. This patch fixes it. (http://bugs.debian.org/200714)
Signed-off-by: Andreas Henriksson <[EMAIL PROTECTED]>
---
ip/iptunnel.c |2 +-
1 files changed, 1 inse
us:~# ip ro get to 1.2.3.4
1.2.3.4 mpath unknown dev ppp0 src 62.77.192.67
cache mtu 1492 advmss 1452 hoplimit 64
ianus:~# ip ro del 1.2.3.4 mpath wrandom nexthop dev ppp0 weight 1 nexthop dev
ppp1 weight 2
See http://bugs.debian.org/428440 for more information.
Signed-off-by: Andreas He
ichal Pokrywka <[EMAIL PROTECTED]> for testcase and information
on which conditions problem could be reproduced under.
Signed-off-by: Andreas Henriksson <[EMAIL PROTECTED]>
---
include/utils.h |2 +-
lib/utils.c |8 +---
2 files changed, 6 insertions(+), 4 deletions
41,
and http://bugs.debian.org/313544.
Signed-off-by: Andreas Henriksson <[EMAIL PROTECTED]>
---
misc/netbug | 24
1 files changed, 8 insertions(+), 16 deletions(-)
diff --git a/misc/netbug b/misc/netbug
index 6d13c8e..7b6ecea 100644
--- a/misc/netbug
+++ b/mi
From: Andreas Barth <[EMAIL PROTECTED]>
Spotted by Aleš Kozumplík <[EMAIL PROTECTED]>
(http://bugs.debian.org/289225)
Signed-off-by: Andreas Henriksson <[EMAIL PROTECTED]>
---
man/man8/tc.8 |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/man/man8/
From: Alexander Wirt <[EMAIL PROTECTED]>
Signed-off-by: Andreas Henriksson <[EMAIL PROTECTED]>
---
ip/iplink.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/ip/iplink.c b/ip/iplink.c
index 4060845..da1f64e 100644
--- a/ip/iplink.c
+++ b/ip/iplink
Symlink rtstat(8) and ctstat(8) to lnstat(8).
Add rtacct/nstat manpage based on doc/nstat.sgml as rtacct(8).
Symlink nstat(8) to rtacct(8).
Add arpd(8) symlink based on doc/arpd.sgml.
Signed-off-by: Andreas Henriksson <[EMAIL PROTECTED]>
---
Makefile |3 ++
man/man8/arpd.8
On tor, 2007-10-11 at 14:48 -0700, David Miller wrote:
> From: Andreas Henriksson <[EMAIL PROTECTED]>
> Date: Thu, 11 Oct 2007 23:22:12 +0200
>
> > Copying Alexander Wirt here again, as I think this is his patch.
>
> It is important that whoever is the package maintai
On tor, 2007-10-11 at 22:30 +0200, Patrick McHardy wrote:
> Andreas Henriksson wrote:
> > Abort flush after 10 seconds.
>
> This should be optional IMO.
Copying Alexander Wirt here again, as I think this is his patch.
I'll skip this patch in my next resend...
>
>
use 'git
> formatpatch origin'
> so all the formatting is correct.
I'm not so great with git, but I'll read up on how to do this and
hopefully resend properly tomorrow.
(I'll make sure the patch Len commented on also gets fixed by then.)
--
Regards,
Andreas Henriksson
-
On tor, 2007-10-11 at 15:25 -0400, Lennart Sorensen wrote:
> On Thu, Oct 11, 2007 at 08:25:32PM +0200, Andreas Henriksson wrote:
> > Patch from debian iproute package.
> >
> > diff -urNad iproute-20060323~/ip/iplink.c iproute-20060323/ip/iplink.c
> > --- iproute-2006032
Hello all!
Posting this set of patches again, since there where no reaction last time I
sent them.
Regards,
Andreas Henriksson
Hello Stephen Hemminger and the rest of the people on the nevdev list!
I'm posting a bunch of patches for iproute2. A few I've written myself
and hav
oute_usage.diff
ip_rule_usage.diff
patches fixing documentation typos:
fix_ss_typo.diff
ip.8-typo.diff
ip_address.diff
libnetlink_typo.diff
manpages-typo.diff
tcb_htb_typo.diff
tc_cbq_details_typo.diff
--
Regards,
Andreas Henriksson
Disallow empty link name.
From: Alexander Wirt <[EMAIL PROTECTED]&g
+ (u32)stats->tx_fifo_errors, (u32)stats->collisions,
+ (u32)(stats->tx_carrier_errors +
+ ustats->tx_aborted_errors +
stats->tx_window_errors +
- stats->tx_heartbeat_errors,
- stats-
...;
unsigned long ...;
This will be a problem when unsigned long isn't 32bits, but I guess the
rtnetlink message size is static for good reason.
Can someone please advise on how to fix this?
--
Regards,
Andreas Henriksson
-
To unsubscribe from this list: send the line "u
51 matches
Mail list logo
