Re: [PATCH 0/3] drivers/net/ethernet/amd: Follow style guide

On Sat, Feb 6, 2021 at 12:07 PM Jakub Kicinski wrote: > > On Fri, 5 Feb 2021 16:01:43 -0800 Amy Parker wrote: > > This patchset updates atarilance.c and sun3lance.c to follow the kernel > > style guide. Each patch tackles a different issue in the style guide. > > These ar

Re: [PATCH bpf-next 4/4] kbuild: Add resolve_btfids clean to root clean target

_btfids_clean > > # mrproper - Delete all generated files, including .config > # > -- > 2.26.2 > It compiles, looks good to me. Reviewed by: Amy Parker Have a great day, and thank you for this patch! -Amy IP

Re: [PATCH 0/3] drivers/net/ethernet/amd: Follow style guide

On Fri, Feb 5, 2021 at 7:16 PM Randy Dunlap wrote: > > On 2/5/21 4:01 PM, Amy Parker wrote: > > This patchset updates atarilance.c and sun3lance.c to follow the kernel > > style guide. Each patch tackles a different issue in the style guide. > > > >

[PATCH 1/3] drivers/net/ethernet/amd: Correct spacing around C keywords

Many C keywords and their statements are not formatted correctly per the kernel style guide. Their spacing makes them harder to read and to maintain. This patch updates their spacing to follow the style guide. Signed-off-by: Amy Parker --- drivers/net/ethernet/amd/atarilance.c | 36

[PATCH 2/3] drivers/net/ethernet/amd: Fix bracket matching and line levels

Some statements - often if statements - do not follow the kernel style guide regarding what lines brackets and pairs should be on. This patch fixes those style violations. Signed-off-by: Amy Parker --- drivers/net/ethernet/amd/atarilance.c | 13 + drivers/net/ethernet/amd

[PATCH 3/3] drivers/net/ethernet/amd: Break apart one-lined expressions

Some expressions using C keywords - especially if expressions - are crammed onto one line. The kernel style guide indicates not to do this, as it harms readability. This patch splits these one-lined statements into two lines. Signed-off-by: Amy Parker --- drivers/net/ethernet/amd/atarilance.c

[PATCH 0/3] drivers/net/ethernet/amd: Follow style guide

This patchset updates atarilance.c and sun3lance.c to follow the kernel style guide. Each patch tackles a different issue in the style guide. -Amy IP Amy Parker (3): drivers/net/ethernet/amd: Correct spacing around C keywords drivers/net/ethernet/amd: Fix bracket matching and line levels

Re: [PATCH net 3/4] net: ipa: use the right accessor in ipa_endpoint_status_skip()

On Mon, Feb 1, 2021 at 4:15 PM Alex Elder wrote: > > On 2/1/21 6:02 PM, Amy Parker wrote: > > On Mon, Feb 1, 2021 at 3:32 PM Alex Elder wrote: > >> > >> When extracting the destination endpoint ID from the status in > >> ipa_endpoint_status_skip(), u

Re: [PATCH net 1/4] net: ipa: add a missing __iomem attribute

read32(virt + GSI_CH_C_CNTXT_0_OFFSET(channel_id)); > -- > 2.27.0 > Seems pretty straightforward to me, ioread32 expects an __iomem-annotated pointer. Reviewed-by: Amy Parker

Re: [PATCH net 3/4] net: ipa: use the right accessor in ipa_endpoint_status_skip()

On Mon, Feb 1, 2021 at 4:02 PM Amy Parker wrote: > > Fix this by using u8_get_bits() to get the destination endpoint ID. > > Isn't > Apologies about this - premature email sending. This was simply going to be "Isn't endpoint_id u32?", which was addressed later

Re: [PATCH net 3/4] net: ipa: use the right accessor in ipa_endpoint_status_skip()

return true; > > -- > 2.27.0 > As far as I see it, using u32_get_bits instead of u8_get_bits simply eliminates confusion about the type of endpoint_id. Perhaps instead of this patch, send a patch with a comment that while u32_get_bits is used, the field is only 8 bits? Best regards, Amy Parker (she/her/hers)