Re: [PATCH] net: genetlink: Move initialization to core_initcall

2020-07-19 Thread Amit Kucheria
the generic netlink > family to the core_initcall and comes after the netlink protocol > initialization. > > Signed-off-by: Daniel Lezcano Reviewed-by: Amit Kucheria > --- > net/netlink/genetlink.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/netli

Re: [PATCH v7 08/11] thermal: Explicitly enable non-changing thermal zone devices

2020-06-29 Thread Amit Kucheria
On Mon, Jun 29, 2020 at 5:59 PM Andrzej Pietrasiewicz wrote: > > Some thermal zone devices never change their state, so they should be > always enabled. > > Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Amit Kucheria > --- > drivers/net/ethernet/chelsio/cxgb4/cxgb

Re: [PATCH v7 09/11] thermal: core: Stop polling DISABLED thermal devices

2020-06-29 Thread Amit Kucheria
led or not. > > Signed-off-by: Andrzej Pietrasiewicz > Reviewed-by: Bartlomiej Zolnierkiewicz Reviewed-by: Amit Kucheria > --- > drivers/thermal/thermal_core.c | 16 ++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/t

Re: [PATCH v7 10/11] thermal: Simplify or eliminate unnecessary set_mode() methods

2020-06-29 Thread Amit Kucheria
only prints debug messages. > > Signed-off-by: Andrzej Pietrasiewicz > [for acerhdf] > Acked-by: Peter Kaestle > Reviewed-by: Bartlomiej Zolnierkiewicz Reviewed-by: Amit Kucheria > --- > drivers/acpi/thermal.c| 26 > .../ethe

Re: [PATCH v5 01/11] acpi: thermal: Fix error handling in the register function

2020-06-29 Thread Amit Kucheria
On Fri, Jun 26, 2020 at 11:08 PM Andrzej Pietrasiewicz wrote: > > The acpi_thermal_register_thermal_zone() is missing any error handling. > This needs to be fixed. > > Signed-off-by: Andrzej Pietrasiewicz > Reviewed-by: Guenter Roeck > Reviewed-by: Bartlomiej Zolnierkiewic

Re: [PATCH v5 05/11] thermal: remove get_mode() operation of drivers

2020-06-29 Thread Amit Kucheria
from struct tzd. > > Signed-off-by: Andrzej Pietrasiewicz > [for acerhdf] > Acked-by: Peter Kaestle > Reviewed-by: Bartlomiej Zolnierkiewicz Reviewed-by: Amit Kucheria > --- > drivers/acpi/thermal.c| 9 -- > .../ethernet/mellanox/mlxsw/cor

Re: [PATCH v5 02/11] thermal: Store thermal mode in a dedicated enum

2020-06-29 Thread Amit Kucheria
On Fri, Jun 26, 2020 at 11:08 PM Andrzej Pietrasiewicz wrote: > > Prepare for storing mode in struct thermal_zone_device. > > Signed-off-by: Andrzej Pietrasiewicz > Reviewed-by: Guenter Roeck > [for acerhdf] > Acked-by: Peter Kaestle > Reviewed-by: Bartlomiej Zolnierkie

Re: [PATCH v5 04/11] thermal: Store device mode in struct thermal_zone_device

2020-06-29 Thread Amit Kucheria
On Fri, Jun 26, 2020 at 11:08 PM Andrzej Pietrasiewicz wrote: > > Prepare for eliminating get_mode(). > > Signed-off-by: Andrzej Pietrasiewicz > [for acerhdf] > Acked-by: Peter Kaestle > Reviewed-by: Bartlomiej Zolnierkiewicz Reviewed-by: Amit Kucheria > --- &

Re: [PATCH v5 03/11] thermal: Add current mode to thermal zone device

2020-06-29 Thread Amit Kucheria
e > get_mode() methods will become redundant. > > Signed-off-by: Andrzej Pietrasiewicz > Reviewed-by: Guenter Roeck > Reviewed-by: Bartlomiej Zolnierkiewicz Reviewed-by: Amit Kucheria > --- > include/linux/thermal.h | 2 ++ > 1 file changed, 2 insertions(+) > &

Re: [PATCH v5 06/11] thermal: Add mode helpers

2020-06-29 Thread Amit Kucheria
On Fri, Jun 26, 2020 at 11:08 PM Andrzej Pietrasiewicz wrote: > > Prepare for making the drivers not access tzd's private members. > > Signed-off-by: Andrzej Pietrasiewicz > Reviewed-by: Bartlomiej Zolnierkiewicz > [EXPORT_SYMBOL -> EXPORT_SYMBOL_GPL] > Signed-off-by: Andrzej Pietrasiewicz > --

Re: [PATCH v7 07/11] thermal: Use mode helpers in drivers

2020-06-29 Thread Amit Kucheria
d in thermal_zone_device_set_mode(). > - thermal/of-thermal.c: no need to set zone->mode to DISABLED in > of_parse_thermal_zones() as a tzd is kzalloc'ed so mode is DISABLED anyway > > Signed-off-by: Andrzej Pietrasiewicz > [for acerhdf] > Acked-by: Peter Kaest

Re: [PATCH v7 11/11] thermal: Rename set_mode() to change_mode()

2020-06-29 Thread Amit Kucheria
about > the mode being changed and giving the driver a chance to oppose such > change. > > To better reflect the purpose of the method rename it to change_mode() > > Signed-off-by: Andrzej Pietrasiewicz > [for acerhdf] > Acked-by: Peter Kaestle > Reviewed-by: Bartlomiej

Re: [PATCH] net: stmmac: fix num_por initialization

2020-05-13 Thread Amit Kucheria
olds por and num_por values and populate > that in driver probe. > > Fixes: a7c30e62d4b8 ("net: stmmac: Add driver for Qualcomm ethqos") > Reported-by: Rahul Ankushrao Kawadgave > Signed-off-by: Vinod Koul Otherwise, Reviewed-by: Amit Kucheria > --- > .../ether

Re: [linux-pm] [RFC] Runtime power management on ipw2100

2007-01-31 Thread Amit Kucheria
On Wed, 2007-01-31 at 14:04 +0100, ext Pavel Machek wrote: > On Wed 2007-01-31 13:53:20, Amit Kucheria wrote: > > > > Yes. Low power states without ability to respond to wakeup interrupts > > would be broken behaviour generally. > > Do you realy expect wifi to save s

Re: [linux-pm] [RFC] Runtime power management on ipw2100

2007-01-31 Thread Amit Kucheria
On Wed, 2007-01-31 at 11:48 +0100, ext Andi Kleen wrote: > On Wednesday 31 January 2007 11:27, Matthew Garrett wrote: > > On Wed, Jan 31, 2007 at 12:13:04PM +0100, Andi Kleen wrote: > > > Matthew Garrett <[EMAIL PROTECTED]> writes: > > > > > > > > PCI seems to require a delay of 10ms when sequenci

Re: [linux-pm] [RFC] Runtime power management on ipw2100

2007-01-31 Thread Amit Kucheria
On Wed, 2007-01-31 at 09:48 +, ext Matthew Garrett wrote: > On Wed, Jan 31, 2007 at 11:13:07AM +0200, Amit Kucheria wrote: > > > What is the latency in changing between different PCI power states for > > peripherals? > > I'm not sure in the general case, bu

Re: [linux-pm] [RFC] Runtime power management on ipw2100

2007-01-31 Thread Amit Kucheria
On Wed, 2007-01-31 at 07:52 +, ext Matthew Garrett wrote: > Based on previous discussions, I've implemented a rough attempt at > providing some level of basic runtime power management on the ipw2100 > chipset. This patch does the following: > > 1) On load, it initialises the hardware and the