Re: [PATCH v3 2/2] net: usb: asix88179_178a: de-duplicate code

2018-04-02 Thread Alexander Kurz
Hi Marc, David, with the v2 patch ("net: usb: asix88179_178a: de-duplicate code") I made an embarrasly stupid mistake of removing the wrong function. The v2 patch accidentially changed ax88179_link_reset() instead of ax88179_reset(). Hunk 6 of v2 ("net: usb: asix88179_178a: de-duplicate code") is

[PATCH v3 1/2] net: usb: asix88179_178a: set permanent address once only

2018-04-02 Thread Alexander Kurz
The permanent address of asix88179_178a devices is read at probe time and should not be overwritten later. Otherwise it may be overwritten unintentionally with a configured address. Signed-off-by: Alexander Kurz --- drivers/net/usb/ax88179_178a.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH v3 2/2] net: usb: asix88179_178a: de-duplicate code

2018-04-02 Thread Alexander Kurz
Remove the duplicated code for asix88179_178a bind and reset methods. Signed-off-by: Alexander Kurz --- drivers/net/usb/ax88179_178a.c | 137 ++--- 1 file changed, 31 insertions(+), 106 deletions(-) diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net

[PATCH v2 2/2] net: usb: asix88179_178a: de-duplicate code

2018-03-08 Thread Alexander Kurz
Remove the duplicated code for asix88179_178a bind and reset methods. Signed-off-by: Alexander Kurz --- drivers/net/usb/ax88179_178a.c | 117 +++-- 1 file changed, 31 insertions(+), 86 deletions(-) diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net

[PATCH v2 1/2] net: usb: asix88179_178a: set permanent address once only

2018-03-08 Thread Alexander Kurz
The permanent address of asix88179_178a devices is read at probe time and should not be overwritten later. Otherwise it may be overwritten unintentionally with a configured address. Signed-off-by: Alexander Kurz --- drivers/net/usb/ax88179_178a.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 2/2] net: usb: asix88179_178a: de-duplicate code

2018-02-28 Thread Alexander Kurz
Remove the duplicated code for asix88179_178a bind and reset methods. Signed-off-by: Alexander Kurz --- drivers/net/usb/ax88179_178a.c | 117 +++-- 1 file changed, 31 insertions(+), 86 deletions(-) diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net

[PATCH 1/2] net: usb: asix88179_178a: set permanent address once only

2018-02-28 Thread Alexander Kurz
The permanent address of asix88179_178a devices is read at probe time and should not be overwritten later. Otherwise it may be overwritten unintentionally with a configured address. Signed-off-by: Alexander Kurz --- drivers/net/usb/ax88179_178a.c | 1 - 1 file changed, 1 deletion(-) diff --git