Re: Fwd: [PATCH] bonding/802.3ad: fix slave initialization states race

2019-10-22 Thread Aleksei Zakharov
9142..d416af72404b 100644 > --- a/include/net/bonding.h > +++ b/include/net/bonding.h > @@ -159,7 +159,6 @@ struct slave { > unsigned long target_last_arp_rx[BOND_MAX_ARP_TARGETS]; > s8 link;/* one of BOND_LINK_ */ > s8 link_new_state; /* one of BOND_LINK_ */ > - s8 new_link; > u8 backup:1, /* indicates backup slave. Value corresponds with > BOND_STATE_ACTIVE and BOND_STATE_BACKUP */ >inactive:1, /* indicates inactive slave */ > @@ -549,7 +548,7 @@ static inline void bond_propose_link_state(struct slave > *slave, int state) > > static inline void bond_commit_link_state(struct slave *slave, bool notify) > { > - if (slave->link == slave->link_new_state) > + if (slave->link_new_state == BOND_LINK_NOCHANGE) > return; > > slave->link = slave->link_new_state; > > > --- > -Jay Vosburgh, jay.vosbu...@canonical.com Hi! As we haven't found any issues with this patch it seems to work fine. Will this patch be applied on net-next? -- Best Regards, Aleksei Zakharov System administrator

Re: Fwd: [PATCH] bonding/802.3ad: fix slave initialization states race

2019-09-27 Thread Aleksei Zakharov
чт, 26 сент. 2019 г. в 23:01, Jay Vosburgh : > > Aleksei Zakharov wrote: > > >чт, 26 сент. 2019 г. в 07:38, Jay Vosburgh : > >> > >> Aleksei Zakharov wrote: > >> > >> >ср, 25 сент. 2019 г. в 03:31, Jay Vosburgh : > >> >> >

Re: Fwd: [PATCH] bonding/802.3ad: fix slave initialization states race

2019-09-26 Thread Aleksei Zakharov
чт, 26 сент. 2019 г. в 07:38, Jay Vosburgh : > > Aleksei Zakharov wrote: > > >ср, 25 сент. 2019 г. в 03:31, Jay Vosburgh : > >> > >> Алексей Захаров wrote: > >> [...] > >> >Right after reboot one of the slaves hangs with actor port state 71

Re: Fwd: [PATCH] bonding/802.3ad: fix slave initialization states race

2019-09-25 Thread Aleksei Zakharov
*XXX*/slave_info(bond_dev, slave_dev, "EVENT %lu llu %lu\n", event, > slave->last_link_up); > if (bond_update_speed_duplex(slave) && > BOND_MODE(bond) == BOND_MODE_8023AD) { > if (slave->last_link_up) >

[PATCH] bonding/802.3ad: fix slave initialization states race

2019-09-18 Thread Aleksei Zakharov
bonding/802.3ad: fix slave link initialization transition states") Signed-off-by: Aleksei Zakharov --- drivers/net/bonding/bond_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 931d9d935686..a28776d8f