[PATCH] net: wireless: search and hold bss in cfg80211_connect_done

2021-03-16 Thread Abhishek Kumar
to be triggered and cause cascading failures. To mitigate this, initiate a get bss call in cfg80211_connect_done itself and hold it to ensure that the BSS instance does not get expired. Signed-off-by: Abhishek Kumar --- net/wireless/sme.c | 21 + 1 file changed, 13 insertions

Re: [PATCH v3] ath10k: skip the wait for completion to recovery in shutdown path

2021-03-02 Thread Abhishek Kumar
This patch seems to address the comments on v2. Overall this patch LGTM. Reviewed-by: Abhishek Kumar On Tue, Feb 23, 2021 at 6:29 AM Youghandhar Chintala wrote: > > Currently in the shutdown callback we wait for recovery to complete > before freeing up the resources. This results in a

Re: [PATCH 1/3] cfg80211: Add wiphy flag to trigger STA disconnect after hardware restart

2021-02-05 Thread Abhishek Kumar
LGTM! If no one has any objections, I would be happy to see this considered for upstream. Reviewed-by: Abhishek Kumar Thanks Abhishek On Tue, Dec 15, 2020 at 9:30 AM Youghandhar Chintala wrote: > > Many wifi drivers (e.g. ath10k using qualcomm wifi chipsets) > support silent target

Re: [PATCH 3/3] ath10k: Set wiphy flag to trigger sta disconnect on hardware restart

2021-02-05 Thread Abhishek Kumar
ws are, or atleast what are the challenges. As you said the task is much bigger with so many firmware branches. As long as you feel it is scalable for coming years, we should be good. As far as the patch is concerned, it LGTM. Reviewed-by: Abhishek Kumar Thanks Abhishek

Re: [PATCH 2/3] mac80211: Add support to trigger sta disconnect on hardware restart

2021-02-05 Thread Abhishek Kumar
Since using DELBA frame to APs to re-establish BA session has a dependency on APs and also some APs may not honour the DELBA frame. I am fine with having the disconnect/reconnect solution. The change looks good to me. Reviewed-by: Abhishek Kumar Thanks Abhishek On Thu, Jan 28, 2021 at 12:08 AM

Re: [PATCH 3/3] ath10k: Set wiphy flag to trigger sta disconnect on hardware restart

2020-12-22 Thread Abhishek Kumar
On Tue, Dec 15, 2020 at 9:24 AM Youghandhar Chintala wrote: > > From: Rakesh Pillai > > Currently after the hardware restart triggered from the driver, > the station interface connection remains intact, since a disconnect > trigger is not sent to userspace. This can lead to a problem in > hardwar

[PATCH v3] ath10k: add option for chip-id based BDF selection

2020-12-07 Thread Abhishek Kumar
d=320' Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.2.2-00696-QCAHLSWMTPL-1 Tested-on: QCA6174 HW3.2 WLAN.RM.4.4.1-00157-QCARMSWPZ-1 Signed-off-by: Abhishek Kumar --- Changes in v3: - Resurreted Patch V1 because as per discussion we do need two fallback board names and

Re: [PATCH v2 1/1] ath10k: add option for chip-id based BDF selection

2020-12-07 Thread Abhishek Kumar
Hi, > > (no changes since v1) > > I think you need to work on the method you're using to generate your > patches. There are most definitely changes since v1. You described > them in your cover letter (which you don't really need for a singleton > patch) instead of here. I agree, this was not int

[PATCH v2 1/1] ath10k: add option for chip-id based BDF selection

2020-11-12 Thread Abhishek Kumar
d=320' Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.2.2-00696-QCAHLSWMTPL-1 Tested-on: QCA6174 HW3.2 WLAN.RM.4.4.1-00157-QCARMSWPZ-1 Signed-off-by: Abhishek Kumar --- (no changes since v1) drivers/net/wireless/ath/ath10k/core.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-)

[PATCH v2 0/1] This patch address comments on patch v1

2020-11-12 Thread Abhishek Kumar
This patch extends ath10k_core_create_board_name function to support chip id based BDF selection and not add provision for fallback_boardname2, thus introducing lesser lines of code. (no changes since v1) Abhishek Kumar (1): ath10k: add option for chip-id based BDF selection drivers/net