[PATCH net v2] virtio-net: don't re-enable refill work too early when NAPI is disabled

2025-04-30 Thread Jakub Kicinski
Commit 4bc12818b363 ("virtio-net: disable delayed refill when pausing rx") fixed a deadlock between reconfig paths and refill work trying to disable the same NAPI instance. The refill work can't run in parallel with reconfig because trying to double-disable a NAPI instance causes a stall under the

[PATCH net v2] virtio-net: free xsk_buffs on error in virtnet_xsk_pool_enable()

2025-04-30 Thread Jakub Kicinski
The selftests added to our CI by Bui Quang Minh recently reveals that there is a mem leak on the error path of virtnet_xsk_pool_enable(): unreferenced object 0x88800a68a000 (size 2048): comm "xdp_helper", pid 318, jiffies 4294692778 hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 00

Re: [PATCH net] virtio-net: don't re-enable refill work too early when NAPI is disabled

2025-04-30 Thread Jakub Kicinski
On Wed, 30 Apr 2025 01:29:06 -0400 Michael S. Tsirkin wrote: > > > @@ -3728,7 +3731,7 @@ static int virtnet_set_queues(struct virtnet_info > > > *vi, u16 queue_pairs) > > > succ: > > > vi->curr_queue_pairs = queue_pairs; > > > /* virtnet_open() will refill when device is going to

Re: [PATCH net] virtio-net: free xsk_buffs on error in virtnet_xsk_pool_enable()

2025-04-30 Thread Simon Horman
On Tue, Apr 29, 2025 at 09:43:23AM -0700, Jakub Kicinski wrote: > The selftests added to our CI by Bui Quang Minh recently reveals > that there is a mem leak on the error path of virtnet_xsk_pool_enable(): > > unreferenced object 0x88800a68a000 (size 2048): > comm "xdp_helper", pid 318, jiff