Re: [PATCH net] virtio-net: don't re-enable refill work too early when NAPI is disabled

On Wed, Apr 30, 2025 at 11:49:15AM +0800, Jason Wang wrote: > On Tue, Apr 29, 2025 at 10:31 PM Jakub Kicinski wrote: > > > > Commit 4bc12818b363 ("virtio-net: disable delayed refill when pausing rx") > > fixed a deadlock between reconfig paths and refill work trying to disable > > the same NAPI in

Re: [PATCH net] virtio-net: don't re-enable refill work too early when NAPI is disabled

On Tue, Apr 29, 2025 at 07:31:04AM -0700, Jakub Kicinski wrote: > Commit 4bc12818b363 ("virtio-net: disable delayed refill when pausing rx") > fixed a deadlock between reconfig paths and refill work trying to disable > the same NAPI instance. The refill work can't run in parallel with reconfig > be

Re: [PATCH net] virtio-net: don't re-enable refill work too early when NAPI is disabled

On Tue, Apr 29, 2025 at 10:31 PM Jakub Kicinski wrote: > > Commit 4bc12818b363 ("virtio-net: disable delayed refill when pausing rx") > fixed a deadlock between reconfig paths and refill work trying to disable > the same NAPI instance. The refill work can't run in parallel with reconfig > because

Re: [PATCH net] virtio-net: free xsk_buffs on error in virtnet_xsk_pool_enable()

On Wed, Apr 30, 2025 at 12:43 AM Jakub Kicinski wrote: > > The selftests added to our CI by Bui Quang Minh recently reveals > that there is a mem leak on the error path of virtnet_xsk_pool_enable(): > > unreferenced object 0x88800a68a000 (size 2048): > comm "xdp_helper", pid 318, jiffies 429

[PATCH net] virtio-net: free xsk_buffs on error in virtnet_xsk_pool_enable()

The selftests added to our CI by Bui Quang Minh recently reveals that there is a mem leak on the error path of virtnet_xsk_pool_enable(): unreferenced object 0x88800a68a000 (size 2048): comm "xdp_helper", pid 318, jiffies 4294692778 hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 00

Re: [PATCH net] virtio-net: don't re-enable refill work too early when NAPI is disabled

On 4/29/25 21:31, Jakub Kicinski wrote: Commit 4bc12818b363 ("virtio-net: disable delayed refill when pausing rx") fixed a deadlock between reconfig paths and refill work trying to disable the same NAPI instance. The refill work can't run in parallel with reconfig because trying to double-disable

[PATCH net] virtio-net: don't re-enable refill work too early when NAPI is disabled

Commit 4bc12818b363 ("virtio-net: disable delayed refill when pausing rx") fixed a deadlock between reconfig paths and refill work trying to disable the same NAPI instance. The refill work can't run in parallel with reconfig because trying to double-disable a NAPI instance causes a stall under the