Re: [PATCH net-next 03/13] virtio_ring: packed: harden dma unmap for indirect

2024-09-11 Thread Xuan Zhuo
On Wed, 11 Sep 2024 07:28:36 -0400, "Michael S. Tsirkin" wrote: > As gcc luckily noted: > > On Tue, Aug 20, 2024 at 03:33:20PM +0800, Xuan Zhuo wrote: > > @@ -1617,23 +1617,24 @@ static void detach_buf_packed(struct > > vring_virtqueue *vq, > > } > > > > if (vq->indirect) { > > +

Re: [PATCH 0/3] Revert "virtio_net: rx enable premapped mode by default"

2024-09-11 Thread Xuan Zhuo
On Wed, 11 Sep 2024 12:30:49 -0700, "Si-Wei Liu" wrote: > > > On 9/11/2024 7:22 AM, Michael S. Tsirkin wrote: > > Thanks a lot! > > Could you retest Xuan Zhuo original patch > Which one? I thought Darren already did so? This one[1]. Now, we revert these patches to disable premapped mode by defa

Re: [PATCH 0/3] Revert "virtio_net: rx enable premapped mode by default"

2024-09-11 Thread Si-Wei Liu
On 9/11/2024 7:22 AM, Michael S. Tsirkin wrote: Thanks a lot! Could you retest Xuan Zhuo original patch Which one? I thought Darren already did so? -Siwei just to make sure it does not fix the issue? On Wed, Sep 11, 2024 at 03:18:55PM +0100, Darren Kenny wrote: For the record, I got a c

Re: [PATCH 0/3] Revert "virtio_net: rx enable premapped mode by default"

2024-09-11 Thread Michael S. Tsirkin
Thanks a lot! Could you retest Xuan Zhuo original patch just to make sure it does not fix the issue? On Wed, Sep 11, 2024 at 03:18:55PM +0100, Darren Kenny wrote: > For the record, I got a chance to test these changes and confirmed that > they resolved the issue for me when applied on 6.11-rc7. >

Re: [PATCH 0/3] Revert "virtio_net: rx enable premapped mode by default"

2024-09-11 Thread Darren Kenny
For the record, I got a chance to test these changes and confirmed that they resolved the issue for me when applied on 6.11-rc7. Tested-by: Darren Kenny Thanks, Darren. PS - I'll try get to looking at the other potential fix when I have time. On Tuesday, 2024-09-10 at 08:12:06 -04, Michael S.

Re: [PATCH net-next 03/13] virtio_ring: packed: harden dma unmap for indirect

2024-09-11 Thread Michael S. Tsirkin
As gcc luckily noted: On Tue, Aug 20, 2024 at 03:33:20PM +0800, Xuan Zhuo wrote: > @@ -1617,23 +1617,24 @@ static void detach_buf_packed(struct vring_virtqueue > *vq, > } > > if (vq->indirect) { > + struct vring_desc_extra *extra; > u32 len; > >

Re: [PATCH net-next 02/13] virtio_ring: split: harden dma unmap for indirect

2024-09-11 Thread Michael S. Tsirkin
On Wed, Sep 11, 2024 at 11:46:30AM +0800, Jason Wang wrote: > On Tue, Aug 20, 2024 at 3:33 PM Xuan Zhuo wrote: > > > > 1. this commit hardens dma unmap for indirect > > I think we need to explain why we need such hardening. yes pls be more specific. Recording same state in two places is just a