Re: [PATCH net-next 13/13] virtio_net: xdp_features add NETDEV_XDP_ACT_XSK_ZEROCOPY

On Tue, Aug 20, 2024 at 3:33 PM Xuan Zhuo wrote: > > Now, we supported AF_XDP(xsk). Add NETDEV_XDP_ACT_XSK_ZEROCOPY to Should be "support". > xdp_features. > > Signed-off-by: Xuan Zhuo Other than this. Acked-by: Jason Wang Thanks

Re: [PATCH net-next 11/13] virtio_net: xsk: tx: handle the transmitted xsk buffer

On Tue, Aug 20, 2024 at 3:34 PM Xuan Zhuo wrote: > > virtnet_free_old_xmit distinguishes three type ptr(skb, xdp frame, xsk > buffer) by the last bits of the pointer. > > Signed-off-by: Xuan Zhuo I suggest squashing this into the previous patch which looks more logical and complete. Thanks

Re: [PATCH net-next 10/13] virtio_net: xsk: tx: support xmit xsk buffer

On Tue, Aug 20, 2024 at 3:33 PM Xuan Zhuo wrote: > > The driver's tx napi is very important for XSK. It is responsible for > obtaining data from the XSK queue and sending it out. > > At the beginning, we need to trigger tx napi. > > Signed-off-by: Xuan Zhuo > --- > drivers/net/virtio_net.c | 127

Re: [PATCH net-next 08/13] virtio_net: xsk: bind/unbind xsk for tx

On Tue, Aug 20, 2024 at 3:33 PM Xuan Zhuo wrote: > > This patch implement the logic of bind/unbind xsk pool to sq and rq. > > Signed-off-by: Xuan Zhuo > --- > drivers/net/virtio_net.c | 54 > 1 file changed, 54 insertions(+) > > diff --git a/drivers/net/v

Re: [PATCH net-next 07/13] virtio_net: refactor the xmit type

On Tue, Aug 20, 2024 at 3:33 PM Xuan Zhuo wrote: > > Because the af-xdp will introduce a new xmit type, so I refactor the > xmit type mechanism first. > > We use the last two bits of the pointer to distinguish the xmit type, > so we can distinguish four xmit types. Now we have three types: skb, >

Re: [PATCH net-next 04/13] virtio_ring: perform premapped operations based on per-buffer

On Tue, Aug 20, 2024 at 3:33 PM Xuan Zhuo wrote: > > The current configuration sets the virtqueue (vq) to premapped mode, > implying that all buffers submitted to this queue must be mapped ahead > of time. This presents a challenge for the virtnet send queue (sq): the > virtnet driver would be req

Re: [PATCH net-next 02/13] virtio_ring: split: harden dma unmap for indirect

On Tue, Aug 20, 2024 at 3:33 PM Xuan Zhuo wrote: > > 1. this commit hardens dma unmap for indirect I think we need to explain why we need such hardening. For example indirect use stream mapping which is read-only from the device. So it looks to me like it doesn't require hardening by itself. > 2

Re: [PATCH 0/3] Revert "virtio_net: rx enable premapped mode by default"

Hello: This series was applied to netdev/net.git (main) by Jakub Kicinski : On Fri, 6 Sep 2024 20:31:34 +0800 you wrote: > Regression: > http://lore.kernel.org/all/8b20cc28-45a9-4643-8e87-ba164a540...@oracle.com > > I still think that the patch can fix the problem, I hope Darren can re-test it

Re: [PATCH 0/3] Revert "virtio_net: rx enable premapped mode by default"

On Tue, 10 Sep 2024 08:12:06 -0400 Michael S. Tsirkin wrote: > Just making sure netdev maintainers see this, this patch is for net. Got it, thanks! I'll be applying it shortly.

Re: [PATCH 0/3] Revert "virtio_net: rx enable premapped mode by default"

On Fri, Sep 06, 2024 at 08:31:34PM +0800, Xuan Zhuo wrote: > Regression: > http://lore.kernel.org/all/8b20cc28-45a9-4643-8e87-ba164a540...@oracle.com > > I still think that the patch can fix the problem, I hope Darren can re-test it > or give me more info. > > > http://lore.kernel.org/all/2

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

On Tue, 10 Sep 2024 14:18:37 +0800, Jason Wang wrote: > On Mon, Sep 9, 2024 at 4:50 PM Xuan Zhuo wrote: > > > > On Mon, 9 Sep 2024 16:38:16 +0800, Jason Wang wrote: > > > On Fri, Sep 6, 2024 at 5:32 PM Xuan Zhuo > > > wrote: > > > > > > > > On Fri, 6 Sep 2024 05:08:56 -0400, "Michael S. Tsirki