Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-08 Thread Xuan Zhuo
On Sun, 8 Sep 2024 15:40:32 -0400, "Michael S. Tsirkin" wrote: > On Tue, Aug 20, 2024 at 03:19:13PM +0800, Xuan Zhuo wrote: > > leads to regression on VM with the sysctl value of: > > > > - net.core.high_order_alloc_disable=1 > > > > which could see reliable crashes or scp failure (scp a file 100M

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-08 Thread Michael S. Tsirkin
On Tue, Aug 20, 2024 at 03:19:13PM +0800, Xuan Zhuo wrote: > leads to regression on VM with the sysctl value of: > > - net.core.high_order_alloc_disable=1 > > which could see reliable crashes or scp failure (scp a file 100M in size > to VM): > > The issue is that the virtnet_rq_dma takes up 16 b

Re: [PATCH 0/3] Revert "virtio_net: rx enable premapped mode by default"

2024-09-08 Thread Michael S. Tsirkin
On Fri, Sep 06, 2024 at 08:31:34PM +0800, Xuan Zhuo wrote: > Regression: > http://lore.kernel.org/all/8b20cc28-45a9-4643-8e87-ba164a540...@oracle.com > > I still think that the patch can fix the problem, I hope Darren can re-test it > or give me more info. > > > http://lore.kernel.org/all/2

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-08 Thread Takero Funaki
2024年9月8日(日) 19:19 Michael S. Tsirkin : > > On Sat, Sep 07, 2024 at 12:16:24PM +0900, Takero Funaki wrote: > > 2024年9月6日(金) 18:55 Michael S. Tsirkin : > > > > > > On Fri, Sep 06, 2024 at 05:46:02PM +0800, Xuan Zhuo wrote: > > > > On Fri, 6 Sep 2024 05:44:27 -0400, "Michael S. Tsirkin" > > > > wro

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-08 Thread Michael S. Tsirkin
On Sat, Sep 07, 2024 at 12:16:24PM +0900, Takero Funaki wrote: > 2024年9月6日(金) 18:55 Michael S. Tsirkin : > > > > On Fri, Sep 06, 2024 at 05:46:02PM +0800, Xuan Zhuo wrote: > > > On Fri, 6 Sep 2024 05:44:27 -0400, "Michael S. Tsirkin" > > > wrote: > > > > On Fri, Sep 06, 2024 at 05:25:36PM +0800,