Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-06 Thread Takero Funaki
2024年9月6日(金) 18:55 Michael S. Tsirkin : > > On Fri, Sep 06, 2024 at 05:46:02PM +0800, Xuan Zhuo wrote: > > On Fri, 6 Sep 2024 05:44:27 -0400, "Michael S. Tsirkin" > > wrote: > > > On Fri, Sep 06, 2024 at 05:25:36PM +0800, Xuan Zhuo wrote: > > > > On Fri, 6 Sep 2024 05:08:56 -0400, "Michael S. Tsi

[PATCH 1/3] Revert "virtio_net: rx remove premapped failover code"

2024-09-06 Thread Xuan Zhuo
This reverts commit defd28aa5acb0fd7c15adc6bc40a8ac277d04dea. Recover the code to disable premapped mode. Signed-off-by: Xuan Zhuo --- drivers/net/virtio_net.c | 85 +++- 1 file changed, 50 insertions(+), 35 deletions(-) diff --git a/drivers/net/virtio_net.c

[PATCH 3/3] virtio_net: disable premapped mode by default

2024-09-06 Thread Xuan Zhuo
Now, the premapped mode encounters some problem. http://lore.kernel.org/all/8b20cc28-45a9-4643-8e87-ba164a540...@oracle.com So we disable the premapped mode by default. We can re-enable it in the future. Fixes: f9dac92ba908 ("virtio_ring: enable premapped mode whatever use_dma_api") Reported

[PATCH 2/3] Revert "virtio_net: big mode skip the unmap check"

2024-09-06 Thread Xuan Zhuo
This reverts commit a377ae542d8d0a20a3173da3bbba72e045bea7a9. Signed-off-by: Xuan Zhuo --- drivers/net/virtio_net.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 36a7781979b7..b68e64e8c7b6 100644 --- a/drivers/ne

[PATCH 0/3] Revert "virtio_net: rx enable premapped mode by default"

2024-09-06 Thread Xuan Zhuo
Regression: http://lore.kernel.org/all/8b20cc28-45a9-4643-8e87-ba164a540...@oracle.com I still think that the patch can fix the problem, I hope Darren can re-test it or give me more info. http://lore.kernel.org/all/20240820071913.68004-1-xuanz...@linux.alibaba.com If that can not work or Da

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-06 Thread Michael S. Tsirkin
On Fri, Sep 06, 2024 at 05:46:02PM +0800, Xuan Zhuo wrote: > On Fri, 6 Sep 2024 05:44:27 -0400, "Michael S. Tsirkin" > wrote: > > On Fri, Sep 06, 2024 at 05:25:36PM +0800, Xuan Zhuo wrote: > > > On Fri, 6 Sep 2024 05:08:56 -0400, "Michael S. Tsirkin" > > > wrote: > > > > On Fri, Sep 06, 2024 at

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-06 Thread Xuan Zhuo
On Fri, 6 Sep 2024 05:44:27 -0400, "Michael S. Tsirkin" wrote: > On Fri, Sep 06, 2024 at 05:25:36PM +0800, Xuan Zhuo wrote: > > On Fri, 6 Sep 2024 05:08:56 -0400, "Michael S. Tsirkin" > > wrote: > > > On Fri, Sep 06, 2024 at 04:53:38PM +0800, Xuan Zhuo wrote: > > > > On Fri, 6 Sep 2024 04:43:29

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-06 Thread Michael S. Tsirkin
On Fri, Sep 06, 2024 at 05:25:36PM +0800, Xuan Zhuo wrote: > On Fri, 6 Sep 2024 05:08:56 -0400, "Michael S. Tsirkin" > wrote: > > On Fri, Sep 06, 2024 at 04:53:38PM +0800, Xuan Zhuo wrote: > > > On Fri, 6 Sep 2024 04:43:29 -0400, "Michael S. Tsirkin" > > > wrote: > > > > On Tue, Aug 20, 2024 at

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-06 Thread Xuan Zhuo
On Fri, 6 Sep 2024 05:08:56 -0400, "Michael S. Tsirkin" wrote: > On Fri, Sep 06, 2024 at 04:53:38PM +0800, Xuan Zhuo wrote: > > On Fri, 6 Sep 2024 04:43:29 -0400, "Michael S. Tsirkin" > > wrote: > > > On Tue, Aug 20, 2024 at 03:19:13PM +0800, Xuan Zhuo wrote: > > > > leads to regression on VM wi

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-06 Thread Michael S. Tsirkin
On Fri, Sep 06, 2024 at 04:53:38PM +0800, Xuan Zhuo wrote: > On Fri, 6 Sep 2024 04:43:29 -0400, "Michael S. Tsirkin" > wrote: > > On Tue, Aug 20, 2024 at 03:19:13PM +0800, Xuan Zhuo wrote: > > > leads to regression on VM with the sysctl value of: > > > > > > - net.core.high_order_alloc_disable=1

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-06 Thread Xuan Zhuo
On Fri, 6 Sep 2024 04:43:29 -0400, "Michael S. Tsirkin" wrote: > On Tue, Aug 20, 2024 at 03:19:13PM +0800, Xuan Zhuo wrote: > > leads to regression on VM with the sysctl value of: > > > > - net.core.high_order_alloc_disable=1 > > > > which could see reliable crashes or scp failure (scp a file 100M

Re: [PATCH net] virtio-net: fix overflow inside virtnet_rq_alloc

2024-09-06 Thread Michael S. Tsirkin
On Tue, Aug 20, 2024 at 03:19:13PM +0800, Xuan Zhuo wrote: > leads to regression on VM with the sysctl value of: > > - net.core.high_order_alloc_disable=1 > > which could see reliable crashes or scp failure (scp a file 100M in size > to VM): > > The issue is that the virtnet_rq_dma takes up 16 b