Re: [PATCH net] virtio_net: move netdev_tx_reset_queue() call before RX napi enable

2024-08-14 Thread Jason Wang
On Wed, Aug 14, 2024 at 8:29 PM Michael S. Tsirkin wrote: > > On Wed, Aug 14, 2024 at 02:25:00PM +0200, Jiri Pirko wrote: > > From: Jiri Pirko > > > > During suspend/resume the following BUG was hit: > > [ cut here ] > > kernel BUG at lib/dynamic_queue_limits.c:99! > > Int

Re: [PATCH net] virtio_net: move netdev_tx_reset_queue() call before RX napi enable

2024-08-14 Thread Michael S. Tsirkin
On Wed, Aug 14, 2024 at 02:25:00PM +0200, Jiri Pirko wrote: > From: Jiri Pirko > > During suspend/resume the following BUG was hit: > [ cut here ] > kernel BUG at lib/dynamic_queue_limits.c:99! > Internal error: Oops - BUG: 0 [#1] SMP ARM > Modules linked in: bluetooth ecd

[PATCH net] virtio_net: move netdev_tx_reset_queue() call before RX napi enable

2024-08-14 Thread Jiri Pirko
From: Jiri Pirko During suspend/resume the following BUG was hit: [ cut here ] kernel BUG at lib/dynamic_queue_limits.c:99! Internal error: Oops - BUG: 0 [#1] SMP ARM Modules linked in: bluetooth ecdh_generic ecc libaes CPU: 1 PID: 1282 Comm: rtcwake Not tainted 6.10.0-rc3

Re: [PATCH net-next v3] virtio_net: add support for Byte Queue Limits

2024-08-14 Thread Jiri Pirko
Wed, Aug 14, 2024 at 11:17:35AM CEST, m.szyprow...@samsung.com wrote: >On 14.08.2024 09:49, Jiri Pirko wrote: >> Mon, Aug 12, 2024 at 06:55:26PM CEST, m.szyprow...@samsung.com wrote: >>> On 12.08.2024 18:47, Jiri Pirko wrote: Mon, Aug 12, 2024 at 04:57:24PM CEST, m.szyprow...@samsung.com wrote

Re: [PATCH net-next v3] virtio_net: add support for Byte Queue Limits

2024-08-14 Thread Jiri Pirko
Wed, Aug 14, 2024 at 11:43:51AM CEST, m...@redhat.com wrote: >On Wed, Aug 14, 2024 at 10:17:15AM +0200, Jiri Pirko wrote: >> >diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c >> >index 3f10c72743e9..c6af18948092 100644 >> >--- a/drivers/net/virtio_net.c >> >+++ b/drivers/net/virtio_

Re: [PATCH net-next v3] virtio_net: add support for Byte Queue Limits

2024-08-14 Thread Michael S. Tsirkin
On Wed, Aug 14, 2024 at 10:17:15AM +0200, Jiri Pirko wrote: > >diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > >index 3f10c72743e9..c6af18948092 100644 > >--- a/drivers/net/virtio_net.c > >+++ b/drivers/net/virtio_net.c > >@@ -2867,8 +2867,8 @@ static int virtnet_enable_queue_pai

Re: [PATCH net-next v3] virtio_net: add support for Byte Queue Limits

2024-08-14 Thread Marek Szyprowski
On 14.08.2024 09:49, Jiri Pirko wrote: > Mon, Aug 12, 2024 at 06:55:26PM CEST, m.szyprow...@samsung.com wrote: >> On 12.08.2024 18:47, Jiri Pirko wrote: >>> Mon, Aug 12, 2024 at 04:57:24PM CEST, m.szyprow...@samsung.com wrote: On 18.06.2024 16:44, Jiri Pirko wrote: > From: Jiri Pirko

Re: [PATCH net-next v3] virtio_net: add support for Byte Queue Limits

2024-08-14 Thread Jiri Pirko
Wed, Aug 14, 2024 at 09:49:57AM CEST, j...@resnulli.us wrote: >Mon, Aug 12, 2024 at 06:55:26PM CEST, m.szyprow...@samsung.com wrote: >>On 12.08.2024 18:47, Jiri Pirko wrote: >>> Mon, Aug 12, 2024 at 04:57:24PM CEST, m.szyprow...@samsung.com wrote: On 18.06.2024 16:44, Jiri Pirko wrote: > F

Re: [PATCH net-next v3] virtio_net: add support for Byte Queue Limits

2024-08-14 Thread Jiri Pirko
Mon, Aug 12, 2024 at 06:55:26PM CEST, m.szyprow...@samsung.com wrote: >On 12.08.2024 18:47, Jiri Pirko wrote: >> Mon, Aug 12, 2024 at 04:57:24PM CEST, m.szyprow...@samsung.com wrote: >>> On 18.06.2024 16:44, Jiri Pirko wrote: From: Jiri Pirko Add support for Byte Queue Limits (BQL).

Re: [PATCH net-next v5 1/4] virtio_ring: enable premapped mode whatever use_dma_api

2024-08-14 Thread Michael S. Tsirkin
On Tue, Aug 13, 2024 at 08:39:53PM -0700, Si-Wei Liu wrote: > Hi Michael, > > I'll look for someone else from Oracle to help you on this, as the relevant > team already did verify internally that reverting all 4 patches from this > series could help address the regression. Just reverting one singl