Re: [PATCH net-next v4 2/5] virtio_net: enable irq for the control vq

2024-06-21 Thread Michael S. Tsirkin
On Fri, Jun 21, 2024 at 03:41:46PM +0800, Xuan Zhuo wrote: > On Thu, 20 Jun 2024 06:11:40 -0400, "Michael S. Tsirkin" > wrote: > > On Thu, Jun 20, 2024 at 06:10:51AM -0400, Michael S. Tsirkin wrote: > > > On Thu, Jun 20, 2024 at 05:53:15PM +0800, Heng Qi wrote: > > > > On Thu, 20 Jun 2024 16:26:0

Re: [PATCH][net-next,v2] virtio_net: Remove u64_stats_update_begin()/end() for stats fetch

2024-06-21 Thread Michael S. Tsirkin
On Fri, Jun 21, 2024 at 05:45:52PM +0800, Li RongQing wrote: > This place is fetching the stats, u64_stats_update_begin()/end() > should not be used, and the fetcher of stats is in the same context > as the updater of the stats, so don't need any protection > > Suggested-by: Jakub Kicinski > Sign

Re: [PATCH net-next 2/2] vsock/virtio: avoid enqueue packets when work queue is empty

2024-06-21 Thread Luigi Leonardi
Hi Matias, > > > I think the test can always send packets at a frequency so the worker > > > queue > > > is always empty. but maybe, this is a corner case and most of the time the > > > worker queue is not empty in a non-testing environment. > > > > I'm not sure about this, but IMHO this optimiza

[PATCH][net-next,v2] virtio_net: Remove u64_stats_update_begin()/end() for stats fetch

2024-06-21 Thread Li RongQing
This place is fetching the stats, u64_stats_update_begin()/end() should not be used, and the fetcher of stats is in the same context as the updater of the stats, so don't need any protection Suggested-by: Jakub Kicinski Signed-off-by: Li RongQing --- drivers/net/virtio_net.c | 4 ++-- 1 file ch

Re: [PATCH net-next 2/2] vsock/virtio: avoid enqueue packets when work queue is empty

2024-06-21 Thread Matias Ezequiel Vara Larsen
On Tue, Jun 18, 2024 at 07:05:54PM +0200, Luigi Leonardi wrote: > Hi Stefano and Matias, > > @Stefano Thanks for your review(s)! I'll send a V2 by the end of the week. > > @Matias > > Thanks for your feedback! > > > I think It would be interesting to know what exactly the test does > > It's re

Re: [PATCH net-next v4 2/5] virtio_net: enable irq for the control vq

2024-06-21 Thread Xuan Zhuo
On Thu, 20 Jun 2024 06:11:40 -0400, "Michael S. Tsirkin" wrote: > On Thu, Jun 20, 2024 at 06:10:51AM -0400, Michael S. Tsirkin wrote: > > On Thu, Jun 20, 2024 at 05:53:15PM +0800, Heng Qi wrote: > > > On Thu, 20 Jun 2024 16:26:05 +0800, Jason Wang > > > wrote: > > > > On Thu, Jun 20, 2024 at 4: