Re: [PATCH net-next v5 12/15] virtio_net: xsk: tx: support wakeup

2024-06-16 Thread Jason Wang
On Fri, Jun 14, 2024 at 2:40 PM Xuan Zhuo wrote: > > xsk wakeup is used to trigger the logic for xsk xmit by xsk framework or > user. > > Virtio-net does not support to actively generate an interruption, so it > tries to trigger tx NAPI on the local cpu. > > Signed-off-by: Xuan Zhuo Acked-by: Ja

Re: [PATCH net-next v5 11/15] virtio_net: xsk: tx: support xmit xsk buffer

2024-06-16 Thread Jason Wang
On Fri, Jun 14, 2024 at 2:40 PM Xuan Zhuo wrote: > > The driver's tx napi is very important for XSK. It is responsible for > obtaining data from the XSK queue and sending it out. > > At the beginning, we need to trigger tx napi. > > Signed-off-by: Xuan Zhuo > --- > drivers/net/virtio_net.c | 121

Re: [PATCH net-next v5 08/15] virtio_net: sq support premapped mode

2024-06-16 Thread Jason Wang
On Mon, Jun 17, 2024 at 1:00 PM Jason Wang wrote: > > On Fri, Jun 14, 2024 at 2:39 PM Xuan Zhuo wrote: > > > > If the xsk is enabling, the xsk tx will share the send queue. > > But the xsk requires that the send queue use the premapped mode. > > So the send queue must support premapped mode when

Re: [PATCH net-next v5 09/15] virtio_net: xsk: bind/unbind xsk

2024-06-16 Thread Jason Wang
On Fri, Jun 14, 2024 at 2:39 PM Xuan Zhuo wrote: > > This patch implement the logic of bind/unbind xsk pool to sq and rq. > > Signed-off-by: Xuan Zhuo > --- > drivers/net/virtio_net.c | 201 ++- > 1 file changed, 200 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH net-next v5 08/15] virtio_net: sq support premapped mode

2024-06-16 Thread Jason Wang
On Fri, Jun 14, 2024 at 2:39 PM Xuan Zhuo wrote: > > If the xsk is enabling, the xsk tx will share the send queue. > But the xsk requires that the send queue use the premapped mode. > So the send queue must support premapped mode when it is bound to > af-xdp. > > * virtnet_sq_set_premapped(sq, tru

Re: [PATCH net-next v5 07/15] virtio_net: refactor the xmit type

2024-06-16 Thread Jason Wang
On Fri, Jun 14, 2024 at 2:40 PM Xuan Zhuo wrote: > > Because the af-xdp and sq premapped mode will introduce two > new xmit type, so I refactor the xmit type mechanism first. > > We use the last two bits of the pointer to distinguish the xmit type, > so we can distinguish four xmit types. Now we h

Re: [PATCH net-next v3 4/4] virtio_net: improve dim command request efficiency

2024-06-16 Thread Jason Wang
On Thu, Jun 6, 2024 at 2:15 PM Heng Qi wrote: > > Currently, control vq handles commands synchronously, > leading to increased delays for dim commands during multi-queue > VM configuration and directly impacting dim performance. > > To address this, we are shifting to asynchronous processing of >

Re: [PATCH net-next v2] virtio_net: add support for Byte Queue Limits

2024-06-16 Thread Jason Wang
On Thu, Jun 13, 2024 at 1:09 AM Jiri Pirko wrote: > > From: Jiri Pirko > > Add support for Byte Queue Limits (BQL). > > Tested on qemu emulated virtio_net device with 1, 2 and 4 queues. > Tested with fq_codel and pfifo_fast. Super netperf with 50 threads is > running in background. Netperf TCP_RR

Re: [patch net-next] virtio_net: add support for Byte Queue Limits

2024-06-16 Thread Jason Wang
On Mon, Jun 10, 2024 at 10:19 PM Michael S. Tsirkin wrote: > > On Fri, Jun 07, 2024 at 01:30:34PM +0200, Jiri Pirko wrote: > > Fri, Jun 07, 2024 at 12:23:37PM CEST, m...@redhat.com wrote: > > >On Fri, Jun 07, 2024 at 11:57:37AM +0200, Jiri Pirko wrote: > > >> >True. Personally, I would like to jus