Re: [patch net-next] virtio_net: add support for Byte Queue Limits

2024-06-06 Thread Jason Wang
On Fri, Jun 7, 2024 at 2:39 PM Jiri Pirko wrote: > > Fri, Jun 07, 2024 at 08:25:19AM CEST, jasow...@redhat.com wrote: > >On Thu, Jun 6, 2024 at 9:45 PM Jiri Pirko wrote: > >> > >> Thu, Jun 06, 2024 at 09:56:50AM CEST, jasow...@redhat.com wrote: > >> >On Thu, Jun 6, 2024 at 2:05 PM Michael S. Tsir

Re: [patch net-next] virtio_net: add support for Byte Queue Limits

2024-06-06 Thread Michael S. Tsirkin
On Fri, Jun 07, 2024 at 08:39:20AM +0200, Jiri Pirko wrote: > Fri, Jun 07, 2024 at 08:25:19AM CEST, jasow...@redhat.com wrote: > >On Thu, Jun 6, 2024 at 9:45 PM Jiri Pirko wrote: > >> > >> Thu, Jun 06, 2024 at 09:56:50AM CEST, jasow...@redhat.com wrote: > >> >On Thu, Jun 6, 2024 at 2:05 PM Michael

Re: [patch net-next] virtio_net: add support for Byte Queue Limits

2024-06-06 Thread Jiri Pirko
Fri, Jun 07, 2024 at 08:22:31AM CEST, jasow...@redhat.com wrote: >On Thu, Jun 6, 2024 at 9:41 PM Jiri Pirko wrote: >> >> Thu, Jun 06, 2024 at 06:25:15AM CEST, jasow...@redhat.com wrote: >> >On Thu, Jun 6, 2024 at 10:59 AM Jason Xing >> >wrote: >> >> >> >> Hello Jason, >> >> >> >> On Thu, Jun 6,

Re: [patch net-next] virtio_net: add support for Byte Queue Limits

2024-06-06 Thread Michael S. Tsirkin
On Fri, Jun 07, 2024 at 02:22:31PM +0800, Jason Wang wrote: > On Thu, Jun 6, 2024 at 9:41 PM Jiri Pirko wrote: > > > > Thu, Jun 06, 2024 at 06:25:15AM CEST, jasow...@redhat.com wrote: > > >On Thu, Jun 6, 2024 at 10:59 AM Jason Xing > > >wrote: > > >> > > >> Hello Jason, > > >> > > >> On Thu, Jun

Re: [patch net-next] virtio_net: add support for Byte Queue Limits

2024-06-06 Thread Jiri Pirko
Fri, Jun 07, 2024 at 08:25:19AM CEST, jasow...@redhat.com wrote: >On Thu, Jun 6, 2024 at 9:45 PM Jiri Pirko wrote: >> >> Thu, Jun 06, 2024 at 09:56:50AM CEST, jasow...@redhat.com wrote: >> >On Thu, Jun 6, 2024 at 2:05 PM Michael S. Tsirkin wrote: >> >> >> >> On Thu, Jun 06, 2024 at 12:25:15PM +08

Re: [patch net-next] virtio_net: add support for Byte Queue Limits

2024-06-06 Thread Jason Wang
On Thu, Jun 6, 2024 at 9:45 PM Jiri Pirko wrote: > > Thu, Jun 06, 2024 at 09:56:50AM CEST, jasow...@redhat.com wrote: > >On Thu, Jun 6, 2024 at 2:05 PM Michael S. Tsirkin wrote: > >> > >> On Thu, Jun 06, 2024 at 12:25:15PM +0800, Jason Wang wrote: > >> > > If the codes of orphan mode don't have a

Re: [patch net-next] virtio_net: add support for Byte Queue Limits

2024-06-06 Thread Jason Wang
On Thu, Jun 6, 2024 at 9:41 PM Jiri Pirko wrote: > > Thu, Jun 06, 2024 at 06:25:15AM CEST, jasow...@redhat.com wrote: > >On Thu, Jun 6, 2024 at 10:59 AM Jason Xing wrote: > >> > >> Hello Jason, > >> > >> On Thu, Jun 6, 2024 at 8:21 AM Jason Wang wrote: > >> > > >> > On Wed, Jun 5, 2024 at 7:51 P

Re: [PATCH net-next v3 4/4] virtio_net: improve dim command request efficiency

2024-06-06 Thread kernel test robot
Hi Heng, kernel test robot noticed the following build warnings: [auto build test WARNING on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Heng-Qi/virtio_net-passing-control_buf-explicitly/20240606-141748 base: net-next/main patch link: https://lore.kernel.org/r

Re: [patch net-next] virtio_net: add support for Byte Queue Limits

2024-06-06 Thread Jiri Pirko
Thu, Jun 06, 2024 at 09:56:50AM CEST, jasow...@redhat.com wrote: >On Thu, Jun 6, 2024 at 2:05 PM Michael S. Tsirkin wrote: >> >> On Thu, Jun 06, 2024 at 12:25:15PM +0800, Jason Wang wrote: >> > > If the codes of orphan mode don't have an impact when you enable >> > > napi_tx mode, please keep it i

Re: [patch net-next] virtio_net: add support for Byte Queue Limits

2024-06-06 Thread Jiri Pirko
Thu, Jun 06, 2024 at 06:25:15AM CEST, jasow...@redhat.com wrote: >On Thu, Jun 6, 2024 at 10:59 AM Jason Xing wrote: >> >> Hello Jason, >> >> On Thu, Jun 6, 2024 at 8:21 AM Jason Wang wrote: >> > >> > On Wed, Jun 5, 2024 at 7:51 PM Heng Qi wrote: >> > > >> > > On Wed, 5 Jun 2024 13:30:51 +0200, J

Re: [patch net-next] virtio_net: add support for Byte Queue Limits

2024-06-06 Thread Michael S. Tsirkin
On Thu, Jun 06, 2024 at 07:42:35PM +0800, Jason Xing wrote: > On Thu, Jun 6, 2024 at 12:25 PM Jason Wang wrote: > > > > On Thu, Jun 6, 2024 at 10:59 AM Jason Xing > > wrote: > > > > > > Hello Jason, > > > > > > On Thu, Jun 6, 2024 at 8:21 AM Jason Wang wrote: > > > > > > > > On Wed, Jun 5, 2024

Re: [patch net-next] virtio_net: add support for Byte Queue Limits

2024-06-06 Thread Jason Xing
On Thu, Jun 6, 2024 at 12:25 PM Jason Wang wrote: > > On Thu, Jun 6, 2024 at 10:59 AM Jason Xing wrote: > > > > Hello Jason, > > > > On Thu, Jun 6, 2024 at 8:21 AM Jason Wang wrote: > > > > > > On Wed, Jun 5, 2024 at 7:51 PM Heng Qi wrote: > > > > > > > > On Wed, 5 Jun 2024 13:30:51 +0200, Jiri

Re: [PATCH net-next v3 4/4] virtio_net: improve dim command request efficiency

2024-06-06 Thread kernel test robot
Hi Heng, kernel test robot noticed the following build warnings: [auto build test WARNING on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Heng-Qi/virtio_net-passing-control_buf-explicitly/20240606-141748 base: net-next/main patch link: https://lore.kernel.org/r

Re: [PATCH vhost v13 04/12] virtio_ring: support add premapped buf

2024-06-06 Thread Alexander Potapenko
On Thu, Jun 6, 2024 at 10:27 AM Xuan Zhuo wrote: > > On Thu, 6 Jun 2024 10:20:21 +0200, Alexander Potapenko > wrote: > > > Could you try this? > > > > Hi Xuan, > > > > What kernel revision does this patch apply to? I tried it against > > v6.10-rc2, and only the first hunk applied. > > However th

Re: [PATCH vhost v13 04/12] virtio_ring: support add premapped buf

2024-06-06 Thread Xuan Zhuo
On Thu, 6 Jun 2024 10:20:21 +0200, Alexander Potapenko wrote: > > Could you try this? > > Hi Xuan, > > What kernel revision does this patch apply to? I tried it against > v6.10-rc2, and only the first hunk applied. > However this seems to fix the problem, at least the kernel boots without > warni

Re: [PATCH vhost v13 04/12] virtio_ring: support add premapped buf

2024-06-06 Thread Alexander Potapenko
> > Could you try this? (resending without HTML, sorry for inconvenience). Hi Xuan, What kernel revision does this patch apply to? I tried it against v6.10-rc2, and only the first hunk applied. However this seems to fix the problem, at least the kernel boots without warnings now. > Thanks. > > d

Re: [patch net-next] virtio_net: add support for Byte Queue Limits

2024-06-06 Thread Jason Wang
On Thu, Jun 6, 2024 at 2:05 PM Michael S. Tsirkin wrote: > > On Thu, Jun 06, 2024 at 12:25:15PM +0800, Jason Wang wrote: > > > If the codes of orphan mode don't have an impact when you enable > > > napi_tx mode, please keep it if you can. > > > > For example, it complicates BQL implementation. > >

Re: [patch net-next] virtio_net: add support for Byte Queue Limits

2024-06-06 Thread Jiri Pirko
Thu, Jun 06, 2024 at 04:20:48AM CEST, dave.t...@gmail.com wrote: >On Wed, May 15, 2024 at 12:37 AM Jiri Pirko wrote: > >> Fri, May 10, 2024 at 01:27:08PM CEST, m...@redhat.com wrote: >> >On Fri, May 10, 2024 at 01:11:49PM +0200, Jiri Pirko wrote: >> >> Fri, May 10, 2024 at 12:52:52PM CEST, m...@re