Re: [PATCH v3] virtio_net: Fix missed rtnl_unlock

2024-05-16 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Wed, 15 May 2024 11:31:25 -0500 you wrote: > The rtnl_lock would stay locked if allocating promisc_allmulti failed. > Also changed the allocation to GFP_KERNEL. > > Fixes: ff7c7d9f5261 ("virtio_net: Remove command data

Re: [patch net-next] virtio_net: add support for Byte Queue Limits

2024-05-16 Thread Michael S. Tsirkin
On Thu, May 16, 2024 at 05:25:20PM +0200, Jiri Pirko wrote: > > >I'd expect a regression if any to be in a streaming benchmark. > > Can you elaborate? BQL does two things that can hurt throughput: - limits amount of data in the queue - can limit bandwidth if we now get queue underruns - adds C

Re: [patch net-next] virtio_net: add support for Byte Queue Limits

2024-05-16 Thread Jiri Pirko
Thu, May 16, 2024 at 02:31:59PM CEST, m...@redhat.com wrote: >On Thu, May 16, 2024 at 12:54:58PM +0200, Jiri Pirko wrote: >> Thu, May 16, 2024 at 06:48:38AM CEST, jasow...@redhat.com wrote: >> >On Wed, May 15, 2024 at 8:54 PM Jiri Pirko wrote: >> >> >> >> Wed, May 15, 2024 at 12:12:51PM CEST, j...

Re: [patch net-next] virtio_net: add support for Byte Queue Limits

2024-05-16 Thread Michael S. Tsirkin
On Thu, May 16, 2024 at 12:54:58PM +0200, Jiri Pirko wrote: > Thu, May 16, 2024 at 06:48:38AM CEST, jasow...@redhat.com wrote: > >On Wed, May 15, 2024 at 8:54 PM Jiri Pirko wrote: > >> > >> Wed, May 15, 2024 at 12:12:51PM CEST, j...@resnulli.us wrote: > >> >Wed, May 15, 2024 at 10:20:04AM CEST, m.

Re: [patch net-next] virtio_net: add support for Byte Queue Limits

2024-05-16 Thread Jiri Pirko
Thu, May 16, 2024 at 06:48:38AM CEST, jasow...@redhat.com wrote: >On Wed, May 15, 2024 at 8:54 PM Jiri Pirko wrote: >> >> Wed, May 15, 2024 at 12:12:51PM CEST, j...@resnulli.us wrote: >> >Wed, May 15, 2024 at 10:20:04AM CEST, m...@redhat.com wrote: >> >>On Wed, May 15, 2024 at 09:34:08AM +0200, Ji