Re: [PATCH net-next v7 8/8] virtio-net: support queue stat

2024-04-26 Thread Jakub Kicinski
On Fri, 26 Apr 2024 11:39:28 +0800 Xuan Zhuo wrote: > To enhance functionality, we now support reporting statistics through > the netdev-generic netlink (netdev-genl) queue stats interface. However, > this does not extend to all statistics, so a new field, qstat_offset, > has been introduced. This

Re: [PATCH net-next v7 7/8] netdev: add queue stats

2024-04-26 Thread Jakub Kicinski
On Fri, 26 Apr 2024 11:39:27 +0800 Xuan Zhuo wrote: > These stats are commonly. Support reporting those via netdev-genl queue > stats. > > name: rx-hw-drops > name: rx-hw-drop-overruns > name: rx-csum-unnecessary > name: rx-csum-none > name: rx-csum-bad > name: rx-hw-gro-packets > name: rx-hw-gro-

RE: [PATCH net-next v5 0/6] Remove RTNL lock protection of CVQ

2024-04-26 Thread Dan Jurgens
> From: Paolo Abeni > Sent: Friday, April 26, 2024 4:54 AM > To: Dan Jurgens ; netdev@vger.kernel.org; > jasow...@redhat.com; m...@redhat.com > Cc: xuanz...@linux.alibaba.com; virtualizat...@lists.linux.dev; > da...@davemloft.net; eduma...@google.com; k...@kernel.org; Jiri Pirko > > Subject: Re:

RE: [PATCH net-next v5 5/6] virtio_net: Add a lock for per queue RX coalesce

2024-04-26 Thread Dan Jurgens
> From: Paolo Abeni > Sent: Friday, April 26, 2024 4:48 AM > To: Dan Jurgens ; netdev@vger.kernel.org > Cc: m...@redhat.com; jasow...@redhat.com; xuanz...@linux.alibaba.com; > virtualizat...@lists.linux.dev; da...@davemloft.net; > eduma...@google.com; k...@kernel.org; Jiri Pirko > Subject: Re: [P

Re: [patch net-next v6 0/5] selftests: virtio_net: introduce initial testing infrastructure

2024-04-26 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (main) by Paolo Abeni : On Wed, 24 Apr 2024 12:40:44 +0200 you wrote: > From: Jiri Pirko > > This patchset aims at introducing very basic initial infrastructure > for virtio_net testing, namely it focuses on virtio feature testing. > > The

Re: [PATCH vhost v3 0/4] virtio_net: rx enable premapped mode by default

2024-04-26 Thread Paolo Abeni
On Wed, 2024-04-24 at 16:16 +0800, Xuan Zhuo wrote: > Actually, for the virtio drivers, we can enable premapped mode whatever > the value of use_dma_api. Because we provide the virtio dma apis. > So the driver can enable premapped mode unconditionally. > > This patch set makes the big mode of virt

Re: [PATCH net-next v5 0/6] Remove RTNL lock protection of CVQ

2024-04-26 Thread Heng Qi
在 2024/4/23 上午11:57, Daniel Jurgens 写道: Currently the buffer used for control VQ commands is protected by the RTNL lock. Previously this wasn't a major concern because the control VQ was only used during device setup and user interaction. With the recent addition of dynamic interrupt moderation

Re: [PATCH net-next v5 0/6] Remove RTNL lock protection of CVQ

2024-04-26 Thread Paolo Abeni
On Tue, 2024-04-23 at 06:57 +0300, Daniel Jurgens wrote: > Currently the buffer used for control VQ commands is protected by the > RTNL lock. Previously this wasn't a major concern because the control VQ > was only used during device setup and user interaction. With the recent > addition of dynamic

Re: [PATCH net-next v5 5/6] virtio_net: Add a lock for per queue RX coalesce

2024-04-26 Thread Paolo Abeni
On Tue, 2024-04-23 at 06:57 +0300, Daniel Jurgens wrote: > Once the RTNL locking around the control buffer is removed there can be > contention on the per queue RX interrupt coalescing data. Use a mutex > per queue. A mutex is required because virtnet_send_command can sleep. > > Signed-off-by: Dan

Re: [PATCH net-next v5 3/6] virtio_net: Add a lock for the command VQ.

2024-04-26 Thread Paolo Abeni
On Tue, 2024-04-23 at 06:57 +0300, Daniel Jurgens wrote: > The command VQ will no longer be protected by the RTNL lock. Use a > mutex to protect the control buffer header and the VQ. > > Signed-off-by: Daniel Jurgens > Reviewed-by: Jiri Pirko > --- > drivers/net/virtio_net.c | 12 ++-- >

Re: [PATCH net-next v5 2/6] virtio_net: Remove command data from control_buf

2024-04-26 Thread Paolo Abeni
On Tue, 2024-04-23 at 06:57 +0300, Daniel Jurgens wrote: > Allocate memory for the data when it's used. Ideally the could be on the Minor nit: 'buffer' or 'struct' is missing here No need to repost just for this. Thank, Paolo