Re: REGRESSION: RIP: 0010:skb_release_data+0xb8/0x1e0 in vhost/tun

2024-03-26 Thread Jason Wang
On Tue, Mar 26, 2024 at 9:26 PM Jaroslav Pulchart wrote: > > > > > On Mon, Mar 25, 2024 at 4:44 PM Igor Raits wrote: > > > > > > Hello, > > > > > > On Fri, Mar 22, 2024 at 12:19 PM Igor Raits wrote: > > > > > > > > Hi Jason, > > > > > > > > On Fri, Mar 22, 2024 at 9:39 AM Igor Raits wrote: > >

Re: [PATCH net-next 4/4] virtio_net: Remove rtnl lock protection of command buffers

2024-03-26 Thread Heng Qi
在 2024/3/26 下午11:18, Dan Jurgens 写道: From: Heng Qi Sent: Tuesday, March 26, 2024 3:55 AM To: Dan Jurgens ; netdev@vger.kernel.org Cc: m...@redhat.com; jasow...@redhat.com; xuanz...@linux.alibaba.com; virtualizat...@lists.linux.dev; da...@davemloft.net; eduma...@google.com; k...@kernel.org; pa

RE: [PATCH net-next 4/4] virtio_net: Remove rtnl lock protection of command buffers

2024-03-26 Thread Dan Jurgens
> From: Heng Qi > Sent: Tuesday, March 26, 2024 3:55 AM > To: Dan Jurgens ; netdev@vger.kernel.org > Cc: m...@redhat.com; jasow...@redhat.com; xuanz...@linux.alibaba.com; > virtualizat...@lists.linux.dev; da...@davemloft.net; > eduma...@google.com; k...@kernel.org; pab...@redhat.com; Jiri Pirko >

Re: REGRESSION: RIP: 0010:skb_release_data+0xb8/0x1e0 in vhost/tun

2024-03-26 Thread Jaroslav Pulchart
> > On Mon, Mar 25, 2024 at 4:44 PM Igor Raits wrote: > > > > Hello, > > > > On Fri, Mar 22, 2024 at 12:19 PM Igor Raits wrote: > > > > > > Hi Jason, > > > > > > On Fri, Mar 22, 2024 at 9:39 AM Igor Raits wrote: > > > > > > > > Hi Jason, > > > > > > > > On Fri, Mar 22, 2024 at 6:31 AM Jason Wang

Re: [PATCH net-next 4/4] virtio_net: Remove rtnl lock protection of command buffers

2024-03-26 Thread Heng Qi
在 2024/3/26 上午5:49, Daniel Jurgens 写道: The rtnl lock is no longer needed to protect the control buffer and command VQ. Signed-off-by: Daniel Jurgens Reviewed-by: Jiri Pirko --- drivers/net/virtio_net.c | 27 +-- 1 file changed, 5 insertions(+), 22 deletions(-) di

Re: [PATCH vhost v4 02/10] virtio_ring: packed: remove double check of the unmap ops

2024-03-26 Thread Michael S. Tsirkin
On Thu, Mar 21, 2024 at 04:20:09PM +0800, Xuan Zhuo wrote: > On Thu, 21 Mar 2024 13:57:06 +0800, Jason Wang wrote: > > On Tue, Mar 12, 2024 at 11:36 AM Xuan Zhuo > > wrote: > > > > > > In the functions vring_unmap_extra_packed and vring_unmap_desc_packed, > > > multiple checks are made whether u

Re: [PATCH net-next 2/4] virtio_net: Remove command data from control_buf

2024-03-26 Thread Heng Qi
在 2024/3/26 上午5:49, Daniel Jurgens 写道: Allocate memory for the data when it's used. Ideally the could be on the stack, but we can't DMA stack memory. With this change only the header and status memory are shared between commands, which will allow using a tighter lock than RTNL. Signed-off-by: