Re: [PATCH net-next v3 3/6] virtio_net: support device stats

2024-03-07 Thread Jakub Kicinski
CC: Willem and some driver folks for more input, context: extending https://lore.kernel.org/all/20240306195509.1502746-1-k...@kernel.org/ to cover virtio stats. On Tue, 27 Feb 2024 16:03:00 +0800 Xuan Zhuo wrote: > +static const struct virtnet_stat_desc virtnet_stats_rx_basic_desc[] = { > + VI

Re: [PATCH net-next v3 5/6] virtio_net: add the total stats field

2024-03-07 Thread Jakub Kicinski
On Thu, 7 Mar 2024 17:36:35 +0800 Xuan Zhuo wrote: > > Please wait for this API to get merged: > > https://lore.kernel.org/all/20240226211015.1244807-1-k...@kernel.org/ > > A lot of the stats you're adding here can go into the new API. > > More drivers can report things like number of LSO / GRO pac

Re: [PATCH net-next v3 5/6] virtio_net: add the total stats field

2024-03-07 Thread Xuan Zhuo
On Tue, 27 Feb 2024 06:54:24 -0800, Jakub Kicinski wrote: > On Tue, 27 Feb 2024 16:03:02 +0800 Xuan Zhuo wrote: > > Now, we just show the stats of every queue. > > > > But for the user, the total values of every stat may are valuable. > > Please wait for this API to get merged: > https://lore.kern