Re: [PATCH 1/1] virtio_net: Add timeout handler to avoid kernel hang

2024-01-19 Thread Zhu Yanjun
在 2024/1/20 1:29, Andrew Lunn 写道:   while (!virtqueue_get_buf(vi->cvq, &tmp) && -   !virtqueue_is_broken(vi->cvq)) +   !virtqueue_is_broken(vi->cvq)) { +    if (timeout) +    timeout--; This is not really a timeout, just a loop counter. 200 iterations could be

Re: [PATCH 1/1] virtio_net: Add timeout handler to avoid kernel hang

2024-01-19 Thread Andrew Lunn
> > > >   while (!virtqueue_get_buf(vi->cvq, &tmp) && > > > > -   !virtqueue_is_broken(vi->cvq)) > > > > +   !virtqueue_is_broken(vi->cvq)) { > > > > +    if (timeout) > > > > +    timeout--; > > > This is not really a timeout, just a loop counter. 200 iterations cou

Re: [PATCH 1/1] virtio_net: Add timeout handler to avoid kernel hang

2024-01-19 Thread Heng Qi
在 2024/1/18 下午8:01, Zhu Yanjun 写道: 在 2024/1/16 20:04, Paolo Abeni 写道: On Mon, 2024-01-15 at 09:29 +0800, Zhu Yanjun wrote: From: Zhu Yanjun Some devices emulate the virtio_net hardwares. When virtio_net driver sends commands to the emulated hardware, normally the hardware needs time to re

Re: [PATCH net-next 0/3] virtio-net: a fix and some updates for virtio dim

2024-01-19 Thread Heng Qi
在 2024/1/19 下午8:28, Michael S. Tsirkin 写道: On Tue, Jan 16, 2024 at 09:11:30PM +0800, Heng Qi wrote: Patch 1 fixes an existing bug. Belongs to the net branch. Patch 2 requires updating the virtio spec. Patch 3 only attempts to modify the sending of dim cmd to an asynchronous way, and does not

Re: [PATCH net-next 3/3] virtio-net: reduce the CPU consumption of dim worker

2024-01-19 Thread kernel test robot
/r/1705410693-118895-4-git-send-email-hengqi%40linux.alibaba.com patch subject: [PATCH net-next 3/3] virtio-net: reduce the CPU consumption of dim worker config: i386-buildonly-randconfig-004-20240119 (https://download.01.org/0day-ci/archive/20240119/202401192156.zunujmua-...@intel.com/config

Re: [PATCH net-next 0/3] virtio-net: a fix and some updates for virtio dim

2024-01-19 Thread Michael S. Tsirkin
On Tue, Jan 16, 2024 at 09:11:30PM +0800, Heng Qi wrote: > Patch 1 fixes an existing bug. Belongs to the net branch. > Patch 2 requires updating the virtio spec. > Patch 3 only attempts to modify the sending of dim cmd to an asynchronous way, > and does not affect the synchronization way of ethtool

Re: [PATCH net-next 3/3] virtio-net: reduce the CPU consumption of dim worker

2024-01-19 Thread kernel test robot
/r/1705410693-118895-4-git-send-email-hengqi%40linux.alibaba.com patch subject: [PATCH net-next 3/3] virtio-net: reduce the CPU consumption of dim worker config: i386-randconfig-012-20240119 (https://download.01.org/0day-ci/archive/20240119/202401191807.rihmhj4u-...@intel.com/config) compiler