Re: [PATCH v2] virtio_net: fix missing dma unmap for resize

2024-01-03 Thread Jason Wang
On Thu, Jan 4, 2024 at 6:18 AM Michael S. Tsirkin wrote: > > On Wed, Jan 03, 2024 at 01:58:03PM -0800, Jakub Kicinski wrote: > > On Tue, 26 Dec 2023 17:43:33 +0800 Xuan Zhuo wrote: > > > For rq, we have three cases getting buffers from virtio core: > > > > > > 1. virtqueue_get_buf{,_ctx} > > > 2.

[PATCH v3 1/1] virtio_net: Fix "‘%d’ directive writing between 1 and 11 bytes into a region of size 10" warnings

2024-01-03 Thread Zhu Yanjun
From: Zhu Yanjun Fix the warnings when building virtio_net driver. " drivers/net/virtio_net.c: In function ‘init_vqs’: drivers/net/virtio_net.c:4551:48: warning: ‘%d’ directive writing between 1 and 11 bytes into a region of size 10 [-Wformat-overflow=] 4551 | sprintf(vi->rq[i]

Re: [PATCH v2 1/1] virtio_net: Fix "‘%d’ directive writing between 1 and 11 bytes into a region of size 10" warnings

2024-01-03 Thread Zhu Yanjun
在 2024/1/4 8:55, Jakub Kicinski 写道: On Wed, 27 Dec 2023 22:26:37 +0800 Zhu Yanjun wrote: From: Zhu Yanjun Fix the warnings when building virtio_net driver. This got marked as Not Applicable in patchwork, not sure why. Could you repost? Got it. I will resend this commit very soon. Best Re

Re: [PATCH v2 1/1] virtio_net: Fix "‘%d’ directive writing between 1 and 11 bytes into a region of size 10" warnings

2024-01-03 Thread Jakub Kicinski
On Wed, 27 Dec 2023 22:26:37 +0800 Zhu Yanjun wrote: > From: Zhu Yanjun > > Fix the warnings when building virtio_net driver. This got marked as Not Applicable in patchwork, not sure why. Could you repost?

Re: [PATCH v2] virtio_net: fix missing dma unmap for resize

2024-01-03 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Tue, 26 Dec 2023 17:43:33 +0800 you wrote: > For rq, we have three cases getting buffers from virtio core: > > 1. virtqueue_get_buf{,_ctx} > 2. virtqueue_detach_unused_buf > 3. callback for virtqueue_resize > > But in

Re: [PATCH v2] virtio_net: fix missing dma unmap for resize

2024-01-03 Thread Michael S. Tsirkin
On Wed, Jan 03, 2024 at 01:58:03PM -0800, Jakub Kicinski wrote: > On Tue, 26 Dec 2023 17:43:33 +0800 Xuan Zhuo wrote: > > For rq, we have three cases getting buffers from virtio core: > > > > 1. virtqueue_get_buf{,_ctx} > > 2. virtqueue_detach_unused_buf > > 3. callback for virtqueue_resize > > >

Re: [PATCH v2] virtio_net: fix missing dma unmap for resize

2024-01-03 Thread Jakub Kicinski
On Tue, 26 Dec 2023 17:43:33 +0800 Xuan Zhuo wrote: > For rq, we have three cases getting buffers from virtio core: > > 1. virtqueue_get_buf{,_ctx} > 2. virtqueue_detach_unused_buf > 3. callback for virtqueue_resize > > But in commit 295525e29a5b("virtio_net: merge dma operations when > filling m

Re: [PATCH net-next 3/6] virtio_net: support device stats

2024-01-03 Thread Simon Horman
On Fri, Dec 22, 2023 at 11:30:18AM +0800, Xuan Zhuo wrote: > As the spec > https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82 > > Virtio-net supports to get the stats from the device by ethtool -S . > > Signed-off-by: Xuan Zhuo Hi Xuan Zhuo, some minor fe