Lee Gibson writes:
> Function wl1251_cmd_scan calls memcpy without checking the length.
> A user could control that length and trigger a buffer overflow.
> Fix by checking the length is within the maximum allowed size.
>
> Signed-off-by: Lee Gibson
Please fix the commit log, the user cannot con
Jiapeng Chong wrote:
> Fix the following whitescan warning:
>
> An unsigned value can never be less than 0.
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng Chong
Patch applied to wireless-drivers-next.git, thanks.
5e6087559e85 wil6210: wmi: Remove useless code
--
https://patchwork.k
Christophe JAILLET wrote:
> 'get_tid_h()' is the same as 'ieee80211_get_tid()'.
> So this function can be removed to save a few lines of code.
>
> Signed-off-by: Christophe JAILLET
> Acked-by: Christian Lamparter
Patch applied to wireless-drivers-next.git, thanks.
cf366b154704 carl9170: remo
Lv Yunlong wrote:
> In mwl8k_probe_hw, hw->priv->txq is freed at the first time by
> dma_free_coherent() in the call chain:
> if(!priv->ap_fw)->mwl8k_init_txqs(hw)->mwl8k_txq_init(hw, i).
>
> Then in err_free_queues of mwl8k_probe_hw, hw->priv->txq is freed
> at the second time by mwl8k_txq_dein
Wan Jiabing wrote:
> struct brcmf_bus is declared twice. One has been declared
> at 37th line. Remove the duplicate.
>
> Signed-off-by: Wan Jiabing
2 patches applied to wireless-drivers-next.git, thanks.
d663bc3317c9 brcmfmac: Remove duplicate struct declaration
444a9af68b5c wilc1000: Remove
Eric Lin wrote:
> Signed-off-by: Eric Lin
> Reported-by: Gustavo A. R. Silva
Patch applied to wireless-drivers-next.git, thanks.
7f50ddc5d4fe wl3501: fix typo of 'Networks' in comment
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210331010418.1632816-2-dslin1...@gmail.com/
Marek Vasut wrote:
> The rsi_resume() does access the bus to enable interrupts on the RSI
> SDIO WiFi card, however when calling sdio_claim_host() in the resume
> path, it is possible the bus is already claimed and sdio_claim_host()
> spins indefinitelly. Enable the SDIO card interrupts in resume
Wan Jiabing wrote:
> struct lbs_private has been declared at 22nd line.
> Remove the duplicate.
>
> Signed-off-by: Wan Jiabing
Patch applied to wireless-drivers-next.git, thanks.
d3240418a662 libertas: struct lbs_private is declared duplicately
--
https://patchwork.kernel.org/project/linux-
Bhaskar Chowdhury wrote:
> s/revsion/revision/
>
> Signed-off-by: Bhaskar Chowdhury
Patch applied to wireless-drivers-next.git, thanks.
705b5cfab183 brcmfmac: A typo fix
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210323043657.1466296-1-unixbhas...@gmail.com/
https://wir
Aditya Srivastava wrote:
> The opening comment mark '/**' is used for highlighting the beginning of
> kernel-doc comments.
> There are some files in drivers/net/wireless/rsi which follow this syntax
> in their file headers, i.e. start with '/**' like comments, which causes
> unexpected warnings f
Dinghao Liu wrote:
> When prism2_hw_config() fails, we just return an error code
> without any resource release, which may lead to memleak.
>
> Signed-off-by: Dinghao Liu
Nobody reviewed this, so dropping the patch.
Patch set to Changes Requested.
--
https://patchwork.kernel.org/project/lin
Colin King wrote:
> From: Colin Ian King
>
> The calculation of offtune_val seems incorrect, the u16 value in
> pi->tx_rx_cal_radio_saveregs[2] is being masked with 0xf0 and then
> shifted 8 places right so that always ends up as a zero result. I
> believe the intended shift was 4 bits to the r
Jia-Ju Bai wrote:
> When kmemdup() returns NULL to ta_firmware, no error return code of
> rsi_load_9116_firmware() is assigned.
> To fix this bug, status is assigned with -ENOMEM in this case.
>
> Reported-by: TOTE Robot
> Signed-off-by: Jia-Ju Bai
Someone needs to review this.
Patch set to
Jia-Ju Bai wrote:
> When ieee80211_pspoll_get() returns NULL to skb, no error return code of
> wl1271_cmd_build_ps_poll() is assigned.
> To fix this bug, ret is assigned with -ENOMEM in this case.
>
> Reported-by: TOTE Robot
> Signed-off-by: Jia-Ju Bai
Someone needs to review this.
Patch set
Jia-Ju Bai wrote:
> When wl is NULL, no error return code of wl1271_suspend() is assigned.
> To fix this bug, ret is assigned with -EINVAL in this case.
>
> Reported-by: TOTE Robot
> Signed-off-by: Jia-Ju Bai
Someone needs to review this.
Patch set to Changes Requested.
--
https://patchwor
Jia-Ju Bai wrote:
> When check_fwfile_format() fails, no error return code of
> if_usb_prog_firmware() is assigned.
> To fix this bug, ret is assigned with -EINVAL as error return code.
>
> Reported-by: TOTE Robot
> Signed-off-by: Jia-Ju Bai
Someone needs to review this.
Patch set to Changes
On Sat, Apr 17, 2021 at 10:26:30PM -0400, Matt Corallo wrote:
> Sure, there are better ways to handle the reassembly cache overflowing, but
> that is pretty unrelated to the fact that waiting 30 full seconds for a
> fragment to come in doesn't really make sense in today's networks (the 30
> second
On Sun, Apr 18, 2021 at 12:09:16AM +0530, Devesh Sharma wrote:
> On Sat, Apr 17, 2021 at 1:44 PM Leon Romanovsky wrote:
> >
> > On Wed, Apr 14, 2021 at 07:15:37PM +0530, Devesh Sharma wrote:
> > > On Mon, Apr 12, 2021 at 1:10 PM Leon Romanovsky wrote:
> > > >
> > > > On Thu, Apr 08, 2021 at 08:42
The 'ip' utility hardcodes the assumption of being a 2-char command, where
any follow-on characters are passed as an argument:
$ ./ip-full help
Object "-full" is unknown, try "ip help".
This confusing behaviour isn't seen with 'tc' for example, and was added in
a 2005 commit without documenta
Sure, there are better ways to handle the reassembly cache overflowing, but that is pretty unrelated to the fact that
waiting 30 full seconds for a fragment to come in doesn't really make sense in today's networks (the 30 second delay
that is used today appears to even be higher than RFC 791 sugg
Willy's words make sense to me and I agree that the existing fragments
should be evicted when the new one comes in and the cache is full.
Though the attacker can still leverage this to flush the victim's
cache, as mentioned previously, since fragments are likely to be
assembled in a very short time
See-also "[PATCH] Reduce IP_FRAG_TIME fragment-reassembly timeout to 1s, from 30s" (and the two resends of it) - given
the size of the default cache (4MB) and the time that it takes before we flush the cache (30 seconds) you only need
about 1Mbps of fragments to hit this issue. While DoS attacks
The default IP reassembly timeout of 30 seconds predates git
history (and cursory web searches turn up nothing related to it).
The only relevant source cited in net/ipv4/ip_fragment.c is RFC
791 defining IPv4 in 1981. RFC 791 suggests allowing the timer to
increase on the receipt of each fragment
On Sat, 2021-04-17 at 14:30 -0400, Jes Sorensen wrote:
> On 4/17/21 1:52 PM, Kalle Valo wrote:
> > "Gustavo A. R. Silva" wrote:
> >
> > > In preparation to enable -Wimplicit-fallthrough for Clang, fix
> > > multiple warnings by replacing /* fall through */ comments with
> > > the new pseudo-keywo
Quoting Stephen Hemminger :
On Thu, 15 Apr 2021 20:06:43 +0200
Paolo Lungaroni wrote:
+ if (is_json_context())
+ open_json_object("stats64");
+
+ if (tb[SEG6_LOCAL_CNT_PACKETS]) {
+ packets = rta_getattr_u64(tb[SEG6_LOCAL_CNT_PACKETS]);
+
On Sat, Apr 17, 2021 at 09:18:57PM +, David Laight wrote:
> Ugly as well.
Thank you for expressing your opinion. Again.
On Sat, Apr 17, 2021 at 09:13:45PM +, David Laight wrote:
> > struct {/* page_pool used by netstack */
> > - /**
> > -* @dma_addr: might require a 64-bit value on
> > -* 32-bit architectures.
> > -
From: Matthew Wilcox
> Sent: 17 April 2021 03:45
>
> Replacement patch to fix compiler warning.
...
> static inline dma_addr_t page_pool_get_dma_addr(struct page *page)
> {
> - return page->dma_addr;
> + dma_addr_t ret = page->dma_addr[0];
> + if (sizeof(dma_addr_t) > sizeof(unsigne
From: Matthew Wilcox (Oracle)
> Sent: 17 April 2021 00:07
>
> The net page_pool wants to use a magic value to identify page pool pages.
> The best place to put it is in the first word where it can be clearly a
> non-pointer value. That means shifting dma_addr up to alias with ->index,
> which me
On Sat, Apr 17, 2021 at 09:32:06PM +0300, Ilias Apalodimas wrote:
> > +static inline void page_pool_set_dma_addr(struct page *page, dma_addr_t
> > addr)
> > +{
> > + page->dma_addr[0] = addr;
> > + if (sizeof(dma_addr_t) > sizeof(unsigned long))
> > + page->dma_addr[1] = addr >> 16 >
On Sat, Apr 17, 2021 at 12:18:08PM -0700, Jakub Kicinski wrote:
> On Sat, 17 Apr 2021 12:15:20 -0700 Jakub Kicinski wrote:
> > On Sat, 17 Apr 2021 21:53:40 +0300 Ido Schimmel wrote:
> > > On Sat, Apr 17, 2021 at 11:13:51AM -0700, Jakub Kicinski wrote:
> > > > On Sat, 17 Apr 2021 10:57:42 -0700 Ja
On 4/17/21 13:29, Jes Sorensen wrote:
> On 3/10/21 3:59 PM, Kees Cook wrote:
>> On Wed, Mar 10, 2021 at 02:51:24PM -0500, Jes Sorensen wrote:
>>> On 3/10/21 2:45 PM, Kees Cook wrote:
On Wed, Mar 10, 2021 at 02:31:57PM -0500, Jes Sorensen wrote:
> On 3/10/21 2:14 PM, Kees Cook wrote:
>>>
On Sat, 17 Apr 2021 22:22:57 +0300 Ido Schimmel wrote:
> > > So you will have something like:
> > >
> > > ETHTOOL_A_STATS_GRP_HIST_BKT_UNITS_BYTES
> >
> > Histogram has two dimensions, what's the second dimension for bytes?
> > Time? Packet arrival?
>
> Not sure what you mean. Here you are c
On Sat, Apr 17, 2021 at 12:18:08PM -0700, Jakub Kicinski wrote:
> On Sat, 17 Apr 2021 12:15:20 -0700 Jakub Kicinski wrote:
> > On Sat, 17 Apr 2021 21:53:40 +0300 Ido Schimmel wrote:
> > > On Sat, Apr 17, 2021 at 11:13:51AM -0700, Jakub Kicinski wrote:
> > > > On Sat, 17 Apr 2021 10:57:42 -0700 Ja
On Sat, Apr 17, 2021 at 11:47:28AM -0700, Jakub Kicinski wrote:
> On Sat, 17 Apr 2021 21:14:40 +0300 Ido Schimmel wrote:
> > > + if (!is_json_context()) {
> > > + fprintf(stdout, "rmon-%s-etherStatsPkts",
> > > + mnl_attr_get_type(hist) == ETHTOOL_A_STATS_GRP_HIST_RX ?
> > >
On Sat, 17 Apr 2021 12:15:20 -0700 Jakub Kicinski wrote:
> On Sat, 17 Apr 2021 21:53:40 +0300 Ido Schimmel wrote:
> > On Sat, Apr 17, 2021 at 11:13:51AM -0700, Jakub Kicinski wrote:
> > > On Sat, 17 Apr 2021 10:57:42 -0700 Jakub Kicinski wrote:
> > >
> > > FWIW ethnl_parse_bit() -> ETHTOOL_A_
On Sat, 17 Apr 2021 21:53:40 +0300 Ido Schimmel wrote:
> On Sat, Apr 17, 2021 at 11:13:51AM -0700, Jakub Kicinski wrote:
> > On Sat, 17 Apr 2021 10:57:42 -0700 Jakub Kicinski wrote:
> > > Um, yes and now. The only places the user space puts those names
> > > is the help message and man page.
> >
On Sat, Apr 17, 2021 at 11:13:51AM -0700, Jakub Kicinski wrote:
> On Sat, 17 Apr 2021 10:57:42 -0700 Jakub Kicinski wrote:
> > > I tried to understand how you add new groups without user space
> > > changes and I think this statement is not entirely accurate.
> > >
> > > At minimum, user space nee
On Sat, 17 Apr 2021 21:14:40 +0300 Ido Schimmel wrote:
> > + if (!is_json_context()) {
> > + fprintf(stdout, "rmon-%s-etherStatsPkts",
> > + mnl_attr_get_type(hist) == ETHTOOL_A_STATS_GRP_HIST_RX ?
> > + "rx" : "tx");
> > +
> > + if (low &&
On Sat, Apr 17, 2021 at 1:44 PM Leon Romanovsky wrote:
>
> On Wed, Apr 14, 2021 at 07:15:37PM +0530, Devesh Sharma wrote:
> > On Mon, Apr 12, 2021 at 1:10 PM Leon Romanovsky wrote:
> > >
> > > On Thu, Apr 08, 2021 at 08:42:57PM +0530, Devesh Sharma wrote:
> > > > On Thu, Apr 8, 2021 at 5:14 PM Le
Hi Matthew,
On Sat, Apr 17, 2021 at 03:45:22AM +0100, Matthew Wilcox wrote:
>
> Replacement patch to fix compiler warning.
>
> From: "Matthew Wilcox (Oracle)"
> Date: Fri, 16 Apr 2021 16:34:55 -0400
> Subject: [PATCH 1/2] mm: Fix struct page layout on 32-bit systems
> To: bro...@redhat.com
> Cc
On 4/17/21 1:52 PM, Kalle Valo wrote:
> "Gustavo A. R. Silva" wrote:
>
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix
>> multiple warnings by replacing /* fall through */ comments with
>> the new pseudo-keyword macro fallthrough; instead of letting the
>> code fall through to t
On 3/10/21 3:59 PM, Kees Cook wrote:
> On Wed, Mar 10, 2021 at 02:51:24PM -0500, Jes Sorensen wrote:
>> On 3/10/21 2:45 PM, Kees Cook wrote:
>>> On Wed, Mar 10, 2021 at 02:31:57PM -0500, Jes Sorensen wrote:
On 3/10/21 2:14 PM, Kees Cook wrote:
> Hm, this conversation looks like a miscommun
On Fri, Apr 16, 2021 at 09:02:52AM -0700, Jakub Kicinski wrote:
> # ethtool -S eth0 --groups eth-phy eth-mac rmon
> Stats for eth0:
> eth-phy-SymbolErrorDuringCarrier: 1
> eth-mac-FramesTransmittedOK: 1
> eth-mac-FrameTooLongErrors: 1
> rmon-etherStatsUndersizePkts: 1
> rmon-etherStatsJabbers: 1
>
On Sat, 17 Apr 2021 10:57:42 -0700 Jakub Kicinski wrote:
> > I tried to understand how you add new groups without user space
> > changes and I think this statement is not entirely accurate.
> >
> > At minimum, user space needs to know the names of these groups, but
> > currently there is no way to
On 08.04.2021 21:04, Maciej S. Szmigiero wrote:
On 08.04.2021 06:42, Pkshih wrote:
-Original Message-
From: Maciej S. Szmigiero [mailto:m...@maciej.szmigiero.name]
Sent: Thursday, April 08, 2021 4:53 AM
To: Larry Finger; Pkshih
Cc: linux-wirel...@vger.kernel.org; netdev@vger.kernel.org;
Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> gcc-11 with KASAN on 32-bit arm produces a warning about a function
> that needs a lot of stack space:
>
> drivers/net/wireless/cisco/airo.c: In function 'setup_card.constprop':
> drivers/net/wireless/cisco/airo.c:3960:1: error: the frame size of
Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> gcc complains about undefined behavior in calling snprintf()
> with the same buffer as input and output:
>
> drivers/net/wireless/ti/wl18xx/debugfs.c: In function
> 'diversity_num_of_packets_per_ant_read':
> drivers/net/wireless/ti/wl18xx/../wlco
Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> Building without mesh supports shows a couple of warnings with
> 'make W=1':
>
> drivers/net/wireless/marvell/libertas/main.c: In function 'lbs_start_card':
> drivers/net/wireless/marvell/libertas/main.c:1068:37: error: suggest braces
> around em
On Sat, 17 Apr 2021 20:15:11 +0300 Ido Schimmel wrote:
> On Fri, Apr 16, 2021 at 12:27:39PM -0700, Jakub Kicinski wrote:
> > Add an interface for reading standard stats, including
> > stats which don't have a corresponding control interface.
> >
> > Start with IEEE 802.3 PHY stats. There seems to
Christophe JAILLET wrote:
> The 'c2hcmd_lock' spinlock is only used to protect some __skb_queue_tail()
> and __skb_dequeue() calls.
> Use the lock provided in the skb itself and call skb_queue_tail() and
> skb_dequeue(). These functions already include the correct locking.
>
> Signed-off-by: Chr
zuoqil...@163.com wrote:
> From: zuoqilin
>
> Remove unneeded variable: "ret"
>
> Signed-off-by: zuoqilin
Patch applied to wireless-drivers-next.git, thanks.
c81852a48e13 mwifiex: Remove unneeded variable: "ret"
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210317063353.10
"Gustavo A. R. Silva" wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix
> multiple warnings by replacing /* fall through */ comments with
> the new pseudo-keyword macro fallthrough; instead of letting the
> code fall through to the next case.
>
> Notice that Clang doesn't r
Huang Guobin wrote:
> From: Guobin Huang
>
> spinlock can be initialized automatically with DEFINE_SPINLOCK()
> rather than explicitly calling spin_lock_init().
>
> Reported-by: Hulk Robot
> Signed-off-by: Guobin Huang
Patch applied to wireless-drivers-next.git, thanks.
e9642be26a37 rtlwif
samirweng1979 wrote:
> From: wengjianfeng
>
> some function's label meaningless, the label statement follows
> the goto statement, no other statements, so just remove it.
>
> Reported-by: kernel test robot
> Signed-off-by: wengjianfeng
Patch applied to wireless-drivers-next.git, thanks.
fb
Christophe JAILLET wrote:
> The 'c2hcmd_lock' spinlock is only used to protect some __skb_queue_tail()
> and __skb_dequeue() calls.
> Use the lock provided in the skb itself and call skb_queue_tail() and
> skb_dequeue(). These functions already include the correct locking.
>
> Signed-off-by: Chr
Christophe JAILLET wrote:
> 'rtl_get_tid_h()' is the same as 'ieee80211_get_tid()'.
> So this function can be removed to save a line of code.
>
> Signed-off-by: Christophe JAILLET
Patch applied to wireless-drivers-next.git, thanks.
987e9bcdd0b7 rtlwifi: remove rtl_get_tid_h
--
https://patch
Yang Li wrote:
> Assigning value "3" to "rtlpriv->btcoexist.reg_bt_sco" here, but that
> stored value is overwritten before it can be used.
>
> Coverity reports this problem as
> CWE563: A value assigned to a variable is never used.
> drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c:
> rtl818
On Sat, Apr 17, 2021 at 3:58 PM Matthew Wilcox wrote:
> I wouldn't like to make that assumption. I've come across IOMMUs (maybe
> on parisc? powerpc?) that like to encode fun information in the top
> few bits. So we could get it down to 52 bits, but I don't think we can
> get all the way down t
Colin King wrote:
> From: Colin Ian King
>
> Variable err is assigned -ENODEV followed by an error return path
> via label error_out that does not access the variable and returns
> with the -ENODEV error return code. The assignment to err is
> redundant and can be removed.
>
> Addresses-Coveri
Bhaskar Chowdhury wrote:
> s/resovle/resolve/
> s/broadcase/broadcast/
> s/sytem/system/
>
> Signed-off-by: Bhaskar Chowdhury
> Acked-by: Randy Dunlap
Patch applied to wireless-drivers-next.git, thanks.
2377b1c49d48 rtlwifi: Few mundane typo fixes
--
https://patchwork.kernel.org/project/li
samirweng1979 wrote:
> From: wengjianfeng
>
> some function's label meaningless, the return statement follows
> the goto statement, so just remove it.
>
> Signed-off-by: wengjianfeng
> Reviewed-by: Sergey Matyukevich
Patch applied to wireless-drivers-next.git, thanks.
a221d0afbf39 qtnfmac:
Chen Lin wrote:
> From: Chen Lin
>
> Remove the 'wsm_*' typedef as it is not used.
>
> Signed-off-by: Chen Lin
Patch applied to wireless-drivers-next.git, thanks.
9dc5fdc8c4f8 cw1200: Remove unused function pointer typedef wsm_*
--
https://patchwork.kernel.org/project/linux-wireless/patch
Chen Lin wrote:
> From: Chen Lin
>
> Remove the 'cw1200_wsm_handler' typedef as it is not used.
>
> Signed-off-by: Chen Lin
Patch applied to wireless-drivers-next.git, thanks.
1c22233a745e cw1200: Remove unused function pointer typedef cw1200_wsm_handler
--
https://patchwork.kernel.org/pr
Lee Gibson wrote:
> Function qtnf_event_handle_external_auth calls memcpy without
> checking the length.
> A user could control that length and trigger a buffer overflow.
> Fix by checking the length is within the maximum allowed size.
>
> Signed-off-by: Lee Gibson
Please use clamp_val() inste
On Fri, Apr 16, 2021 at 12:27:39PM -0700, Jakub Kicinski wrote:
> Add an interface for reading standard stats, including
> stats which don't have a corresponding control interface.
>
> Start with IEEE 802.3 PHY stats. There seems to be only
> one stat to expose there.
>
> Define API to not requir
On Sat, Apr 17, 2021 at 04:48:53PM +, Al Viro wrote:
> On Sat, Apr 17, 2021 at 07:36:39AM -0700, Alexei Starovoitov wrote:
>
> > The kernel will perform the same work with FDs. The same locks are held
> > and the same execution conditions are in both cases. The LSM hooks,
> > fsnotify, etc wil
The pull request you sent on Fri, 16 Apr 2021 22:07:03 -0700:
> git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git tags/net-5.12-rc8
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/88a5af943985fb43b4c9472b5abd9c0b9705533d
Thank you!
--
Deet-doot-dot, I am a
On Sat, Apr 17, 2021 at 07:36:39AM -0700, Alexei Starovoitov wrote:
> The kernel will perform the same work with FDs. The same locks are held
> and the same execution conditions are in both cases. The LSM hooks,
> fsnotify, etc will be called the same way.
> It's no different if new syscall was in
On Fri, Apr 16, 2021 at 10:01 PM Masahiro Yamada wrote:
>
> Since commit d9f4ff50d2aa ("kbuild: spilt cc-option and friends to
> scripts/Makefile.compiler"), some kselftests fail to build.
>
> The tools/ directory opted out Kbuild, and went in a different
> direction. They copy any kind of files t
On Fri, Apr 16, 2021 at 10:01:43PM -0700, Alexei Starovoitov wrote:
> On Fri, Apr 16, 2021 at 9:04 PM Al Viro wrote:
> >
> > On Fri, Apr 16, 2021 at 08:46:05PM -0700, Alexei Starovoitov wrote:
> > > On Fri, Apr 16, 2021 at 8:42 PM Al Viro wrote:
> > > >
> > > > On Fri, Apr 16, 2021 at 08:32:20PM
On Sat, Apr 17, 2021 at 12:31:37PM +0200, Arnd Bergmann wrote:
> On Fri, Apr 16, 2021 at 5:27 PM Matthew Wilcox wrote:
> > diff --git a/include/net/page_pool.h b/include/net/page_pool.h
> > index b5b195305346..db7c7020746a 100644
> > --- a/include/net/page_pool.h
> > +++ b/include/net/page_pool.h
On Thu, Mar 4, 2021 at 2:04 AM Geert Uytterhoeven wrote:
>
> On Wed, Feb 24, 2021 at 12:52 PM Adam Ford wrote:
> > The AVB refererence clock assumes an external clock that runs
>
> reference
>
> > automatically. Because the Versaclock is wired to provide the
> > AVB refclock, the device tree nee
The call to clk_disable_unprepare() can happen before priv is
initialized. This means moving clk_disable_unprepare out of
out_release into a new label.
Fixes: 8ef7adc6beb2("net: ethernet: ravb: Enable optional refclk")
Signed-off-by: Adam Ford
diff --git a/drivers/net/ethernet/renesas/ravb_main.
From: Grygorii Strashko
> Sent: 16 April 2021 10:27
...
> Sry, for delayed reply.
>
> The TI platforms am3/4/5 (cpsw) and Keystone 2 (netcp) can do only 32bit DMA
> even in case of LPAE
> (dma-ranges are used).
> Originally, as I remember, CONFIG_ARCH_DMA_ADDR_T_64BIT has not been selected
> for
> On 2021/4/16 11:27, zhudi (J) wrote:
> >> dependencyOn 2021/4/15 11:35, zhudi wrote:
> >>> From: Di Zhu
> >>>
> >>> We encountered a crash: in the packet receiving process, we got an
> >>> illegal VLAN device address, but the VLAN device address saved in
> >>> vmcore is correct. After checking t
"Paul E. McKenney" writes:
> On Fri, Apr 16, 2021 at 11:22:52AM -0700, Martin KaFai Lau wrote:
>> On Fri, Apr 16, 2021 at 03:45:23PM +0200, Jesper Dangaard Brouer wrote:
>> > On Thu, 15 Apr 2021 17:39:13 -0700
>> > Martin KaFai Lau wrote:
>> >
>> > > On Thu, Apr 15, 2021 at 10:29:40PM +0200, To
Taking address of a function argument directly works just fine.
Signed-off-by: Alexey Dobriyan
---
include/linux/netlink.h | 12
1 file changed, 4 insertions(+), 8 deletions(-)
--- a/include/linux/netlink.h
+++ b/include/linux/netlink.h
@@ -129,23 +129,19 @@ struct netlink_ext_a
From: Matteo Croce
> Sent: 16 April 2021 23:44
...
> > A more interesting change would be something that generated:
> > unsigned int nr_frags = skb_shinfo(skb)->nr_frags;
> > for (i = 0; i < nr_frags; i++) {
> > since that will run faster for most loops.
> > But that is ~impossible
From: Matthew Wilcox
> Sent: 16 April 2021 16:28
>
> On Thu, Apr 15, 2021 at 08:08:32PM +0200, Jesper Dangaard Brouer wrote:
> > See below patch. Where I swap32 the dma address to satisfy
> > page->compound having bit zero cleared. (It is the simplest fix I could
> > come up with).
>
> I think t
On Fri, Apr 16, 2021 at 5:27 PM Matthew Wilcox wrote:
> diff --git a/include/net/page_pool.h b/include/net/page_pool.h
> index b5b195305346..db7c7020746a 100644
> --- a/include/net/page_pool.h
> +++ b/include/net/page_pool.h
> @@ -198,7 +198,17 @@ static inline void page_pool_recycle_direct(struct
On 2021/4/17 17:10, Marc Zyngier wrote:
On Sat, 17 Apr 2021 09:59:39 +0100,
Zenghui Yu wrote:
On 2021/3/30 22:54, Marc Zyngier wrote:
+PTP_KVM support for arm/arm64
+=
+
+PTP_KVM is used for high precision time sync between host and guests.
+It relies on transferri
On 16.04.2021 16:35, Thomas Bogendoerfer wrote:
On Fri, Apr 16, 2021 at 12:29:46PM +0300, Sergei Shtylyov wrote:
On 16.04.2021 11:52, Thomas Bogendoerfer wrote:
Add device tree bindings for ethernet controller integrated into
IDT 79RC3243x SoCs.
Signed-off-by: Thomas Bogendoerfer
---
.../
On 2021/3/30 22:54, Marc Zyngier wrote:
#define SMCCC_ARCH_WORKAROUND_RET_UNAFFECTED 1
I think it'd be better to keep this definition together with other
wa Function IDs. It's only a cosmetic comment anyway.
Zenghui
On 2021/3/30 22:54, Marc Zyngier wrote:
- u64 cycles;
- ktime_t real;
- ktime_t raw;
- unsigned intclock_was_set_seq;
- u8 cs_was_changed_seq;
+ u64 cycles;
+ ktime_t real;
+
On Sat, 17 Apr 2021 09:59:39 +0100,
Zenghui Yu wrote:
>
> On 2021/3/30 22:54, Marc Zyngier wrote:
> > +PTP_KVM support for arm/arm64
> > +=
> > +
> > +PTP_KVM is used for high precision time sync between host and guests.
> > +It relies on transferring the wall clock an
On Sat, 17 Apr 2021 09:42:37 +0100,
Zenghui Yu wrote:
>
> On 2021/3/30 22:54, Marc Zyngier wrote:
> > +int kvm_arch_ptp_init(void)
> > +{
> > + int ret;
> > +
> > + ret = kvm_arm_hyp_service_available(ARM_SMCCC_KVM_FUNC_PTP);
> > + if (ret <= 0)
>
> kvm_arm_hyp_service_available() returns
On 2021/3/30 22:54, Marc Zyngier wrote:
+PTP_KVM support for arm/arm64
+=
+
+PTP_KVM is used for high precision time sync between host and guests.
+It relies on transferring the wall clock and counter value from the
+host to the guest using a KVM-specific hypercall.
+
On 2021/3/30 22:54, Marc Zyngier wrote:
+int kvm_arch_ptp_init(void)
+{
+ int ret;
+
+ ret = kvm_arm_hyp_service_available(ARM_SMCCC_KVM_FUNC_PTP);
+ if (ret <= 0)
kvm_arm_hyp_service_available() returns boolean. Maybe write as ?
bool ret;
ret = kvm_arm_hyp_s
Le 16/04/2021 à 01:49, Alexei Starovoitov a écrit :
On Thu, Apr 15, 2021 at 8:41 AM Quentin Monnet wrote:
2021-04-15 16:37 UTC+0200 ~ Daniel Borkmann
On 4/15/21 11:32 AM, Jianlin Lv wrote:
For debugging JITs, dumping the JITed image to kernel log is discouraged,
"bpftool prog dump jited"
On Wed, Apr 14, 2021 at 07:15:37PM +0530, Devesh Sharma wrote:
> On Mon, Apr 12, 2021 at 1:10 PM Leon Romanovsky wrote:
> >
> > On Thu, Apr 08, 2021 at 08:42:57PM +0530, Devesh Sharma wrote:
> > > On Thu, Apr 8, 2021 at 5:14 PM Leon Romanovsky wrote:
> > > >
> > > > On Thu, Apr 08, 2021 at 05:06:
Hi David, Nico,
On 17/04/2021 06:24, David Gow wrote:
Hi Matt,
Like patch 1/6, I can apply it in MPTCP tree and send it later to
net-next with other patches.
Except if you guys prefer to apply it in KUnit tree and send it to
linux-next?
Given 1/6 is going to net-next, it makes sense to send
With any regulatory domain requests coming from either user space or
802.11 IE (Information Element), the country is coded in ISO3166
standard. It needs to be translated to firmware country code and
revision with the mapping info in settings->country_codes table.
Support populate country_codes tab
On Sat, Apr 17, 2021 at 12:42:39AM -0700, Keyu Man wrote:
> How about at least allow the existing queue to finish? Currently a tiny new
> fragment would potentially invalid all previous fragments by letting them
> timeout without allowing the fragments to come in to finish the assembly.
Because th
On Fri, Apr 16, 2021 at 2:00 PM Arend Van Spriel
wrote:
>
> On 4/15/2021 12:47 PM, Shawn Guo wrote:
> > With any regulatory domain requests coming from either user space or
> > 802.11 IE (Information Element), the country is coded in ISO3166
> > standard. It needs to be translated to firmware cou
Tested on Bananapi-r2 (please see my mt7623 patch for supporting offloading)
with ~300 iperf3 iterations and uptime >6h
Tested-by: Frank Wunderlich
regards Frank
On Sat, 17 Apr 2021 00:07:23 +0100
"Matthew Wilcox (Oracle)" wrote:
> 32-bit architectures which expect 8-byte alignment for 8-byte integers
> and need 64-bit DMA addresses (arc, arm, mips, ppc) had their struct
> page inadvertently expanded in 2019. When the dma_addr_t was added,
> it forced th
Issue was traffic problems after a while with increased ping times if
flow offload is active. It turns out that key_offset with cookie is
needed in rhashtable_params but was re-assigned to head_offset.
Fix the assignment.
Fixes: 502e84e2382d ("net: ethernet: mtk_eth_soc: add flow offloading suppor
On Sat, Apr 17, 2021 at 06:44:40AM +0200, Eric Dumazet wrote:
> On Sat, Apr 17, 2021 at 2:31 AM David Ahern wrote:
> >
> > [ cc author of 648700f76b03b7e8149d13cc2bdb3355035258a9 ]
>
> I think this has been discussed already. There is no strategy that
> makes IP reassembly units immune to DDOS at
'kasprintf()' can replace a kmalloc/strcpy/strcat sequence.
It is less verbose and avoid the use of a magic number (64).
Anyway, the underlying 'alloc_workqueue()' would only keep the 24 first
chars (i.e. sizeof(struct workqueue_struct->name) = WQ_NAME_LEN).
Signed-off-by: Christophe JAILLET
---
1 - 100 of 104 matches
Mail list logo
