Re: [PATCH 2/4] phy: phy-can-transceiver: Add support for generic CAN transceiver driver

2021-04-13 Thread Marc Kleine-Budde
On 14.04.2021 11:54:36, Aswath Govindraju wrote: > Hi Marc, > > On 12/04/21 3:48 pm, Marc Kleine-Budde wrote: > > On 4/9/21 3:40 PM, Aswath Govindraju wrote: > >> The driver adds support for generic CAN transceivers. Currently > >> the modes supported by this driver are standby and normal modes fo

Re: [PATCH] mac80211_hwsim: indicate support for 60GHz channels

2021-04-13 Thread Kalle Valo
Ramon Fontes writes: > Advertise 60GHz channels to mac80211. SoB missing: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#signed-off-by_missing -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documenta

Re: [PATCH v2 0/2][next] wl3501_cs: Fix out-of-bounds warnings

2021-04-13 Thread Kalle Valo
"Gustavo A. R. Silva" writes: > Friendly ping: could somebody give us some feedback or take > this series, please? First patch 2 comment needs to be resolved. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpa

Re: [PATCH 3/4] dt-bindings: net: can: Document transceiver implementation as phy

2021-04-13 Thread Aswath Govindraju
Hi Rob, On 12/04/21 11:21 pm, Rob Herring wrote: > On Fri, Apr 09, 2021 at 07:10:53PM +0530, Aswath Govindraju wrote: >> From: Faiz Abbas >> >> Some transceivers need a configuration step (for example, pulling the >> standby or enable lines) for them to start sending messages. The >> transceiver

Re: [PATCH 2/4] phy: phy-can-transceiver: Add support for generic CAN transceiver driver

2021-04-13 Thread Aswath Govindraju
Hi Marc, On 12/04/21 3:48 pm, Marc Kleine-Budde wrote: > On 4/9/21 3:40 PM, Aswath Govindraju wrote: >> The driver adds support for generic CAN transceivers. Currently >> the modes supported by this driver are standby and normal modes for TI >> TCAN1042 and TCAN1043 CAN transceivers. >> >> The tra

[PATCH net-next] r8169: add support for pause ethtool ops

2021-04-13 Thread Heiner Kallweit
This adds support for the [g|s]et_pauseparam ethtool ops. It considers that the chip doesn't support pause frame use in jumbo mode. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169_main.c | 28 +++ 1 file changed, 28 insertions(+) diff --git a/drivers/ne

RE: [net-next] enetc: fix locking for one-step timestamping packet transfer

2021-04-13 Thread Y.b. Lu
Hi Jakub, > -Original Message- > From: Jakub Kicinski > Sent: 2021年4月14日 1:11 > To: Y.b. Lu > Cc: netdev@vger.kernel.org; David S . Miller ; Richard > Cochran ; Claudiu Manoil > ; Vladimir Oltean ; > Russell King > Subject: Re: [net-next] enetc: fix locking for one-step timestamping pac

Re: [PATCH net-next] net: Space: remove hp100 probe

2021-04-13 Thread Arnd Bergmann
On Wed, Apr 14, 2021, 00:42 Stephen Hemminger wrote: > > On Tue, 13 Apr 2021 16:16:17 +0200 Arnd Bergmann wrote: > > > */ > > static struct devprobe2 isa_probes[] __initdata = { > > -#if defined(CONFIG_HP100) && defined(CONFIG_ISA) /* ISA, EISA */ > > - {hp100_probe, 0}, > > -#endif >

Re: [PATCH 1/2] kunit: Fix formatting of KUNIT tests to meet the standard

2021-04-13 Thread Greg KH
On Wed, Apr 14, 2021 at 12:33:02AM -0400, Nico Pache wrote: > There are few instances of KUNIT tests that are not properly defined. > This commit focuses on correcting these issues to match the standard > defined in the Documentation. > > Issues Fixed: > - Tests should default to KUNIT_ALL_TE

Re: [PATCH net-next v4 10/10] virtio-net: xsk zero copy xmit kick by threshold

2021-04-13 Thread Jason Wang
在 2021/4/13 上午11:15, Xuan Zhuo 写道: After testing, the performance of calling kick every time is not stable. And if all the packets are sent and kicked again, the performance is not good. So add a module parameter to specify how many packets are sent to call a kick. 8 is a relatively stable val

Re: [PATCH 1/2] kunit: Fix formatting of KUNIT tests to meet the standard

2021-04-13 Thread Greg KH
On Wed, Apr 14, 2021 at 12:33:02AM -0400, Nico Pache wrote: > There are few instances of KUNIT tests that are not properly defined. > This commit focuses on correcting these issues to match the standard > defined in the Documentation. > > Issues Fixed: > - Tests should default to KUNIT_ALL_TE

Re: [PATCH net-next v4 09/10] virtio-net: xsk zero copy xmit implement wakeup and xmit

2021-04-13 Thread Jason Wang
在 2021/4/13 上午11:15, Xuan Zhuo 写道: This patch implements the core part of xsk zerocopy xmit. When the user calls sendto to consume the data in the xsk tx queue, virtnet_xsk_wakeup() will be called. In wakeup, it will try to send a part of the data directly. There are two purposes for this rea

Re: [PATCH net-next v2 1/2] of: net: pass the dst buffer to of_get_mac_address()

2021-04-13 Thread Dan Carpenter
Hi Michael, url: https://github.com/0day-ci/linux/commits/Michael-Walle/of-net-support-non-platform-devices-in-of_get_mac_address/20210406-234030 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git cc0626c2aaed8e475efdd85fa374b497a7192e35 config: x86_64-randconfig-m001-

RE: [PATCH v4 05/23] ice: Add devlink params support

2021-04-13 Thread Parav Pandit
+ Jiri. > From: Saleem, Shiraz > Sent: Wednesday, April 14, 2021 5:51 AM > > > Subject: RE: [PATCH v4 05/23] ice: Add devlink params support > > > > > > > > > From: Saleem, Shiraz > > > Sent: Tuesday, April 13, 2021 8:11 PM > > [..] > > > > > > > > Parav is talking about generic ways to customi

Re: [RFC PATCH v8 11/19] virtio/vsock: dequeue callback for SOCK_SEQPACKET

2021-04-13 Thread Arseny Krasnov
I'll fix some issues of this patch found by kernel test robot On 13.04.2021 15:44, Arseny Krasnov wrote: > This adds transport callback and it's logic for SEQPACKET dequeue. > Callback fetches RW packets from rx queue of socket until whole record > is copied(if user's buffer is full, user is not w

[PATCH 2/2] m68k: update configs to match the proper KUNIT syntax

2021-04-13 Thread Nico Pache
No functional changes other than CONFIG name changes Signed-off-by: Nico Pache --- arch/m68k/configs/amiga_defconfig| 6 +++--- arch/m68k/configs/apollo_defconfig | 6 +++--- arch/m68k/configs/atari_defconfig| 6 +++--- arch/m68k/configs/bvme6000_defconfig | 6 +++--- arch/m68k/configs/

[PATCH 1/2] kunit: Fix formatting of KUNIT tests to meet the standard

2021-04-13 Thread Nico Pache
There are few instances of KUNIT tests that are not properly defined. This commit focuses on correcting these issues to match the standard defined in the Documentation. Issues Fixed: - Tests should default to KUNIT_ALL_TESTS - Tests configs tristate should have `if !KUNIT_ALL_TESTS` - Tests

Re: [PATCH net-next v4 08/10] virtio-net: xsk zero copy xmit setup

2021-04-13 Thread Jason Wang
在 2021/4/13 上午11:15, Xuan Zhuo 写道: xsk is a high-performance packet receiving and sending technology. This patch implements the binding and unbinding operations of xsk and the virtio-net queue for xsk zero copy xmit. The xsk zero copy xmit depends on tx napi. It's better to describe why ze

[PATCH] netfilter: nf_conntrack: Add conntrack helper for ESP/IPsec

2021-04-13 Thread Cole Dishington
Introduce changes to add ESP connection tracking helper to netfilter conntrack. The connection tracking of ESP is based on IPsec SPIs. The underlying motivation for this patch was to allow multiple VPN ESP clients to be distinguished when using NAT. Added config flag CONFIG_NF_CT_PROTO_ESP to enab

[PATCH net] ethtool: pause: make sure we init driver stats

2021-04-13 Thread Jakub Kicinski
The intention was for pause statistics to not be reported when driver does not have the relevant callback (only report an empty netlink nest). What happens currently we report all 0s instead. Make sure statistics are initialized to "not set" (which is -1) so the dumping code skips them. Fixes: 9a2

[PATCH net-next 6/6] mlx5: implement ethtool::get_fec_stats

2021-04-13 Thread Jakub Kicinski
Report corrected bits. Signed-off-by: Jakub Kicinski --- .../ethernet/mellanox/mlx5/core/en_ethtool.c | 9 ++ .../ethernet/mellanox/mlx5/core/en_stats.c| 28 +-- .../ethernet/mellanox/mlx5/core/en_stats.h| 2 ++ 3 files changed, 37 insertions(+), 2 deletions(-) di

[PATCH net-next 5/6] sfc: ef10: implement ethtool::get_fec_stats

2021-04-13 Thread Jakub Kicinski
Report what appears to be the standard block counts: - 30.5.1.1.17 aFECCorrectedBlocks - 30.5.1.1.18 aFECUncorrectableBlocks Don't report the per-lane symbol counts, if those really count symbols they are not what the standard calls for (even if symbols seem like the most useful thing to count.)

[PATCH net-next 3/6] ethtool: add FEC statistics

2021-04-13 Thread Jakub Kicinski
Similarly to pause statistics add stats for FEC. The IEEE standard mandates two sets of counters: - 30.5.1.1.17 aFECCorrectedBlocks - 30.5.1.1.18 aFECUncorrectableBlocks where block is a block of bits FEC operates on. Each of these counters is defined per lane (PCS instance). Multiple vendors p

[PATCH net-next 4/6] bnxt: implement ethtool::get_fec_stats

2021-04-13 Thread Jakub Kicinski
Report corrected bits. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c index 2f8b193a772

[PATCH net-next 2/6] ethtool: fec_prepare_data() - jump to error handling

2021-04-13 Thread Jakub Kicinski
Refactor fec_prepare_data() a little bit to skip the body of the function and exit on error. Currently the code depends on the fact that we only have one call which may fail between ethnl_ops_begin() and ethnl_ops_complete() and simply saves the error code. This will get hairy with the stats also b

[PATCH net-next 0/6] ethtool: add standard FEC statistics

2021-04-13 Thread Jakub Kicinski
Hi! This set adds uAPI for reporting standard FEC statistics, and implements it in a handful of drivers. The statistics are taken from the IEEE standard, with one extra seemingly popular but not standard statistics added. The implementation is similar to that of the pause frame statistics, user

[PATCH net-next 1/6] ethtool: move ethtool_stats_init

2021-04-13 Thread Jakub Kicinski
We'll need it for FEC stats as well. Signed-off-by: Jakub Kicinski --- include/linux/ethtool.h | 6 ++ net/ethtool/pause.c | 6 -- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h index 9f6f323af59a..069100b252bd 100644

Re: [PATCH net-next v4 07/10] virtio-net: virtnet_poll_tx support budget check

2021-04-13 Thread Jason Wang
在 2021/4/13 上午11:15, Xuan Zhuo 写道: virtnet_poll_tx() check the work done like other network card drivers. When work < budget, napi_poll() in dev.c will exit directly. And virtqueue_napi_complete() will be called to close napi. If closing napi fails or there is still data to be processed, virtq

Re: [PATCH net-next v4 06/10] virtio-net: unify the code for recycling the xmit ptr

2021-04-13 Thread Jason Wang
在 2021/4/13 上午11:15, Xuan Zhuo 写道: Now there are two types of "skb" and "xdp frame" during recycling old xmit. There are two completely similar and independent implementations. This is inconvenient for the subsequent addition of new types. So extract a function from this piece of code and call

Re: [PATCH v3 net-next] net: multipath routing: configurable seed

2021-04-13 Thread David Ahern
On 4/13/21 4:55 AM, Balaev Pavel wrote: > Ability for a user to assign seed value to multipath route hashes. > Now kernel uses random seed value to prevent hash-flooding DoS attacks; > however, it disables some use cases, f.e: > > +---++--+++ > | |-eth0---| FW

Re: [PATCH net-next 7/7] net: korina: Make driver COMPILE_TESTable

2021-04-13 Thread kernel test robot
Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Thomas-Bogendoerfer/net-Korina-improvements/20210414-045102 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 8ef7adc6beb

[PATCH net v3] i40e: fix the panic when running bpf in xdpdrv mode

2021-04-13 Thread kerneljasonxing
From: Jason Xing Fix this panic by adding more rules to calculate the value of @rss_size_max which could be used in allocating the queues when bpf is loaded, which, however, could cause the failure and then trigger the NULL pointer of vsi->rx_rings. Prio to this fix, the machine doesn't care abou

RE: Regression v5.12-rc3: net: stmmac: re-init rx buffers when mac resume back

2021-04-13 Thread Joakim Zhang
> -Original Message- > From: Thierry Reding > Sent: 2021年4月14日 0:07 > To: David S. Miller ; Jakub Kicinski > Cc: Joakim Zhang ; Jon Hunter > ; Giuseppe Cavallaro ; > Alexandre Torgue ; Jose Abreu > ; netdev@vger.kernel.org; Linux Kernel Mailing List > ; linux-tegra > Subject: Re: Regres

[PATCH net-next v2 2/3] net: intel: Remove unused function pointer typedef ixgbe_mc_addr_itr

2021-04-13 Thread Tony Nguyen
From: Chen Lin Remove the 'ixgbe_mc_addr_itr' typedef as it is not used. Signed-off-by: Chen Lin Tested-by: Dave Switzer Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ixgbe/ixgbe_type.h | 4 drivers/net/ethernet/intel/ixgbevf/vf.h | 3 --- 2 files changed, 7 deletions(

[PATCH net-next v2 1/3] ixgbe: Support external GBE SerDes PHY BCM54616s

2021-04-13 Thread Tony Nguyen
From: Jostar Yang The Broadcom PHY is used in switches, so add the ID, and hook it up. This upstreams the Linux kernel patch from the network operating system SONiC from February 2020 [1]. [1]: https://github.com/Azure/sonic-linux-kernel/pull/122 Signed-off-by: Jostar Yang Signed-off-by: Guoh

[PATCH net-next v2 3/3] net: ethernet: intel: Fix a typo in the file ixgbe_dcb_nl.c

2021-04-13 Thread Tony Nguyen
From: Bhaskar Chowdhury s/Reprogam/Reprogram/ Signed-off-by: Bhaskar Chowdhury Reviewed-by: Jesse Brandeburg Acked-by: Randy Dunlap Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_nl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/

[PATCH net-next v2 0/3][pull request] 10GbE Intel Wired LAN Driver Updates 2021-04-13

2021-04-13 Thread Tony Nguyen
This series contains updates to ixgbe and ixgbevf driver. Jostar Yang adds support for BCM54616s PHY for ixgbe. Chen Lin removes an unused function pointer for ixgbe and ixgbevf. Bhaskar Chowdhury fixes a typo in ixgbe. --- v2: - Dropped rx_error statistics patch The following are changes since

Re: [PATCH net-next 7/7] net: korina: Make driver COMPILE_TESTable

2021-04-13 Thread kernel test robot
Hi Thomas, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Thomas-Bogendoerfer/net-Korina-improvements/20210414-045102 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 8ef7a

[PATCH net-next v2] virtio-net: page_to_skb() use build_skb when there's sufficient tailroom

2021-04-13 Thread Xuan Zhuo
In page_to_skb(), if we have enough tailroom to save skb_shared_info, we can use build_skb to create skb directly. No need to alloc for additional space. And it can save a 'frags slot', which is very friendly to GRO. Here, if the payload of the received package is too small (less than GOOD_COPY_LE

Re: [PATCH net-next 1/2] net: hns3: PF add support for pushing link status to VFs

2021-04-13 Thread Huazhong Tan
On 2021/4/14 1:18, Jakub Kicinski wrote: On Tue, 13 Apr 2021 14:17:00 +0800 Huazhong Tan wrote: +static void hclge_push_link_status(struct hclge_dev *hdev) +{ + struct hclge_vport *vport; + int ret; + u16 i; + + for (i = 0; i < pci_num_vf(hdev->pdev); i++) { +

Re: [PATCH net v2] i40e: fix the panic when running bpf in xdpdrv mode

2021-04-13 Thread Jason Xing
On Wed, Apr 14, 2021 at 12:27 AM Jesse Brandeburg wrote: > > kerneljasonx...@gmail.com wrote: > > > From: Jason Xing > > Hi Jason, > > Sorry, I missed this on the first time: Added intel-wired-lan, > please include on any future submissions for Intel drivers. > get-maintainers script might help h

[PATCHv6 bpf-next 3/4] sample/bpf: add xdp_redirect_map_multi for redirect_map broadcast test

2021-04-13 Thread Hangbin Liu
This is a sample for xdp redirect broadcast. In the sample we could forward all packets between given interfaces. There is also an option -X that could enable 2nd xdp_prog on egress interface. Signed-off-by: Hangbin Liu --- samples/bpf/Makefile | 3 + samples/bpf/xdp_redir

[PATCHv6 bpf-next 4/4] selftests/bpf: add xdp_redirect_multi test

2021-04-13 Thread Hangbin Liu
Add a bpf selftest for new helper xdp_redirect_map_multi(). In this test there are 3 forward groups and 1 exclude group. The test will redirect each interface's packets to all the interfaces in the forward group, and exclude the interface in exclude map. Two maps (DEVMAP, DEVMAP_HASH) and two xdp

[PATCHv6 bpf-next 2/4] xdp: extend xdp_redirect_map with broadcast support

2021-04-13 Thread Hangbin Liu
This patch adds two flags BPF_F_BROADCAST and BPF_F_EXCLUDE_INGRESS to extend xdp_redirect_map for broadcast support. With BPF_F_BROADCAST the packet will be broadcasted to all the interfaces in the map. with BPF_F_EXCLUDE_INGRESS the ingress interface will be excluded when do broadcasting. When

[PATCHv6 bpf-next 1/4] bpf: run devmap xdp_prog on flush instead of bulk enqueue

2021-04-13 Thread Hangbin Liu
From: Jesper Dangaard Brouer This changes the devmap XDP program support to run the program when the bulk queue is flushed instead of before the frame is enqueued. This has a couple of benefits: - It "sorts" the packets by destination devmap entry, and then runs the same BPF program on all the

[PATCHv6 bpf-next 0/4] xdp: extend xdp_redirect_map with broadcast support

2021-04-13 Thread Hangbin Liu
Hi, This patchset is a new implementation for XDP multicast support based on my previous 2 maps implementation[1]. The reason is that Daniel think the exclude map implementation is missing proper bond support in XDP context. And there is a plan to add native XDP bonding support. Adding a exclude m

Re: [PATCHv2 RFC bpf-next 0/7] bpf: Add support for ftrace probe

2021-04-13 Thread Andrii Nakryiko
On Tue, Apr 13, 2021 at 7:57 AM Jiri Olsa wrote: > > hi, > sending another attempt on speeding up load of multiple probes > for bpftrace and possibly other tools (first post in [1]). > > This patchset adds support to attach bpf program directly to > ftrace probe as suggested by Steven and it speed

Re: [PATCH bpf-next 3/5] libbpf: add low level TC-BPF API

2021-04-13 Thread Andrii Nakryiko
On Tue, Apr 6, 2021 at 3:06 AM Toke Høiland-Jørgensen wrote: > > Andrii Nakryiko writes: > > > On Sat, Apr 3, 2021 at 10:47 AM Alexei Starovoitov > > wrote: > >> > >> On Sat, Apr 03, 2021 at 12:38:06AM +0530, Kumar Kartikeya Dwivedi wrote: > >> > On Sat, Apr 03, 2021 at 12:02:14AM IST, Alexei St

Re: [PATCH RFC v2 1/4] virtio: fix up virtio_disable_cb

2021-04-13 Thread Willem de Bruijn
> > > > > > > > > but even yours is also fixed I think. > > > > > > The common point is that a single spurious interrupt is not a problem. > > > The problem only exists if there are tons of spurious interrupts with no > > > real ones. For this to trigger, we keep polling the ring and while we do >

RE: [PATCH v4 05/23] ice: Add devlink params support

2021-04-13 Thread Saleem, Shiraz
> Subject: RE: [PATCH v4 05/23] ice: Add devlink params support > > > > > From: Saleem, Shiraz > > Sent: Tuesday, April 13, 2021 8:11 PM > [..] > > > > > > Parav is talking about generic ways to customize the aux devices > > > > > created and that would seem to serve the same function as this.

[PATCH net-next v4 1/1] net: stmmac: Add support for external trigger timestamping

2021-04-13 Thread Wong Vee Khee
From: Tan Tee Min The Synopsis MAC controller supports auxiliary snapshot feature that allows user to store a snapshot of the system time based on an external event. This patch add supports to the above mentioned feature. Users will be able to triggered capturing the time snapshot from user-spac

Re: [PATCH net-next 2/4] ixgbe: aggregate of all receive errors through netdev's rx_errors

2021-04-13 Thread Nguyen, Anthony L
On Fri, 2021-04-09 at 18:00 -0700, Jakub Kicinski wrote: > On Fri, 9 Apr 2021 12:03:12 -0700 Tony Nguyen wrote: > > From: Radoslaw Tyl > > > > The global rx error does not take into account all the error > > counters > > that are counted by device. > > > > Extend rx error with the following cou

Re: A data race between fanout_demux_rollover() and __fanout_unlink()

2021-04-13 Thread Willem de Bruijn
On Tue, Apr 13, 2021 at 6:55 PM Xie He wrote: > > On Tue, Apr 13, 2021 at 1:51 PM Gong, Sishuai wrote: > > > > Hi, > > > > We found a data race in linux-5.12-rc3 between af_packet.c functions > > fanout_demux_rollover() and __fanout_unlink() and we are able to reproduce > > it under x86. > > >

Re: [PATCH v3 net-next] net: multipath routing: configurable seed

2021-04-13 Thread David Miller
From: Balaev Pavel Date: Tue, 13 Apr 2021 14:55:04 +0300 > @@ -222,6 +230,9 @@ struct netns_ipv4 { > #ifdef CONFIG_IP_ROUTE_MULTIPATH > u8 sysctl_fib_multipath_use_neigh; > u8 sysctl_fib_multipath_hash_policy; > + int sysctl_fib_multipath_hash_seed; > + struct multipath_seed_

Re: [net-next 01/16] net/mlx5: E-Switch, let user to enable disable metadata

2021-04-13 Thread Jakub Kicinski
On Tue, 13 Apr 2021 15:40:24 -0700 Saeed Mahameed wrote: > > > Hence, allow user to disable metadata using driver specific devlink > > > parameter. > > > > > > Example to show and disable metadata before changing eswitch mode: > > > $ devlink dev param show pci/:06:00.0 name esw_port_metadata

Re: A data race between fanout_demux_rollover() and __fanout_unlink()

2021-04-13 Thread Xie He
On Tue, Apr 13, 2021 at 1:51 PM Gong, Sishuai wrote: > > Hi, > > We found a data race in linux-5.12-rc3 between af_packet.c functions > fanout_demux_rollover() and __fanout_unlink() and we are able to reproduce it > under x86. > > When the two functions are running together, __fanout_unlink() wi

Re: [PATCH net-next 3/3] net: stmmac: Add RK3566/RK3568 SoC support

2021-04-13 Thread Peter Geis
On Tue, Apr 13, 2021 at 5:03 PM Ezequiel Garcia wrote: > > From: David Wu > > Add constants and callback functions for the dwmac present > on RK3566 and RK3568 SoCs. As can be seen, the base structure > is the same, only registers and the bits in them moved slightly. > > RK3568 supports two MACs,

[PATCH iproute2] rdma: stat: initialize ret in stat_qp_show_parse_cb()

2021-04-13 Thread Andrea Claudi
In the unlikely case in which the mnl_attr_for_each_nested() cycle is not executed, this function return an uninitialized value. Fix this initializing ret to 0. Fixes: 5937552b42e4 ("rdma: Add "stat qp show" support") Signed-off-by: Andrea Claudi --- rdma/stat.c | 2 +- 1 file changed, 1 insert

[PATCH iproute2] nexthop: fix memory leak in add_nh_group_attr()

2021-04-13 Thread Andrea Claudi
grps is dinamically allocated with a calloc, and not freed in a return path in the for cycle. This commit fix it. While at it, make the function use a single return point. Fixes: 63df8e8543b0 ("Add support for nexthop objects") Signed-off-by: Andrea Claudi --- ip/ipnexthop.c | 14 +-

[PATCH iproute2] q_cake: remove useless check on argv

2021-04-13 Thread Andrea Claudi
In cake_parse_opt(), *argv is checked not to be null when parsing for overhead and mpu parameters. However this is useless, since *argv matches right before for "overhead" or "mpu". Signed-off-by: Andrea Claudi --- tc/q_cake.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --gi

[PATCH iproute2] devlink: always check strslashrsplit() return value

2021-04-13 Thread Andrea Claudi
strslashrsplit() return value is not checked in __dl_argv_handle(), despite the fact that it can return EINVAL. This commit fix it and make __dl_argv_handle() return error if strslashrsplit() return an error code. Fixes: 2f85a9c53587 ("devlink: allow to parse both devlink and port handle in the

[PATCH V2 net] ice: Re-organizes reqstd/avail {R,T}XQ check/code for efficiency+readability

2021-04-13 Thread Salil Mehta
If user has explicitly requested the number of {R,T}XQs, then it is unnecessary to get the count of already available {R,T}XQs from the PF avail_{r,t}xqs bitmap. This value will get overridden by user specified value in any case. This patch does minor re-organization of the code for improving the

Re: mmotm 2021-04-11-20-47 uploaded (bpf: xsk.c)

2021-04-13 Thread Randy Dunlap
On 4/13/21 3:18 PM, Andrii Nakryiko wrote: > On Mon, Apr 12, 2021 at 9:38 AM Randy Dunlap wrote: >> >> On 4/11/21 8:48 PM, a...@linux-foundation.org wrote: >>> The mm-of-the-moment snapshot 2021-04-11-20-47 has been uploaded to >>> >>>https://www.ozlabs.org/~akpm/mmotm/ >>> >>> mmotm-readme.tx

Re: [PATCH net-next] net: Space: remove hp100 probe

2021-04-13 Thread Stephen Hemminger
On Tue, 13 Apr 2021 16:16:17 +0200 Arnd Bergmann wrote: > From: Arnd Bergmann > > The driver was removed last year, but the static initialization got left > behind by accident. > > Fixes: a10079c66290 ("staging: remove hp100 driver") > Signed-off-by: Arnd Bergmann > --- > drivers/net/Space.c

Re: Re: [RFC] vsock: add multiple transports support for dgram

2021-04-13 Thread Jiang Wang .
Hi Jorgen, Thanks for the detailed explanation and I agree with you. For the bind list, my prototype is doing something similar to that. I will double check it. Hi Stefano, I don't have other questions for now. Thanks. Regards, Jiang On Tue, Apr 13, 2021 at 5:52 AM Stefano Garzarella wrote:

Re: [net-next 01/16] net/mlx5: E-Switch, let user to enable disable metadata

2021-04-13 Thread Saeed Mahameed
On Tue, 2021-04-13 at 13:21 -0700, Jakub Kicinski wrote: > On Tue, 13 Apr 2021 12:29:51 -0700 Saeed Mahameed wrote: > > Currently each packet inserted in eswitch is tagged with a internal > > metadata to indicate source vport. Metadata tagging is not always > > needed. Metadata insertion is needed

Re: [RFC] vsock: add multiple transports support for dgram

2021-04-13 Thread Jiang Wang .
On Tue, Apr 13, 2021 at 2:02 AM Jorgen Hansen wrote: > > > > > On 7 Apr 2021, at 20:25, Jiang Wang . wrote: > > > > On Wed, Apr 7, 2021 at 2:51 AM Jorgen Hansen wrote: > >> > >> > >>> On 6 Apr 2021, at 20:31, Jiang Wang wrote: > >>> > >>> From: "jiang.wang" > >>> > >>> Currently, only VMCI sup

Re: [PATCH] xen-netback: Check for hotplug-status existence before watching

2021-04-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 13 Apr 2021 16:25:12 +0100 you wrote: > The logic in connect() is currently written with the assumption that > xenbus_watch_pathfmt() will return an error for a node that does not > exist. This assumption is incorrect:

Re: [PATCH net] gro: ensure frag0 meets IP header alignment

2021-04-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 13 Apr 2021 05:41:35 -0700 you wrote: > From: Eric Dumazet > > After commit 0f6925b3e8da ("virtio_net: Do not pull payload in skb->head") > Guenter Roeck reported one failure in his tests using sh architecture. > > Af

Re: mmotm 2021-04-11-20-47 uploaded (bpf: xsk.c)

2021-04-13 Thread Andrii Nakryiko
On Mon, Apr 12, 2021 at 9:38 AM Randy Dunlap wrote: > > On 4/11/21 8:48 PM, a...@linux-foundation.org wrote: > > The mm-of-the-moment snapshot 2021-04-11-20-47 has been uploaded to > > > >https://www.ozlabs.org/~akpm/mmotm/ > > > > mmotm-readme.txt says > > > > README for mm-of-the-moment: > >

Re: [PATCH RFC v2 1/4] virtio: fix up virtio_disable_cb

2021-04-13 Thread Michael S. Tsirkin
On Tue, Apr 13, 2021 at 05:44:42PM -0400, Willem de Bruijn wrote: > On Tue, Apr 13, 2021 at 3:54 PM Michael S. Tsirkin wrote: > > > > On Tue, Apr 13, 2021 at 10:01:11AM -0400, Willem de Bruijn wrote: > > > On Tue, Apr 13, 2021 at 1:47 AM Michael S. Tsirkin > > > wrote: > > > > > > > > virtio_dis

Re: [PATCH v2 net-next] ionic: git_ts_info bit shifters

2021-04-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 13 Apr 2021 10:22:16 -0700 you wrote: > All the uses of HWTSTAMP_FILTER_* values need to be > bit shifters, not straight values. > > v2: fixed subject and added Cc Dan and SoB Allen > > Fixes: f8ba81da73fc ("ionic

Re: [PATCH net-next 0/2] net: ipa: add support for the SM8350 SoC

2021-04-13 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Tue, 13 Apr 2021 11:38:24 -0500 you wrote: > This small series adds IPA driver support for the Qualcomm SM8350 > SoC, which implements IPA v4.9. > > The first patch updates the DT binding, and depends on a previous > p

Re: [PATCH net-next] ionic: return -EFAULT if copy_to_user() fails

2021-04-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 13 Apr 2021 13:47:59 +0300 you wrote: > The copy_to_user() function returns the number of bytes that it wasn't > able to copy. We want to return -EFAULT to the user. > > Fixes: fee6efce565d ("ionic: add hw timesta

Re: [PATCH net-next v2 0/7] stmmac: add XDP ZC support

2021-04-13 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Tue, 13 Apr 2021 17:36:19 +0800 you wrote: > Hi, > > This is the v2 patch series to add XDP ZC support to stmmac driver. > > Summary of v2 patch change:- > > 6/7: fix synchronize_rcu() is called stmmac_disable_all_qu

Re: [PATCH v2] net/sctp: fix race condition in sctp_destroy_sock

2021-04-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 13 Apr 2021 21:10:31 +0300 you wrote: > If sctp_destroy_sock is called without sock_net(sk)->sctp.addr_wq_lock > held and sp->do_auto_asconf is true, then an element is removed > from the auto_asconf_splist without any p

Re: [PATCHv4 bpf-next 1/5] bpf: Allow trampoline re-attach for tracing and lsm programs

2021-04-13 Thread Andrii Nakryiko
On Mon, Apr 12, 2021 at 9:28 AM Jiri Olsa wrote: > > Currently we don't allow re-attaching of trampolines. Once > it's detached, it can't be re-attach even when the program > is still loaded. > > Adding the possibility to re-attach the loaded tracing and > lsm programs. > > Fixing missing unlock w

Re: [PATCH] rsi: remove unused including

2021-04-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 13 Apr 2021 17:46:12 +0800 you wrote: > Fix the following versioncheck warning: > ./drivers/net/wireless/rsi/rsi_91x_ps.c: 19 linux/version.h not needed. > > Reported-by: Abaci Robot > Signed-off-by: Yang Li > --

Re: [PATCH net-next v2] ibmvnic: queue reset work in system_long_wq

2021-04-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 13 Apr 2021 14:33:39 -0500 you wrote: > The reset process for ibmvnic commonly takes multiple seconds, clearly > making it inappropriate for schedule_work/system_wq. The reason to make > this change is that ibmvnic'

Re: [PATCH] nfc: st-nci: remove unnecessary label

2021-04-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 13 Apr 2021 17:45:30 +0800 you wrote: > From: wengjianfeng > > in st_nci_spi_write function, first assign a value to a variable then > goto exit label. return statement just follow the label and exit label > just

Re: pull-request: can-next 2021-04-13

2021-04-13 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net-next.git (refs/heads/master): On Tue, 13 Apr 2021 11:51:47 +0200 you wrote: > Hello Jakub, hello David, > > this is a pull request of 14 patches for net-next/master. > > The first patch is by Yoshihiro Shimoda and updates the DT bindings > for

Re: [PATCH net] ibmvnic: correctly use dev_consume/free_skb_irq

2021-04-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 13 Apr 2021 03:33:25 -0500 you wrote: > It is more correct to use dev_kfree_skb_irq when packets are dropped, > and to use dev_consume_skb_irq when packets are consumed. > > Fixes: 0d973388185d ("ibmvnic: Introduce xmit

Re: [PATCHv4 bpf-next 4/5] selftests/bpf: Add re-attach test to lsm test

2021-04-13 Thread Andrii Nakryiko
On Mon, Apr 12, 2021 at 9:31 AM Jiri Olsa wrote: > > Adding the test to re-attach (detach/attach again) lsm programs, > plus check that already linked program can't be attached again. > > Signed-off-by: Jiri Olsa > --- > .../selftests/bpf/prog_tests/test_lsm.c | 48 +++ > 1

Re: [PATCHv4 bpf-next 3/5] selftests/bpf: Add re-attach test to fexit_test

2021-04-13 Thread Andrii Nakryiko
On Mon, Apr 12, 2021 at 9:30 AM Jiri Olsa wrote: > > Adding the test to re-attach (detach/attach again) tracing > fexit programs, plus check that already linked program can't > be attached again. > > Also switching to ASSERT* macros. > > Signed-off-by: Jiri Olsa > --- > .../selftests/bpf/prog_te

Re: [PATCHv4 bpf-next 2/5] selftests/bpf: Add re-attach test to fentry_test

2021-04-13 Thread Andrii Nakryiko
On Mon, Apr 12, 2021 at 9:29 AM Jiri Olsa wrote: > > Adding the test to re-attach (detach/attach again) tracing > fentry programs, plus check that already linked program can't > be attached again. > > Also switching to ASSERT* macros and adding missing ';' in > ASSERT_ERR_PTR macro. > > Signed-off

Re: [PATCH net-next V2] icmp: ICMPV6: pass RFC 8335 reply messages to ping_rcv

2021-04-13 Thread Willem de Bruijn
On Mon, Apr 12, 2021 at 5:25 PM Andreas Roeseler wrote: > > The current icmp_rcv function drops all unknown ICMP types, including > ICMP_EXT_ECHOREPLY (type 43). In order to parse Extended Echo Reply messages, > we have > to pass these packets to the ping_rcv function, which does not do any > oth

Re: [PATCH v2 0/2][next] wl3501_cs: Fix out-of-bounds warnings

2021-04-13 Thread Gustavo A. R. Silva
Hi all, Friendly ping: could somebody give us some feedback or take this series, please? Thanks -- Gustavo On 3/31/21 16:43, Gustavo A. R. Silva wrote: > Fix the a couple of out-of-bounds warnings by making the code > a bit more structured. > > This helps with the ongoing efforts to enable -Wa

Re: [PATCH net-next v2] ibmvnic: improve failover sysfs entry

2021-04-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 13 Apr 2021 03:31:44 -0500 you wrote: > The current implementation relies on H_IOCTL call to issue a > H_SESSION_ERR_DETECTED command to let the hypervisor to send a failover > signal. However, it may not work if th

Re: [PATCH net-next] net: dsa: lantiq_gswip: Add support for dumping the registers

2021-04-13 Thread Hauke Mehrtens
On 4/13/21 12:24 AM, Martin Blumenstingl wrote: Hi Andrew, On Mon, Apr 12, 2021 at 1:16 AM Andrew Lunn wrote: On Sun, Apr 11, 2021 at 10:55:11PM +0200, Martin Blumenstingl wrote: Add support for .get_regs_len and .get_regs so it is easier to find out about the state of the ports on the GSWIP

Re: [PATCH v2 2/2][next] wl3501_cs: Fix out-of-bounds warning in wl3501_mgmt_join

2021-04-13 Thread Gustavo A. R. Silva
Hi all! On 4/7/21 14:02, Kees Cook wrote: > On Wed, Mar 31, 2021 at 04:45:34PM -0500, Gustavo A. R. Silva wrote: >> Fix the following out-of-bounds warning by enclosing >> some structure members into new struct req: >> >> arch/x86/include/asm/string_32.h:182:25: warning: '__builtin_memcpy' offset

Re: [PATCH RFC v2 1/4] virtio: fix up virtio_disable_cb

2021-04-13 Thread Willem de Bruijn
On Tue, Apr 13, 2021 at 3:54 PM Michael S. Tsirkin wrote: > > On Tue, Apr 13, 2021 at 10:01:11AM -0400, Willem de Bruijn wrote: > > On Tue, Apr 13, 2021 at 1:47 AM Michael S. Tsirkin wrote: > > > > > > virtio_disable_cb is currently a nop for split ring with event index. > > > This is because it

Re: [BUG]: WARNING: CPU: 5 PID: 0 at net/sched/sch_generic.c:442 dev_watchdog+0x24d/0x260

2021-04-13 Thread Xose Vazquez Perez
On 4/13/21 11:07 PM, Heiner Kallweit wrote: On 13.04.2021 22:59, Xose Vazquez Perez wrote: A non-recurring bug, on 5.11.12-300.fc34.x86_64 (Fedora kernel). Thanks. 0c:00.0 Ethernet controller [0200]: Realtek Semiconductor Co., Ltd. RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller

Re: [PATCH net-next v2] net: dsa: mt7530: Add support for EEE features

2021-04-13 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 12 Apr 2021 08:50:31 +0200 you wrote: > This patch adds EEE support. > > Signed-off-by: René van Dorst > --- > v1 -> v2: > - Refactor the mt753x_{get,set}_mac_eee(). > As DENQ Qingfang mentioned, most things are

Re: [PATCH net-next v4 0/2] of: net: support non-platform devices in of_get_mac_address()

2021-04-13 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Mon, 12 Apr 2021 19:47:16 +0200 you wrote: > of_get_mac_address() is commonly used to fetch the MAC address > from the device tree. It also supports reading it from a NVMEM > provider. But the latter is only possible fo

Re: [PATCH 1/2] net: sit: Unregister catch-all devices

2021-04-13 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Mon, 12 Apr 2021 20:41:16 +0300 you wrote: > A sit interface created without a local or a remote address is linked > into the `sit_net::tunnels_wc` list of its original namespace. When > deleting a network namespace, delete

Re: pull-request: wireless-drivers-next-2021-04-13

2021-04-13 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net-next.git (refs/heads/master): On Tue, 13 Apr 2021 05:33:45 + (UTC) you wrote: > Hi, > > here's a pull request to net-next tree, more info below. Please let me know if > there are any problems. > > Kalle > > [...] Here is the summary with

RE: [Intel-wired-lan] [PATCH] i40e: The state of phy may not be correct during power-on

2021-04-13 Thread Kubalewski, Arkadiusz
>On 4/10/21 2:12 AM, Kubalewski, Arkadiusz wrote: >>> -Original Message- >>> From: Intel-wired-lan On Behalf Of >>> xiao33...@qq.com >>> Sent: piątek, 9 kwietnia 2021 11:18 >>> To: Brandeburg, Jesse ; Nguyen, Anthony L >>> >>> Cc: netdev@vger.kernel.org; xiaolinkui ; >>> linux-ker...@v

Re: [BUG]: WARNING: CPU: 5 PID: 0 at net/sched/sch_generic.c:442 dev_watchdog+0x24d/0x260

2021-04-13 Thread Heiner Kallweit
On 13.04.2021 22:59, Xose Vazquez Perez wrote: > A non-recurring bug, on 5.11.12-300.fc34.x86_64 (Fedora kernel). > > Thanks. > > > 0c:00.0 Ethernet controller [0200]: Realtek Semiconductor Co., Ltd. > RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller [10ec:8168] (rev 06) > > [    2.96

[PATCH net-next 3/3] net: stmmac: Add RK3566/RK3568 SoC support

2021-04-13 Thread Ezequiel Garcia
From: David Wu Add constants and callback functions for the dwmac present on RK3566 and RK3568 SoCs. As can be seen, the base structure is the same, only registers and the bits in them moved slightly. RK3568 supports two MACs, and RK3566 support just one. Signed-off-by: David Wu [Ezequiel: Add

[PATCH net-next 2/3] net: stmmac: dwmac-rk: Check platform-specific ops

2021-04-13 Thread Ezequiel Garcia
From: David Wu Add a check for non-null struct rk_gmac_ops for the configured PHY interface mode, failing if unsupported. Signed-off-by: David Wu [Ezequiel: Refactor so it fails if unsupported] Signed-off-by: Ezequiel Garcia --- .../net/ethernet/stmicro/stmmac/dwmac-rk.c| 31 +

  1   2   3   4   >