[PATCH] i40e: fix the panic when running bpf in xdpdrv mode

2021-04-11 Thread kerneljasonxing
From: Jason Xing Fix this by add more rules to calculate the value of @rss_size_max which could be used in allocating the queues when bpf is loaded, which, however, could cause the failure and then triger the NULL pointer of vsi->rx_rings. Prio to this fix, the machine doesn't care about how many

Re: [PATCH net-next] net: dsa: mt7530: Add support for EEE features

2021-04-11 Thread René van Dorst
Quoting DENG Qingfang : Hi Qingfang, Thanks for the review. Hi René, On Sat, Apr 10, 2021 at 6:54 AM René van Dorst wrote: --- a/drivers/net/dsa/mt7530.c +++ b/drivers/net/dsa/mt7530.c @@ -2568,6 +2568,11 @@ static void mt753x_phylink_mac_link_up(struct dsa_switch *ds, int port,

Re: [Patch net] smc: disallow TCP_ULP in smc_setsockopt()

2021-04-11 Thread Karsten Graul
On 10/04/2021 20:17, Cong Wang wrote: > From: Cong Wang > > syzbot is able to setup kTLS on an SMC socket, which coincidentally > uses sk_user_data too, later, kTLS treats it as psock so triggers a > refcnt warning. The cause is that smc_setsockopt() simply calls > TCP setsockopt(). I do not t

[PATCH net-next v2] net: dsa: mt7530: Add support for EEE features

2021-04-11 Thread René van Dorst
This patch adds EEE support. Signed-off-by: René van Dorst --- v1 -> v2: - Refactor the mt753x_{get,set}_mac_eee(). As DENQ Qingfang mentioned, most things are set else were. These functions only set/report the LPI timeout value/LPI timeout enable bit. - Removed the variable "eee_enabled", do

RE: [PATCH net-next 0/3] net: add new properties for of_get_mac_address from nvmem

2021-04-11 Thread Joakim Zhang
Hi Jabuk, > -Original Message- > From: Jakub Kicinski > Sent: 2021年4月10日 2:44 > To: Joakim Zhang > Cc: da...@davemloft.net; robh...@kernel.org; and...@lunn.ch; > hkallwe...@gmail.com; li...@armlinux.org.uk; frowand.l...@gmail.com; > netdev@vger.kernel.org; devicet...@vger.kernel.org; >

RE: [PATCH net-next 1/3] dt-bindings: net: add new properties for of_get_mac_address from nvmem

2021-04-11 Thread Joakim Zhang
Hi Rob, > -Original Message- > From: Rob Herring > Sent: 2021年4月9日 21:50 > To: Joakim Zhang > Cc: David Miller ; Jakub Kicinski ; > Andrew Lunn ; Heiner Kallweit ; > Russell King ; Frank Rowand > ; netdev ; > devicet...@vger.kernel.org; linux-ker...@vger.kernel.org; dl-linux-imx > > Su

Re: [PATCH net] virtio_net: Do not pull payload in skb->head

2021-04-11 Thread Guenter Roeck
Hi Eric, On Mon, Apr 12, 2021 at 07:53:43AM +0200, Eric Dumazet wrote: > On Mon, Apr 12, 2021 at 7:48 AM Eric Dumazet wrote: > > > > > give a verdict. > > > > Please post the whole strace output. > > > > Thanks. > > Also please add -tt option to strace so that we have an idea of time > delays j

Re: [PATCH v2 1/9] riscv: add __init section marker to some functions

2021-04-11 Thread Jisheng Zhang
On Fri, 2 Apr 2021 09:38:02 +0530 Anup Patel wrote: > > > On Wed, Mar 31, 2021 at 10:00 PM Jisheng Zhang > wrote: > > > > From: Jisheng Zhang > > > > They are not needed after booting, so mark them as __init to move them > > to the __init section. > > > > Signed-off-by: Jisheng Zhang > > --

linux-next: build failure after merge of the net-next tree

2021-04-11 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (x86_64 allmodconfig) failed like this: In file included from include/asm-generic/bug.h:20, from arch/x86/include/asm/bug.h:93, from include/linux/bug.h:5, from include/linux/mmdeb

[PATCH net-next 2/2] netfilter: conntrack: Make global sysctls readonly in non-init netns

2021-04-11 Thread Jonathon Reinhart
These sysctls point to global variables: - NF_SYSCTL_CT_MAX (&nf_conntrack_max) - NF_SYSCTL_CT_EXPECT_MAX (&nf_ct_expect_max) - NF_SYSCTL_CT_BUCKETS (&nf_conntrack_htable_size_user) Because their data pointers are not updated to point to per-netns structures, they must be marked read-only in a non

[PATCH net-next 1/2] net: Ensure net namespace isolation of sysctls

2021-04-11 Thread Jonathon Reinhart
This adds an ensure_safe_net_sysctl() check during register_net_sysctl() to validate that sysctl table entries for a non-init_net netns are sufficiently isolated. To be netns-safe, an entry must adhere to at least (and usually exactly) one of these rules: 1. It is marked read-only inside the netns

[PATCH net-next 0/2] Ensuring net sysctl isolation

2021-04-11 Thread Jonathon Reinhart
This patchset is the result of an audit of /proc/sys/net to prove that it is safe to be mouted read-write in a container when a net namespace is in use. See [1]. The first commit adds code to detect sysctls which are not netns-safe, and can "leak" changes to other net namespaces. My manual audit

[RFC v4 net-next 4/4] staging: mt7621-dts: enable MT7530 interrupt controller

2021-04-11 Thread DENG Qingfang
Enable MT7530 interrupt controller in the MT7621 SoC. Signed-off-by: DENG Qingfang Reviewed-by: Andrew Lunn --- RFC v3 -> RFC v4: - Add #interrupt-cells property. drivers/staging/mt7621-dts/mt7621.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/mt7621-dts/mt7621.dt

[RFC v4 net-next 3/4] dt-bindings: net: dsa: add MT7530 interrupt controller binding

2021-04-11 Thread DENG Qingfang
Add device tree binding to support MT7530 interrupt controller. Signed-off-by: DENG Qingfang Reviewed-by: Andrew Lunn --- RFC v3 -> RFC v4: - Add #interrupt-cells property. Documentation/devicetree/bindings/net/dsa/mt7530.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentat

[RFC v4 net-next 2/4] net: dsa: mt7530: add interrupt support

2021-04-11 Thread DENG Qingfang
Add support for MT7530 interrupt controller to handle internal PHYs. In order to assign an IRQ number to each PHY, the registration of MDIO bus is also done in this driver. Signed-off-by: DENG Qingfang --- RFC v3 -> RFC v4: - No changes. drivers/net/dsa/Kconfig | 1 + drivers/net/dsa/mt7530.

[RFC v4 net-next 1/4] net: phy: add MediaTek PHY driver

2021-04-11 Thread DENG Qingfang
Add support for MediaTek PHYs found in MT7530 and MT7531 switches. The initialization procedure is from the vendor driver, but due to lack of documentation, the function of some register values remains unknown. Signed-off-by: DENG Qingfang --- RFC v3 -> RFC v4: - Remove unused include. drivers/

[RFC v4 net-next 0/4] MT7530 interrupt support

2021-04-11 Thread DENG Qingfang
Add support for MT7530 interrupt controller. DENG Qingfang (4): net: phy: add MediaTek PHY driver net: dsa: mt7530: add interrupt support dt-bindings: net: dsa: add MT7530 interrupt controller binding staging: mt7621-dts: enable MT7530 interrupt controller .../devicetree/bindings/net/dsa

Re: [PATCH net v3] net: sched: fix packet stuck problem for lockless qdisc

2021-04-11 Thread Yunsheng Lin
On 2021/4/12 11:21, Hillf Danton wrote: > On Mon, 12 Apr 2021 09:24:30 Yunsheng Lin wrote: >> On 2021/4/9 17:09, Hillf Danton wrote: >>> On Fri, 9 Apr 2021 07:31:03 Juergen Gross wrote: On 25.03.21 04:13, Yunsheng Lin wrote: I have a setup which is able to reproduce the issue quite reli

Re: [PATCH RFC net-next 1/3] net: dsa: allow for multiple CPU ports

2021-04-11 Thread DENG Qingfang
On Sat, Apr 10, 2021 at 03:34:47PM +0200, Ansuel Smith wrote: > Allow for multiple CPU ports in a DSA switch tree. By default the first > CPU port is assigned mimic the original assignement logic. A DSA driver > can define a function to declare a preferred CPU port based on the > provided port. If

[PATCH v2] nfc: pn533: remove redundant assignment

2021-04-11 Thread samirweng1979
From: wengjianfeng In many places,first assign a value to a variable and then return the variable. which is redundant, we should directly return the value. in pn533_rf_field funciton,return rc also in the if statement, so we use return 0 to replace the last return rc. Signed-off-by: wengjianfeng

Re: Re: Re: [PATCH v6 03/10] vhost-vdpa: protect concurrent access to vhost device iotlb

2021-04-11 Thread Yongji Xie
On Mon, Apr 12, 2021 at 4:49 AM Michael S. Tsirkin wrote: > > On Sun, Apr 11, 2021 at 01:36:18PM +0800, Yongji Xie wrote: > > On Sat, Apr 10, 2021 at 12:16 AM Michael S. Tsirkin wrote: > > > > > > On Wed, Mar 31, 2021 at 04:05:12PM +0800, Xie Yongji wrote: > > > > Use vhost_dev->mutex to protect

Re: BUG: unable to handle kernel paging request in __build_skb

2021-04-11 Thread Willem de Bruijn
On Sun, Apr 11, 2021 at 9:31 PM Hao Sun wrote: > > Hi > > When using Healer(https://github.com/SunHao-0/healer/tree/dev) to fuzz > the Linux kernel, I found the following bug report, but I'm not sure > about this. > Sorry, I do not have a reproducing program for this bug. > I hope that the stack t

Re: [PATCH net-next] [RESEND] wireguard: disable in FIPS mode

2021-04-11 Thread Hangbin Liu
On Fri, Apr 09, 2021 at 12:29:42PM -0600, Jason A. Donenfeld wrote: > On Fri, Apr 9, 2021 at 2:08 AM Hangbin Liu wrote: > > After offline discussion with Herbert, here is > > what he said: > > > > """ > > This is not a problem in RHEL8 because the Crypto API RNG replaces > > /dev/random > > in FI

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-11 Thread Florian Fainelli
On 4/11/2021 4:53 PM, Vladimir Oltean wrote: > On Sun, Apr 11, 2021 at 09:50:17PM +0300, Vladimir Oltean wrote: >> On Sun, Apr 11, 2021 at 08:01:35PM +0200, Marek Behun wrote: >>> On Sat, 10 Apr 2021 15:34:46 +0200 >>> Ansuel Smith wrote: >>> Hi, this is a respin of the Marek series i

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-11 Thread Florian Fainelli
On 4/11/2021 11:39 AM, Andrew Lunn wrote: > On Sun, Apr 11, 2021 at 08:01:35PM +0200, Marek Behun wrote: >> On Sat, 10 Apr 2021 15:34:46 +0200 >> Ansuel Smith wrote: >> >>> Hi, >>> this is a respin of the Marek series in hope that this time we can >>> finally make some progress with dsa support

RE: flexcan introduced a DIV/0 in kernel

2021-04-11 Thread Joakim Zhang
Hi Koen, Mac, Sorry about this regression, it has caused inconvenience to many people. I tested the first version, but only double check the logic after improving the patch per Mac's advice. I will keep in mind, test each version before upstream to avoid unexpected issues, sorry. Best Regard

Re: [PATCH 1/2] dt-binding: bcm43xx-fmac: add optional brcm,ccode-map

2021-04-11 Thread Shawn Guo
On Sun, Apr 11, 2021 at 10:57:54AM +0300, Kalle Valo wrote: > Shawn Guo writes: > > > Add optional brcm,ccode-map property to support translation from ISO3166 > > country code to brcmfmac firmware country code and revision. > > > > Signed-off-by: Shawn Guo > > --- > > .../devicetree/bindings/ne

Re: [PATCH net v3] net: sched: fix packet stuck problem for lockless qdisc

2021-04-11 Thread Yunsheng Lin
On 2021/4/9 17:09, Hillf Danton wrote: > On Fri, 9 Apr 2021 07:31:03 Juergen Gross wrote: >> On 25.03.21 04:13, Yunsheng Lin wrote: >> I have a setup which is able to reproduce the issue quite reliably: >> >> In a Xen guest I'm mounting 8 NFS shares and run sysbench fileio on >> each of them. The

Re: [PATCH net] net: flow_offload: Fix UBSAN invalid-load warning in tcf_block_unbind

2021-04-11 Thread Jianbo Liu
The 04/09/2021 09:01, Jakub Kicinski wrote: > On Fri, 9 Apr 2021 06:25:56 + Jianbo Liu wrote: > > The 04/08/2021 14:16, Jakub Kicinski wrote: > > > On Thu, 8 Apr 2021 07:47:18 + Jianbo Liu wrote: > > > > When device is removed, indirect block is unregisterd. As > > > > bo->unlocked_driver

Re: [PATCH 1/2] dt-binding: bcm43xx-fmac: add optional brcm,ccode-map

2021-04-11 Thread Shawn Guo
On Fri, Apr 09, 2021 at 01:46:06PM -0500, Rob Herring wrote: > On Thu, Apr 08, 2021 at 07:30:21PM +0800, Shawn Guo wrote: > > Add optional brcm,ccode-map property to support translation from ISO3166 > > country code to brcmfmac firmware country code and revision. > > > > Signed-off-by: Shawn Guo

Re: [PATCH 1/1] mm: Fix struct page layout on 32-bit systems

2021-04-11 Thread Matthew Wilcox
On Sun, Apr 11, 2021 at 11:33:18AM +0100, Matthew Wilcox wrote: > Basically, we have three aligned dwords here. We can either alias with > @flags and the first word of @lru, or the second word of @lru and @mapping, > or @index and @private. @flags is a non-starter. If we use @mapping, > then you

Re: [PATCH net v3] net: sched: fix packet stuck problem for lockless qdisc

2021-04-11 Thread Yunsheng Lin
On 2021/4/9 13:31, Juergen Gross wrote: > On 25.03.21 04:13, Yunsheng Lin wrote: >> Lockless qdisc has below concurrent problem: >> cpu0 cpu1 >> . . >> q->enqueue . >> . . >> qdisc_run_begin() . >>

[PATCH net-next v2 3/3] net: use skb_for_each_frag() in illegal_highdma()

2021-04-11 Thread Matteo Croce
From: Matteo Croce Coccinelle failed with the following error: EXN: Failure("no position information") in net/core/dev.c Apply it by hand as it's trivial. Signed-off-by: Matteo Croce --- net/core/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/dev.c b/net/

[PATCH net-next v2 2/3] net: use skb_for_each_frag() helper where possible

2021-04-11 Thread Matteo Croce
From: Matteo Croce use the new helper macro skb_for_each_frag() which allows to iterate through all the SKB fragments. The patch was created with Coccinelle, this was the semantic patch: @@ struct sk_buff *skb; identifier i; statement S; iterator name skb_for_each_frag; @@ -for (i = 0; i < skb_

[PATCH net-next v2 0/3] introduce skb_for_each_frag()

2021-04-11 Thread Matteo Croce
From: Matteo Croce Introduce skb_for_each_frag, an helper macro to iterate over the SKB frags. First patch introduces the helper, the second one is generated with coccinelle and uses the macro where possible. Last one is a chunk which have to be applied by hand. The second patch raises some che

[PATCH net-next v2 1/3] skbuff: add helper to walk over the fraglist

2021-04-11 Thread Matteo Croce
From: Matteo Croce Add an skb_for_each_frag() macro to iterate on SKB fragments. Signed-off-by: Matteo Croce --- include/linux/skbuff.h | 4 1 file changed, 4 insertions(+) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index dbf820a50a39..a8d4ccacdda5 100644 --- a/include/

[PATCH net-next 4/5] bnxt_en: Refactor __bnxt_vf_reps_destroy().

2021-04-11 Thread Michael Chan
Add a new helper function __bnxt_free_one_vf_rep() to free one VF rep. We also reintialize the VF rep fields to proper initial values so that the function can be used without freeing the VF rep data structure. This will be used in subsequent patches to free and recreate VF reps after error recover

[PATCH net-next 3/5] bnxt_en: Refactor bnxt_vf_reps_create().

2021-04-11 Thread Michael Chan
From: Sriharsha Basavapatna Add a new function bnxt_alloc_vf_rep() to allocate a VF representor. This function will be needed in subsequent patches to recreate the VF reps after error recovery. Signed-off-by: Sriharsha Basavapatna Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/

[PATCH net-next 5/5] bnxt_en: Free and allocate VF-Reps during error recovery.

2021-04-11 Thread Michael Chan
From: Sriharsha Basavapatna During firmware recovery, VF-Rep configuration in the firmware is lost. Fix it by freeing and (re)allocating VF-Reps in FW at relevant points during the error recovery process. Signed-off-by: Sriharsha Basavapatna Signed-off-by: Michael Chan --- drivers/net/etherne

[PATCH net-next 0/5] bnxt_en: Error recovery fixes.

2021-04-11 Thread Michael Chan
This series adds some fixes and enhancements to the error recovery logic. The health register logic is improved and we also add missing code to free and re-create VF representors in the firmware after error recovery. Michael Chan (2): bnxt_en: Treat health register value 0 as valid in bnxt_

[PATCH net-next 1/5] bnxt_en: Treat health register value 0 as valid in bnxt_try_reover_fw().

2021-04-11 Thread Michael Chan
The retry loop in bnxt_try_recover_fw() should not abort when the health register value is 0. It is a valid value that indicates the firmware is booting up. Fixes: 861aae786f2f ("bnxt_en: Enhance retry of the first message to the firmware.") Reviewed-by: Edwin Peer Signed-off-by: Michael Chan

[PATCH net-next 2/5] bnxt_en: Invalidate health register mapping at the end of probe.

2021-04-11 Thread Michael Chan
From: Vasundhara Volam After probe is successful, interface may not be bought up in all the cases and health register mapping could be invalid if firmware undergoes reset. Fix it by invalidating the health register at the end of probe. It will be remapped during ifup. Fixes: 43a440c4007b ("bnxt_

Re: [PATCH net-next 0/8] ethtool: Extend module EEPROM dump API

2021-04-11 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 9 Apr 2021 11:06:33 +0300 you wrote: > Ethtool supports module EEPROM dumps via the `ethtool -m ` command. > But in current state its functionality is limited - offset and length > parameters, which are used to spe

Re: [PATCH net-next 0/4] net: ipa: support two more platforms

2021-04-11 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 9 Apr 2021 15:40:20 -0500 you wrote: > This series adds IPA support for two more Qualcomm SoCs. > > The first patch updates the DT binding to add compatible strings. > > The second temporarily disables checksum

Re: [PATCH net-next] ehea: add missing MODULE_DEVICE_TABLE

2021-04-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 9 Apr 2021 19:09:11 +0800 you wrote: > This patch adds missing MODULE_DEVICE_TABLE definition which generates > correct modalias for automatic loading of this driver when it is built > as an external module. > > Re

Re: [PATCH net-next 0/4] veth: allow GRO even without XDP

2021-04-11 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 9 Apr 2021 13:04:36 +0200 you wrote: > This series allows the user-space to enable GRO/NAPI on a veth > device even without attaching an XDP program. > > It does not change the default veth behavior (no NAPI, no

Re: [PATCH] net: geneve: check skb is large enough for IPv4/IPv6 header

2021-04-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Sun, 11 Apr 2021 12:28:24 +0100 you wrote: > Check within geneve_xmit_skb/geneve6_xmit_skb that sk_buff structure > is large enough to include IPv4 or IPv6 header, and reject if not. The > geneve_xmit_skb portion and overall

Re: [PATCH] net: davicom: Fix regulator not turned off on failed probe

2021-04-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Sun, 11 Apr 2021 11:02:08 +0200 you wrote: > When the probe fails, we must disable the regulator that was previously > enabled. > > This patch is a follow-up to commit ac88c531a5b3 > ("net: davicom: Fix regulator not turned

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-11 Thread Vladimir Oltean
On Sun, Apr 11, 2021 at 09:50:17PM +0300, Vladimir Oltean wrote: > On Sun, Apr 11, 2021 at 08:01:35PM +0200, Marek Behun wrote: > > On Sat, 10 Apr 2021 15:34:46 +0200 > > Ansuel Smith wrote: > > > > > Hi, > > > this is a respin of the Marek series in hope that this time we can > > > finally make

Re: [PATCH] MAINTAINERS: update maintainer entry for freescale fec driver

2021-04-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 9 Apr 2021 17:11:45 +0800 you wrote: > Update maintainer entry for freescale fec driver. > > Suggested-by: Heiner Kallweit > Signed-off-by: Joakim Zhang > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+),

Re: [PATCH net-next] net: dsa: lantiq_gswip: Add support for dumping the registers

2021-04-11 Thread Andrew Lunn
On Sun, Apr 11, 2021 at 10:55:11PM +0200, Martin Blumenstingl wrote: > Add support for .get_regs_len and .get_regs so it is easier to find out > about the state of the ports on the GSWIP hardware. For this we > specifically add the GSWIP_MAC_PSTATp(port) and GSWIP_MDIO_STATp(port) > register #defin

Re: [PATCH net] virtio_net: Do not pull payload in skb->head

2021-04-11 Thread Guenter Roeck
On 4/11/21 2:43 PM, Eric Dumazet wrote: > On Sun, Apr 11, 2021 at 11:32 PM Guenter Roeck wrote: >> >> On 4/11/21 2:23 PM, Eric Dumazet wrote: >>> On Sun, Apr 11, 2021 at 10:37 PM Guenter Roeck wrote: On 4/11/21 8:06 AM, Eric Dumazet wrote: > On Sun, Apr 11, 2021 at 3:43 PM Guenter R

Re: [PATCH net-next] net: dsa: lantiq_gswip: Add support for dumping the registers

2021-04-11 Thread Hauke Mehrtens
On 4/11/21 10:55 PM, Martin Blumenstingl wrote: Add support for .get_regs_len and .get_regs so it is easier to find out about the state of the ports on the GSWIP hardware. For this we specifically add the GSWIP_MAC_PSTATp(port) and GSWIP_MDIO_STATp(port) register #defines as these contain the cur

[PATCH] lib: remove "expecting prototype" kernel-doc warnings

2021-04-11 Thread Randy Dunlap
Fix various kernel-doc warnings in lib/ due to missing or erroneous function names. Add kernel-doc for some function parameters that was missing. Use kernel-doc "Return:" notation in earlycpio.c. Quietens the following warnings: ../lib/earlycpio.c:61: warning: expecting prototype for cpio_data f

Re: [PATCH net] virtio_net: Do not pull payload in skb->head

2021-04-11 Thread Guenter Roeck
On 4/11/21 2:43 PM, Eric Dumazet wrote: > On Sun, Apr 11, 2021 at 11:32 PM Guenter Roeck wrote: >> >> On 4/11/21 2:23 PM, Eric Dumazet wrote: >>> On Sun, Apr 11, 2021 at 10:37 PM Guenter Roeck wrote: On 4/11/21 8:06 AM, Eric Dumazet wrote: > On Sun, Apr 11, 2021 at 3:43 PM Guenter R

Re: Re: BUG: Bad rss-counter state (4)

2021-04-11 Thread Vegard Nossum
(trimmed off the batman/bpf Ccs) On 2020-05-18 14:28, syzbot wrote: syzbot has bisected this bug to: commit 0d8dd67be013727ae57645ecd3ea2c36365d7da8 Author: Song Liu Date: Wed Dec 6 22:45:14 2017 + perf/headers: Sync new perf_event.h with the tools/include/uapi version bisection l

Re: [PATCH net] virtio_net: Do not pull payload in skb->head

2021-04-11 Thread Guenter Roeck
On 4/11/21 2:23 PM, Eric Dumazet wrote: > On Sun, Apr 11, 2021 at 10:37 PM Guenter Roeck wrote: >> >> On 4/11/21 8:06 AM, Eric Dumazet wrote: >>> On Sun, Apr 11, 2021 at 3:43 PM Guenter Roeck wrote: >>> This patch causes a virtio-net interface failure when booting sh4 images in qemu. Th

[PATCH net-next] net: dsa: lantiq_gswip: Add support for dumping the registers

2021-04-11 Thread Martin Blumenstingl
Add support for .get_regs_len and .get_regs so it is easier to find out about the state of the ports on the GSWIP hardware. For this we specifically add the GSWIP_MAC_PSTATp(port) and GSWIP_MDIO_STATp(port) register #defines as these contain the current port status (as well as the result of the aut

Re: Re: [PATCH v6 03/10] vhost-vdpa: protect concurrent access to vhost device iotlb

2021-04-11 Thread Michael S. Tsirkin
On Sun, Apr 11, 2021 at 01:36:18PM +0800, Yongji Xie wrote: > On Sat, Apr 10, 2021 at 12:16 AM Michael S. Tsirkin wrote: > > > > On Wed, Mar 31, 2021 at 04:05:12PM +0800, Xie Yongji wrote: > > > Use vhost_dev->mutex to protect vhost device iotlb from > > > concurrent access. > > > > > > Fixes: 4c8

Re: [PATCH net] virtio_net: Do not pull payload in skb->head

2021-04-11 Thread Guenter Roeck
On 4/11/21 8:06 AM, Eric Dumazet wrote: > On Sun, Apr 11, 2021 at 3:43 PM Guenter Roeck wrote: > >> This patch causes a virtio-net interface failure when booting sh4 images >> in qemu. The test case is nothing special: Just try to get an IP address >> using udhcpc. If it fails, udhcpc reports: >>

Re: [PATCH net-next 1/7] net: sched: Add a trap-and-forward action

2021-04-11 Thread Jamal Hadi Salim
On 2021-04-09 9:43 a.m., Petr Machata wrote: Jamal Hadi Salim writes: Does the spectrum not support multiple actions? e.g with a policy like: match blah action trap action drop skip_sw Trap drops implicitly. We need a "trap, but don't drop". Expressed in terms of existing actions it wou

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-11 Thread Vladimir Oltean
On Sun, Apr 11, 2021 at 08:01:35PM +0200, Marek Behun wrote: > On Sat, 10 Apr 2021 15:34:46 +0200 > Ansuel Smith wrote: > > > Hi, > > this is a respin of the Marek series in hope that this time we can > > finally make some progress with dsa supporting multi-cpu port. > > > > This implementation

Re: [PATCHv3 bpf-next 1/5] bpf: Allow trampoline re-attach for tracing and lsm programs (fwd)

2021-04-11 Thread Jiri Olsa
> CC: b...@vger.kernel.org > CC: Martin KaFai Lau > CC: Song Liu > CC: Yonghong Song > CC: John Fastabend > > Hi Jiri, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on bpf-next/master] > > url: > https://github.com/

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-11 Thread Andrew Lunn
On Sun, Apr 11, 2021 at 08:01:35PM +0200, Marek Behun wrote: > On Sat, 10 Apr 2021 15:34:46 +0200 > Ansuel Smith wrote: > > > Hi, > > this is a respin of the Marek series in hope that this time we can > > finally make some progress with dsa supporting multi-cpu port. > > > > This implementation

Re: sysctl: setting key "net.core.bpf_jit_enable": Invalid argument

2021-04-11 Thread Paul Menzel
Dear Christophe, Am 11.04.21 um 18:23 schrieb Christophe Leroy: Le 11/04/2021 à 13:09, Paul Menzel a écrit : Related to * [CVE-2021-29154] Linux kernel incorrect computation of branch displacements in BPF JIT compiler can be abused to execute arbitrary code in Kernel mode* [1], on the POWE

Re: [PATCH stable-5.4 0/2] net: dsa: lantiq_gswip: backports for Linux 5.4

2021-04-11 Thread Sasha Levin
On Sun, Apr 11, 2021 at 07:17:46PM +0200, Martin Blumenstingl wrote: Hi Sasha, On Sun, Apr 11, 2021 at 6:48 PM Sasha Levin wrote: On Sun, Apr 11, 2021 at 12:23:42PM +0200, Martin Blumenstingl wrote: >Hello, > >This backports two patches (which could not be backported automatically >because th

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-11 Thread Ansuel Smith
On Sun, Apr 11, 2021 at 08:01:35PM +0200, Marek Behun wrote: > On Sat, 10 Apr 2021 15:34:46 +0200 > Ansuel Smith wrote: > > > Hi, > > this is a respin of the Marek series in hope that this time we can > > finally make some progress with dsa supporting multi-cpu port. > > > > This implementation

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-11 Thread Marek Behun
On Sat, 10 Apr 2021 15:34:46 +0200 Ansuel Smith wrote: > Hi, > this is a respin of the Marek series in hope that this time we can > finally make some progress with dsa supporting multi-cpu port. > > This implementation is similar to the Marek series but with some tweaks. > This adds support for

Re: [PATCHv3 bpf-next 1/5] bpf: Allow trampoline re-attach for tracing and lsm programs (fwd)

2021-04-11 Thread Julia Lawall
i-Olsa/bpf-Tracing-and-lsm-programs-re-attach/20210411-210314 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master :: branch date: 4 hours ago :: commit date: 4 hours ago config: x86_64-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 If you

Re: [PATCH stable-5.4 0/2] net: dsa: lantiq_gswip: backports for Linux 5.4

2021-04-11 Thread Martin Blumenstingl
Hi Sasha, On Sun, Apr 11, 2021 at 6:48 PM Sasha Levin wrote: > > On Sun, Apr 11, 2021 at 12:23:42PM +0200, Martin Blumenstingl wrote: > >Hello, > > > >This backports two patches (which could not be backported automatically > >because the gswip_phylink_mac_link_up function is different in Linux 5.

Re: [PATCH RFC iproute2-next] iplink: allow to change iplink value

2021-04-11 Thread Vladimir Oltean
On Sun, Apr 11, 2021 at 10:04:11AM -0700, Stephen Hemminger wrote: > On Sat, 10 Apr 2021 15:34:50 +0200 > Ansuel Smith wrote: > > > Allow to change the interface to which a given interface is linked to. > > This is useful in the case of multi-CPU port DSA, for changing the CPU > > port of a given

Re: [PATCH RFC iproute2-next] iplink: allow to change iplink value

2021-04-11 Thread Stephen Hemminger
On Sat, 10 Apr 2021 15:34:50 +0200 Ansuel Smith wrote: > Allow to change the interface to which a given interface is linked to. > This is useful in the case of multi-CPU port DSA, for changing the CPU > port of a given user port. > > Signed-off-by: Marek Behún > Cc: David Ahern > Cc: Stephen H

Re: [PATCH stable-5.4 0/2] net: dsa: lantiq_gswip: backports for Linux 5.4

2021-04-11 Thread Sasha Levin
On Sun, Apr 11, 2021 at 12:23:42PM +0200, Martin Blumenstingl wrote: Hello, This backports two patches (which could not be backported automatically because the gswip_phylink_mac_link_up function is different in Linux 5.4 compared to 5.7 and newer) for the lantiq_gswip driver: - commit 3e9005be87

Re: sysctl: setting key "net.core.bpf_jit_enable": Invalid argument

2021-04-11 Thread Christophe Leroy
Le 11/04/2021 à 13:09, Paul Menzel a écrit : Dear Linux folks, Related to * [CVE-2021-29154] Linux kernel incorrect computation of branch displacements in BPF JIT compiler can be abused to execute arbitrary code in Kernel mode* [1], on the POWER8 system IBM S822LC with self-built Linux 5.1

Re: [PATCH net-next 0/8] ionic: hwstamp tweaks

2021-04-11 Thread Richard Cochran
On Wed, Apr 07, 2021 at 04:19:53PM -0700, Shannon Nelson wrote: > A few little changes after review comments and > additional internal testing. This series is a delta against the previously posted one. Please follow the process by re-basing your changes into the original series, putting a "v2" in

Re: [PATCH net-next v3 1/1] net: stmmac: Add support for external trigger timestamping

2021-04-11 Thread Richard Cochran
On Sun, Apr 11, 2021 at 10:40:28AM +0800, Wong Vee Khee wrote: > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c > b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c > index 60566598d644..60e17fd24aba 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c > +++ b/drivers/

[PATCH RFC net-next 2/3] net: add ndo for setting the iflink property

2021-04-11 Thread Ansuel Smith
From: Marek Behún In DSA the iflink value is used to report to which CPU port a given switch port is connected to. Since we want to support multi-CPU DSA, we want the user to be able to change this value. Add ndo_set_iflink method into the ndo strucutre to be a pair to ndo_get_iflink. Also creat

[PATCH RFC net-next 3/3] net: dsa: implement ndo_set_netlink for chaning port's CPU port

2021-04-11 Thread Ansuel Smith
Implement ndo_set_iflink for DSA slave device. In multi-CPU port setup this should be used to change to which CPU destination port a given port should be connected. On CPU port change, the mac address is updated with the new value, if not set to a custom value. Signed-off-by: Marek Behún Signed-o

[PATCH RFC iproute2-next] iplink: allow to change iplink value

2021-04-11 Thread Ansuel Smith
Allow to change the interface to which a given interface is linked to. This is useful in the case of multi-CPU port DSA, for changing the CPU port of a given user port. Signed-off-by: Marek Behún Cc: David Ahern Cc: Stephen Hemminger --- ip/iplink.c | 16 +--- man/man8/ip

[PATCH RFC net-next 1/3] net: dsa: allow for multiple CPU ports

2021-04-11 Thread Ansuel Smith
Allow for multiple CPU ports in a DSA switch tree. By default the first CPU port is assigned mimic the original assignement logic. A DSA driver can define a function to declare a preferred CPU port based on the provided port. If the function doesn't have a preferred port the CPU port is assigned us

[PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-11 Thread Ansuel Smith
Hi, this is a respin of the Marek series in hope that this time we can finally make some progress with dsa supporting multi-cpu port. This implementation is similar to the Marek series but with some tweaks. This adds support for multiple-cpu port but leave the driver the decision of the type of lo

Re: [PATCH net] virtio_net: Do not pull payload in skb->head

2021-04-11 Thread Guenter Roeck
Hi, On Fri, Apr 02, 2021 at 06:26:02AM -0700, Eric Dumazet wrote: > From: Eric Dumazet > > Xuan Zhuo reported that commit 3226b158e67c ("net: avoid 32 x truesize > under-estimation for tiny skbs") brought a ~10% performance drop. > > The reason for the performance drop was that GRO was forced

Re: [PATCH net-next 4/7] net: ipa: ipa_stop() does not return an error

2021-04-11 Thread Alex Elder
On 4/11/21 8:28 AM, Leon Romanovsky wrote: >> I think *not* checking an available return value is questionable >> practice. I'd really rather have a build option for a >> "__need_not_check" tag and have "must_check" be the default. > __need_not_check == void ??? I'm not sure I understand your sta

Re: [PATCH net-next 4/7] net: ipa: ipa_stop() does not return an error

2021-04-11 Thread Leon Romanovsky
On Sun, Apr 11, 2021 at 08:09:55AM -0500, Alex Elder wrote: > On 4/11/21 1:34 AM, Leon Romanovsky wrote: > > On Fri, Apr 09, 2021 at 01:07:19PM -0500, Alex Elder wrote: > >> In ipa_modem_stop(), if the modem netdev pointer is non-null we call > >> ipa_stop(). We check for an error and if one is re

Re: [PATCH net-next 4/7] net: ipa: ipa_stop() does not return an error

2021-04-11 Thread Alex Elder
On 4/11/21 1:34 AM, Leon Romanovsky wrote: > On Fri, Apr 09, 2021 at 01:07:19PM -0500, Alex Elder wrote: >> In ipa_modem_stop(), if the modem netdev pointer is non-null we call >> ipa_stop(). We check for an error and if one is returned we handle >> it. But ipa_stop() never returns an error, so t

[PATCHv3 bpf-next 4/5] selftests/bpf: Add re-attach test to lsm test

2021-04-11 Thread Jiri Olsa
Adding the test to re-attach (detach/attach again) lsm programs, plus check that already linked program can't be attached again. Signed-off-by: Jiri Olsa --- .../selftests/bpf/prog_tests/test_lsm.c | 48 +++ 1 file changed, 38 insertions(+), 10 deletions(-) diff --git a/to

[PATCHv3 bpf-next 5/5] selftests/bpf: Test that module can't be unloaded with attached trampoline

2021-04-11 Thread Jiri Olsa
Adding test to verify that once we attach module's trampoline, the module can't be unloaded. Acked-by: Andrii Nakryiko Signed-off-by: Jiri Olsa --- .../selftests/bpf/prog_tests/module_attach.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/tools/testing/selftests/bpf/

[PATCHv3 bpf-next 2/5] selftests/bpf: Add re-attach test to fentry_test

2021-04-11 Thread Jiri Olsa
Adding the test to re-attach (detach/attach again) tracing fentry programs, plus check that already linked program can't be attached again. Also switching to ASSERT* macros and adding missing ';' in ASSERT_ERR_PTR macro. Signed-off-by: Jiri Olsa --- .../selftests/bpf/prog_tests/fentry_test.c

[PATCHv3 bpf-next 3/5] selftests/bpf: Add re-attach test to fexit_test

2021-04-11 Thread Jiri Olsa
Adding the test to re-attach (detach/attach again) tracing fexit programs, plus check that already linked program can't be attached again. Also switching to ASSERT* macros. Signed-off-by: Jiri Olsa --- .../selftests/bpf/prog_tests/fexit_test.c | 51 +-- 1 file changed, 36 in

[PATCHv3 bpf-next 1/5] bpf: Allow trampoline re-attach for tracing and lsm programs

2021-04-11 Thread Jiri Olsa
Currently we don't allow re-attaching of trampolines. Once it's detached, it can't be re-attach even when the program is still loaded. Adding the possibility to re-attach the loaded tracing and lsm programs. Acked-by: Toke Høiland-Jørgensen Signed-off-by: Jiri Olsa --- kernel/bpf/syscall.c

[PATCHv3 bpf-next 0/5] bpf: Tracing and lsm programs re-attach

2021-04-11 Thread Jiri Olsa
hi, while adding test for pinning the module while there's trampoline attach to it, I noticed that we don't allow link detach and following re-attach for trampolines. Adding that for tracing and lsm programs. You need to have patch [1] from bpf tree for test module attach test to pass. v3 changes

[PATCH rdma-next v1 5/7] RDMA/mlx5: Add support to MODIFY_MEMIC command

2021-04-11 Thread Leon Romanovsky
From: Maor Gottlieb Add two functions to allocate and deallocate MEMIC operations by using the MODIFY_MEMIC command. Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/dm.c | 36 + drivers/infiniband/hw/mlx5/dm.h | 2 ++

[PATCH rdma-next v1 7/7] RDMA/mlx5: Expose UAPI to query DM

2021-04-11 Thread Leon Romanovsky
From: Maor Gottlieb Expose UAPI to query MEMIC DM, this will let user space application that didn't allocate the DM but has access to by owning the matching command FD to retrieve its information. Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/dm.c

[PATCH rdma-next v1 2/7] RDMA/uverbs: Make UVERBS_OBJECT_METHODS to consider line number

2021-04-11 Thread Leon Romanovsky
From: Maor Gottlieb In order to support multiple methods declaration in the same file we should use the line number as part of the name. Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- include/rdma/uverbs_named_ioctl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[PATCH rdma-next v1 6/7] RDMA/mlx5: Add support in MEMIC operations

2021-04-11 Thread Leon Romanovsky
From: Maor Gottlieb MEMIC buffer, in addition to regular read and write operations, can support atomic operations from the host. Introduce and implement new UAPI to allocate address space for MEMIC operations such as atomic. This includes: 1. Expose new IOCTL for request mapping of MEMIC operat

[PATCH rdma-next v1 4/7] RDMA/mlx5: Re-organize the DM code

2021-04-11 Thread Leon Romanovsky
From: Maor Gottlieb 1. Inline the checks from check_dm_type_support() into their respective allocation functions. 2. Fix use after free when driver fails to copy the MEMIC address to the user by moving the allocation code into their respective functions, hence we avoid the explicit call

[PATCH rdma-next v1 3/7] RDMA/mlx5: Move all DM logic to separate file

2021-04-11 Thread Leon Romanovsky
From: Maor Gottlieb Move all device memory related code to a separate file. Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/Makefile | 1 + drivers/infiniband/hw/mlx5/cmd.c | 101 drivers/infiniband/hw/mlx5/cmd.h | 3 - drivers/

[PATCH mlx5-next v1 1/7] net/mlx5: Add MEMIC operations related bits

2021-04-11 Thread Leon Romanovsky
From: Maor Gottlieb Add the MEMIC operations bits and structures to the mlx5_ifc file. Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky --- include/linux/mlx5/mlx5_ifc.h | 42 ++- 1 file changed, 41 insertions(+), 1 deletion(-) diff --git a/include/

[PATCH rdma-next v1 0/7] Add MEMIC operations support

2021-04-11 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v1: * Changed logic of patch #6 per-Jason's request. v0: https://lore.kernel.org/linux-rdma/20210318111548.674749-1-l...@kernel.org --- Hi, This series from Maor extends MEMIC to support

Re: [PATCH v2] Bluetooth: Return whether a connection is outbound

2021-04-11 Thread Marcel Holtmann
Hi Yu, > When an MGMT_EV_DEVICE_CONNECTED event is reported back to the user > space we will set the flags to tell if the established connection is > outbound or not. This is useful for the user space to log better metrics > and error messages. > > Reviewed-by: Miao-chen Chou > Reviewed-by: Alai

  1   2   >