Re: [PATCH v6 09/10] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-04-07 Thread Jason Wang
在 2021/3/31 下午4:05, Xie Yongji 写道: This VDUSE driver enables implementing vDPA devices in userspace. Both control path and data path of vDPA devices will be able to be handled in userspace. In the control path, the VDUSE driver will make use of message mechnism to forward the config operation

Re: [PATCH net-next] [RESEND] wireguard: disable in FIPS mode

2021-04-07 Thread Hangbin Liu
On Wed, Apr 07, 2021 at 03:15:51PM -0600, Jason A. Donenfeld wrote: > Hi Hangbin, > > On Wed, Apr 7, 2021 at 5:39 AM Hangbin Liu wrote: > > > > As the cryptos(BLAKE2S, Curve25519, CHACHA20POLY1305) in WireGuard are not > > FIPS certified, the WireGuard module should be disabled in FIPS mode. > >

RE: [PATCH net-next 2/3] net: fec: use mac-managed PHY PM

2021-04-07 Thread Joakim Zhang
> -Original Message- > From: Heiner Kallweit > Sent: 2021年4月8日 14:00 > To: Joakim Zhang ; Andrew Lunn > ; Russell King - ARM Linux ; Jakub > Kicinski ; David Miller ; Fugang > Duan > Cc: netdev@vger.kernel.org > Subject: Re: [PATCH net-next 2/3] net: fec: use mac-managed PHY PM > > On 0

Re: [PATCH] ibmvnic: Continue with reset if set link down failed

2021-04-07 Thread Sukadev Bhattiprolu
Dany Madden [d...@linux.ibm.com] wrote: > When an adapter is going thru a reset, it maybe in an unstable state that > makes a request to set link down fail. In such a case, the adapter needs > to continue on with reset to bring itself back to a stable state. > > Fixes: ed651a10875f ("ibmvnic: Upda

Re: [PATCH net-next 2/3] net: fec: use mac-managed PHY PM

2021-04-07 Thread Heiner Kallweit
On 08.04.2021 07:45, Joakim Zhang wrote: > >> -Original Message- >> From: Heiner Kallweit >> Sent: 2021年4月7日 23:53 >> To: Andrew Lunn ; Russell King - ARM Linux >> ; Jakub Kicinski ; David Miller >> ; Fugang Duan >> Cc: netdev@vger.kernel.org; Joakim Zhang >> Subject: [PATCH net-next 2/

RE: [PATCH v4 bpf 2/3] libbpf: restore umem state after socket create failure

2021-04-07 Thread Loftus, Ciara
> On Tue, Mar 30, 2021 at 11:45 PM Ciara Loftus > wrote: > > > > If the call to xsk_socket__create fails, the user may want to retry the > > socket creation using the same umem. Ensure that the umem is in the > > same state on exit if the call fails by: > > 1. ensuring the umem _save pointers are

[PATCH bpf] libbpf: fix potential NULL pointer dereference

2021-04-07 Thread Ciara Loftus
Wait until after the UMEM is checked for null to dereference it. Fixes: 43f1bc1efff1 ("libbpf: Restore umem state after socket create failure") Signed-off-by: Ciara Loftus --- tools/lib/bpf/xsk.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/lib/bpf/xsk.c b/tools/

RE: [PATCH net-next 2/3] net: fec: use mac-managed PHY PM

2021-04-07 Thread Joakim Zhang
> -Original Message- > From: Heiner Kallweit > Sent: 2021年4月7日 23:53 > To: Andrew Lunn ; Russell King - ARM Linux > ; Jakub Kicinski ; David Miller > ; Fugang Duan > Cc: netdev@vger.kernel.org; Joakim Zhang > Subject: [PATCH net-next 2/3] net: fec: use mac-managed PHY PM > > Use the ne

RE: [PATCH net-next 0/3] net: make PHY PM ops a no-op if MAC driver manages PHY PM

2021-04-07 Thread Joakim Zhang
Hi Heiner, Why not target this patch set to net repo as a bug fixes? Others may also suffer from this. Best Regards, Joakim Zhang > -Original Message- > From: Heiner Kallweit > Sent: 2021年4月7日 23:51 > To: Andrew Lunn ; Russell King - ARM Linux > ; Jakub Kicinski ; David Miller > ; Fug

Re: Re: [PATCH v6 08/10] vduse: Implement an MMU-based IOMMU driver

2021-04-07 Thread Yongji Xie
On Thu, Apr 8, 2021 at 11:26 AM Jason Wang wrote: > > > 在 2021/3/31 下午4:05, Xie Yongji 写道: > > This implements an MMU-based IOMMU driver to support mapping > > kernel dma buffer into userspace. The basic idea behind it is > > treating MMU (VA->PA) as IOMMU (IOVA->PA). The driver will set > > up MM

Re: [PATCH net v4] atl1c: move tx cleanup processing out of interrupt

2021-04-07 Thread Gatis Peisenieks
On 2021-04-07 19:55, Eric Dumazet wrote: On 4/6/21 4:49 PM, Gatis Peisenieks wrote: Tx queue cleanup happens in interrupt handler on same core as rx queue processing. Both can take considerable amount of processing in high packet-per-second scenarios. Sending big amounts of packets can stall th

RE: rtlwifi/rtl8192cu AP mode broken with PS STA

2021-04-07 Thread Pkshih
> -Original Message- > From: Maciej S. Szmigiero [mailto:m...@maciej.szmigiero.name] > Sent: Thursday, April 08, 2021 4:53 AM > To: Larry Finger; Pkshih > Cc: linux-wirel...@vger.kernel.org; netdev@vger.kernel.org; > linux-ker...@vger.kernel.org; > johan...@sipsolutions.net; kv...@codeau

Re: [External] linux-next: manual merge of the net-next tree with the bpf tree

2021-04-07 Thread Cong Wang .
On Wed, Apr 7, 2021 at 8:11 PM Stephen Rothwell wrote: > > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > net/core/skmsg.c > > between commit: > > 144748eb0c44 ("bpf, sockmap: Fix incorrect fwd_alloc accounting") > > from the bpf tree and commit: > > e3526bb

Re: [External] linux-next: manual merge of the net-next tree with the bpf tree

2021-04-07 Thread Cong Wang .
On Wed, Apr 7, 2021 at 8:02 PM Stephen Rothwell wrote: > > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > include/linux/skmsg.h > > between commit: > > 1c84b33101c8 ("bpf, sockmap: Fix sk->prot unhash op reset") > > from the bpf tree and commit: > > 8a59f9d1

[PATCH net-next 2/2] net: hns3: add suspend and resume pm_ops

2021-04-07 Thread Huazhong Tan
From: Jiaran Zhang To implement the system suspend/resume functions, the NIC driver needs to support: 1. When the system enters the suspend mode, the driver needs to implement the suspend callback function of the NIC device. The driver needs to mute the device, stop all RX/TX activities of the de

[PATCH net-next 1/2] net: hns3: change flr_prepare/flr_done function names

2021-04-07 Thread Huazhong Tan
From: Jiaran Zhang The flr_prepare/flr_done functions are not only used in the FLR scenario, but also used in the suspend/resume. Change the function names to prepare_for_reset/rebuild_for_reset, change the flr_prepare/flr_done to reset_prepare/reset_done in hnae3_ae_ops. Signed-off-by: Jiaran

[PATCH net-next 0/2] net: hns3: add support for pm_ops

2021-04-07 Thread Huazhong Tan
This series adds support for pm_ops in the HNS3 ethernet driver. Jiaran Zhang (2): net: hns3: change flr_prepare/flr_done function names net: hns3: add suspend and resume pm_ops drivers/net/ethernet/hisilicon/hns3/hnae3.h| 5 +-- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c|

Re: [PATCH v6 08/10] vduse: Implement an MMU-based IOMMU driver

2021-04-07 Thread Jason Wang
在 2021/3/31 下午4:05, Xie Yongji 写道: This implements an MMU-based IOMMU driver to support mapping kernel dma buffer into userspace. The basic idea behind it is treating MMU (VA->PA) as IOMMU (IOVA->PA). The driver will set up MMU mapping instead of IOMMU mapping for the DMA transfer so that the u

linux-next: manual merge of the net-next tree with the net tree

2021-04-07 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/tipc/crypto.c between commit: 2a2403ca3add ("tipc: increment the tmp aead refcnt before attaching it") from the net tree and commit: 97bc84bbd4de ("tipc: clean up warnings detected by sparse") from the net-nex

linux-next: manual merge of the net-next tree with the bpf tree

2021-04-07 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/core/skmsg.c between commit: 144748eb0c44 ("bpf, sockmap: Fix incorrect fwd_alloc accounting") from the bpf tree and commit: e3526bb92a20 ("skmsg: Move sk_redir from TCP_SKB_CB to skb") from the net-next tree.

[Patch bpf-next] sock_map: fix a potential use-after-free in sock_map_close()

2021-04-07 Thread Cong Wang
From: Cong Wang The last refcnt of the psock can be gone right after sock_map_remove_links(), so sk_psock_stop() could trigger a UAF. The reason why I placed sk_psock_stop() there is to avoid RCU read critical section, and more importantly, some callee of sock_map_remove_links() is supposed to be

linux-next: manual merge of the net-next tree with the bpf tree

2021-04-07 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: include/linux/skmsg.h between commit: 1c84b33101c8 ("bpf, sockmap: Fix sk->prot unhash op reset") from the bpf tree and commit: 8a59f9d1e3d4 ("sock: Introduce sk->sk_prot->psock_update_sk_prot()") from the net-nex

linux-next: manual merge of the net-next tree with the net tree

2021-04-07 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: include/linux/ethtool.h between commit: a975d7d8a356 ("ethtool: Remove link_mode param and derive link params from driver") from the net tree and commit: 7888fe53b706 ("ethtool: Add common function for filling out

Re: [PATCH v6 07/10] vdpa: Support transferring virtual addressing during DMA mapping

2021-04-07 Thread Jason Wang
在 2021/3/31 下午4:05, Xie Yongji 写道: This patch introduces an attribute for vDPA device to indicate whether virtual address can be used. If vDPA device driver set it, vhost-vdpa bus driver will not pin user page and transfer userspace virtual address instead of physical address during DMA mapping

RE: [EXT] [PATCH] bnx2x: Fix potential infinite loop

2021-04-07 Thread Sudarsana Reddy Kalluru
> -Original Message- > From: Colin King > Sent: Wednesday, April 7, 2021 7:58 PM > To: Ariel Elior ; Sudarsana Reddy Kalluru > ; GR-everest-linux-l2 l...@marvell.com>; David S . Miller ; Jakub Kicinski > ; Eilon Greenstein ; > netdev@vger.kernel.org > Cc: kernel-janit...@vger.kernel.org;

Re: [PATCH net-next] [RESEND] wireguard: disable in FIPS mode

2021-04-07 Thread Hangbin Liu
On Wed, Apr 07, 2021 at 02:12:27PM -0700, Eric Biggers wrote: > On Wed, Apr 07, 2021 at 07:39:20PM +0800, Hangbin Liu wrote: > > As the cryptos(BLAKE2S, Curve25519, CHACHA20POLY1305) in WireGuard are not > > FIPS certified, the WireGuard module should be disabled in FIPS mode. > > > > Signed-off-b

Re: [PATCH net v2 2/3] net: sched: fix action overwrite reference counting

2021-04-07 Thread Cong Wang
On Wed, Apr 7, 2021 at 8:36 AM Vlad Buslov wrote: > > Action init code increments reference counter when it changes an action. > This is the desired behavior for cls API which needs to obtain action > reference for every classifier that points to action. However, act API just > needs to change the

Re: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Bernd Petrovitsch
Hi all! On 07/04/2021 23:59, Dexuan Cui wrote: [...] > FWIW, {0} and { 0 } are still widely used, but it looks like > {} is indeed more preferred: > > $ grep "= {};" drivers/net/ -nr | wc -l > 829 $ egrep -nr "=[[:space:]]*{[[:space:]]*};" drivers/net/ | wc -l 872 > $ grep "= {0};" drivers/n

Re: memory leak in bpf

2021-04-07 Thread Andrii Nakryiko
On Wed, Apr 7, 2021 at 4:24 PM Rustam Kovhaev wrote: > > On Mon, Mar 01, 2021 at 09:43:00PM +0100, Dmitry Vyukov wrote: > > On Mon, Mar 1, 2021 at 9:39 PM Rustam Kovhaev wrote: > > > > > > On Mon, Mar 01, 2021 at 08:05:42PM +0100, Dmitry Vyukov wrote: > > > > On Mon, Mar 1, 2021 at 5:21 PM Rustam

Re: [PATCH net-next 3/3] dt-bindings: net: dsa: Document dsa,tag-protocol property

2021-04-07 Thread Vladimir Oltean
On Tue, Apr 06, 2021 at 03:30:46PM +0200, Andrew Lunn wrote: > > Andrew, Vladimir: I will just list dsa and edsa for now. If it is needed > > on other devices, people can add them to the list after they have tested > > their drivers. Fair? > > O.K. Same here.

Re: [PATCH RFC net 1/2] net: dsa: lantiq_gswip: Don't use PHY auto polling

2021-04-07 Thread Andrew Lunn
> If dropping the modifications to gswip_phylink_mac_config is my only change: > do you want me to keep or drop your Reviewed-by in v2? You can keep it. Andrew

Re: memory leak in bpf

2021-04-07 Thread Rustam Kovhaev
On Mon, Mar 01, 2021 at 09:43:00PM +0100, Dmitry Vyukov wrote: > On Mon, Mar 1, 2021 at 9:39 PM Rustam Kovhaev wrote: > > > > On Mon, Mar 01, 2021 at 08:05:42PM +0100, Dmitry Vyukov wrote: > > > On Mon, Mar 1, 2021 at 5:21 PM Rustam Kovhaev wrote: > > > > > > > > On Wed, Dec 09, 2020 at 10:58:10P

Re: [RFC v2 net-next 4/4] staging: mt7621-dts: enable MT7530 interrupt controller

2021-04-07 Thread Andrew Lunn
On Wed, Apr 07, 2021 at 12:50:38PM +0800, DENG Qingfang wrote: > Enable MT7530 interrupt controller in the MT7621 SoC. > > Signed-off-by: DENG Qingfang Reviewed-by: Andrew Lunn Andrew

Re: [RFC v2 net-next 3/4] dt-bindings: net: dsa: add MT7530 interrupt controller binding

2021-04-07 Thread Andrew Lunn
On Wed, Apr 07, 2021 at 12:50:37PM +0800, DENG Qingfang wrote: > Add device tree binding to support MT7530 interrupt controller. > > Signed-off-by: DENG Qingfang Reviewed-by: Andrew Lunn Andrew

Re: [RFC v2 net-next 2/4] net: dsa: mt7530: add interrupt support

2021-04-07 Thread Andrew Lunn
On Wed, Apr 07, 2021 at 12:50:36PM +0800, DENG Qingfang wrote: > Add support for MT7530 interrupt controller to handle internal PHYs. > In order to assign an IRQ number to each PHY, the registration of MDIO bus > is also done in this driver. > > Signed-off-by: DENG Qingfang > --- > RFC v1 -> RFC

[PATCH net-next 8/8] ionic: extend ts_config set locking

2021-04-07 Thread Shannon Nelson
Make sure the configuration is locked before operating on it for the replay. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_phc.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/pensando/ionic/ionic_phc.c b/

[PATCH net-next 7/8] ionic: add ts_config replay

2021-04-07 Thread Shannon Nelson
Split the call into ionic_lif_hwstamp_set() to have two separate interfaces, one from the ioctl() for changing the configuration and one for replaying the current configuration after a FW RESET. Signed-off-by: Shannon Nelson --- .../net/ethernet/pensando/ionic/ionic_lif.c | 2 +- .../net/ethe

[PATCH net-next 6/8] ionic: ignore EBUSY on queue start

2021-04-07 Thread Shannon Nelson
When starting the queues in the link-check, don't go into the BROKEN state if the return was EBUSY. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_lif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.

[PATCH net-next 5/8] ionic: re-start ptp after queues up

2021-04-07 Thread Shannon Nelson
When returning after a firmware reset, re-start the PTP after we've restarted the general queues. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_lif.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/pensando/ionic/ionic_

[PATCH net-next 4/8] ionic: add SKBTX_IN_PROGRESS

2021-04-07 Thread Shannon Nelson
Set the SKBTX_IN_PROGRESS when offloading the Tx timestamp. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_txrx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/pensando/ionic/ionic_txrx.c b/drivers/net/ethernet/pensando/ionic/ionic_txrx.c

[PATCH net-next 3/8] ionic: check for valid tx_mode on SKBTX_HW_TSTAMP xmit

2021-04-07 Thread Shannon Nelson
Make sure the device is in a Tx offload mode before calling the hwstamp offload xmit. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_txrx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/pensando/ionic/ionic_txrx.c b/drivers

[PATCH net-next 2/8] ionic: remove unnecessary compat ifdef

2021-04-07 Thread Shannon Nelson
We don't need to look for HAVE_HWSTAMP_TX_ONESTEP_P2P in the upstream kernel. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_phc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/pensando/ionic/ionic_phc.c b/drivers/net/ethernet/pensando/io

[PATCH net-next 0/8] ionic: hwstamp tweaks

2021-04-07 Thread Shannon Nelson
A few little changes after review comments and additional internal testing. Shannon Nelson (8): ionic: fix up a couple of code style nits ionic: remove unnecessary compat ifdef ionic: check for valid tx_mode on SKBTX_HW_TSTAMP xmit ionic: add SKBTX_IN_PROGRESS ionic: re-start ptp after q

[PATCH net-next 1/8] ionic: fix up a couple of code style nits

2021-04-07 Thread Shannon Nelson
Clean up variable declarations. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/ionic_lif.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/pensando/ionic/ionic_lif.c b/drivers/net/ethernet/pensando/ionic/ionic_lif.c inde

Re: [PATCH net-next 0/2] Additional tests for action API

2021-04-07 Thread Cong Wang
On Wed, Apr 7, 2021 at 8:46 AM Vlad Buslov wrote: > > Add two new tests for action create/change code. Acked-by: Cong Wang Thanks.

Re: WARNING net/core/stream.c:208 when running test_sockmap

2021-04-07 Thread Cong Wang
On Wed, Apr 7, 2021 at 2:22 PM Jiri Olsa wrote: > > hi, > I'm getting couple of WARNINGs below when running > test_sockmap on latest bpf-next/master, like: > > # while :; do ./test_sockmap ; done > > The warning is at: > WARN_ON(sk->sk_forward_alloc); > > so looks like some socket allocation m

Re: [RFC v2 net-next 1/4] net: phy: add MediaTek PHY driver

2021-04-07 Thread Andrew Lunn
On Wed, Apr 07, 2021 at 12:50:35PM +0800, DENG Qingfang wrote: > Add support for MediaTek PHYs found in MT7530 and MT7531 switches. > The initialization procedure is from the vendor driver, but due to lack > of documentation, the function of some register values remains unknown. > > Signed-off-by:

Re: [PATCH net-next v4 14/16] net: phy: marvell10g: differentiate 88E2110 vs 88E2111

2021-04-07 Thread Andrew Lunn
On Wed, Apr 07, 2021 at 10:22:52PM +0200, Marek Behún wrote: > 88E2111 is a variant of 88E2110 which does not support 5 gigabit speeds. > > Differentiate these variants via the match_phy_device() method, since > they have the same PHY ID. > > Signed-off-by: Marek Behún Reviewed-by: Andrew Lunn

Re: [PATCH net-next v4 11/16] net: phy: marvell10g: add separate structure for 88X3340

2021-04-07 Thread Andrew Lunn
On Wed, Apr 07, 2021 at 10:22:49PM +0200, Marek Behún wrote: > The 88X3340 contains 4 cores similar to 88X3310, but there is a > difference: it does not support xaui host mode. Instead the > corresponding MACTYPE means > rxaui / 5gbase-r / 2500base-x / sgmii without AN > > Signed-off-by: Marek B

Re: [igb] netconsole triggers warning in netpoll_poll_dev

2021-04-07 Thread Alexander Duyck
On Wed, Apr 7, 2021 at 11:07 AM Jakub Kicinski wrote: > > On Wed, 7 Apr 2021 09:25:28 -0700 Alexander Duyck wrote: > > On Wed, Apr 7, 2021 at 8:37 AM Jakub Kicinski wrote: > > > > > > On Wed, 7 Apr 2021 08:00:53 +0200 Oleksandr Natalenko wrote: > > > > Thanks for the effort, but reportedly [1] it

Re: [PATCH net-next v4 08/16] net: phy: marvell10g: check for correct supported interface mode

2021-04-07 Thread Andrew Lunn
On Wed, Apr 07, 2021 at 10:22:46PM +0200, Marek Behún wrote: > The 88E2110 does not support xaui nor rxaui modes. Check for correct > interface mode for different chips. > > Signed-off-by: Marek Behún Reviewed-by: Andrew Lunn Andrew

Re: [PATCHv2 bpf-next 5/5] selftests/bpf: Test that module can't be unloaded with attached trampoline

2021-04-07 Thread Andrii Nakryiko
On Wed, Apr 7, 2021 at 4:22 AM Jiri Olsa wrote: > > Adding test to verify that once we attach module's trampoline, > the module can't be unloaded. > > Signed-off-by: Jiri Olsa > --- To be fair, to test that you are actually testing what you think you are testing, you'd have to prove that you *ca

Re: [PATCH net-next v4 07/16] net: phy: marvell10g: support all rate matching modes

2021-04-07 Thread Andrew Lunn
On Wed, Apr 07, 2021 at 10:22:45PM +0200, Marek Behún wrote: > Add support for all rate matching modes for 88X3310 (currently only > 10gbase-r is supported, but xaui and rxaui can also be used). > > Add support for rate matching for 88E2110 (on 88E2110 the MACTYPE > register is at a different plac

Re: [RFC net-next 0/1] seg6: Counters for SRv6 Behaviors

2021-04-07 Thread David Ahern
Since this is a single patch set, just put this good cover letter content as the message in the patch.

Re: [RFC net-next 1/1] seg6: add counters support for SRv6 Behaviors

2021-04-07 Thread David Ahern
On 4/7/21 12:03 PM, Andrea Mayer wrote: > diff --git a/include/uapi/linux/seg6_local.h b/include/uapi/linux/seg6_local.h > index 3b39ef1dbb46..ae5e3fd12b73 100644 > --- a/include/uapi/linux/seg6_local.h > +++ b/include/uapi/linux/seg6_local.h > @@ -27,6 +27,7 @@ enum { > SEG6_LOCAL_OIF, >

Re: [PATCHv2 bpf-next 3/5] selftests/bpf: Add re-attach test to fexit_test

2021-04-07 Thread Andrii Nakryiko
On Wed, Apr 7, 2021 at 4:21 AM Jiri Olsa wrote: > > Adding the test to re-attach (detach/attach again) tracing > fexit programs, plus check that already linked program can't > be attached again. > > Fixing the number of check-ed results, which should be 8. > > Signed-off-by: Jiri Olsa > --- > ..

Re: [PATCHv2 bpf-next 2/5] selftests/bpf: Add re-attach test to fentry_test

2021-04-07 Thread Andrii Nakryiko
On Wed, Apr 7, 2021 at 4:21 AM Jiri Olsa wrote: > > Adding the test to re-attach (detach/attach again) tracing > fentry programs, plus check that already linked program can't > be attached again. > > Fixing the number of check-ed results, which should be 8. > > Signed-off-by: Jiri Olsa > --- > .

Re: [PATCH v4 05/23] ice: Add devlink params support

2021-04-07 Thread Jason Gunthorpe
On Wed, Apr 07, 2021 at 08:58:25PM +, Saleem, Shiraz wrote: > > Subject: Re: [PATCH v4 05/23] ice: Add devlink params support > > > > On Tue, Apr 06, 2021 at 04:01:07PM -0500, Shiraz Saleem wrote: > > > Add a new generic runtime devlink parameter 'rdma_protocol' > > > and use it in ice PCI dri

Re: [PATCH v4 01/23] iidc: Introduce iidc.h

2021-04-07 Thread Jason Gunthorpe
On Wed, Apr 07, 2021 at 08:58:49PM +, Saleem, Shiraz wrote: > > Subject: Re: [PATCH v4 01/23] iidc: Introduce iidc.h > > > > On Tue, Apr 06, 2021 at 04:01:03PM -0500, Shiraz Saleem wrote: > > > > > +/* Following APIs are implemented by core PCI driver */ struct > > > +iidc_core_ops { > > > +

Re: [PATCH net-next] net: sundance: use module_pci_driver to simplify the code

2021-04-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 7 Apr 2021 15:07:09 + you wrote: > Use the module_pci_driver() macro to make the code simpler > by eliminating module_init and module_exit calls. > > Signed-off-by: Wei Yongjun > --- > drivers/net/ethernet/dl

Re: [PATCH net-next] net: fealnx: use module_pci_driver to simplify the code

2021-04-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 7 Apr 2021 15:07:12 + you wrote: > Use the module_pci_driver() macro to make the code simpler > by eliminating module_init and module_exit calls. > > Signed-off-by: Wei Yongjun > --- > drivers/net/ethernet/fe

Re: [PATCH net-next] net: atheros: atl2: use module_pci_driver to simplify the code

2021-04-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 7 Apr 2021 15:07:11 + you wrote: > Use the module_pci_driver() macro to make the code simpler > by eliminating module_init and module_exit calls. > > Signed-off-by: Wei Yongjun > --- > .../atheros/atlx/atl2.c

Re: [PATCH net-next] net: encx24j600: use module_spi_driver to simplify the code

2021-04-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 7 Apr 2021 15:07:04 + you wrote: > module_spi_driver() makes the code simpler by eliminating > boilerplate code. > > Signed-off-by: Wei Yongjun > --- > .../net/ethernet/microchip/encx24j600.c | 12 +-

Re: [PATCH net-next] tulip: windbond-840: use module_pci_driver to simplify the code

2021-04-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 7 Apr 2021 15:07:07 + you wrote: > Use the module_pci_driver() macro to make the code simpler > by eliminating module_init and module_exit calls. > > Signed-off-by: Wei Yongjun > --- > .../ethernet/dec/tulip/

Re: [PATCH net-next] tulip: de2104x: use module_pci_driver to simplify the code

2021-04-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 7 Apr 2021 15:07:08 + you wrote: > Use the module_pci_driver() macro to make the code simpler > by eliminating module_init and module_exit calls. > > Signed-off-by: Wei Yongjun > --- > .../net/ethernet/dec/tu

Re: [PATCH net-next] enic: use module_pci_driver to simplify the code

2021-04-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 7 Apr 2021 15:07:05 + you wrote: > Use the module_pci_driver() macro to make the code simpler > by eliminating module_init and module_exit calls. > > Signed-off-by: Wei Yongjun > --- > .../net/ethernet/cisco/

Re: pull-request: ieee802154 for net 2021-04-07

2021-04-07 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net.git (refs/heads/master): On Wed, 7 Apr 2021 16:55:05 +0200 you wrote: > Hello Dave, Jakub. > > An update from ieee802154 for your *net* tree. > > Most of these are coming from the flood of syzkaller reports > lately got for the ieee802154 subs

Re: [PATCH 4/6] fs/jffs2: Delete obsolete TODO file

2021-04-07 Thread Richard Weinberger
On Tue, Mar 30, 2021 at 9:07 AM Wang Qing wrote: > > The TODO file here has not been updated for 14 years, and the function > development described in the file have been implemented or abandoned. > > Its existence will mislead developers seeking to view outdated information. Did you check whether

Re: [PATCH v2] net: hso: fix null-ptr-deref during tty device unregistration

2021-04-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 7 Apr 2021 22:57:22 +0530 you wrote: > Multiple ttys try to claim the same the minor number causing a double > unregistration of the same device. The first unregistration succeeds > but the next one results in a null-pt

Re: [PATCH] bnx2x: Fix potential infinite loop

2021-04-07 Thread David Miller
From: Colin King Date: Wed, 7 Apr 2021 15:28:02 +0100 > From: Colin Ian King > > The for_each_tx_queue loop iterates with a u8 loop counter i and > compares this with the loop upper limit of bp->num_queues that > is an int type. There is a potential infinite loop if bp->num_queues > is larger

Re: [PATCH] xircom: remove redundant error check on variable err

2021-04-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 7 Apr 2021 10:39:22 +0100 you wrote: > From: Colin Ian King > > The error check on err is always false as err is always 0 at the > port_found label. The code is redundant and can be removed. > > Addresses-Coveri

Re: [PATCH net-next] net: remove the new_ifindex argument from dev_change_net_namespace

2021-04-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 6 Apr 2021 23:40:51 -0700 you wrote: > Here is only one place where we want to specify new_ifindex. In all > other cases, callers pass 0 as new_ifindex. It looks reasonable to add a > low-level function with new_if

Re: pull-request: can-next 2021-04-07

2021-04-07 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net-next.git (refs/heads/master): On Wed, 7 Apr 2021 10:01:12 +0200 you wrote: > Hello Jakub, hello David, > > this is a pull request of 6 patches for net-next/master. > > The first patch targets the CAN driver infrastructure, it improves the > al

Re: [PATCH] liquidio: Fix unintented sign extension of a left shift of a u16

2021-04-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 7 Apr 2021 11:12:48 +0100 you wrote: > From: Colin Ian King > > The macro CN23XX_PEM_BAR1_INDEX_REG is being used to shift oct->pcie_port > (a u16) left 24 places. There are two subtle issues here, first the > sh

Re: [PATCH net-next] net: wan: z85230: drop unused async state

2021-04-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 7 Apr 2021 12:48:56 +0200 you wrote: > According to the changelog, asynchronous mode was dropped sometime > before v2.2. Let's get rid of the unused driver-specific async state as > well so that it doesn't show up

Re: [PATCH net v3 0/2] Fix link_mode derived params functionality

2021-04-07 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Wed, 7 Apr 2021 13:06:50 +0300 you wrote: > Currently, link_mode parameter derives 3 other link parameters, speed, > lanes and duplex, and the derived information is sent to user space. > > Few bugs were found in that funct

Re: pull-request: wireless-drivers-2021-04-07

2021-04-07 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net.git (refs/heads/master): On Wed, 7 Apr 2021 12:22:04 + (UTC) you wrote: > Hi, > > here's a pull request to net tree, more info below. Please let me know if > there > are any problems. > > Kalle > > [...] Here is the summary with links:

Re: [PATCH v2] net: tipc: Fix spelling errors in net/tipc module

2021-04-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 7 Apr 2021 09:59:45 +0800 you wrote: > These patches fix a series of spelling errors in net/tipc module. > > Reported-by: Hulk Robot > Signed-off-by: Zheng Yongjun > --- > net/tipc/bearer.h | 6 +++--- > net/tipc/net

Re: [net 1/5] net/mlx5: Fix HW spec violation configuring uplink

2021-04-07 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Tue, 6 Apr 2021 21:06:16 -0700 you wrote: > From: Eli Cohen > > Make sure to modify uplink port to follow only if the uplink_follow > capability is set as required by the HW spec. Failure to do so causes > traffic to the

Re: [PATCH net v3] net: hsr: Reset MAC header for Tx path

2021-04-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 6 Apr 2021 09:35:09 +0200 you wrote: > Reset MAC header in HSR Tx path. This is needed, because direct packet > transmission, e.g. by specifying PACKET_QDISC_BYPASS does not reset the MAC > header. > > This has been ob

Re: [PATCH net 0/3] ethtool: kdoc fixes

2021-04-07 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Tue, 6 Apr 2021 17:28:24 -0700 you wrote: > Number of kdoc fixes to ethtool headers. All comment changes. > > With all the patches posted kdoc script seems happy: > $ ./scripts/kernel-doc -none include/uapi/linux/ethtool.h

RE: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-07 Thread Dexuan Cui
> From: Leon Romanovsky > Sent: Wednesday, April 7, 2021 5:45 AM > > > > > > BTW, you don't need to write { 0 }, the {} is enough. > > > > Thanks for the suggestion! I'll use {0} in v2. > > You missed the point, "{ 0 }" change to be "{}" without 0. Got it. Will make the suggested change. FWIW,

Re: [PATCH net-next] net: introduce nla_policy for IFLA_NEW_IFINDEX

2021-04-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 6 Apr 2021 23:40:03 -0700 you wrote: > In this case, we don't need to check that new_ifindex is positive in > validate_linkmsg. > > Fixes: eeb85a14ee34 ("net: Allow to specify ifindex when device is moved to > an

Re: [net-next 01/13] net/mlx5: E-switch, Move vport table functions to a new file

2021-04-07 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Tue, 6 Apr 2021 21:54:09 -0700 you wrote: > From: Chris Mi > > Currently, the vport table functions are in common eswitch offload > file. This file is too big. Move the vport table create, delete and > lookup functio

Re: [PATCH] nfc/fdp: remove unnecessary assignment and label

2021-04-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 7 Apr 2021 11:16:38 +0800 you wrote: > From: wengjianfeng > > In function fdp_nci_patch_otp and fdp_nci_patch_ram,many goto > out statements are used, and out label just return variable r. > in some places,just j

Re: [PATCH v2 net-next] stmmac: intel: Enable SERDES PHY rx clk for PSE

2021-04-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 6 Apr 2021 09:32:50 +0800 you wrote: > EHL PSE SGMII mode requires to ungate the SERDES PHY rx clk for power up > sequence and vice versa. > > Signed-off-by: Voon Weifeng > --- > Changes: > v1 -> v2 > -change s

Re: [PATCH net-next] mlxsw: core: Remove critical trip points from thermal zones

2021-04-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 6 Apr 2021 15:27:33 +0300 you wrote: > From: Vadim Pasternak > > Disable software thermal protection by removing critical trip points > from all thermal zones. > > The software thermal protection is redundant gi

RE: [PATCH V2 net] ice: fix memory leak of aRFS after resuming from suspend

2021-04-07 Thread Brelinski, TonyX
> -Original Message- > From: Intel-wired-lan On Behalf Of > Nguyen, Anthony L > Sent: Thursday, April 1, 2021 1:27 PM > To: Chittim, Madhu ; > yongxin@windriver.com; andrewx.bow...@intel.com; > jeffrey.t.kirs...@intel.com; Creeley, Brett > Cc: netdev@vger.kernel.org; intel-wired-...@l

Re: [PATCH net-next 0/8] mptcp: Cleanup, a new test case, and header trimming

2021-04-07 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Tue, 6 Apr 2021 17:15:56 -0700 you wrote: > Some more patches to include from the MPTCP tree: > > Patches 1-6 refactor an address-related data structure and reduce some > duplicate code that handles IPv4 and IPv6 addr

Re: [PATCH net-next] ethtool: document PHY tunable callbacks

2021-04-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 6 Apr 2021 17:23:59 -0700 you wrote: > Add missing kdoc for phy tunable callbacks. > > Signed-off-by: Jakub Kicinski > --- > Targetting net-next to avoid conflict with upcoming patches. > Should apply cleanly to

Re: [PATCH bpf-next] libbpf: clarify flags in ringbuf helpers

2021-04-07 Thread Andrii Nakryiko
On Wed, Apr 7, 2021 at 1:10 PM Pedro Tammela wrote: > > Em qua., 7 de abr. de 2021 às 16:58, Andrii Nakryiko > escreveu: > > > > On Wed, Apr 7, 2021 at 11:43 AM Joe Stringer wrote: > > > > > > Hi Pedro, > > > > > > On Tue, Apr 6, 2021 at 11:58 AM Pedro Tammela wrote: > > > > > > > > In 'bpf_rin

Re: [PATCH net-next] [RESEND] wireguard: disable in FIPS mode

2021-04-07 Thread Jason A. Donenfeld
Hi Hangbin, On Wed, Apr 7, 2021 at 5:39 AM Hangbin Liu wrote: > > As the cryptos(BLAKE2S, Curve25519, CHACHA20POLY1305) in WireGuard are not > FIPS certified, the WireGuard module should be disabled in FIPS mode. I'm not sure this makes so much sense to do _in wireguard_. If you feel like the FI

Re: [PATCH net-next] [RESEND] wireguard: disable in FIPS mode

2021-04-07 Thread Eric Biggers
On Wed, Apr 07, 2021 at 07:39:20PM +0800, Hangbin Liu wrote: > As the cryptos(BLAKE2S, Curve25519, CHACHA20POLY1305) in WireGuard are not > FIPS certified, the WireGuard module should be disabled in FIPS mode. > > Signed-off-by: Hangbin Liu I think you mean "FIPS allowed", not "FIPS certified"?

Re: [PATCH] net/rds: Avoid potential use after free in rds_send_remove_from_sock

2021-04-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 6 Apr 2021 19:09:12 -0500 you wrote: > In case of rs failure in rds_send_remove_from_sock(), the 'rm' resource > is freed and later under spinlock, causing potential use-after-free. > Set the free pointer to NULL to avo

RE: [PATCH v4 01/23] iidc: Introduce iidc.h

2021-04-07 Thread Saleem, Shiraz
> Subject: Re: [PATCH v4 01/23] iidc: Introduce iidc.h > > On Tue, Apr 06, 2021 at 04:01:03PM -0500, Shiraz Saleem wrote: > > > +/* Following APIs are implemented by core PCI driver */ struct > > +iidc_core_ops { > > + /* APIs to allocate resources such as VEB, VSI, Doorbell queues, > > +*

RE: [PATCH v4 05/23] ice: Add devlink params support

2021-04-07 Thread Saleem, Shiraz
> Subject: Re: [PATCH v4 05/23] ice: Add devlink params support > > On Tue, Apr 06, 2021 at 04:01:07PM -0500, Shiraz Saleem wrote: > > Add a new generic runtime devlink parameter 'rdma_protocol' > > and use it in ice PCI driver. Configuration changes result in > > unplugging the auxiliary RDMA dev

RE: [PATCH v4 resend 21/23] RDMA/irdma: Add ABI definitions

2021-04-07 Thread Saleem, Shiraz
> Subject: Re: [PATCH v4 resend 21/23] RDMA/irdma: Add ABI definitions > > On Tue, Apr 06, 2021 at 07:15:00PM -0500, Shiraz Saleem wrote: > > From: Mustafa Ismail > > > > Add ABI definitions for irdma. > > > > Signed-off-by: Mustafa Ismail > > Signed-off-by: Shiraz Saleem > > include/uapi/rdma/

Re: rtlwifi/rtl8192cu AP mode broken with PS STA

2021-04-07 Thread Maciej S. Szmigiero
On 07.04.2021 06:21, Larry Finger wrote: On 4/6/21 9:48 PM, Pkshih wrote: On Tue, 2021-04-06 at 11:25 -0500, Larry Finger wrote: On 4/6/21 7:06 AM, Maciej S. Szmigiero wrote: On 06.04.2021 12:00, Kalle Valo wrote: "Maciej S. Szmigiero" writes: On 29.03.2021 00:54, Maciej S. Szmigiero wrote

Re: [PATCH net 0/3] Fixes for sja1105 best-effort VLAN filtering

2021-04-07 Thread Vladimir Oltean
On Wed, Apr 07, 2021 at 11:14:49PM +0300, Vladimir Oltean wrote: > From: Vladimir Oltean > > This series addresses some user complaints regarding best-effort VLAN > filtering support on sja1105: > - switch not pushing VLAN tag on egress when it should > - switch not dropping traffic with unknown

Re: [PATCH kbuild] Makefile.extrawarn: disable -Woverride-init in W=1

2021-04-07 Thread Marek Behún
On Wed, 7 Apr 2021 09:14:29 +0200 Arnd Bergmann wrote: > On Wed, Apr 7, 2021 at 2:24 AM Marek Behún wrote: > > > > The -Wextra flag enables -Woverride-init in newer versions of GCC. > > > > This causes the compiler to warn when a value is written twice in a > > designated initializer, for exampl

  1   2   3   >