[PATCH net-next] net: remove the new_ifindex argument from dev_change_net_namespace

2021-04-06 Thread Andrei Vagin
Here is only one place where we want to specify new_ifindex. In all other cases, callers pass 0 as new_ifindex. It looks reasonable to add a low-level function with new_ifindex and to convert dev_change_net_namespace to a static inline wrapper. Fixes: eeb85a14ee34 ("net: Allow to specify ifindex w

[PATCH net-next] net: introduce nla_policy for IFLA_NEW_IFINDEX

2021-04-06 Thread Andrei Vagin
In this case, we don't need to check that new_ifindex is positive in validate_linkmsg. Fixes: eeb85a14ee34 ("net: Allow to specify ifindex when device is moved to another namespace") Suggested-by: Jakub Kicinski Signed-off-by: Andrei Vagin --- net/core/rtnetlink.c | 4 +--- 1 file changed, 1 i

[PATCH net-next v5] atl1c: move tx cleanup processing out of interrupt

2021-04-06 Thread Gatis Peisenieks
Tx queue cleanup happens in interrupt handler on same core as rx queue processing. Both can take considerable amount of processing in high packet-per-second scenarios. Sending big amounts of packets can stall the rx processing which is unfair and also can lead to out-of-memory condition since _

Re: [igb] netconsole triggers warning in netpoll_poll_dev

2021-04-06 Thread Oleksandr Natalenko
Hello. On Tue, Apr 06, 2021 at 11:48:02AM -0700, Jakub Kicinski wrote: > On Tue, 6 Apr 2021 14:36:19 +0200 Oleksandr Natalenko wrote: > > Hello. > > > > I've raised this here [1] first, but was suggested to engage igb devs, > > so here we are. > > > > I'm experiencing the following woes while us

[PATCH net-next] virtio-net: page_to_skb() use build_skb when there's sufficient tailroom

2021-04-06 Thread Xuan Zhuo
In page_to_skb(), if we have enough tailroom to save skb_shared_info, we can use build_skb to create skb directly. No need to alloc for additional space. And it can save a 'frags slot', which is very friendly to GRO. Here, if the payload of the received package is too small (less than GOOD_COPY_LE

Re: [PATCH net-next 05/12] ionic: add hw timestamp support files

2021-04-06 Thread Shannon Nelson
On 4/6/21 5:27 PM, Richard Cochran wrote: On Tue, Apr 06, 2021 at 04:18:00PM -0700, Shannon Nelson wrote: On 4/5/21 11:17 AM, Richard Cochran wrote: On Mon, Apr 05, 2021 at 09:16:39AM -0700, Shannon Nelson wrote: On 4/4/21 4:05 PM, Richard Cochran wrote: This check is unneeded, because the io

[net-next 11/13] net/mlx5e: TC, Refactor tc update skb function

2021-04-06 Thread Saeed Mahameed
From: Chris Mi As a pre-step to process sampled packet in this function. Signed-off-by: Chris Mi Signed-off-by: Saeed Mahameed --- .../ethernet/mellanox/mlx5/core/en/rep/tc.c | 59 +++ 1 file changed, 33 insertions(+), 26 deletions(-) diff --git a/drivers/net/ethernet/mella

[net-next 07/13] net/mlx5e: TC, Parse sample action

2021-04-06 Thread Saeed Mahameed
From: Chris Mi Parse TC sample action and save sample parameters in flow attribute data structure. Signed-off-by: Chris Mi Reviewed-by: Oz Shlomo Reviewed-by: Mark Bloch Signed-off-by: Saeed Mahameed --- .../ethernet/mellanox/mlx5/core/en/tc_priv.h | 1 + .../net/ethernet/mellanox/mlx5/co

[net-next 08/13] net/mlx5e: TC, Add sampler termination table API

2021-04-06 Thread Saeed Mahameed
From: Chris Mi Sampled packets are sent to software using termination tables. There is only one rule in that table that is to forward sampled packets to the e-switch management vport. Create a sampler termination table and rule for each eswitch. Signed-off-by: Chris Mi Reviewed-by: Oz Shlomo

[net-next 06/13] net/mlx5: Instantiate separate mapping objects for FDB and NIC tables

2021-04-06 Thread Saeed Mahameed
From: Chris Mi Currently, the u32 chain id is mapped to u16 value which is stored on the lower 16 bits of reg_c0 for FDB and reg_b for NIC tables. The mapping is internally maintained by the chains object. However, with the introduction of reg_c0 objects the fdb may store more than just the chain

[net-next 09/13] net/mlx5e: TC, Add sampler object API

2021-04-06 Thread Saeed Mahameed
From: Chris Mi In order to offload sample action, HW introduces sampler object. The sampler object samples packets according to the provided sample ratio. Sampled packets are duplicated. One copy is processed by a termination table, named the sample table, which sends the packet up to software. T

[net-next 10/13] net/mlx5e: TC, Add sampler restore handle API

2021-04-06 Thread Saeed Mahameed
From: Chris Mi Use common object pool to create an object ID to map sample parameters. Allocate a modify header action to write the object ID to reg_c0 lower 16 bits. Create a restore rule to pass the object ID to software. So software can identify sampled packets via the object ID and send it to

[net-next 13/13] net/mlx5e: TC, Add support to offload sample action

2021-04-06 Thread Saeed Mahameed
From: Chris Mi The following diagram illustrates the hardware model for tc sample action: +-+ + original flow table + +-+ + original match+ +-+ | v +---

[net-next 05/13] net/mlx5: Map register values to restore objects

2021-04-06 Thread Saeed Mahameed
From: Chris Mi Currently reg_c0 lower 16 bits and reg_b are used to store the chain id that missed in FDB and NIC tables accordingly. However, the registers' values may index a restore object, rather than a single u32 value. Different object types can be used to restore mutually exclusive context

[net-next 12/13] net/mlx5e: TC, Handle sampled packets

2021-04-06 Thread Saeed Mahameed
From: Chris Mi Mark the sampled packets with a sample restore object. Send sampled packets using the psample api. Signed-off-by: Chris Mi Reviewed-by: Oz Shlomo Reviewed-by: Mark Bloch Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/en/rep/tc.c | 14 +++--- .

[net-next 02/13] net/mlx5: E-switch, Rename functions to follow naming convention.

2021-04-06 Thread Saeed Mahameed
From: Chris Mi Public api starts with mlx5 and remove mlx5 for non-public api. Signed-off-by: Chris Mi Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/esw/vporttbl.c | 4 +-- .../net/ethernet/mellanox/mlx5/core/eswitch.h | 4 +-- .../mellanox/mlx5/core/eswitch_offloads.c

[net-next 03/13] net/mlx5: E-switch, Generalize per vport table API

2021-04-06 Thread Saeed Mahameed
From: Chris Mi Currently, per vport table was used only for port mirroring actions. However, sample action will also require a per vport table instance. Generalize the vport table API to work with multiple namespaces where each namespace manages its own vport table instance. Signed-off-by: Chri

[net-next 04/13] net/mlx5: E-switch, Set per vport table default group number

2021-04-06 Thread Saeed Mahameed
From: Chris Mi Different per voprt table is created using a different per vport table namespace. Because we can't use variable to set the namespace member value. If max group number is 0 in the namespace, use the eswitch default max group number. Signed-off-by: Chris Mi Reviewed-by: Oz Shlomo

[net-next 01/13] net/mlx5: E-switch, Move vport table functions to a new file

2021-04-06 Thread Saeed Mahameed
From: Chris Mi Currently, the vport table functions are in common eswitch offload file. This file is too big. Move the vport table create, delete and lookup functions to a separate file. Put the file in esw directory. Pre-step for generalizing its functionality for serving both the mirroring and

[pull request][net-next 00/13] mlx5 updates 2021-04-06

2021-04-06 Thread Saeed Mahameed
From: Saeed Mahameed Hi Dave, Jakub, This series From Chris adds the support for TC psample offloads to mlx5 driver. For more information please see tag log below. Please pull and let me know if there is any problem. Thanks, Saeed. --- The following changes since commit 0b35e0deb5bee7d488235

[RFC v2 net-next 4/4] staging: mt7621-dts: enable MT7530 interrupt controller

2021-04-06 Thread DENG Qingfang
Enable MT7530 interrupt controller in the MT7621 SoC. Signed-off-by: DENG Qingfang --- RFC v1 -> RFC v2: - No changes. drivers/staging/mt7621-dts/mt7621.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/mt7621-dts/mt7621.dtsi b/drivers/staging/mt7621-dts/mt7621.dtsi i

[RFC v2 net-next 3/4] dt-bindings: net: dsa: add MT7530 interrupt controller binding

2021-04-06 Thread DENG Qingfang
Add device tree binding to support MT7530 interrupt controller. Signed-off-by: DENG Qingfang --- RFC v1 -> RFC v2: - No changes. Documentation/devicetree/bindings/net/dsa/mt7530.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/net/dsa/mt7530.txt b/

[RFC v2 net-next 2/4] net: dsa: mt7530: add interrupt support

2021-04-06 Thread DENG Qingfang
Add support for MT7530 interrupt controller to handle internal PHYs. In order to assign an IRQ number to each PHY, the registration of MDIO bus is also done in this driver. Signed-off-by: DENG Qingfang --- RFC v1 -> RFC v2: - Split MDIO and IRQ setup function drivers/net/dsa/Kconfig | 1 + d

[RFC v2 net-next 1/4] net: phy: add MediaTek PHY driver

2021-04-06 Thread DENG Qingfang
Add support for MediaTek PHYs found in MT7530 and MT7531 switches. The initialization procedure is from the vendor driver, but due to lack of documentation, the function of some register values remains unknown. Signed-off-by: DENG Qingfang --- RFC v1 -> RFC v2: - Add PHY interface mode check, sug

[RFC v2 net-next 0/4] MT7530 interrupt support

2021-04-06 Thread DENG Qingfang
Add support for MT7530 interrupt controller. DENG Qingfang (4): net: phy: add MediaTek PHY driver net: dsa: mt7530: add interrupt support dt-bindings: net: dsa: add MT7530 interrupt controller binding staging: mt7621-dts: enable MT7530 interrupt controller .../devicetree/bindings/net/dsa

Re: rtlwifi/rtl8192cu AP mode broken with PS STA

2021-04-06 Thread Larry Finger
On 4/6/21 9:48 PM, Pkshih wrote: On Tue, 2021-04-06 at 11:25 -0500, Larry Finger wrote: On 4/6/21 7:06 AM, Maciej S. Szmigiero wrote: On 06.04.2021 12:00, Kalle Valo wrote: "Maciej S. Szmigiero" writes: On 29.03.2021 00:54, Maciej S. Szmigiero wrote: Hi, It looks like rtlwifi/rtl8192cu AP

[net 4/5] net/mlx5: Fix PBMC register mapping

2021-04-06 Thread Saeed Mahameed
From: Aya Levin Add reserved mapping to cover all the register in order to avoid setting arbitrary values to newer FW which implements the reserved fields. Fixes: 50b4a3c23646 ("net/mlx5: PPTB and PBMC register firmware command support") Signed-off-by: Aya Levin Reviewed-by: Moshe Shemesh Sig

[net 3/5] net/mlx5: Fix PPLM register mapping

2021-04-06 Thread Saeed Mahameed
From: Aya Levin Add reserved mapping to cover all the register in order to avoid setting arbitrary values to newer FW which implements the reserved fields. Fixes: a58837f52d43 ("net/mlx5e: Expose FEC feilds and related capability bit") Signed-off-by: Aya Levin Reviewed-by: Moshe Shemesh Signed

[net 5/5] net/mlx5: fix kfree mismatch in indir_table.c

2021-04-06 Thread Saeed Mahameed
From: Xiaoming Ni Memory allocated by kvzalloc() should be freed by kvfree(). Fixes: 34ca65352ddf2 ("net/mlx5: E-Switch, Indirect table infrastructur") Signed-off-by: Xiaoming Ni Reviewed-by: Leon Romanovsky Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/esw/indir_tabl

[net 1/5] net/mlx5: Fix HW spec violation configuring uplink

2021-04-06 Thread Saeed Mahameed
From: Eli Cohen Make sure to modify uplink port to follow only if the uplink_follow capability is set as required by the HW spec. Failure to do so causes traffic to the uplink representor net device to cease after switching to switchdev mode. Fixes: 7d0314b11cdd ("net/mlx5e: Modify uplink state

[net 2/5] net/mlx5: Fix placement of log_max_flow_counter

2021-04-06 Thread Saeed Mahameed
From: Raed Salem The cited commit wrongly placed log_max_flow_counter field of mlx5_ifc_flow_table_prop_layout_bits, align it to the HW spec intended placement. Fixes: 16f1c5bb3ed7 ("net/mlx5: Check device capability for maximum flow counters") Signed-off-by: Raed Salem Reviewed-by: Roi Dayan

[pull request][net 0/5] mlx5 fixes 2021-04-06

2021-04-06 Thread Saeed Mahameed
From: Saeed Mahameed Hi Dave, Jakub, This series provides some fixes to mlx5 driver. Please pull and let me know if there is any problem. Thanks, Saeed. --- The following changes since commit 5219d6012d46ec1fa3397e50bfeb7b8c16df72cf: docs: ethtool: fix some copy-paste errors (2021-04-06 16:

Re: [PATCH net-next 0/3] net/mlx5: Fix some coding-style issues

2021-04-06 Thread Saeed Mahameed
On Thu, 2021-04-01 at 21:07 +0800, Weihang Li wrote: > Just make some cleanups according to the coding style of kernel. > > Wenpeng Liang (3): >   net/mlx5: Add a blank line after declarations. >   net/mlx5: Remove return statement exist at the end of void function >   net/mlx5: Replace spaces wit

Re: [PATCH] net/mlx5: fix kfree mismatch in indir_table.c

2021-04-06 Thread Saeed Mahameed
On Mon, 2021-04-05 at 07:56 +0300, Leon Romanovsky wrote: > On Mon, Apr 05, 2021 at 10:53:39AM +0800, Xiaoming Ni wrote: > > Memory allocated by kvzalloc() should be freed by kvfree(). > > > > Fixes: 34ca65352ddf2 ("net/mlx5: E-Switch, Indirect table > > infrastructur") > > Signed-off-by: Xiaoming

[Patch bpf-next] skmsg: pass psock pointer to ->psock_update_sk_prot()

2021-04-06 Thread Cong Wang
From: Cong Wang Using sk_psock() to retrieve psock pointer from sock requires RCU read lock, but we already get psock pointer before calling ->psock_update_sk_prot() in both cases, so we can just pass it without bothering sk_psock(). Reported-and-tested-by: syzbot+320a3bc8d80f478c3...@syzkaller.

[PATCH] nfc/fdp: remove unnecessary assignment and label

2021-04-06 Thread samirweng1979
From: wengjianfeng In function fdp_nci_patch_otp and fdp_nci_patch_ram,many goto out statements are used, and out label just return variable r. in some places,just jump to the out label, and in other places, assign a value to the variable r,then jump to the out label. It is unnecessary, we just u

RE: [PATCH net-next v2 0/2] Enable 2.5Gbps speed for stmmac

2021-04-06 Thread Voon, Weifeng
> > The limitation is not on the MAC, PCS or the PHY. For Intel mgbe, the > > overclocking of 2.5 times clock rate to support 2.5G is only able to > > be configured in the BIOS during boot time. Kernel driver has no > > access to modify the clock rate for 1Gbps/2.5G mode. The way to > > determined

Re: [PATCH net-next] ipv6: report errors for iftoken via netlink extack

2021-04-06 Thread kernel test robot
/net-next.git cc0626c2aaed8e475efdd85fa374b497a7192e35 config: arm64-randconfig-r012-20210406 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project c060945b23a1c54d4b2a053ff4b093a2277b303d) reproduce (this is a W=1 build): wget https

Re: rtlwifi/rtl8192cu AP mode broken with PS STA

2021-04-06 Thread Pkshih
On Tue, 2021-04-06 at 11:25 -0500, Larry Finger wrote: > On 4/6/21 7:06 AM, Maciej S. Szmigiero wrote: > > On 06.04.2021 12:00, Kalle Valo wrote: > >> "Maciej S. Szmigiero" writes: > >> > >>> On 29.03.2021 00:54, Maciej S. Szmigiero wrote: > Hi, > > It looks like rtlwifi/rtl8192cu A

Re: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-06 Thread kernel test robot
Hi Dexuan, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Dexuan-Cui/net-mana-Add-a-driver-for-Microsoft-Azure-Network-Adapter-MANA/20210407-072552 base: https://git.kernel.org/pub/scm/linux/kernel

Re: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-06 Thread kernel test robot
/davem/net-next.git cc0626c2aaed8e475efdd85fa374b497a7192e35 config: powerpc-randconfig-r024-20210406 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project c060945b23a1c54d4b2a053ff4b093a2277b303d) reproduce (this is a W=1 build): wget https

Re: [PATCH net-next] ethtool: document PHY tunable callbacks

2021-04-06 Thread Florian Fainelli
On 4/6/2021 5:23 PM, Jakub Kicinski wrote: > Add missing kdoc for phy tunable callbacks. > > Signed-off-by: Jakub Kicinski Reviewed-by: Florian Fainelli -- Florian

[PATCH v2] net: tipc: Fix spelling errors in net/tipc module

2021-04-06 Thread Zheng Yongjun
These patches fix a series of spelling errors in net/tipc module. Reported-by: Hulk Robot Signed-off-by: Zheng Yongjun --- net/tipc/bearer.h | 6 +++--- net/tipc/net.c| 2 +- net/tipc/node.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/net/tipc/bearer.h b/net/tip

Re: [PATCH net-next v3 2/2] of: net: fix of_get_mac_addr_nvmem() for PCI and DSA nodes

2021-04-06 Thread Florian Fainelli
On 4/6/2021 3:09 PM, Michael Walle wrote: > of_get_mac_address() already supports fetching the MAC address by an > nvmem provider. But until now, it was just working for platform devices. > Esp. it was not working for DSA ports and PCI devices. It gets more > common that PCI devices have a devic

RE: [PATCH] net: phy: fix PHY possibly unwork after MDIO bus resume back

2021-04-06 Thread Joakim Zhang
Hi Heiner, > -Original Message- > From: Heiner Kallweit > Sent: 2021年4月7日 2:22 > To: Joakim Zhang ; christian.me...@t2data.com; > and...@lunn.ch; li...@armlinux.org.uk; da...@davemloft.net; > k...@kernel.org; Russell King - ARM Linux > Cc: netdev@vger.kernel.org; linux-ker...@vger.kerne

Re: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-06 Thread kernel test robot
/kernel/git/davem/net-next.git cc0626c2aaed8e475efdd85fa374b497a7192e35 config: i386-randconfig-m021-20210406 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/f086d8bc693c2686de24a81398e49496ab3747a9

Re: [PATCH 2/2] of: net: fix of_get_mac_addr_nvmem() for PCI and DSA nodes

2021-04-06 Thread Rob Herring
On Mon, Apr 5, 2021 at 11:47 AM Michael Walle wrote: > > of_get_mac_address() already supports fetching the MAC address by an > nvmem provider. But until now, it was just working for platform devices. > Esp. it was not working for DSA ports and PCI devices. It gets more > common that PCI devices h

Re: [PATCH net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)

2021-04-06 Thread Andrew Lunn
> +static int gdma_query_max_resources(struct pci_dev *pdev) > +{ > + struct gdma_context *gc = pci_get_drvdata(pdev); > + struct gdma_general_req req = { 0 }; > + struct gdma_query_max_resources_resp resp = { 0 }; > + int err; Network drivers need to use reverse christmas tree. I

Re: [PATCH v2 2/2] drivers: net: dsa: qca8k: add support for multiple cpu port

2021-04-06 Thread Ansuel Smith
On Wed, Apr 07, 2021 at 02:41:02AM +0200, Andrew Lunn wrote: > On Tue, Apr 06, 2021 at 06:50:40AM +0200, Ansuel Smith wrote: > > qca8k 83xx switch have 2 cpu ports. Rework the driver to support > > multiple cpu port. All ports can access both cpu ports by default as > > they support the same featur

Re: [PATCH v2 2/2] drivers: net: dsa: qca8k: add support for multiple cpu port

2021-04-06 Thread Andrew Lunn
On Tue, Apr 06, 2021 at 06:50:40AM +0200, Ansuel Smith wrote: > qca8k 83xx switch have 2 cpu ports. Rework the driver to support > multiple cpu port. All ports can access both cpu ports by default as > they support the same features. Do you have more information about how this actually works. How

Re: [PATCH net-next] ethtool: document PHY tunable callbacks

2021-04-06 Thread Andrew Lunn
On Tue, Apr 06, 2021 at 05:23:59PM -0700, Jakub Kicinski wrote: > Add missing kdoc for phy tunable callbacks. > > Signed-off-by: Jakub Kicinski Reviewed-by: Andrew Lunn Andrew

[PATCH v2 2/2] drivers: net: dsa: qca8k: add support for multiple cpu port

2021-04-06 Thread Ansuel Smith
qca8k 83xx switch have 2 cpu ports. Rework the driver to support multiple cpu port. All ports can access both cpu ports by default as they support the same features. Signed-off-by: Ansuel Smith --- drivers/net/dsa/qca8k.c | 18 +- drivers/net/dsa/qca8k.h | 2 -- 2 files changed,

[PATCH v2 1/2] include: net: add dsa_cpu_ports function

2021-04-06 Thread Ansuel Smith
In preparation for the future when dsa will support multi cpu port, dsa_cpu_ports can be useful for switch that has multiple cpu port to retrieve the cpu mask for ACL and bridge table. Signed-off-by: Ansuel Smith --- include/net/dsa.h | 12 1 file changed, 12 insertions(+) diff --g

Re: [PATCH RFC net 2/2] net: dsa: lantiq_gswip: Configure all remaining GSWIP_MII_CFG bits

2021-04-06 Thread Andrew Lunn
> case PHY_INTERFACE_MODE_RGMII: > case PHY_INTERFACE_MODE_RGMII_ID: > case PHY_INTERFACE_MODE_RGMII_RXID: > case PHY_INTERFACE_MODE_RGMII_TXID: > miicfg |= GSWIP_MII_CFG_MODE_RGMII; > + > + if (phylink_autoneg_inband(mode)) > +

Re: [PATCH net-next 09/12] ionic: add and enable tx and rx timestamp handling

2021-04-06 Thread Richard Cochran
On Tue, Apr 06, 2021 at 04:06:09PM -0700, Shannon Nelson wrote: > Interesting... I doubt that our particular MAC and PHY will ever be > separate, but it makes sense to watch for this in the general case. I've got > an update coming for this. Even if your HW can never support stacked MAC/PHY HW tim

[PATCH net 1/3] ethtool: un-kdocify extended link state

2021-04-06 Thread Jakub Kicinski
Extended link state structures and enums use kdoc headers but then do not describe any of the members. Convert to normal comments. Signed-off-by: Jakub Kicinski --- include/linux/ethtool.h | 4 +--- include/uapi/linux/ethtool.h | 26 ++ 2 files changed, 7 insertion

[PATCH net 2/3] ethtool: document reserved fields in the uAPI

2021-04-06 Thread Jakub Kicinski
Add a note on expected handling of reserved fields, and references to all kdocs. This fixes a bunch of kdoc warnings. Signed-off-by: Jakub Kicinski --- include/uapi/linux/ethtool.h | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/ethto

[PATCH net 3/3] ethtool: fix kdoc in headers

2021-04-06 Thread Jakub Kicinski
Fix remaining issues with kdoc in the ethtool headers. Signed-off-by: Jakub Kicinski --- include/linux/ethtool.h | 9 +++-- include/uapi/linux/ethtool.h | 6 ++ 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h index a2

[PATCH net 0/3] ethtool: kdoc fixes

2021-04-06 Thread Jakub Kicinski
Number of kdoc fixes to ethtool headers. All comment changes. With all the patches posted kdoc script seems happy: $ ./scripts/kernel-doc -none include/uapi/linux/ethtool.h include/linux/ethtool.h $ Note that some of the changes are in -next, e.g. the FEC documentation update so full effect will

Re: [PATCH net-next 05/12] ionic: add hw timestamp support files

2021-04-06 Thread Richard Cochran
On Tue, Apr 06, 2021 at 04:18:00PM -0700, Shannon Nelson wrote: > On 4/5/21 11:17 AM, Richard Cochran wrote: > > On Mon, Apr 05, 2021 at 09:16:39AM -0700, Shannon Nelson wrote: > > > On 4/4/21 4:05 PM, Richard Cochran wrote: > > > > This check is unneeded, because the ioctl layer never passes NULL

Re: [PATCH RFC net 1/2] net: dsa: lantiq_gswip: Don't use PHY auto polling

2021-04-06 Thread Andrew Lunn
On Tue, Apr 06, 2021 at 10:35:07PM +0200, Martin Blumenstingl wrote: > PHY auto polling on the GSWIP hardware can be used so link changes > (speed, link up/down, etc.) can be detected automatically. Internally > GSWIP reads the PHY's registers for this functionality. Based on this > automatic detec

[PATCH kbuild] Makefile.extrawarn: disable -Woverride-init in W=1

2021-04-06 Thread Marek Behún
The -Wextra flag enables -Woverride-init in newer versions of GCC. This causes the compiler to warn when a value is written twice in a designated initializer, for example: int x[1] = { [0] = 3, [0] = 3, }; Note that for clang, this was disabled from the beginning with -Wno-initializer

[PATCH net-next] ethtool: document PHY tunable callbacks

2021-04-06 Thread Jakub Kicinski
Add missing kdoc for phy tunable callbacks. Signed-off-by: Jakub Kicinski --- Targetting net-next to avoid conflict with upcoming patches. Should apply cleanly to both trees. include/linux/ethtool.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/ethtool.h b/include/linux/et

Re: [PATCH net-next v3 04/18] net: phy: marvell10g: indicate 88X33x0 only port control registers

2021-04-06 Thread Marek Behún
On Wed, 7 Apr 2021 02:10:24 +0200 Andrew Lunn wrote: > > @@ -479,8 +479,8 @@ static int mv3310_config_init(struct phy_device *phydev) > > val = phy_read_mmd(phydev, MDIO_MMD_VEND2, MV_V2_PORT_CTRL); > > if (val < 0) > > return val; > > - priv->rate_match = ((val & MV_V2_PORT

Re: [PATCH v2 1/1] time64.h: Consolidated PSEC_PER_SEC definition

2021-04-06 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 6 Apr 2021 13:22:51 +0300 you wrote: > We have currently three users of the PSEC_PER_SEC each of them defining it > individually. Instead, move it to time64.h to be available for everyone. > > There is a new user

Re: [PATCH net-next] nfp: flower: add support for packet-per-second policing

2021-04-06 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 6 Apr 2021 17:54:52 +0200 you wrote: > From: Peng Zhang > > Allow hardware offload of a policer action attached to a matchall filter > which enforces a packets-per-second rate-limit. > > e.g. > tc filter add dev

Re: [PATCH net-next v1 1/1] stmmac: intel: Drop duplicate ID in the list of PCI device IDs

2021-04-06 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 6 Apr 2021 13:13:06 +0300 you wrote: > The PCI device IDs are defined with a prefix PCI_DEVICE_ID. > There is no need to repeat the ID part at the end of each definition. > > Signed-off-by: Andy Shevchenko > ---

Re: [PATCH net-next] docs: ethtool: correct quotes

2021-04-06 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 6 Apr 2021 15:59:31 -0700 you wrote: > Quotes to backticks. All commands use backticks since the names > are constants. > > Signed-off-by: Jakub Kicinski > --- > Targeting net-next to avoid conflicts with upcomin

RE: [PATCH v4 00/23] Add Intel Ethernet Protocol Driver for RDMA (irdma)

2021-04-06 Thread Saleem, Shiraz
> Subject: RE: [PATCH v4 00/23] Add Intel Ethernet Protocol Driver for RDMA > (irdma) > > > Subject: Re: [PATCH v4 00/23] Add Intel Ethernet Protocol Driver for > > RDMA > > (irdma) > > > > On Tue, Apr 06, 2021 at 04:01:02PM -0500, Shiraz Saleem wrote: > > > Dave Ertman (4): > > > iidc: Introduc

[PATCH v4 resend 23/23] RDMA/irdma: Update MAINTAINERS file

2021-04-06 Thread Shiraz Saleem
Add maintainer entry for irdma driver. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 276cadf..f1a9752 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8957,6 +8957,14 @@ F:

[PATCH net-next 7/8] selftests: mptcp: add the net device name testcase

2021-04-06 Thread Mat Martineau
From: Geliang Tang This patch added a new testcase for setting the net device name. In it, pass the net device name to pm_nl_ctl to set the ifindex field of struct mptcp_pm_addr_entry. Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- tools/testing/selftests/net/mptcp/mptcp_join.sh

[PATCH] SUNRPC: Add a check for gss_release_msg

2021-04-06 Thread Aditya Pakki
In gss_pipe_destroy_msg(), in case of error in msg, gss_release_msg deletes gss_msg. The patch adds a check to avoid a potential double free. Signed-off-by: Aditya Pakki --- net/sunrpc/auth_gss/auth_gss.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/sunrpc/auth_gss/a

[PATCH v4 resend 21/23] RDMA/irdma: Add ABI definitions

2021-04-06 Thread Shiraz Saleem
From: Mustafa Ismail Add ABI definitions for irdma. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- include/uapi/rdma/irdma-abi.h | 116 ++ 1 file changed, 116 insertions(+) create mode 100644 include/uapi/rdma/irdma-abi.h diff --git a/

[PATCH net-next 6/8] mptcp: unify add_addr(6)_generate_hmac

2021-04-06 Thread Mat Martineau
From: Geliang Tang The length of the IPv4 address is 4 octets and IPv6 is 16. That's the only difference between add_addr_generate_hmac and add_addr6_generate_hmac. This patch dropped the duplicate code and unify them into one. Co-developed-by: Matthieu Baerts Signed-off-by: Matthieu Baerts S

[PATCH net-next 8/8] mptcp: drop all sub-options except ADD_ADDR when the echo bit is set

2021-04-06 Thread Mat Martineau
From: Davide Caratti Current Linux carries echo-ed ADD_ADDR over pure TCP ACKs, so there is no need to add a DSS element that would fit only ADD_ADDR with IPv4 address. Drop the DSS from echo-ed ADD_ADDR, regardless of the IP version. Signed-off-by: Davide Caratti Signed-off-by: Mat Martineau

[PATCH v4 resend 20/23] RDMA/irdma: Add dynamic tracing for CM

2021-04-06 Thread Shiraz Saleem
From: "Michael J. Ruhl" Add dynamic tracing functionality to debug connection management issues. Signed-off-by: "Michael J. Ruhl" Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/trace.c| 112 drivers/infiniband/hw/irdma/trace.h| 3 + drivers/infiniband/hw/irdma

[PATCH net-next 5/8] mptcp: drop MPTCP_ADDR_IPVERSION_4/6

2021-04-06 Thread Mat Martineau
From: Geliang Tang Since the type of the address family in struct mptcp_options_received became sa_family_t, we should set AF_INET/AF_INET6 to it, instead of using MPTCP_ADDR_IPVERSION_4/6. Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- net/mptcp/options.c | 14 +++---

[PATCH v4 resend 19/23] RDMA/irdma: Add miscellaneous utility definitions

2021-04-06 Thread Shiraz Saleem
From: Mustafa Ismail Add miscellaneous utility functions and headers. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/osdep.h | 86 ++ drivers/infiniband/hw/irdma/protos.h | 116 ++ drivers/infiniband/hw/irdma/status.h | 71 + drivers/infiniban

[PATCH v4 resend 18/23] RDMA/irdma: Add user/kernel shared libraries

2021-04-06 Thread Shiraz Saleem
From: Mustafa Ismail Building the WQE descriptors for different verb operations are similar in kernel and user-space. Add these shared libraries. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/uk.c | 1737 driv

Re: [PATCH] include: net: add dsa_cpu_ports function

2021-04-06 Thread Andrew Lunn
On Tue, Apr 06, 2021 at 05:49:03AM +0200, Ansuel Smith wrote: > In preparation for the future when dsa will support multi cpu port, > dsa_cpu_ports can be useful for switch that has multiple cpu port to > retrieve the cpu mask for ACL and bridge table. > > Signed-off-by: Ansuel Smith > --- > inc

[PATCH net-next 4/8] mptcp: use mptcp_addr_info in mptcp_options_received

2021-04-06 Thread Mat Martineau
From: Geliang Tang This patch added a new struct mptcp_addr_info member addr in struct mptcp_options_received, and dropped the original family, addr_id, addr, addr6 and port fields in it. Then we can pass the parameter mp_opt.addr directly to mptcp_pm_add_addr_received and mptcp_pm_add_addr_echoe

[PATCH net-next 3/8] mptcp: drop OPTION_MPTCP_ADD_ADDR6

2021-04-06 Thread Mat Martineau
From: Geliang Tang Since the family field was added in struct mptcp_out_options, no need to use OPTION_MPTCP_ADD_ADDR6 to identify the IPv6 address. Drop it. Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- net/mptcp/options.c | 15 +-- net/mptcp/protocol.h | 9 -

[PATCH net-next 1/8] mptcp: move flags and ifindex out of mptcp_addr_info

2021-04-06 Thread Mat Martineau
From: Geliang Tang This patch moved the flags and ifindex fields from struct mptcp_addr_info to struct mptcp_pm_addr_entry. Add the flags and ifindex values as two new parameters to __mptcp_subflow_connect. In mptcp_pm_create_subflow_or_signal_addr, pass the local address entry's flags and ifind

[PATCH v4 resend 17/23] RDMA/irdma: Add RoCEv2 UD OP support

2021-04-06 Thread Shiraz Saleem
From: Mustafa Ismail Add the header, data structures and functions to populate the WQE descriptors and issue the Control QP commands that support RoCEv2 UD operations. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/uda.c | 379

[PATCH v4 resend 15/23] RDMA/irdma: Add PBLE resource manager

2021-04-06 Thread Shiraz Saleem
From: Mustafa Ismail Implement a Physical Buffer List Entry (PBLE) resource manager to manage a pool of PBLE HMC resource objects. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/pble.c | 525 + drivers/infiniband/

[PATCH] net/rds: Avoid potential use after free in rds_send_remove_from_sock

2021-04-06 Thread Aditya Pakki
In case of rs failure in rds_send_remove_from_sock(), the 'rm' resource is freed and later under spinlock, causing potential use-after-free. Set the free pointer to NULL to avoid undefined behavior. Signed-off-by: Aditya Pakki --- net/rds/message.c | 1 + net/rds/send.c| 2 +- 2 files change

[PATCH v4 resend 16/23] RDMA/irdma: Implement device supported verb APIs

2021-04-06 Thread Shiraz Saleem
From: Mustafa Ismail Implement device supported verb APIs. The supported APIs vary based on the underlying transport the ibdev is registered as (i.e. iWARP or RoCEv2). Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/verbs.c | 4544 +++

[PATCH net-next 2/8] mptcp: use mptcp_addr_info in mptcp_out_options

2021-04-06 Thread Mat Martineau
From: Geliang Tang This patch moved the mptcp_addr_info struct from protocol.h to mptcp.h, added a new struct mptcp_addr_info member addr in struct mptcp_out_options, and dropped the original addr, addr6, addr_id and port fields in it. Then we can use opts->addr to get the adding address from PM

[PATCH net-next 0/8] mptcp: Cleanup, a new test case, and header trimming

2021-04-06 Thread Mat Martineau
Some more patches to include from the MPTCP tree: Patches 1-6 refactor an address-related data structure and reduce some duplicate code that handles IPv4 and IPv6 addresses. Patch 7 adds a test case for the MPTCP netlink interface, passing a specific ifindex to the kernel. Patch 8 drops extra he

[PATCH v4 resend 13/23] RDMA/irdma: Add QoS definitions

2021-04-06 Thread Shiraz Saleem
From: Mustafa Ismail Add definitions for managing the RDMA HW work scheduler (WS) tree. A WS node is created via a control QP operation with the bandwidth allocation, arbitration scheme, and traffic class of the QP specified. The Qset handle returned associates the QoS parameters for the QP. The

[PATCH v4 resend 14/23] RDMA/irdma: Add connection manager

2021-04-06 Thread Shiraz Saleem
From: Mustafa Ismail Add connection management (CM) implementation for iWARP including accept, reject, connect, create_listen, destroy_listen and CM utility functions Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/cm.c | 4425 +++

[PATCH v4 resend 12/23] RDMA/irdma: Add privileged UDA queue implementation

2021-04-06 Thread Shiraz Saleem
From: Mustafa Ismail Implement privileged UDA queues to handle iWARP connection packets and receive exceptions. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/puda.c | 1749 drivers/infiniband/hw/irdma/puda.h |

[PATCH v4 resend 05/23] ice: Add devlink params support

2021-04-06 Thread Shiraz Saleem
Add a new generic runtime devlink parameter 'rdma_protocol' and use it in ice PCI driver. Configuration changes result in unplugging the auxiliary RDMA device and re-plugging it with updated values for irdma auxiiary driver to consume at drv.probe() Signed-off-by: Shiraz Saleem --- .../networkin

[PATCH v4 resend 06/23] i40e: Prep i40e header for aux bus conversion

2021-04-06 Thread Shiraz Saleem
Add the definitions and private ops to the i40e client header file in preparation to convert i40e to use the new auxiliary bus infrastructure. This header is shared between the 'i40e' Intel networking driver providing RDMA support and the 'irdma' driver. Signed-off-by: Shiraz Saleem --- include/

[PATCH v4 resend 04/23] ice: Register auxiliary device to provide RDMA

2021-04-06 Thread Shiraz Saleem
From: Dave Ertman Register ice client auxiliary RDMA device on the auxiliary bus per PCIe device function for the auxiliary driver (irdma) to attach to. It allows to realize a single RDMA driver (irdma) capable of working with multiple netdev drivers over multi-generation Intel HW supporting RDMA

[PATCH v4 resend 03/23] ice: Implement iidc operations

2021-04-06 Thread Shiraz Saleem
From: Dave Ertman Add implementations for supporting iidc operations for device operation such as allocation of resources and event notifications. Signed-off-by: Dave Ertman Signed-off-by: Tony Nguyen Signed-off-by: Shiraz Saleem --- drivers/net/ethernet/intel/ice/ice.h | 1 +

[PATCH v4 resend 02/23] ice: Initialize RDMA support

2021-04-06 Thread Shiraz Saleem
From: Dave Ertman Probe the device's capabilities to see if it supports RDMA. If so, allocate and reserve resources to support its operation; populate structures with initial values. Signed-off-by: Dave Ertman Signed-off-by: Tony Nguyen Signed-off-by: Shiraz Saleem --- drivers/net/ethernet/i

[PATCH v4 resend 11/23] RDMA/irdma: Add HMC backing store setup functions

2021-04-06 Thread Shiraz Saleem
From: Mustafa Ismail HW uses host memory as a backing store for a number of protocol context objects and queue state tracking. The Host Memory Cache (HMC) is a component responsible for managing these objects stored in host memory. Add the functions and data structures to manage the allocation o

[PATCH v4 resend 08/23] RDMA/irdma: Register auxiliary driver and implement private channel OPs

2021-04-06 Thread Shiraz Saleem
From: Mustafa Ismail Register auxiliary drivers which can attach to auxiliary RDMA devices from Intel PCI netdev drivers i40e and ice. Implement the private channel ops, and register net notifiers. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/i40i

[PATCH v4 resend 09/23] RDMA/irdma: Implement device initialization definitions

2021-04-06 Thread Shiraz Saleem
From: Mustafa Ismail Implement device initialization routines, interrupt set-up, and allocate object bit-map tracking structures. Also, add device specific attributes and register definitions. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/hw.c

  1   2   3   4   >