[PATCH net-next] ip6_tunnel: sit: proper dev_{hold|put} in ndo_[un]init methods

2021-03-29 Thread Eric Dumazet
From: Eric Dumazet Same reasons than for the previous commits : 6289a98f0817 ("sit: proper dev_{hold|put} in ndo_[un]init methods") 40cb881b5aaa ("ip6_vti: proper dev_{hold|put} in ndo_[un]init methods") 7f700334be9a ("ip6_gre: proper dev_{hold|put} in ndo_[un]init methods") After adopting CONFI

Re: [Patch bpf-next v7 09/13] udp: implement ->read_sock() for sockmap

2021-03-29 Thread John Fastabend
Cong Wang wrote: > On Mon, Mar 29, 2021 at 11:23 PM John Fastabend > wrote: > > > > Cong Wang wrote: > > > On Mon, Mar 29, 2021 at 1:54 PM John Fastabend > > > wrote: > > > > > > > > Cong Wang wrote: > > > > > From: Cong Wang > > > > > > > > > > This is similar to tcp_read_sock(), except we do

Re: [PATCH bpf-next 2/2] bpf: selftests: Update clang requirement in README.rst for testing kfunc call

2021-03-29 Thread Song Liu
> On Mar 29, 2021, at 10:41 PM, Martin KaFai Lau wrote: > > This patch updates the README.rst to specify the clang requirement > to compile the bpf selftests that call kernel function. > > Signed-off-by: Martin KaFai Lau Acked-by: Song Liu

Re: [PATCH bpf-next 1/2] bpf: Update bpf_design_QA.rst to clarify the kfunc call is not ABI

2021-03-29 Thread Song Liu
> On Mar 29, 2021, at 10:41 PM, Martin KaFai Lau wrote: > > This patch updates bpf_design_QA.rst to clarify that the kernel > function callable by bpf program is not an ABI. > > Signed-off-by: Martin KaFai Lau Acked-by: Song Liu

Re: [Patch bpf-next v7 09/13] udp: implement ->read_sock() for sockmap

2021-03-29 Thread Cong Wang
On Mon, Mar 29, 2021 at 11:23 PM John Fastabend wrote: > > Cong Wang wrote: > > On Mon, Mar 29, 2021 at 1:54 PM John Fastabend > > wrote: > > > > > > Cong Wang wrote: > > > > From: Cong Wang > > > > > > > > This is similar to tcp_read_sock(), except we do not need > > > > to worry about connect

Re: ESP RSS support for NVIDIA Mellanox ConnectX-6 Ethernet Adapter Cards

2021-03-29 Thread 高钧浩
Saeed Mahameed 于2021年3月30日周二 上午4:56写道: > > On Mon, 2021-03-29 at 12:33 +0800, 高钧浩 wrote: > > Hi borisp, saeedm > > > > I have seen mlx5 driver in 5.12.0-rc4 kernel, then find that > > mlx5e_set_rss_hash_opt only support tcp4/udp4/tcp6/udp6. So mlx5 > > kernel driver doesn't support esp4 rss?

RE: [PATCH v2] Bluetooth: hci_h5: btrtl: Add quirk for keep power in suspend/resume

2021-03-29 Thread Hilda Wu
Hi Maintainers, About this commit, do you have any further comments/suggestions on this? If you have any questions or concerns, please kindly let me know. Thank you. Regards, Hilda -Original Message- From: Hilda Wu Sent: Tuesday, March 16, 2021 6:07 PM To: mar...@holtmann.org Cc: johan

Re: [Patch bpf-next v7 09/13] udp: implement ->read_sock() for sockmap

2021-03-29 Thread John Fastabend
Cong Wang wrote: > On Mon, Mar 29, 2021 at 1:54 PM John Fastabend > wrote: > > > > Cong Wang wrote: > > > From: Cong Wang > > > > > > This is similar to tcp_read_sock(), except we do not need > > > to worry about connections, we just need to retrieve skb > > > from UDP receive queue. > > > > > >

Re: [RFC PATCH bpf-next 4/4] selftests/bpf: Test that module can't be unloaded with attached trampoline

2021-03-29 Thread Song Liu
> On Mar 28, 2021, at 4:26 AM, Jiri Olsa wrote: > > Adding test to verify that once we attach module's trampoline, > the module can't be unloaded. > > Signed-off-by: Jiri Olsa Acked-by: Song Liu [...]

tc f_u32 bug detected

2021-03-29 Thread Stephen Hemminger
After seeing a user report of trying to use JSON with tc, started to fix some of it. Found a surprise. The display of U32 filters confuses IPv6 and IPv4. The code in tc/f_u32.c is obviously wront in print_ipv6(). It is just a copy/past of IPv4. Almost want to just remove the bad code and let i

Re: [Patch bpf-next v7 12/13] sock_map: update sock type checks for UDP

2021-03-29 Thread Cong Wang
On Mon, Mar 29, 2021 at 4:10 PM John Fastabend wrote: > I think its a bit odd for TCP_ESTABLISHED to work with !tcp, but > thats not your invention so LGTM. It has been there for many years, so why it is suddenly a problem with my patchset? More importantly, why don't you change it by yourself as

[PATCH bpf-next 2/2] bpf: selftests: Update clang requirement in README.rst for testing kfunc call

2021-03-29 Thread Martin KaFai Lau
This patch updates the README.rst to specify the clang requirement to compile the bpf selftests that call kernel function. Signed-off-by: Martin KaFai Lau --- tools/testing/selftests/bpf/README.rst | 14 ++ 1 file changed, 14 insertions(+) diff --git a/tools/testing/selftests/bpf/RE

[PATCH bpf-next 1/2] bpf: Update bpf_design_QA.rst to clarify the kfunc call is not ABI

2021-03-29 Thread Martin KaFai Lau
This patch updates bpf_design_QA.rst to clarify that the kernel function callable by bpf program is not an ABI. Signed-off-by: Martin KaFai Lau --- Documentation/bpf/bpf_design_QA.rst | 15 +++ 1 file changed, 15 insertions(+) diff --git a/Documentation/bpf/bpf_design_QA.rst b/Docu

[PATCH bpf-next 0/2] bpf: Update doc about calling kernel function

2021-03-29 Thread Martin KaFai Lau
This set updates the document about the bpf program calling kernel function. In particular, updates are regarding to the clang requirement in selftests and kfunc-call not an ABI. Martin KaFai Lau (2): bpf: Update bpf_design_QA.rst to clarify the kfunc call is not ABI bpf: selftests: Update cl

Re: [Patch bpf-next v7 09/13] udp: implement ->read_sock() for sockmap

2021-03-29 Thread Cong Wang
On Mon, Mar 29, 2021 at 1:54 PM John Fastabend wrote: > > Cong Wang wrote: > > From: Cong Wang > > > > This is similar to tcp_read_sock(), except we do not need > > to worry about connections, we just need to retrieve skb > > from UDP receive queue. > > > > Note, the return value of ->read_sock()

Re: [PATCH ipsec v2] xfrm: Provide private skb extensions for segmented and hw offloaded ESP packets

2021-03-29 Thread Steffen Klassert
On Fri, Mar 26, 2021 at 09:44:48AM +0100, Steffen Klassert wrote: > Commit 94579ac3f6d0 ("xfrm: Fix double ESP trailer insertion in IPsec > crypto offload.") added a XFRM_XMIT flag to avoid duplicate ESP trailer > insertion on HW offload. This flag is set on the secpath that is shared > amongst seg

[net-next 10/12] net/mlx5e: Add PTP Flow Steering support

2021-03-29 Thread Saeed Mahameed
From: Aya Levin When opening PTP channel with MLX5E_PTP_STATE_RX set, add the corresponding flow steering rules. Capture UDP packets with destination port 319 and L2 packets with ethertype 0x88F7 and steer them into the RQ of the PTP channel. Add API that manages the flow steering rules to be use

[net-next 07/12] net/mlx5e: Cleanup Flow Steering level

2021-03-29 Thread Saeed Mahameed
From: Aya Levin Flow Steering levels are used to determine the order between the tables. As of today, each one of these tables follows the TTC table, and hijacks its traffic, and cannot be combined together for now. Putting them in the same layer better reflects the situation. Signed-off-by: Aya

[net-next 11/12] net/mlx5e: Allow coexistence of CQE compression and HW TS PTP

2021-03-29 Thread Saeed Mahameed
From: Aya Levin Update setting HW time-stamp to allow coexistence with CQE compression. Turn on RX PTP indication and try to reopen the channels. On success, coexistence with CQE compression is enabled. Otherwise, fall-back to turning off CQE compression. Signed-off-by: Aya Levin Reviewed-by: T

[net-next 12/12] net/mlx5e: Update ethtool setting of CQE compression

2021-03-29 Thread Saeed Mahameed
From: Aya Levin Remove restriction blocking configuration of CQE compression when PTP rx filter is set. Instead turn on indication for RX PTP, and try to reopen the channels. Signed-off-by: Aya Levin Reviewed-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/ml

[net-next 08/12] net/mlx5e: Introduce Flow Steering UDP API

2021-03-29 Thread Saeed Mahameed
From: Aya Levin Add a new FS API which captures the UDP traffic from the traffic classifier into a dedicated FS table. This API handles both UDP over IPv4 and IPv6 in the same manner. The tables (one for UDPv4 and another for UDPv6) consist of a group matching the UDP destination port and a must-

[net-next 09/12] net/mlx5e: Introduce Flow Steering ANY API

2021-03-29 Thread Saeed Mahameed
From: Aya Levin Add a new FS API which captures the ANY traffic from the traffic classifier into a dedicated FS table. The table consists of a group matching the ethertype and a must-be-last group which contains a default rule redirecting the unmatched packets back to the RSS logic. Signed-off-b

[net-next 03/12] net/mlx5e: Add PTP-RX statistics

2021-03-29 Thread Saeed Mahameed
From: Aya Levin Like PTP-TX, once the PTP-RX is opened, corresponding statistics appear. Add indication that PTP-RX was ever opened: rx_ptp_opened. If any of the PTP RX or TX were opened, display the PTP channel's statistics. Signed-off-by: Aya Levin Signed-off-by: Tariq Toukan Signed-off-by:

[net-next 06/12] net/mlx5e: Add PTP RQ to RX reporter

2021-03-29 Thread Saeed Mahameed
From: Aya Levin When present, add the PTP RQ to the RX reporter. Signed-off-by: Aya Levin Reviewed-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/en/reporter_rx.c | 68 ++- 1 file changed, 66 insertions(+), 2 deletions(-) diff --git a/drivers

[net-next 02/12] net/mlx5e: Add RQ to PTP channel

2021-03-29 Thread Saeed Mahameed
From: Aya Levin Enhance PTP channel to allow PTP without disabling CQE compression. Add RQ, TIR and PTP_RX_STATE to PTP channel. When this bit is set, PTP channel manages its RQ, and PTP traffic is directed to the PTP-RQ which is not affected by compression. Signed-off-by: Aya Levin Signed-off-

[net-next 05/12] net/mlx5e: Refactor RX reporter diagnostics

2021-03-29 Thread Saeed Mahameed
From: Aya Levin Break RX diagnostics function into smaller helpers. This enables easier enhancement in the next patch in the set. Signed-off-by: Aya Levin Reviewed-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/en/reporter_rx.c | 104 +++--- 1 fil

[net-next 04/12] net:mlx5e: Add PTP-TIR and PTP-RQT

2021-03-29 Thread Saeed Mahameed
From: Aya Levin Add PTP-TIR and initiate its RQT to allow PTP-RQ to integrate into the safe-reopen flow on configuration change. Add rx_ptp_support flag on a profile and turn it on for ETH driver. With this flag set, create a redirect-RQT for PTP-RQ. Signed-off-by: Aya Levin Reviewed-by: Tariq

[pull request][net-next 00/12] mlx5 updates 2021-03-29

2021-03-29 Thread Saeed Mahameed
From: Saeed Mahameed Hi Dave, Jakub, This series removes the mlx5 netdev restriction of enabling both PTP time-stamping and CQE-Compression features. For more information please see tag log below. Please pull and let me know if there is any problem. Thanks, Saeed. --- The following changes s

[net-next 01/12] net/mlx5e: Add states to PTP channel

2021-03-29 Thread Saeed Mahameed
From: Aya Levin Add PTP TX state to PTP channel, which indicates the corresponding SQ is available. Further patches in the set extend PTP channel to include RQ. The PTP channel state will be used for separation and coexistence of RX and TX PTP. Enhance conditions to verify the TX PTP state is set

[RFC ethtool-next 1/3] update UAPI header copies

2021-03-29 Thread Jakub Kicinski
Update to kernel commit 6917719f1b85. Signed-off-by: Jakub Kicinski --- uapi/linux/ethtool.h | 47 +++- uapi/linux/ethtool_netlink.h | 18 ++ uapi/linux/if_link.h | 9 +-- uapi/linux/netlink.h | 2 +- uapi/linux/rtnetlink.

[RFC ethtool-next 3/3] netlink: add FEC support

2021-03-29 Thread Jakub Kicinski
Add support for FEC get/set over netlink. Output should be identical but for ordering of RS vs BaseR. Since the new output is based on link modes RS comes before BaseR in "Configured FEC encodings". Seems pretty unlikely someone depends on the ordering there. Since old API was case insensitive we

[RFC ethtool-next 2/3] json: simplify array print API

2021-03-29 Thread Jakub Kicinski
In ethtool when we print an array we usually have a label (non-JSON) and a key (JSON), because arrays are most often printed on a single line (unlike iproute2 where the output has multiple params on a line to cater to multi-interface dumps well). Build this into the json array API. Signed-off-by:

[PATCH net-next 1/3] ethtool: support FEC settings over netlink

2021-03-29 Thread Jakub Kicinski
Add FEC API to netlink. This is not a 1-to-1 conversion. FEC settings already depend on link modes to tell user which modes are supported. Take this further an use link modes for manual configuration. Old struct ethtool_fecparam is still used to talk to the drivers, so we need to translate back a

[PATCH net-next 2/3] netdevsim: add FEC settings support

2021-03-29 Thread Jakub Kicinski
Add support for ethtool FEC and some ethtool error injection. Signed-off-by: Jakub Kicinski --- drivers/net/netdevsim/ethtool.c | 36 +++ drivers/net/netdevsim/netdevsim.h | 3 +++ 2 files changed, 39 insertions(+) diff --git a/drivers/net/netdevsim/ethtool.c b/dr

[PATCH net-next 3/3] selftests: ethtool: add a netdevsim FEC test

2021-03-29 Thread Jakub Kicinski
Test FEC settings, iterate over configs. Signed-off-by: Jakub Kicinski --- .../drivers/net/netdevsim/ethtool-common.sh | 5 +- .../drivers/net/netdevsim/ethtool-fec.sh | 110 ++ 2 files changed, 114 insertions(+), 1 deletion(-) create mode 100755 tools/testing/selftests

[PATCH net-next 0/3] ethtool: support FEC configuration over netlink

2021-03-29 Thread Jakub Kicinski
This series adds support for the equivalents of ETHTOOL_GFECPARAM and ETHTOOL_SFECPARAM over netlink. As a reminder - this is an API which allows user to query current FEC mode, as well as set FEC manually if autoneg is disabled. It does not configure anything if autoneg is enabled (that said few/

Re: [PATCH net-next v3 5/7] mld: convert ifmcaddr6 to RCU

2021-03-29 Thread Taehee Yoo
On 2021. 3. 30. 오전 4:56, Eric Dumazet wrote: > > Hi Eric, Thank you for the review! > On 3/25/21 5:16 PM, Taehee Yoo wrote: >> The ifmcaddr6 has been protected by inet6_dev->lock(rwlock) so that >> the critical section is atomic context. In order to switch this context, >> changing locking is ne

Re: [PATCH] Add Open/R to rt_protos

2021-03-29 Thread Cooper Lees
Thanks David! Cooper > On Mar 29, 2021, at 8:07 PM, David Ahern wrote: > > On 3/26/21 9:05 AM, Cooper Ry Lees wrote: >> From: Cooper Lees >> >> - Open Routing is using ID 99 for it's installed routes >> - https://github.com/facebook/openr >> - Kernel has accepted 99 in `rtnetlink.h` >> >> Si

Re: [PATCH bpf-next 5/5] libbpf: add selftests for TC-BPF API

2021-03-29 Thread Alexei Starovoitov
On Sun, Mar 28, 2021 at 07:38:42PM -0700, Andrii Nakryiko wrote: > > See above. I don't know which hassle is libbpf for users today. You > were implying code size used for functionality users might not use > (e.g., linker). Libbpf is a very small library, <300KB. There are > users building tools f

[RFC] (re)moving drivers/net/appletalk/cops_*.h firmware blobs

2021-03-29 Thread Doug Brown
Hi there, I've been recently looking at the (ancient) AppleTalk/LocalTalk drivers because I've been working on a modern LocalTalk network adapter for crazy vintage computer enthusiasts like myself. ;-) In the process, I discovered the existence of cops_ffdrv.h and cops_ltdrv.h in the kernel s

Re: [PATCH iproute2-next] police: add support for packet-per-second rate limiting

2021-03-29 Thread David Ahern
On 3/26/21 6:50 AM, Simon Horman wrote: > From: Baowen Zheng > > Allow a policer action to enforce a rate-limit based on packets-per-second, > configurable using a packet-per-second rate and burst parameters. > > e.g. > # $TC actions add action police pkts_rate 1000 pkts_burst 200 index 1 > #

Re: [PATCH] Add Open/R to rt_protos

2021-03-29 Thread David Ahern
On 3/26/21 9:05 AM, Cooper Ry Lees wrote: > From: Cooper Lees > > - Open Routing is using ID 99 for it's installed routes > - https://github.com/facebook/openr > - Kernel has accepted 99 in `rtnetlink.h` > > Signed-of-by: Cooper Lees > --- > etc/iproute2/rt_protos | 1 + > 1 file changed, 1 in

Re: IP_FRAG_TIME Default Too Large

2021-03-29 Thread Matt Corallo
On 3/29/21 20:04, Matt Corallo wrote: This issue largely goes away when setting net.ipv4.ipfrag_time to 0/1. Quick correction - the issue is reduced when set to 1 (as you might expect, you don't see as much loss if you wipe the fragment buffer every second) but if you set it to zero hosts ran

[PATCH net-next v2 6/6] net: stmmac: Add support for XDP_REDIRECT action

2021-03-29 Thread Ong Boon Leong
This patch adds the support of XDP_REDIRECT to another remote cpu for further action. It also implements ndo_xdp_xmit ops, enabling the driver to transmit packets forwarded to it by XDP program running on another interface. This patch has been tested using "xdp_redirect_cpu" for XDP_REDIRECT + dro

[PATCH net-next v2 5/6] net: stmmac: Add support for XDP_TX action

2021-03-29 Thread Ong Boon Leong
This patch adds support for XDP_TX action which enables XDP program to transmit back received frames. This patch has been tested with the "xdp2" app located in samples/bpf dir. The DUT receives burst traffic packet generated using pktgen script 'pktgen_sample03_burst_single_flow.sh'. Signed-off-b

[PATCH net-next v2 4/6] net: stmmac: Add initial XDP support

2021-03-29 Thread Ong Boon Leong
This patch adds the initial XDP support to stmmac driver. It supports XDP_PASS, XDP_DROP and XDP_ABORTED actions. Upcoming patches will add support for XDP_TX and XDP_REDIRECT. To support XDP headroom, this patch adds page_offset into RX buffer and change the dma_sync_single_for_device|cpu(). The

[PATCH net-next v2 2/6] net: stmmac: make SPH enable/disable to be configurable

2021-03-29 Thread Ong Boon Leong
SPH functionality splits header and payload according to split mode and offsef fields (SPLM and SPLOFST). It is beneficials for Linux network stack RX processing however it adds a lot of complexity in XDP processing. So, this patch makes the split-header (SPH) capability of the controller is store

[PATCH net-next v2 1/6] net: stmmac: set IRQ affinity hint for multi MSI vectors

2021-03-29 Thread Ong Boon Leong
Certain platform likes Intel mGBE has independent hardware IRQ resources for TX and RX DMA operation. In preparation to support XDP TX, we add IRQ affinity hint to group both RX and TX queue of the same queue ID to the same CPU. Changes in v2: - IRQ affinity hint need to set to null before IRQ is

[PATCH net-next 1/1] stmmac: intel: add cross time-stamping freq difference adjustment

2021-03-29 Thread Wong Vee Khee
Cross time-stamping mechanism used in certain instance of Intel mGbE may run at different clock frequency in comparison to the clock frequency used by processor, so we introduce cross T/S frequency adjustment to ensure TSC calculation is correct when processor got the cross time-stamps. Signed-off

[PATCH -next v2 1/2] mISDN: Use DEFINE_SPINLOCK() for spinlock

2021-03-29 Thread Shixin Liu
spinlock can be initialized automatically with DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). Changelog: >From v1: 1. fix the mistake reported by kernel test robot. Signed-off-by: Shixin Liu --- drivers/isdn/hardware/mISDN/hfcmulti.c | 7 ++- drivers/isdn/mISDN/dsp_core.

[PATCH -next v2 2/2] mISDN: Use LIST_HEAD() for list_head

2021-03-29 Thread Shixin Liu
There's no need to declare a list and then init it manually, just use the LIST_HEAD() macro. Signed-off-by: Shixin Liu --- drivers/isdn/mISDN/dsp_core.c | 7 ++- drivers/isdn/mISDN/l1oip_core.c | 4 +--- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/isdn/mISDN/dsp_

[PATCHv4 4/4] net: cdc_ether: record speed in status method

2021-03-29 Thread Grant Grundler
From: Grant Grundler Until very recently, the usbnet framework only had support functions for devices which reported the link speed by explicitly querying the PHY over a MDIO interface. However, the cdc_ether devices send notifications when the link state or link speeds change and do not expose t

[PATCHv4 2/4] usbnet: add method for reporting speed without MII

2021-03-29 Thread Grant Grundler
From: Oliver Neukum The old method for reporting link speed assumed a driver uses the generic phy (mii) MDIO read/write functions. CDC devices don't expose the phy. Add a primitive internal version reporting back directly what the CDC notification/status operations recorded. v2: rebased on upst

[PATCHv4 3/4] net: cdc_ncm: record speed in status method

2021-03-29 Thread Grant Grundler
From: Oliver Neukum Until very recently, the usbnet framework only had support functions for devices which reported the link speed by explicitly querying the PHY over a MDIO interface. However, the cdc_ncm devices send notifications when the link state or link speeds change and do not expose the

[PATCHv4 1/4] usbnet: add _mii suffix to usbnet_set/get_link_ksettings

2021-03-29 Thread Grant Grundler
From: Oliver Neukum The generic functions assumed devices provided an MDIO interface (accessed via older mii code, not phylib). This is true only for genuine ethernet. Devices with a higher level of abstraction or based on different technologies do not have MDIO. To support this case, first rena

[PATCHv4 0/4] usbnet: speed reporting for devices without MDIO

2021-03-29 Thread Grant Grundler
This series introduces support for USB network devices that report speed as a part of their protocol, not emulating an MII to be accessed over MDIO. v2: rebased on recent upstream changes v3: incorporated hints on naming and comments v4: fix misplaced hunks; reword some commit messages; add sa

[Patch bpf-next] net: filter: Remove unused bpf_load_pointer

2021-03-29 Thread He Fengqing
Remove unused bpf_load_pointer function in filter.h Signed-off-by: He Fengqing --- include/linux/filter.h | 9 - 1 file changed, 9 deletions(-) diff --git a/include/linux/filter.h b/include/linux/filter.h index eecfd82db648..9a09547bc7ba 100644 --- a/include/linux/filter.h +++ b/include

Re: [PATCH bpf-next] bpf: tcp: Limit calling some tcp cc functions to CONFIG_DYNAMIC_FTRACE

2021-03-29 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Mon, 29 Mar 2021 15:13:57 -0700 you wrote: > pahole currently only generates the btf_id for external function and > ftrace-able function. Some functions in the bpf_tcp_ca_kfunc_ids > are static (e.g. cubictcp_init). Thus,

[PATCH net-next V6 6/6] icmp: add response to RFC 8335 PROBE messages

2021-03-29 Thread Andreas Roeseler
Modify the icmp_rcv function to check PROBE messages and call icmp_echo if a PROBE request is detected. Modify the existing icmp_echo function to respond ot both ping and PROBE requests. This was tested using a custom modification to the iputils package and wireshark. It supports IPV4 probing by

[PATCH net-next V6 4/6] net: add support for sending RFC 8335 PROBE messages

2021-03-29 Thread Andreas Roeseler
Modify the ping_supported function to support PROBE message types. This allows tools such as the ping command in the iputils package to be modified to send PROBE requests through the existing framework for sending ping requests. Signed-off-by: Andreas Roeseler --- net/ipv4/ping.c | 4 +++- 1 fil

[PATCH net-next V6 5/6] ipv6: add ipv6_dev_find to stubs

2021-03-29 Thread Andreas Roeseler
Add ipv6_dev_find to ipv6_stub to allow lookup of net_devices by IPV6 address in net/ipv4/icmp.c. Signed-off-by: Andreas Roeseler --- include/net/ipv6_stubs.h | 2 ++ net/ipv6/addrconf_core.c | 7 +++ net/ipv6/af_inet6.c | 1 + 3 files changed, 10 insertions(+) diff --git a/include/net

[PATCH net-next V6 2/6] ICMPV6: add support for RFC 8335 PROBE

2021-03-29 Thread Andreas Roeseler
Add definitions for the ICMPV6 type of Extended Echo Request and Extended Echo Reply, as defined by sections 2 and 3 of RFC 8335. Signed-off-by: Andreas Roeseler --- include/uapi/linux/icmpv6.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/uapi/linux/icmpv6.h b/include/uapi/linu

[PATCH net-next V6 3/6] net: add sysctl for enabling RFC 8335 PROBE messages

2021-03-29 Thread Andreas Roeseler
Section 8 of RFC 8335 specifies potential security concerns of responding to PROBE requests, and states that nodes that support PROBE functionality MUST be able to enable/disable responses and that responses MUST be disabled by default Signed-off-by: Andreas Roeseler --- Changes: v1 -> v2: - Com

[PATCH net-next V6 1/6] icmp: add support for RFC 8335 PROBE

2021-03-29 Thread Andreas Roeseler
Add definitions for PROBE ICMP types and codes. Add AFI definitions for IP and IPV6 as specified by IANA Add a struct to represent the additional header when probing by IP address (ctype == 3) for use in parsing incoming PROBE messages Add a struct to represent the entire Interface Identificatio

[PATCH net-next V6 0/6] add support for RFC 8335 PROBE

2021-03-29 Thread Andreas Roeseler
The popular utility ping has several severe limitations, such as the inability to query specific interfaces on a node and requiring bidirectional connectivity between the probing and probed interfaces. RFC 8335 attempts to solve these limitations by creating the new utility PROBE which is a special

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-29 Thread Bjorn Helgaas
On Fri, Mar 26, 2021 at 04:01:48PM -0300, Jason Gunthorpe wrote: > On Fri, Mar 26, 2021 at 11:50:44AM -0700, Alexander Duyck wrote: > > > My concern would be that we are defining the user space interface. > > Once we have this working as a single operation I could see us having > > to support it t

Re: [Patch bpf-next v7 07/13] sock_map: introduce BPF_SK_SKB_VERDICT

2021-03-29 Thread Cong Wang
On Mon, Mar 29, 2021 at 1:10 PM John Fastabend wrote: > > Cong Wang wrote: > > From: Cong Wang > > > > Reusing BPF_SK_SKB_STREAM_VERDICT is possible but its name is > > confusing and more importantly we still want to distinguish them > > from user-space. So we can just reuse the stream verdict co

Re: [RFC PATCH bpf-next 2/4] selftests/bpf: Add re-attach test to fentry_test

2021-03-29 Thread Song Liu
> On Mar 28, 2021, at 4:26 AM, Jiri Olsa wrote: > > Adding the test to re-attach (detach/attach again) tracing > fentry programs, plus check that already linked program can't > be attached again. > > Fixing the number of check-ed results, which should be 8. > > Signed-off-by: Jiri Olsa > [

Re: ip help text should fit on 80 columns

2021-03-29 Thread Vincent Lefevre
On 2021-03-29 15:13:38 -0700, Stephen Hemminger wrote: > On Mon, 29 Mar 2021 19:24:05 +0200 > Vincent Lefevre wrote: > > > Help text such as output by "ip help" or "ip link help" should fit > > on 80 columns. It currently seems to take up to 86 columns. > > > > Tested version: > > > > zira:~> i

Re: [RFC PATCH bpf-next 1/4] bpf: Allow trampoline re-attach

2021-03-29 Thread Song Liu
> On Mar 28, 2021, at 4:26 AM, Jiri Olsa wrote: > > Currently we don't allow re-attaching of trampolines. Once > it's detached, it can't be re-attach even when the program > is still loaded. > > Adding the possibility to re-attach the loaded tracing > kernel program. > > Signed-off-by: Jiri

linux-next: Fixes tag needs some work in the net-next tree

2021-03-29 Thread Stephen Rothwell
Hi all, In commit d24f511b04b8 ("tcp: fix tcp_min_tso_segs sysctl") Fixes tag Fixes: 47996b489bdc ("tcp: convert elligible sysctls to u8") has these problem(s): - Target SHA1 does not exist Maybe you meant Fixes: 4ecc1baf362c ("tcp: convert elligible sysctls to u8") -- Cheers, Steph

[no subject]

2021-03-29 Thread Rowell Hambrick
Did you get my last mail

Re: [PATCH] ethernet/netronome/nfp: Fix a use after free in nfp_bpf_ctrl_msg_rx

2021-03-29 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 29 Mar 2021 04:50:02 -0700 you wrote: > In nfp_bpf_ctrl_msg_rx, if > nfp_ccm_get_type(skb) == NFP_CCM_TYPE_BPF_BPF_EVENT is true, the skb > will be freed. But the skb is still used by nfp_ccm_rx(&bpf->ccm, skb). > > My

Re: [PATCH net-next] hv_netvsc: Add error handling while switching data path

2021-03-29 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 29 Mar 2021 16:21:35 -0700 you wrote: > Add error handling in case of failure to send switching data path message > to the host. > > Reported-by: Shachar Raindel > Signed-off-by: Haiyang Zhang > > > [...] Here

IP_FRAG_TIME Default Too Large

2021-03-29 Thread Matt Corallo
IP_FRAG_TIME defaults to 30 full long seconds to wait for reassembly of fragments. In practice, with the default values, if I send enough fragments over a line that there is material loss, its not strange to see fragments be completely dropped for the remainder of a 30 second time period before r

Re: [PATCH] ethernet/netronome/nfp: Fix a use after free in nfp_bpf_ctrl_msg_rx

2021-03-29 Thread Jakub Kicinski
On Mon, 29 Mar 2021 04:50:02 -0700 Lv Yunlong wrote: > In nfp_bpf_ctrl_msg_rx, if > nfp_ccm_get_type(skb) == NFP_CCM_TYPE_BPF_BPF_EVENT is true, the skb > will be freed. But the skb is still used by nfp_ccm_rx(&bpf->ccm, skb). > > My patch adds a return when the skb was freed. > > Fixes: bcf0cafa

Re: [PATCH net-next 0/8][pull request] 1GbE Intel Wired LAN Driver Updates 2021-03-29

2021-03-29 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Mon, 29 Mar 2021 10:09:23 -0700 you wrote: > This series contains updates to igc driver only. > > Andre Guedes says: > > Add XDP support for the igc driver. The approach implemented by this > series follows the same a

Re: [PATCH net-next] sit: proper dev_{hold|put} in ndo_[un]init methods

2021-03-29 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 29 Mar 2021 12:25:22 -0700 you wrote: > From: Eric Dumazet > > After adopting CONFIG_PCPU_DEV_REFCNT=n option, syzbot was able to trigger > a warning [1] > > Issue here is that: > > [...] Here is the summary wi

Re: tipc: fix htmldoc and smatch warnings

2021-03-29 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 29 Mar 2021 13:17:31 -0400 you wrote: > From: Jon Maloy > > We fix a warning from the htmldoc tool and an indentation error reported > by smatch. There are no functional changes in this commit. > > Signed-off-by:

Re: [PATCH net-next] ip6_gre: proper dev_{hold|put} in ndo_[un]init methods

2021-03-29 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 29 Mar 2021 11:39:51 -0700 you wrote: > From: Eric Dumazet > > After adopting CONFIG_PCPU_DEV_REFCNT=n option, syzbot was able to trigger > a warning [1] > > Issue here is that: > > [...] Here is the summary wi

Re: [PATCH net-next] ip6_vti: proper dev_{hold|put} in ndo_[un]init methods

2021-03-29 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 29 Mar 2021 12:12:54 -0700 you wrote: > From: Eric Dumazet > > After adopting CONFIG_PCPU_DEV_REFCNT=n option, syzbot was able to trigger > a warning [1] > > Issue here is that: > > [...] Here is the summary wi

Re: [PATCH net-next v3 1/2] net: mhi: Add support for non-linear MBIM skb processing

2021-03-29 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Mon, 29 Mar 2021 17:39:31 +0200 you wrote: > Currently, if skb is non-linear, due to MHI skb chaining, it is > linearized in MBIM RX handler prior MBIM decoding, causing extra > allocation and copy that can be as large

Re: [PATCH net 0/9][pull request] Intel Wired LAN Driver Updates 2021-03-29

2021-03-29 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Mon, 29 Mar 2021 13:18:48 -0700 you wrote: > This series contains updates to ice driver only. > > Ani does not fail on link/PHY errors during probe as this is not a fatal > error to prevent the user from remedying the probl

Re: [PATCH net] dt-bindings: net: bcm4908-enet: fix Ethernet generic properties

2021-03-29 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 29 Mar 2021 17:33:28 +0200 you wrote: > From: Rafał Miłecki > > This binding file uses $ref: ethernet-controller.yaml# so it's required > to use "unevaluatedProperties" (instead of "additionalProperties") to > make Eth

Re: [PATCH] ieee802154: hwsim: remove redundant initialization of variable res

2021-03-29 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 29 Mar 2021 12:23:54 +0100 you wrote: > From: Colin Ian King > > The variable res is being initialized with a value that is > never read and it is being updated later with a new value. > The initialization is redu

Re: [PATCH] net:tipc: Fix a double free in tipc_sk_mcast_rcv

2021-03-29 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Sun, 28 Mar 2021 00:30:29 -0700 you wrote: > In the if(skb_peek(arrvq) == skb) branch, it calls __skb_dequeue(arrvq) to get > the skb by skb = skb_peek(arrvq). Then __skb_dequeue() unlinks the skb from > arrvq > and returns

Re: [PATCH net] dt-bindings: net: ethernet-controller: fix typo in NVMEM

2021-03-29 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 29 Mar 2021 16:03:17 +0200 you wrote: > From: Rafał Miłecki > > The correct property name is "nvmem-cell-names". This is what: > 1. Was originally documented in the ethernet.txt > 2. Is used in DTS files > 3. Matches s

[PATCH] xfrm/compat: Cleanup WARN()s that can be user-triggered

2021-03-29 Thread Dmitry Safonov
Replace WARN_ONCE() that can be triggered from userspace with pr_warn_once(). Those still give user a hint what's the issue. I've left WARN()s that are not possible to trigger with current code-base and that would mean that the code has issues: - relying on current compat_msg_min[type] <= xfrm_msg

[PATCH net-next] hv_netvsc: Add error handling while switching data path

2021-03-29 Thread Haiyang Zhang
Add error handling in case of failure to send switching data path message to the host. Reported-by: Shachar Raindel Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h | 6 +- drivers/net/hyperv/netvsc.c | 35 + drivers/net/hyperv/netvsc_dr

Re: [PATCH net] cxgb4: avoid collecting SGE_QBASE regs during traffic

2021-03-29 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Sat, 27 Mar 2021 23:49:08 +0530 you wrote: > Accessing SGE_QBASE_MAP[0-3] and SGE_QBASE_INDEX registers can lead > to SGE missing doorbells under heavy traffic. So, only collect them > when adapter is idle. Also update the re

RE: [Patch bpf-next v7 12/13] sock_map: update sock type checks for UDP

2021-03-29 Thread John Fastabend
Cong Wang wrote: > From: Cong Wang > > Now UDP supports sockmap and redirection, we can safely update > the sock type checks for it accordingly. > > Cc: John Fastabend > Cc: Daniel Borkmann > Cc: Jakub Sitnicki > Cc: Lorenz Bauer > Signed-off-by: Cong Wang > --- > net/core/sock_map.c | 5 +

Re: [PATCH v3 bpf-next] tools/resolve_btfids: Fix warnings

2021-03-29 Thread Song Liu
On Mon, Mar 29, 2021 at 3:35 PM Stanislav Fomichev wrote: > > * make eprintf static, used only in main.c > * initialize ret in eprintf > * remove unused *tmp > > v3: > * remove another err (Song Liu) > > v2: > * remove unused 'int err = -1' > > Cc: Song Liu > Signed-off-by: Stanislav Fomichev A

[PATCH v5 bpf-next 17/17] selftests: xsk: Remove unused defines

2021-03-29 Thread Maciej Fijalkowski
From: Björn Töpel Remove two unused defines. Signed-off-by: Björn Töpel --- tools/testing/selftests/bpf/xdpxceiver.c | 7 +++ tools/testing/selftests/bpf/xdpxceiver.h | 2 -- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/tools/testing/selftests/bpf/xdpxceiver.c b/tools/te

[PATCH v5 bpf-next 16/17] selftests: xsk: Remove mutex and condition variable

2021-03-29 Thread Maciej Fijalkowski
From: Björn Töpel The usage of the condition variable is broken, and overkill. Replace it with a pthread barrier. Signed-off-by: Björn Töpel --- tools/testing/selftests/bpf/xdpxceiver.c | 33 tools/testing/selftests/bpf/xdpxceiver.h | 3 +-- 2 files changed, 6 inserti

[PATCH v5 bpf-next 15/17] selftests: xsk: remove thread attribute

2021-03-29 Thread Maciej Fijalkowski
From: Björn Töpel There is really no reason to have a non-default thread stack size. Remove that. Signed-off-by: Björn Töpel --- tools/testing/selftests/bpf/xdpxceiver.c | 9 ++--- tools/testing/selftests/bpf/xdpxceiver.h | 2 -- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git

[PATCH v5 bpf-next 14/17] selftests: xsk: implement bpf_link test

2021-03-29 Thread Maciej Fijalkowski
Introduce a test that is supposed to verify the persistence of BPF resources based on underlying bpf_link usage. Test will: 1) create and bind two sockets on queue ids 0 and 1 2) run a traffic on queue ids 0 3) remove xsk sockets from queue 0 on both veth interfaces 4) run a traffic on queues ids

[PATCH v5 bpf-next 13/17] veth: implement ethtool's get_channels() callback

2021-03-29 Thread Maciej Fijalkowski
Libbpf's xsk part calls get_channels() API to retrieve the queue count of the underlying driver so that XSKMAP is sized accordingly. Implement that in veth so multi queue scenarios can work properly. Cc: Toshiaki Makita Signed-off-by: Maciej Fijalkowski --- drivers/net/veth.c | 12

[PATCH v5 bpf-next 10/17] selftests: xsk: remove Tx synchronization resources

2021-03-29 Thread Maciej Fijalkowski
Tx thread needs to be started after the Rx side is fully initialized so that packets are not xmitted until xsk Rx socket is ready to be used. It can be observed that atomic variable spinning_tx is not checked from Rx side in any way, so thread_common_ops can be modified to only address the spinnin

[PATCH v5 bpf-next 11/17] selftests: xsk: refactor teardown/bidi test cases and testapp_validate

2021-03-29 Thread Maciej Fijalkowski
Currently, there is a testapp_sockets() that acts like a wrapper around testapp_validate() and it is called for bidi and teardown test types. Other test types call testapp_validate() directly. Split testapp_sockets() onto two separate functions so a bunch of bidi specific logic can be moved there

[PATCH v5 bpf-next 09/17] selftests: xsk: split worker thread

2021-03-29 Thread Maciej Fijalkowski
Let's a have a separate Tx/Rx worker threads instead of a one common thread packed with Tx/Rx specific checks. Move mmap for umem buffer space and a switch_namespace() call to thread_common_ops. This also allows for a bunch of simplifactions that are the subject of the next commits. The final res

  1   2   3   4   5   >