Re: [PATCH net-next] qrtr: move to staging

2021-03-28 Thread Greg Kroah-Hartman
On Mon, Mar 29, 2021 at 09:30:25AM +0300, Leon Romanovsky wrote: > On Mon, Mar 29, 2021 at 07:30:08AM +0200, Greg Kroah-Hartman wrote: > > On Mon, Mar 29, 2021 at 08:17:06AM +0300, Leon Romanovsky wrote: > > > On Sun, Mar 28, 2021 at 02:26:21PM +0200, Greg Kroah-Hartman wrote: > > > > There does no

Re: [PATCH net-next] qrtr: move to staging

2021-03-28 Thread Leon Romanovsky
On Mon, Mar 29, 2021 at 07:30:08AM +0200, Greg Kroah-Hartman wrote: > On Mon, Mar 29, 2021 at 08:17:06AM +0300, Leon Romanovsky wrote: > > On Sun, Mar 28, 2021 at 02:26:21PM +0200, Greg Kroah-Hartman wrote: > > > There does not seem to be any developers willing to maintain the > > > net/qrtr/ code,

Re: [PATCH bpf-next 3/3] selftests/bpf: allow compiling BPF objects without BTF

2021-03-28 Thread Andrii Nakryiko
On Sun, Mar 28, 2021 at 6:16 PM Alexei Starovoitov wrote: > > On Fri, Mar 26, 2021 at 9:44 AM Andrii Nakryiko > wrote: > > > Because they double the maintenance cost now and double the support > > > forever. > > > We never needed to worry about skeleton without BTF and now it would be > > > a th

Re: [PATCH][next] mlxsw: spectrum_router: remove redundant initialization of variable force

2021-03-28 Thread Dan Carpenter
On Sat, Mar 27, 2021 at 10:33:34PM +, Colin King wrote: > From: Colin Ian King > > The variable force is being initialized with a value that is > never read and it is being updated later with a new value. The > initialization is redundant and can be removed. > > Addresses-Coverity: ("Unused

Re: [PATCH] bpf: remove redundant assignment of variable id

2021-03-28 Thread Dan Carpenter
On Fri, Mar 26, 2021 at 01:18:36PM -0700, Song Liu wrote: > On Fri, Mar 26, 2021 at 12:45 PM Colin King wrote: > > > > From: Colin Ian King > > > > The variable id is being assigned a value that is never > > read, the assignment is redundant and can be removed. > > > > Addresses-Coverity: ("Unuse

Re: [PATCH net-next] qrtr: move to staging

2021-03-28 Thread Greg Kroah-Hartman
On Mon, Mar 29, 2021 at 08:17:06AM +0300, Leon Romanovsky wrote: > On Sun, Mar 28, 2021 at 02:26:21PM +0200, Greg Kroah-Hartman wrote: > > There does not seem to be any developers willing to maintain the > > net/qrtr/ code, so move it to drivers/staging/ so that it can be removed > > from the kerne

Re: [PATCH net-next] qrtr: move to staging

2021-03-28 Thread Leon Romanovsky
On Sun, Mar 28, 2021 at 02:26:21PM +0200, Greg Kroah-Hartman wrote: > There does not seem to be any developers willing to maintain the > net/qrtr/ code, so move it to drivers/staging/ so that it can be removed > from the kernel tree entirely in a few kernel releases if no one steps > up to maintain

Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-28 Thread Juergen Gross
On 28.03.21 22:46, Hsu, Chiahao wrote: Leon Romanovsky 於 2021/3/22 08:13 寫道: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On Mon, Mar 22, 2021 at 08:01:17AM +0100, Jü

ESP RSS support for NVIDIA Mellanox ConnectX-6 Ethernet Adapter Cards

2021-03-28 Thread 高钧浩
Hi borisp, saeedm I have seen mlx5 driver in 5.12.0-rc4 kernel, then find that mlx5e_set_rss_hash_opt only support tcp4/udp4/tcp6/udp6. So mlx5 kernel driver doesn't support esp4 rss? Then do you have any plan to support esp4 or other latest mlx5 driver have supported esp4? Then does NVIDIA M

[PATCH net-next 6/9] net: hns3: add handling for xmit skb with recursive fraglist

2021-03-28 Thread Huazhong Tan
From: Yunsheng Lin Currently hns3 driver only handle the xmit skb with one level of fraglist skb, add handling for multi level by calling hns3_tx_bd_num() recursively when calculating bd num and calling hns3_fill_skb_to_desc() recursively when filling tx desc. When the skb has a fraglist level o

[PATCH net-next 7/9] net: hns3: add tx send size handling for tso skb

2021-03-28 Thread Huazhong Tan
From: Yunsheng Lin The actual size on wire for tso skb should be (gso_segs - 1) * hdr + skb->len instead of skb->len, which can be seen by user using 'ethtool -S ethX' cmd, and 'Byte Queue Limit' also use the send size stat to do the queue limiting, so add send_bytes in the desc_cb to record the

[PATCH net-next 8/9] net: hns3: expand the tc config command

2021-03-28 Thread Huazhong Tan
From: Guojia Liao The device HNAE3_DEVICE_VERSION_V3 supports up to 1280 queues and qsets for one function, so the bitwidth of tc_offset, meaning the tqps index, needs to expand from 10 bits to 11 bits. The device HNAE3_DEVICE_VERSION_V3 supports up to 512 queues on one TC. The tc_size, meaning

[PATCH net-next 9/9] net: hns3: add stats logging when skb padding fails

2021-03-28 Thread Huazhong Tan
From: Yunsheng Lin skb_put_padto() may fails because of memory failure, sw_err_cnt is already used to log memory failure in hns3_skb_linearize(), so use it to log the memory failure for skb_put_padto() too. Signed-off-by: Yunsheng Lin Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisil

[PATCH net-next 5/9] net: hns3: optimize the process of queue reset

2021-03-28 Thread Huazhong Tan
From: Yufeng Mo Currently, the queue reset process needs to be performed one by one, which is inefficient. However, the queue reset of the same function is always performed at the same time. Therefore, according to the UM, command HCLGE_OPC_CFG_RST_TRIGGER can be used to reset all queues of the s

[PATCH net-next 2/9] net: hns3: fix use-after-free issue for hclge_add_fd_entry_common()

2021-03-28 Thread Huazhong Tan
From: Jian Shen When new rule state is TO_ADD or ACTIVE, and there is already a rule with same location in the fd_rule_list, the new rule will be freed after modifying the old rule. It may cause user-after-free issue when access rule again in hclge_add_fd_entry_common(). Fixes: fc4243b8de8b ("ne

[PATCH net-next 1/9] net: hns3: fix missing rule state assignment

2021-03-28 Thread Huazhong Tan
From: Jian Shen Currently, when adding flow director rule, it missed to set rule state. Which may cause the rule state in software is unconsistent with hardware. Fixes: fc4243b8de8b ("net: hns3: refactor flow director configuration") Signed-off-by: Jian Shen Signed-off-by: Huazhong Tan --- dr

[PATCH net-next 0/9] net: hns3: misc updates for -next

2021-03-28 Thread Huazhong Tan
This series include some updates for the HNS3 ethernet driver. #1 & #2 fix two bugs in commit fc4243b8de8b ("net: hns3: refactor flow director configuration"). #3 modifies a potential overflow risk. #4 remove the rss_size limitation when updating rss size. #5 optimizes the resetting of tqp. #6

[PATCH net-next 4/9] net: hns3: remove the rss_size limitation by vector num

2021-03-28 Thread Huazhong Tan
From: Jian Shen Currently, if user hasn't change channel number, the rss_size is limited to be no more than the vector number, in order to keep one vector only being mapped to one queue. But the queue number of each tc can be different, and one vector also can be mapped by multiple queues. So rem

[PATCH net-next 3/9] net: hns3: remediate a potential overflow risk of bd_num_list

2021-03-28 Thread Huazhong Tan
From: Guangbin Huang The array size of bd_num_list is a fixed value, it may have potential overflow risk when array size of hclge_dfx_bd_offset_list is greater than that fixed value. So modify bd_num_list as a pointer and allocate memory for it according to array size of hclge_dfx_bd_offset_list.

Re: [PATCH net 1/4] virtchnl: Fix layout of RSS structures

2021-03-28 Thread Samudrala, Sridhar
On 3/27/2021 2:53 AM, Geert Uytterhoeven wrote: Hi Samudrala, On Fri, Mar 26, 2021 at 11:45 PM Samudrala, Sridhar wrote: On 3/26/2021 1:06 AM, Geert Uytterhoeven wrote: On Thu, Mar 25, 2021 at 11:29 PM Tony Nguyen wrote: From: Norbert Ciosek Remove padding from RSS structures. Previous lay

Re: [PATCH bpf-next 5/5] libbpf: add selftests for TC-BPF API

2021-03-28 Thread Andrii Nakryiko
On Sun, Mar 28, 2021 at 6:40 PM Alexei Starovoitov wrote: > > On Sat, Mar 27, 2021 at 09:32:58PM -0700, Andrii Nakryiko wrote: > > > I think it's better to start with new library for tc/xdp and have > > > libbpf as a dependency on that new lib. > > > For example we can add it as subdir in tools/li

[PATCH net-next v2] net: mscc: ocelot: remove redundant dev_err call in vsc9959_mdio_bus_alloc()

2021-03-28 Thread Huang Guobin
From: Guobin Huang There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- drivers/net/dsa/ocelot/felix_vsc9959.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-

[PATCH net-next v2] net: stmmac: remove redundant dev_err call in qcom_ethqos_probe()

2021-03-28 Thread Huang Guobin
From: Guobin Huang There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- .../net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 1 - 1 file changed, 1 deletion(-) dif

[PATCH net-next v2] net: axienet: Remove redundant dev_err call in axienet_probe()

2021-03-28 Thread Huang Guobin
From: Guobin Huang There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 1 - 1 file changed, 1 deletion(-) diff -

Re: [PATCH bpf-next 5/5] libbpf: add selftests for TC-BPF API

2021-03-28 Thread Kumar Kartikeya Dwivedi
On Mon, Mar 29, 2021 at 06:56:02AM IST, Alexei Starovoitov wrote: > This is up to you. I'm trying to understand the motivation for *_block() apis. > I'm not taking a stance for/against them. The block APIs simply attach to a different shared filter block, so in that sense they just forward to the

Re: [PATCH bpf-next 5/5] libbpf: add selftests for TC-BPF API

2021-03-28 Thread Alexei Starovoitov
On Sat, Mar 27, 2021 at 09:32:58PM -0700, Andrii Nakryiko wrote: > > I think it's better to start with new library for tc/xdp and have > > libbpf as a dependency on that new lib. > > For example we can add it as subdir in tools/lib/bpf/. > > > > Similarly I think integerating static linking into li

[PATCH net-next v2] net: mdio: Remove redundant dev_err call in mdio_mux_iproc_probe()

2021-03-28 Thread Huang Guobin
From: Guobin Huang There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot Signed-off-by: Guobin Huang --- drivers/net/mdio/mdio-mux-bcm-iproc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

linux-next: manual merge of the net-next tree with the bpf tree

2021-03-28 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: include/linux/bpf.h between commit: 861de02e5f3f ("bpf: Take module reference for trampoline in module") from the bpf tree and commit: 69c087ba6225 ("bpf: Add bpf_for_each_map_elem() helper") from the net-next tre

Re: [PATCH bpf-next 5/5] libbpf: add selftests for TC-BPF API

2021-03-28 Thread Alexei Starovoitov
On Sat, Mar 27, 2021 at 04:17:16PM +0100, Toke Høiland-Jørgensen wrote: > Alexei Starovoitov writes: > > > On Thu, Mar 25, 2021 at 05:30:03PM +0530, Kumar Kartikeya Dwivedi wrote: > >> This adds some basic tests for the low level bpf_tc_* API and its > >> bpf_program__attach_tc_* wrapper on top.

Re: [PATCH v2 bpf-next 00/14] bpf: Support calling kernel function

2021-03-28 Thread Martin KaFai Lau
On Sun, Mar 28, 2021 at 01:13:35PM -0700, Cong Wang wrote: > On Sat, Mar 27, 2021 at 3:54 PM Alexei Starovoitov > wrote: > > > > On Sat, Mar 27, 2021 at 3:08 PM Cong Wang wrote: > > > BTFIDS vmlinux > > > FAILED unresolved symbol cubictcp_state > > > make: *** [Makefile:1199: vmlinux] Error 25

Re: [PATCH] drivers/net/wan/hdlc_fr: Fix a double free in pvc_xmit

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Sun, 28 Mar 2021 00:50:08 -0700 you wrote: > In pvc_xmit, if __skb_pad(skb, pad, false) failed, it will free > the skb in the first time and goto drop. But the same skb is freed > by kfree_skb(skb) in the second time in drop.

Re: [PATCH bpf-next] bpf: tcp: Fix an error in the bpf_tcp_ca_kfunc_ids list

2021-03-28 Thread Alexei Starovoitov
On Sun, Mar 28, 2021 at 5:32 PM Martin KaFai Lau wrote: > > There is a typo in the bbr function, s/even/event/. > This patch fixes it. > > Fixes: e78aea8b2170 ("bpf: tcp: Put some tcp cong functions in allowlist for > bpf-tcp-cc") > Signed-off-by: Martin KaFai Lau Applied.

Re: [PATCH bpf-next 3/3] selftests/bpf: allow compiling BPF objects without BTF

2021-03-28 Thread Alexei Starovoitov
On Fri, Mar 26, 2021 at 9:44 AM Andrii Nakryiko wrote: > > Because they double the maintenance cost now and double the support forever. > > We never needed to worry about skeleton without BTF and now it would be > > a thing ? So all tests realistically need to be doubled: with and without > > BTF

Re: [PATCH net-next v2] net: dsa: hellcreek: Remove redundant dev_err call in hellcreek_probe()

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 27 Mar 2021 18:07:18 +0800 you wrote: > From: Guobin Huang > > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Reported-by: Hulk

Re: [PATCH -next] net: stmmac: fix missing unlock on error in stmmac_suspend()

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 27 Mar 2021 17:33:22 +0800 you wrote: > Add the missing unlock before return from stmmac_suspend() > in the error handling case. > > Fixes: 5ec55823438e ("net: stmmac: add clocks management for gmac driver") > Repo

Re: [PATCH net-next] mt76: mt7615: remove redundant dev_err call in mt7622_wmac_probe()

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 27 Mar 2021 17:56:18 +0800 you wrote: > From: Guobin Huang > > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Reported-by: Hulk

Re: [PATCH] mt76: Convert to DEFINE_SHOW_ATTRIBUTE

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 27 Mar 2021 17:56:17 +0800 you wrote: > From: Junlin Yang > > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Junlin Yang > --- > .../net/wireless/mediatek/mt76/mt7915/debugfs.c| 36

Re: [PATCH net-next v2] net: lantiq: Remove redundant dev_err call in xrx200_probe()

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 27 Mar 2021 18:31:51 +0800 you wrote: > From: Guobin Huang > > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Reported-by: Hulk

Re: [PATCH net-next v2] net: moxa: remove redundant dev_err call in moxart_mac_probe()

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 27 Mar 2021 18:37:54 +0800 you wrote: > From: Guobin Huang > > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Reported-by: Hulk

Re: [PATCH net-next] nexthop: Rename artifacts related to legacy multipath nexthop groups

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 26 Mar 2021 14:20:22 +0100 you wrote: > After resilient next-hop groups have been added recently, there are two > types of multipath next-hop groups: the legacy "mpath", and the new > "resilient". Calling the legacy

Re: [PATCH 0/9] net: Correct function names in the kerneldoc comments

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Sat, 27 Mar 2021 16:15:47 +0800 you wrote: > Xiongfeng Wang (9): > l3mdev: Correct function names in the kerneldoc comments > netlabel: Correct function name netlbl_mgmt_add() in the kerneldoc > comments > net

Re: [PATCH net-next,v2] net: dsa: mt7530: clean up core and TRGMII clock setup

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 26 Mar 2021 23:07:52 -0700 you wrote: > Three minor changes: > > - When disabling PLL, there is no need to call core_write_mmd_indirect > directly, use the core_write wrapper instead like the rest of the code >

Re: [PATCH -next 0/3] Fix some typos

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Sat, 27 Mar 2021 10:27:21 +0800 you wrote: > Lu Wei (3): > net: rds: Fix a typo > net: sctp: Fix some typos > net: vsock: Fix a typo > > net/rds/send.c | 2 +- > net/sctp/sm_make_chunk.c | 2 +- > net/

Re: [PATCH] drivers: net: smc91x: remove redundant initialization of pointer gpio

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 26 Mar 2021 19:28:47 + you wrote: > From: Colin Ian King > > The pointer gpio is being initialized with a value that is > never read and it is being updated later with a new value. The > initialization is redu

Re: [PATCH net-next] net: hns3: no return statement in hclge_clear_arfs_rules

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 27 Mar 2021 12:33:39 +0800 you wrote: > From: Liu Jian > > drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c: In function > 'hclge_clear_arfs_rules': > drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.

Re: [PATCH net-next 0/2] selftest: add tests for packet per second

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 26 Mar 2021 14:09:36 +0100 you wrote: > Add self tests for the recently added packet per second rate limiting > feature of the TC policer action[1]. > > The forwarding selftest (patch 2/2) depends on iproute2 supp

Re: [PATCH v2 0/7] remove different PHY fixups

2021-03-28 Thread Shawn Guo
On Wed, Mar 24, 2021 at 06:54:24AM +0100, Oleksij Rempel wrote: > Hi Shawn, > > ping, do this patches need some ACK from some one? As this will break existing DTBs, I need more ACKs from people to see the consensus that this is the right thing to do. Shawn > > Regards, > Oleksij > > On Tue, M

Re: [PATCH] ipv6: addrconf.c: Fix a typo

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 27 Mar 2021 04:42:40 +0530 you wrote: > s/Identifers/Identifiers/ > > Signed-off-by: Bhaskar Chowdhury > --- > net/ipv6/addrconf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > [...] Here is the s

Re: [PATCH] bearer.h: Spellos fixed

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 27 Mar 2021 04:42:37 +0530 you wrote: > s/initalized/initialized/ ...three different places > > Signed-off-by: Bhaskar Chowdhury > --- > net/tipc/bearer.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletion

Re: [PATCH] ipv4: ip_output.c: Couple of typo fixes

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 27 Mar 2021 04:42:38 +0530 you wrote: > s/readibility/readability/ > s/insufficent/insufficient/ > > Signed-off-by: Bhaskar Chowdhury > --- > net/ipv4/ip_output.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 de

Re: [PATCH] mptcp: subflow.c: Fix a typo

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 27 Mar 2021 04:42:46 +0530 you wrote: > s/concerened/concerned/ > > Signed-off-by: Bhaskar Chowdhury > --- > net/mptcp/subflow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > [...] Here is the sum

Re: [PATCH] ncsi: internal.h: Fix a spello

2021-03-28 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 27 Mar 2021 04:42:47 +0530 you wrote: > s/Firware/Firmware/ > > Signed-off-by: Bhaskar Chowdhury > --- > net/ncsi/internal.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > [...] Here is the summary

[PATCH bpf-next] bpf: tcp: Fix an error in the bpf_tcp_ca_kfunc_ids list

2021-03-28 Thread Martin KaFai Lau
There is a typo in the bbr function, s/even/event/. This patch fixes it. Fixes: e78aea8b2170 ("bpf: tcp: Put some tcp cong functions in allowlist for bpf-tcp-cc") Signed-off-by: Martin KaFai Lau --- net/ipv4/bpf_tcp_ca.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ip

Re: [PATCH] ia64: tools: add generic errno.h definition

2021-03-28 Thread Sergei Trofimovich
On Sat, 27 Mar 2021 10:18:18 + Sergei Trofimovich wrote: > On Fri, Mar 12, 2021 at 07:51:35AM +, Sergei Trofimovich wrote: > > Noticed missing header when build bpfilter helper: > > > > CC [U] net/bpfilter/main.o > > In file included from /usr/include/linux/errno.h:1, > >

Re: [Patch bpf-next v7 00/13] sockmap: introduce BPF_SK_SKB_VERDICT and support UDP

2021-03-28 Thread Alexei Starovoitov
On Sun, Mar 28, 2021 at 01:20:00PM -0700, Cong Wang wrote: > From: Cong Wang > > We have thousands of services connected to a daemon on every host > via AF_UNIX dgram sockets, after they are moved into VM, we have to > add a proxy to forward these communications from VM to host, because > rewriti

rtlwifi/rtl8192cu AP mode broken with PS STA

2021-03-28 Thread Maciej S. Szmigiero
Hi, It looks like rtlwifi/rtl8192cu AP mode is broken when a STA is using PS, since the driver does not update its beacon to account for TIM changes, so a station that is sleeping will never learn that it has packets buffered at the AP. Looking at the code, the rtl8192cu driver implements neithe

[PATCH net-next v4] net: x25: Queue received packets in the drivers instead of per-CPU queues

2021-03-28 Thread Xie He
X.25 Layer 3 (the Packet Layer) expects layer 2 to provide a reliable datalink service such that no packets are reordered or dropped. And X.25 Layer 2 (the LAPB layer) is indeed designed to provide such service. However, this reliability is not preserved when a driver calls "netif_rx" to deliver t

Re: [PATCH net-next 2/3] net: dsa: Allow default tag protocol to be overridden from DT

2021-03-28 Thread Andrew Lunn
On Mon, Mar 29, 2021 at 12:53:09AM +0300, Vladimir Oltean wrote: > On Sun, Mar 28, 2021 at 05:52:43PM +0200, Andrew Lunn wrote: > > > +static int dsa_switch_setup_tag_protocol(struct dsa_switch *ds) > > > +{ > > > + const struct dsa_device_ops *tag_ops = ds->dst->tag_ops; > > > + struct dsa_switch_

Re: [PATCH net-next 2/3] net: dsa: Allow default tag protocol to be overridden from DT

2021-03-28 Thread Vladimir Oltean
On Sun, Mar 28, 2021 at 05:52:43PM +0200, Andrew Lunn wrote: > > +static int dsa_switch_setup_tag_protocol(struct dsa_switch *ds) > > +{ > > + const struct dsa_device_ops *tag_ops = ds->dst->tag_ops; > > + struct dsa_switch_tree *dst = ds->dst; > > + int port, err; > > + > > + if (tag_ops->

[PATCH] lan743x: remove redundant intializations of pointers adapter and phydev

2021-03-28 Thread Colin King
From: Colin Ian King The pointers adapter and phydev are being initialized with values that are never read and are being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/net/ethern

[PATCH] mac80211: remove redundant assignment of variable result

2021-03-28 Thread Colin King
From: Colin Ian King The variable result is being assigned a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- net/mac80211/tx.c | 2 +- 1 file chan

Re: [PATCH net-next v5 3/3] smsc95xx: add phylib support

2021-03-28 Thread Måns Rullgård
Heiner Kallweit writes: > On 28.03.2021 21:59, Måns Rullgård wrote: >> Andre Edich writes: >> >>> Generally, each PHY has their own configuration and it can be done >>> through an external PHY driver. The smsc95xx driver uses only the >>> hard-coded internal PHY configuration. >>> >>> This pat

Re: [net-next 1/2] xen-netback: add module parameter to disable ctrl-ring

2021-03-28 Thread Hsu, Chiahao
Leon Romanovsky 於 2021/3/22 08:13 寫道: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. On Mon, Mar 22, 2021 at 08:01:17AM +0100, Jürgen Groß wrote: On 22.03.21 07:48, Le

Re: [PATCH net-next v5 3/3] smsc95xx: add phylib support

2021-03-28 Thread Heiner Kallweit
On 28.03.2021 21:59, Måns Rullgård wrote: > Andre Edich writes: > >> Generally, each PHY has their own configuration and it can be done >> through an external PHY driver. The smsc95xx driver uses only the >> hard-coded internal PHY configuration. >> >> This patch adds phylib support to probe ext

[Patch bpf-next v7 13/13] selftests/bpf: add a test case for udp sockmap

2021-03-28 Thread Cong Wang
From: Cong Wang Add a test case to ensure redirection between two UDP sockets work. Cc: John Fastabend Cc: Daniel Borkmann Cc: Jakub Sitnicki Cc: Lorenz Bauer Signed-off-by: Cong Wang --- .../selftests/bpf/prog_tests/sockmap_listen.c | 136 ++ .../selftests/bpf/progs/test_s

[Patch bpf-next v7 11/13] udp: implement udp_bpf_recvmsg() for sockmap

2021-03-28 Thread Cong Wang
From: Cong Wang We have to implement udp_bpf_recvmsg() to replace the ->recvmsg() to retrieve skmsg from ingress_msg. Cc: John Fastabend Cc: Daniel Borkmann Cc: Jakub Sitnicki Cc: Lorenz Bauer Signed-off-by: Cong Wang --- net/ipv4/udp_bpf.c | 64

[Patch bpf-next v7 12/13] sock_map: update sock type checks for UDP

2021-03-28 Thread Cong Wang
From: Cong Wang Now UDP supports sockmap and redirection, we can safely update the sock type checks for it accordingly. Cc: John Fastabend Cc: Daniel Borkmann Cc: Jakub Sitnicki Cc: Lorenz Bauer Signed-off-by: Cong Wang --- net/core/sock_map.c | 5 - 1 file changed, 4 insertions(+), 1

[Patch bpf-next v7 07/13] sock_map: introduce BPF_SK_SKB_VERDICT

2021-03-28 Thread Cong Wang
From: Cong Wang Reusing BPF_SK_SKB_STREAM_VERDICT is possible but its name is confusing and more importantly we still want to distinguish them from user-space. So we can just reuse the stream verdict code but introduce a new type of eBPF program, skb_verdict. Users are not allowed to set stream_v

[Patch bpf-next v7 10/13] skmsg: extract __tcp_bpf_recvmsg() and tcp_bpf_wait_data()

2021-03-28 Thread Cong Wang
From: Cong Wang Although these two functions are only used by TCP, they are not specific to TCP at all, both operate on skmsg and ingress_msg, so fit in net/core/skmsg.c very well. And we will need them for non-TCP, so rename and move them to skmsg.c and export them to modules. Cc: John Fastabe

[Patch bpf-next v7 08/13] sock: introduce sk->sk_prot->psock_update_sk_prot()

2021-03-28 Thread Cong Wang
From: Cong Wang Currently sockmap calls into each protocol to update the struct proto and replace it. This certainly won't work when the protocol is implemented as a module, for example, AF_UNIX. Introduce a new ops sk->sk_prot->psock_update_sk_prot(), so each protocol can implement its own way

[Patch bpf-next v7 09/13] udp: implement ->read_sock() for sockmap

2021-03-28 Thread Cong Wang
From: Cong Wang This is similar to tcp_read_sock(), except we do not need to worry about connections, we just need to retrieve skb from UDP receive queue. Note, the return value of ->read_sock() is unused in sk_psock_verdict_data_ready(). Cc: John Fastabend Cc: Daniel Borkmann Cc: Jakub Sitni

[Patch bpf-next v7 06/13] skmsg: use GFP_KERNEL in sk_psock_create_ingress_msg()

2021-03-28 Thread Cong Wang
From: Cong Wang This function is only called in process context. Cc: John Fastabend Cc: Daniel Borkmann Cc: Jakub Sitnicki Cc: Lorenz Bauer Signed-off-by: Cong Wang --- net/core/skmsg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/skmsg.c b/net/core/skmsg.c

[Patch bpf-next v7 04/13] skmsg: avoid lock_sock() in sk_psock_backlog()

2021-03-28 Thread Cong Wang
From: Cong Wang We do not have to lock the sock to avoid losing sk_socket, instead we can purge all the ingress queues when we close the socket. Sending or receiving packets after orphaning socket makes no sense. We do purge these queues when psock refcnt reaches zero but here we want to purge t

[Patch bpf-next v7 05/13] skmsg: use rcu work for destroying psock

2021-03-28 Thread Cong Wang
From: Cong Wang The RCU callback sk_psock_destroy() only queues work psock->gc, so we can just switch to rcu work to simplify the code. Cc: Daniel Borkmann Cc: Jakub Sitnicki Cc: Lorenz Bauer Acked-by: John Fastabend Signed-off-by: Cong Wang --- include/linux/skmsg.h | 5 + net/core/s

[Patch bpf-next v7 02/13] skmsg: introduce a spinlock to protect ingress_msg

2021-03-28 Thread Cong Wang
From: Cong Wang Currently we rely on lock_sock to protect ingress_msg, it is too big for this, we can actually just use a spinlock to protect this list like protecting other skb queues. __tcp_bpf_recvmsg() is still special because of peeking, it still has to use lock_sock. Cc: John Fastabend C

[Patch bpf-next v7 03/13] net: introduce skb_send_sock() for sock_map

2021-03-28 Thread Cong Wang
From: Cong Wang We only have skb_send_sock_locked() which requires callers to use lock_sock(). Introduce a variant skb_send_sock() which locks on its own, callers do not need to lock it any more. This will save us from adding a ->sendmsg_locked for each protocol. To reuse the code, pass function

[Patch bpf-next v7 00/13] sockmap: introduce BPF_SK_SKB_VERDICT and support UDP

2021-03-28 Thread Cong Wang
From: Cong Wang We have thousands of services connected to a daemon on every host via AF_UNIX dgram sockets, after they are moved into VM, we have to add a proxy to forward these communications from VM to host, because rewriting thousands of them is not practical. This proxy uses an AF_UNIX socke

[Patch bpf-next v7 01/13] skmsg: lock ingress_skb when purging

2021-03-28 Thread Cong Wang
From: Cong Wang Currently we purge the ingress_skb queue only when psock refcnt goes down to 0, so locking the queue is not necessary, but in order to be called during ->close, we have to lock it here. Cc: John Fastabend Cc: Daniel Borkmann Cc: Lorenz Bauer Acked-by: Jakub Sitnicki Signed-of

Re: [PATCH v2 bpf-next 00/14] bpf: Support calling kernel function

2021-03-28 Thread Cong Wang
On Sat, Mar 27, 2021 at 3:54 PM Alexei Starovoitov wrote: > > On Sat, Mar 27, 2021 at 3:08 PM Cong Wang wrote: > > BTFIDS vmlinux > > FAILED unresolved symbol cubictcp_state > > make: *** [Makefile:1199: vmlinux] Error 255 > > > > I suspect it is related to the kernel config or linker version.

Re: [PATCH net-next v5 3/3] smsc95xx: add phylib support

2021-03-28 Thread Måns Rullgård
Andre Edich writes: > Generally, each PHY has their own configuration and it can be done > through an external PHY driver. The smsc95xx driver uses only the > hard-coded internal PHY configuration. > > This patch adds phylib support to probe external PHY drivers for > configuring external PHYs.

Re: [PATCH] PCI: Remove pci_try_set_mwi

2021-03-28 Thread Bjorn Helgaas
On Sun, Mar 28, 2021 at 12:04:35AM +0100, Heiner Kallweit wrote: > On 26.03.2021 22:26, Bjorn Helgaas wrote: > > [+cc Randy, Andrew (though I'm sure you have zero interest in this > > ancient question :))] > > > > On Wed, Dec 09, 2020 at 09:31:21AM +0100, Heiner Kallweit wrote: > >> pci_set_mwi()

[syzbot] KASAN: slab-out-of-bounds Read in fib6_nh_get_excptn_bucket (3)

2021-03-28 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:7acac4b3 Merge tag 'linux-kselftest-kunit-fixes-5.12-rc5.1.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=102449f6d0 kernel config: https://syzkaller.appspot.com/x/.config?x=5adab0bdee099d7a das

Re: [PATCH bpf-next] bpf: tcp: Remove comma which is causing build error

2021-03-28 Thread Alexei Starovoitov
On Sun, Mar 28, 2021 at 5:05 AM Atul Gopinathan wrote: > > Currently, building the bpf-next source with the CONFIG_BPF_SYSCALL > enabled is causing a compilation error: > > "net/ipv4/bpf_tcp_ca.c:209:28: error: expected identifier or '(' before > ',' token" > > Fix this by removing an unnecessary

Re: [PATCH v4 bpf-next 07/12] libbpf: add BPF static linker BTF and BTF.ext support

2021-03-28 Thread Andrii Nakryiko
On Sun, Mar 28, 2021 at 5:03 AM Jiri Olsa wrote: > > On Fri, Mar 19, 2021 at 07:58:13PM +0100, Jiri Olsa wrote: > > On Fri, Mar 19, 2021 at 11:39:01AM -0700, Andrii Nakryiko wrote: > > > On Fri, Mar 19, 2021 at 9:23 AM Jiri Olsa wrote: > > > > > > > > On Thu, Mar 18, 2021 at 12:40:31PM -0700, And

Re: [net-next PATCH 0/8] configuration support for switch headers & phy

2021-03-28 Thread Andrew Lunn
> The usecase is simple, unlike DSA tag, this 4byte FDSA tag doesn't > have a ethertype, > so HW cannot recognize this header. If such packers arise, then HW parsing > will > fail and RSS will not work. > > Hypothetically if we introduce some communication between MAC driver > and DSA driver, > w

[PATCH net-next 7/7] net: ipa: kill IPA_TABLE_ENTRY_SIZE

2021-03-28 Thread Alex Elder
Entries in an IPA route or filter table are 64-bit little-endian addresses, each of which refers to a routing or filtering rule. The format of these table slots are fixed, but IPA_TABLE_ENTRY_SIZE is used to define their size. This symbol doesn't really add value, and I think it unnecessarily obs

[PATCH net-next 6/7] net: ipa: DMA addresses are nicely aligned

2021-03-28 Thread Alex Elder
A recent patch avoided doing 64-bit modulo operations by checking the alignment of some DMA allocations using only the lower 32 bits of the address. David Laight pointed out (after the fix was committed) that DMA allocations might already satisfy the alignment requirements. And he was right. Rem

[PATCH net-next 5/7] net: ipa: use version based configuration for SC7180

2021-03-28 Thread Alex Elder
Rename the SC7180 configuration data file so that its name is derived from its IPA version. Update a few other references to the code that talk about the SC7180 rather than just IPA v4.2. Signed-off-by: Alex Elder --- drivers/net/ipa/Makefile | 2 +- .../{ipa_data-sc7180.c

[PATCH net-next 3/7] net: ipa: don't define endpoints unnecessarily

2021-03-28 Thread Alex Elder
We don't typically need much information about modem endpoints. Normally we need to specify information about modem endpoints in configuration data in only two cases: - When a modem TX endpoint supports filtering - When another endpoint's configuration refers to it For the first case, the AP i

[PATCH net-next 1/7] net: ipa: fix all kernel-doc warnings

2021-03-28 Thread Alex Elder
Fix all warnings produced when running: scripts/kernel-doc -none drivers/net/ipa/*.[ch] Signed-off-by: Alex Elder --- drivers/net/ipa/gsi_private.h | 2 +- drivers/net/ipa/gsi_trans.h | 5 +++-- drivers/net/ipa/ipa.h | 7 --- drivers/net/ipa/ipa_cmd.h | 19

[PATCH net-next 2/7] net: ipa: store BCR register values in config data

2021-03-28 Thread Alex Elder
The backward compatibility register value is a platform-specific property that is not stored in the platform data. Create a data field where this can be represented, and get rid ipa_reg_bcr_val(). This register is not present starting with IPA v4.5. Signed-off-by: Alex Elder --- drivers/net/ip

[PATCH net-next 4/7] net: ipa: switch to version based configuration

2021-03-28 Thread Alex Elder
Rename the SDM845 configuration data file so that its name is derived from its IPA version. I am not aware of any special IPA behavior or handling that would be based on a specific SoC (as opposed to a specific version of the IPA it contains). Update a few other references to the code that talk a

[PATCH net-next 0/7] net: ipa: a few last bits

2021-03-28 Thread Alex Elder
This series incorporates a few last things that didn't fit neatly with patches I've posted recently. The first patch eliminates all remaining kernel-doc warnings. There's still room for kernel-doc improvement, but at least what's there will no longer produce warnings. The next moves the definitio

[PATCH net-next v3] net: x25: Queue received packets in the drivers instead of per-CPU queues

2021-03-28 Thread Xie He
X.25 Layer 3 (the Packet Layer) expects layer 2 to provide a reliable datalink service such that no packets are reordered or dropped. And X.25 Layer 2 (the LAPB layer) is indeed designed to provide such service. However, this reliability is not preserved when a driver calls "netif_rx" to deliver t

Re: [PATCH net-next V5 6/6] icmp: add response to RFC 8335 PROBE messages

2021-03-28 Thread Willem de Bruijn
On Wed, Mar 24, 2021 at 2:20 PM Andreas Roeseler wrote: > > Modify the icmp_rcv function to check PROBE messages and call icmp_echo > if a PROBE request is detected. > > Modify the existing icmp_echo function to respond ot both ping and PROBE > requests. > > This was tested using a custom modifica

Re: [net-next PATCH 0/8] configuration support for switch headers & phy

2021-03-28 Thread Sunil Kovvuri
On Thu, Mar 25, 2021 at 6:51 PM Andrew Lunn wrote: > > On Thu, Mar 25, 2021 at 06:32:12PM +0530, Sunil Kovvuri wrote: > > On Thu, Mar 25, 2021 at 6:20 PM Andrew Lunn wrote: > > > > > > > > So you completely skipped how this works with mv88e6xxx or > > > > > prestera. If you need this private flag

[PATCH net-next v2] net: x25: Queue received packets in the drivers instead of per-CPU queues

2021-03-28 Thread Xie He
X.25 Layer 3 (the Packet Layer) expects layer 2 to provide a reliable datalink service such that no packets are reordered or dropped. And X.25 Layer 2 (the LAPB layer) is indeed designed to provide such service. However, this reliability is not preserved when a driver calls "netif_rx" to deliver t

[PATCH bpf-next] libbpf: Add '_wait()' and '_nowait()' macros for 'bpf_ring_buffer__poll()'

2021-03-28 Thread Pedro Tammela
'bpf_ring_buffer__poll()' abstracts the polling method, so abstract the constants that make the implementation don't wait or wait indefinetly for data. Signed-off-by: Pedro Tammela --- tools/lib/bpf/libbpf.h | 3 +++ tools/testing/selftests/bpf/benchs/bench_ringbu

[PATCH bpf-next] bpf: check flags in 'bpf_ringbuf_discard()' and 'bpf_ringbuf_submit()'

2021-03-28 Thread Pedro Tammela
The current code only checks flags in 'bpf_ringbuf_output()'. Signed-off-by: Pedro Tammela --- include/uapi/linux/bpf.h | 8 kernel/bpf/ringbuf.c | 13 +++-- tools/include/uapi/linux/bpf.h | 8 3 files changed, 19 insertions(+), 10 deletions(-) diff -

[PATCH bpf-next] bpf: add 'BPF_RB_MAY_WAKEUP' flag

2021-03-28 Thread Pedro Tammela
The current way to provide a no-op flag to 'bpf_ringbuf_submit()', 'bpf_ringbuf_discard()' and 'bpf_ringbuf_output()' is to provide a '0' value. A '0' value might notify the consumer if it already caught up in processing, so let's provide a more descriptive notation for this value. Signed-off-by:

  1   2   >