[PATCH net-next,v2] net: dsa: mt7530: clean up core and TRGMII clock setup

2021-03-26 Thread Ilya Lipnitskiy
Three minor changes: - When disabling PLL, there is no need to call core_write_mmd_indirect directly, use the core_write wrapper instead like the rest of the code in the function does. This change helps with consistency and readability. Move the comment to the definition of core_read_mmd_i

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-26 Thread Leon Romanovsky
On Fri, Mar 26, 2021 at 02:12:09PM -0300, Jason Gunthorpe wrote: > On Fri, Mar 26, 2021 at 12:08:31PM -0500, Bjorn Helgaas wrote: > > > Leon has implemented a ton of variations, but I don't think having all > > the files in the PF directory was one of them. > > If you promise this is the last of

[PATCH net-next] net: dsa: mt7530: clean up core and TRGMII clock setup

2021-03-26 Thread Ilya Lipnitskiy
Three minor changes: - When disabling PLL, there is no need to call core_write_mmd_indirect directly, use the core_write wrapper instead like the rest of the code in the function does. This change helps with consistency and readability. Move the comment to the definition of core_write_mmd_

Re: [Patch bpf-next v6 04/12] skmsg: avoid lock_sock() in sk_psock_backlog()

2021-03-26 Thread Cong Wang
On Thu, Mar 25, 2021 at 7:10 PM John Fastabend wrote: > Hi Cong, > > I'm trying to understand if the workqueue logic will somehow prevent the > following, > > CPU0 CPU1 > > work dequeue > sk_psock_backlog() > ... do backlog > ... also maybe sleep > >

[PATCH net-next] net: hns3: no return statement in hclge_clear_arfs_rules

2021-03-26 Thread 'Liu Jian
From: Liu Jian drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c: In function 'hclge_clear_arfs_rules': drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:7173:1: error: no return statement in function returning non-void [-Werror=return-type] 7173 | } | ^ cc1: some warnings be

[PATCH bpf-next] libbpf: fix memory leak when emitting final btf_ext

2021-03-26 Thread Andrii Nakryiko
Free temporary allocated memory used to construct finalized .BTF.ext data. Found by Coverity static analysis on libbpf's Github repo. Fixes: 8fd27bf69b86 ("libbpf: Add BPF static linker BTF and BTF.ext support") Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/linker.c | 24 -

Re: [PATCH v2 bpf-next 03/14] bpf: Support bpf program calling kernel function

2021-03-26 Thread Alexei Starovoitov
On Wed, Mar 24, 2021 at 06:51:42PM -0700, Martin KaFai Lau wrote: > ref_tname = btf_name_by_offset(btf, ref_t->name_off); > - if (btf_get_prog_ctx_type(log, btf, t, env->prog->type, i)) { > + if (btf_is_kernel(btf)) { > + const struct btf_ty

Re: [PATCH bpf-next 1/5] tools pkt_cls.h: sync with kernel sources

2021-03-26 Thread Andrii Nakryiko
On Fri, Mar 26, 2021 at 8:54 PM Kumar Kartikeya Dwivedi wrote: > > On Sat, Mar 27, 2021 at 04:55:51AM IST, Andrii Nakryiko wrote: > > On Thu, Mar 25, 2021 at 5:01 AM Kumar Kartikeya Dwivedi > > wrote: > > > > > > Update the header file so we can use the new defines in subsequent > > > patches. >

Re: [PATCH bpf-next 1/5] tools pkt_cls.h: sync with kernel sources

2021-03-26 Thread Kumar Kartikeya Dwivedi
On Sat, Mar 27, 2021 at 04:55:51AM IST, Andrii Nakryiko wrote: > On Thu, Mar 25, 2021 at 5:01 AM Kumar Kartikeya Dwivedi > wrote: > > > > Update the header file so we can use the new defines in subsequent > > patches. > > > > Reviewed-by: Toke Høiland-Jørgensen > > Signed-off-by: Kumar Kartikeya

Re: [PATCH v2 bpf-next 00/14] bpf: Support calling kernel function

2021-03-26 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf-next.git (refs/heads/master): On Wed, 24 Mar 2021 18:51:24 -0700 you wrote: > This series adds support to allow bpf program calling kernel function. > > The use case included in this set is to allow bpf-tcp-cc to directly > call some tcp-cc helper functi

Re: [PATCHv3 bpf] bpf: Take module reference for trampoline in module

2021-03-26 Thread Alexei Starovoitov
On Fri, Mar 26, 2021 at 11:59:00AM +0100, Jiri Olsa wrote: > Currently module can be unloaded even if there's a trampoline > register in it. It's easily reproduced by running in parallel: > > # while :; do ./test_progs -t module_attach; done > # while :; do rmmod bpf_testmod; sleep 0.5; done >

Re: [PATCH v2 bpf 3/3] libbpf: ignore return values of setsockopt for XDP rings.

2021-03-26 Thread Alexei Starovoitov
On Fri, Mar 26, 2021 at 02:29:46PM +, Ciara Loftus wrote: > During xsk_socket__create the XDP_RX_RING and XDP_TX_RING setsockopts > are called to create the rx and tx rings for the AF_XDP socket. If the ring > has already been set up, the setsockopt will return an error. However, > in the event

[PATCH -next 2/3] net: sctp: Fix some typos

2021-03-26 Thread Lu Wei
Modify "unkown" to "unknown" in net/sctp/sm_make_chunk.c and Modify "orginal" to "original" in net/sctp/socket.c. Reported-by: Hulk Robot Signed-off-by: Lu Wei --- net/sctp/sm_make_chunk.c | 2 +- net/sctp/socket.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ne

[PATCH -next 1/3] net: rds: Fix a typo

2021-03-26 Thread Lu Wei
Modify "beween" to "between" in net/rds/send.c. Reported-by: Hulk Robot Signed-off-by: Lu Wei --- net/rds/send.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rds/send.c b/net/rds/send.c index 985d0b7713ac..53444397de66 100644 --- a/net/rds/send.c +++ b/net/rds/send.c

[PATCH -next 3/3] net: vsock: Fix a typo

2021-03-26 Thread Lu Wei
Modify "occured" to "occurred" in net/vmw_vsock/af_vsock.c. Reported-by: Hulk Robot Signed-off-by: Lu Wei --- net/vmw_vsock/af_vsock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c index 5546710d8ac1..01eebfecf1d7 100644

[PATCH -next 0/3] Fix some typos

2021-03-26 Thread Lu Wei
Lu Wei (3): net: rds: Fix a typo net: sctp: Fix some typos net: vsock: Fix a typo net/rds/send.c | 2 +- net/sctp/sm_make_chunk.c | 2 +- net/sctp/socket.c| 2 +- net/vmw_vsock/af_vsock.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) -- 2.17.1

Re: [PATCH bpf-next 5/5] libbpf: add selftests for TC-BPF API

2021-03-26 Thread Alexei Starovoitov
On Thu, Mar 25, 2021 at 05:30:03PM +0530, Kumar Kartikeya Dwivedi wrote: > This adds some basic tests for the low level bpf_tc_* API and its > bpf_program__attach_tc_* wrapper on top. *_block() apis from patch 3 and 4 are not covered by this selftest. Why were they added ? And how were they tested

Re: [PATCH] net:qrtr: fix allocator flag of idr_alloc_u32() in qrtr_port_assign()

2021-03-26 Thread Du Cheng
On Fri, Mar 26, 2021 at 10:31:57AM +0100, Greg Kroah-Hartman wrote: > On Fri, Mar 26, 2021 at 11:33:45AM +0800, Du Cheng wrote: > > change the allocator flag of idr_alloc_u32 from GFP_ATOMIC to > > GFP_KERNEL, as GFP_ATOMIC caused BUG: "using smp_processor_id() in > > preemptible" as reported by sy

RE: [PATCH] net: intel: Remove unused function pointer typedef ixgbe_mc_addr_itr

2021-03-26 Thread Switzer, David
>-Original Message- >From: Chen Lin >Sent: Monday, February 15, 2021 4:05 AM >To: da...@davemloft.net; k...@kernel.org >Cc: Brandeburg, Jesse ; Nguyen, Anthony L >; intel-wired-...@lists.osuosl.org; >netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Chen Lin > >Subject: [PATCH] net:

Re: [PATCH bpf-next 2/5] libbpf: add helpers for preparing netlink attributes

2021-03-26 Thread Andrii Nakryiko
On Thu, Mar 25, 2021 at 5:01 AM Kumar Kartikeya Dwivedi wrote: > > This change introduces a few helpers to wrap open coded attribute > preparation in netlink.c. > > Every nested attribute's closure must happen using the helper > end_nlattr_nested, which sets its length properly. NLA_F_NESTED is >

Re: [PATCH bpf-next 1/5] tools pkt_cls.h: sync with kernel sources

2021-03-26 Thread Andrii Nakryiko
On Thu, Mar 25, 2021 at 5:01 AM Kumar Kartikeya Dwivedi wrote: > > Update the header file so we can use the new defines in subsequent > patches. > > Reviewed-by: Toke Høiland-Jørgensen > Signed-off-by: Kumar Kartikeya Dwivedi > --- > tools/include/uapi/linux/pkt_cls.h | 174

[PATCH v4 bpf-next 16/17] selftests: xsk: Remove mutex and condition variable

2021-03-26 Thread Maciej Fijalkowski
From: Björn Töpel The usage of the condition variable is broken, and overkill. Replace it with a pthread barrier. Signed-off-by: Björn Töpel --- tools/testing/selftests/bpf/xdpxceiver.c | 33 tools/testing/selftests/bpf/xdpxceiver.h | 3 +-- 2 files changed, 6 inserti

[PATCH v4 bpf-next 15/17] selftests: xsk: remove thread attribute

2021-03-26 Thread Maciej Fijalkowski
From: Björn Töpel There is really no reason to have a non-default thread stack size. Remove that. Signed-off-by: Björn Töpel --- tools/testing/selftests/bpf/xdpxceiver.c | 9 ++--- tools/testing/selftests/bpf/xdpxceiver.h | 2 -- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git

[PATCH v4 bpf-next 09/17] selftests: xsk: split worker thread

2021-03-26 Thread Maciej Fijalkowski
Let's a have a separate Tx/Rx worker threads instead of a one common thread packed with Tx/Rx specific checks. Move mmap for umem buffer space and a switch_namespace() call to thread_common_ops. This also allows for a bunch of simplifactions that are the subject of the next commits. The final res

[PATCH v4 bpf-next 10/17] selftests: xsk: remove Tx synchronization resources

2021-03-26 Thread Maciej Fijalkowski
Tx thread needs to be started after the Rx side is fully initialized so that packets are not xmitted until xsk Rx socket is ready to be used. It can be observed that atomic variable spinning_tx is not checked from Rx side in any way, so thread_common_ops can be modified to only address the spinnin

[PATCH v4 bpf-next 11/17] selftests: xsk: refactor teardown/bidi test cases and testapp_validate

2021-03-26 Thread Maciej Fijalkowski
Currently, there is a testapp_sockets() that acts like a wrapper around testapp_validate() and it is called for bidi and teardown test types. Other test types call testapp_validate() directly. Split testapp_sockets() onto two separate functions so a bunch of bidi specific logic can be moved there

[PATCH v4 bpf-next 17/17] selftests: xsk: Remove unused defines

2021-03-26 Thread Maciej Fijalkowski
From: Björn Töpel Remove two unused defines. Signed-off-by: Björn Töpel --- tools/testing/selftests/bpf/xdpxceiver.c | 7 +++ tools/testing/selftests/bpf/xdpxceiver.h | 2 -- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/tools/testing/selftests/bpf/xdpxceiver.c b/tools/te

[PATCH v4 bpf-next 14/17] selftests: xsk: implement bpf_link test

2021-03-26 Thread Maciej Fijalkowski
Introduce a test that is supposed to verify the persistence of BPF resources based on underlying bpf_link usage. Test will: 1) create and bind two sockets on queue ids 0 and 1 2) run a traffic on queue ids 0 3) remove xsk sockets from queue 0 on both veth interfaces 4) run a traffic on queues ids

[PATCH v4 bpf-next 08/17] selftests: xsk: remove thread for netns switch

2021-03-26 Thread Maciej Fijalkowski
Currently, there is a dedicated thread for following remote ns operations: - grabbing the ifindex of the interface moved to remote netns - removing xdp prog from that interface With bpf_link usage in place, this can be simply omitted, so remove mentioned thread, as BPF resources will be managed by

[PATCH v4 bpf-next 13/17] veth: implement ethtool's get_channels() callback

2021-03-26 Thread Maciej Fijalkowski
Libbpf's xsk part calls get_channels() API to retrieve the queue count of the underlying driver so that XSKMAP is sized accordingly. Implement that in veth so multi queue scenarios can work properly. Signed-off-by: Maciej Fijalkowski --- drivers/net/veth.c | 12 1 file changed, 12

[PATCH v4 bpf-next 06/17] libbpf: xsk: use bpf_link

2021-03-26 Thread Maciej Fijalkowski
Currently, if there are multiple xdpsock instances running on a single interface and in case one of the instances is terminated, the rest of them are left in an inoperable state due to the fact of unloaded XDP prog from interface. Consider the scenario below: // load xdp prog and xskmap and add e

[PATCH v4 bpf-next 12/17] selftests: xsk: remove sync_mutex_tx and atomic var

2021-03-26 Thread Maciej Fijalkowski
Although thread_common_ops() are called in both Tx and Rx threads, testapp_validate() will not spawn Tx thread until Rx thread signals that it has finished its initialization via condition variable. Therefore, locking in thread_common_ops is not needed and furthermore Tx thread does not have to sp

[PATCH v4 bpf-next 05/17] selftests: xsk: simplify frame traversal in dumping thread

2021-03-26 Thread Maciej Fijalkowski
Store offsets to each layer in a separate variables rather than compute them every single time. Signed-off-by: Björn Töpel Signed-off-by: Maciej Fijalkowski --- tools/testing/selftests/bpf/xdpxceiver.c | 47 +++- 1 file changed, 21 insertions(+), 26 deletions(-) diff --git

[PATCH v4 bpf-next 04/17] selftests: xsk: remove inline keyword from source file

2021-03-26 Thread Maciej Fijalkowski
Follow the kernel coding style guidelines and let compiler do the decision about inlining. Signed-off-by: Maciej Fijalkowski --- tools/testing/selftests/bpf/xdpxceiver.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/tools/testing/selftests/bpf/xdpxceiver.

[PATCH v4 bpf-next 07/17] samples: bpf: do not unload prog within xdpsock

2021-03-26 Thread Maciej Fijalkowski
With the introduction of bpf_link in xsk's libbpf part, there's no further need for explicit unload of prog on xdpsock's termination. When process dies, the bpf_link's refcount will be decremented and resources will be unloaded/freed under the hood in case when there are no more active users. Whil

[PATCH v4 bpf-next 03/17] selftests: xsk: remove unused function

2021-03-26 Thread Maciej Fijalkowski
Probably it was ported from xdpsock but is not used anywhere. Signed-off-by: Maciej Fijalkowski --- tools/testing/selftests/bpf/xdpxceiver.c | 13 - 1 file changed, 13 deletions(-) diff --git a/tools/testing/selftests/bpf/xdpxceiver.c b/tools/testing/selftests/bpf/xdpxceiver.c inde

[PATCH v4 bpf-next 02/17] selftests: xsk: remove struct ifaceconfigobj

2021-03-26 Thread Maciej Fijalkowski
ifaceconfigobj is not really useful, it is possible to keep the functionality and simplify the code. Signed-off-by: Maciej Fijalkowski --- tools/testing/selftests/bpf/xdpxceiver.c | 65 +++- tools/testing/selftests/bpf/xdpxceiver.h | 9 2 files changed, 30 insertions(+)

[PATCH v4 bpf-next 01/17] selftests: xsk: don't call worker_pkt_dump() for stats test

2021-03-26 Thread Maciej Fijalkowski
For TEST_TYPE_STATS, worker_pkt_validate() that places frames onto pkt_buf is not called. Therefore, when dump mode is set, don't call worker_pkt_dump() for mentioned test type, so that it won't crash on pkt_buf() access. Signed-off-by: Maciej Fijalkowski --- tools/testing/selftests/bpf/xdpxceiv

[PATCH v4 bpf-next 00/17] AF_XDP selftests improvements & bpf_link

2021-03-26 Thread Maciej Fijalkowski
Changes since v3: - do not unload netlink-based XDP prog when updating map elem failed and current socket was not the creator of XDP resources (Toke) - pull out code paths based on prog_id value within __xsk_setup_xdp_prog so that teardown in case of error at any point is more clear Changes si

[PATCH 19/19] ipv4: tcp_lp.c: Couple of typo fixes

2021-03-26 Thread Bhaskar Chowdhury
s/resrved/reserved/ s/whithin/within/ Signed-off-by: Bhaskar Chowdhury --- net/ipv4/tcp_lp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/tcp_lp.c b/net/ipv4/tcp_lp.c index e6459537d4d2..82b36ec3f2f8 100644 --- a/net/ipv4/tcp_lp.c +++ b/net/ipv4/tcp_lp.c @@ -6

[PATCH 18/19] ipv4: ip_output.c: Couple of typo fixes

2021-03-26 Thread Bhaskar Chowdhury
s/readibility/readability/ s/insufficent/insufficient/ Signed-off-by: Bhaskar Chowdhury --- net/ipv4/ip_output.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c index 3aab53beb4ea..c3efc7d658f6 100644 --- a/net/ipv4/ip_output.c

[PATCH 15/19] kcm: kcmsock.c: Couple of typo fixes

2021-03-26 Thread Bhaskar Chowdhury
s/synchonization/synchronization/ s/aready/already/ Signed-off-by: Bhaskar Chowdhury --- net/kcm/kcmsock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/kcm/kcmsock.c b/net/kcm/kcmsock.c index d0b56ffbb057..6201965bd822 100644 --- a/net/kcm/kcmsock.c +++ b/net/kcm/k

[PATCH 14/19] iucv: af_iucv.c: Couple of typo fixes

2021-03-26 Thread Bhaskar Chowdhury
s/unitialized/uninitialized/ s/notifcations/notifications/ Signed-off-by: Bhaskar Chowdhury --- net/iucv/af_iucv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c index 6092d5cb7168..0fdb389c3390 100644 --- a/net/iucv/af_iucv.c +++

[PATCH 16/19] ipv6: route.c: A spello fix

2021-03-26 Thread Bhaskar Chowdhury
s/notfication/notification/ Signed-off-by: Bhaskar Chowdhury --- net/ipv6/route.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 1536f4948e86..dfe5fb260e4c 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -6093,7 +6093,7 @@ vo

[PATCH 17/19] ipv6: addrconf.c: Fix a typo

2021-03-26 Thread Bhaskar Chowdhury
s/Identifers/Identifiers/ Signed-off-by: Bhaskar Chowdhury --- net/ipv6/addrconf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index f2337fb756ac..8421f58ea6ea 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -2358,7

[PATCH 12/19] mac80211: cfg.c: A typo fix

2021-03-26 Thread Bhaskar Chowdhury
s/assocaited/associated/ Signed-off-by: Bhaskar Chowdhury --- net/mac80211/cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c index c4c70e30ad7f..62f2f356d401 100644 --- a/net/mac80211/cfg.c +++ b/net/mac80211/cfg.c @@ -1486,7 +1486,

[PATCH 13/19] llc: llc_core.c: COuple of typo fixes

2021-03-26 Thread Bhaskar Chowdhury
s/searchs/searches/ ...two different places. Signed-off-by: Bhaskar Chowdhury --- net/llc/llc_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/llc/llc_core.c b/net/llc/llc_core.c index 64d4bef04e73..6e387aadffce 100644 --- a/net/llc/llc_core.c +++ b/net/llc/llc

[PATCH 09/19] netfilter: nf_conntrack_acct.c: A typo fix

2021-03-26 Thread Bhaskar Chowdhury
s/Accouting/Accounting/ Signed-off-by: Bhaskar Chowdhury --- net/netfilter/nf_conntrack_acct.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/nf_conntrack_acct.c b/net/netfilter/nf_conntrack_acct.c index 2ccda8ace796..91bc8df3e4b0 100644 --- a/net/netfilter/nf

[PATCH 11/19] ncsi: internal.h: Fix a spello

2021-03-26 Thread Bhaskar Chowdhury
s/Firware/Firmware/ Signed-off-by: Bhaskar Chowdhury --- net/ncsi/internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ncsi/internal.h b/net/ncsi/internal.h index e37102546be6..49031f804276 100644 --- a/net/ncsi/internal.h +++ b/net/ncsi/internal.h @@ -100,7 +100,7

[PATCH 10/19] mptcp: subflow.c: Fix a typo

2021-03-26 Thread Bhaskar Chowdhury
s/concerened/concerned/ Signed-off-by: Bhaskar Chowdhury --- net/mptcp/subflow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c index 3d47d670e665..f1b6e4d0b95f 100644 --- a/net/mptcp/subflow.c +++ b/net/mptcp/subflow.c @@ -1076,7 +1

[PATCH 08/19] netfilter: ipvs: A spello fix

2021-03-26 Thread Bhaskar Chowdhury
s/registerd/registered/ Signed-off-by: Bhaskar Chowdhury --- net/netfilter/ipvs/ip_vs_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/ipvs/ip_vs_core.c b/net/netfilter/ipvs/ip_vs_core.c index 0c132ff9b446..128690c512df 100644 --- a/net/netfilter/ipvs/ip_v

[PATCH 07/19] sm_statefuns.c: Mundane spello fixes

2021-03-26 Thread Bhaskar Chowdhury
s/simulataneous/simultaneous/ .three different places. s/association/association/ s/interpeter/interpreter/ Signed-off-by: Bhaskar Chowdhury --- net/sctp/sm_statefuns.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_stat

[PATCH 06/19] bearer.h: Spellos fixed

2021-03-26 Thread Bhaskar Chowdhury
s/initalized/initialized/ three different places. Signed-off-by: Bhaskar Chowdhury --- net/tipc/bearer.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/tipc/bearer.h b/net/tipc/bearer.h index 6bf4550aa1ac..57c6a1a719e2 100644 --- a/net/tipc/bearer.h +++ b/net/t

[PATCH] reg.c: Fix a spello

2021-03-26 Thread Bhaskar Chowdhury
s/ingoring/ignoring/ Signed-off-by: Bhaskar Chowdhury --- net/wireless/reg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/wireless/reg.c b/net/wireless/reg.c index 21536c48deec..68db914df642 100644 --- a/net/wireless/reg.c +++ b/net/wireless/reg.c @@ -3404,7 +3404,7 @@

[PATCH 04/19] reg.c: Fix a spello

2021-03-26 Thread Bhaskar Chowdhury
s/ingoring/ignoring/ Signed-off-by: Bhaskar Chowdhury --- net/wireless/reg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/wireless/reg.c b/net/wireless/reg.c index 21536c48deec..68db914df642 100644 --- a/net/wireless/reg.c +++ b/net/wireless/reg.c @@ -3404,7 +3404,7 @@

[PATCH 05/19] node.c: A typo fix

2021-03-26 Thread Bhaskar Chowdhury
s/synching/syncing/ Signed-off-by: Bhaskar Chowdhury --- net/tipc/node.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tipc/node.c b/net/tipc/node.c index 008670d1f43e..713550c16eba 100644 --- a/net/tipc/node.c +++ b/net/tipc/node.c @@ -2009,7 +2009,7 @@ static bool tip

[PATCH 03/19] af_x25.c: Fix a spello

2021-03-26 Thread Bhaskar Chowdhury
s/facilties/facilities/ Signed-off-by: Bhaskar Chowdhury --- net/x25/af_x25.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/x25/af_x25.c b/net/x25/af_x25.c index ff687b97b2d9..44d6566dd23e 100644 --- a/net/x25/af_x25.c +++ b/net/x25/af_x25.c @@ -1018,7 +1018,7 @@ int x2

[PATCH] xfrm_user.c: Added a punctuation

2021-03-26 Thread Bhaskar Chowdhury
s/wouldnt/wouldn\'t/ Signed-off-by: Bhaskar Chowdhury --- net/xfrm/xfrm_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c index 5a0ef4361e43..df8bc8fc724c 100644 --- a/net/xfrm/xfrm_user.c +++ b/net/xfrm/xfrm_user.c @@ -1761,

[PATCH 02/19] xfrm_user.c: Added a punctuation

2021-03-26 Thread Bhaskar Chowdhury
s/wouldnt/wouldn\'t/ Signed-off-by: Bhaskar Chowdhury --- net/xfrm/xfrm_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c index 5a0ef4361e43..df8bc8fc724c 100644 --- a/net/xfrm/xfrm_user.c +++ b/net/xfrm/xfrm_user.c @@ -1761,7

[PATCH] sm_statefuns.c: Mundane spello fixes

2021-03-26 Thread Bhaskar Chowdhury
s/simulataneous/simultaneous/in three dirrent places. s/tempory/temporary/ s/interpeter/interpreter/ Signed-off-by: Bhaskar Chowdhury --- net/sctp/sm_statefuns.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefu

[PATCH] netfilter: nf_conntrack_acct.c: A typo fix

2021-03-26 Thread Bhaskar Chowdhury
s/Accouting/Accounting/ Signed-off-by: Bhaskar Chowdhury --- net/netfilter/nf_conntrack_acct.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/nf_conntrack_acct.c b/net/netfilter/nf_conntrack_acct.c index 2ccda8ace796..91bc8df3e4b0 100644 --- a/net/netfilter/nf

[PATCH] node.c: A typo fix

2021-03-26 Thread Bhaskar Chowdhury
s/synching/syncing/ Signed-off-by: Bhaskar Chowdhury --- net/tipc/node.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tipc/node.c b/net/tipc/node.c index 008670d1f43e..713550c16eba 100644 --- a/net/tipc/node.c +++ b/net/tipc/node.c @@ -2009,7 +2009,7 @@ static bool tip

[PATCH 01/19] xfrm_policy.c : Mundane typo fix

2021-03-26 Thread Bhaskar Chowdhury
s/sucessful/successful/ Signed-off-by: Bhaskar Chowdhury --- net/xfrm/xfrm_policy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c index b74f28cabe24..156347fd7e2e 100644 --- a/net/xfrm/xfrm_policy.c +++ b/net/xfrm/xfrm_policy.

[PATCH] netfilter: ipvs: A spello fix

2021-03-26 Thread Bhaskar Chowdhury
s/registerd/registered/ Signed-off-by: Bhaskar Chowdhury --- net/netfilter/ipvs/ip_vs_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/ipvs/ip_vs_core.c b/net/netfilter/ipvs/ip_vs_core.c index 0c132ff9b446..128690c512df 100644 --- a/net/netfilter/ipvs/ip_v

[PATCH] ncsi: internal.h: Fix a spello

2021-03-26 Thread Bhaskar Chowdhury
s/Firware/Firmware/ Signed-off-by: Bhaskar Chowdhury --- net/ncsi/internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ncsi/internal.h b/net/ncsi/internal.h index e37102546be6..49031f804276 100644 --- a/net/ncsi/internal.h +++ b/net/ncsi/internal.h @@ -100,7 +100,7

[PATCH] mptcp: subflow.c: Fix a typo

2021-03-26 Thread Bhaskar Chowdhury
s/concerened/concerned/ Signed-off-by: Bhaskar Chowdhury --- net/mptcp/subflow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c index 3d47d670e665..f1b6e4d0b95f 100644 --- a/net/mptcp/subflow.c +++ b/net/mptcp/subflow.c @@ -1076,7 +1

[PATCH] llc: llc_core.c: COuple of typo fixes

2021-03-26 Thread Bhaskar Chowdhury
s/searchs/searches/ two different places. Signed-off-by: Bhaskar Chowdhury --- net/llc/llc_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/llc/llc_core.c b/net/llc/llc_core.c index 64d4bef04e73..6e387aadffce 100644 --- a/net/llc/llc_core.c +++ b/net/llc/l

[PATCH] mac80211: cfg.c: A typo fix

2021-03-26 Thread Bhaskar Chowdhury
s/assocaited/associated/ Signed-off-by: Bhaskar Chowdhury --- net/mac80211/cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c index c4c70e30ad7f..62f2f356d401 100644 --- a/net/mac80211/cfg.c +++ b/net/mac80211/cfg.c @@ -1486,7 +1486,

[PATCH] kcm: kcmsock.c: Couple of typo fixes

2021-03-26 Thread Bhaskar Chowdhury
s/synchonization/synchronization/ s/aready/already/ Signed-off-by: Bhaskar Chowdhury --- net/kcm/kcmsock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/kcm/kcmsock.c b/net/kcm/kcmsock.c index d0b56ffbb057..6201965bd822 100644 --- a/net/kcm/kcmsock.c +++ b/net/kcm

[PATCH] ipv6: route.c: A spello fix

2021-03-26 Thread Bhaskar Chowdhury
s/notfication/notification/ Signed-off-by: Bhaskar Chowdhury --- net/ipv6/route.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 1536f4948e86..dfe5fb260e4c 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -6093,7 +6093,7 @@ vo

[PATCH] iucv: af_iucv.c: Couple of typo fixes

2021-03-26 Thread Bhaskar Chowdhury
s/unitialized/uninitialized/ s/notifcations/notifications/ Signed-off-by: Bhaskar Chowdhury --- net/iucv/af_iucv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c index 6092d5cb7168..0fdb389c3390 100644 --- a/net/iucv/af_iucv.c ++

[PATCH] ipv6: addrconf.c: Fix a typo

2021-03-26 Thread Bhaskar Chowdhury
s/Identifers/Identifiers/ Signed-off-by: Bhaskar Chowdhury --- net/ipv6/addrconf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index f2337fb756ac..8421f58ea6ea 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -2358,

[PATCH] ipv4: tcp_lp.c: Couple of typo fixes

2021-03-26 Thread Bhaskar Chowdhury
s/resrved/reserved/ s/within/within/ Signed-off-by: Bhaskar Chowdhury --- net/ipv4/tcp_lp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/tcp_lp.c b/net/ipv4/tcp_lp.c index e6459537d4d2..82b36ec3f2f8 100644 --- a/net/ipv4/tcp_lp.c +++ b/net/ipv4/tcp_lp.c @@ -63

[PATCH] af_x25.c: Fix a spello

2021-03-26 Thread Bhaskar Chowdhury
s/facilties/facilities/ Signed-off-by: Bhaskar Chowdhury --- net/x25/af_x25.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/x25/af_x25.c b/net/x25/af_x25.c index ff687b97b2d9..44d6566dd23e 100644 --- a/net/x25/af_x25.c +++ b/net/x25/af_x25.c @@ -1018,7 +1018,7 @@ int x2

[PATCH] ipv4: ip_output.c: Couple of typo fixes

2021-03-26 Thread Bhaskar Chowdhury
s/readibility/readability/ s/insufficent/insufficient/ Signed-off-by: Bhaskar Chowdhury --- net/ipv4/ip_output.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c index 3aab53beb4ea..c3efc7d658f6 100644 --- a/net/ipv4/ip_output.c

[PATCH] bearer.h: Spellos fixed

2021-03-26 Thread Bhaskar Chowdhury
s/initalized/initialized/ ...three different places Signed-off-by: Bhaskar Chowdhury --- net/tipc/bearer.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/tipc/bearer.h b/net/tipc/bearer.h index 6bf4550aa1ac..57c6a1a719e2 100644 --- a/net/tipc/bearer.h +++ b/net/tip

[PATCH 00/19] net: Trivial spello/typo fixes throughout the tree

2021-03-26 Thread Bhaskar Chowdhury
This is a patch series with all mundane/trivial/rudimentary typo/spello/ fixes in various files in the net subsystem. Bhaskar Chowdhury (19): xfrm_policy.c : Mundane typo fix xfrm_user.c: Added a punctuation af_x25.c: Fix a spello reg.c: Fix a spello node.c: A typo fix bearer.h: Spello

linux-next: Fixes tag needs some work in the net-next tree

2021-03-26 Thread Stephen Rothwell
Hi all, In commit 63c173ff7aa3 ("net: stmmac: Fix kernel panic due to NULL pointer dereference of fpe_cfg") Fixes tag Fixes: 5a5586112b92 ("net: stmmac: support FPE link partner hand-shaking has these problem(s): - Subject has leading but no trailing parentheses - Subject has leading

Re: [PATCH net-next 0/3] ethtool: fec: ioctl kdoc touch ups

2021-03-26 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 26 Mar 2021 13:22:20 -0700 you wrote: > A few touch ups from v1 review. > > Jakub Kicinski (3): > ethtool: fec: add note about reuse of reserved > ethtool: fec: fix FEC_NONE check > ethtool: document the enu

Re: [PATCH net-next] farsync: use DEFINE_SPINLOCK() for spinlock

2021-03-26 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 26 Mar 2021 20:31:38 +0800 you wrote: > From: Liu Jian > > spinlock can be initialized automatically with DEFINE_SPINLOCK() > rather than explicitly calling spin_lock_init(). > > Reported-by: Hulk Robot > Signed

Re: [PATCH net-next] net: stmmac: Fix kernel panic due to NULL pointer dereference of fpe_cfg

2021-03-26 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 26 Mar 2021 17:10:46 +0800 you wrote: > From: Mohammad Athari Bin Ismail > > In this patch, "net: stmmac: support FPE link partner hand-shaking > procedure", priv->plat->fpe_cfg wouldn`t be "devm_kzalloc"ed if > d

Re: [PATCH net-next v4 0/2] axienet clock additions

2021-03-26 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Thu, 25 Mar 2021 18:04:36 -0600 you wrote: > Add support to the axienet driver for controlling all of the clocks that > the logic core may utilize. > > Changed since v3: > -Added Acked-by to patch 1 > -Now applies to n

Re: [PATCH][next] ethtool: fec: Fix bitwise-and with ETHTOOL_FEC_NONE

2021-03-26 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 26 Mar 2021 14:27:33 + you wrote: > From: Colin Ian King > > Currently ETHTOOL_FEC_NONE_BIT is being used as a mask, however > this is zero and the mask should be using ETHTOOL_FEC_NONE instead. > Fix this. >

Re: [net-next] tipc: fix kernel-doc warnings

2021-03-26 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 26 Mar 2021 16:14:14 +0700 you wrote: > Fix kernel-doc warning introduced in > commit b83e214b2e04 ("tipc: add extack messages for bearer/media failure"): > > net/tipc/bearer.c:248: warning: Function parameter or m

Re: [PATCH net-next] net: ethernet: remove duplicated include

2021-03-26 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 26 Mar 2021 10:40:46 +0800 you wrote: > Remove duplicated include from mtk_ppe_offload.c. > > Reported-by: Hulk Robot > Signed-off-by: Xu Jia > --- > drivers/net/ethernet/mediatek/mtk_ppe_offload.c | 1 - > 1 fi

Re: [PATCH -next 0/3] net: llc: Correct some function names in header

2021-03-26 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 26 Mar 2021 18:13:47 +0800 you wrote: > Fix some make W=1 kernel build warnings in net/llc/ > > Yang Yingliang (3): > net: llc: Correct some function names in header > net: llc: Correct function name llc_sap_a

RE: [PATCH v2] eeprom/optoe: driver to read/write SFP/QSFP/CMIS EEPROMS

2021-03-26 Thread Don Bollinger
> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Friday, March 26, 2021 2:54 PM > To: Don Bollinger > Cc: 'Jakub Kicinski' ; ar...@arndb.de; > gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > brandon_chu...@edge-core.com; wally_w...@accton.com; > aken_

[PATCH] iwlwifi: mvm: fix memdup.cocci warnings

2021-03-26 Thread kernel test robot
From: kernel test robot drivers/net/wireless/intel/iwlwifi/mvm/rfi.c:110:8-15: WARNING opportunity for kmemdup Use kmemdup rather than duplicating its implementation Generated by: scripts/coccinelle/api/memdup.cocci Fixes: 21254908cbe9 ("iwlwifi: mvm: add RFI-M support") CC: Gregory Greenman

Re: [PATCH net-next 00/13] MPTCP: Cleanup and address advertisement fixes

2021-03-26 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 26 Mar 2021 11:23:07 -0700 you wrote: > This patch series contains cleanup and fixes we have been testing in the > MPTCP tree. MPTCP uses TCP option headers to advertise additional > address information after an in

Re: [net-next V2 01/13] net/mlx5e: alloc the correct size for indirection_rqt

2021-03-26 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Thu, 25 Mar 2021 19:53:33 -0700 you wrote: > From: Saeed Mahameed > > The cited patch allocated the wrong size for the indirection_rqt table, > fix that. > > Fixes: 2119bda642c4 ("net/mlx5e: allocate 'indirection_rqt

Re: [PATCH net-next 00/12] net: ipa: rework resource programming

2021-03-26 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 26 Mar 2021 10:11:10 -0500 you wrote: > This series reworks the way IPA resources are defined and > programmed. It is a little long--and I apologize for that--but > I think the patches are best taken together as a

Re: [PATCH net-next 0/9] net: hns3: add some cleanups

2021-03-26 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 26 Mar 2021 09:36:19 +0800 you wrote: > This series includes some cleanups for the HNS3 ethernet driver. > > Guojia Liao (1): > net: hns3: split out hclge_tm_vport_tc_info_update() > > Huazhong Tan (3): > net

Re: [PATCH] PCI: Remove pci_try_set_mwi

2021-03-26 Thread Bjorn Helgaas
On Fri, Mar 26, 2021 at 11:42:46PM +0200, Andy Shevchenko wrote: > On Fri, Mar 26, 2021 at 04:26:55PM -0500, Bjorn Helgaas wrote: > > [+cc Randy, Andrew (though I'm sure you have zero interest in this > > ancient question :))] > > > > On Wed, Dec 09, 2020 at 09:31:21AM +0100, Heiner Kallweit wrote

Re: [PATCH v2] eeprom/optoe: driver to read/write SFP/QSFP/CMIS EEPROMS

2021-03-26 Thread Andrew Lunn
> The only thing wrong I can see is that it doesn't use the kernel network > stack. Here's where "you keep missing the point". The kernel network stack > is not being used in these systems. Implementing EEPROM access through > ethtool is of course possible, but it is a lot of work with no benefi

Re: [PATCH net-next] docs: nf_flowtable: fix compilation and warnings

2021-03-26 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 25 Mar 2021 22:10:16 +0100 you wrote: > ... cannot be used in block quote, it breaks compilation, remove it. > > Fix warnings due to missing blank line such as: > > net-next/Documentation/networking/nf_flowtable.r

Re: [PATCH v2 net-next 0/5] net: stmmac: enable multi-vector MSI

2021-03-26 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Fri, 26 Mar 2021 01:39:11 +0800 you wrote: > This patchset adds support for multi MSI interrupts in addition to > current single common interrupt implementation. Each MSI interrupt is tied > to a newly introduce interru

Re: [PATCH net-next 0/5] net: use less storage for most sysctl

2021-03-26 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Thu, 25 Mar 2021 11:08:12 -0700 you wrote: > From: Eric Dumazet > > This patch series adds a new sysctl type, to allow using u8 instead of > "int" or "long int" types. > > Then we convert mosts sysctls found in struc

Re: [PATCH net-next v2 0/6] ethtool: clarify the ethtool FEC interface

2021-03-26 Thread David Miller
From: Jakub Kicinski Date: Thu, 25 Mar 2021 19:07:21 -0700 > Our FEC configuration interface is one of the more confusing. > It also lacks any error checking in the core. This certainly > shows in the varying implementations across the drivers. > > Improve the documentation and add most basic ch

Re: [PATCH] PCI: Remove pci_try_set_mwi

2021-03-26 Thread Andy Shevchenko
On Fri, Mar 26, 2021 at 04:26:55PM -0500, Bjorn Helgaas wrote: > [+cc Randy, Andrew (though I'm sure you have zero interest in this > ancient question :))] > > On Wed, Dec 09, 2020 at 09:31:21AM +0100, Heiner Kallweit wrote: > > pci_set_mwi() and pci_try_set_mwi() do exactly the same, just that th

Re: [PATCH] PCI: Remove pci_try_set_mwi

2021-03-26 Thread Bjorn Helgaas
[+cc Randy, Andrew (though I'm sure you have zero interest in this ancient question :))] On Wed, Dec 09, 2020 at 09:31:21AM +0100, Heiner Kallweit wrote: > pci_set_mwi() and pci_try_set_mwi() do exactly the same, just that the > former one is declared as __must_check. However also some callers of

  1   2   3   >