Re: Re: [PATCH v5 08/11] vduse: Implement an MMU-based IOMMU driver

2021-03-25 Thread Yongji Xie
On Fri, Mar 26, 2021 at 2:16 PM Jason Wang wrote: > > > 在 2021/3/26 下午1:14, Yongji Xie 写道: > > + } > + map->bounce_page = page; > + > + /* paired with vduse_domain_map_page() */ > + smp_mb(); > > So this is suspicious. It's better to explain like, we need make sure A > must be done

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-25 Thread Leon Romanovsky
On Thu, Mar 25, 2021 at 03:28:36PM -0300, Jason Gunthorpe wrote: > On Thu, Mar 25, 2021 at 01:20:21PM -0500, Bjorn Helgaas wrote: > > On Thu, Mar 25, 2021 at 02:36:46PM -0300, Jason Gunthorpe wrote: > > > On Thu, Mar 25, 2021 at 12:21:44PM -0500, Bjorn Helgaas wrote: > > > > > > > NVMe and mlx5 ha

RE: [PATCH v2 05/23] ice: Add devlink params support

2021-03-25 Thread Parav Pandit
> From: Saleem, Shiraz > Sent: Friday, March 26, 2021 1:40 AM > > Subject: RE: [PATCH v2 05/23] ice: Add devlink params support [..] > > > > Resources are better represented as devlink resource. > > Such as, > > > > $ devlink resource set pci/:06:00.0 /rdma/max_qps 16384 $ devlink > > reso

Re: kinldy see the V2 ..just sent [PATCH] fddi: skfp: Rudimentary spello fixes

2021-03-25 Thread Bhaskar Chowdhury
On 17:09 Thu 25 Mar 2021, David Miller wrote: From: Bhaskar Chowdhury Date: Thu, 25 Mar 2021 12:38:35 +0530 s/autohorized/authorized/ s/recsource/resource/ s/measuered/measured/ sauthoriziation/authorization/ Signed-off-by: Bhaskar Chowdhury Does not apply cleanly to net-next please respi

[PATCH V2] fddi: skfp: Rudimentary spello fixes

2021-03-25 Thread Bhaskar Chowdhury
s/autohorized/authorized/ s/recsource/resource/ s/measuered/measured/ s/authoriziation/authorization/ Signed-off-by: Bhaskar Chowdhury --- Changes from V1: David said the patch didn't applied cleanly,so recreate it. Randy found out a glitch in changelog text, fixed it. drivers/net/fddi/skf

Re: Re: [PATCH v5 08/11] vduse: Implement an MMU-based IOMMU driver

2021-03-25 Thread Yongji Xie
On Fri, Mar 26, 2021 at 12:27 PM Jason Wang wrote: > > > 在 2021/3/25 下午3:38, Yongji Xie 写道: > > On Thu, Mar 25, 2021 at 12:53 PM Jason Wang wrote: > >> > >> 在 2021/3/24 下午3:39, Yongji Xie 写道: > >>> On Wed, Mar 24, 2021 at 11:54 AM Jason Wang wrote: > 在 2021/3/15 下午1:37, Xie Yongji 写道: > >>>

Re: [PATCH bpf] bpf: link: refuse non-zero file_flags in BPF_OBJ_GET

2021-03-25 Thread Andrii Nakryiko
On Thu, Mar 25, 2021 at 8:22 AM Lorenz Bauer wrote: > > Invoking BPF_OBJ_GET on a pinned bpf_link checks the path access > permissions based on file_flags, but the returned fd ignores flags. > This means that any user can acquire a "read-write" fd for a pinned > link with mode 0664 by invoking BPF

Re: [PATCH bpf-next] libbpf: fix bail out from 'ringbuf_process_ring()' on error

2021-03-25 Thread Andrii Nakryiko
On Thu, Mar 25, 2021 at 8:02 AM Pedro Tammela wrote: > > The current code bails out with negative and positive returns. > If the callback returns a positive return code, 'ring_buffer__consume()' > and 'ring_buffer__poll()' will return a spurious number of records > consumed, but mostly important w

[PATCH v2 bpf-next] libbpf: preserve empty DATASEC BTFs during static linking

2021-03-25 Thread Andrii Nakryiko
Ensure that BPF static linker preserves all DATASEC BTF types, even if some of them might not have any variable information at all. This may happen if the compiler promotes local initialized variable contents into .rodata section and there are no global or static functions in the program. For exam

Re: [PATCH v5 08/11] vduse: Implement an MMU-based IOMMU driver

2021-03-25 Thread Jason Wang
在 2021/3/25 下午3:38, Yongji Xie 写道: On Thu, Mar 25, 2021 at 12:53 PM Jason Wang wrote: 在 2021/3/24 下午3:39, Yongji Xie 写道: On Wed, Mar 24, 2021 at 11:54 AM Jason Wang wrote: 在 2021/3/15 下午1:37, Xie Yongji 写道: This implements an MMU-based IOMMU driver to support mapping kernel dma buffer in

Re: [PATCH bpf-next] libbpf: preserve empty DATASEC BTFs during static linking

2021-03-25 Thread Andrii Nakryiko
On Thu, Mar 25, 2021 at 8:31 AM Yonghong Song wrote: > > > > On 3/24/21 10:11 PM, Andrii Nakryiko wrote: > > Ensure that BPF static linker preserves all DATASEC BTF types, even if some > > of > > them might not have any variable information at all. It's not completely > > clear > > in which case

Re: [PATCH bpf v2 2/2] bpf/selftests: test that kernel rejects a TCP CC with an invalid license

2021-03-25 Thread Andrii Nakryiko
On Thu, Mar 25, 2021 at 2:11 PM Toke Høiland-Jørgensen wrote: > > This adds a selftest to check that the verifier rejects a TCP CC struct_ops > with a non-GPL license. > > v2: > - Use a minimal struct_ops BPF program instead of rewriting bpf_dctcp's > license in memory. > - Check for the verifie

[PATCH] net:qrtr: fix allocator flag of idr_alloc_u32() in qrtr_port_assign()

2021-03-25 Thread Du Cheng
change the allocator flag of idr_alloc_u32 from GFP_ATOMIC to GFP_KERNEL, as GFP_ATOMIC caused BUG: "using smp_processor_id() in preemptible" as reported by syzkaller. Reported-by: syzbot+3eec59e770685e3dc...@syzkaller.appspotmail.com Signed-off-by: Du Cheng --- Hi David & Jakub, Although this i

Re: [bpf PATCH] bpf, selftests: test_maps generating unrecognized data section

2021-03-25 Thread Andrii Nakryiko
On Wed, Mar 24, 2021 at 2:07 PM John Fastabend wrote: > > With a relatively recent clang master branch test_map skips a section, > > libbpf: elf: skipping unrecognized data section(5) .rodata.str1.1 > So it was on my TODO list for a while to get rid of this by combining all .rodata* sections int

[net-next V2 13/13] net/mlx5: Fix spelling mistakes in mlx5_core_info message

2021-03-25 Thread Saeed Mahameed
From: Colin Ian King There are two spelling mistakes in a mlx5_core_info message. Fix them. Signed-off-by: Colin Ian King Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/health.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet

[net-next V2 12/13] net/mlx5e: Cleanup PTP

2021-03-25 Thread Saeed Mahameed
From: Aya Levin Reduce scope of mlx5e_ptp_params, move to its c file. Remove unneeded variables from mlx5e_ptp_open and state bitmap from PTP channel. In addition, remove channel index from PTP channel since it is set to a hard coded value, use define instead. Signed-off-by: Aya Levin Reviewed-

[net-next V2 10/13] net/mlx5e: Generalize direct-TIRs and direct-RQTs API

2021-03-25 Thread Saeed Mahameed
From: Aya Levin Add input parameter indicating the size of direct-TIRs/direct-RQTs array to be created/destroyed. This allows next patches in the patch-set to handle a single direct-TIR pointing to a direct-RQT with a single entry. Signed-off-by: Aya Levin Reviewed-by: Tariq Toukan Signed-off-

[net-next V2 09/13] net/mlx5e: Generalize close RQ

2021-03-25 Thread Saeed Mahameed
From: Aya Levin Allow different flavours of RQ to use the same close flow. Add validity checks to support different RQ types which not necessarily initialize all the RQ's functionality. Signed-off-by: Aya Levin Reviewed-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/

[net-next V2 06/13] net/mlx5: Add helper to set time-stamp translator on a queue

2021-03-25 Thread Saeed Mahameed
From: Aya Levin Translation method on the time-stamp is set by the capabilities. Avoid code duplication by using a helper to set ptp_cyc2time callback on a queue. Signed-off-by: Aya Levin Reviewed-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en/p

[net-next V2 08/13] net/mlx5e: Generalize RQ activation

2021-03-25 Thread Saeed Mahameed
From: Aya Levin Support RQ activation for RQs without an ICOSQ in the main flow, like existing trap-RQ and like PTP-RQ that will be introduced in the coming patches in the patchset. With this patch, remove the wrapper in traps to deactivate the trap-RQ. Signed-off-by: Aya Levin Reviewed-by: Tar

[net-next V2 11/13] net/mlx5e: Generalize PTP implementation

2021-03-25 Thread Saeed Mahameed
From: Aya Levin Following patches in the set add support for RX PTP. Rename PTP prefix from %s/port_ptp/ptp/g to include RX PTP too. In addition rename indication (used in statistics context) that PTP-SQ was opened: %s/port_ptp_opened/tx_ptp_opened/g. This will simplify adding indication that PT

[net-next V2 04/13] net/mlx5e: Restrict usage of mlx5e_priv in params logic functions

2021-03-25 Thread Saeed Mahameed
From: Tariq Toukan Do not use generic struct mlx5e_priv as a parameter to param functions, as it is too generic. All calculations of the channel's param should be mainly based on struct mlx5_core_dev and struct mlx5e_params. Additional info can be explicitly passed. Signed-off-by: Tariq Toukan

[net-next V2 07/13] net/mlx5e: Generalize open RQ

2021-03-25 Thread Saeed Mahameed
From: Aya Levin Unify RQ creation for different RQ types. For each RQ type add a separate open helper which initializes the RQ specific values and trigger a call for generic open RQ function. Avoid passing the mlx5e_channel pointer to the generic open RQ as a container, since the RQ may reside un

[net-next V2 05/13] net/mlx5e: Allow creating mpwqe info without channel

2021-03-25 Thread Saeed Mahameed
From: Aya Levin Change the signature of mlx5e_rq_alloc_mpwqe_info from receiving channel pointer to receive the NUMA node. This allows creating mpwqe_info in context of different channels types. Signed-off-by: Aya Levin Reviewed-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/

[net-next V2 03/13] net/mlx5e: Move params logic into its dedicated file

2021-03-25 Thread Saeed Mahameed
From: Tariq Toukan Take params logic out of en_main.c, into the dedicated params.c. Some functions are now hidden and become static. No functional change here. Signed-off-by: Tariq Toukan Reviewed-by: Maxim Mikityanskiy Reviewed-by: Aya Levin Signed-off-by: Saeed Mahameed --- drivers/net/et

[net-next V2 02/13] net/mlx5e: Pass q_counter indentifier as parameter to rq_param builders

2021-03-25 Thread Saeed Mahameed
From: Tariq Toukan Pass q_counter idintifier, instead of reading it from mlx5e_priv parameter. This is a step towards removing the mlx5e_priv parameter from all params function and logic in the next patches of the series. Signed-off-by: Tariq Toukan Reviewed-by: Aya Levin Signed-off-by: Saeed

[net-next V2 01/13] net/mlx5e: alloc the correct size for indirection_rqt

2021-03-25 Thread Saeed Mahameed
From: Saeed Mahameed The cited patch allocated the wrong size for the indirection_rqt table, fix that. Fixes: 2119bda642c4 ("net/mlx5e: allocate 'indirection_rqt' buffer dynamically") CC: Arnd Bergmann Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 4 ++--

[pull request][net-next V2 00/13] mlx5 updates 2021-03-24

2021-03-25 Thread Saeed Mahameed
From: Saeed Mahameed Hi Dave/Jakub, This series provides update to mlx5 netdev driver, mostly refactoring. v1->v2: - Remove inline keyword from static function in c file - Rebase on latest net-next For more information please see tag log below. Please pull and let me know if there i

[PATCH -next] mac80211: minstrel_ht: remove unused variable 'mg' in minstrel_ht_next_jump_rate()

2021-03-25 Thread Wei Yongjun
GCC reports the following warning with W=1: net/mac80211/rc80211_minstrel_ht.c:871:34: warning: variable 'mg' set but not used [-Wunused-but-set-variable] 871 | struct minstrel_mcs_group_data *mg; | ^~ This variable is not used in function , this commit

[PATCH net-next] net: ethernet: remove duplicated include

2021-03-25 Thread Xu Jia
Remove duplicated include from mtk_ppe_offload.c. Reported-by: Hulk Robot Signed-off-by: Xu Jia --- drivers/net/ethernet/mediatek/mtk_ppe_offload.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/mediatek/mtk_ppe_offload.c b/drivers/net/ethernet/mediatek/mtk_ppe_offload

RE: [Patch bpf-next v6 05/12] skmsg: use rcu work for destroying psock

2021-03-25 Thread John Fastabend
Cong Wang wrote: > From: Cong Wang > > The RCU callback sk_psock_destroy() only queues work psock->gc, > so we can just switch to rcu work to simplify the code. > > Cc: John Fastabend > Cc: Daniel Borkmann > Cc: Jakub Sitnicki > Cc: Lorenz Bauer > Signed-off-by: Cong Wang > --- Acked-by: J

RE: [Patch bpf-next v6 04/12] skmsg: avoid lock_sock() in sk_psock_backlog()

2021-03-25 Thread John Fastabend
Cong Wang wrote: > From: Cong Wang > > We do not have to lock the sock to avoid losing sk_socket, > instead we can purge all the ingress queues when we close > the socket. Sending or receiving packets after orphaning > socket makes no sense. > > We do purge these queues when psock refcnt reaches

[PATCH net-next v2 6/6] ethtool: clarify the ethtool FEC interface

2021-03-25 Thread Jakub Kicinski
The definition of the FEC driver interface is quite unclear. Improve the documentation. This is based on current driver and user space code, as well as the discussions about the interface: RFC v1 (24 Oct 2016): https://lore.kernel.org/netdev/1477363849-36517-1-git-send-email-vi...@cumulusnetwork

[PATCH net-next v2 5/6] ethtool: fec: sanitize ethtool_fecparam->fec

2021-03-25 Thread Jakub Kicinski
Reject NONE on set, this mode means device does not support FEC so it's a little out of place in the set interface. This should be safe to do - user space ethtool does not allow the use of NONE on set. A few drivers treat it the same as OFF, but none use it instead of OFF. Similarly reject an emp

[PATCH net-next v2 2/6] ethtool: fec: remove long structure description

2021-03-25 Thread Jakub Kicinski
Digging through the mailing list archive @autoneg was part of the first version of the RFC, this left over comment was pointed out twice in review but wasn't removed. The sentence is an exact copy-paste from pauseparam. Signed-off-by: Jakub Kicinski Reviewed-by: Andrew Lunn --- include/uapi/li

[PATCH net-next v2 4/6] ethtool: fec: sanitize ethtool_fecparam->active_fec

2021-03-25 Thread Jakub Kicinski
struct ethtool_fecparam::active_fec is a GET-only field, all in-tree drivers correctly ignore it on SET. Clear the field on SET to avoid any confusion. Again, we can't reject non-zero now since ethtool user space does not zero-init the param correctly. Signed-off-by: Jakub Kicinski Reviewed-by: A

[PATCH net-next v2 3/6] ethtool: fec: sanitize ethtool_fecparam->reserved

2021-03-25 Thread Jakub Kicinski
struct ethtool_fecparam::reserved is never looked at by the core. Make sure it's actually 0. Unfortunately we can't return an error because old ethtool doesn't zero-initialize the structure for SET. On GET we can be more verbose, there are no in tree (ab)users. Fix up the kdoc on the structure. Re

[PATCH net-next v2 0/6] ethtool: clarify the ethtool FEC interface

2021-03-25 Thread Jakub Kicinski
Our FEC configuration interface is one of the more confusing. It also lacks any error checking in the core. This certainly shows in the varying implementations across the drivers. Improve the documentation and add most basic checks. Sadly, it's probably too late now to try to enforce much more uni

[PATCH net-next v2 1/6] ethtool: fec: fix typo in kdoc

2021-03-25 Thread Jakub Kicinski
s/porte/the port/ Signed-off-by: Jakub Kicinski Reviewed-by: Andrew Lunn --- include/uapi/linux/ethtool.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h index cde753bb2093..1433d6278018 100644 --- a/include/uapi/li

[PATCH net-next 3/9] net: hns3: remove redundant query in hclge_config_tm_hw_err_int()

2021-03-25 Thread Huazhong Tan
From: Jiaran Zhang According to the HW manual, the query operation is unnecessary when the TM QCN error event is enabled, so remove it. Signed-off-by: Jiaran Zhang Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c | 8 +--- 1 file changed, 1 insertion(

[PATCH net-next 2/9] net: hns3: remove redundant blank lines

2021-03-25 Thread Huazhong Tan
From: Peng Li Remove some redundant blank lines. Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 7 --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c| 1 - drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.

[PATCH net-next 4/9] net: hns3: remove unused parameter from hclge_set_vf_vlan_common()

2021-03-25 Thread Huazhong Tan
From: Peng Li Parameter vf in hclge_set_vf_vlan_common() is unused now, so remove it. Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/h

[PATCH net-next 1/9] net: hns3: remove unused code of vmdq

2021-03-25 Thread Huazhong Tan
From: Jian Shen Vmdq is not supported yet, the num_vmdq_vport is always 0, it's a bit confusing when using the num_vport, so remove these unused codes of vmdq. Reported-by: Dan Carpenter Signed-off-by: Jian Shen Signed-off-by: Huazhong Tan --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd

[PATCH net-next 9/9] net: hns3: split out hclge_tm_vport_tc_info_update()

2021-03-25 Thread Huazhong Tan
From: Guojia Liao hclge_tm_vport_tc_info_update() is bloated, so split it into separate functions for readability and maintainability. Signed-off-by: Guojia Liao Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c | 11 +-- 1 file changed, 9 insertion

[PATCH net-next 7/9] net: hns3: fix some typos in hclge_main.c

2021-03-25 Thread Huazhong Tan
s/sucessful/successful/ s/serivce/service/ and remove a redundant new. Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/driv

[PATCH net-next 5/9] net: hns3: remove unused parameter from hclge_dbg_dump_loopback()

2021-03-25 Thread Huazhong Tan
Parameter cm_buf is never used, so remove it. Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c b/drivers/net/ethernet/his

[PATCH net-next 6/9] net: hns3: fix prototype warning

2021-03-25 Thread Huazhong Tan
Correct a report warning in hns3_ethtool.c Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c b/drivers/net/ethernet/hisilicon/hns3/hns3_ethtool

[PATCH net-next 8/9] net: hns3: split function hclge_reset_rebuild()

2021-03-25 Thread Huazhong Tan
From: Yufeng Mo hclge_reset_rebuild() is a bit too long. So add a new function hclge_update_reset_level() to improve readability. Signed-off-by: Yufeng Mo Signed-off-by: Huazhong Tan --- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 26 +- 1 file changed, 16 inserti

[PATCH net-next 0/9] net: hns3: add some cleanups

2021-03-25 Thread Huazhong Tan
This series includes some cleanups for the HNS3 ethernet driver. Guojia Liao (1): net: hns3: split out hclge_tm_vport_tc_info_update() Huazhong Tan (3): net: hns3: remove unused parameter from hclge_dbg_dump_loopback() net: hns3: fix prototype warning net: hns3: fix some typos in hclge_ma

Re: linux-next: build failure after merge of the bpf-next tree

2021-03-25 Thread Stephen Rothwell
Hi all, On Fri, 12 Mar 2021 12:00:14 +1100 Stephen Rothwell wrote: > > [Cc'ing a few (maybe) interested parties] > > On Thu, 11 Mar 2021 07:47:03 +0100 Björn Töpel wrote: > > > > On 2021-03-11 01:47, Stephen Rothwell wrote: > > > > > > After merging the bpf-next tree, today's linux-next bui

Re: [PATCH net-next] docs: nf_flowtable: fix compilation and warnings

2021-03-25 Thread Stephen Rothwell
Hi Pablo, On Thu, 25 Mar 2021 22:10:16 +0100 Pablo Neira Ayuso wrote: > > ... cannot be used in block quote, it breaks compilation, remove it. > > Fix warnings due to missing blank line such as: > > net-next/Documentation/networking/nf_flowtable.rst:142: WARNING: Block quote > ends without a

Re: [PATCH net 0/4][pull request] Intel Wired LAN Driver Updates 2021-03-25

2021-03-25 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Thu, 25 Mar 2021 15:31:15 -0700 you wrote: > This series contains updates to virtchnl header file and i40e driver. > > Norbert removes added padding from virtchnl RSS structures as this > causes issues when iterating over t

Re: [bpf PATCH 2/2] bpf, sockmap: fix incorrect fwd_alloc accounting

2021-03-25 Thread John Fastabend
Cong Wang wrote: > On Wed, Mar 24, 2021 at 7:46 PM John Fastabend > wrote: > > > > Cong Wang wrote: > > > On Wed, Mar 24, 2021 at 2:00 PM John Fastabend > > > wrote: > > > > > > > > Incorrect accounting fwd_alloc can result in a warning when the socket > > > > is torn down, > > > > > > > > [...

Re: [bpf PATCH 1/2] bpf, sockmap: fix sk->prot unhash op reset

2021-03-25 Thread John Fastabend
Cong Wang wrote: > On Wed, Mar 24, 2021 at 7:28 PM John Fastabend > wrote: > > > > Cong Wang wrote: > > > On Wed, Mar 24, 2021 at 1:59 PM John Fastabend > > > wrote: > > > > diff --git a/net/tls/tls_main.c b/net/tls/tls_main.c > > > > index 47b7c5334c34..ecb5634b4c4a 100644 > > > > --- a/net/tl

Re: [PATCH net] sch_red: fix off-by-one checks in red_check_params()

2021-03-25 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 25 Mar 2021 11:14:53 -0700 you wrote: > From: Eric Dumazet > > This fixes following syzbot report: > > UBSAN: shift-out-of-bounds in ./include/net/red.h:237:23 > shift exponent 32 is too large for 32-bit type 'unsigne

Re: [PATCH net 0/2] net: do not modify the shared tunnel info when PMTU triggers an ICMP reply

2021-03-25 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Thu, 25 Mar 2021 16:35:31 +0100 you wrote: > Hi, > > The series fixes an issue were a shared ip_tunnel_info is modified when > PMTU triggers an ICMP reply in vxlan and geneve, making following > packets in that flow to have

Re: [bpf PATCH] bpf, selftests: test_maps generating unrecognized data section

2021-03-25 Thread John Fastabend
Daniel Borkmann wrote: > On 3/24/21 10:07 PM, John Fastabend wrote: > > With a relatively recent clang master branch test_map skips a section, > > > > libbpf: elf: skipping unrecognized data section(5) .rodata.str1.1 > > > > the cause is some pointless strings from bpf_printks in the BPF progra

Re: [PATCH net-next] net: ethernet: mtk_eth_soc: remove unused variable 'count'

2021-03-25 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 25 Mar 2021 17:31:51 +0800 you wrote: > GCC reports the following warning with W=1: > > drivers/net/ethernet/mediatek/mtk_ppe_debugfs.c:80:9: warning: > variable 'count' set but not used [-Wunused-but-set-variable

Re: [PATCH net-next 0/6] net: ipa: update registers for other versions

2021-03-25 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Thu, 25 Mar 2021 09:44:31 -0500 you wrote: > This series updates IPA and GSI register definitions to permit more > versions of IPA hardware to be supported. Most of the updates are > informational, updating comments to

Re: [PATCH net] amd-xgbe: Update DMA coherency values

2021-03-25 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 25 Mar 2021 08:39:12 +0530 you wrote: > Based on the IOMMU configuration, the current cache control settings can > result in possible coherency issues. The hardware team has recommended > new settings for the PCI device

Re: [PATCH v2] net: axienet: allow setups without MDIO

2021-03-25 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 24 Mar 2021 14:05:36 +0100 you wrote: > In setups with fixed-link settings there is no mdio node in DTS. > axienet_probe() already handles that gracefully but lp->mii_bus is > then NULL. > > Fix code that tries to blind

Re: [PATCH net-next v2] net: change netdev_unregister_timeout_secs min value to 1

2021-03-25 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 25 Mar 2021 15:52:45 +0100 you wrote: > netdev_unregister_timeout_secs=0 can lead to printing the > "waiting for dev to become free" message every jiffy. > This is too frequent and unnecessary. > Set the min value t

Re: [PATCH] dt-bindings: net: micrel-ksz90x1.txt: correct documentation

2021-03-25 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 24 Mar 2021 08:52:19 -0500 you wrote: > Correct the Micrel phy documentation for the ksz9021 and ksz9031 phys > for how the phy skews are set. > > Signed-off-by: Dinh Nguyen > --- > .../bindings/net/micrel-ksz90x1.txt

Re: [PATCH resend 0/4] nfc: fix Resource leakage and endless loop

2021-03-25 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Thu, 25 Mar 2021 11:51:09 +0800 you wrote: > fix Resource leakage and endless loop in net/nfc/llcp_sock.c, > reported by "kiyin(尹亮)". > > Link: https://www.openwall.com/lists/oss-security/2020/11/01/1 > > Xiaoming Ni (4):

Re: [PATCH net] net: dsa: lantiq_gswip: Let GSWIP automatically set the xMII clock

2021-03-25 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 24 Mar 2021 20:36:04 +0100 you wrote: > The xMII interface clock depends on the PHY interface (MII, RMII, RGMII) > as well as the current link speed. Explicitly configure the GSWIP to > automatically select the appropria

Re: [PATCH] drivers: net: ethernet: struct sk_buff is declared duplicately

2021-03-25 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 25 Mar 2021 14:35:55 +0800 you wrote: > struct sk_buff has been declared. Remove the duplicate. > > Signed-off-by: Wan Jiabing > --- > drivers/net/ethernet/netronome/nfp/nfp_app.h | 1 - > 1 file changed, 1 delet

Re: [PATCH net-next] net: dsa: b53: spi: add missing MODULE_DEVICE_TABLE

2021-03-25 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 25 Mar 2021 17:19:54 +0800 you wrote: > This patch adds missing MODULE_DEVICE_TABLE definition which generates > correct modalias for automatic loading of this driver when it is built > as an external module. > > R

Re: [PATCH -next 0/5]Fix some typos

2021-03-25 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Thu, 25 Mar 2021 14:38:20 +0800 you wrote: > Lu Wei (5): > net: ceph: Fix a typo in osdmap.c > net: core: Fix a typo in dev_addr_lists.c > net: decnet: Fix a typo in dn_nsp_in.c > net: dsa: Fix a typo in tag_rtl

Re: [PATCH net-next] r8169: remove rtl_hw_start_8168c_3

2021-03-25 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 25 Mar 2021 10:31:39 +0100 you wrote: > We can simply use rtl_hw_start_8168c_2() also for chip version 21. > > Signed-off-by: Heiner Kallweit > --- > drivers/net/ethernet/realtek/r8169_main.c | 7 +-- > 1 fil

Re: [PATCH net-next 0/2] net: gve: make cleanup for gve

2021-03-25 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Thu, 25 Mar 2021 15:56:30 +0800 you wrote: > This patch set replace deprecated strlcpy by strscpy, remove > repeat word "allowed" in gve driver. > for more details, please refer to each patch. > > Daode Huang (2): >

Re: [PATCH bpf-next] libbpf: constify few bpf_program getters

2021-03-25 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Wed, 24 Mar 2021 10:29:41 -0700 you wrote: > bpf_program__get_type() and bpf_program__get_expected_attach_type() shouldn't > modify given bpf_program, so mark input parameter as const struct bpf_program. > This eliminates u

Re: [PATCH] fddi: skfp: Rudimentary spello fixes

2021-03-25 Thread David Miller
From: Bhaskar Chowdhury Date: Thu, 25 Mar 2021 12:38:35 +0530 > > s/autohorized/authorized/ > s/recsource/resource/ > s/measuered/measured/ > sauthoriziation/authorization/ > > Signed-off-by: Bhaskar Chowdhury Does not apply cleanly to net-next please respin. Thank you.

[PATCH net-next v4 1/2] dt-bindings: net: xilinx_axienet: Document additional clocks

2021-03-25 Thread Robert Hancock
Update DT bindings to describe all of the clocks that the axienet driver will now be able to make use of. Acked-by: Rob Herring Signed-off-by: Robert Hancock --- .../bindings/net/xilinx_axienet.txt | 25 ++- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git

[PATCH net-next v4 2/2] net: axienet: Enable more clocks

2021-03-25 Thread Robert Hancock
This driver was only enabling the first clock on the device, regardless of its name. However, this controller logic can have multiple clocks which should all be enabled. Add support for enabling additional clocks. The clock names used are matching those used in the Xilinx version of this driver as

[PATCH net-next v4 0/2] axienet clock additions

2021-03-25 Thread Robert Hancock
Add support to the axienet driver for controlling all of the clocks that the logic core may utilize. Changed since v3: -Added Acked-by to patch 1 -Now applies to net-next tree after earlier patches merged in - code unchanged from v3 Changed since v2: -Additional clock description clarification C

Re: [PATCH net-next] net: bcmgenet: remove unused including

2021-03-25 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 25 Mar 2021 11:29:32 +0800 you wrote: > From: Zheng Yongjun > > Remove including that don't need it. > > Reported-by: Hulk Robot > Signed-off-by: Zheng Yongjun > > [...] Here is the summary with links: - [

Re: [net-next] tipc: add extack messages for bearer/media failure

2021-03-25 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 25 Mar 2021 08:56:41 +0700 you wrote: > Add extack error messages for -EINVAL errors when enabling bearer, > getting/setting properties for a media/bearer > > Acked-by: Jon Maloy > Signed-off-by: Hoang Le > --- >

Re: [PATCH] net: Fix a misspell in socket.c

2021-03-25 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 25 Mar 2021 11:01:55 +0800 you wrote: > s/addres/address > > Reported-by: Hulk Robot > Signed-off-by: Lu Wei > --- > net/socket.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with

Re: [PATCH net-next] qede: remove unused including

2021-03-25 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 25 Mar 2021 11:29:28 +0800 you wrote: > From: Zheng Yongjun > > Remove including that don't need it. > > Reported-by: Hulk Robot > Signed-off-by: Zheng Yongjun > > [...] Here is the summary with links: - [

Re: [PATCH net-next] net: usb: lan78xx: remove unused including

2021-03-25 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 25 Mar 2021 10:51:08 +0800 you wrote: > From: Zheng Yongjun > > Remove including that don't need it. > > Reported-by: Hulk Robot > Signed-off-by: Zheng Yongjun > > [...] Here is the summary with links: - [

Re: [PATCH v3 net] net: dsa: only unset VLAN filtering when last port leaves last VLAN-aware bridge

2021-03-25 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 24 Mar 2021 11:56:39 +0200 you wrote: > From: Vladimir Oltean > > DSA is aware of switches with global VLAN filtering since the blamed > commit, but it makes a bad decision when multiple bridges are spanning > the same

Re: [net-next 05/15] net/mlx5e: Move params logic into its dedicated file

2021-03-25 Thread David Miller
From: Saeed Mahameed Date: Wed, 24 Mar 2021 22:04:28 -0700 > +static inline u8 mlx5e_get_rqwq_log_stride(u8 wq_type, int ndsegs) Please no inline in foo.c files. Thasnk you.

Re: [pull request][net-next 00/15] mlx5 updates 2021-03-24

2021-03-25 Thread David Miller
From: Saeed Mahameed Date: Wed, 24 Mar 2021 22:04:23 -0700 > From: Saeed Mahameed > > Hi Dave/Jakub, > > This series provides update to mlx5 netdev driver, mostly refactoring. > For more information please see tag log below. > > Please pull and let me know if there is any problem. Please res

Re: [RFC PATCH V5 net-next 0/5] ethtool: Extend module EEPROM dump API

2021-03-25 Thread Andrew Lunn
On Thu, Mar 25, 2021 at 04:56:50PM +0200, Moshe Shemesh wrote: > Ethtool supports module EEPROM dumps via the `ethtool -m ` command. > But in current state its functionality is limited - offset and length > parameters, which are used to specify a linear desired region of EEPROM > data to dump, is n

RE: [PATCH net-next] net: stmmac: support FPE link partner hand-shaking procedure

2021-03-25 Thread Wong, Vee Khee
_drm > stmmac rtc_meson_vrtc rng_core meson_canvas pwm_meson dw_hdmi > mdio_mux_meson_g12a pcs_xpcs snd_soc_meson_axg_tdm_interface > snd_soc_meson_axg_tdm_formatter nvmem_meson_efuse > display_connector >  CPU: 1 PID: 7 Comm: kworker/u8:0 Not tainted 5.12.0-rc4-next-20210325+ > #2747 >  Hardware name: H

Re: [PATCH v2 bpf-next 03/14] bpf: Support bpf program calling kernel function

2021-03-25 Thread Martin KaFai Lau
On Thu, Mar 25, 2021 at 11:02:23PM +0100, Toke Høiland-Jørgensen wrote: > Martin KaFai Lau writes: > > > This patch adds support to BPF verifier to allow bpf program calling > > kernel function directly. > > Hi Martin > > This is exciting stuff! :) > > Just one quick question about this: > >

Re: [PATCH bpf v2 2/2] bpf/selftests: test that kernel rejects a TCP CC with an invalid license

2021-03-25 Thread Martin KaFai Lau
On Thu, Mar 25, 2021 at 10:11:22PM +0100, Toke Høiland-Jørgensen wrote: > This adds a selftest to check that the verifier rejects a TCP CC struct_ops > with a non-GPL license. > > v2: > - Use a minimal struct_ops BPF program instead of rewriting bpf_dctcp's > license in memory. > - Check for the

[PATCH net 2/4] i40e: Added Asym_Pause to supported link modes

2021-03-25 Thread Tony Nguyen
From: Mateusz Palczewski Add Asym_Pause to supported link modes (it is supported by HW). Lack of Asym_Pause in supported modes can cause several problems, i.e. it won't be possible to turn the autonegotiation on with asymmetric pause settings (i.e. Tx on, Rx off). Fixes: 4e91bcd5d47a ("i40e: Fin

[PATCH net 4/4] i40e: Fix oops at i40e_rebuild()

2021-03-25 Thread Tony Nguyen
From: Arkadiusz Kubalewski Setup TC before the i40e_setup_pf_switch() call. Memory must be initialized for all the queues before using its resources. Previously it could be possible that a call: xdp_rxq_info_reg(&rx_ring->xdp_rxq, rx_ring->netdev, rx_ring->queue_index, rx_ring->q_vector->napi.na

[PATCH net 0/4][pull request] Intel Wired LAN Driver Updates 2021-03-25

2021-03-25 Thread Tony Nguyen
This series contains updates to virtchnl header file and i40e driver. Norbert removes added padding from virtchnl RSS structures as this causes issues when iterating over the arrays. Mateusz adds Asym_Pause as supported to allow these settings to be set as the hardware supports it. Eryk fixes an

[PATCH net 1/4] virtchnl: Fix layout of RSS structures

2021-03-25 Thread Tony Nguyen
From: Norbert Ciosek Remove padding from RSS structures. Previous layout could lead to unwanted compiler optimizations in loops when iterating over key and lut arrays. Fixes: 65ece6de0114 ("virtchnl: Add missing explicit padding to structures") Signed-off-by: Norbert Ciosek Tested-by: Konrad Ja

[PATCH net 3/4] i40e: Fix kernel oops when i40e driver removes VF's

2021-03-25 Thread Tony Nguyen
From: Eryk Rybak Fix the reason of kernel oops when i40e driver removed VFs. Added new __I40E_VFS_RELEASING state to signalize releasing process by PF, that it makes possible to exit of reset VF procedure. Without this patch, it is possible to suspend the VFs reset by releasing VFs resources proc

Re: [PATCH v2 bpf-next 03/14] bpf: Support bpf program calling kernel function

2021-03-25 Thread Toke Høiland-Jørgensen
Martin KaFai Lau writes: > This patch adds support to BPF verifier to allow bpf program calling > kernel function directly. Hi Martin This is exciting stuff! :) Just one quick question about this: > [ For the future calling function-in-kernel-module support, an array > of module btf_fds can

udp: Add support for getsockopt(..., ..., UDP_GRO, ..., ...);

2021-03-25 Thread Norman Maurer
Support for UDP_GRO was added in the past but the implementation for getsockopt was missed which did lead to an error when we tried to retrieve the setting for UDP_GRO. This patch adds the missing switch case for UDP_GRO Fixes: e20cf8d3f1f7 ("udp: implement GRO for plain UDP sockets.") Signed-off-

Re: [PATCHv2] bpf: Take module reference for trampoline in module

2021-03-25 Thread Jiri Olsa
On Thu, Mar 25, 2021 at 10:26:32PM +0100, Daniel Borkmann wrote: > On 3/24/21 6:40 PM, Jiri Olsa wrote: > > Currently module can be unloaded even if there's a trampoline > > register in it. It's easily reproduced by running in parallel: > > > ># while :; do ./test_progs -t module_attach; done

Re: [PATCHv2] bpf: Take module reference for trampoline in module

2021-03-25 Thread Daniel Borkmann
On 3/24/21 6:40 PM, Jiri Olsa wrote: Currently module can be unloaded even if there's a trampoline register in it. It's easily reproduced by running in parallel: # while :; do ./test_progs -t module_attach; done # while :; do rmmod bpf_testmod; sleep 0.5; done Taking the module reference

[PATCH bpf v2 2/2] bpf/selftests: test that kernel rejects a TCP CC with an invalid license

2021-03-25 Thread Toke Høiland-Jørgensen
This adds a selftest to check that the verifier rejects a TCP CC struct_ops with a non-GPL license. v2: - Use a minimal struct_ops BPF program instead of rewriting bpf_dctcp's license in memory. - Check for the verifier reject message instead of just the return code. Signed-off-by: Toke Høiland

[PATCH bpf v2 1/2] bpf: enforce that struct_ops programs be GPL-only

2021-03-25 Thread Toke Høiland-Jørgensen
With the introduction of the struct_ops program type, it became possible to implement kernel functionality in BPF, making it viable to use BPF in place of a regular kernel module for these particular operations. Thus far, the only user of this mechanism is for implementing TCP congestion control a

[PATCH net-next] docs: nf_flowtable: fix compilation and warnings

2021-03-25 Thread Pablo Neira Ayuso
... cannot be used in block quote, it breaks compilation, remove it. Fix warnings due to missing blank line such as: net-next/Documentation/networking/nf_flowtable.rst:142: WARNING: Block quote ends without a blank line; unexpected unindent. Fixes: 143490cde566 ("docs: nf_flowtable: update docu

Re: [bpf PATCH] bpf, selftests: test_maps generating unrecognized data section

2021-03-25 Thread Daniel Borkmann
On 3/24/21 10:07 PM, John Fastabend wrote: With a relatively recent clang master branch test_map skips a section, libbpf: elf: skipping unrecognized data section(5) .rodata.str1.1 the cause is some pointless strings from bpf_printks in the BPF program loaded during testing. Remove them so we

  1   2   3   4   >