Re: [PATCH net-next] Revert "net: dsa: sja1105: Clear VLAN filtering offload netdev feature"

2021-03-20 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sun, 21 Mar 2021 01:04:45 +0200 you wrote: > From: Vladimir Oltean > > This reverts commit e9bf96943b408e6c99dd13fb01cb907335787c61. > > The topic of the reverted patch is the support for switches with global > VLAN f

Re: [PATCH net-next] r8169: add support for ethtool get_ringparam

2021-03-20 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 20 Mar 2021 23:14:28 +0100 you wrote: > Add support for the ethtool get_ringparam operation. > > Signed-off-by: Heiner Kallweit > --- > drivers/net/ethernet/realtek/r8169_main.c | 10 ++ > 1 file changed,

Re: [PATCH v3 net-next 12/12] net: ocelot: replay switchdev events when joining bridge

2021-03-20 Thread kernel test robot
Hi Vladimir, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Vladimir-Oltean/Better-support-for-sandwiched-LAGs-with-bridge-and-DSA/20210321-063842 base: https://git.kernel.org/pub/scm/linux/kernel/git/da

Re: [PATCH net] r8169: fix DMA being used after buffer free if WoL is enabled

2021-03-20 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Sat, 20 Mar 2021 21:40:08 +0100 you wrote: > IOMMU errors have been reported if WoL is enabled and interface is > brought down. It turned out that the network chip triggers DMA > transfers after the DMA buffers have been free

Re: pull-request: can 2021-03-20

2021-03-20 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net.git (refs/heads/master): On Sat, 20 Mar 2021 20:37:06 +0100 you wrote: > Hello Jakub, hello David, > > this is a pull request of 2 patches for net/master. > > The first patch is by Oliver Hartkopp. He fixes the TX-path in the > ISO-TP protocol

Re: [PATCH net-next 0/5] net: ipa: more configuration data updates

2021-03-20 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Sat, 20 Mar 2021 10:57:02 -0500 you wrote: > This series starts with two patches that should have been included > in an earlier series. With these in place, QSB settings are > programmed from information found in the d

Re: [PATCH] net: decnet: Fixed multiple coding style issues

2021-03-20 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Sat, 20 Mar 2021 11:45:12 +0530 you wrote: > Made changes to coding style as suggested by checkpatch.pl > changes are of the type: > open brace '{' following struct go on the same line > do not use assignment

Re: [PATCH] perf evlist: Mundane typo fix

2021-03-20 Thread Randy Dunlap
On Sun, 21 Mar 2021, Bhaskar Chowdhury wrote: s/explicitely/explicitly/ Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap --- tools/perf/builtin-top.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index 36

Re: [PATCH] perf tools: Rudimentary typo fix

2021-03-20 Thread Randy Dunlap
On Sun, 21 Mar 2021, Bhaskar Chowdhury wrote: s/archictures/architectures/ Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap --- tools/perf/builtin-stat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c in

Re: [PATCH net-next] dsa: simplify Kconfig symbols and dependencies

2021-03-20 Thread Florian Fainelli
On 3/19/2021 8:46 AM, Alexander Lobakin wrote: > 1. Remove CONFIG_HAVE_NET_DSA. > > CONFIG_HAVE_NET_DSA is a legacy leftover from the times when drivers > should have selected CONFIG_NET_DSA manually. > Currently, all drivers has explicit 'depends on NET_DSA', so this is > no more needed. > >

Re: [PATCH v3 net-next 10/12] net: dsa: replay VLANs installed on port when joining the bridge

2021-03-20 Thread kernel test robot
Hi Vladimir, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Vladimir-Oltean/Better-support-for-sandwiched-LAGs-with-bridge-and-DSA/20210321-063842 base: https://git.kernel.org/pub/scm/linux/kernel/git/da

[PATCH] perf evlist: Mundane typo fix

2021-03-20 Thread Bhaskar Chowdhury
s/explicitely/explicitly/ Signed-off-by: Bhaskar Chowdhury --- tools/perf/builtin-top.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index 3673c04d16b6..173ace43f845 100644 --- a/tools/perf/builtin-top.c +++ b/tools/per

Re: [PATCH net-next] dsa: simplify Kconfig symbols and dependencies

2021-03-20 Thread Vladimir Oltean
On Fri, Mar 19, 2021 at 03:46:30PM +, Alexander Lobakin wrote: > 1. Remove CONFIG_HAVE_NET_DSA. > > CONFIG_HAVE_NET_DSA is a legacy leftover from the times when drivers > should have selected CONFIG_NET_DSA manually. > Currently, all drivers has explicit 'depends on NET_DSA', so this is > no mo

Re: [PATCH v3 net-next 03/12] net: dsa: inherit the actual bridge port flags at join time

2021-03-20 Thread kernel test robot
Hi Vladimir, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Vladimir-Oltean/Better-support-for-sandwiched-LAGs-with-bridge-and-DSA/20210321-063842 base: https://git.kernel.org/pub/scm/linux/kernel/

[PATCH] perf tools: Rudimentary typo fix

2021-03-20 Thread Bhaskar Chowdhury
s/archictures/architectures/ Signed-off-by: Bhaskar Chowdhury --- tools/perf/builtin-stat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index 2e2e4a8345ea..5cc5eeae6ade 100644 --- a/tools/perf/builtin-stat.c +++ b/to

[PATCH] ipv4/raw: support binding to nonlocal addresses

2021-03-20 Thread Riccardo Paolo Bestetti
Add support to inet raw sockets for binding to nonlocal addresses through the IP_FREEBIND and IP_TRANSPARENT socket options, as well as the ipv4.ip_nonlocal_bind kernel parameter. Signed-off-by: Riccardo Paolo Bestetti --- net/ipv4/raw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

Re: [PATCH v3 net-next 03/12] net: dsa: inherit the actual bridge port flags at join time

2021-03-20 Thread kernel test robot
Hi Vladimir, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Vladimir-Oltean/Better-support-for-sandwiched-LAGs-with-bridge-and-DSA/20210321-063842 base: https://git.kernel.org/pub/scm/linux/kernel/

[PATCH net-next] Revert "net: dsa: sja1105: Clear VLAN filtering offload netdev feature"

2021-03-20 Thread Vladimir Oltean
From: Vladimir Oltean This reverts commit e9bf96943b408e6c99dd13fb01cb907335787c61. The topic of the reverted patch is the support for switches with global VLAN filtering, added by commit 061f6a505ac3 ("net: dsa: Add ndo_vlan_rx_{add, kill}_vid implementation"). Be there a switch with 4 ports sw

[PATCH v2 net 3/3] net: dsa: let drivers state that they need VLAN filtering while standalone

2021-03-20 Thread Vladimir Oltean
From: Vladimir Oltean As explained in the blamed patch, the hellcreek driver uses some tricks to comply with the network stack expectations: it enforces port separation in standalone mode using VLANs. For untagged traffic, bridging between ports is prevented by using different PVIDs, and for VLAN

[PATCH v2 net 2/3] net: dsa: don't advertise 'rx-vlan-filter' if VLAN filtering not global

2021-03-20 Thread Vladimir Oltean
From: Vladimir Oltean The blamed patch has removed the driver's ability to return -EOPNOTSUPP in the .port_vlan_add method when called from .ndo_vlan_rx_add_vid (unmassaged by DSA, -EOPNOTSUPP is a hard error for vlan_vid_add). But we have not managed well enough the cases under which .port_vlan_

[PATCH v2 net 0/3] Clear rx-vlan-filter feature in DSA when necessary

2021-03-20 Thread Vladimir Oltean
From: Vladimir Oltean Patches 2 and 3 address the problems raised by Tobias here: https://patchwork.kernel.org/project/netdevbpf/cover/20210308150405.3694678-1-tob...@waldekranz.com/ The key difference compared to Tobias' patch is that his approach makes dsa_slave_vlan_rx_add_vid accept -EOPNOTS

[PATCH v2 net 1/3] net: dsa: only unset VLAN filtering when last port leaves last VLAN-aware bridge

2021-03-20 Thread Vladimir Oltean
From: Vladimir Oltean DSA is aware of switches with global VLAN filtering since the blamed commit, but it makes a bad decision when multiple bridges are spanning the same switch: ip link add br0 type bridge vlan_filtering 1 ip link add br1 type bridge vlan_filtering 1 ip link set swp2 master br0

Re: [PATCH v2 1/1] io_uring: call req_set_fail_links() on short send[msg]()/recv[msg]() with MSG_WAITALL

2021-03-20 Thread Jens Axboe
On 3/20/21 1:33 PM, Stefan Metzmacher wrote: > Without that it's not safe to use them in a linked combination with > others. > > Now combinations like IORING_OP_SENDMSG followed by IORING_OP_SPLICE > should be possible. > > We already handle short reads and writes for the following opcodes: > >

Re: [PATCH] docs: networking: Fix a typo

2021-03-20 Thread Randy Dunlap
On Sun, 21 Mar 2021, Bhaskar Chowdhury wrote: s/subsytem/subsystem/ Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap --- Documentation/networking/xfrm_device.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/networking/xfrm_device.rst b/Docu

[PATCH v3 net-next 12/12] net: ocelot: replay switchdev events when joining bridge

2021-03-20 Thread Vladimir Oltean
From: Vladimir Oltean The premise of this change is that the switchdev port attributes and objects offloaded by ocelot might have been missed when we are joining an already existing bridge port, such as a bonding interface. The patch pulls these switchdev attributes and objects from the bridge,

[PATCH v3 net-next 10/12] net: dsa: replay VLANs installed on port when joining the bridge

2021-03-20 Thread Vladimir Oltean
From: Vladimir Oltean Currently this simple setup: ip link add br0 type bridge vlan_filtering 1 ip link add bond0 type bond ip link set bond0 master br0 ip link set swp0 master bond0 will not work because the bridge has created the PVID in br_add_if -> nbp_vlan_init, and it has notified switchd

[PATCH v3 net-next 08/12] net: dsa: replay port and host-joined mdb entries when joining the bridge

2021-03-20 Thread Vladimir Oltean
From: Vladimir Oltean I have udhcpcd in my system and this is configured to bring interfaces up as soon as they are created. I create a bridge as follows: ip link add br0 type bridge As soon as I create the bridge and udhcpcd brings it up, I also have avahi which automatically starts sending I

[PATCH v3 net-next 11/12] net: ocelot: call ocelot_netdevice_bridge_join when joining a bridged LAG

2021-03-20 Thread Vladimir Oltean
From: Vladimir Oltean Similar to the DSA situation, ocelot supports LAG offload but treats this scenario improperly: ip link add br0 type bridge ip link add bond0 type bond ip link set bond0 master br0 ip link set swp0 master bond0 We do the same thing as we do there, which is to simulate a 'br

[PATCH v3 net-next 06/12] net: dsa: sync multicast router state when joining the bridge

2021-03-20 Thread Vladimir Oltean
From: Vladimir Oltean Make sure that the multicast router setting of the bridge is picked up correctly by DSA when joining, regardless of whether there are sandwiched interfaces or not. The SWITCHDEV_ATTR_ID_BRIDGE_MROUTER port attribute is only emitted from br_mc_router_state_change. Signed-off

[PATCH v3 net-next 09/12] net: dsa: replay port and local fdb entries when joining the bridge

2021-03-20 Thread Vladimir Oltean
From: Vladimir Oltean When a DSA port joins a LAG that already had an FDB entry pointing to it: ip link set bond0 master br0 bridge fdb add dev bond0 00:01:02:03:04:05 master static ip link set swp0 master bond0 the DSA port will have no idea that this FDB entry is there, because it missed the

[PATCH v3 net-next 07/12] net: dsa: sync ageing time when joining the bridge

2021-03-20 Thread Vladimir Oltean
From: Vladimir Oltean The SWITCHDEV_ATTR_ID_BRIDGE_AGEING_TIME attribute is only emitted from: sysfs/ioctl/netlink -> br_set_ageing_time -> __set_ageing_time therefore not at bridge port creation time, so: (a) drivers had to hardcode the initial value for the address ageing time, because

[PATCH v3 net-next 04/12] net: dsa: sync up with bridge port's STP state when joining

2021-03-20 Thread Vladimir Oltean
From: Vladimir Oltean It may happen that we have the following topology: ip link add br0 type bridge stp_state 1 ip link add bond0 type bond ip link set bond0 master br0 ip link set swp0 master bond0 ip link set swp1 master bond0 STP decides that it should put bond0 into the BLOCKING state, and

[PATCH v3 net-next 05/12] net: dsa: sync up VLAN filtering state when joining the bridge

2021-03-20 Thread Vladimir Oltean
From: Vladimir Oltean This is the same situation as for other switchdev port attributes: if we join an already-created bridge port, such as a bond master interface, then we can miss the initial switchdev notification emitted by the bridge for this port. Signed-off-by: Vladimir Oltean Reviewed-b

[PATCH v3 net-next 02/12] net: dsa: pass extack to dsa_port_{bridge,lag}_join

2021-03-20 Thread Vladimir Oltean
From: Vladimir Oltean This is a pretty noisy change that was broken out of the larger change for replaying switchdev attributes and objects at bridge join time, which is when these extack objects are actually used. Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli --- Changes in v3:

[PATCH v3 net-next 03/12] net: dsa: inherit the actual bridge port flags at join time

2021-03-20 Thread Vladimir Oltean
From: Vladimir Oltean DSA currently assumes that the bridge port starts off with this constellation of bridge port flags: - learning on - unicast flooding on - multicast flooding on - broadcast flooding on just by virtue of code copy-pasta from the bridge layer (new_nbp). This was a simple enou

[PATCH v3 net-next 01/12] net: dsa: call dsa_port_bridge_join when joining a LAG that is already in a bridge

2021-03-20 Thread Vladimir Oltean
From: Vladimir Oltean DSA can properly detect and offload this sequence of operations: ip link add br0 type bridge ip link add bond0 type bond ip link set swp0 master bond0 ip link set bond0 master br0 But not this one: ip link add br0 type bridge ip link add bond0 type bond ip link set bond0

[PATCH v3 net-next 00/12] Better support for sandwiched LAGs with bridge and DSA

2021-03-20 Thread Vladimir Oltean
From: Vladimir Oltean The objective of this series is to make LAG uppers on top of switchdev ports work regardless of which order we link interfaces to their masters (first make the port join the LAG, then the LAG join the bridge, or the other way around). There was a design decision to be made

[PATCH net-next] r8169: add support for ethtool get_ringparam

2021-03-20 Thread Heiner Kallweit
Add support for the ethtool get_ringparam operation. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169_main.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index 0d7001303

[PATCH] docs: networking: Fix a typo

2021-03-20 Thread Bhaskar Chowdhury
s/subsytem/subsystem/ Signed-off-by: Bhaskar Chowdhury --- Documentation/networking/xfrm_device.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/networking/xfrm_device.rst b/Documentation/networking/xfrm_device.rst index da1073acda96..01391dfd37d9 100644 -

[PATCH net] r8169: fix DMA being used after buffer free if WoL is enabled

2021-03-20 Thread Heiner Kallweit
IOMMU errors have been reported if WoL is enabled and interface is brought down. It turned out that the network chip triggers DMA transfers after the DMA buffers have been freed. For WoL to work we need to leave rx enabled, therefore simply stop the chip from being a DMA busmaster. Fixes: 567ca57f

rfc5837 and rfc8335

2021-03-20 Thread David Ahern
On 3/19/21 10:24 PM, David Ahern wrote: > At the end of the day, what is the value of this feature vs the other > ICMP probing set? Merging the conversations about both of these RFCs since my comments and questions are the same for both. What is the motivation for adding support for these RFCs? I

Re: [PATCH] rtlwifi: Few mundane typo fixes

2021-03-20 Thread Randy Dunlap
On Sun, 21 Mar 2021, Bhaskar Chowdhury wrote: s/resovle/resolve/ s/broadcase/broadcast/ s/sytem/system/ Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap --- drivers/net/wireless/realtek/rtlwifi/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dri

[PATCH] rtlwifi: Few mundane typo fixes

2021-03-20 Thread Bhaskar Chowdhury
s/resovle/resolve/ s/broadcase/broadcast/ s/sytem/system/ Signed-off-by: Bhaskar Chowdhury --- drivers/net/wireless/realtek/rtlwifi/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c b/drivers/net/wireless/realtek/rtlwi

Re: linux-next: manual merge of the net tree with Linus' tree

2021-03-20 Thread Linus Torvalds
On Sat, Mar 20, 2021 at 12:28 PM Marc Kleine-Budde wrote: > > Good idea. I'll send a pull request to David and Jakub. I don't think the revert is necessary. The conflict is so trivial that it doesn't really matter. Conflicts like this that are local and obvious aren't really problematic. Any mai

[net 1/2] can: isotp: tx-path: zero initialize outgoing CAN frames

2021-03-20 Thread Marc Kleine-Budde
From: Oliver Hartkopp Commit d4eb538e1f48 ("can: isotp: TX-path: ensure that CAN frame flags are initialized") ensured the TX flags to be properly set for outgoing CAN frames. In fact the root cause of the issue results from a missing initialization of outgoing CAN frames created by isotp. This

[net 2/2] can: peak_usb: Revert "can: peak_usb: add forgotten supported devices"

2021-03-20 Thread Marc Kleine-Budde
In commit 6417f03132a6 ("module: remove never implemented MODULE_SUPPORTED_DEVICE") the MODULE_SUPPORTED_DEVICE macro was removed from the kerne entirely. Shortly before this patch was applied mainline the commit 59ec7b89ed3e ("can: peak_usb: add forgotten supported devices") was added to net/maste

pull-request: can 2021-03-20

2021-03-20 Thread Marc Kleine-Budde
el.org/pub/scm/linux/kernel/git/mkl/linux-can.git tags/linux-can-fixes-for-5.12-20210320 for you to fetch changes up to 5d7047ed6b7214fbabc16d8712a822e256b1aa44: can: peak_usb: Revert "can: peak_usb: add forgotten supported devices" (2021-

[PATCH v2 1/1] io_uring: call req_set_fail_links() on short send[msg]()/recv[msg]() with MSG_WAITALL

2021-03-20 Thread Stefan Metzmacher
Without that it's not safe to use them in a linked combination with others. Now combinations like IORING_OP_SENDMSG followed by IORING_OP_SPLICE should be possible. We already handle short reads and writes for the following opcodes: - IORING_OP_READV - IORING_OP_READ_FIXED - IORING_OP_READ - IOR

Re: linux-next: manual merge of the net tree with Linus' tree

2021-03-20 Thread Marc Kleine-Budde
On 3/19/21 4:55 PM, Leon Romanovsky wrote: > On Fri, Mar 19, 2021 at 08:29:39AM +1100, Stephen Rothwell wrote: >> Hi all, >> >> Today's linux-next merge of the net tree got a conflict in: >> >> drivers/net/can/usb/peak_usb/pcan_usb_fd.c >> >> between commit: >> >> 6417f03132a6 ("module: remove

Re: [PATCH v2 2/3] net: ethernet: actions: Add Actions Semi Owl Ethernet MAC driver

2021-03-20 Thread kernel test robot
Hi Cristian, Thank you for the patch! Yet something to improve: [auto build test ERROR on robh/for-next] [also build test ERROR on net-next/master net/master linus/master sparc-next/master v5.12-rc3 next-20210319] [If your patch is applied to the wrong git tree, kindly drop us a note. And when s

Re: [PATCH v1] Bluetooth: Add ncmd=0 recovery handling

2021-03-20 Thread Marcel Holtmann
Hi Manish, > During command status or command complete event, the controller may set > ncmd=0 indicating that it is not accepting any more commands. In such a > case, host holds off sending any more commands to the controller. If the > controller doesn't recover from such condition, host will wait

Re: Fwd: netdevice.7 SIOCGIFFLAGS/SIOCSIFFLAGS

2021-03-20 Thread Oliver Hartkopp
Hi Alejandro, we added IFF_ECHO these days on suggestion of Dave Miller - and the IFF_LOWER_UP/IFF_DORMANT were already there at that time. I don't know if there ioctls are still used for retrieving these flags as I assume this is done via netlink interface today. At least there is enough s

Re: [PATCH bpf-next 02/15] bpf: btf: Support parsing extern func

2021-03-20 Thread Andrii Nakryiko
On Fri, Mar 19, 2021 at 5:13 PM Martin KaFai Lau wrote: > > On Fri, Mar 19, 2021 at 04:02:27PM -0700, Andrii Nakryiko wrote: > > On Fri, Mar 19, 2021 at 3:45 PM Martin KaFai Lau wrote: > > > > > > On Fri, Mar 19, 2021 at 03:29:57PM -0700, Andrii Nakryiko wrote: > > > > On Fri, Mar 19, 2021 at 3:1

Re: [PATCH bpf-next 03/15] bpf: Refactor btf_check_func_arg_match

2021-03-20 Thread Andrii Nakryiko
On Fri, Mar 19, 2021 at 5:10 PM Alexei Starovoitov wrote: > > On 3/19/21 2:51 PM, Andrii Nakryiko wrote: > > > > It's a matter of taste, I suppose. I'd probably disagree with you on > > the readability of those verifier parts ;) So it's up to you, of > > course, but for me this code pattern: > > >

Re: [PATCH bpf-next 3/3] selftests/bpf: allow compiling BPF objects without BTF

2021-03-20 Thread Andrii Nakryiko
On Fri, Mar 19, 2021 at 7:22 PM Alexei Starovoitov wrote: > > On Fri, Mar 19, 2021 at 01:59:09PM -0700, Andrii Nakryiko wrote: > > Add ability to skip BTF generation for some BPF object files. This is done > > through using a convention of .nobtf.c file name suffix. > > > > Also add third statical

Re: [PATCH V4 net-next 5/5] icmp: add response to RFC 8335 PROBE messages

2021-03-20 Thread David Ahern
On 3/20/21 10:01 AM, Andreas Roeseler wrote: > On Wed, 2021-03-17 at 21:24 -0600, David Ahern wrote: >> On 3/17/21 9:19 PM, David Miller wrote: >>> From: Andreas Roeseler >>> Date: Wed, 17 Mar 2021 22:11:47 -0500 >>> On Mon, 2021-03-15 at 04:35 +0800, kernel test robot wrote: Is there so

Re: [PATCH v2] eeprom/optoe: driver to read/write SFP/QSFP/CMIS EEPROMS

2021-03-20 Thread Pali Rohár
Hello Don! I have read whole discussion and your EEPROM patch proposal. But for me it looks like some kernel glue code for some old legacy / proprietary access method which does not have any usage outside of that old code. Your code does not contain any quirks which are needed to read different E

Re: [PATCH V4 net-next 5/5] icmp: add response to RFC 8335 PROBE messages

2021-03-20 Thread Andreas Roeseler
On Wed, 2021-03-17 at 21:24 -0600, David Ahern wrote: > On 3/17/21 9:19 PM, David Miller wrote: > > From: Andreas Roeseler > > Date: Wed, 17 Mar 2021 22:11:47 -0500 > > > > > On Mon, 2021-03-15 at 04:35 +0800, kernel test robot wrote: > > > Is there something that I'm not understanding about comp

[PATCH net-next 1/5] net: ipa: use configuration data for QSB settings

2021-03-20 Thread Alex Elder
Use the QSB configuration data in ipa_hardware_config_qsb(), rather than determining in code what values to use based on IPA version. Pass configuration data to ipa_hardware_config() so it can be passed to ipa_hardware_config_qsb(). Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_main.c | 73 +

[PATCH net-next 5/5] net: ipa: update some comments in "ipa_data.h"

2021-03-20 Thread Alex Elder
Fix/expand some comments in "ipa_data.h". Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_data.h | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/net/ipa/ipa_data.h b/drivers/net/ipa/ipa_data.h index caf9b3f9577eb..7816583fc14aa 100644 --- a

[PATCH net-next 3/5] net: ipa: split sequencer type in two

2021-03-20 Thread Alex Elder
An IPA endpoint has a sequencer that must be configured based on how the endpoint is to be used. Currently the IPA code programs the sequencer type by splitting a value into four 4-bit nibbles. Doing that doesn't really add much value, and regardless, a better way of splitting the sequencer type

[PATCH net-next 4/5] net: ipa: sequencer type is for TX endpoints only

2021-03-20 Thread Alex Elder
We only program the sequencer type for TX endpoints. So move the definition of the sequencer type fields into the TX-specific portion of the endpoint configuration data. There's no need to maintain this in the IPA structure; we can extract it from the configuration data it points to in the one sp

[PATCH net-next 2/5] net: ipa: implement MAX_READS_BEATS QSB data

2021-03-20 Thread Alex Elder
Starting with IPA v4.0, a limit is placed on the number of bytes outstanding in a transaction, to reduce latency. The limit is imposed only if this value is non-zero. We don't use a non-zero value for SC7180, but newer versions of IPA do. Prepare for that by allowing a programmed value to be spe

[PATCH net-next 0/5] net: ipa: more configuration data updates

2021-03-20 Thread Alex Elder
This series starts with two patches that should have been included in an earlier series. With these in place, QSB settings are programmed from information found in the data files rather than being embedded in code. Support is then added for reprenting another QSB property (supported for IPA v4.0+

Re: GTE - The hardware timestamping engine

2021-03-20 Thread Richard Cochran
On Sat, Mar 20, 2021 at 01:44:20PM +0100, Arnd Bergmann wrote: > Adding Richard Cochran as well, for drivers/ptp/, he may be able to > identify whether this should be integrated into that framework in some > form. I'm not familiar with the GTE, but it sounds like it is a (free running?) clock with

pull-request: bpf 2021-03-20

2021-03-20 Thread Alexei Starovoitov
Hi David, hi Jakub, The following pull-request contains BPF updates for your *net* tree. We've added 5 non-merge commits during the last 3 day(s) which contain a total of 8 files changed, 155 insertions(+), 12 deletions(-). The main changes are: 1) Use correct nops in fexit trampoline, from Sta

Re: [PATCH net-next 0/4] net: ipa: fix validation

2021-03-20 Thread Alex Elder
On 3/20/21 8:24 AM, Alex Elder wrote: On 3/18/21 11:29 PM, Alex Elder wrote: There is sanity checking code in the IPA driver that's meant to be enabled only during development.  This allows the driver to make certain assumptions, but not have to verify those assumptions are true at (operational)

Re: [PATCH net-next] net: dsa: hellcreek: Report switch name and ID

2021-03-20 Thread Andrew Lunn
> +static int hellcreek_devlink_info_get(struct dsa_switch *ds, > + struct devlink_info_req *req, > + struct netlink_ext_ack *extack) > +{ > + struct hellcreek *hellcreek = ds->priv; > + int ret; > + > + ret = devlink_i

[PATCH net-next v2 2/2] net: ipa: fix IPA validation

2021-03-20 Thread Alex Elder
There are blocks of IPA code that sanity-check various values, at compile time where possible. Most of these checks can be done once during development but skipped for normal operation. These checks permit the driver to make certain assumptions, thereby avoiding the need for runtime error checkin

[PATCH net-next v2 0/2] net: ipa: fix validation

2021-03-20 Thread Alex Elder
There is sanity checking code in the IPA driver that's meant to be enabled only during development. This allows the driver to make certain assumptions, but not have to verify those assumptions are true at (operational) runtime. This code is built conditional on IPA_VALIDATION, set (if desired) in

[PATCH net-next v2 1/2] net: ipa: fix init header command validation

2021-03-20 Thread Alex Elder
We use ipa_cmd_header_valid() to ensure certain values we will program into hardware are within range, well in advance of when we actually program them. This way we avoid having to check for errors when we actually program the hardware. Unfortunately the dev_err() call for a bad offset value does

Re: [PATCH net-next 0/4] net: ipa: fix validation

2021-03-20 Thread Alex Elder
On 3/18/21 11:29 PM, Alex Elder wrote: There is sanity checking code in the IPA driver that's meant to be enabled only during development. This allows the driver to make certain assumptions, but not have to verify those assumptions are true at (operational) runtime. This code is built condition

Re: GTE - The hardware timestamping engine

2021-03-20 Thread Arnd Bergmann
On Sat, Mar 20, 2021 at 12:56 PM Linus Walleij wrote: > > Hi Dipen, > > thanks for your mail! > > I involved some other kernel people to get some discussion. > I think Kent Gibson can be of great help because he is using > GPIOs with high precision. > > We actually discussed this a bit when adding

Re: [PATCH net-next v2 4/4] net: dsa: hellcreek: Add devlink FDB region

2021-03-20 Thread Kurt Kanzenbach
On Sun Mar 14 2021, Kurt Kanzenbach wrote: > On Sat Mar 13 2021, Vladimir Oltean wrote: >> On Sat, Mar 13, 2021 at 10:39:39AM +0100, Kurt Kanzenbach wrote: >>> Allow to dump the FDB table via devlink. This is a useful debugging feature. >>> >>> Signed-off-by: Kurt Kanzenbach >>> Reviewed-by: Andr

[PATCH net-next] net: dsa: hellcreek: Report switch name and ID

2021-03-20 Thread Kurt Kanzenbach
Report the driver name, ASIC ID and the switch name via devlink. This is a useful information for user space tooling. Signed-off-by: Kurt Kanzenbach --- drivers/net/dsa/hirschmann/hellcreek.c | 18 ++ .../linux/platform_data/hirschmann-hellcreek.h | 1 + 2 files changed,

Re: [PATCH mlx5-next v8 0/4] Dynamically assign MSI-X vectors count

2021-03-20 Thread Leon Romanovsky
Gentle reminder Thanks On Sun, Mar 14, 2021 at 02:42:52PM +0200, Leon Romanovsky wrote: > - > Changelog > v8: > * Added "physical/virtual function" words near PF and VF acronyms. > v7: https://lore.kernel.org/linux-p

Re: [RFC PATCH v2 net-next 08/16] net: dsa: replay port and host-joined mdb entries when joining the bridge

2021-03-20 Thread Vladimir Oltean
On Fri, Mar 19, 2021 at 03:20:38PM -0700, Florian Fainelli wrote: > > > On 3/18/2021 4:18 PM, Vladimir Oltean wrote: > > From: Vladimir Oltean > > > > I have udhcpcd in my system and this is configured to bring interfaces > > up as soon as they are created. > > > > I create a bridge as follows: >

Re: [PATCH net v4] net: fix race between napi kthread mode and busy poll

2021-03-20 Thread Martin Zaharinov
Hi Wei Check this: [ 39.706567] [ cut here ] [ 39.706568] RTNL: assertion failed at net/ipv4/udp_tunnel_nic.c (557) [ 39.706585] WARNING: CPU: 0 PID: 429 at net/ipv4/udp_tunnel_nic.c:557 __udp_tunnel_nic_reset_ntf+0xea/0x100 [ 39.706594] Modules linked in: i40e(+)

Re: [PATCH net v4] net: fix race between napi kthread mode and busy poll

2021-03-20 Thread Martin Zaharinov
Hi Eric May be I write to Wai to check yet. And one other problem may be is for network team and I don't know how much it has to do with it. Mar 20 06:06:28 [367562.703896][T1217504] team0: Failed to send options change via netlink (err -105) Mar 20 06:06:33 [367567.824137][T1217504] team0: Fa

[PATCH] net: decnet: Fixed multiple coding style issues

2021-03-20 Thread Sai Kalyaan Palla
Made changes to coding style as suggested by checkpatch.pl changes are of the type: open brace '{' following struct go on the same line do not use assignment in if condition Signed-off-by: Sai Kalyaan Palla --- net/decnet/dn_route.c | 21 + 1 file changed, 13

Re: [syzbot] KASAN: slab-out-of-bounds Read in add_adv_patterns_monitor

2021-03-20 Thread syzbot
syzbot suspects this issue was fixed by commit: commit b4a221ea8a1f890b50838ef389d016c7ff280abc Author: Archie Pusaka Date: Fri Jan 22 08:36:11 2021 + Bluetooth: advmon offload MSFT add rssi support bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=14ef5ad6d0 start comm

Re: [RFC PATCH v2 net-next 03/16] net: dsa: inherit the actual bridge port flags at join time

2021-03-20 Thread Vladimir Oltean
On Fri, Mar 19, 2021 at 03:08:46PM -0700, Florian Fainelli wrote: > > > On 3/18/2021 4:18 PM, Vladimir Oltean wrote: > > From: Vladimir Oltean > > > > DSA currently assumes that the bridge port starts off with this > > constellation of bridge port flags: > > > > - learning on > > - unicast flo

Re: [RFC PATCH v2 net-next 07/16] net: dsa: sync ageing time when joining the bridge

2021-03-20 Thread Vladimir Oltean
On Fri, Mar 19, 2021 at 03:13:03PM -0700, Florian Fainelli wrote: > > diff --git a/net/bridge/br_stp.c b/net/bridge/br_stp.c > > index 86b5e05d3f21..3dafb6143cff 100644 > > --- a/net/bridge/br_stp.c > > +++ b/net/bridge/br_stp.c > > @@ -639,6 +639,19 @@ int br_set_ageing_time(struct net_bridge *br,