RE: [PATCH net-next 1/1] net: phy: fix invalid phy id when probe using C22

2021-03-17 Thread Wong, Vee Khee
> -Original Message- > From: Heiner Kallweit > Sent: Wednesday, March 17, 2021 4:15 PM > To: Wong, Vee Khee ; Andrew Lunn > ; Russell King ; David S . Miller > ; Jakub Kicinski > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; > sta...@vger.kernel.org; Voon Weifeng ; Ong, > Boon

[PATCH net] net: sched: fix packet stuck problem for lockless qdisc

2021-03-17 Thread Yunsheng Lin
Lockless qdisc has below concurrent problem: cpu0 cpu1 . . q->enqueue . . . qdisc_run_begin(). . . dequeue_skb() . .

[PATCH bpf-next v2] bpf: Simplify expression for identify bpf mem type

2021-03-17 Thread Jianlin Lv
Added BPF_LD_ST_SIZE_MASK macro as mask of size modifier that help to reduce the evaluation of expressions in if statements, and remove BPF_SIZE_MASK in netronome driver. Signed-off-by: Jianlin Lv --- v2: Move the bpf_LD_ST_SIZE_MASK macro definition to include/linux/bpf.h --- drivers/net/ethern

Re: [vdpa_sim_net] 79991caf52: net/ipv4/ipmr.c:#RCU-list_traversed_in_non-reader_section

2021-03-17 Thread Oliver Sang
Hi Joe and Dongli, On Mon, Feb 08, 2021 at 08:10:21AM -0800, Joe Jin wrote: > On 2/7/21 12:15 PM, Dongli Zhang wrote: > > Is it possible that the issue is not due to this change? > > Looks this issue does not related your change, from dmesg output, when issue > occurred, virtio was not loaded: >

[PATCH v3 bpf-next 12/12] selftests/bpf: add multi-file statically linked BPF object file test

2021-03-17 Thread Andrii Nakryiko
Add Makefile infra to specify multi-file BPF object files (and derivative skeletons). Add first selftest validating BPF static linker can merge together successfully two independent BPF object files and resulting object and skeleton are correct and usable. Use the same F(F(F(X))) = F(F(X)) identit

[PATCH v3 bpf-next 10/12] selftests/bpf: re-generate vmlinux.h and BPF skeletons if bpftool changed

2021-03-17 Thread Andrii Nakryiko
Trigger vmlinux.h and BPF skeletons re-generation if detected that bpftool was re-compiled. Otherwise full `make clean` is required to get updated skeletons, if bpftool is modified. Fixes: acbd06206bbb ("selftests/bpf: Add vmlinux.h selftest exercising tracing of syscalls") Signed-off-by: Andrii

[PATCH v3 bpf-next 07/12] libbpf: add BPF static linker BTF and BTF.ext support

2021-03-17 Thread Andrii Nakryiko
Add .BTF and .BTF.ext static linking logic. When multiple BPF object files are linked together, their respective .BTF and .BTF.ext sections are merged together. BTF types are not just concatenated, but also deduplicated. .BTF.ext data is grouped by type (func info, line info, core_relos) and targe

[PATCH v3 bpf-next 03/12] libbpf: rename internal memory-management helpers

2021-03-17 Thread Andrii Nakryiko
Rename btf_add_mem() and btf_ensure_mem() helpers that abstract away details of dynamically resizable memory to use libbpf_ prefix, as they are not BTF-specific. No functional changes. Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/btf.c | 24 tools/lib/bpf

[PATCH v3 bpf-next 11/12] selftests/bpf: pass all BPF .o's through BPF static linker

2021-03-17 Thread Andrii Nakryiko
Pass all individual BPF object files (generated from progs/*.c) through `bpftool gen object` command to validate that BPF static linker doesn't corrupt them. As an additional sanity checks, validate that passing resulting object files through linker again results in identical ELF files. Exact same

[PATCH v3 bpf-next 06/12] libbpf: add BPF static linker APIs

2021-03-17 Thread Andrii Nakryiko
Introduce BPF static linker APIs to libbpf. BPF static linker allows to perform static linking of multiple BPF object files into a single combined resulting object file, preserving all the BPF programs, maps, global variables, etc. Data sections (.bss, .data, .rodata, .maps, maps, etc) with the sa

[PATCH v3 bpf-next 09/12] bpftool: add `gen object` command to perform BPF static linking

2021-03-17 Thread Andrii Nakryiko
Add `bpftool gen object ...` command to statically link multiple BPF ELF object files into a single output BPF ELF object file. This patch also updates bash completions and man page. Man page gets a short section on `gen object` command, but also updates the skeleton example to show off workflow

[PATCH v3 bpf-next 08/12] bpftool: add ability to specify custom skeleton object name

2021-03-17 Thread Andrii Nakryiko
Add optional name OBJECT_NAME parameter to `gen skeleton` command to override default object name, normally derived from input file name. This allows much more flexibility during build time. Signed-off-by: Andrii Nakryiko --- .../bpf/bpftool/Documentation/bpftool-gen.rst | 13 + tools/bp

[PATCH v3 bpf-next 05/12] libbpf: add generic BTF type shallow copy API

2021-03-17 Thread Andrii Nakryiko
Add btf__add_type() API that performs shallow copy of a given BTF type from the source BTF into the destination BTF. All the information and type IDs are preserved, but all the strings encountered are added into the destination BTF and corresponding offsets are rewritten. BTF type IDs are assumed t

[PATCH v3 bpf-next 04/12] libbpf: extract internal set-of-strings datastructure APIs

2021-03-17 Thread Andrii Nakryiko
Extract BTF logic for maintaining a set of strings data structure, used for BTF strings section construction in writable mode, into separate re-usable API. This data structure is going to be used by bpf_linker to maintains ELF STRTAB section, which has the same layout as BTF strings section. Sugge

[PATCH v3 bpf-next 00/12] BPF static linking

2021-03-17 Thread Andrii Nakryiko
This patch set adds new libbpf APIs and their bpftool integration that allows to perform static linking of BPF object files. Currently no extern resolution across object files is performed. This is going to be the focus of the follow up patches. But, given amount of code and logic necessary to perf

[PATCH v3 bpf-next 02/12] libbpf: generalize BTF and BTF.ext type ID and strings iteration

2021-03-17 Thread Andrii Nakryiko
Extract and generalize the logic to iterate BTF type ID and string offset fields within BTF types and .BTF.ext data. Expose this internally in libbpf for re-use by bpf_linker. Additionally, complete strings deduplication handling for BTF.ext (e.g., CO-RE access strings), which was previously missi

[PATCH v3 bpf-next 01/12] libbpf: expose btf_type_by_id() internally

2021-03-17 Thread Andrii Nakryiko
btf_type_by_id() is internal-only convenience API returning non-const pointer to struct btf_type. Expose it outside of btf.c for re-use. Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/btf.c | 2 +- tools/lib/bpf/libbpf_internal.h | 5 + 2 files changed, 6 insertions(+), 1 delet

linux-next: build warnings after merge of the net-next tree

2021-03-17 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (htmldocs) produced these warnings: Documentation/networking/tipc:66: /home/sfr/next/next/net/tipc/name_table.c:558: WARNING: Unexpected indentation. Documentation/networking/tipc:66: /home/sfr/next/next/net/tipc/name_table.c:559

[PATCH] ethernet: sun: Fix a typo

2021-03-17 Thread Bhaskar Chowdhury
s/serisouly/seriously/ Signed-off-by: Bhaskar Chowdhury --- drivers/net/ethernet/sun/sungem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/sun/sungem.c b/drivers/net/ethernet/sun/sungem.c index 58f142ee78a3..b4ef6f095975 100644 --- a/drivers/net/eth

linux-next: build warning after merge of the net-next tree

2021-03-17 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (htmldocs) produced this warning: net/tipc/subscr.h:73: warning: Function parameter or member 's' not described in 'tipc_subscription' Introduced by commit 429189acac53 ("tipc: add host-endian copy of user subscription to stru

[PATCH stable 5.4.y, 4.19.y] net: dsa: tag_mtk: fix 802.1ad VLAN egress

2021-03-17 Thread DENG Qingfang
[ Upstream commit 9200f515c41f4cbaeffd8fdd1d8b6373a18b1b67 ] A different TPID bit is used for 802.1ad VLAN frames. Reported-by: Ilario Gelmetti Fixes: f0af34317f4b ("net: dsa: mediatek: combine MediaTek tag with VLAN tag") Signed-off-by: DENG Qingfang Signed-off-by: David S. Miller --- net/ds

Re: [PATCH] net: check all name nodes in __dev_alloc_name

2021-03-17 Thread Stephen Hemminger
On Thu, 18 Mar 2021 04:42:53 +0100 Jiri Bohac wrote: > for_each_netdev(net, d) { > + struct netdev_name_node *name_node; > + list_for_each_entry(name_node, &d->name_node->list, > list) { > + if (!sscanf(name_node->

Re: [PATCHv2 bpf-next 2/4] xdp: extend xdp_redirect_map with broadcast support

2021-03-17 Thread Hangbin Liu
On Wed, Mar 17, 2021 at 01:03:02PM +0100, Toke Høiland-Jørgensen wrote: > FYI, this no longer applies to bpf-next due to Björn's refactor in > commit: ee75aef23afe ("bpf, xdp: Restructure redirect actions") Thanks Toke, I need to see how to get the map via map_id, does bpf_map_get_curr_or_next() w

[PATCH] net: stmmac: remove useless else if

2021-03-17 Thread Jay Fang
From: Junhao He Fix the following coccinelle report: kernel/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c:233:6-8: WARNING : cond_no_effect : possible condition with no effect (if == else) Signed-off-by: Junhao He Signed-off-by: Jay Fang --- drivers/net/ethernet/stmicro/stmmac/st

[PATCH] net: check all name nodes in __dev_alloc_name

2021-03-17 Thread Jiri Bohac
__dev_alloc_name(), when supplied with a name containing '%d', will search for the first available device number to generate a unique device name. Since commit ff92741270bf8b6e78aa885f166b68c7a67ab13a ("net: introduce name_node struct to be used in hashlist") network devices may have alternate nam

Re: [PATCH v4 14/14] vdpa_sim_blk: add support for vdpa management tool

2021-03-17 Thread Jason Wang
在 2021/3/16 上午12:34, Stefano Garzarella 写道: Enable the user to create vDPA block simulator devices using the vdpa management tool: # Show vDPA supported devices $ vdpa mgmtdev show vdpasim_blk: supported_classes block # Create a vDPA block device named as 'blk0' fro

Re: [PATCH net-next 8/9] net: hns3: add support for queue bonding mode of flow director

2021-03-17 Thread Alexander Duyck
On Wed, Mar 17, 2021 at 6:28 PM Jakub Kicinski wrote: > > On Thu, 18 Mar 2021 09:02:54 +0800 Huazhong Tan wrote: > > On 2021/3/16 4:04, Jakub Kicinski wrote: > > > On Mon, 15 Mar 2021 20:23:50 +0800 Huazhong Tan wrote: > > >> From: Jian Shen > > >> > > >> For device version V3, it supports queue

Re: [PATCH v3 bpf-next 0/2] Provide NULL and KERNEL_VERSION macros in bpf_helpers.h

2021-03-17 Thread Alexei Starovoitov
On 3/17/21 1:05 PM, Andrii Nakryiko wrote: Provide NULL and KERNEL_VERSION macros in bpf_helpers.h. Patch #2 removes such custom NULL definition from one of the selftests. v2->v3: - instead of vmlinux.h, do this in bpf_helpers.h; - added KERNEL_VERSION, which comes up periodically as well;

Re: [PATCH V4 net-next 5/5] icmp: add response to RFC 8335 PROBE messages

2021-03-17 Thread David Ahern
On 3/17/21 9:19 PM, David Miller wrote: > From: Andreas Roeseler > Date: Wed, 17 Mar 2021 22:11:47 -0500 > >> On Mon, 2021-03-15 at 04:35 +0800, kernel test robot wrote: >> Is there something that I'm not understanding about compiling kernel >> components modularly? How do I avoid this error? >

Re: [PATCH v4 10/14] vhost/vdpa: Remove the restriction that only supports virtio-net devices

2021-03-17 Thread Jason Wang
在 2021/3/16 上午12:34, Stefano Garzarella 写道: From: Xie Yongji Since the config checks are done by the vDPA drivers, we can remove the virtio-net restriction and we should be able to support all kinds of virtio devices. is not needed anymore, but we need to include to avoid compilation failu

Re: [PATCH v4 09/14] vhost/vdpa: use get_config_size callback in vhost_vdpa_config_validate()

2021-03-17 Thread Jason Wang
在 2021/3/16 上午12:34, Stefano Garzarella 写道: Let's use the new 'get_config_size()' callback available instead of using the 'virtio_id' to get the size of the device config space. Signed-off-by: Stefano Garzarella Acked-by: Jason Wang --- drivers/vhost/vdpa.c | 9 ++--- 1 file cha

Re: [PATCH v4 08/14] vdpa: add get_config_size callback in vdpa_config_ops

2021-03-17 Thread Jason Wang
在 2021/3/16 上午12:34, Stefano Garzarella 写道: This new callback is used to get the size of the configuration space of vDPA devices. Signed-off-by: Stefano Garzarella Acked-by: Jason Wang --- include/linux/vdpa.h | 4 drivers/vdpa/ifcvf/ifcvf_main.c | 6 ++ dri

Re: [mm, net-next v2] mm: net: memcg accounting for TCP rx zerocopy

2021-03-17 Thread Andrew Morton
On Mon, 15 Mar 2021 18:30:03 -0700 Arjun Roy wrote: > From: Arjun Roy > > TCP zerocopy receive is used by high performance network applications > to further scale. For RX zerocopy, the memory containing the network > data filled by the network driver is directly mapped into the address > space

Re: [PATCH V4 net-next 5/5] icmp: add response to RFC 8335 PROBE messages

2021-03-17 Thread David Miller
From: Andreas Roeseler Date: Wed, 17 Mar 2021 22:11:47 -0500 > On Mon, 2021-03-15 at 04:35 +0800, kernel test robot wrote: > Is there something that I'm not understanding about compiling kernel > components modularly? How do I avoid this error? > You cannot reference module exported symbols fro

S390: all HAS_IOMEM build failures in one fell swoop

2021-03-17 Thread Randy Dunlap
On ARCH=s390: By disabling CONFIG_PCI and hence also disabling CONFIG_HAS_IOMEM (after having done 'make ARCH=s390 allmodconfig'), we can see all of the drivers that use IOMEM-related interfaces without mentioning that they do so (in their respective Kconfig files). This should catch all of the

Re: [PATCH V4 net-next 5/5] icmp: add response to RFC 8335 PROBE messages

2021-03-17 Thread Andreas Roeseler
On Mon, 2021-03-15 at 04:35 +0800, kernel test robot wrote: > Hi Andreas, > > [FYI, it's a private test report for your RFC patch.] > [auto build test ERROR on net-next/master] > > url:    > https://github.com/0day-ci/linux/commits/Andreas-Roeseler/add-support-for-RFC-8335-PROBE/20210315-005052

[PATCH bpf-next] bpf: Remove insn_buf[] declaration in inner block

2021-03-17 Thread Jianlin Lv
Two insn_buf[16] variables are declared in the function, which act on function scope and block scope respectively. The statement in the inner blocks is redundant, so remove it. Signed-off-by: Jianlin Lv --- kernel/bpf/verifier.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/bpf/verif

Re: [PATCH V5 7/7] vDPA/ifcvf: deduce VIRTIO device ID from pdev ids

2021-03-17 Thread Jason Wang
在 2021/3/17 下午5:49, Zhu Lingshan 写道: This commit deduces the VIRTIO device ID of a probed device from its pdev device ids. Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_base.h | 1 + drivers/vdpa/ifcvf/ifcvf_main.c | 14 +- 2 files changed, 14 insertions(+), 1 dele

[PATCH] selftests/bpf: fix warning comparing pointer to 0

2021-03-17 Thread Jiapeng Chong
Fix the following coccicheck warning: ./tools/testing/selftests/bpf/progs/fentry_test.c:76:15-16: WARNING comparing pointer to 0. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- tools/testing/selftests/bpf/progs/fentry_test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH net-next 5/5] net: dsa: mv88e6xxx: Offload bridge broadcast flooding flag

2021-03-17 Thread Andrew Lunn
On Wed, Mar 17, 2021 at 12:14:18PM +0100, Tobias Waldekranz wrote: > On Tue, Mar 16, 2021 at 11:39, Vladimir Oltean wrote: > > On Mon, Mar 15, 2021 at 10:14:00PM +0100, Tobias Waldekranz wrote: > >> These switches have two modes of classifying broadcast: > >> > >> 1. Broadcast is multicast. > >>

Re: [PATCH v4 RESEND net-next] net: socket: use BIT() for MSG_*

2021-03-17 Thread Menglong Dong
On Wed, Mar 17, 2021 at 11:12 PM David Laight wrote: > ... > > Isn't MSG_CMSG_COMPAT an internal value? > Could it be changed to 1u << 30 instead of 1u << 31 ? > Then it wouldn't matter if the high bit of flags got replicated. > Yeah, MSG_CMSG_COMPAT is an internal value, and maybe it's why it is

Re: [PATCH net-next 3/5] net: dsa: mv88e6xxx: Flood all traffic classes on standalone ports

2021-03-17 Thread Andrew Lunn
On Mon, Mar 15, 2021 at 10:13:58PM +0100, Tobias Waldekranz wrote: > In accordance with the comment in dsa_port_bridge_leave, standalone > ports shall be configured to flood all types of traffic. This change > aligns the mv88e6xxx driver with that policy. > > Previously a standalone port would ini

Re: [PATCH net-next 1/5] net: dsa: mv88e6xxx: Provide generic VTU iterator

2021-03-17 Thread Andrew Lunn
On Mon, Mar 15, 2021 at 10:13:56PM +0100, Tobias Waldekranz wrote: > Move the intricacies of correctly iterating over the VTU to a common > implementation. > > Signed-off-by: Tobias Waldekranz Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next 8/9] net: hns3: add support for queue bonding mode of flow director

2021-03-17 Thread Jakub Kicinski
On Thu, 18 Mar 2021 09:02:54 +0800 Huazhong Tan wrote: > On 2021/3/16 4:04, Jakub Kicinski wrote: > > On Mon, 15 Mar 2021 20:23:50 +0800 Huazhong Tan wrote: > >> From: Jian Shen > >> > >> For device version V3, it supports queue bonding, which can > >> identify the tuple information of TCP strea

Re: [PATCH net-next v4] Add Mellanox BlueField Gigabit Ethernet driver

2021-03-17 Thread Andrew Lunn
> > > + if (device_property_read_u32(&pdev->dev, "version", &version)) { > > > + dev_err(&pdev->dev, "Version Info not found\n"); > > > + return -EINVAL; > > > + } > > > > Is this a device tree property? ACPI? If it is device tree property you > > need to > > document the binding,

Re: [PATCH net-next 8/9] net: hns3: add support for queue bonding mode of flow director

2021-03-17 Thread Huazhong Tan
On 2021/3/16 4:04, Jakub Kicinski wrote: On Mon, 15 Mar 2021 20:23:50 +0800 Huazhong Tan wrote: From: Jian Shen For device version V3, it supports queue bonding, which can identify the tuple information of TCP stream, and create flow director rules automatically, in order to keep the tx and

[PATCH net-next 2/2] net: stmmac: Add EST errors into ethtool statistic

2021-03-17 Thread mohammad . athari . ismail
From: Ong Boon Leong Below EST errors are added into ethtool statistic: 1) Constant Gate Control Error (CGCE): The counter "mtl_est_cgce" increases everytime CGCE interrupt is triggered. 2) Head-of-Line Blocking due to Scheduling (HLBS): The counter "mtl_est_hlbs" increases everytime HL

[PATCH net-next v2 1/2] net: stmmac: EST interrupts handling and error reporting

2021-03-17 Thread mohammad . athari . ismail
From: Voon Weifeng Enabled EST related interrupts as below: 1) Constant Gate Control Error (CGCE) 2) Head-of-Line Blocking due to Scheduling (HLBS) 3) Head-of-Line Blocking due to Frame Size (HLBF). 4) Base Time Register error (BTRE) 5) Switch to S/W owned list Complete (SWLC) For HLBS, the user

[PATCH net-next 0/2] net: stmmac: EST interrupts and ethtool

2021-03-17 Thread mohammad . athari . ismail
From: Mohammad Athari Bin Ismail This patchset adds support for handling EST interrupts and reporting EST errors. Additionally, the errors are added into ethtool statistic. Ong Boon Leong (1): net: stmmac: Add EST errors into ethtool statistic Voon Weifeng (1): net: stmmac: EST interrupts h

pull-request: bpf 2021-03-18

2021-03-17 Thread Daniel Borkmann
Hi David, hi Jakub, The following pull-request contains BPF updates for your *net* tree. We've added 10 non-merge commits during the last 4 day(s) which contain a total of 14 files changed, 336 insertions(+), 94 deletions(-). The main changes are: 1) Fix fexit/fmod_ret trampoline for sleepable

linux-next: manual merge of the net-next tree with the net tree

2021-03-17 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/pensando/ionic/ionic_txrx.c between commit: d2c21422323b ("ionic: linearize tso skb with too many frags") from the net tree and commit: f37bc3462e80 ("ionic: optimize fastpath struct usage") f

[PATCH iproute2] ip: cleanup help message

2021-03-17 Thread Stephen Hemminger
Wrap help message text at 80 characters, and put list of things in alpha order. Signed-off-by: Stephen Hemminger --- Other places may need this as well. PS: I made a version that auto-generated the text but it was too verbose especially since many options in iproute2 are dynamically bound. ip/

Re: [PATCH 0/2] send[msg]()/recv[msg]() fixes/improvements

2021-03-17 Thread Stefan Metzmacher
Hi Pavel, > here're patches which fix linking of send[msg]()/recv[msg]() calls > and make sure io_uring_enter() never generate a SIGPIPE. >>> >>> 1/2 breaks userspace. >> >> Can you explain that a bit please, how could some application ever >> have a useful use of IOSQE_IO_LINK with these

Re: [PATCH bpf-next v2] libbpf: use SOCK_CLOEXEC when opening the netlink socket

2021-03-17 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf.git (refs/heads/master): On Wed, 17 Mar 2021 17:28:58 +0530 you wrote: > Otherwise, there exists a small window between the opening and closing > of the socket fd where it may leak into processes launched by some other > thread. > > Fixes: 949abbe88436 ("

Re: [PATCH] libbpf: Fix error path in bpf_object__elf_init()

2021-03-17 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf.git (refs/heads/master): On Wed, 17 Mar 2021 23:54:14 +0900 you wrote: > When it failed to get section names, it should call > bpf_object__elf_finish() like others. > > Signed-off-by: Namhyung Kim > --- > tools/lib/bpf/libbpf.c | 3 ++- > 1 file changed

Re: [PATCH 1/2] neighbour: allow referenced neighbours to be removed

2021-03-17 Thread David Ahern
On 3/17/21 12:53 PM, Thadeu Lima de Souza Cascardo wrote: > During forced garbage collection, neighbours with more than a reference are > not removed. It's possible to DoS the neighbour table by using ARP spoofing > in such a way that there is always a timer pending for all neighbours, > preventing

Re: [PATCH net-next] netfilter: conntrack: Remove unused variable declaration

2021-03-17 Thread Pablo Neira Ayuso
On Thu, Mar 11, 2021 at 01:55:59PM +0800, YueHaibing wrote: > commit e97c3e278e95 ("tproxy: split off ipv6 defragmentation to a separate > module") left behind this. Applied, thanks.

Re: [PATCH RESEND][next] netfilter: Fix fall-through warnings for Clang

2021-03-17 Thread Pablo Neira Ayuso
On Fri, Mar 05, 2021 at 02:42:09AM -0600, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple > warnings by explicitly adding multiple break statements instead of just > letting the code fall through to the next case. Applied to nf-next, thanks.

Re: [PATCH nf-next] netfilter: flowtable: separate replace, destroy and stats to different workqueues

2021-03-17 Thread Pablo Neira Ayuso
On Wed, Mar 03, 2021 at 02:59:53PM +0200, Oz Shlomo wrote: > Currently the flow table offload replace, destroy and stats work items are > executed on a single workqueue. As such, DESTROY and STATS commands may > be backloged after a burst of REPLACE work items. This scenario can bloat > up memory a

Re: [PATCH net-next 2/4] net: ipa: introduce dma_addr_high32()

2021-03-17 Thread Florian Fainelli
On 3/17/2021 3:49 PM, Alex Elder wrote: > On 3/17/21 5:47 PM, Florian Fainelli wrote: >>> +/* Encapsulate extracting high-order 32 bits of DMA address */ >>> +static u32 dma_addr_high32(dma_addr_t addr) >>> +{ >>> +#ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT >>> +    return (u32)(addr >> 32); >> You can

Re: [PATCH net] ipv6: weaken the v4mapped source check

2021-03-17 Thread Mat Martineau
On Wed, 17 Mar 2021, Jakub Kicinski wrote: This reverts commit 6af1799aaf3f1bc8defedddfa00df3192445bbf3. Commit 6af1799aaf3f ("ipv6: drop incoming packets having a v4mapped source address") introduced an input check against v4mapped addresses. Use of such addresses on the wire is indeed quest

Re: [PATCH net-next 2/4] net: ipa: introduce dma_addr_high32()

2021-03-17 Thread Alex Elder
On 3/17/21 5:47 PM, Florian Fainelli wrote: +/* Encapsulate extracting high-order 32 bits of DMA address */ +static u32 dma_addr_high32(dma_addr_t addr) +{ +#ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT + return (u32)(addr >> 32); You can probably use upper_32bits() here... Where is that defined?

Re: [PATCH net-next 2/4] net: ipa: introduce dma_addr_high32()

2021-03-17 Thread Florian Fainelli
On 3/17/2021 3:29 PM, Alex Elder wrote: > Create a new helper function to encapsulate extracting the > high-order 32 bits of a DMA address. It returns 0 for builds > in which a DMA address is not 64 bits. > > This avoids doing a 32-position shift on a DMA address if it > happens not to be 64 b

Re: [PATCH] dt-bindings: Drop type references on common properties

2021-03-17 Thread Kuninori Morimoto
Hi Rob > Users of common properties shouldn't have a type definition as the > common schemas already have one. Drop all the unnecessary type > references in the tree. > > A meta-schema update to catch these is pending. > > Cc: Nicolas Saenz Julienne > Cc: Maxime Ripard > Cc: Linus Walleij >

Re: [PATCH] net: macb: simplify clk_init with dev_err_probe

2021-03-17 Thread Nicolas Ferre
On 17/03/2021 at 17:16, Michael Tretter wrote: On some platforms, e.g., the ZynqMP, devm_clk_get can return -EPROBE_DEFER if the clock controller, which is implemented in firmware, has not been probed yet. As clk_init is only called during probe, use dev_err_probe to simplify the error message a

Re: [PATCH net-next 3/5] net: dsa: mv88e6xxx: Flood all traffic classes on standalone ports

2021-03-17 Thread Florian Fainelli
On 3/15/2021 2:13 PM, Tobias Waldekranz wrote: > In accordance with the comment in dsa_port_bridge_leave, standalone > ports shall be configured to flood all types of traffic. This change > aligns the mv88e6xxx driver with that policy. > > Previously a standalone port would initially not egress

Re: [PATCH net-next 4/5] net: dsa: mv88e6xxx: Offload bridge learning flag

2021-03-17 Thread Tobias Waldekranz
On Wed, Mar 17, 2021 at 21:29, Vladimir Oltean wrote: > On Wed, Mar 17, 2021 at 07:45:46PM +0100, Tobias Waldekranz wrote: >> On Wed, Mar 17, 2021 at 16:12, Vladimir Oltean wrote: >> > On Mon, Mar 15, 2021 at 10:13:59PM +0100, Tobias Waldekranz wrote: >> >> + if (flags.mask & BR_LEARNING) { >> >>

[PATCH net-next 4/4] net: ipa: relax 64-bit build requirement

2021-03-17 Thread Alex Elder
We currently assume the IPA driver is built only for a 64 bit kernel. When this constraint was put in place it eliminated some do_div() calls, replacing them with the "/" and "%" operators. We now only use these operations on u32 and size_t objects. In a 32-bit kernel build, size_t will be 32 bi

[PATCH net-next 1/4] net: ipa: fix assumptions about DMA address size

2021-03-17 Thread Alex Elder
Some build time checks in ipa_table_validate_build() assume that a DMA address is 64 bits wide. That is more restrictive than it has to be. A route or filter table is 64 bits wide no matter what the size of a DMA address is on the AP. The code actually uses a pointer to __le64 to access table en

[PATCH net-next 2/4] net: ipa: introduce dma_addr_high32()

2021-03-17 Thread Alex Elder
Create a new helper function to encapsulate extracting the high-order 32 bits of a DMA address. It returns 0 for builds in which a DMA address is not 64 bits. This avoids doing a 32-position shift on a DMA address if it happens not to be 64 bits wide. Signed-off-by: Alex Elder --- drivers/net/

[PATCH net-next 3/4] net: ipa: fix table alignment requirement

2021-03-17 Thread Alex Elder
We currently have a build-time check to ensure that the minimum DMA allocation alignment satisfies the constraint that IPA filter and route tables must point to rules that are 128-byte aligned. But what's really important is that the actual allocated DMA memory has that alignment, even if the mini

[PATCH net-next 0/4] net: ipa: support 32-bit targets

2021-03-17 Thread Alex Elder
There is currently a configuration dependency that restricts IPA to be supported only on 64-bit machines. There are only a few things that really require that, and those are fixed in this series. The last patch in the series removes the CONFIG_64BIT build dependency for IPA.

Re: [PATCH 0/7 v4] Introduce a bulk order-0 page allocator with two in-tree users

2021-03-17 Thread Alexander Lobakin
From: Jesper Dangaard Brouer Date: Wed, 17 Mar 2021 18:19:43 +0100 > On Wed, 17 Mar 2021 16:52:32 + > Alexander Lobakin wrote: > > > From: Jesper Dangaard Brouer > > Date: Wed, 17 Mar 2021 17:38:44 +0100 > > > > > On Wed, 17 Mar 2021 16:31:07 + > > > Alexander Lobakin wrote: > > > > >

Re: [PATCH] net: macb: simplify clk_init with dev_err_probe

2021-03-17 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 17 Mar 2021 17:16:09 +0100 you wrote: > On some platforms, e.g., the ZynqMP, devm_clk_get can return > -EPROBE_DEFER if the clock controller, which is implemented in firmware, > has not been probed yet. > > As clk_

[PATCH v3] icmp: support rfc5837

2021-03-17 Thread ishaangandhi
From: ishaan This patch identifies the interface a packet arrived on when sending ICMP time exceeded, destination unreachable, and parameter problem messages, in accordance with RFC 5837. It was tested by pinging a machine with a ttl of 1, and observing the response in Wireshark. Changes since

Re: [PATCH v2 bpf-next 07/11] libbpf: add BPF static linker BTF and BTF.ext support

2021-03-17 Thread Andrii Nakryiko
On Tue, Mar 16, 2021 at 10:25 PM Alexei Starovoitov wrote: > > On Sat, Mar 13, 2021 at 11:35:33AM -0800, Andrii Nakryiko wrote: > > + for (j = 0; j < n; j++, src_var++) { > > + void *sec_vars = dst_sec->sec_vars; > > + > > + sec_vars = libbpf_rea

Re: [mm, net-next v2] mm: net: memcg accounting for TCP rx zerocopy

2021-03-17 Thread Johannes Weiner
On Tue, Mar 16, 2021 at 11:05:11PM -0700, Arjun Roy wrote: > On Tue, Mar 16, 2021 at 3:27 AM Johannes Weiner wrote: > > > > Hello, > > > > On Mon, Mar 15, 2021 at 09:16:45PM -0700, Arjun Roy wrote: > > > From: Arjun Roy > > > > > > TCP zerocopy receive is used by high performance network applicat

Re: [PATCH v2] ethernet/broadcom:remove unneeded variable: "ret"

2021-03-17 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 17 Mar 2021 20:29:33 +0800 you wrote: > From: dingsenjie > > remove unneeded variable: "ret". > > Signed-off-by: dingsenjie > --- > drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 3 +-- > 1 file changed, 1

Re: [PATCH v2] ethernet/microchip:remove unneeded variable: "ret"

2021-03-17 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 17 Mar 2021 20:30:30 +0800 you wrote: > From: dingsenjie > > remove unneeded variable: "ret". > > Signed-off-by: dingsenjie > --- > drivers/net/ethernet/microchip/encx24j600.c | 3 +-- > 1 file changed, 1 inser

Re: [PATCH net v4] net: fix race between napi kthread mode and busy poll

2021-03-17 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 16 Mar 2021 15:36:47 -0700 you wrote: > Currently, napi_thread_wait() checks for NAPI_STATE_SCHED bit to > determine if the kthread owns this napi and could call napi->poll() on > it. However, if socket busy poll is enab

Re: [PATCH net-next v17 0/4] Add support for mv88e6393x family of Marvell

2021-03-17 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Wed, 17 Mar 2021 14:46:39 +0100 you wrote: > Hello, > > after 2 months I finally had time to send v17 of Amethyst patches. > > This series is tested on Marvell CN9130-CRB. > > Changes since v16: > - dropped patches a

Re: [PATCH 2/2] net: mdio: Add BCM6368 MDIO mux bus controller

2021-03-17 Thread Florian Fainelli
On 3/17/2021 10:49 AM, Andrew Lunn wrote: >> BCM6368 (and newer) SoCs have an integrated ethernet switch controller with >> dedicated internal phys, but it also supports connecting to external phys >> not integrated in the internal switch. >> Ports 0-3 are internal, ports 4-7 are external and

Re: [PATCH net-next v2 0/1] net: stmmac: add per-q coalesce support

2021-03-17 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 17 Mar 2021 09:01:22 +0800 you wrote: > Hi, > > This patch adds per-queue RX & TX coalesce control so that user can > adjust the RX & TX interrupt moderation per queue. This is beneficial for > mixed criticality co

Re: [PATCH v2 bpf-next 10/11] selftests/bpf: pass all BPF .o's through BPF static linker

2021-03-17 Thread Andrii Nakryiko
On Wed, Mar 17, 2021 at 2:00 PM Alexei Starovoitov wrote: > > On Wed, Mar 17, 2021 at 1:47 PM Andrii Nakryiko > wrote: > > > > On Tue, Mar 16, 2021 at 10:34 PM Alexei Starovoitov > > wrote: > > > > > > On Sat, Mar 13, 2021 at 11:35:36AM -0800, Andrii Nakryiko wrote: > > > > > > > > -$(TRUNNER_BP

Re: [PATCH 1/2] net: dsa: bcm_sf2: add function finding RGMII register

2021-03-17 Thread Florian Fainelli
On 3/17/2021 7:37 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > Simple macro like REG_RGMII_CNTRL_P() is insufficient as: > 1. It doesn't validate port argument > 2. It doesn't support chipsets with non-lineral RGMII regs layout > > Missing port validation could result in getting registe

Re: [Intel-wired-lan] [PATCH][next] ixgbe: Fix out-of-bounds warning in ixgbe_host_interface_command()

2021-03-17 Thread Gustavo A. R. Silva
On 3/17/21 15:10, Jann Horn wrote: > On Wed, Mar 17, 2021 at 9:04 PM Gustavo A. R. Silva > wrote: >> On 3/17/21 13:57, Jann Horn wrote: >> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c >> b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c >> index 62ddb452f862..bff3dc

Re: [PATCH v2 bpf-next 10/11] selftests/bpf: pass all BPF .o's through BPF static linker

2021-03-17 Thread Alexei Starovoitov
On Wed, Mar 17, 2021 at 1:47 PM Andrii Nakryiko wrote: > > On Tue, Mar 16, 2021 at 10:34 PM Alexei Starovoitov > wrote: > > > > On Sat, Mar 13, 2021 at 11:35:36AM -0800, Andrii Nakryiko wrote: > > > > > > -$(TRUNNER_BPF_SKELS): $(TRUNNER_OUTPUT)/%.skel.h:\ > > > -

Re: [PATCH net-next v2 1/1] net: stmmac: add per-queue TX & RX coalesce ethtool support

2021-03-17 Thread Jakub Kicinski
On Wed, 17 Mar 2021 09:01:23 +0800 Ong Boon Leong wrote: > Extending the driver to support per-queue RX and TX coalesce settings in > order to support below commands: > > To show per-queue coalesce setting:- > $ ethtool --per-queue queue_mask --show-coalesce > > To set per-queue coalesce setti

Re: [PATCH v2 bpf-next 10/11] selftests/bpf: pass all BPF .o's through BPF static linker

2021-03-17 Thread Andrii Nakryiko
On Tue, Mar 16, 2021 at 10:34 PM Alexei Starovoitov wrote: > > On Sat, Mar 13, 2021 at 11:35:36AM -0800, Andrii Nakryiko wrote: > > > > -$(TRUNNER_BPF_SKELS): $(TRUNNER_OUTPUT)/%.skel.h:\ > > - $(TRUNNER_OUTPUT)/%.o \ > > -

Re: [Intel-wired-lan] [PATCH][next] ixgbe: Fix out-of-bounds warning in ixgbe_host_interface_command()

2021-03-17 Thread Gustavo A. R. Silva
On 3/17/21 13:57, Jann Horn wrote: diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c index 62ddb452f862..bff3dc1af702 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c +++ b/drivers/net/ethernet/in

Re: [PATCH] selinux: vsock: Set SID for socket returned by accept()

2021-03-17 Thread Paul Moore
On Wed, Mar 17, 2021 at 11:44 AM David Brazdil wrote: > > For AF_VSOCK, accept() currently returns sockets that are unlabelled. > Other socket families derive the child's SID from the SID of the parent > and the SID of the incoming packet. This is typically done as the > connected socket is placed

[PATCH v3 bpf-next 2/2] selftests/bpf: drop custom NULL #define in skb_pkt_end selftest

2021-03-17 Thread Andrii Nakryiko
Now that bpftool generates NULL definition as part of vmlinux.h, drop custom NULL definition in skb_pkt_end.c. Signed-off-by: Andrii Nakryiko --- tools/testing/selftests/bpf/progs/skb_pkt_end.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/testing/selftests/bpf/progs/skb_pkt_end.c b/

[PATCH v3 bpf-next 0/2] Provide NULL and KERNEL_VERSION macros in bpf_helpers.h

2021-03-17 Thread Andrii Nakryiko
Provide NULL and KERNEL_VERSION macros in bpf_helpers.h. Patch #2 removes such custom NULL definition from one of the selftests. v2->v3: - instead of vmlinux.h, do this in bpf_helpers.h; - added KERNEL_VERSION, which comes up periodically as well; - I dropped strict compilation patches for n

[PATCH v3 bpf-next 1/2] libbpf: provide NULL and KERNEL_VERSION macros in bpf_helpers.h

2021-03-17 Thread Andrii Nakryiko
Given that vmlinux.h is not compatible with headers like stddef.h, NULL poses an annoying problem: it is defined as #define, so is not captured in BTF, so is not emitted into vmlinux.h. This leads to users either sticking to explicit 0, or defining their own NULL (as progs/skb_pkt_end.c does). But

Re: [PATCH bpf-next] bpf: Simplify expression for identify bpf mem type

2021-03-17 Thread Alexei Starovoitov
On Wed, Mar 17, 2021 at 5:52 AM Jianlin Lv wrote: > return BPF_CLASS(meta->insn.code); > diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h > index 2d3036e292a9..5d77675e7112 100644 > --- a/include/uapi/linux/bpf.h > +++ b/include/uapi/linux/bpf.h > @@ -21,6 +21,7 @@ > #defi

Re: [PATCH net-next 0/5] DSA/switchdev documentation fixups

2021-03-17 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Wed, 17 Mar 2021 19:44:53 +0200 you wrote: > These are some small fixups after the recently merged documentation > update. > > Vladimir Oltean (5): > Documentation: networking: switchdev: separate bulleted items with

Re: [PATCH net-next 0/5] refactor code related to npc install flow

2021-03-17 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Wed, 17 Mar 2021 19:05:33 +0530 you wrote: > This patchset refactors and cleans up the code associated with the > npc install flow API, specifically to eliminate different code paths > while installing MCAM rules by AF

Re: [PATCH] net: ppp: Mundane typo fixes in the file pppoe.c

2021-03-17 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 17 Mar 2021 14:30:59 +0530 you wrote: > s/procesing/processing/ > s/comparations/comparisons/ > > Signed-off-by: Bhaskar Chowdhury > --- > drivers/net/ppp/pppoe.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 de

Re: [PATCH net-next 0/7] mlxsw: Allow 802.1d and .1ad VxLAN bridges to coexist on Spectrum>=2

2021-03-17 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Wed, 17 Mar 2021 12:35:22 +0200 you wrote: > From: Ido Schimmel > > This patchset allows user space to simultaneously configure both 802.1d > and 802.1ad VxLAN bridges on Spectrum-2 and later ASICs. 802.1ad VxLAN > br

Re: [PATCH net-next resend] net: dsa: b53: relax is63xx() condition

2021-03-17 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 17 Mar 2021 09:42:01 +0100 you wrote: > BCM63xx switches are present on bcm63xx and bmips devices. > > Signed-off-by: Álvaro Fernández Rojas > Acked-by: Florian Fainelli > --- > drivers/net/dsa/b53/b53_priv.h |

  1   2   3   >