Re: [PATCH net] selftests/bpf: set gopt opt_class to 0 if get tunnel opt failed

2021-03-14 Thread Hangbin Liu
On Fri, Mar 12, 2021 at 04:15:27PM +0100, Daniel Borkmann wrote: > On 3/12/21 2:56 AM, Hangbin Liu wrote: > > Hi David, > > > > May I ask what's the status of this patch? From patchwork[1] the state is > > accepted. But I can't find the fix on net or net-next. > > I think there may have been two

[PATCH] staging: qlge : fix missing error codes

2021-03-14 Thread Jay Fang
From: Zihao Tang Fixes one smatch warnings: drivers/staging/qlge/qlge_main.c:4564 qlge_probe() warn: missing error code 'err' Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Zihao Tang Signed-off-by: Jay Fang --- drivers/staging/qlge/qlge_main.c | 4 +++- 1 file c

[PATCH net-next 1/1] net: stmmac: add per-queue TX & RX coalesce ethtool support

2021-03-14 Thread Ong Boon Leong
Extending the driver to support per-queue RX and TX coalesce settings in order to support below commands: To show per-queue coalesce setting:- $ ethtool --per-queue queue_mask --show-coalesce To set per-queue coalesce setting:- $ ethtool --per-queue queue_mask --coalesce \ [rx-usecs N]

[PATCH net-next 0/1] net: stmmac: add per-q coalesce support

2021-03-14 Thread Ong Boon Leong
Hi, This patch adds per-queue RX & TX coalesce control so that user can adjust the RX & TX interrupt moderation per queue. This is beneficial for mixed criticality control (according to VLAN priority) by user application. The patch as been tested with following steps and results and the from the

Re: [PATCH devicetree] arm64: dts: ls1028a: set up the real link speed for ENETC port 2

2021-03-14 Thread Shawn Guo
On Mon, Mar 08, 2021 at 03:08:34PM +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > In NXP LS1028A there is a MAC-to-MAC internal link between enetc_port2 > and mscc_felix_port4. This link operates at 2.5Gbps and is described as > such for the mscc_felix_port4 node. > > The reason for t

Re: [PATCH net-next 0/3] iwlwifi: series with smaller improvements

2021-03-14 Thread Kalle Valo
Heiner Kallweit writes: > Series includes smaller improvements. > > Heiner Kallweit (3): > iwlwifi: use DECLARE_BITMAP macro > iwlwifi: switch "index larger than supported by driver" warning to > debug level > iwlwifi: use dma_set_mask_and_coherent iwlwifi patches go to iwlwifi-next, n

[PATCH v5 10/11] vduse: Add config interrupt support

2021-03-14 Thread Xie Yongji
This patch introduces a new ioctl VDUSE_INJECT_CONFIG_IRQ to support injecting config interrupt. Signed-off-by: Xie Yongji --- drivers/vdpa/vdpa_user/vduse_dev.c | 24 +++- include/uapi/linux/vduse.h | 3 +++ 2 files changed, 26 insertions(+), 1 deletion(-) diff --g

[PATCH v5 11/11] Documentation: Add documentation for VDUSE

2021-03-14 Thread Xie Yongji
VDUSE (vDPA Device in Userspace) is a framework to support implementing software-emulated vDPA devices in userspace. This document is intended to clarify the VDUSE design and usage. Signed-off-by: Xie Yongji --- Documentation/userspace-api/index.rst | 1 + Documentation/userspace-api/vduse.rst

[PATCH v5 09/11] vduse: Introduce VDUSE - vDPA Device in Userspace

2021-03-14 Thread Xie Yongji
This VDUSE driver enables implementing vDPA devices in userspace. Both control path and data path of vDPA devices will be able to be handled in userspace. In the control path, the VDUSE driver will make use of message mechnism to forward the config operation from vdpa bus driver to userspace. User

[PATCH v5 08/11] vduse: Implement an MMU-based IOMMU driver

2021-03-14 Thread Xie Yongji
This implements an MMU-based IOMMU driver to support mapping kernel dma buffer into userspace. The basic idea behind it is treating MMU (VA->PA) as IOMMU (IOVA->PA). The driver will set up MMU mapping instead of IOMMU mapping for the DMA transfer so that the userspace process is able to use its vir

[PATCH v5 06/11] vdpa: factor out vhost_vdpa_pa_map()

2021-03-14 Thread Xie Yongji
The upcoming patch is going to support VA mapping. So let's factor out the logic of PA mapping firstly to make the code more readable. Suggested-by: Jason Wang Signed-off-by: Xie Yongji --- drivers/vhost/vdpa.c | 46 -- 1 file changed, 28 insertions(+

[PATCH v5 04/11] vhost-iotlb: Add an opaque pointer for vhost IOTLB

2021-03-14 Thread Xie Yongji
Add an opaque pointer for vhost IOTLB. And introduce vhost_iotlb_add_range_ctx() to accept it. Suggested-by: Jason Wang Acked-by: Jason Wang Signed-off-by: Xie Yongji --- drivers/vhost/iotlb.c | 20 include/linux/vhost_iotlb.h | 3 +++ 2 files changed, 19 insertions

[PATCH v5 07/11] vdpa: Support transferring virtual addressing during DMA mapping

2021-03-14 Thread Xie Yongji
This patch introduces an attribute for vDPA device to indicate whether virtual address can be used. If vDPA device driver set it, vhost-vdpa bus driver will not pin user page and transfer userspace virtual address instead of physical address during DMA mapping. And corresponding vma->vm_file and of

[PATCH v5 05/11] vdpa: Add an opaque pointer for vdpa_config_ops.dma_map()

2021-03-14 Thread Xie Yongji
Add an opaque pointer for DMA mapping. Suggested-by: Jason Wang Acked-by: Jason Wang Signed-off-by: Xie Yongji --- drivers/vdpa/vdpa_sim/vdpa_sim.c | 6 +++--- drivers/vhost/vdpa.c | 2 +- include/linux/vdpa.h | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) di

[PATCH v5 03/11] vhost-vdpa: protect concurrent access to vhost device iotlb

2021-03-14 Thread Xie Yongji
Use vhost_dev->mutex to protect vhost device iotlb from concurrent access. Fixes: 4c8cf318("vhost: introduce vDPA-based backend") Signed-off-by: Xie Yongji --- drivers/vhost/vdpa.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.

[PATCH v5 02/11] eventfd: Increase the recursion depth of eventfd_signal()

2021-03-14 Thread Xie Yongji
Increase the recursion depth of eventfd_signal() to 1. This is the maximum recursion depth we have found so far, which can be triggered with the following call chain: kvm_io_bus_write[kvm] --> ioeventfd_write [kvm] --> eventfd_signal

[PATCH v5 01/11] file: Export __receive_fd() to modules

2021-03-14 Thread Xie Yongji
Export __receive_fd() so that some modules can use it to pass file descriptor between processes. Signed-off-by: Xie Yongji --- fs/file.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/file.c b/fs/file.c index dab120b71e44..a2e5bcae63ba 100644 --- a/fs/file.c +++ b/fs/file.c @@ -1107,6 +1

[PATCH v5 00/11] Introduce VDUSE - vDPA Device in Userspace

2021-03-14 Thread Xie Yongji
This series introduces a framework, which can be used to implement vDPA Devices in a userspace program. The work consist of two parts: control path forwarding and data path offloading. In the control path, the VDUSE driver will make use of message mechnism to forward the config operation from vdpa

[PATCH net-next 6/6] stmmac: intel: add pcs-xpcs for Intel mGbE controller

2021-03-14 Thread Ong Boon Leong
Intel mGbE controller such as those in EHL & TGL uses pcs-xpcs driver for SGMII interface. To ensure mdio bus scanning does not assign phy_device to MDIO-addressable entities like intel serdes and pcs-xpcs, we set up to phy_mask to skip them. Signed-off-by: Ong Boon Leong --- drivers/net/etherne

[PATCH net-next 5/6] net: stmmac: ensure phydev is attached to phylink for C37 AN

2021-03-14 Thread Ong Boon Leong
As the support for MAC-side SGMII C37 AN is added to pcs-xpcs, phydev should be attached to phylink during driver's open(). So, we change the condition to "Not C73 AN" instead. Signed-off-by: Ong Boon Leong --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion

[PATCH net-next 4/6] net: stmmac: make in-band AN mode parsing is supported for non-DT

2021-03-14 Thread Ong Boon Leong
Not all platform uses DT, so phylink_parse_mode() will skip in-band setup of pl->supported and pl->link_config.advertising entirely. So, we add the setting of ovr_an_inband flag to make it works for non-DT platform. Signed-off-by: Ong Boon Leong --- drivers/net/ethernet/stmicro/stmmac/stmmac_mai

[PATCH net-next 3/6] net: phylink: make phylink_parse_mode() support non-DT platform

2021-03-14 Thread Ong Boon Leong
Certain platform does not support DT, so we make phylink_parse_mode() to allow non-DT platform to use it to setup in-band AN advertising. Signed-off-by: Ong Boon Leong --- drivers/net/phy/phylink.c | 5 +++-- include/linux/phylink.h | 2 ++ 2 files changed, 5 insertions(+), 2 deletions(-) dif

[PATCH net-next 2/6] net: pcs: add C37 SGMII AN support for intel mGbE controller

2021-03-14 Thread Ong Boon Leong
XPCS IP supports C37 SGMII AN process and it is used in intel multi-GbE controller as MAC-side SGMII. Signed-off-by: Ong Boon Leong --- drivers/net/pcs/pcs-xpcs.c | 167 ++- include/linux/pcs/pcs-xpcs.h | 1 + 2 files changed, 167 insertions(+), 1 deletion(-)

[PATCH net-next 1/6] net: pcs: rearrange C73 functions to prepare for C37 support later

2021-03-14 Thread Ong Boon Leong
The current implementation for XPCS is validated for C73, so we rename them to have _c73 suffix and introduce a set of functions to use an_mode flag to switch between C73 and C37 AN later. Signed-off-by: Ong Boon Leong --- drivers/net/pcs/pcs-xpcs.c | 94 +--- i

[PATCH net-next 0/6] net: pcs, stmmac: add C37 AN SGMII support

2021-03-14 Thread Ong Boon Leong
Hi all, This patch series adds MAC-side SGMII support to stmmac driver and it is changed as follow:- 1/6: Refactor the current C73 implementation in pcs-xpcs to prepare for adding C37 AN later. 2/6: Add MAC-side SGMII C37 AN support to pcs-xpcs 3,4/6: make phylink_parse_mode() to work for no

[PATCH net 1/1] net: phylink: Fix phylink_err() function name error in phylink_major_config

2021-03-14 Thread Ong Boon Leong
if pl->mac_ops->mac_finish() failed, phylink_err should use "mac_finish" instead of "mac_prepare". Fixes: b7ad14c2fe2d4 ("net: phylink: re-implement interface configuration with PCS") Signed-off-by: Ong Boon Leong --- drivers/net/phy/phylink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

Re: [net-next PATCH 07/10] virtio_net: Update driver to use ethtool_sprintf

2021-03-14 Thread Jason Wang
在 2021/3/13 上午1:48, Alexander Duyck 写道: From: Alexander Duyck Update the code to replace instances of snprintf and a pointer update with just calling ethtool_sprintf. Also replace the char pointer with a u8 pointer to avoid having to recast the pointer type. Signed-off-by: Alexander Duyck

[RFC v2] net: sched: implement TCQ_F_CAN_BYPASS for lockless qdisc

2021-03-14 Thread Yunsheng Lin
Currently pfifo_fast has both TCQ_F_CAN_BYPASS and TCQ_F_NOLOCK flag set, but queue discipline by-pass does not work for lockless qdisc because skb is always enqueued to qdisc even when the qdisc is empty, see __dev_xmit_skb(). This patch calls sch_direct_xmit() to transmit the skb directly to the

Re: [PATCH] net: ethernet: intel: igb: Typo fix in the file igb_main.c

2021-03-14 Thread Randy Dunlap
On 3/14/21 6:48 PM, Bhaskar Chowdhury wrote: > > s/structue/structure/ > > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > drivers/net/ethernet/intel/igb/igb_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/igb/igb

Re: [PATCH] net: ethernet: neterion: Fix a typo in the file s2io.c

2021-03-14 Thread Randy Dunlap
On 3/14/21 6:53 PM, Bhaskar Chowdhury wrote: > > s/structue/structure/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > drivers/net/ethernet/neterion/s2io.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/neterion/s2io.c > b/

[PATCH] net: ethernet: neterion: Fix a typo in the file s2io.c

2021-03-14 Thread Bhaskar Chowdhury
s/structue/structure/ Signed-off-by: Bhaskar Chowdhury --- drivers/net/ethernet/neterion/s2io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/neterion/s2io.c b/drivers/net/ethernet/neterion/s2io.c index 8f2f091bce89..9cfcd5500462 100644 --- a/drivers

[PATCH] net: ethernet: intel: igb: Typo fix in the file igb_main.c

2021-03-14 Thread Bhaskar Chowdhury
s/structue/structure/ Signed-off-by: Bhaskar Chowdhury --- drivers/net/ethernet/intel/igb/igb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index 03f78fdb0dcd..afc8ab9046a5 1006

Re: [PATCH net-next 2/2] net: macb: Disable PCS auto-negotiation for SGMII fixed-link mode

2021-03-14 Thread Andrew Lunn
On Sun, Mar 14, 2021 at 11:22:03PM +, Robert Hancock wrote: > On Sat, 2021-03-13 at 02:45 +0100, Andrew Lunn wrote: > > On Thu, Mar 11, 2021 at 02:18:13PM -0600, Robert Hancock wrote: > > > When using a fixed-link configuration in SGMII mode, it's not really > > > sensible to have auto-negotiat

Re: [PATCH RFC] net: sched: implement TCQ_F_CAN_BYPASS for lockless qdisc

2021-03-14 Thread Yunsheng Lin
On 2021/3/14 18:15, Marc Kleine-Budde wrote: > Cc += linux-...@vger.kernel.org > > On 3/14/21 1:03 AM, Vladimir Oltean wrote: >> On Sat, Mar 13, 2021 at 10:47:47AM +0800, Yunsheng Lin wrote: >>> Currently pfifo_fast has both TCQ_F_CAN_BYPASS and TCQ_F_NOLOCK >>> flag set, but queue discipline by-p

Re: [PATCH] ethernet: amazon: ena: A typo fix in the file ena_com.h

2021-03-14 Thread Randy Dunlap
On 3/14/21 3:22 PM, Bhaskar Chowdhury wrote: > > Mundane typo fix. > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > drivers/net/ethernet/amazon/ena/ena_com.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/amazon/ena/ena_com.h

Re: [PATCH net-next 0/2] axienet clock additions

2021-03-14 Thread Robert Hancock
On Sun, 2021-03-14 at 14:27 -0700, David Miller wrote: > From: Robert Hancock > Date: Thu, 11 Mar 2021 14:11:15 -0600 > > > Add support to the axienet driver for controlling all of the clocks that > > the logic core may utilize. > > This series does not apply to net-next, please respin. > > Tha

Re: [PATCH net-next 2/2] net: macb: Disable PCS auto-negotiation for SGMII fixed-link mode

2021-03-14 Thread Robert Hancock
On Sat, 2021-03-13 at 02:45 +0100, Andrew Lunn wrote: > On Thu, Mar 11, 2021 at 02:18:13PM -0600, Robert Hancock wrote: > > When using a fixed-link configuration in SGMII mode, it's not really > > sensible to have auto-negotiation enabled since the link settings are > > fixed by definition. In othe

Re: [PATCH net-next 00/11] psample: Add additional metadata attributes

2021-03-14 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Sun, 14 Mar 2021 14:19:29 +0200 you wrote: > From: Ido Schimmel > > This series extends the psample module to expose additional metadata to > user space for packets sampled via act_sample. The new metadata (e.g., > tr

Re: [PATCH net] net: qrtr: fix a kernel-infoleak in qrtr_recvmsg()

2021-03-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 12 Mar 2021 08:59:48 -0800 you wrote: > From: Eric Dumazet > > struct sockaddr_qrtr has a 2-byte hole, and qrtr_recvmsg() currently > does not clear it before copying kernel data to user space. > > It might be too lat

Re: [PATCH net] flow_dissector: fix byteorder of dissected ICMP ID

2021-03-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 12 Mar 2021 20:08:57 + you wrote: > flow_dissector_key_icmp::id is of type u16 (CPU byteorder), > ICMP header has its ID field in network byteorder obviously. > Sparse says: > > net/core/flow_dissector.c:178:43: war

[PATCH] ethernet: amazon: ena: A typo fix in the file ena_com.h

2021-03-14 Thread Bhaskar Chowdhury
Mundane typo fix. Signed-off-by: Bhaskar Chowdhury --- drivers/net/ethernet/amazon/ena/ena_com.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_com.h b/drivers/net/ethernet/amazon/ena/ena_com.h index 343caf41e709..73b03ce59412 100644 --

Re: [RFC net] net: dsa: Centralize validation of VLAN configuration

2021-03-14 Thread Tobias Waldekranz
On Wed, Mar 10, 2021 at 00:01, Vladimir Oltean wrote: > On Tue, Mar 09, 2021 at 10:28:11PM +0100, Tobias Waldekranz wrote: >> On Tue, Mar 09, 2021 at 12:40, Florian Fainelli wrote: >> > On 3/9/21 10:42 AM, Tobias Waldekranz wrote: >> >> There are three kinds of events that have an inpact on VLAN

Re: [PATCH net-next] hv_netvsc: Add a comment clarifying batching logic

2021-03-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 12 Mar 2021 15:45:27 -0800 you wrote: > From: Shachar Raindel > > The batching logic in netvsc_send is non-trivial, due to > a combination of the Linux API and the underlying hypervisor > interface. Add a comment

Re: [PATCH net] flow_dissector: fix byteorder of dissected ICMP ID

2021-03-14 Thread David Miller
From: Vladimir Oltean Date: Sun, 14 Mar 2021 20:44:49 + > On Sun, Mar 14, 2021 at 09:21:40PM +0100, Jakub Sitnicki wrote: >> On Fri, Mar 12, 2021 at 09:08 PM CET, Alexander Lobakin wrote: >> >> Smells like a breaking change for existing consumers of this value. >> >> How about we change the

Re: [PATCH] net: arcnet: com20020 fix error handling

2021-03-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Sun, 14 Mar 2021 14:08:36 -0400 you wrote: > There are two issues when handling error case in com20020pci_probe() > > 1. priv might be not initialized yet when calling com20020pci_remove() > from com20020pci_probe(), since t

Re: [PATCH v3 net-next 0/2] pktgen: scripts improvements

2021-03-14 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Thu, 11 Mar 2021 11:32:51 +0100 you wrote: > Hello netdev community, > > Please consider small improvements to pktgen scripts we use in our > environment. > > Adding delay parameter through command line, > Adding new

Re: [PATCH net-next 0/2] axienet clock additions

2021-03-14 Thread David Miller
From: Robert Hancock Date: Thu, 11 Mar 2021 14:11:15 -0600 > Add support to the axienet driver for controlling all of the clocks that > the logic core may utilize. This series does not apply to net-next, please respin. Thanks.

Re: [PATCH v3 net-next 4/6] linux/etherdevice.h: misc trailing whitespace cleanup

2021-03-14 Thread Vladimir Oltean
On Sun, Mar 14, 2021 at 11:11:32AM +, Alexander Lobakin wrote: > Caught by the text editor. Fix it separately from the actual changes. > > Signed-off-by: Alexander Lobakin > --- > include/linux/etherdevice.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/li

Re: [PATCH net] flow_dissector: fix byteorder of dissected ICMP ID

2021-03-14 Thread Vladimir Oltean
On Sun, Mar 14, 2021 at 09:21:40PM +0100, Jakub Sitnicki wrote: > On Fri, Mar 12, 2021 at 09:08 PM CET, Alexander Lobakin wrote: > > flow_dissector_key_icmp::id is of type u16 (CPU byteorder), > > ICMP header has its ID field in network byteorder obviously. > > Sparse says: > > > > net/core/flow_di

Re: [PATCH net] flow_dissector: fix byteorder of dissected ICMP ID

2021-03-14 Thread Jakub Sitnicki
On Fri, Mar 12, 2021 at 09:08 PM CET, Alexander Lobakin wrote: > flow_dissector_key_icmp::id is of type u16 (CPU byteorder), > ICMP header has its ID field in network byteorder obviously. > Sparse says: > > net/core/flow_dissector.c:178:43: warning: restricted __be16 degrades to > integer > > Conv

[PATCH 08/10] rsi: rsi_debugfs: fix file header comment syntax

2021-03-14 Thread Aditya Srivastava
The opening comment mark '/**' is used for highlighting the beginning of kernel-doc comments. The header comment used in drivers/net/wireless/rsi/rsi_debugfs.h follows kernel-doc syntax, i.e. starts with '/**'. But the content inside the comment does not comply with kernel-doc specifications (i.e.

[PATCH 10/10] rsi: rsi_usb: fix file header comment syntax

2021-03-14 Thread Aditya Srivastava
The opening comment mark '/**' is used for highlighting the beginning of kernel-doc comments. The header comment used in drivers/net/wireless/rsi/rsi_usb.h follows kernel-doc syntax, i.e. starts with '/**'. But the content inside the comment does not comply with kernel-doc specifications (i.e., fu

[PATCH 09/10] rsi: rsi_sdio: fix file header comment syntax

2021-03-14 Thread Aditya Srivastava
The opening comment mark '/**' is used for highlighting the beginning of kernel-doc comments. The header comment used in drivers/net/wireless/rsi/rsi_sdio.h follows kernel-doc syntax, i.e. starts with '/**'. But the content inside the comment does not comply with kernel-doc specifications (i.e., f

[PATCH 07/10] rsi: rsi_hal: fix file header comment syntax

2021-03-14 Thread Aditya Srivastava
The opening comment mark '/**' is used for highlighting the beginning of kernel-doc comments. The header comment used in drivers/net/wireless/rsi/rsi_hal.h follows kernel-doc syntax, i.e. starts with '/**'. But the content inside the comment does not comply with kernel-doc specifications (i.e., fu

[PATCH 06/10] rsi: rsi_main: fix file header comment syntax

2021-03-14 Thread Aditya Srivastava
The opening comment mark '/**' is used for highlighting the beginning of kernel-doc comments. The header comment used in drivers/net/wireless/rsi/rsi_main.h follows kernel-doc syntax, i.e. starts with '/**'. But the content inside the comment does not comply with kernel-doc specifications (i.e., f

[PATCH 05/10] rsi: rsi_mgmt: fix file header comment syntax

2021-03-14 Thread Aditya Srivastava
The opening comment mark '/**' is used for highlighting the beginning of kernel-doc comments. The header comment used in drivers/net/wireless/rsi/rsi_mgmt.h follows kernel-doc syntax, i.e. starts with '/**'. But the content inside the comment does not comply with kernel-doc specifications (i.e., f

[PATCH 04/10] rsi: rsi_common: fix file header comment syntax

2021-03-14 Thread Aditya Srivastava
The opening comment mark '/**' is used for highlighting the beginning of kernel-doc comments. The header comment used in drivers/net/wireless/rsi/rsi_common.h follows kernel-doc syntax, i.e. starts with '/**'. But the content inside the comment does not comply with kernel-doc specifications (i.e.,

[PATCH 01/10] rsi: rsi_boot_params: fix file header comment syntax

2021-03-14 Thread Aditya Srivastava
The opening comment mark '/**' is used for highlighting the beginning of kernel-doc comments. The header comment used in drivers/net/wireless/rsi/rsi_boot_params.h follows kernel-doc syntax, i.e. starts with '/**'. But the content inside the comment does not comply with kernel-doc specifications (

[PATCH 03/10] rsi: rsi_ps: fix file header comment syntax

2021-03-14 Thread Aditya Srivastava
The opening comment mark '/**' is used for highlighting the beginning of kernel-doc comments. The header comment used in drivers/net/wireless/rsi/rsi_ps.h follows kernel-doc syntax, i.e. starts with '/**'. But the content inside the comment does not comply with kernel-doc specifications (i.e., fun

[PATCH 02/10] rsi: rsi_coex: fix file header comment syntax

2021-03-14 Thread Aditya Srivastava
The opening comment mark '/**' is used for highlighting the beginning of kernel-doc comments. The header comment used in drivers/net/wireless/rsi/rsi_coex.h follows kernel-doc syntax, i.e. starts with '/**'. But the content inside the comment does not comply with kernel-doc specifications (i.e., f

[PATCH 00/10] rsi: fix comment syntax in file headers

2021-03-14 Thread Aditya Srivastava
The opening comment mark '/**' is used for highlighting the beginning of kernel-doc comments. There are files in drivers/net/wireless/rsi which follow this syntax in their file headers, i.e. start with '/**' like comments, which causes unexpected warnings from kernel-doc. E.g., running scripts/ker

[PATCH net-next 3/3] iwlwifi: use dma_set_mask_and_coherent

2021-03-14 Thread Heiner Kallweit
Simplify the code by using dma_set_mask_and_coherent(). Signed-off-by: Heiner Kallweit --- drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c b/drivers/net/wireless/intel/

[PATCH net-next 1/3] iwlwifi: use DECLARE_BITMAP macro

2021-03-14 Thread Heiner Kallweit
Use DECLARE_BITMAP macro to simplify the code. Signed-off-by: Heiner Kallweit --- drivers/net/wireless/intel/iwlwifi/fw/img.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/fw/img.h b/drivers/net/wireless/intel/iwlwifi/fw/img.h index 1

[PATCH net-next 2/3] iwlwifi: switch "index larger than supported by driver" warning to debug level

2021-03-14 Thread Heiner Kallweit
If a chip supports additional API calls that are not supported by the driver yet, then this is no reason to bother users with a warning. Therefore switch the message to debug level. Signed-off-by: Heiner Kallweit --- drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 10 -- 1 file changed, 4

[PATCH net-next 0/3] iwlwifi: series with smaller improvements

2021-03-14 Thread Heiner Kallweit
Series includes smaller improvements. Heiner Kallweit (3): iwlwifi: use DECLARE_BITMAP macro iwlwifi: switch "index larger than supported by driver" warning to debug level iwlwifi: use dma_set_mask_and_coherent drivers/net/wireless/intel/iwlwifi/fw/img.h | 4 ++-- drivers/net/wire

[PATCH] net: arcnet: com20020 fix error handling

2021-03-14 Thread Tong Zhang
There are two issues when handling error case in com20020pci_probe() 1. priv might be not initialized yet when calling com20020pci_remove() from com20020pci_probe(), since the priv is set at the very last but it can jump to error handling in the middle and priv remains NULL. 2. memory leak - the n

[PATCH] libbpf: avoid inline hint definition from 'linux/stddef.h'

2021-03-14 Thread Pedro Tammela
Linux headers might pull 'linux/stddef.h' which defines '__always_inline' as the following: #ifndef __always_inline #define __always_inline __inline__ #endif This becomes an issue if the program picks up the 'linux/stddef.h' definition as the macro now just hints inline to clang. This c

[PATCH V4 net-next 4/5] net: add support for sending RFC 8335 PROBE messages

2021-03-14 Thread Andreas Roeseler
Modify the ping_supported function to support PROBE message types. This allows tools such as the ping command in the iputils package to be modified to send PROBE requests through the existing framework for sending ping requests. Signed-off-by: Andreas Roeseler --- net/ipv4/ping.c | 4 +++- 1 fil

[PATCH V4 net-next 5/5] icmp: add response to RFC 8335 PROBE messages

2021-03-14 Thread Andreas Roeseler
Modify the icmp_rcv function to check PROBE messages and call icmp_echo if a PROBE request is detected. Modify the existing icmp_echo function to respond ot both ping and PROBE requests. This was tested using a custom modification to the iputils package and wireshark. It supports IPV4 probing by

[PATCH V4 net-next 3/5] net: add sysctl for enabling RFC 8335 PROBE messages

2021-03-14 Thread Andreas Roeseler
Section 8 of RFC 8335 specifies potential security concerns of responding to PROBE requests, and states that nodes that support PROBE functionality MUST be able to enable/disable responses and that responses MUST be disabled by default Signed-off-by: Andreas Roeseler --- Changes: v1 -> v2: - Com

[PATCH V4 net-next 2/5] ICMPV6: add support for RFC 8335 PROBE

2021-03-14 Thread Andreas Roeseler
Add definitions for the ICMPV6 type of Extended Echo Request and Extended Echo Reply, as defined by sections 2 and 3 of RFC 8335. Signed-off-by: Andreas Roeseler --- include/uapi/linux/icmpv6.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/uapi/linux/icmpv6.h b/include/uapi/linu

[PATCH V4 net-next 1/5] icmp: add support for RFC 8335 PROBE

2021-03-14 Thread Andreas Roeseler
Add definitions for PROBE ICMP types and codes. Add AFI definitions for IP and IPV6 as specified by IANA Add a struct to represent the additional header when probing by IP address (ctype == 3) for use in parsing incoming PROBE messages Add a struct to represent the entire Interface Identificatio

[PATCH V4 net-next 0/5] add support for RFC 8335 PROBE

2021-03-14 Thread Andreas Roeseler
The popular utility ping has several severe limitations, such as the inability to query specific interfaces on a node and requiring bidirectional connectivity between the probing and probed interfaces. RFC 8335 attempts to solve these limitations by creating the new utility PROBE which is a special

Re: [PATCH 15/17] iommu: remove DOMAIN_ATTR_NESTING

2021-03-14 Thread Christoph Hellwig
On Sun, Mar 14, 2021 at 11:44:52AM +0100, Auger Eric wrote: > As mentionned by Robin, there are series planning to use > DOMAIN_ATTR_NESTING to get info about the nested caps of the iommu (ARM > and Intel): > > [Patch v8 00/10] vfio: expose virtual Shared Virtual Addressing to VMs > patches 1, 2,

Re: [PATCH iproute2-next 4/6] nexthop: Add ability to specify group type

2021-03-14 Thread David Ahern
On 3/12/21 10:23 AM, Petr Machata wrote: > From: Petr Machata > > From: Ido Schimmel All of the patches have the above. If Ido is the author and you are sending, AIUI you add your Signed-off-by below his. > > Next patches are going to add a 'resilient' nexthop group type, so allow > users to

Re: [PATCH net-next 07/10] selftests: fib_nexthops: Test resilient nexthop groups

2021-03-14 Thread David Ahern
On 3/12/21 9:50 AM, Petr Machata wrote: > From: Ido Schimmel > > Add test cases for resilient nexthop groups. Exhaustive forwarding tests > are added separately under net/forwarding/. > ... > > Signed-off-by: Ido Schimmel > Co-developed-by: Petr Machata > Signed-off-by: Petr Machata > --- >

Re: [PATCH net-next 06/10] selftests: fib_nexthops: List each test case in a different line

2021-03-14 Thread David Ahern
On 3/12/21 9:50 AM, Petr Machata wrote: > From: Ido Schimmel > > The lines with the IPv4 and IPv6 test cases are already very long and > more test cases will be added in subsequent patches. > > List each test case in a different line to make it easier to extend the > test with more test cases. >

Re: [PATCH net-next 05/10] selftests: fib_nexthops: Declutter test output

2021-03-14 Thread David Ahern
On 3/12/21 9:50 AM, Petr Machata wrote: > From: Ido Schimmel > > Before: > > # ./fib_nexthops.sh -t ipv4_torture > > IPv4 runtime torture > > TEST: IPv4 torture test [ OK ] > ./fib_nexthops.sh: line 213: 19376 Killed

[PATCH net-next] atm: delete include/linux/atm_suni.h

2021-03-14 Thread Alexey Dobriyan
This file has been effectively empty since 2.3.99-pre3 ! Signed-off-by: Alexey Dobriyan --- drivers/atm/fore200e.c |1 - drivers/atm/suni.c |1 - include/linux/atm_suni.h | 12 3 files changed, 14 deletions(-) --- a/drivers/atm/fore200e.c +++ b/drivers/atm/fore20

Re: [PATCH 2/5] mm/page_alloc: Add a bulk page allocator

2021-03-14 Thread Chuck Lever III
> On Mar 14, 2021, at 8:52 AM, Mel Gorman wrote: > > On Sat, Mar 13, 2021 at 07:33:43PM +, Matthew Wilcox wrote: >> On Sat, Mar 13, 2021 at 04:56:31PM +, Chuck Lever III wrote: >>> IME lists are indeed less CPU-efficient, but I wonder if that >>> expense is insignificant compared to se

[PATCH net-next v2] bonding: Added -ENODEV interpret for slaves option

2021-03-14 Thread Jianlin Lv
When the incorrect interface name is stored in the slaves/active_slave option of the bonding sysfs, the kernel does not record the log that interface does not exist. This patch adds a log for -ENODEV error, which will facilitate users to figure out such issue. Signed-off-by: Jianlin Lv --- v2: U

[PATCH net-next] net: export dev_set_threaded symbol

2021-03-14 Thread Lorenzo Bianconi
For wireless devices (e.g. mt76 driver) multiple net_devices belongs to the same wireless phy and the napi object is registered in a dummy netdevice related to the wireless phy. Export dev_set_threaded in order to be reused in device drivers enabling threaded NAPI. Signed-off-by: Lorenzo Bianconi

Re: [PATCH net-next] net: dsa: hellcreek: Offload bridge port flags

2021-03-14 Thread Leon Romanovsky
On Sun, Mar 14, 2021 at 01:52:08PM +0100, Kurt Kanzenbach wrote: > The switch implements unicast and multicast filtering per port. > Add support for it. By default filtering is disabled. > > Signed-off-by: Kurt Kanzenbach > --- > drivers/net/dsa/hirschmann/hellcreek.c | 129 --

Re: [PATCH v3 1/5] thermal/drivers/core: Use a char pointer for the cooling device name

2021-03-14 Thread Daniel Lezcano
On 14/03/2021 13:47, Ido Schimmel wrote: > On Sun, Mar 14, 2021 at 12:13:29PM +0100, Daniel Lezcano wrote: >> We want to have any kind of name for the cooling devices as we do no >> longer want to rely on auto-numbering. Let's replace the cooling >> device's fixed array by a char pointer to be allo

Re: [BUG] net: rds: rds_send_probe memory leak

2021-03-14 Thread Fatih Yildirim
On Sun, 2021-03-14 at 13:44 +0100, Greg KH wrote: > On Sun, Mar 14, 2021 at 03:19:05PM +0300, Fatih Yildirim wrote: > > On Sun, 2021-03-14 at 09:36 +0100, Greg KH wrote: > > > On Sun, Mar 14, 2021 at 11:23:10AM +0300, Fatih Yildirim wrote: > > > > Hi Santosh, > > > > > > > > I've been working on a

Re: [PATCH net-next v2 4/4] net: dsa: hellcreek: Add devlink FDB region

2021-03-14 Thread Kurt Kanzenbach
On Sat Mar 13 2021, Vladimir Oltean wrote: > On Sat, Mar 13, 2021 at 10:39:39AM +0100, Kurt Kanzenbach wrote: >> Allow to dump the FDB table via devlink. This is a useful debugging feature. >> >> Signed-off-by: Kurt Kanzenbach >> Reviewed-by: Andrew Lunn >> --- > > Reviewed-by: Vladimir Oltean

[PATCH net-next] net: dsa: hellcreek: Offload bridge port flags

2021-03-14 Thread Kurt Kanzenbach
The switch implements unicast and multicast filtering per port. Add support for it. By default filtering is disabled. Signed-off-by: Kurt Kanzenbach --- drivers/net/dsa/hirschmann/hellcreek.c | 129 - 1 file changed, 104 insertions(+), 25 deletions(-) diff --git a/driver

Re: [PATCH 2/5] mm/page_alloc: Add a bulk page allocator

2021-03-14 Thread Mel Gorman
On Sat, Mar 13, 2021 at 07:33:43PM +, Matthew Wilcox wrote: > On Sat, Mar 13, 2021 at 04:56:31PM +, Chuck Lever III wrote: > > IME lists are indeed less CPU-efficient, but I wonder if that > > expense is insignificant compared to serialization primitives like > > disabling and re-enabling I

Re: [PATCH v3 1/5] thermal/drivers/core: Use a char pointer for the cooling device name

2021-03-14 Thread Ido Schimmel
On Sun, Mar 14, 2021 at 12:13:29PM +0100, Daniel Lezcano wrote: > We want to have any kind of name for the cooling devices as we do no > longer want to rely on auto-numbering. Let's replace the cooling > device's fixed array by a char pointer to be allocated dynamically > when registering the cooli

Re: [BUG] net: rds: rds_send_probe memory leak

2021-03-14 Thread Greg KH
On Sun, Mar 14, 2021 at 03:19:05PM +0300, Fatih Yildirim wrote: > On Sun, 2021-03-14 at 09:36 +0100, Greg KH wrote: > > On Sun, Mar 14, 2021 at 11:23:10AM +0300, Fatih Yildirim wrote: > > > Hi Santosh, > > > > > > I've been working on a memory leak bug reported by syzbot. > > > https://syzkaller.a

[PATCH mlx5-next v8 1/4] PCI: Add a sysfs file to change the MSI-X table size of SR-IOV VFs

2021-03-14 Thread Leon Romanovsky
A typical cloud provider SR-IOV use case is to create many VFs for use by guest VMs. The VFs may not be assigned to a VM until a customer requests a VM of a certain size, e.g., number of CPUs. A VF may need MSI-X vectors proportional to the number of CPUs in the VM, but there is no standard way to

[PATCH mlx5-next v8 4/4] net/mlx5: Implement sriov_get_vf_total_msix/count() callbacks

2021-03-14 Thread Leon Romanovsky
The mlx5 implementation executes a firmware command on the PF to change the configuration of the selected VF. Signed-off-by: Leon Romanovsky --- .../net/ethernet/mellanox/mlx5/core/main.c| 2 ++ .../ethernet/mellanox/mlx5/core/mlx5_core.h | 7 .../net/ethernet/mellanox/mlx5/core/sri

[PATCH mlx5-next v8 3/4] net/mlx5: Dynamically assign MSI-X vectors count

2021-03-14 Thread Leon Romanovsky
The number of MSI-X vectors is a PCI property visible through lspci. The field is read-only and configured by the device. The mlx5 devices work in a static or dynamic assignment mode. Static assignment means that all newly created VFs have a preset number of MSI-X vectors determined by device conf

[PATCH mlx5-next v8 2/4] net/mlx5: Add dynamic MSI-X capabilities bits

2021-03-14 Thread Leon Romanovsky
These new fields declare the number of MSI-X vectors that is possible to allocate on the VF through PF configuration. Value must be in range defined by min_dynamic_vf_msix_table_size and max_dynamic_vf_msix_table_size. The driver should continue to query its MSI-X table through PCI configuration

[PATCH mlx5-next v8 0/4] Dynamically assign MSI-X vectors count

2021-03-14 Thread Leon Romanovsky
- Changelog v8: * Added "physical/virtual function" words near PF and VF acronyms. v7: https://lore.kernel.org/linux-pci/20210301075524.441609-1-l...@kernel.org * Rebase on top v5.12-rc1 * More english fixes * Retur

Re: [RFC net-next v2 3/3] devlink: add more failure modes

2021-03-14 Thread Eran Ben Elisha
On 3/11/2021 6:49 PM, Jakub Kicinski wrote: On Thu, 11 Mar 2021 16:23:09 +0200 Eran Ben Elisha wrote: On 3/11/2021 5:26 AM, Jakub Kicinski wrote: Pending vendors adding the right reporters. << Would you like Nvidia to reply with the remedy per reporter or to actually prepare the patch? You

[PATCH net-next 10/11] mlxsw: spectrum: Report extra metadata to psample module

2021-03-14 Thread Ido Schimmel
From: Ido Schimmel Make use of the previously added metadata and report it to the psample module. The metadata is read from the skb's control block, which was initialized by the bus driver (i.e., 'mlxsw_pci') after decoding the packet's Completion Queue Element (CQE). Signed-off-by: Ido Schimmel

[PATCH net-next 11/11] selftests: mlxsw: Add tc sample tests

2021-03-14 Thread Ido Schimmel
From: Ido Schimmel Test that packets are sampled when tc-sample is used and that reported metadata is correct. Two sets of hosts (with and without LAG) are used, since metadata extraction in mlxsw is a bit different when LAG is involved. # ./tc_sample.sh TEST: tc sample rate (forward)

[PATCH net-next 08/11] mlxsw: spectrum: Remove unnecessary RCU read-side critical section

2021-03-14 Thread Ido Schimmel
From: Ido Schimmel Since commit 7d8e8f3433dc ("mlxsw: core: Increase scope of RCU read-side critical section"), all Rx handlers are called from an RCU read-side critical section. Remove the unnecessary rcu_read_lock() / rcu_read_unlock(). Signed-off-by: Ido Schimmel Reviewed-by: Jiri Pirko --

[PATCH net-next 07/11] mlxsw: pci: Set extra metadata in skb control block

2021-03-14 Thread Ido Schimmel
From: Ido Schimmel Packets that are mirrored / sampled to the CPU have extra metadata encoded in their corresponding Completion Queue Element (CQE). Retrieve this metadata from the CQE and set it in the skb control block so that it could be accessed by the switch driver (i.e., 'mlxsw_spectrum').

  1   2   >