On Mär 13 2021, Emil Renner Berthing wrote:
> As you can see I haven't updated OpenSBI or u-boot in a while
Does it also work if you use the u-boot SPL instead of FSBL?
Andreas.
--
Andreas Schwab, sch...@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"A
> > > + if (phy->interface != PHY_INTERFACE_MODE_RMII) {
> > > + netdev_err(netdev, "unsupported phy mode: %s\n",
> > > +phy_modes(phy->interface));
> > > + phy_disconnect(phy);
> > > + netdev->phydev = NULL;
> > > + return -EINVAL;
> > > + }
> >
On Fri, Mar 12, 2021 at 10:15 PM Eric Dumazet wrote:
>
>
>
> On 3/12/21 1:10 AM, patchwork-bot+netdev...@kernel.org wrote:
> > Hello:
> >
> > This patch was applied to netdev/net.git (refs/heads/master):
> >
> > On Thu, 11 Mar 2021 10:57:36 +0800 you wrote:
> >> From: Tonghao Zhang
> >>
> >> Intr
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Fri, 12 Mar 2021 16:30:25 -0800 you wrote:
> Minor tweaks and improvement of wording about the diagnose callback.
>
> Signed-off-by: Jakub Kicinski
> ---
> Documentation/networking/devlink/devlink-health.rst | 13 +++
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Sat, 13 Mar 2021 01:04:13 +0100 you wrote:
> This commit fixes three spelling typos in devlink-dpipe.rst and
> devlink-port.rst.
>
> Signed-off-by: Eva Dengler
> ---
> Documentation/networking/devlink/devlink-dpipe.rst | 2
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Sat, 13 Mar 2021 11:15:36 +0530 you wrote:
> s/calclation/calculation/
>
> Signed-off-by: Bhaskar Chowdhury
> ---
> drivers/net/ethernet/marvell/sky2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> [...
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Sat, 13 Mar 2021 14:06:49 +0530 you wrote:
> Added a blank line after structure declaration.
> This is done to maintain code uniformity.
>
> Signed-off-by: Sanjana Srinidhi
> ---
> drivers/net/vxlan.c | 1 +
> 1 file
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Sat, 13 Mar 2021 13:18:26 + you wrote:
> Commit eaf4fac47807 ("net: stmmac: Do not accept invalid MTU values")
> started using the TX FIFO size to verify what counts as a valid MTU
> request for the stmmac driver. T
None of these apply to net-next as per the patchwork automated checks. Any
idea why?
Thanks.
Hi Martin,
Could you ack? Thanks!
On 3/13/2021 1:39 AM, Kurt Kanzenbach wrote:
> Allow to dump the FDB table via devlink. This is a useful debugging feature.
>
> Signed-off-by: Kurt Kanzenbach
> Reviewed-by: Andrew Lunn
Reviewed-by: Florian Fainelli
--
Florian
On 3/13/2021 1:39 AM, Kurt Kanzenbach wrote:
> hellcreek_select_vlan() takes a boolean instead of an integer.
> So, use false accordingly.
>
> Signed-off-by: Kurt Kanzenbach
> Reviewed-by: Andrew Lunn
Reviewed-by: Florian Fainelli
--
Florian
On 3/13/2021 1:39 AM, Kurt Kanzenbach wrote:
> There are two functions which need to populate fdb entries. Move that to a
> helper function.
>
> Signed-off-by: Kurt Kanzenbach
> Reviewed-by: Andrew Lunn
Reviewed-by: Florian Fainelli
--
Florian
On 3/13/2021 1:39 AM, Kurt Kanzenbach wrote:
> Allow to dump the VLAN table via devlink. This especially useful, because the
> driver internally leverages VLANs for the port separation. These are not
> visible
> via the bridge utility.
>
> Signed-off-by: Kurt Kanzenbach
Reviewed-by: Florian
Hi Andrew,
Thank you for the detailed review!
On Sat, Mar 13, 2021 at 02:01:19AM +0100, Andrew Lunn wrote:
> On Thu, Mar 11, 2021 at 03:20:13AM +0200, Cristian Ciocaltea wrote:
> > +static inline void owl_emac_reg_set(struct owl_emac_priv *priv,
> > + u32 reg, u32 bi
On Fri, 12 Mar 2021 22:35:35 -0800
ishaangandhi wrote:
> + // Always add if_index to the IIO
The kernel networking code has not used C++ style comments
Checkpatch used to complain about it.
Hi Yunsheng,
On Sat, Mar 13, 2021 at 10:47:47AM +0800, Yunsheng Lin wrote:
> Currently pfifo_fast has both TCQ_F_CAN_BYPASS and TCQ_F_NOLOCK
> flag set, but queue discipline by-pass does not work for lockless
> qdisc because skb is always enqueued to qdisc even when the qdisc
> is empty, see __dev
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Fri, 12 Mar 2021 15:08:28 +0100 you wrote:
> This series enhances the TC policer action implementation to allow a
> policer action instance to enforce a rate-limit based on
> packets-per-second, configurable using a pac
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Sat, 13 Mar 2021 10:39:35 +0100 you wrote:
> Hi,
>
> add support for dumping the VLAN and FDB table via devlink. As the driver uses
> internal VLANs and static FDB entries, this is a useful debugging feature.
>
> Chan
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Fri, 12 Mar 2021 16:47:24 +0100 you wrote:
> From: Sebastian Andrzej Siewior
>
> The usage of in_interrupt() in non-core code is phased out. Ideally the
> information of the calling context should be passed by the call
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 12 Mar 2021 09:12:48 -0600 you wrote:
> When a QMI handle is initialized, an array of message handler
> structures is provided, defining how any received message should
> be handled based on its type and message ID. The
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Fri, 12 Mar 2021 16:50:12 +0800 you wrote:
> This series adds support for imp-controlled PHYs in the HNS3
> ethernet driver.
>
> Guangbin Huang (4):
> net: hns3: add support for imp-controlled PHYs
> net: hns3: add
Hi Andreas
On Wed, 10 Mar 2021 at 20:55, Andreas Schwab wrote:
> On Mär 09 2021, claudiu.bez...@microchip.com wrote:
> > I don't have a SiFive HiFive Unleashed to investigate this. Can you check
> > if reverting commits on macb driver b/w 5.10 and 5.11 solves your issues:
> >
> > git log --onelin
> > This interface is implemented in python scripts provided by the switch
> > platform vendor. Those scripts encode the mapping of CPLD i2c muxes
> > to i2c buses to port numbers, specific to each switch.
> >
> > At the bottom of that python stack, all EEPROM access goes through
> > open/seek/rea
On Sat, 13 Mar 2021 at 18:37, Andrii Nakryiko wrote:
>
> On Fri, Mar 12, 2021 at 10:07 AM Quentin Monnet wrote:
> >
> > 2021-03-11 10:45 UTC-0800 ~ Andrii Nakryiko
> > > On Thu, Mar 11, 2021 at 3:31 AM Quentin Monnet
> > > wrote:
> > >>
> > >> 2021-03-09 20:04 UTC-0800 ~ Andrii Nakryiko
> > >
Somehow when bpftool is compiled in -Og mode, compiler produces new warnings
about possibly uninitialized variables. Fix all the reported problems.
Fixes: 2119f2189df1 ("bpftool: add C output format option to btf dump
subcommand")
Signed-off-by: Andrii Nakryiko
---
tools/bpf/bpftool/btf.c | 3
xsk_ring_prod__reserve() doesn't necessarily set idx in some conditions, so
from static analysis point of view compiler is right about the problems like:
In file included from xdpxceiver.c:92:
xdpxceiver.c: In function ‘xsk_populate_fill_ring’:
/data/users/andriin/linux/tools/testing/selftests/bpf
Build selftests, bpftool, and libbpf in debug mode with DWARF data to
facilitate easier debugging.
In terms of impact on building and running selftests. Build is actually faster
now:
BEFORE: make -j60 380.21s user 37.87s system 1466% cpu 28.503 total
AFTER: make -j60 345.47s user 37.37s system
Build BPF selftests and libbpf and bpftool, that are used as part of
selftests, in debug mode (specifically, -Og). This makes it much simpler and
nicer to do development and/or bug fixing. See patch #4 for some unscientific
measurements.
This patch set fixes new maybe-unitialized warnings produced
Adding such anonymous padding fixes the issue with uninitialized portions of
bpf_xdp_set_link_opts when using LIBBPF_DECLARE_OPTS macro with inline field
initialization:
DECLARE_LIBBPF_OPTS(bpf_xdp_set_link_opts, opts, .old_fd = -1);
When such code is compiled in debug mode, compiler is generatin
'hash' stores not the flow hash, but the index of the GRO bucket
corresponding to it.
Change its name to 'bucket' to avoid confusion while reading lines
like '__set_bit(hash, &napi->gro_bitmask)'.
Signed-off-by: Alexander Lobakin
---
net/core/dev.c | 12 ++--
1 file changed, 6 insertions
gro_list_prepare() always returns &napi->gro_hash[bucket].list,
without any variations. Moreover, it uses 'napi' argument only to
have access to this list, and calculates the bucket index for the
second time (firstly it happens at the beginning of
dev_gro_receive()) to do that.
Given that dev_gro_r
This random series addresses some of suboptimal constructions used
in the main GRO entry point.
The main body is gro_list_prepare() simplification and pointer usage
optimization in dev_gro_receive() itself. Being mostly cosmetic, it
gives like +10 Mbps on my setup to both TCP and UDP (both single-
GRO bucket index doesn't change through the entire function.
Store a pointer to the corresponding bucket instead of its member
and use it consistently through the function.
It is performance-safe since &gro_list->list == gro_list.
Misc: remove superfluous braces around single-line branches.
Signe
Jianlin Lv wrote:
>After upgrading the kernel, the slave interface name is changed,
>Systemd cannot use the original configuration to create bond interface,
>thereby losing the connection with the host.
>
>Adding log for ENODEV will make it easier to find out such problem lies.
To be cle
Add Makefile infra to specify multi-file BPF object files (and derivative
skeletons). Add first selftest validating BPF static linker can merge together
successfully two independent BPF object files and resulting object and
skeleton are correct and usable.
Signed-off-by: Andrii Nakryiko
---
tool
Introduce BPF static linker APIs to libbpf. BPF static linker allows to
perform static linking of multiple BPF object files into a single combined
resulting object file, preserving all the BPF programs, maps, global
variables, etc.
Data sections (.bss, .data, .rodata, .maps, maps, etc) with the sa
Pass all individual BPF object files (progs/*.o) through `bpftool gen object`
command to validate that BPF static linker doesn't corrupt them.
Signed-off-by: Andrii Nakryiko
---
tools/testing/selftests/bpf/.gitignore | 1 +
tools/testing/selftests/bpf/Makefile | 8 +++-
2 files changed, 4
Add .BTF and .BTF.ext static linking logic.
When multiple BPF object files are linked together, their respective .BTF and
.BTF.ext sections are merged together. BTF types are not just concatenated,
but also deduplicated. .BTF.ext data is grouped by type (func info, line info,
core_relos) and targe
Rename btf_add_mem() and btf_ensure_mem() helpers that abstract away details
of dynamically resizable memory to use libbpf_ prefix, as they are not
BTF-specific. No functional changes.
Signed-off-by: Andrii Nakryiko
---
tools/lib/bpf/btf.c | 24
tools/lib/bpf
Add `bpftool gen object ...` command to statically
link multiple BPF ELF object files into a single output BPF ELF object file.
Similarly to existing '*.o' convention, bpftool is establishing a '*.bpfo'
convention for statically-linked BPF object files. Both .o and .bpfo suffixes
will be stripped
This patch set adds new libbpf APIs and their bpftool integration that allows
to perform static linking of BPF object files. Currently no extern resolution
across object files is performed. This is going to be the focus of the follow
up patches. But, given amount of code and logic necessary to perf
Add btf__add_type() API that performs shallow copy of a given BTF type from
the source BTF into the destination BTF. All the information and type IDs are
preserved, but all the strings encountered are added into the destination BTF
and corresponding offsets are rewritten. BTF type IDs are assumed t
Trigger vmlinux.h and BPF skeletons re-generation if detected that bpftool was
re-compiled. Otherwise full `make clean` is required to get updated skeletons,
if bpftool is modified.
Fixes: acbd06206bbb ("selftests/bpf: Add vmlinux.h selftest exercising tracing
of syscalls")
Signed-off-by: Andrii
Extract BTF logic for maintaining a set of strings data structure, used for
BTF strings section construction in writable mode, into separate re-usable
API. This data structure is going to be used by bpf_linker to maintains ELF
STRTAB section, which has the same layout as BTF strings section.
Sugge
btf_type_by_id() is internal-only convenience API returning non-const pointer
to struct btf_type. Expose it outside of btf.c for re-use.
Signed-off-by: Andrii Nakryiko
---
tools/lib/bpf/btf.c | 2 +-
tools/lib/bpf/libbpf_internal.h | 5 +
2 files changed, 6 insertions(+), 1 delet
Extract and generalize the logic to iterate BTF type ID and string offset
fields within BTF types and .BTF.ext data. Expose this internally in libbpf
for re-use by bpf_linker.
Additionally, complete strings deduplication handling for BTF.ext (e.g., CO-RE
access strings), which was previously missi
On Sat, Mar 13, 2021 at 04:56:31PM +, Chuck Lever III wrote:
> IME lists are indeed less CPU-efficient, but I wonder if that
> expense is insignificant compared to serialization primitives like
> disabling and re-enabling IRQs, which we are avoiding by using
> bulk page allocation.
Cache misse
On Fri, Mar 12, 2021 at 10:07 AM Quentin Monnet wrote:
>
> 2021-03-11 10:45 UTC-0800 ~ Andrii Nakryiko
> > On Thu, Mar 11, 2021 at 3:31 AM Quentin Monnet
> > wrote:
> >>
> >> 2021-03-09 20:04 UTC-0800 ~ Andrii Nakryiko
> >>> Add `bpftool gen bpfo ...` command to statically
> >>> link multiple
On Fri, Mar 12, 2021 at 4:02 AM Jakub Sitnicki wrote:
>
> On Wed, Mar 10, 2021 at 06:32 AM CET, Cong Wang wrote:
> > diff --git a/net/core/sock_map.c b/net/core/sock_map.c
> > index dd53a7771d7e..26ba47b099f1 100644
> > --- a/net/core/sock_map.c
> > +++ b/net/core/sock_map.c
> > @@ -1540,6 +1540,7
> On Mar 13, 2021, at 11:39 AM, Matthew Wilcox wrote:
>
> On Sat, Mar 13, 2021 at 01:16:48PM +, Mel Gorman wrote:
>>> I'm not claiming the pagevec is definitely a win, but it's very
>>> unclear which tradeoff is actually going to lead to better performance.
>>> Hopefully Jesper or Chuck ca
Signed-off-by: Chinmayi Shetty
---
drivers/net/gtp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c
index efe5247d8c42..79998f4394e5 100644
--- a/drivers/net/gtp.c
+++ b/drivers/net/gtp.c
@@ -437,7 +437,7 @@ static inline void gtp1_push_h
On Sat, Mar 13, 2021 at 01:16:48PM +, Mel Gorman wrote:
> > I'm not claiming the pagevec is definitely a win, but it's very
> > unclear which tradeoff is actually going to lead to better performance.
> > Hopefully Jesper or Chuck can do some tests and figure out what actually
> > works better w
Signed-off-by: Chinmayi Shetty
---
drivers/net/gtp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c
index efe5247d8c42..79998f4394e5 100644
--- a/drivers/net/gtp.c
+++ b/drivers/net/gtp.c
@@ -437,7 +437,7 @@ static inline void gtp1_push_h
On Fri, Mar 12, 2021 at 11:09:06AM +, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> Lee Jones (4):
> ptp_pch: Remove unused function 'pch_ch_control_read()'
>
Commit eaf4fac47807 ("net: stmmac: Do not accept invalid MTU values")
started using the TX FIFO size to verify what counts as a valid MTU
request for the stmmac driver. This is unset for the ipq806x variant.
Looking at older patches for this it seems the RX + TXs buffers can be
up to 8k, so set ap
After upgrading the kernel, the slave interface name is changed,
Systemd cannot use the original configuration to create bond interface,
thereby losing the connection with the host.
Adding log for ENODEV will make it easier to find out such problem lies.
Signed-off-by: Jianlin Lv
---
drivers/ne
On Fri, Mar 12, 2021 at 11:44:09AM -0800, Alexander Duyck wrote:
> > - /* FUTURE development:
> > -*
> > -* Current slow-path essentially falls back to single page
> > -* allocations, which doesn't improve performance. This code
> > -* need bulk allocation sup
From: Alexander Lobakin
Date: Sat, 13 Mar 2021 11:37:03 +
> This little number makes all of the flow dissection functions take
> raw input data pointer as const (1-5) and shuffles the branches in
> __skb_header_pointer() according to their hit probability.
>
> The result is +20 Mbps per flow/
Hi Jason,> Thanks for the patch and sorry for the delay in reviewing it.
Seeing
> the basic scaffolding for getting netlink notifiers working with
> WireGuard is enlightening; it looks surprisingly straightforward.
Glad to hear that this is a welcome feature.
>
> There are three classes of things
On Fri, Mar 12, 2021 at 09:08:23PM +, Matthew Wilcox wrote:
> > > > The result of the API is to deliver pages as a double-linked list via
> > > > LRU (page->lru member). If you are planning to use llist, then how to
> > > > handle this API change later?
> > > >
> > > > Have you notice that th
On Fri, Mar 12, 2021 at 07:22:43PM +, Chuck Lever III wrote:
> Mel, I can send you a tidied and tested update to this patch,
> or you can drop the two NFSD patches and I can submit them via
> the NFSD tree when alloc_pages_bulk() is merged.
>
Send me a tidied version anyway. I'm happy enough
On Sat, Mar 13, 2021 at 10:39:39AM +0100, Kurt Kanzenbach wrote:
> Allow to dump the FDB table via devlink. This is a useful debugging feature.
>
> Signed-off-by: Kurt Kanzenbach
> Reviewed-by: Andrew Lunn
> ---
Reviewed-by: Vladimir Oltean
By the way, what user space program do you use to du
On Sat, Mar 13, 2021 at 10:39:38AM +0100, Kurt Kanzenbach wrote:
> There are two functions which need to populate fdb entries. Move that to a
> helper function.
>
> Signed-off-by: Kurt Kanzenbach
> Reviewed-by: Andrew Lunn
> ---
> drivers/net/dsa/hirschmann/hellcreek.c | 85 +---
On Sat, Mar 13, 2021 at 10:39:37AM +0100, Kurt Kanzenbach wrote:
> hellcreek_select_vlan() takes a boolean instead of an integer.
> So, use false accordingly.
>
> Signed-off-by: Kurt Kanzenbach
> Reviewed-by: Andrew Lunn
> ---
Reviewed-by: Vladimir Oltean
On Sat, Mar 13, 2021 at 10:39:36AM +0100, Kurt Kanzenbach wrote:
> Allow to dump the VLAN table via devlink. This especially useful, because the
> driver internally leverages VLANs for the port separation. These are not
> visible
> via the bridge utility.
>
> Signed-off-by: Kurt Kanzenbach
> ---
{,__}skb_header_pointer() helpers exist mainly for preventing
accesses-beyond-end of the linear data.
In the vast majorify of cases, they bail out on the first condition.
All code going after is mostly a fallback.
Mark the most common branch as 'likely' one to move it in-line.
Also, skb_copy_bits()
It's used only for flow dissection, which now takes constant data
pointers.
Signed-off-by: Alexander Lobakin
---
include/linux/etherdevice.h | 2 +-
net/ethernet/eth.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/etherdevice.h b/include/linux/ethe
Caught by the text editor. Fix it separately from the actual changes.
Signed-off-by: Alexander Lobakin
---
include/linux/etherdevice.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/etherdevice.h b/include/linux/etherdevice.h
index 2e5debc0373c..bcb2f81baafb 10
Flow Dissector code never modifies the input buffer, neither skb nor
raw data.
Make @data argument const for all of the Flow dissector's functions.
Signed-off-by: Alexander Lobakin
---
include/linux/skbuff.h | 15 ++---
include/net/flow_dissector.h | 2 +-
net/core/flow_dissector.
The function never modifies the input buffer, so @data argument
can be marked as const.
This implies one harmless cast-away.
Signed-off-by: Alexander Lobakin
---
include/linux/skbuff.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/skbuff.h b/include/linu
BPF Flow dissection programs are read-only and don't touch input
buffers.
Mark @data and @data_end in struct bpf_flow_dissector as const in
preparation for global input constifying.
Signed-off-by: Alexander Lobakin
---
include/net/flow_dissector.h | 4 ++--
1 file changed, 2 insertions(+), 2 del
This little number makes all of the flow dissection functions take
raw input data pointer as const (1-5) and shuffles the branches in
__skb_header_pointer() according to their hit probability.
The result is +20 Mbps per flow/core with one Flow Dissector pass
per packet. This affects RPS (with soft
hellcreek_select_vlan() takes a boolean instead of an integer.
So, use false accordingly.
Signed-off-by: Kurt Kanzenbach
Reviewed-by: Andrew Lunn
---
drivers/net/dsa/hirschmann/hellcreek.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/hirschmann/hellcreek.c
There are two functions which need to populate fdb entries. Move that to a
helper function.
Signed-off-by: Kurt Kanzenbach
Reviewed-by: Andrew Lunn
---
drivers/net/dsa/hirschmann/hellcreek.c | 85 +-
1 file changed, 43 insertions(+), 42 deletions(-)
diff --git a/drivers
Allow to dump the VLAN table via devlink. This especially useful, because the
driver internally leverages VLANs for the port separation. These are not visible
via the bridge utility.
Signed-off-by: Kurt Kanzenbach
---
drivers/net/dsa/hirschmann/hellcreek.c | 74 ++
driver
Hi,
add support for dumping the VLAN and FDB table via devlink. As the driver uses
internal VLANs and static FDB entries, this is a useful debugging feature.
Changes since v1:
* Drop memory reporting as there are better APIs to expose this
* Move comment to VLAN patch
Previous versions:
* h
Allow to dump the FDB table via devlink. This is a useful debugging feature.
Signed-off-by: Kurt Kanzenbach
Reviewed-by: Andrew Lunn
---
drivers/net/dsa/hirschmann/hellcreek.c | 62 ++
drivers/net/dsa/hirschmann/hellcreek.h | 1 +
2 files changed, 63 insertions(+)
diff
Added a blank line after structure declaration.
This is done to maintain code uniformity.
Signed-off-by: Sanjana Srinidhi
---
drivers/net/vxlan.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index 666dd201c3d5..7665817f3cb6 100644
--- a/drivers/ne
79 matches
Mail list logo
