[syzbot] general protection fault in bt_accept_unlink (2)

Hello, syzbot found the following issue on: HEAD commit:95b39f07 net: ethernet: mtk-star-emac: fix wrong unmap in .. git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=13658a5cd0 kernel config: https://syzkaller.appspot.com/x/.config?x=e2d5ba72abae4f14 dashboar

Re: [PATCH bpf-next v2 0/2] load-acquire/store-release barriers for AF_XDP rings

Hello: This series was applied to bpf/bpf-next.git (refs/heads/master): On Fri, 5 Mar 2021 10:41:11 +0100 you wrote: > This two-patch series introduces load-acquire/store-release barriers > for the AF_XDP rings. > > For most contemporary architectures, this is more effective than a > SPSC ring

Re: [PATCHv2 bpf-next] selftests/bpf: Fix test_attach_probe for powerpc uprobes

On Fri, Mar 5, 2021 at 5:42 AM Jiri Olsa wrote: > > When testing uprobes we the test gets GEP (Global Entry Point) > address from kallsyms, but then the function is called locally > so the uprobe is not triggered. > > Fixing this by adjusting the address to LEP (Local Entry Point) > for powerpc ar

[syzbot] general protection fault in klist_iter_exit

Hello, syzbot found the following issue on: HEAD commit:d310ec03 Merge tag 'perf-core-2021-02-17' of git://git.ker.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=1350c796d0 kernel config: https://syzkaller.appspot.com/x/.config?x=2b8307379601586a das

Re: [PATCH net 1/9] uapi: nfnetlink_cthelper.h: fix userspace compilation error

Hello: This series was applied to netdev/net.git (refs/heads/master): On Sat, 6 Mar 2021 13:12:15 +0100 you wrote: > From: "Dmitry V. Levin" > > Apparently, and > could not be included into the same > compilation unit because of a cut-and-paste typo in the former header. > > Fixes: 12f7a505

Re: [PATCH net 2/2] net: dsa: Always react to global bridge attribute changes

On Sat, Mar 06, 2021 at 07:17:09PM +0100, Tobias Waldekranz wrote: > On Sat, Mar 06, 2021 at 16:04, Vladimir Oltean wrote: > > On Sat, Mar 06, 2021 at 04:00:33PM +0200, Vladimir Oltean wrote: > >> Hi Tobias, > >> > >> On Sat, Mar 06, 2021 at 01:24:55AM +0100, Tobias Waldekranz wrote: > >> > This i

Re: [PATCH wpan 01/17] net: ieee802154: make shift exponent unsigned

Hi Stefan, On Thu, 4 Mar 2021 at 02:28, Stefan Schmidt wrote: > > Hello Alex. > > On 28.02.21 16:18, Alexander Aring wrote: > > This patch changes the iftype type variable to unsigned that it can > > never be reach a negative value. > > > > Reported-by: syzbot+7bf7b22759195c9a2...@syzkaller.appsp

[PATCH net-next] net: usb: log errors to dmesg/syslog

Errors in protocol should be logged when the driver aborts operations. If the driver can carry on and "humor" the device, then emitting the message as debug output level is fine. Signed-off-by: Grant Grundler --- drivers/net/usb/usbnet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Rep

[PATCH net-next] net: usb: cdc_ncm: emit dev_err on error paths

Several error paths in bind/probe code will only emit output using dev_dbg. But if we are going to fail the bind/probe, emit related output with "err" priority. Signed-off-by: Grant Grundler --- drivers/net/usb/cdc_ncm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Reposting

[PATCH] net: ethernet: chelsio: inline_crypto: Mundane typos fixed throughout the file chcr_ktls.c

Mundane typos fixes throughout the file. s/establised/established/ s/availbale/available/ s/vaues/values/ s/Incase/In case/ Signed-off-by: Bhaskar Chowdhury --- .../ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c| 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: Query on new ethtool RSS hashing options

On Sat, Mar 06, 2021 at 14:54, Vladimir Oltean wrote: > On Sat, Mar 06, 2021 at 05:38:14PM +0530, Sunil Kovvuri wrote: >> > Can you share the format of the DSA tag? Is there a driver for it >> > upstream? Do we need to represent it in union ethtool_flow_union? >> > >> >> No, there is no driver fo

Re: [RFC] devlink: health: add remediation type

On Sat, 6 Mar 2021 15:48:11 +0100 Andrew Lunn wrote: > +/** > > + * enum devlink_health_reporter_remedy - severity of remediation procedure > > + * @DLH_REMEDY_NONE: transient error, no remediation required > > + * @DLH_REMEDY_COMP_RESET: associated device component (e.g. device queue) > > + *

Re: [regression] Kernel panic on resume from sleep

> Great, I submitted the patch and marked it for stable inclusion! > > It should percolate through the trees in a couple of weeks. Cool. Jakub, thank you very much for your awesome assistance! Zbynek

Re: [Patch bpf-next v3 3/9] udp: implement ->sendmsg_locked()

On Fri, Mar 5, 2021 at 5:21 PM John Fastabend wrote: > > Cong Wang wrote: > > From: Cong Wang > > > > UDP already has udp_sendmsg() which takes lock_sock() inside. > > We have to build ->sendmsg_locked() on top of it, by adding > > a new parameter for whether the sock has been locked. > > > > Cc:

Re: [PATCH net 2/2] net: dsa: Always react to global bridge attribute changes

On Sat, Mar 06, 2021 at 16:04, Vladimir Oltean wrote: > On Sat, Mar 06, 2021 at 04:00:33PM +0200, Vladimir Oltean wrote: >> Hi Tobias, >> >> On Sat, Mar 06, 2021 at 01:24:55AM +0100, Tobias Waldekranz wrote: >> > This is the second attempt to provide a fix for the issue described in >> > 99b8202b1

Re: [PATCH AUTOSEL 5.11 16/67] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant

On Sat, Mar 06, 2021 at 12:38:02AM +0100, Pali Rohár wrote: On Thursday 04 March 2021 17:33:01 Sasha Levin wrote: On Thu, Feb 25, 2021 at 08:03:06PM +0100, Pali Rohár wrote: > On Wednesday 24 February 2021 07:49:34 Sasha Levin wrote: > > From: Pali Rohár > > > > [ Upstream commit f0b4f847673299

Re: VRF leaking doesn't work

On 3/2/21 3:57 AM, Greesha Mikhalkin wrote: > Main goal is that 100.255.254.3 should be reachable from vrf2. But > after this setup it doesn’t work. When i run `ping -I vrf2 > 100.255.254.3` it sends packets from source address that belongs to > vlan1 enslaved by vrf1. I can see in tcpdump that ICM

Re: [PATCH net 3/9] netfilter: nf_nat: undo erroneous tcp edemux lookup

On 6.3.2021 16.49, Mika Penttilä wrote: On 6.3.2021 14.12, Pablo Neira Ayuso wrote: From: Florian Westphal Under extremely rare conditions TCP early demux will retrieve the wrong socket. 1. local machine establishes a connection to a remote server, S, on port     p.     This gives:    

[BUG] Thunderbolt network package forward speed problem.

Hi! Authors of Linux thunderbolt-network driver: Problem: Thunderbolt network <- Software Router(NUC 11) <- 10G NIC Speed is normal= about 9-10Gbps Thunderbolt network -> Software Router(NUC 11) -> 10G NIC Speed is super = slow about 1Mbps-100Kbps Thunderbolt network <- Software Router(NUC

Re: [PATCH net 3/9] netfilter: nf_nat: undo erroneous tcp edemux lookup

On 6.3.2021 14.12, Pablo Neira Ayuso wrote: From: Florian Westphal Under extremely rare conditions TCP early demux will retrieve the wrong socket. 1. local machine establishes a connection to a remote server, S, on port p. This gives: laddr:lport -> S:p ... both in tcp and

Re: [RFC] devlink: health: add remediation type

+/** > + * enum devlink_health_reporter_remedy - severity of remediation procedure > + * @DLH_REMEDY_NONE: transient error, no remediation required > + * @DLH_REMEDY_COMP_RESET: associated device component (e.g. device queue) > + * will be reset > + * @DLH_REMEDY_RESET: full devic

[PATCH] ti: wlcore: fix error return code of wl1271_suspend()

When wl is NULL, no error return code of wl1271_suspend() is assigned. To fix this bug, ret is assigned with -EINVAL in this case. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai --- drivers/net/wireless/ti/wlcore/sdio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless

Re: [PATCH] net: mellanox: mlxsw: fix error return code of mlxsw_sp_router_nve_promote_decap()

On 06.03.2021 15:07, Jia-Ju Bai wrote: > When fib_entry is NULL, no error return code of > mlxsw_sp_router_nve_promote_decap() is assigned. > To fix this bug, err is assigned with -EINVAL in this case. > Again, are you sure this is a bug? To me it looks like it is intentional to not return an erro

Re: Query on new ethtool RSS hashing options

On Sat, Mar 06, 2021 at 06:04:14PM +0530, Sunil Kovvuri wrote: > On Sat, Mar 6, 2021 at 5:47 AM Andrew Lunn wrote: > > > > On Fri, Mar 05, 2021 at 03:07:02PM -0800, Jakub Kicinski wrote: > > > On Fri, 5 Mar 2021 16:15:51 +0530 Sunil Kovvuri wrote: > > > > Hi, > > > > > > > > We have a requirement

[PATCH] net: mellanox: mlxsw: fix error return code of mlxsw_sp_router_nve_promote_decap()

When fib_entry is NULL, no error return code of mlxsw_sp_router_nve_promote_decap() is assigned. To fix this bug, err is assigned with -EINVAL in this case. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai --- drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 4 +++- 1 file changed, 3 in

Re: [PATCH net 2/2] net: dsa: Always react to global bridge attribute changes

On Sat, Mar 06, 2021 at 04:00:33PM +0200, Vladimir Oltean wrote: > Hi Tobias, > > On Sat, Mar 06, 2021 at 01:24:55AM +0100, Tobias Waldekranz wrote: > > This is the second attempt to provide a fix for the issue described in > > 99b8202b179f, which was reverted in the previous commit. > > > > When a

Re: [PATCH net 2/2] net: dsa: Always react to global bridge attribute changes

Hi Tobias, On Sat, Mar 06, 2021 at 01:24:55AM +0100, Tobias Waldekranz wrote: > This is the second attempt to provide a fix for the issue described in > 99b8202b179f, which was reverted in the previous commit. > > When a change is made to some global bridge attribute, such as VLAN > filtering, ac

[PATCH] net: mellanox: mlx5: fix error return code of mlx5e_stats_flower()

When mlx5e_tc_get_counter() returns NULL to counter or mlx5_devcom_get_peer_data() returns NULL to peer_esw, no error return code of mlx5e_stats_flower() is assigned. To fix this bug, err is assigned with -EINVAL in these cases. Reported-by: TOTE Robot Signed-off-by: Jia-Ju Bai --- drivers/net

Re: Query on new ethtool RSS hashing options

On Sat, Mar 06, 2021 at 06:04:14PM +0530, Sunil Kovvuri wrote: > On Sat, Mar 6, 2021 at 5:47 AM Andrew Lunn wrote: > > > > On Fri, Mar 05, 2021 at 03:07:02PM -0800, Jakub Kicinski wrote: > > > On Fri, 5 Mar 2021 16:15:51 +0530 Sunil Kovvuri wrote: > > > > Hi, > > > > > > > > We have a requirement

Re: [PATCH wpan 04/17] net: ieee802154: forbid monitor for set llsec params

Hi, On Thu, 4 Mar 2021 at 02:28, Stefan Schmidt wrote: > > Hello Alex. > > On 28.02.21 16:18, Alexander Aring wrote: > > This patch forbids to set llsec params for monitor interfaces which we > > don't support yet. > > > > Reported-by: syzbot+8b6719da8a04beeaf...@syzkaller.appspotmail.com > > Sig

Re: Query on new ethtool RSS hashing options

On Sat, Mar 06, 2021 at 05:38:14PM +0530, Sunil Kovvuri wrote: > > Can you share the format of the DSA tag? Is there a driver for it > > upstream? Do we need to represent it in union ethtool_flow_union? > > > > No, there is no driver for this tag in the kernel. > I have attached the tag format. >

Re: Query on new ethtool RSS hashing options

On Sat, Mar 6, 2021 at 5:47 AM Andrew Lunn wrote: > > On Fri, Mar 05, 2021 at 03:07:02PM -0800, Jakub Kicinski wrote: > > On Fri, 5 Mar 2021 16:15:51 +0530 Sunil Kovvuri wrote: > > > Hi, > > > > > > We have a requirement where in we want RSS hashing to be done on packet > > > fields > > > which a

[PATCH net 4/9] netfilter: conntrack: avoid misleading 'invalid' in log message

From: Florian Westphal The packet is not flagged as invalid: conntrack will accept it and its associated with the conntrack entry. This happens e.g. when receiving a retransmitted SYN in SYN_RECV state. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_con

[PATCH net 9/9] netfilter: nftables: bogus check for netlink portID with table owner

The existing branch checks for 0 != table->nlpid which always evaluates true for tables that have an owner. Fixes: 6001a930ce03 ("netfilter: nftables: introduce table ownership") Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_tables_api.c | 7 +++ 1 file changed, 3 insertions(+), 4 de

[PATCH net 8/9] netfilter: nftables: fix possible double hook unregistration with table owner

Skip hook unregistration of owner tables from the netns exit path, nft_rcv_nl_event() unregisters the table hooks before tearing down the table content. Fixes: 6001a930ce03 ("netfilter: nftables: introduce table ownership") Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_tables_api.c | 6 +

[PATCH net 5/9] selftests: netfilter: test nat port clash resolution interaction with tcp early demux

From: Florian Westphal Convert Antonio Ojeas bug reproducer to a kselftest. Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso --- tools/testing/selftests/netfilter/Makefile| 2 +- .../selftests/netfilter/nf_nat_edemux.sh | 99 +++ 2 files changed, 100

[PATCH net 3/9] netfilter: nf_nat: undo erroneous tcp edemux lookup

From: Florian Westphal Under extremely rare conditions TCP early demux will retrieve the wrong socket. 1. local machine establishes a connection to a remote server, S, on port p. This gives: laddr:lport -> S:p ... both in tcp and conntrack. 2. local machine establishes a connection

[PATCH net 1/9] uapi: nfnetlink_cthelper.h: fix userspace compilation error

From: "Dmitry V. Levin" Apparently, and could not be included into the same compilation unit because of a cut-and-paste typo in the former header. Fixes: 12f7a505331e6 ("netfilter: add user-space connection tracking helper infrastructure") Cc: # v3.6 Signed-off-by: Dmitry V. Levin Signed-of

[PATCH net 7/9] netfilter: nftables: disallow updates on table ownership

Disallow updating the ownership bit on an existing table: Do not allow to grab ownership on an existing table. Do not allow to drop ownership on an existing table. Fixes: 6001a930ce03 ("netfilter: nftables: introduce table ownership") Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_tables_

[PATCH net 6/9] netfilter: x_tables: gpf inside xt_find_revision()

From: Vasily Averin nested target/match_revfn() calls work with xt[NFPROTO_UNSPEC] lists without taking xt[NFPROTO_UNSPEC].mutex. This can race with module unload and cause host to crash: general protection fault: [#1] Modules linked in: ... [last unloaded: xt_cluster] CPU: 0 PID: 542455 Co

[PATCH net 0/9] Netfilter fixes for net

Hi, The following patchset contains Netfilter fixes for net: 1) Fix incorrect enum type definition in nfnetlink_cthelper UAPI, from Dmitry V. Levin. 2) Remove extra space in deprecated automatic helper assignment notice, from Klemen Košir. 3) Drop early socket demux socket after NAT mangl

[PATCH net 2/9] netfilter: conntrack: Remove a double space in a log message

From: Klemen Košir Removed an extra space in a log message and an extra blank line in code. Signed-off-by: Klemen Košir Signed-off-by: Pablo Neira Ayuso --- net/netfilter/nf_conntrack_helper.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/netfilter/nf_conntrack_hel

[syzbot] bpf boot error: WARNING in kvm_wait

Hello, syzbot found the following issue on: HEAD commit:edbea922 veth: Store queue_mapping independently of XDP pr.. git tree: bpf console output: https://syzkaller.appspot.com/x/log.txt?x=113ae02ad0 kernel config: https://syzkaller.appspot.com/x/.config?x=402784bff477e1ac dashboar

Re: [PATCH] bonding: 3ad: fix a use-after-free in bond_3ad_state_machine_handle

zhudi wrote: >From: Di Zhu > >I use the similar test method described in link below with KASAN enabled: >https://lore.kernel.org/netdev/4c5e467e07fb410ab4135b391d663...@huawei.com/ >soon after, KASAN reports: >[ 9041.977110] >== >[