[PATCH net] net: phy: fix save wrong speed and duplex problem if autoneg is on

From: Guangbin Huang If phy uses generic driver and autoneg is on, enter command "ethtool -s eth0 speed 50" will not change phy speed actually, but command "ethtool eth0" shows speed is 50Mb/s because phydev->speed has been set to 50 and no update later. And duplex setting has same problem too.

Re: [PATCH v2 1/1] net: fec: ptp: avoid register access when ipg clock is disabled

Hi all, Am Do., 25. Feb. 2021 um 22:15 Uhr schrieb Heiko Thiery : > > When accessing the timecounter register on an i.MX8MQ the kernel hangs. > This is only the case when the interface is down. This can be reproduced > by reading with 'phc_ctrl eth0 get'. > > Like described in the change in 91c0d9

AW: [PATCH net] net: hsr: add support for EntryForgetTime

On Thu, Feb 25, 2021 at 6:49 PM Jakub Kicinski wrote: > > On Wed, 24 Feb 2021 14:55:17 +0100 Andrew Lunn wrote: > > On Wed, Feb 24, 2021 at 10:46:49AM +0100, Marco Wenzel wrote: > > > In IEC 62439-3 EntryForgetTime is defined with a value of 400 ms. > > > When a node does not send any frame withi

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

On 25.02.2021 23:28, Daniel González Cabanelas wrote: > El jue, 25 feb 2021 a las 21:05, Heiner Kallweit > () escribió: >> >> On 25.02.2021 17:36, Daniel González Cabanelas wrote: >>> El jue, 25 feb 2021 a las 8:22, Heiner Kallweit >>> () escribió: On 25.02.2021 00:54, Daniel González Cab

Re: [PATCH 3/3] PCI: Convert rtw88 power cycle quirk to shutdown quirk

Kai-Heng Feng writes: > Now we have a generic D3 shutdown quirk, so convert the original > approach to a PCI quirk. > > Signed-off-by: Kai-Heng Feng > --- > drivers/net/wireless/realtek/rtw88/pci.c | 2 -- > drivers/pci/quirks.c | 6 ++ > 2 files changed, 6 insertions(+)

[PATCH net] net: dsa: mt7530: don't build GPIO support if !GPIOLIB

The new GPIO support may be optional at runtime, but it requires building against gpiolib: ERROR: modpost: "gpiochip_get_data" [drivers/net/dsa/mt7530.ko] undefined! ERROR: modpost: "devm_gpiochip_add_data_with_key" [drivers/net/dsa/mt7530.ko] undefined! Add #ifdef to exclude GPIO support if GPIO

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

On 2/25/2021 2:56 PM, Heiner Kallweit wrote: > It's still an ugly workaround and a proper root cause analysis should be > done > first. I can only imagine that phydev->irq is overwritten in phy_probe() > because phy_drv_supports_irq() is false. Can you please check whether >

[PATCH/v3] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_ENCAP_L2_ETH

From: Xuesen Huang bpf_skb_adjust_room sets the inner_protocol as skb->protocol for packets encapsulation. But that is not appropriate when pushing Ethernet header. Add an option to further specify encap L2 type and set the inner_protocol as ETH_P_TEB. v3: - Fix the code format. v2: Suggested-

Re: [PATCH net] net: fix race between napi kthread mode and busy poll

On Thu, Feb 25, 2021 at 5:20 PM Jakub Kicinski wrote: > > On Thu, 25 Feb 2021 16:16:20 -0800 Wei Wang wrote: > > On Thu, Feb 25, 2021 at 3:00 PM Jakub Kicinski wrote: > > > On Thu, 25 Feb 2021 10:29:47 -0800 Wei Wang wrote: > > > > Hmm... I don't think the above patch would work. Consider a situa

Re: Spurious TCP retransmissions on ack vs kfree_skb reordering

On Thu, 25 Feb 2021 15:25:15 -0800 Jakub Kicinski wrote: > Hi! > > We see large (4-8x) increase of what looks like TCP RTOs after rising > the Tx coalescing above Rx coalescing timeout. > > Quick tracing of the events seems to indicate that the data has already > been acked when we enter tcp:tcp

Re: [PATCH] net: bridge: Fix jump_label config

On 2021/2/26 5:22, Cong Wang wrote: On Wed, Feb 24, 2021 at 8:03 AM Kefeng Wang wrote: HAVE_JUMP_LABLE is removed by commit e9666d10a567 ("jump_label: move 'asm goto' support test to Kconfig"), use CONFIG_JUMP_LABLE instead of HAVE_JUMP_LABLE. Fixes: 971502d77faa ("bridge: netfilter: unroll

RE: [RFC V2 net-next 0/3] net: stmmac: implement clocks management

Hi All, There is an issue in this patch set version(V2), please stop reviewing. Sorry. I will fix it, and then repost it after testing. Best Regards, Joakim Zhang > -Original Message- > From: Joakim Zhang > Sent: 2021年2月25日 19:51 > To: peppe.cavall...@st.com; alexandre.tor...@st.com; >

Re: [PATCH net] net: fix race between napi kthread mode and busy poll

On Thu, 25 Feb 2021 16:16:20 -0800 Wei Wang wrote: > On Thu, Feb 25, 2021 at 3:00 PM Jakub Kicinski wrote: > > On Thu, 25 Feb 2021 10:29:47 -0800 Wei Wang wrote: > > > Hmm... I don't think the above patch would work. Consider a situation > > > that: > > > 1. At first, the kthread is in sleep mo

Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

Hi Michael, Are you okay to live without this ioctl for now? I think QEMU is the one that needs to be fixed and will have to be made legacy guest aware. I think the kernel can just honor the feature negotiation result done by QEMU and do as what's told to.Will you agree? If it's fine, I wo

Re: [PATCH v6 bpf-next 0/6] bpf: enable task local storage for tracing programs

On Thu, Feb 25, 2021 at 03:43:13PM -0800, Song Liu wrote: > This set enables task local storage for non-BPF_LSM programs. > > It is common for tracing BPF program to access per-task data. Currently, > these data are stored in hash tables with pid as the key. In > bcc/libbpftools [1], 9 out of 23 t

Re: [PATCH v6 bpf-next 2/6] bpf: prevent deadlock from recursive bpf_task_storage_[get|delete]

On Thu, Feb 25, 2021 at 03:43:15PM -0800, Song Liu wrote: > BPF helpers bpf_task_storage_[get|delete] could hold two locks: > bpf_local_storage_map_bucket->lock and bpf_local_storage->lock. Calling > these helpers from fentry/fexit programs on functions in bpf_*_storage.c > may cause deadlock on ei

[PATCH] net: always use icmp{,v6}_ndo_send from ndo_start_xmit

There were a few remaining tunnel drivers that didn't receive the prior conversion to icmp{,v6}_ndo_send. Knowing now that this could lead to memory corrution (see ee576c47db60 ("net: icmp: pass zeroed opts from icmp{,v6}_ndo_send before sending") for details), there's even more imperative to have

[PATCH v6 bpf-next 5/6] bpf: runqslower: prefer using local vmlimux to generate vmlinux.h

Update the Makefile to prefer using $(O)/vmlinux, $(KBUILD_OUTPUT)/vmlinux (for selftests) or ../../../vmlinux. These two files should have latest definitions for vmlinux.h. Acked-by: Andrii Nakryiko Signed-off-by: Song Liu --- tools/bpf/runqslower/Makefile | 5 - 1 file changed, 4 insertio

[PATCH v6 bpf-next 6/6] bpf: runqslower: use task local storage

Replace hashtab with task local storage in runqslower. This improves the performance of these BPF programs. The following table summarizes average runtime of these programs, in nanoseconds: task-local hash-prealloc hash-no-prealloc handle__sched_wakeup 125

[PATCH v6 bpf-next 4/6] selftests/bpf: test deadlock from recursive bpf_task_storage_[get|delete]

Add a test with recursive bpf_task_storage_[get|delete] from fentry programs on bpf_local_storage_lookup and bpf_local_storage_update. Without proper deadlock prevent mechanism, this test would cause deadlock. Signed-off-by: Song Liu --- .../bpf/prog_tests/task_local_storage.c | 23 ++

[PATCH v6 bpf-next 3/6] selftests/bpf: add non-BPF_LSM test for task local storage

Task local storage is enabled for tracing programs. Add two tests for task local storage without CONFIG_BPF_LSM. The first test stores a value in sys_enter and read it back in sys_exit. The second test checks whether the kernel allows allocating task local storage in exit_creds() (which it should

[PATCH v6 bpf-next 2/6] bpf: prevent deadlock from recursive bpf_task_storage_[get|delete]

BPF helpers bpf_task_storage_[get|delete] could hold two locks: bpf_local_storage_map_bucket->lock and bpf_local_storage->lock. Calling these helpers from fentry/fexit programs on functions in bpf_*_storage.c may cause deadlock on either locks. Prevent such deadlock with a per cpu counter, bpf_tas

[PATCH v6 bpf-next 1/6] bpf: enable task local storage for tracing programs

To access per-task data, BPF programs usually creates a hash table with pid as the key. This is not ideal because: 1. The user need to estimate the proper size of the hash table, which may be inaccurate; 2. Big hash tables are slow; 3. To clean up the data properly during task terminations,

[PATCH v6 bpf-next 0/6] bpf: enable task local storage for tracing programs

This set enables task local storage for non-BPF_LSM programs. It is common for tracing BPF program to access per-task data. Currently, these data are stored in hash tables with pid as the key. In bcc/libbpftools [1], 9 out of 23 tools use such hash tables. However, hash table is not ideal for many

[net] tcp: Fix sign comparison bug in getsockopt(TCP_ZEROCOPY_RECEIVE)

From: Arjun Roy getsockopt(TCP_ZEROCOPY_RECEIVE) has a bug where we read a user-provided "len" field of type signed int, and then compare the value to the result of an "offsetofend" operation, which is unsigned. Negative values provided by the user will be promoted to large positive numbers; thu

Spurious TCP retransmissions on ack vs kfree_skb reordering

Hi! We see large (4-8x) increase of what looks like TCP RTOs after rising the Tx coalescing above Rx coalescing timeout. Quick tracing of the events seems to indicate that the data has already been acked when we enter tcp:tcp_retransmit_skb: sk_state: 1 icsk_ca_state: 4 bytes_in: 0 b

Re: [PATCH v2 net 3/6] net: enetc: take the MDIO lock only once per NAPI poll cycle

On Fri, Feb 26, 2021 at 01:00:26AM +0200, Vladimir Oltean wrote: > The goal is to eventually get rid of all the _hot stuff and always take > the lock from the top level, this would allow us to do more register > read/write batching and that would amortize the cost of the locking > overall. Of cour

Re: [PATCH v2 net 3/6] net: enetc: take the MDIO lock only once per NAPI poll cycle

On Thu, Feb 25, 2021 at 11:52:19PM +0100, Andrew Lunn wrote: > On Thu, Feb 25, 2021 at 02:18:32PM +0200, Vladimir Oltean wrote: > > @@ -327,8 +329,8 @@ static void enetc_get_tx_tstamp(struct enetc_hw *hw, > > union enetc_tx_bd *txbd, > > { > > u32 lo, hi, tstamp_lo; > > > > - lo = enetc_r

Re: [PATCH net] net: fix race between napi kthread mode and busy poll

On Thu, 25 Feb 2021 10:29:47 -0800 Wei Wang wrote: > Hmm... I don't think the above patch would work. Consider a situation that: > 1. At first, the kthread is in sleep mode. > 2. Then someone calls napi_schedule() to schedule work on this napi. > So napi_schedule() is called. But at this moment

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

On 25.02.2021 23:28, Daniel González Cabanelas wrote: > El jue, 25 feb 2021 a las 21:05, Heiner Kallweit > () escribió: >> >> On 25.02.2021 17:36, Daniel González Cabanelas wrote: >>> El jue, 25 feb 2021 a las 8:22, Heiner Kallweit >>> () escribió: On 25.02.2021 00:54, Daniel González Cab

Re: [PATCH] net: phy: make mdio_bus_phy_suspend/resume as __maybe_unused

On Thu, Feb 25, 2021 at 03:57:27PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > When CONFIG_PM_SLEEP is disabled, the compiler warns about unused > functions: > > drivers/net/phy/phy_device.c:273:12: error: unused function > 'mdio_bus_phy_suspend' [-Werror,-Wunused-function] > static i

Re: [PATCH v2 net 3/6] net: enetc: take the MDIO lock only once per NAPI poll cycle

On Thu, Feb 25, 2021 at 02:18:32PM +0200, Vladimir Oltean wrote: > @@ -327,8 +329,8 @@ static void enetc_get_tx_tstamp(struct enetc_hw *hw, > union enetc_tx_bd *txbd, > { > u32 lo, hi, tstamp_lo; > > - lo = enetc_rd(hw, ENETC_SICTR0); > - hi = enetc_rd(hw, ENETC_SICTR1); > + l

Re: [PATCH v2 1/1] net: fec: ptp: avoid register access when ipg clock is disabled

Hi Heiko, Thank you for the patch! Yet something to improve: [auto build test ERROR on net/master] [also build test ERROR on net-next/master ipvs/master linus/master v5.11 next-20210225] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

El jue, 25 feb 2021 a las 21:05, Heiner Kallweit () escribió: > > On 25.02.2021 17:36, Daniel González Cabanelas wrote: > > El jue, 25 feb 2021 a las 8:22, Heiner Kallweit > > () escribió: > >> > >> On 25.02.2021 00:54, Daniel González Cabanelas wrote: > >>> El mié, 24 feb 2021 a las 23:01, Florian

[PATCH v2] vio: make remove callback return void

The driver core ignores the return value of struct bus_type::remove() because there is only little that can be done. To simplify the quest to make this function return void, let struct vio_driver::remove() return void, too. All users already unconditionally return 0, this commit makes it obvious th

Re: [RFC] dwarves/pahole: Add test scripts

On Wed, Feb 24, 2021 at 10:30:45AM -0700, Nathan Chancellor wrote: SNIP > > + > > +build() > > +{ > > + local name=$1 > > + local opts=$2 > > A more robust way to handle this might be > > shift > local opts=$@ > > > + > > + echo "build ${name} (${OUTPUT}/output)" > > + > > + mkdir -p $

Re: [PATCH v3] bcm63xx_enet: fix internal phy IRQ assignment

On Wed, Feb 24, 2021 at 05:11:33PM +0100, Daniel González Cabanelas wrote: > The current bcm63xx_enet driver doesn't asign the internal phy IRQ. As a > result of this it works in polling mode. > > Fix it using the phy_device structure to assign the platform IRQ. Hi Daniel We still don't have a r

[PATCH v2 4/6] can: c_can: use 32-bit write to set arbitration register

The arbitration register is already set up with 32-bit writes in the other parts of the code except for this point. Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/net/can/c_can/c_can.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/can/c_can/

[PATCH v2 3/6] can: c_can: fix control interface used by c_can_do_tx

According to commit 640916db2bf7 ("can: c_can: Make it SMP safe") let RX use IF1 (i.e. IF_RX) and TX use IF2 (i.e. IF_TX). Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/net/can/c_can/c_can.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/c

[PATCH v2 2/6] can: c_can: fix indentation

Commit 524369e2391f ("can: c_can: remove obsolete STRICT_FRAME_ORDERING Kconfig option") left behind wrong indentation, fix it. Signed-off-by: Dario Binacchi --- (no changes since v1) drivers/net/can/c_can/c_can.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net

[PATCH v2 6/6] can: c_can: add support to 64 message objects

D_CAN controller supports 16, 32, 64 or 128 message objects, comparing to 32 on C_CAN. AM335x/AM437x Sitara processors and DRA7 SOC all instantiate a D_CAN controller with 64 message objects, as described in the "DCAN features" subsection of the CAN chapter of their technical reference manuals. Th

[PATCH v2 5/6] can: c_can: prepare to up the message objects number

As pointed by commit c0a9f4d396c9 ("can: c_can: Reduce register access") the "driver casts the 16 message objects in stone, which is completely braindead as contemporary hardware has up to 128 message objects". The patch prepares the module to extend the number of message objects beyond the 32 cur

[PATCH v2 1/6] can: c_can: remove unused code

Commit 9d23a9818cb1 ("can: c_can: Remove unused inline function") left behind C_CAN_MSG_OBJ_TX_LAST constant. Commit fa39b54ccf28 ("can: c_can: Get rid of pointless interrupts") left behind C_CAN_MSG_RX_LOW_LAST and C_CAN_MSG_OBJ_RX_SPLIT constants. The removed code also made a comment useless an

[PATCH v2 0/6] can: c_can: add support to 64 message objects

The D_CAN controller supports up to 128 messages. Until now the driver only managed 32 messages although Sitara processors and DRA7 SOC can handle 64. The series was tested on a beaglebone board. Note: I have not changed the type of tx_field (belonging to the c_can_priv structure) to atomic64_t

Re: [PATCH] net: bridge: Fix jump_label config

On Wed, Feb 24, 2021 at 8:03 AM Kefeng Wang wrote: > > HAVE_JUMP_LABLE is removed by commit e9666d10a567 ("jump_label: move > 'asm goto' support test to Kconfig"), use CONFIG_JUMP_LABLE instead > of HAVE_JUMP_LABLE. > > Fixes: 971502d77faa ("bridge: netfilter: unroll NF_HOOK helper in bridge > in

[PATCH v2 1/1] net: fec: ptp: avoid register access when ipg clock is disabled

When accessing the timecounter register on an i.MX8MQ the kernel hangs. This is only the case when the interface is down. This can be reproduced by reading with 'phc_ctrl eth0 get'. Like described in the change in 91c0d987a9788dcc5fe26baafd73bf9242b68900 the igp clock is disabled when the interfac

[PATCH v2 1/1] net: fec: ptp: avoid register access when ipg clock is disabled

When accessing the timecounter register on an i.MX8MQ the kernel hangs. This is only the case when the interface is down. This can be reproduced by reading with 'phc_ctrl eth0 get'. Like described in the change in 91c0d987a9788dcc5fe26baafd73bf9242b68900 the igp clock is disabled when the interfac

Re: [RFC PATCH net-next 08/12] Documentation: networking: dsa: add paragraph for the LAG offload

On Sun, Feb 21, 2021 at 23:33, Vladimir Oltean wrote: > From: Vladimir Oltean > > Add a short summary of the methods that a driver writer must implement > for offloading a link aggregation group, and what is still missing. > > Cc: Tobias Waldekranz > Signed-off-by: Vladimir Oltean > --- > Docu

Re: [RFC PATCH net-next 02/12] Documentation: networking: dsa: rewrite chapter about tagging protocol

On Sun, Feb 21, 2021 at 23:33, Vladimir Oltean wrote: > From: Vladimir Oltean > > The chapter about tagging protocols is out of date because it doesn't > mention all taggers that have been added since last documentation > update. But judging based on that, it will always tend to lag behind, > and

Re: [GIT PULL] virtio: features, fixes

The pull request you sent on Thu, 25 Feb 2021 14:33:33 -0500: > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/ffc1759676bed0bff046427dd7d00cb68660190d Thank you! -- Deet-doot-dot, I am a b

Re: [GIT PULL] Networking for 5.12-rc1

The pull request you sent on Thu, 25 Feb 2021 10:48:26 -0800: > git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git tags/net-5.12-rc1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/5ad3dbab569ac39e88fae31690401895c37368b6 Thank you! -- Deet-doot-dot, I am a

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

On 25.02.2021 17:36, Daniel González Cabanelas wrote: > El jue, 25 feb 2021 a las 8:22, Heiner Kallweit > () escribió: >> >> On 25.02.2021 00:54, Daniel González Cabanelas wrote: >>> El mié, 24 feb 2021 a las 23:01, Florian Fainelli >>> () escribió: On 2/24/2021 1:44 PM, Heiner

[GIT PULL] virtio: features, fixes

There are a couple new drivers and support for the new management interface for mlx under review now. I figured I'll send them separately if review is done in time, lots of people are waiting for the vdpa tool patches to I want to make sure they make this release. The following changes since commi

Re: [RFC PATCH net-next 01/12] Documentation: networking: update the graphical representation

On Sun, Feb 21, 2021 at 23:33, Vladimir Oltean wrote: > From: Vladimir Oltean > > While preparing some slides for a customer presentation, I found the > existing high-level view to be a bit confusing, so I modified it a > little bit. > > Signed-off-by: Vladimir Oltean > --- Reviewed-by: Tobias

Re: [PATCH v5 bpf-next 1/6] bpf: enable task local storage for tracing programs

On Tue, Feb 23, 2021 at 02:28:40PM -0800, Song Liu wrote: > To access per-task data, BPF programs usually creates a hash table with > pid as the key. This is not ideal because: > 1. The user need to estimate the proper size of the hash table, which may > be inaccurate; > 2. Big hash tables ar

Re: [PATCH net-next 4/4] net: dsa: don't set skb->offload_fwd_mark when not offloading the bridge

On Sun, Feb 14, 2021 at 17:53, Vladimir Oltean wrote: > From: Vladimir Oltean > > DSA has gained the recent ability to deal gracefully with upper > interfaces it cannot offload, such as the bridge, bonding or team > drivers. When such uppers exist, the ports are still in standalone mode > as far

Re: [PATCH net-next 2/4] net: dsa: reject switchdev objects centrally from dsa_slave_port_obj_{add,del}

On Sun, Feb 14, 2021 at 17:53, Vladimir Oltean wrote: > From: Vladimir Oltean > > The dsa_port_offloads_netdev check is inside dsa_slave_vlan_{add,del}, > but outside dsa_port_mdb_{add,del}. We can reduce the number of > occurrences of dsa_port_offloads_netdev by checking only once, at the > begi

Re: [PATCH net-next 3/4] net: dsa: return -EOPNOTSUPP if .port_lag_join is not implemented

On Sun, Feb 14, 2021 at 17:53, Vladimir Oltean wrote: > From: Vladimir Oltean > > There is currently some provisioning for DSA to use the software > fallback for link aggregation, but only if the .port_lag_join is > implemented but it fails (for example because there are more link > aggregation g

Re: [PATCH net-next 1/4] net: dsa: don't offload switchdev objects on ports that don't offload the bridge

On Sun, Feb 14, 2021 at 17:53, Vladimir Oltean wrote: > From: Vladimir Oltean > > Starting with commit 058102a6e9eb ("net: dsa: Link aggregation support"), > DSA warns that certain configurations of upper interfaces are not offloaded > to hardware. When a DSA port does not offload a LAG interface

Re: [PATCH AUTOSEL 5.11 16/67] net: sfp: add mode quirk for GPON module Ubiquiti U-Fiber Instant

On Wednesday 24 February 2021 07:49:34 Sasha Levin wrote: > From: Pali Rohár > > [ Upstream commit f0b4f847673299577c29b71d3f3acd3c313d81b7 ] Hello! This commit requires also commit~1 from that patch series: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=426c6cbc40

Re: [virtio-dev] Re: [PATCH] vdpa/mlx5: set_features should allow reset to zero

On Thu, Feb 25, 2021 at 12:36:07PM +0800, Jason Wang wrote: > > On 2021/2/24 7:12 下午, Cornelia Huck wrote: > > On Wed, 24 Feb 2021 17:29:07 +0800 > > Jason Wang wrote: > > > > > On 2021/2/23 6:58 下午, Cornelia Huck wrote: > > > > On Tue, 23 Feb 2021 18:31:07 +0800 > > > > Jason Wang wrote: > > >

Re: [PATCH] mt7601u: fix always true expression

On Thu, 25 Feb 2021 18:32:41 + Colin King wrote: > From: Colin Ian King > > Currently the expression ~nic_conf1 is always true because nic_conf1 > is a u16 and according to 6.5.3.3 of the C standard the ~ operator > promotes the u16 to an integer before flipping all the bits. Thus > the top 1

[GIT PULL] Networking for 5.12-rc1

The following changes since commit d310ec03a34e92a77302edb804f7d68ee4f01ba0: Merge tag 'perf-core-2021-02-17' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip (2021-02-21 12:49:32 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/netdev/ne

[PATCH] mt7601u: fix always true expression

From: Colin Ian King Currently the expression ~nic_conf1 is always true because nic_conf1 is a u16 and according to 6.5.3.3 of the C standard the ~ operator promotes the u16 to an integer before flipping all the bits. Thus the top 16 bits of the integer result are all set so the expression is alw

Re: [PATCH stable 0/8] net: dsa: b53: Correct learning for standalone ports

On 2/25/2021 9:11 AM, Greg KH wrote: > On Thu, Feb 25, 2021 at 08:53:22AM -0800, Florian Fainelli wrote: >> >> >> On 2/25/2021 12:15 AM, Greg KH wrote: >>> On Wed, Feb 24, 2021 at 05:08:53PM -0800, Florian Fainelli wrote: From: Florian Fainelli Hi Greg, Sasha, Jaakub and David, >

Re: [PATCH] iwlwifi: fix link error without CONFIG_IWLMVM

Arnd Bergmann writes: > From: Arnd Bergmann > > A runtime check that was introduced recently failed to > check for the matching Kconfig symbol: > > ld.lld: error: undefined symbol: iwl_so_trans_cfg referenced by drv.c net/wireless/intel/iwlwifi/pcie/drv.o:(iwl_pci_probe)

Re: [PATCH net] net: psample: Fix netlink skb length with tunnel info

Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 25 Feb 2021 15:51:45 +0800 you wrote: > Currently, the psample netlink skb is allocated with a size that does > not account for the nested 'PSAMPLE_ATTR_TUNNEL' attribute and the > padding required for the 64-bit attribu

Re: [PATCH net] r8169: fix jumbo packet handling on RTL8168e

Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 25 Feb 2021 16:05:19 +0100 you wrote: > Josef reported [0] that using jumbo packets fails on RTL8168e. > Aligning the values for register MaxTxPacketSize with the > vendor driver fixes the problem. > > [0] https://bugzi

Re: [PATCH 1/2] mt76: mt7915: fix unused 'mode' variable

On Thu, Feb 25, 2021 at 03:59:14PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > clang points out a possible corner case in the mt7915_tm_set_tx_cont() > function if called with invalid arguments: > > drivers/net/wireless/mediatek/mt76/mt7915/testmode.c:593:2: warning: variable > 'mode'

Re: [PATCH v3 net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8081

On Thu, 25 Feb 2021 02:59:51 +0100 Andrew Lunn wrote: > On Wed, Feb 24, 2021 at 09:55:36PM +0100, Christian Melki wrote: > > Following a similar reinstate for the KSZ9031. > > > > Older kernels would use the genphy_soft_reset if the PHY did not implement > > a .soft_reset. > > > > Bluntly removin

Re: [PATCH] net: dsa: sja1105: Remove unneeded cast in sja1105_crc32()

Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 23 Feb 2021 12:20:03 +0100 you wrote: > sja1105_unpack() takes a "const void *buf" as its first parameter, so > there is no need to cast away the "const" of the "buf" variable before > calling it. > > Drop the cast, as

Re: [PATCH net] net: hsr: add support for EntryForgetTime

On Wed, 24 Feb 2021 14:55:17 +0100 Andrew Lunn wrote: > On Wed, Feb 24, 2021 at 10:46:49AM +0100, Marco Wenzel wrote: > > In IEC 62439-3 EntryForgetTime is defined with a value of 400 ms. When a > > node does not send any frame within this time, the sequence number check > > for can be ignored. Thi

Re: [PATCH net] net: broadcom: bcm4908_enet: fix NAPI poll returned value

On Wed, 24 Feb 2021 09:06:18 -0800 Florian Fainelli wrote: > On 2/24/2021 7:18 AM, Rafał Miłecki wrote: > > From: Rafał Miłecki > > > > Missing increment was resulting in poll function always returning 0 > > instead of amount of processed packets. > > > > Signed-off-by: Rafał Miłecki > > Ack

[PATCH 3/3] PCI: Convert rtw88 power cycle quirk to shutdown quirk

Now we have a generic D3 shutdown quirk, so convert the original approach to a PCI quirk. Signed-off-by: Kai-Heng Feng --- drivers/net/wireless/realtek/rtw88/pci.c | 2 -- drivers/pci/quirks.c | 6 ++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/

Re: [PATCH V3 net-next 5/5] icmp: add response to RFC 8335 PROBE messages

On Wed, Feb 24, 2021 at 6:21 PM Andreas Roeseler wrote: > > On Sun, 2021-02-21 at 23:49 -0500, Willem de Bruijn wrote: > On Wed, Feb 17, 2021 at 1:14 PM Andreas Roeseler > wrote: > > > > Modify the icmp_rcv function to check for PROBE messages and call > > icmp_echo if a PROBE request is detected

Re: [PATCH 1/1] net: fec: ptp: avoid register access when ipg clock is disabled

On Thu, Feb 25, 2021 at 03:05:32PM +0100, Heiko Thiery wrote: > But the explanation why it is currently disabled that way can be found > in the commit 91c0d987a9788dcc5fe26baafd73bf9242b68900. Okay, without re-factoring the entire driver, I agree that the gettime lock up aught to be fixed in a si

Re: [PATCH v2 net 6/6] net: enetc: force the RGMII speed and duplex instead of operating in inband mode

On Thu, Feb 25, 2021 at 02:18:35PM +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > The ENETC port 0 MAC supports in-band status signaling coming from a PHY > when operating in RGMII mode, and this feature is enabled by default. > > It has been reported that RGMII is broken in fixed-lin

Re: [PATCH stable 0/8] net: dsa: b53: Correct learning for standalone ports

On Thu, Feb 25, 2021 at 08:53:22AM -0800, Florian Fainelli wrote: > > > On 2/25/2021 12:15 AM, Greg KH wrote: > > On Wed, Feb 24, 2021 at 05:08:53PM -0800, Florian Fainelli wrote: > >> From: Florian Fainelli > >> > >> Hi Greg, Sasha, Jaakub and David, > >> > >> This patch series contains backpor

Re: [PATCH v2 net-next] virtio-net: support XDP_TX when not more queues

On Thu, 25 Feb 2021 16:22:29 +0800 Xuan Zhuo wrote: > The number of queues implemented by many virtio backends is limited, > especially some machines have a large number of CPUs. In this case, it > is often impossible to allocate a separate queue for XDP_TX. > > This patch allows XDP_TX to run b

Re: [RFC PATCH v5 02/19] af_vsock: separate wait data loop

On 25.02.2021 17:24, Jorgen Hansen wrote: >> On 18 Feb 2021, at 06:36, Arseny Krasnov >> wrote: >> >> This moves wait loop for data to dedicated function, because later >> it will be used by SEQPACKET data receive loop. >> >> Signed-off-by: Arseny Krasnov >> --- >> net/vmw_vsock/af_vsock.c | 1

Re: [RFC PATCH v5 04/19] af_vsock: implement SEQPACKET receive loop

On 25.02.2021 19:27, Jorgen Hansen wrote: > On 18 Feb 2021, at 06:37, Arseny Krasnov wrote: >> This adds receive loop for SEQPACKET. It looks like receive loop for >> STREAM, but there is a little bit difference: >> 1) It doesn't call notify callbacks. >> 2) It doesn't care about 'SO_SNDLOWAT' a

[PATCH net 2/3] mlxsw: spectrum_ethtool: Add an external speed to PTYS register

From: Danielle Ratson Currently, only external bits are added to the PTYS register, whereas there is one external bit that is wrongly marked as internal, and so was recently removed from the register. Add that bit to the PTYS register again, as this bit is no longer internal. Its removal result

[PATCH net 3/3] mlxsw: spectrum_router: Ignore routes using a deleted nexthop object

From: Ido Schimmel Routes are currently processed from a workqueue whereas nexthop objects are processed in system call context. This can result in the driver not finding a suitable nexthop group for a route and issuing a warning [1]. Fix this by ignoring such routes earlier in the process. The

WARNING in __alloc_skb

Hello, syzbot found the following issue on: HEAD commit:291009f6 Merge tag 'pm-5.11-rc8' of git://git.kernel.org/p.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1481fbacd0 kernel config: https://syzkaller.appspot.com/x/.config?x=1106b4b91e8dfab8 das

[PATCH net 1/3] selftests: forwarding: Fix race condition in mirror installation

From: Danielle Ratson When mirroring to a gretap in hardware the device expects to be programmed with the egress port and all the encapsulating headers. This requires the driver to resolve the path the packet will take in the software data path and program the device accordingly. If the path can

[PATCH net 0/3] mlxsw: Various fixes

From: Ido Schimmel This patchset contains various fixes for mlxsw. Patch #1 fixes a race condition in a selftest. The race and fix are explained in detail in the changelog. Patch #2 re-adds a link mode that was wrongly removed, resulting in a regression in some setups. Patch #3 fixes a race co

Re: [PATCH] kallsyms: make arch_get_kallsym static

On Thu, Feb 25, 2021 at 03:08:37PM +0800, Jiapeng Chong wrote: > Fix the following sparse warning: > > kernel/kallsyms.c:457:12: warning: symbol 'arch_get_kallsym' was not > declared. Should it be static? > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Please just remove the functi

Re: [PATCH stable 0/8] net: dsa: b53: Correct learning for standalone ports

On 2/25/2021 12:15 AM, Greg KH wrote: > On Wed, Feb 24, 2021 at 05:08:53PM -0800, Florian Fainelli wrote: >> From: Florian Fainelli >> >> Hi Greg, Sasha, Jaakub and David, >> >> This patch series contains backports for a change that recently made it >> upstream as: >> >> commit f3f9be9c58085d11

general protection fault in ieee802154_llsec_parse_dev_addr

Hello, syzbot found the following issue on: HEAD commit:fcb30073 Merge branch 'wireguard-fixes-for-5-12-rc1' git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=148f1646d0 kernel config: https://syzkaller.appspot.com/x/.config?x=2b8307379601586a dashboard link:

Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment

El jue, 25 feb 2021 a las 8:22, Heiner Kallweit () escribió: > > On 25.02.2021 00:54, Daniel González Cabanelas wrote: > > El mié, 24 feb 2021 a las 23:01, Florian Fainelli > > () escribió: > >> > >> > >> > >> On 2/24/2021 1:44 PM, Heiner Kallweit wrote: > >>> On 24.02.2021 16:44, Daniel González C

RE: [External] Re: High (200+) XFRM interface count performance problem (throughput)

Hi Eyal, with kernel 5.10 it work very well. Tested with 10 000 interfaces. Thank you once more. Regards, Karel -Original Message- From: Vinš Karel Sent: Wednesday, February 24, 2021 12:02 PM To: 'Eyal Birger' Cc: netdev@vger.kernel.org Subject: [External] RE: [External] Re: High (200

Re: [RFC PATCH v5 04/19] af_vsock: implement SEQPACKET receive loop

On 18 Feb 2021, at 06:37, Arseny Krasnov wrote: > > This adds receive loop for SEQPACKET. It looks like receive loop for > STREAM, but there is a little bit difference: > 1) It doesn't call notify callbacks. > 2) It doesn't care about 'SO_SNDLOWAT' and 'SO_RCVLOWAT' values, because > there is n

Re: [PATCH] xen-netback: correct success/error reporting for the SKB-with-fraglist case

On 25/02/2021 14:00, Jan Beulich wrote: On 25.02.2021 13:11, Paul Durrant wrote: On 25/02/2021 07:33, Jan Beulich wrote: On 24.02.2021 17:39, Paul Durrant wrote: On 23/02/2021 16:29, Jan Beulich wrote: When re-entering the main loop of xenvif_tx_check_gop() a 2nd time, the special considerati

Re: [PATCH 3/3] net: dsa: mt7530: add GPIOLIB dependency

On Thu, Feb 25, 2021 at 4:52 PM DENG Qingfang wrote: > > Hi Arnd, > > On Thu, Feb 25, 2021 at 10:40 PM Arnd Bergmann wrote: > > > > From: Arnd Bergmann > > > > The new gpio support may be optional at runtime, but it requires > > building against gpiolib: > > > > ERROR: modpost: "gpiochip_get_dat

Re: [PATCH 1/2] mt76: mt7915: fix unused 'mode' variable

Arnd Bergmann writes: > From: Arnd Bergmann > > clang points out a possible corner case in the mt7915_tm_set_tx_cont() > function if called with invalid arguments: > > drivers/net/wireless/mediatek/mt76/mt7915/testmode.c:593:2: warning: variable > 'mode' is used uninitialized whenever switch de

Re: [PATCH 3/3] net: dsa: mt7530: add GPIOLIB dependency

Hi Arnd, On Thu, Feb 25, 2021 at 10:40 PM Arnd Bergmann wrote: > > From: Arnd Bergmann > > The new gpio support may be optional at runtime, but it requires > building against gpiolib: > > ERROR: modpost: "gpiochip_get_data" [drivers/net/dsa/mt7530.ko] undefined! > ERROR: modpost: "devm_gpiochip_

Re: [RFC net-next] net: dsa: mt7530: support MDB and bridge flag operations

Hi Vladimir, On Wed, Feb 24, 2021 at 4:42 PM Vladimir Oltean wrote: > > I think the comment is incorrect and this _enables_ flooding (which btw > is ok until we get the address filtering thing sorted out). The initial value of these FFP fields is all 1's (0xFF). Writing the CPU port bit here wil

Re: [PATCH 2/3] net: dsa: tag_ocelot_8021q: fix driver dependency

On Thu, Feb 25, 2021 at 4:07 PM Vladimir Oltean wrote: > On Thu, Feb 25, 2021 at 03:49:08PM +0100, Arnd Bergmann wrote: > > On Thu, Feb 25, 2021 at 3:47 PM Arnd Bergmann wrote: > > > On Thu, Feb 25, 2021 at 3:43 PM Vladimir Oltean wrote: > > > > On Thu, Feb 25, 2021 at 03:38:32PM +0100, Arnd Ber

[PATCH] xen-netback: use local var in xenvif_tx_check_gop() instead of re-calculating

shinfo already holds the result of skb_shinfo(skb) at this point - no need to re-invoke the construct even twice. Signed-off-by: Jan Beulich --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -557,8 +557,8 @@ check_frags: } if (skb_has_frag_list(

Re: [PATCH RFC net-next 3/3] mm: make zone->free_area[order] access faster

On Thu, Feb 25, 2021 at 04:16:33PM +0100, Jesper Dangaard Brouer wrote: > > On Wed, Feb 24, 2021 at 07:56:51PM +0100, Jesper Dangaard Brouer wrote: > > > Avoid multiplication (imul) operations when accessing: > > > zone->free_area[order].nr_free > > > > > > This was really tricky to find. I was p

  1   2   >