Re: [PATCH mlx5-next v6 1/4] PCI: Add sysfs callback to allow MSI-X table size change of SR-IOV VFs

2021-02-20 Thread Leon Romanovsky
On Sat, Feb 20, 2021 at 01:06:00PM -0600, Bjorn Helgaas wrote: > On Fri, Feb 19, 2021 at 09:20:18AM +0100, Greg Kroah-Hartman wrote: > > > Ok, can you step back and try to explain what problem you are trying to > > solve first, before getting bogged down in odd details? I find it > > highly unlike

Re: [PATCH] rtw88: 8822ce: fix wifi disconnect after S3/S4 on HONOR laptop

2021-02-20 Thread Leon Romanovsky
On Sat, Feb 20, 2021 at 04:46:02PM +0800, Hao Chen wrote: > When the laptop HONOR MagicBook 14 sleep to S3/S4, the laptop can't > resume. > The dmesg of kernel report: > "[ 99.990168] pcieport :00:01.2: can't change power state > from D3hot to D0 (config space inaccessible) > [ 99.993334] r

Re: [PATCH net-next RFC v4] net: hdlc_x25: Queue outgoing LAPB frames

2021-02-20 Thread Leon Romanovsky
On Fri, Feb 19, 2021 at 12:28:12PM -0800, Xie He wrote: > On Fri, Feb 19, 2021 at 10:39 AM Jakub Kicinski wrote: > > > > Not entirely sure what the argument is about but adding constants would > > certainly help. > > Leon wants me to replace this: > > dev->needed_headroom = 3 - 1; > > with this: >

Re: [PATCH mellanox-tree] net/mlx5: prevent an integer underflow in mlx5_perout_configure()

2021-02-20 Thread Leon Romanovsky
On Fri, Feb 19, 2021 at 12:57:52PM +0300, Dan Carpenter wrote: > The value of "sec" comes from the user. Negative values will lead to > shift wrapping inside the perout_conf_real_time() function and triggger > a UBSan warning. > > Add a check and return -EINVAL to prevent that from happening. > >

Re: [PATCH v15 2/4] phy: Add media type and speed serdes configuration interfaces

2021-02-20 Thread Leon Romanovsky
On Thu, Feb 18, 2021 at 05:14:49PM +0100, Steen Hegelund wrote: > Provide new phy configuration interfaces for media type and speed that > allows e.g. PHYs used for ethernet to be configured with this > information. > > Signed-off-by: Lars Povlsen > Signed-off-by: Steen Hegelund > Reviewed-by: An

Re: [GIT] Networking

2021-02-20 Thread pr-tracker-bot
The pull request you sent on Wed, 17 Feb 2021 18:52:00 -0800 (PST): > git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git > refs/heads/master has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/51e6d17809c85e1934600ec4cdb85552e9bda254 Thank you! -- Deet-do

Re: [PATCH] arp: Remove the arp_hh_ops structure

2021-02-20 Thread Yejune Deng
Sorry,it was my fault, I will resubmit. On Sun, Feb 21, 2021 at 9:54 AM David Ahern wrote: > > On 2/19/21 9:32 PM, Yejune Deng wrote: > > static const struct neigh_ops arp_direct_ops = { > > .family = AF_INET, > > .output = neigh_direct_output, > > @@ -277

Re: [PATCH] arp: Remove the arp_hh_ops structure

2021-02-20 Thread David Ahern
On 2/19/21 9:32 PM, Yejune Deng wrote: > static const struct neigh_ops arp_direct_ops = { > .family = AF_INET, > .output = neigh_direct_output, > @@ -277,15 +269,10 @@ static int arp_constructor(struct neighbour *neigh) > memcpy(neigh->

Re: KASAN: use-after-free Read in blk_update_request

2021-02-20 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:f40ddce8 Linux 5.11 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1156374ad0 kernel config: https://syzkaller.appspot.com/x/.config?x=4b919ebed7b4902 dashboard link: https://syzkalle

Re: [PATCH] tcp: avoid unnecessary loop if even ports are used up

2021-02-20 Thread Jeremy Sowden
On 2021-02-20, at 13:44:02 -0800, David Miller wrote: > From: Honglei Wang > Date: Sat, 20 Feb 2021 19:03:56 +0800 > > > We are getting port for connect() from even ports firstly now. This > > makes bind() users have more available slots at odd part. But there is a > > problem here when the even p

Re: [PATCH] tcp: avoid unnecessary loop if even ports are used up

2021-02-20 Thread David Miller
From: Honglei Wang Date: Sat, 20 Feb 2021 19:03:56 +0800 > We are getting port for connect() from even ports firstly now. This > makes bind() users have more available slots at odd part. But there is a > problem here when the even ports are used up. This happens when there > is a flood of short l

Re: KASAN: use-after-free Write in j1939_can_recv

2021-02-20 Thread Pavel Machek
Can we get some kind of common prefix for the subjects? > This report is generated by a bot. It may contain errors. It is less useful than average lkml mail, so it should be easy to filter. > See https://goo.gl/tpsmEJ for more information about syzbot. > syzbot engineers can be reached at syzk

Re: [PATCH mlx5-next v6 1/4] PCI: Add sysfs callback to allow MSI-X table size change of SR-IOV VFs

2021-02-20 Thread Bjorn Helgaas
On Fri, Feb 19, 2021 at 09:20:18AM +0100, Greg Kroah-Hartman wrote: > Ok, can you step back and try to explain what problem you are trying to > solve first, before getting bogged down in odd details? I find it > highly unlikely that this is something "unique", but I could be wrong as > I do not u

Re: [PATCH bpf-next v2 1/2] bpf, xdp: per-map bpf_redirect_map functions for XDP

2021-02-20 Thread kernel test robot
Hi "Björn, I love your patch! Yet something to improve: [auto build test ERROR on 7b1e385c9a488de9291eaaa412146d3972e9dec5] url: https://github.com/0day-ci/linux/commits/Bj-rn-T-pel/Optimize-bpf_redirect_map-xdp_do_redirect/20210220-233623 base: 7b1e385c9a488de9291eaaa412146d3972e

Re: [PATCH v2] net: phy: add Marvell 88X2222 transceiver support

2021-02-20 Thread Andrew Lunn
> > +/* switch line-side interface between 10GBase-R and 1GBase-X > > + * according to speed */ > > +static void mv_update_interface(struct phy_device *phydev) > > +{ > > + struct mv_data *priv = phydev->priv; > > + > > + if (phydev->speed == SPEED_1 && > > + priv->line_interf

Re: [PATCH v2] net: phy: add Marvell 88X2222 transceiver support

2021-02-20 Thread Andrew Lunn
Hi Ivan > +static int sfp_module_insert(void *_priv, const struct sfp_eeprom_id *id) > +{ > + struct phy_device *phydev = _priv; > + struct device *dev = &phydev->mdio.dev; > + struct mv_data *priv = phydev->priv; > + phy_interface_t sfp_interface; Reverse Christmas tree pleas

Re: [PATCH v2] net: phy: add Marvell 88X2222 transceiver support

2021-02-20 Thread Ivan Bornyakov
On Sat, Feb 20, 2021 at 11:53:04AM +, Russell King - ARM Linux admin wrote: > On Sat, Feb 20, 2021 at 12:46:23PM +0300, Ivan Bornyakov wrote: > > + > > + switch (sfp_interface) { > > + case PHY_INTERFACE_MODE_10GBASER: > > + phydev->speed = SPEED_1; > > + phy_write_m

Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

2021-02-20 Thread Andrew Lunn
> If in doubt, leaving the patch as is would be fine with me. The patch is O.K. as is, no need to export something so simple for a single users. When the next user come along, we can reconsider. Andrew

Re: [PATCH net-next] net: dsa: Fix dependencies with HSR

2021-02-20 Thread Vladimir Oltean
On Fri, Feb 19, 2021 at 09:12:21PM -0800, Florian Fainelli wrote: > The core DSA framework uses hsr_is_master() which would not resolve to a > valid symbol if HSR is built-into the kernel and DSA is a module. > > Fixes: 18596f504a3e ("net: dsa: add support for offloading HSR") > Reported-by: kerne

[PATCH bpf-next v2 2/2] bpf, xdp: restructure redirect actions

2021-02-20 Thread Björn Töpel
From: Björn Töpel The XDP_REDIRECT implementations for maps and non-maps are fairly similar, but obviously need to take different code paths depending on if the target is using a map or not. Today, the redirect targets for XDP either uses a map, or is based on ifindex. Here, an explicit redirect

[PATCH bpf-next v2 1/2] bpf, xdp: per-map bpf_redirect_map functions for XDP

2021-02-20 Thread Björn Töpel
From: Björn Töpel Currently the bpf_redirect_map() implementation dispatches to the correct map-lookup function via a switch-statement. To avoid the dispatching, this change adds one bpf_redirect_map() implementation per map. Correct function is automatically selected by the BPF verifier. v1->v2

[PATCH bpf-next v2 0/2] Optimize bpf_redirect_map()/xdp_do_redirect()

2021-02-20 Thread Björn Töpel
Hi XDP-folks, This two patch series contain two optimizations for the bpf_redirect_map() helper and the xdp_do_redirect() function. The bpf_redirect_map() optimization is about avoiding the map lookup dispatching. Instead of having a switch-statement and selecting the correct lookup function, we

Re: [PATCH net-next] net: dsa: Fix dependencies with HSR

2021-02-20 Thread George McCollister
On Fri, Feb 19, 2021 at 11:14 PM Florian Fainelli wrote: > > > > On 2/19/2021 9:12 PM, Florian Fainelli wrote: > > The core DSA framework uses hsr_is_master() which would not resolve to a > > valid symbol if HSR is built-into the kernel and DSA is a module. > > > > Fixes: 18596f504a3e ("net: dsa:

[PATCH ipsec,v2] xfrm: interface: fix ipv4 pmtu check to honor ip header df

2021-02-20 Thread Eyal Birger
Frag needed should only be sent if the header enables DF. This fix allows packets larger than MTU to pass the xfrm interface and be fragmented after encapsulation, aligning behavior with non-interface xfrm. Fixes: f203b76d7809 ("xfrm: Add virtual xfrm interfaces") Signed-off-by: Eyal Birger ---

Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

2021-02-20 Thread Heiner Kallweit
On 20.02.2021 10:02, Serge Semin wrote: > On Thu, Feb 11, 2021 at 10:39:41AM +, Russell King - ARM Linux admin > wrote: >> On Wed, Feb 10, 2021 at 07:47:20PM +0300, Serge Semin wrote: >>> On Tue, Feb 09, 2021 at 10:56:46AM +, Russell King - ARM Linux admin >>> wrote: On Tue, Feb 09,

Re: [PATCH v2] net: phy: add Marvell 88X2222 transceiver support

2021-02-20 Thread Russell King - ARM Linux admin
On Sat, Feb 20, 2021 at 12:46:23PM +0300, Ivan Bornyakov wrote: > Add basic support for the Marvell 88X multi-speed ethernet > transceiver. > > This PHY provides data transmission over fiber-optic as well as Twinax > copper links. The 88X supports 2 ports of 10GBase-R and 1000Base-X > on t

[PATCH] tcp: avoid unnecessary loop if even ports are used up

2021-02-20 Thread Honglei Wang
We are getting port for connect() from even ports firstly now. This makes bind() users have more available slots at odd part. But there is a problem here when the even ports are used up. This happens when there is a flood of short life cycle connections. In this scenario, it starts getting ports fr

KASAN: use-after-free Write in j1939_can_recv

2021-02-20 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:f40ddce8 Linux 5.11 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=17073738d0 kernel config: https://syzkaller.appspot.com/x/.config?x=e53d04227c52a0df dashboard link: https://syzkaller.appspot.co

Re: [PATCH net] net: l2tp: reduce log level when passing up invalid packets

2021-02-20 Thread Matthias Schiffer
Hi Tom, On 2/19/21 9:12 PM, Tom Parkin wrote: Hi Matthias, Thanks for your patch! On Fri, Feb 19, 2021 at 20:06:15 +0100, Matthias Schiffer wrote: Before commit 5ee759cda51b ("l2tp: use standard API for warning log messages"), it was possible for userspace applications to use their own contr

[PATCH v2] net: phy: add Marvell 88X2222 transceiver support

2021-02-20 Thread Ivan Bornyakov
Add basic support for the Marvell 88X multi-speed ethernet transceiver. This PHY provides data transmission over fiber-optic as well as Twinax copper links. The 88X supports 2 ports of 10GBase-R and 1000Base-X on the line-side interface. The host-side interface supports 4 ports of 10GBase-

[PATCH] libbpf: Remove unnecessary conversion to bool

2021-02-20 Thread Jiapeng Chong
Fix the following coccicheck warnings: ./tools/lib/bpf/libbpf.c:1487:43-48: WARNING: conversion to bool not needed here. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- tools/lib/bpf/libbpf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/lib/bpf/libbpf.c b

Re: [PATCH] rtw88: 8822ce: fix wifi disconnect after S3/S4 on HONOR laptop

2021-02-20 Thread Kalle Valo
Hao Chen writes: > When the laptop HONOR MagicBook 14 sleep to S3/S4, the laptop can't > resume. > The dmesg of kernel report: > "[ 99.990168] pcieport :00:01.2: can't change power state > from D3hot to D0 (config space inaccessible) > [ 99.993334] rtw_pci :01:00.0: can't change power

Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

2021-02-20 Thread Serge Semin
On Thu, Feb 11, 2021 at 10:39:41AM +, Russell King - ARM Linux admin wrote: > On Wed, Feb 10, 2021 at 07:47:20PM +0300, Serge Semin wrote: > > On Tue, Feb 09, 2021 at 10:56:46AM +, Russell King - ARM Linux admin > > wrote: > > > On Tue, Feb 09, 2021 at 11:37:29AM +0100, Heiner Kallweit wro

[PATCH] rtw88: 8822ce: fix wifi disconnect after S3/S4 on HONOR laptop

2021-02-20 Thread Hao Chen
When the laptop HONOR MagicBook 14 sleep to S3/S4, the laptop can't resume. The dmesg of kernel report: "[ 99.990168] pcieport :00:01.2: can't change power state from D3hot to D0 (config space inaccessible) [ 99.993334] rtw_pci :01:00.0: can't change power state from D3hot to D0 (config