Re: [PATCH v10 01/20] dlb: add skeleton for DLB driver

2021-02-17 Thread gre...@linuxfoundation.org
On Thu, Feb 18, 2021 at 07:34:31AM +, Chen, Mike Ximing wrote: > > > > -Original Message- > > From: Mike Ximing Chen > > Sent: Wednesday, February 10, 2021 12:54 PM > > To: netdev@vger.kernel.org > > Cc: da...@davemloft.net; k...@kernel.org; a...@arndb.de; > > gre...@linuxfoundation.

[PATCH v1] vdpa/mlx5: Fix suspend/resume index restoration

2021-02-17 Thread Eli Cohen
When we suspend the VM, the VDPA interface will be reset. When the VM is resumed again, clear_virtqueues() will clear the available and used indices resulting in hardware virqtqueue objects becoming out of sync. We can avoid this function alltogether since qemu will clear them if required, e.g. whe

[PATCH v2] vdpa/mlx5: Enable user to add/delete vdpa device

2021-02-17 Thread Eli Cohen
Allow to control vdpa device creation and destruction using the vdpa management tool. Examples: 1. List the management devices $ vdpa mgmtdev show pci/:3b:00.1: supported_classes net 2. Create vdpa instance $ vdpa dev add mgmtdev pci/:3b:00.1 name vdpa0 3. Show vdpa devices $ vdpa dev

RE: [PATCH v10 01/20] dlb: add skeleton for DLB driver

2021-02-17 Thread Chen, Mike Ximing
> -Original Message- > From: Mike Ximing Chen > Sent: Wednesday, February 10, 2021 12:54 PM > To: netdev@vger.kernel.org > Cc: da...@davemloft.net; k...@kernel.org; a...@arndb.de; > gre...@linuxfoundation.org; Williams, Dan J ; > pierre- > louis.boss...@linux.intel.com; Gage Eads > Su

[PATCH] iwlegacy: 4965-mac: Simplify the calculation of variables

2021-02-17 Thread Jiapeng Chong
Fix the following coccicheck warnings: ./drivers/net/wireless/intel/iwlegacy/4965-mac.c:2596:54-56: WARNING !A || A && B is equivalent to !A || B. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/net/wireless/intel/iwlegacy/4965-mac.c | 3 +-- 1 file changed, 1 insertion(+), 2

Re: [PATCH 1/2] vdpa/mlx5: Fix suspend/resume index restoration

2021-02-17 Thread Eli Cohen
On Wed, Feb 17, 2021 at 04:20:14PM -0500, Michael S. Tsirkin wrote: > On Wed, Feb 17, 2021 at 11:42:48AM -0800, Si-Wei Liu wrote: > > > > > > On 2/16/2021 8:20 AM, Eli Cohen wrote: > > > When we suspend the VM, the VDPA interface will be reset. When the VM is > > > resumed again, clear_virtqueues

Re: [PATCH 2/2 v1] vdpa/mlx5: Enable user to add/delete vdpa device

2021-02-17 Thread Eli Cohen
On Wed, Feb 17, 2021 at 12:13:37PM -0500, Michael S. Tsirkin wrote: > On Wed, Feb 17, 2021 at 01:31:36PM +0200, Eli Cohen wrote: > > Allow to control vdpa device creation and destruction using the vdpa > > management tool. > > > > Examples: > > 1. List the management devices > > $ vdpa mgmtdev sho

Re: [PATCH v2 3/3] vdpa/mlx5: defer clear_virtqueues to until DRIVER_OK

2021-02-17 Thread Jason Wang
On 2021/2/18 上午5:55, Si-Wei Liu wrote: On 2/16/2021 7:21 AM, Eli Cohen wrote: On Thu, Feb 11, 2021 at 09:33:14AM +0200, Eli Cohen wrote: On Wed, Feb 10, 2021 at 01:48:00PM -0800, Si-Wei Liu wrote: While virtq is stopped,  get_vq_state() is supposed to be  called to  get  sync'ed  with  the

Re: [PATCH v2 2/3] vdpa/mlx5: fix feature negotiation across device reset

2021-02-17 Thread Jason Wang
On 2021/2/11 上午5:47, Si-Wei Liu wrote: The mlx_features denotes the capability for which set of virtio features is supported by device. In principle, this field needs not be cleared during virtio device reset, as this capability is static and does not change across reset. In fact, the current

Re: [PATCH] Revert "ath9k: fix ath_tx_process_buffer() potential null ptr dereference"

2021-02-17 Thread Kalle Valo
Shuah Khan wrote: > This reverts commit a56c14bb21b296fb6d395164ab62ef2e419e5069. > > ath_tx_process_buffer() doesn't dereference or check sta and passes it > to ath_tx_complete_aggr() and ath_tx_complete_buf(). > > ath_tx_complete_aggr() checks the pointer before use. No problem here. > > ath

RE: [PATCH v7 bpf-next 0/6] xsk: build skb by page (aka generic zerocopy xmit)

2021-02-17 Thread John Fastabend
Alexander Lobakin wrote: > This series introduces XSK generic zerocopy xmit by adding XSK umem > pages as skb frags instead of copying data to linear space. > The only requirement for this for drivers is to be able to xmit skbs > with skb_headlen(skb) == 0, i.e. all data including hard headers > st

Re: RE: [PATCH v7 bpf-next 6/6] xsk: build skb by page (aka generic zerocopy xmit)

2021-02-17 Thread John Fastabend
Xuan Zhuo wrote: > On Wed, 17 Feb 2021 16:46:04 -0800, John Fastabend > wrote: > > Alexander Lobakin wrote: > > > From: Xuan Zhuo > > > > > > This patch is used to construct skb based on page to save memory copy > > > overhead. > > > > > > This function is implemented based on IFF_TX_SKB_NO_LINE

[RFC PATCH v5 18/19] vsock_test: add SOCK_SEQPACKET tests

2021-02-17 Thread Arseny Krasnov
This adds two tests of SOCK_SEQPACKET socket: both transfer data and then test MSG_EOR and MSG_TRUNC flags. Cases for connect(), bind(), etc. are not tested, because it is same as for stream socket. Signed-off-by: Arseny Krasnov --- tools/testing/vsock/util.c | 32 ++-- tools/testing/

[RFC PATCH v5 17/19] vsock/loopback: setup SEQPACKET ops for transport

2021-02-17 Thread Arseny Krasnov
This adds SEQPACKET ops for loopback transport Signed-off-by: Arseny Krasnov --- net/vmw_vsock/vsock_loopback.c | 5 + 1 file changed, 5 insertions(+) diff --git a/net/vmw_vsock/vsock_loopback.c b/net/vmw_vsock/vsock_loopback.c index a45f7ffca8c5..c0da94119f74 100644 --- a/net/vmw_vsock/vso

[RFC PATCH v5 15/19] virtio/vsock: setup SEQPACKET ops for transport

2021-02-17 Thread Arseny Krasnov
This adds SEQPACKET ops for virtio transport Signed-off-by: Arseny Krasnov --- net/vmw_vsock/virtio_transport.c | 5 + 1 file changed, 5 insertions(+) diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c index 2700a63ab095..bd3a854bb366 100644 --- a/net/vmw_vsock

[RFC PATCH v5 16/19] vhost/vsock: setup SEQPACKET ops for transport

2021-02-17 Thread Arseny Krasnov
This also removes ignore of non-stream type of packets. Signed-off-by: Arseny Krasnov --- drivers/vhost/vsock.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c index 5e78fb719602..5c86d09e36d9 100644 --- a/drivers/vhost/vs

[RFC PATCH v5 19/19] virtio/vsock: update trace event for SEQPACKET

2021-02-17 Thread Arseny Krasnov
This updates current implementation for trace event of virtio vsock: SEQPACKET socket's type, SEQPACKET specific ops and SEQPACKET 'msg_len' and 'msg_cnt' fields are added. Signed-off-by: Arseny Krasnov --- .../events/vsock_virtio_transport_common.h| 48 +++ net/vmw_vsock/vir

[PATCH net 1/1] net: stmmac: fix CBS idleslope and sendslope calculation

2021-02-17 Thread Song Yoong Siang
From: "Song, Yoong Siang" When link speed is not 100 Mbps, port transmit rate and speed divider are set to 8 and 100 respectively. These values are incorrect for CBS idleslope and sendslope HW values calculation if the link speed is not 1 Gbps. This patch adds switch statement to set the val

[RFC PATCH v5 13/19] virtio/vsock: add SEQPACKET receive logic

2021-02-17 Thread Arseny Krasnov
This modifies current receive logic for SEQPACKET support: 1) Inserts 'SEQ_BEGIN' packet to socket's rx queue. 2) Inserts 'RW' packet to socket's rx queue, but without merging with buffer of last packet in queue. 3) Performs check for packet and socket types on receive(if mismatch, then reset

[RFC PATCH v5 12/19] virtio/vsock: fetch length for SEQPACKET record

2021-02-17 Thread Arseny Krasnov
This adds transport callback which tries to fetch record begin marker from socket's rx queue. It is called from af_vsock.c before reading data packets of record. Signed-off-by: Arseny Krasnov --- include/linux/virtio_vsock.h| 1 + net/vmw_vsock/virtio_transport_common.c | 53 +++

[RFC PATCH v5 14/19] virtio/vsock: rest of SOCK_SEQPACKET support

2021-02-17 Thread Arseny Krasnov
This adds rest of logic for SEQPACKET: 1) SEQPACKET specific functions which send SEQ_BEGIN/SEQ_END. Note that both functions may sleep to wait enough space for SEQPACKET header. 2) SEQ_BEGIN/SEQ_END in TAP packet capture. 3) Send SHUTDOWN on socket close for SEQPACKET type. 4) Set SEQPACKET

[RFC PATCH v5 11/19] virtio/vsock: dequeue callback for SOCK_SEQPACKET

2021-02-17 Thread Arseny Krasnov
This adds transport callback and it's logic for SEQPACKET dequeue. Callback fetches RW packets from rx queue of socket until whole record is copied(if user's buffer is full, user is not woken up). This is done to not stall sender, because if we wake up user and it leaves syscall, nobody will send c

[RFC PATCH v5 09/19] virtio/vsock: set packet's type in send

2021-02-17 Thread Arseny Krasnov
This moves passing type of packet from 'info' srtucture to send function. There is no sense to set type of packet which differs from type of socket, and since at current time only stream type is supported, so force to use this type. Signed-off-by: Arseny Krasnov --- net/vmw_vsock/virtio_transpor

[RFC PATCH v5 10/19] virtio/vsock: simplify credit update function API

2021-02-17 Thread Arseny Krasnov
'virtio_transport_send_credit_update()' has some extra args: 1) 'type' may be set in 'virtio_transport_send_pkt_info()' using type of socket. 2) This function is static and 'hdr' arg was always NULL. Signed-off-by: Arseny Krasnov --- net/vmw_vsock/virtio_transport_common.c | 15 --

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-02-17 Thread Jason Wang
On 2021/2/10 下午5:14, Michael S. Tsirkin wrote: On Tue, Feb 09, 2021 at 10:00:22AM -0800, Wei Wang wrote: On Tue, Feb 9, 2021 at 6:58 AM Willem de Bruijn wrote: I have no preference. Just curious, especially if it complicates the patch. My understanding is that. It's probably ok for net. Bu

[RFC PATCH v5 08/19] af_vsock: update comments for stream sockets

2021-02-17 Thread Arseny Krasnov
This replaces 'stream' to 'connect oriented' in comments as SEQPACKET is also connect oriented. Signed-off-by: Arseny Krasnov --- net/vmw_vsock/af_vsock.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsoc

[RFC PATCH v5 06/19] af_vsock: implement send logic for SEQPACKET

2021-02-17 Thread Arseny Krasnov
This adds some logic to current stream enqueue function for SEQPACKET support: 1) Send record's begin/end marker. 2) Return value from enqueue function is whole record length or error for SOCK_SEQPACKET. Signed-off-by: Arseny Krasnov --- include/net/af_vsock.h | 2 ++ net/vmw_vsock/af_vsoc

[RFC PATCH v5 07/19] af_vsock: rest of SEQPACKET support

2021-02-17 Thread Arseny Krasnov
This does rest of SOCK_SEQPACKET support: 1) Adds socket ops for SEQPACKET type. 2) Allows to create socket with SEQPACKET type. Signed-off-by: Arseny Krasnov --- net/vmw_vsock/af_vsock.c | 36 +++- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/net

[RFC PATCH v5 04/19] af_vsock: implement SEQPACKET receive loop

2021-02-17 Thread Arseny Krasnov
This adds receive loop for SEQPACKET. It looks like receive loop for STREAM, but there is a little bit difference: 1) It doesn't call notify callbacks. 2) It doesn't care about 'SO_SNDLOWAT' and 'SO_RCVLOWAT' values, because there is no sense for these values in SEQPACKET case. 3) It waits until

[RFC PATCH v5 05/19] af_vsock: separate wait space loop

2021-02-17 Thread Arseny Krasnov
This moves loop that waits for space on send to separate function, because it will be used for SEQ_BEGIN/SEQ_END sending before and after data transmission. Waiting for SEQ_BEGIN/SEQ_END is needed because such packets carries SEQPACKET header that couldn't be fragmented by credit mechanism, so to a

[RFC PATCH v5 01/19] af_vsock: update functions for connectible socket

2021-02-17 Thread Arseny Krasnov
This prepares af_vsock.c for SEQPACKET support: some functions such as setsockopt(), getsockopt(), connect(), recvmsg(), sendmsg() are shared between both types of sockets, so rename them in general manner. Signed-off-by: Arseny Krasnov --- net/vmw_vsock/af_vsock.c | 64 +

[RFC PATCH v5 03/19] af_vsock: separate receive data loop

2021-02-17 Thread Arseny Krasnov
This moves STREAM specific data receive logic to dedicated function: '__vsock_stream_recvmsg()', while checks that will be same for both types of socket are in shared function: 'vsock_connectible_recvmsg()'. Signed-off-by: Arseny Krasnov --- net/vmw_vsock/af_vsock.c | 116 ++-

[RFC PATCH v5 02/19] af_vsock: separate wait data loop

2021-02-17 Thread Arseny Krasnov
This moves wait loop for data to dedicated function, because later it will be used by SEQPACKET data receive loop. Signed-off-by: Arseny Krasnov --- net/vmw_vsock/af_vsock.c | 155 +-- 1 file changed, 83 insertions(+), 72 deletions(-) diff --git a/net/vmw_vso

[net-next PATCH v6 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver

2021-02-17 Thread Calvin Johnson
Modify dpaa2_mac_get_node() to get the dpmac fwnode from either DT or ACPI. Modify dpaa2_mac_get_if_mode() to get interface mode from dpmac_node which is a fwnode. Modify dpaa2_pcs_create() to create pcs from dpmac_node fwnode. Modify dpaa2_mac_connect() to support ACPI along with DT. Signed-of

[RFC PATCH v5 00/19] virtio/vsock: introduce SOCK_SEQPACKET support

2021-02-17 Thread Arseny Krasnov
This patchset impelements support of SOCK_SEQPACKET for virtio transport. As SOCK_SEQPACKET guarantees to save record boundaries, so to do it, two new packet operations were added: first for start of record and second to mark end of record(SEQ_BEGIN and SEQ_END later). Also, both o

[net-next PATCH v6 14/15] net: phylink: Refactor phylink_of_phy_connect()

2021-02-17 Thread Calvin Johnson
Refactor phylink_of_phy_connect() to use phylink_fwnode_phy_connect(). Signed-off-by: Calvin Johnson --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None drivers/net/phy/phylink.c | 39 +-- 1 file changed, 1

[net-next PATCH v6 13/15] net: phylink: introduce phylink_fwnode_phy_connect()

2021-02-17 Thread Calvin Johnson
Define phylink_fwnode_phy_connect() to connect phy specified by a fwnode to a phylink instance. Signed-off-by: Calvin Johnson --- Changes in v6: - remove OF check for fixed-link Changes in v5: None Changes in v4: - call phy_device_free() before returning Changes in v3: None Changes in v2: None

[net-next PATCH v6 11/15] net: mdiobus: Introduce fwnode_mdiobus_register()

2021-02-17 Thread Calvin Johnson
Introduce fwnode_mdiobus_register() to register PHYs on the mdiobus. If the fwnode is DT node, then call of_mdiobus_register(). If it is an ACPI node, then call acpi_mdiobus_register(). Signed-off-by: Calvin Johnson --- Changes in v6: None Changes in v5: None Changes in v4: - Remove redundant e

[net-next PATCH v6 12/15] net/fsl: Use fwnode_mdiobus_register()

2021-02-17 Thread Calvin Johnson
fwnode_mdiobus_register() internally takes care of both DT and ACPI cases to register mdiobus. Replace existing of_mdiobus_register() with fwnode_mdiobus_register(). Note: For both ACPI and DT cases, endianness of MDIO controller need to be specified using "little-endian" property. Signed-off-by:

[net-next PATCH v6 09/15] ACPI: utils: Introduce acpi_get_local_address()

2021-02-17 Thread Calvin Johnson
Introduce a wrapper around the _ADR evaluation. Signed-off-by: Calvin Johnson --- Changes in v6: None Changes in v5: - Replace fwnode_get_id() with acpi_get_local_address() Changes in v4: - Improve code structure to handle all cases Changes in v3: - Modified to retrieve reg property value for

[net-next PATCH v6 10/15] net: mdio: Add ACPI support code for mdio

2021-02-17 Thread Calvin Johnson
Define acpi_mdiobus_register() to Register mii_bus and create PHYs for each ACPI child node. Signed-off-by: Calvin Johnson --- Changes in v6: - use GENMASK() and ACPI_COMPANION_SET() - some cleanup - remove unwanted header inclusion Changes in v5: - add missing MODULE_LICENSE() - replace fwnode

[net-next PATCH v6 07/15] net: mdiobus: Introduce fwnode_mdiobus_register_phy()

2021-02-17 Thread Calvin Johnson
Introduce fwnode_mdiobus_register_phy() to register PHYs on the mdiobus. From the compatible string, identify whether the PHY is c45 and based on this create a PHY device instance which is registered on the mdiobus. uninitialized symbol 'mii_ts' Reported-by: kernel test robot Reported-by: Dan Car

[net-next PATCH v6 04/15] of: mdio: Refactor of_phy_find_device()

2021-02-17 Thread Calvin Johnson
Refactor of_phy_find_device() to use fwnode_phy_find_device(). Signed-off-by: Calvin Johnson --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None drivers/net/mdio/of_mdio.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) d

[net-next PATCH v6 05/15] net: phy: Introduce fwnode_get_phy_id()

2021-02-17 Thread Calvin Johnson
Extract phy_id from compatible string. This will be used by fwnode_mdiobus_register_phy() to create phy device using the phy_id. Signed-off-by: Calvin Johnson --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: - Use traditional comparison pattern - Use GENMASK Change

[net-next PATCH v6 08/15] of: mdio: Refactor of_mdiobus_register_phy()

2021-02-17 Thread Calvin Johnson
Refactor of_mdiobus_register_phy() to use fwnode_mdiobus_register_phy(). Signed-off-by: Calvin Johnson --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None drivers/net/mdio/of_mdio.c | 40 +- 1 file changed,

[net-next PATCH v6 03/15] net: phy: Introduce phy related fwnode functions

2021-02-17 Thread Calvin Johnson
Define fwnode_phy_find_device() to iterate an mdiobus and find the phy device of the provided phy fwnode. Additionally define device_phy_find_device() to find phy device of provided device. Define fwnode_get_phy_node() to get phy_node using named reference. Signed-off-by: Calvin Johnson --- Cha

Re: [PATCH net] net: ag71xx: remove unnecessary MTU reservation

2021-02-17 Thread Oleksij Rempel
On Thu, Feb 18, 2021 at 11:45:14AM +0800, DENG Qingfang wrote: > 2 bytes of the MTU are reserved for Atheros DSA tag, but DSA core > has already handled that since commit dc0fe7d47f9f. > Remove the unnecessary reservation. > > Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver") > Signed-off-b

[net-next PATCH v6 06/15] of: mdio: Refactor of_get_phy_id()

2021-02-17 Thread Calvin Johnson
With the introduction of fwnode_get_phy_id(), refactor of_get_phy_id() to use fwnode equivalent. Signed-off-by: Calvin Johnson --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None drivers/net/mdio/of_mdio.c | 12 +--- 1 file changed, 1

[net-next PATCH v6 01/15] Documentation: ACPI: DSD: Document MDIO PHY

2021-02-17 Thread Calvin Johnson
Introduce ACPI mechanism to get PHYs registered on a MDIO bus and provide them to be connected to MAC. Describe properties "phy-handle" and "phy-mode". Signed-off-by: Calvin Johnson --- Changes in v6: - Minor cleanup Changes in v5: - More cleanup Changes in v4: - More cleanup Changes in v3:

[net-next PATCH v6 02/15] net: phy: Introduce fwnode_mdio_find_device()

2021-02-17 Thread Calvin Johnson
Define fwnode_mdio_find_device() to get a pointer to the mdio_device from fwnode passed to the function. Refactor of_mdio_find_device() to use fwnode_mdio_find_device(). Signed-off-by: Calvin Johnson --- Changes in v6: None Changes in v5: None Changes in v4: None Changes in v3: None Changes in

[net-next PATCH v6 00/15] ACPI support for dpaa2 driver

2021-02-17 Thread Calvin Johnson
This patch set provides ACPI support to DPAA2 network drivers. It also introduces new fwnode based APIs to support phylink and phy layers Following functions are defined: phylink_fwnode_phy_connect() fwnode_mdiobus_register_phy() fwnode_mdiobus_register() fwnode_get_p

Re: [PATCH v1] vdpa/mlx5: Restore the hardware used index after change map

2021-02-17 Thread Jason Wang
On 2021/2/10 下午4:59, Si-Wei Liu wrote: On 2/9/2021 7:53 PM, Jason Wang wrote: On 2021/2/10 上午10:30, Si-Wei Liu wrote: On 2/8/2021 10:37 PM, Jason Wang wrote: On 2021/2/9 下午2:12, Eli Cohen wrote: On Tue, Feb 09, 2021 at 11:20:14AM +0800, Jason Wang wrote: On 2021/2/8 下午6:04, Eli Cohen

Re: [PATCH bpf-next 00/17] Improve BPF syscall command documentation

2021-02-17 Thread Joe Stringer
On Wed, Feb 17, 2021 at 9:32 AM Jonathan Corbet wrote: > > [CC += linux-doc] > > Joe Stringer writes: > > > From: Joe Stringer > > > > The state of bpf(2) manual pages today is not exactly ideal. For the > > most part, it was written several years ago and has not kept up with the > > pace of dev

Re: [PATCH bpf-next 00/17] Improve BPF syscall command documentation

2021-02-17 Thread Joe Stringer
On Wed, Feb 17, 2021 at 5:55 AM Toke Høiland-Jørgensen wrote: > > Joe Stringer writes: > > Given the relative success of the process around bpf-helpers(7) to > > encourage developers to document their user-facing changes, in this > > patch series I explore applying this technique to bpf(2) as wel

Re: [PATCH] net: ftgmac100: Support phyless operation

2021-02-17 Thread Florian Fainelli
On 2/17/2021 7:40 PM, William A. Kennington III wrote: > We have BMC to BMC connections that lack a PHY in between but don't > want to use the NC-SI state machinery of the kernel. Instead, > allow for an option to disable the phy detection and mdio logic. > > Signed-off-by: William A. Kenningto

[PATCH net] net: ag71xx: remove unnecessary MTU reservation

2021-02-17 Thread DENG Qingfang
2 bytes of the MTU are reserved for Atheros DSA tag, but DSA core has already handled that since commit dc0fe7d47f9f. Remove the unnecessary reservation. Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver") Signed-off-by: DENG Qingfang --- drivers/net/ethernet/atheros/ag71xx.c | 4 +--- 1 fi

RE: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-17 Thread Min Li
> -Original Message- > From: Arnd Bergmann > Sent: February 17, 2021 4:30 PM > To: Min Li > Cc: Derek Kiernan ; Dragan Cvetic > ; Arnd Bergmann ; gregkh > ; linux-ker...@vger.kernel.org; Networking > ; Richard Cochran > Subject: Re: [PATCH net-next] misc: Add Renesas Synchronization >

Re: [PATCH netdev] virtio-net: support XDP_TX when not more queues

2021-02-17 Thread Jason Wang
On 2021/2/11 5:40 上午, Michael S. Tsirkin wrote: On Wed, Jan 13, 2021 at 04:08:57PM +0800, Xuan Zhuo wrote: The number of queues implemented by many virtio backends is limited, especially some machines have a large number of CPUs. In this case, it is often impossible to allocate a separate queu

Re: [PATCH][next] net: hns3: Fix uninitialized return from function

2021-02-17 Thread lipeng (Y)
在 2021/2/10 23:26, Colin King 写道: From: Colin Ian King Currently function hns3_reset_notify_uninit_enet is returning the contents of the uninitialized variable ret. Fix this by removing ret (since it is no longer used) and replace it with a return of the literal value 0. you can not remov

RE: [PATCH net-next v3 0/5] lan743x speed boost

2021-02-17 Thread Bryan.Whitehead
> From: Sven Van Asbroeck > > Tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git # > 9ec5eea5b6ac > > v2 -> v3: > - Bryan Whitehead: > + add Bryan's reviewed-by tag to patch 1/5. > + Only use FRAME_LENGTH if the LS bit is checked. > If set use the smaller of F

Re: [PATCH] lib: vsprintf: check for NULL device_node name in device_node_string()

2021-02-17 Thread Sergey Senozhatsky
On (21/02/17 13:15), Enrico Weigelt, metux IT consult wrote: > Under rare circumstances it may happen that a device node's name is NULL > (most likely kernel bug in some other place). In such situations anything > but helpful, if the debug printout crashes, and nobody knows what actually > happened

RE: [PATCH v7 bpf-next 6/6] xsk: build skb by page (aka generic zerocopy xmit)

2021-02-17 Thread John Fastabend
Alexander Lobakin wrote: > From: Xuan Zhuo > > This patch is used to construct skb based on page to save memory copy > overhead. > > This function is implemented based on IFF_TX_SKB_NO_LINEAR. Only the > network card priv_flags supports IFF_TX_SKB_NO_LINEAR will use page to > directly construct

Re: WARNING in slave_kobj_release

2021-02-17 Thread syzbot
syzbot has bisected this issue to: commit dcd479e10a0510522a5d88b29b8f79ea3467d501 Author: Johannes Berg Date: Fri Oct 9 12:17:11 2020 + mac80211: always wind down STA state bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=169ceb24d0 start commit: f40ddce8 Linux 5.11

[Patch bpf-next v2] bpf: clear percpu pointers in bpf_prog_clone_free()

2021-02-17 Thread Cong Wang
From: Cong Wang Similar to bpf_prog_realloc(), bpf_prog_clone_create() also copies the percpu pointers, but the clone still shares them with the original prog, so we have to clear these two percpu pointers in bpf_prog_clone_free(). Otherwise we would get a double free: BUG: kernel NULL pointer

Re: [PATCH mlx5-next v6 1/4] PCI: Add sysfs callback to allow MSI-X table size change of SR-IOV VFs

2021-02-17 Thread Jason Gunthorpe
On Wed, Feb 17, 2021 at 02:28:35PM -0600, Bjorn Helgaas wrote: > On Wed, Feb 17, 2021 at 03:25:22PM -0400, Jason Gunthorpe wrote: > > On Wed, Feb 17, 2021 at 12:02:39PM -0600, Bjorn Helgaas wrote: > > > > > > BTW, I asked more than once how these sysfs knobs should be handled > > > > in the PCI/co

Re: [PATCH net-next v5] udp:allow UDP cmsghdrs through io_uring

2021-02-17 Thread Victor Stewart
On Thu, Dec 17, 2020 at 1:45 PM Jens Axboe wrote: > > On 12/17/20 11:30 AM, Victor Stewart wrote: > > might this still make it into 5.11? > > Doesn't meet the criteria to go in at this point. I sometimes > make exceptions, but generally speaking, something going into > 5.11 should have been comple

Re: possible stack corruption in icmp_send (__stack_chk_fail)

2021-02-17 Thread Willem de Bruijn
On Wed, Feb 17, 2021 at 6:18 PM Jason A. Donenfeld wrote: > > On 2/18/21, Willem de Bruijn wrote: > > On Wed, Feb 17, 2021 at 5:56 PM Jason A. Donenfeld wrote: > >> > >> Hi Willem, > >> > >> On Wed, Feb 17, 2021 at 11:27 PM Willem de Bruijn > >> wrote: > >> > A vmlinux image might help. I could

Re: possible stack corruption in icmp_send (__stack_chk_fail)

2021-02-17 Thread Jason A. Donenfeld
On 2/18/21, Willem de Bruijn wrote: > On Wed, Feb 17, 2021 at 5:56 PM Jason A. Donenfeld wrote: >> >> Hi Willem, >> >> On Wed, Feb 17, 2021 at 11:27 PM Willem de Bruijn >> wrote: >> > A vmlinux image might help. I couldn't find one for this kernel. >> >> https://data.zx2c4.com/icmp_send-crash-e0

Re: [Patch bpf-next] bpf: clear per_cpu pointers in bpf_prog_clone_create()

2021-02-17 Thread Daniel Borkmann
On 2/17/21 11:46 PM, Cong Wang wrote: On Wed, Feb 17, 2021 at 2:01 PM Daniel Borkmann wrote: On 2/17/21 4:58 AM, Cong Wang wrote: From: Cong Wang Pretty much similar to commit 1336c662474e ("bpf: Clear per_cpu pointers during bpf_prog_realloc") we also need to clear these two percpu pointers

Re: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-17 Thread Jakub Kicinski
On Wed, 17 Feb 2021 22:30:14 +0100 Arnd Bergmann wrote: > On Wed, Feb 17, 2021 at 9:20 PM Min Li wrote: > > I attached the G.8273.2 document, where chapter 6 is about supporting > > physical layer > > frequency. And combo mode is Renesas way to support this requirement. Other > > companies > > m

Re: possible stack corruption in icmp_send (__stack_chk_fail)

2021-02-17 Thread Willem de Bruijn
On Wed, Feb 17, 2021 at 5:56 PM Jason A. Donenfeld wrote: > > Hi Willem, > > On Wed, Feb 17, 2021 at 11:27 PM Willem de Bruijn > wrote: > > A vmlinux image might help. I couldn't find one for this kernel. > > https://data.zx2c4.com/icmp_send-crash-e03b4a42-706a-43bf-bc40-1f15966b3216.tar.xz > has

Re: possible stack corruption in icmp_send (__stack_chk_fail)

2021-02-17 Thread Jason A. Donenfeld
Hi Willem, On Wed, Feb 17, 2021 at 11:27 PM Willem de Bruijn wrote: > A vmlinux image might help. I couldn't find one for this kernel. https://data.zx2c4.com/icmp_send-crash-e03b4a42-706a-43bf-bc40-1f15966b3216.tar.xz has .debs with vmlinuz in there, which you can extract to vmlinux, as well as

Re: [Patch bpf-next] bpf: clear per_cpu pointers in bpf_prog_clone_create()

2021-02-17 Thread Cong Wang
On Wed, Feb 17, 2021 at 2:01 PM Daniel Borkmann wrote: > > On 2/17/21 4:58 AM, Cong Wang wrote: > > From: Cong Wang > > > > Pretty much similar to commit 1336c662474e > > ("bpf: Clear per_cpu pointers during bpf_prog_realloc") we also need to > > clear these two percpu pointers in bpf_prog_clone_

Re: [PATCH net-next] octeontx2-pf: Fix otx2_get_fecparam()

2021-02-17 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 17 Feb 2021 10:41:39 +0300 you wrote: > Static checkers complained about an off by one read overflow in > otx2_get_fecparam() and we applied two conflicting fixes for it. > > Correct: b0aae0bde26f ("octeontx2: Fix

Re: [PATCH net-next] cteontx2-pf: cn10k: Prevent harmless double shift bugs

2021-02-17 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 17 Feb 2021 09:16:20 +0300 you wrote: > These defines are used with set_bit() and test_bit() which take a bit > number. In other words, the code is doing: > > if (BIT(BIT(1)) & pf->hw.cap_flag) { > > This w

Re: [PATCH net-next 1/1] net: stmmac: Add PCI bus info to ethtool driver query output

2021-02-17 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 17 Feb 2021 17:57:05 +0800 you wrote: > This patch populates the PCI bus info in the ethtool driver query data. > > Users will be able to view PCI bus info using 'ethtool -i '. > > Signed-off-by: Wong Vee Khee >

Re: possible stack corruption in icmp_send (__stack_chk_fail)

2021-02-17 Thread Willem de Bruijn
On Wed, Feb 17, 2021 at 1:12 PM Jason A. Donenfeld wrote: > > Hi Netdev & Willem, > > I've received a report of stack corruption -- via the stack protector > check -- in icmp_send. I was sent a vmcore, and was able to extract > the OOPS from there. However, I've been unable to produce the bug and

Re: [PATCH V3 net-next 0/5] add support for RFC 8335 PROBE

2021-02-17 Thread David Miller
From: Andreas Roeseler Date: Wed, 17 Feb 2021 10:07:38 -0800 > The popular utility ping has several severe limitations such as the > inability to query specific interfaces on a node and requiring > bidirectional connectivity between the probing and probed interfaces. > RFC 8335 attempts to solve

Re: [PATCH net-next v3 0/5] lan743x speed boost

2021-02-17 Thread David Miller
From: Sven Van Asbroeck Date: Wed, 17 Feb 2021 17:04:05 -0500 > Hi Jakub and Bryan, > > Jakub, is there anything else you'd like to see from us, before you > are satisfied that patches 1/5 and 2/5 can be merged into your tree? They are already merged into net-next

Re: [PATCH net-next v3 0/5] lan743x speed boost

2021-02-17 Thread Sven Van Asbroeck
Hi Jakub and Bryan, On Wed, Feb 17, 2021 at 4:43 PM wrote: > > Just to let you know, my colleague tested the patches 1 and 2 on x86 PC and > we are satisfied with the result. > We confirmed some performance improvements. > We also confirmed PTP is working. > > Thanks for your work on this. > > T

Re: [Patch bpf-next] bpf: clear per_cpu pointers in bpf_prog_clone_create()

2021-02-17 Thread Daniel Borkmann
On 2/17/21 4:58 AM, Cong Wang wrote: From: Cong Wang Pretty much similar to commit 1336c662474e ("bpf: Clear per_cpu pointers during bpf_prog_realloc") we also need to clear these two percpu pointers in bpf_prog_clone_create(), otherwise would get a double free: BUG: kernel NULL pointer dere

Re: [PATCH v3 net-next 0/7] ptp: ptp_clockmatrix: Fix output 1 PPS alignment.

2021-02-17 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Wed, 17 Feb 2021 00:42:11 -0500 you wrote: > From: Vincent Cheng > > This series fixes a race condition that may result in the output clock > not aligned to internal 1 PPS clock. > > Part of device initialization is

Re: [PATCH v2 3/3] vdpa/mlx5: defer clear_virtqueues to until DRIVER_OK

2021-02-17 Thread Si-Wei Liu
On 2/16/2021 7:21 AM, Eli Cohen wrote: On Thu, Feb 11, 2021 at 09:33:14AM +0200, Eli Cohen wrote: On Wed, Feb 10, 2021 at 01:48:00PM -0800, Si-Wei Liu wrote: While virtq is stopped, get_vq_state() is supposed to be called to get sync'ed with the latest internal avail_index from device.

Re: [PATCH 1/2] vdpa/mlx5: Fix suspend/resume index restoration

2021-02-17 Thread Si-Wei Liu
On 2/17/2021 1:20 PM, Michael S. Tsirkin wrote: On Wed, Feb 17, 2021 at 11:42:48AM -0800, Si-Wei Liu wrote: On 2/16/2021 8:20 AM, Eli Cohen wrote: When we suspend the VM, the VDPA interface will be reset. When the VM is resumed again, clear_virtqueues() will clear the available and used ind

Re: [PATCH net-next v2 0/5] dwmac-sun8i cleanup and shutdown hook

2021-02-17 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Tue, 16 Feb 2021 22:20:01 -0600 you wrote: > These patches clean up some things I noticed while fixing suspend/resume > behavior. The first four are minor code improvements. The last one adds > a shutdown hook to minimi

Re: [PATCH net-next 1/3] netfilter: nftables: add helper function to release one table

2021-02-17 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Wed, 17 Feb 2021 20:03:30 +0100 you wrote: > Add a function to release one table. > > Signed-off-by: Pablo Neira Ayuso > --- > net/netfilter/nf_tables_api.c | 75 +++ > 1 file changed,

Re: [PATCH net-next] r8169: use macro pm_ptr

2021-02-17 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 17 Feb 2021 22:23:58 +0100 you wrote: > Use macro pm_ptr(), this helps to avoid some ifdeffery. > > Signed-off-by: Heiner Kallweit > --- > drivers/net/ethernet/realtek/r8169_main.c | 4 +--- > 1 file changed, 1 i

Re: [PATCH 2/2] ath9k: fix ath_tx_process_buffer() potential null ptr dereference

2021-02-17 Thread Felix Fietkau
> On 17. Feb 2021, at 21:28, Shuah Khan wrote: > > On 2/17/21 7:56 AM, Shuah Khan wrote: >>> On 2/17/21 12:30 AM, Kalle Valo wrote: >>> Shuah Khan writes: >>> On 2/16/21 12:53 AM, Felix Fietkau wrote: > > On 2021-02-16 08:03, Kalle Valo wrote: >> Shuah Khan wrote: >>

RE: [Patch bpf-next] bpf: clear per_cpu pointers in bpf_prog_clone_create()

2021-02-17 Thread John Fastabend
Cong Wang wrote: > From: Cong Wang > > Pretty much similar to commit 1336c662474e > ("bpf: Clear per_cpu pointers during bpf_prog_realloc") we also need to > clear these two percpu pointers in bpf_prog_clone_create(), otherwise > would get a double free: > > BUG: kernel NULL pointer dereference

Re: [PATCH net-next] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-02-17 Thread Arnd Bergmann
On Wed, Feb 17, 2021 at 9:20 PM Min Li wrote: > > I attached the G.8273.2 document, where chapter 6 is about supporting > physical layer > frequency. And combo mode is Renesas way to support this requirement. Other > companies > may come up with different ways to support it. > > When EEC quality

Re: [PATCH net-next] net: phy: icplus: Call phy_restore_page() when phy_select_page() fails

2021-02-17 Thread Dan Carpenter
On Wed, Feb 17, 2021 at 06:06:48PM +0100, Andrew Lunn wrote: > > I'm wondering whether we need to add __acquires() and __releases() > > annotations to some of these functions so that sparse can catch > > these cases. Thoughts? > > Hi Russell > > The more tools we have for catching locking problem

[PATCH net-next] r8169: use macro pm_ptr

2021-02-17 Thread Heiner Kallweit
Use macro pm_ptr(), this helps to avoid some ifdeffery. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169_main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index

Re: [PATCH net-next] net: mscc: ocelot: select PACKING in the Kconfig

2021-02-17 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 17 Feb 2021 22:33:48 +0200 you wrote: > From: Vladimir Oltean > > Ocelot now uses include/linux/dsa/ocelot.h which makes use of > CONFIG_PACKING to pack/unpack bits into the Injection/Extraction Frame > Headers. S

Re: [PATCH 1/2] vdpa/mlx5: Fix suspend/resume index restoration

2021-02-17 Thread Michael S. Tsirkin
On Wed, Feb 17, 2021 at 11:42:48AM -0800, Si-Wei Liu wrote: > > > On 2/16/2021 8:20 AM, Eli Cohen wrote: > > When we suspend the VM, the VDPA interface will be reset. When the VM is > > resumed again, clear_virtqueues() will clear the available and used > > indices resulting in hardware virqtqueu

Re: [PATCH net-next] net: mdio: Remove of_phy_attach()

2021-02-17 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 17 Feb 2021 12:25:57 -0800 you wrote: > We have no in-tree users, also update the sfp-phylink.rst documentation > to indicate that phy_attach_direct() is used instead of of_phy_attach(). > > Signed-off-by: Florian

[PATCH] Revert "ath9k: fix ath_tx_process_buffer() potential null ptr dereference"

2021-02-17 Thread Shuah Khan
ath_tx_process_buffer() doesn't dereference or check sta and passes it to ath_tx_complete_aggr() and ath_tx_complete_buf(). ath_tx_complete_aggr() checks the pointer before use. No problem here. ath_tx_complete_buf() doesn't check or dereference sta and passes it on to ath_tx_complete(). ath_tx_c

[PATCH net-next] net: mscc: ocelot: select PACKING in the Kconfig

2021-02-17 Thread Vladimir Oltean
From: Vladimir Oltean Ocelot now uses include/linux/dsa/ocelot.h which makes use of CONFIG_PACKING to pack/unpack bits into the Injection/Extraction Frame Headers. So it needs to explicitly select it, otherwise there might be build errors due to the missing dependency. Fixes: 40d3f295b5fe ("net:

Re: [PATCH net-next] net: mdio: Remove of_phy_attach()

2021-02-17 Thread Andrew Lunn
On Wed, Feb 17, 2021 at 12:25:57PM -0800, Florian Fainelli wrote: > We have no in-tree users, also update the sfp-phylink.rst documentation > to indicate that phy_attach_direct() is used instead of of_phy_attach(). > > Signed-off-by: Florian Fainelli Reviewed-by: Andrew Lunn Andrew

Re: [PATCH mlx5-next v6 1/4] PCI: Add sysfs callback to allow MSI-X table size change of SR-IOV VFs

2021-02-17 Thread Bjorn Helgaas
On Wed, Feb 17, 2021 at 03:25:22PM -0400, Jason Gunthorpe wrote: > On Wed, Feb 17, 2021 at 12:02:39PM -0600, Bjorn Helgaas wrote: > > > > BTW, I asked more than once how these sysfs knobs should be handled > > > in the PCI/core. > > > > Thanks for the pointers. This is the first instance I can t

Re: [PATCH 2/2] ath9k: fix ath_tx_process_buffer() potential null ptr dereference

2021-02-17 Thread Shuah Khan
On 2/17/21 7:56 AM, Shuah Khan wrote: On 2/17/21 12:30 AM, Kalle Valo wrote: Shuah Khan writes: On 2/16/21 12:53 AM, Felix Fietkau wrote: On 2021-02-16 08:03, Kalle Valo wrote: Shuah Khan wrote: ath_tx_process_buffer() references ieee80211_find_sta_by_ifaddr() return pointer (sta) outsi

  1   2   3   >