Re: [PATCH v3] brcmfmac: add support for CQM RSSI notifications

2021-02-08 Thread Kalle Valo
Alvin Šipraga wrote: > Add support for CQM RSSI measurement reporting and advertise the > NL80211_EXT_FEATURE_CQM_RSSI_LIST feature. This enables a userspace > supplicant such as iwd to be notified of changes in the RSSI for roaming > and signal monitoring purposes. > > Signed-off-by: Alvin Šipr

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-08 Thread Nathan Chancellor
On Mon, Feb 08, 2021 at 10:56:36PM -0800, Andrii Nakryiko wrote: > On Mon, Feb 8, 2021 at 10:13 PM Andrii Nakryiko > wrote: > > > > On Mon, Feb 8, 2021 at 10:09 PM Andrii Nakryiko > > wrote: > > > > > > On Mon, Feb 8, 2021 at 9:23 PM Nathan Chancellor > > > wrote: > > > > > > > > On Mon, Feb 08

[PATCH bpf v3] selftests/bpf: convert test_xdp_redirect.sh to bash

2021-02-08 Thread Björn Töpel
From: Björn Töpel The test_xdp_redirect.sh script uses a bash feature, '&>'. On systems, e.g. Debian, where '/bin/sh' is dash, this will not work as expected. Use bash in the shebang to get the expected behavior. Further, using 'set -e' means that the error of a command cannot be captured withou

Re: [PATCH net 2/2] switchdev: mrp: Remove SWITCHDEV_ATTR_ID_MRP_PORT_STAT

2021-02-08 Thread Rasmus Villemoes
On 06/02/2021 22.47, Horatiu Vultur wrote: > Now that MRP started to use also SWITCHDEV_ATTR_ID_PORT_STP_STATE to > notify HW, then SWITCHDEV_ATTR_ID_MRP_PORT_STAT is not used anywhere > else, therefore we can remove it. > > Fixes: c284b545900830 ("switchdev: mrp: Extend switchdev API to offload M

Re: [PATCH net 1/2] bridge: mrp: Fix the usage of br_mrp_port_switchdev_set_state

2021-02-08 Thread Rasmus Villemoes
On 06/02/2021 22.47, Horatiu Vultur wrote: > The function br_mrp_port_switchdev_set_state was called both with MRP > port state and STP port state, which is an issue because they don't > match exactly. > > Therefore, update the function to be used only with STP port state and > use the id SWITCHDE

Re: KMSAN: uninit-value in bpf_iter_prog_supported

2021-02-08 Thread Dmitry Vyukov
On Sun, Feb 7, 2021 at 1:20 PM syzbot wrote: > > Hello, > > syzbot found the following issue on: > > HEAD commit:73d62e81 kmsan: random: prevent boot-time reports in _mix_.. > git tree: https://github.com/google/kmsan.git master > console output: https://syzkaller.appspot.com/x/log.txt?x

Re: [PATCH] carl9170: fix struct alignment conflict

2021-02-08 Thread Kalle Valo
Arnd Bergmann wrote: > Multiple structures in the carl9170 driver have alignment > impossible alignment constraints that gcc warns about when > building with 'make W=1': > > drivers/net/wireless/ath/carl9170/fwcmd.h:243:2: warning: alignment 1 of > 'union ' is less than 4 [-Wpacked-not-aligned]

Re: [PATCH] wcn36xx: del BA session on TX stop

2021-02-08 Thread Kalle Valo
Loic Poulain wrote: > Deleting BA session was not correcly performed, causing communication > issues with APs that dynamically stop/start new BA sessions. > > Signed-off-by: Loic Poulain > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 84da2a84027c wcn36xx: de

Re: [PATCH] ath10k: Fix lockdep assertion warning in ath10k_sta_statistics

2021-02-08 Thread Kalle Valo
Anand K Mistry wrote: > ath10k_debug_fw_stats_request just be called with conf_mutex held, > otherwise the following warning is seen when lock debugging is enabled: > > WARNING: CPU: 0 PID: 793 at drivers/net/wireless/ath/ath10k/debug.c:357 > ath10k_debug_fw_stats_request+0x12c/0x133 [ath10k_co

Re: [PATCH] ath10k: Fix suspicious RCU usage warning in ath10k_wmi_tlv_parse_peer_stats_info()

2021-02-08 Thread Kalle Valo
Anand K Mistry wrote: > The ieee80211_find_sta_by_ifaddr call in > ath10k_wmi_tlv_parse_peer_stats_info must be called while holding the > RCU read lock. Otherwise, the following warning will be seen when RCU > usage checking is enabled: > > = > WARNING: suspicious RC

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-08 Thread Andrii Nakryiko
On Mon, Feb 8, 2021 at 10:13 PM Andrii Nakryiko wrote: > > On Mon, Feb 8, 2021 at 10:09 PM Andrii Nakryiko > wrote: > > > > On Mon, Feb 8, 2021 at 9:23 PM Nathan Chancellor wrote: > > > > > > On Mon, Feb 08, 2021 at 08:45:43PM -0800, Andrii Nakryiko wrote: > > > > On Mon, Feb 8, 2021 at 7:44 PM

Re: [PATCH bpf v2] selftests/bpf: remove bash feature in test_xdp_redirect.sh

2021-02-08 Thread Randy Dunlap
On 2/8/21 10:41 PM, Björn Töpel wrote: > On 2021-02-09 06:52, Andrii Nakryiko wrote: >> On Sat, Feb 6, 2021 at 1:29 AM Björn Töpel wrote: >>> >>> From: Björn Töpel >>> >>> The test_xdp_redirect.sh script uses a bash redirect feature, >>> '&>/dev/null'. Use '>/dev/null 2>&1' instead. >> >> We have

Re: [PATCH net-next v2] net: phy: broadcom: remove BCM5482 1000Base-BX support

2021-02-08 Thread Heiner Kallweit
On 09.02.2021 02:30, Andrew Lunn wrote: > On Tue, Feb 09, 2021 at 12:17:06AM +0100, Michael Walle wrote: >> It is nowhere used in the kernel. It also seems to be lacking the >> proper fiber advertise flags. Remove it. > > Maybe also remove the #define for PHY_BCM_FLAGS_MODE_1000BX? Maybe > there i

Re: [Patch bpf-next 01/19] bpf: rename BPF_STREAM_PARSER to BPF_SOCK_MAP

2021-02-08 Thread John Fastabend
Cong Wang wrote: > On Mon, Feb 8, 2021 at 12:21 AM John Fastabend > wrote: > > > > Cong Wang wrote: > > > From: Cong Wang > > > > > > Before we add non-TCP support, it is necessary to rename > > > BPF_STREAM_PARSER as it will be no longer specific to TCP, > > > and it does not have to be a parse

Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency

2021-02-08 Thread Leon Romanovsky
On Mon, Feb 08, 2021 at 07:07:35PM +0200, Ido Schimmel wrote: > On Mon, Feb 08, 2021 at 11:07:02AM +0200, Leon Romanovsky wrote: > > On Mon, Feb 08, 2021 at 10:57:46AM +0200, Ido Schimmel wrote: > > > On Mon, Feb 08, 2021 at 09:03:50AM +0200, Leon Romanovsky wrote: > > > > On Mon, Feb 01, 2021 at 0

Re: [PATCH bpf v2] selftests/bpf: remove bash feature in test_xdp_redirect.sh

2021-02-08 Thread Björn Töpel
On 2021-02-09 06:52, Andrii Nakryiko wrote: On Sat, Feb 6, 2021 at 1:29 AM Björn Töpel wrote: From: Björn Töpel The test_xdp_redirect.sh script uses a bash redirect feature, '&>/dev/null'. Use '>/dev/null 2>&1' instead. We have plenty of explicit bash uses in selftest scripts, I'm not sure

Re: [PATCH v1] vdpa/mlx5: Restore the hardware used index after change map

2021-02-08 Thread Jason Wang
On 2021/2/9 下午2:12, Eli Cohen wrote: On Tue, Feb 09, 2021 at 11:20:14AM +0800, Jason Wang wrote: On 2021/2/8 下午6:04, Eli Cohen wrote: On Mon, Feb 08, 2021 at 05:04:27PM +0800, Jason Wang wrote: On 2021/2/8 下午2:37, Eli Cohen wrote: On Mon, Feb 08, 2021 at 12:27:18PM +0800, Jason Wang wrote:

[PATCH net v5] net/sched: cls_flower: Reject invalid ct_state flags rules

2021-02-08 Thread wenxu
From: wenxu Reject the unsupported and invalid ct_state flags of cls flower rules. Fixes: e0ace68af2ac ("net/sched: cls_flower: Add matching on conntrack info") Signed-off-by: wenxu --- include/uapi/linux/pkt_cls.h | 2 ++ net/sched/cls_flower.c | 39

Re: [net-next v2] tcp: Explicitly mark reserved field in tcp_zerocopy_receive args.

2021-02-08 Thread Leon Romanovsky
On Mon, Feb 08, 2021 at 08:20:29PM -0700, David Ahern wrote: > On 2/8/21 7:53 PM, Jakub Kicinski wrote: > > On Mon, 8 Feb 2021 19:24:05 -0700 David Ahern wrote: > >> On 2/8/21 11:41 AM, Jakub Kicinski wrote: > >>> On Sun, 7 Feb 2021 10:26:54 +0200 Leon Romanovsky wrote: > There is a check that

Re: [net-next v2] tcp: Explicitly mark reserved field in tcp_zerocopy_receive args.

2021-02-08 Thread Leon Romanovsky
On Mon, Feb 08, 2021 at 10:41:43AM -0800, Jakub Kicinski wrote: > On Sun, 7 Feb 2021 10:26:54 +0200 Leon Romanovsky wrote: > > On Sat, Feb 06, 2021 at 03:28:28PM -0800, Jakub Kicinski wrote: > > > On Sat, 6 Feb 2021 12:36:48 -0800 Arjun Roy wrote: > > > > From: Arjun Roy > > > > > > > > Explicitl

Re: [PATCH v1] vdpa/mlx5: Restore the hardware used index after change map

2021-02-08 Thread Eli Cohen
On Tue, Feb 09, 2021 at 11:20:14AM +0800, Jason Wang wrote: > > On 2021/2/8 下午6:04, Eli Cohen wrote: > > On Mon, Feb 08, 2021 at 05:04:27PM +0800, Jason Wang wrote: > > > On 2021/2/8 下午2:37, Eli Cohen wrote: > > > > On Mon, Feb 08, 2021 at 12:27:18PM +0800, Jason Wang wrote: > > > > > On 2021/2/6

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-08 Thread Andrii Nakryiko
On Mon, Feb 8, 2021 at 10:09 PM Andrii Nakryiko wrote: > > On Mon, Feb 8, 2021 at 9:23 PM Nathan Chancellor wrote: > > > > On Mon, Feb 08, 2021 at 08:45:43PM -0800, Andrii Nakryiko wrote: > > > On Mon, Feb 8, 2021 at 7:44 PM Nathan Chancellor > > > wrote: > > > > > > > > Hi all, > > > > > > > >

[PATCH net-next v2] cxgb4: collect serial config version from register

2021-02-08 Thread Rahul Lakkireddy
Collect serial config version information directly from an internal register, instead of explicitly resizing VPD. v2: - Add comments on info stored in PCIE_STATIC_SPARE2 register. Signed-off-by: Rahul Lakkireddy --- .../net/ethernet/chelsio/cxgb4/cudbg_entity.h | 3 --- .../net/ethernet/chelsi

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-08 Thread Andrii Nakryiko
On Mon, Feb 8, 2021 at 9:23 PM Nathan Chancellor wrote: > > On Mon, Feb 08, 2021 at 08:45:43PM -0800, Andrii Nakryiko wrote: > > On Mon, Feb 8, 2021 at 7:44 PM Nathan Chancellor wrote: > > > > > > Hi all, > > > > > > Recently, an issue with CONFIG_DEBUG_INFO_BTF was reported for arm64: > > > http

Re: [PATCH bpf v2] selftests/bpf: remove bash feature in test_xdp_redirect.sh

2021-02-08 Thread Andrii Nakryiko
On Sat, Feb 6, 2021 at 1:29 AM Björn Töpel wrote: > > From: Björn Töpel > > The test_xdp_redirect.sh script uses a bash redirect feature, > '&>/dev/null'. Use '>/dev/null 2>&1' instead. We have plenty of explicit bash uses in selftest scripts, I'm not sure it's a good idea to make scripts more v

Re: [PATCH RFC v2 3/4] virtio-net: support transmit timestamp

2021-02-08 Thread Jason Wang
On 2021/2/9 上午2:55, Willem de Bruijn wrote: From: Willem de Bruijn Add optional PTP hardware tx timestamp offload for virtio-net. Accurate RTT measurement requires timestamps close to the wire. Introduce virtio feature VIRTIO_NET_F_TX_TSTAMP, the transmit equivalent to VIRTIO_NET_F_RX_TSTAMP

Re: [PATCH net v4] net/sched: cls_flower: Reject invalid ct_state flags rules

2021-02-08 Thread Cong Wang
On Mon, Feb 8, 2021 at 10:48 AM Jakub Kicinski wrote: > > On Mon, 8 Feb 2021 10:41:35 -0800 Cong Wang wrote: > > On Sat, Feb 6, 2021 at 9:26 PM wrote: > > > + if (state && !(state & TCA_FLOWER_KEY_CT_FLAGS_TRACKED)) { > > > + NL_SET_ERR_MSG_ATTR(extack, tb, > > > +

Re: [PATCHv2 bpf-next 0/4] kbuild/resolve_btfids: Invoke resolve_btfids clean in root Makefile

2021-02-08 Thread Andrii Nakryiko
On Fri, Feb 5, 2021 at 4:45 AM Jiri Olsa wrote: > > hi, > resolve_btfids tool is used during the kernel build, > so we should clean it on kernel's make clean. > > v2 changes: > - add Song's acks on patches 1 and 4 (others changed) [Song] > - add missing / [Andrii] > - change srctree variable

Re: [PATCH net-next 0/8] mld: change context from atomic to sleepable

2021-02-08 Thread Cong Wang
On Mon, Feb 8, 2021 at 6:17 PM Taehee Yoo wrote: > You're right, this patchset contains many unnecessary changes. > So I will send a v2 patch, which contains only the necessary changes. > And target branch will be 'net', not 'net-next'. Just to be clear: this is up to you. I am not suggesting the

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-08 Thread Nathan Chancellor
On Mon, Feb 08, 2021 at 08:45:43PM -0800, Andrii Nakryiko wrote: > On Mon, Feb 8, 2021 at 7:44 PM Nathan Chancellor wrote: > > > > Hi all, > > > > Recently, an issue with CONFIG_DEBUG_INFO_BTF was reported for arm64: > > https://groups.google.com/g/clang-built-linux/c/de_mNh23FOc/m/E7cu5BwbBAAJ >

Re: [PATCH] selftests/bpf: Simplify the calculation of variables

2021-02-08 Thread Andrii Nakryiko
On Thu, Feb 4, 2021 at 10:27 PM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./tools/testing/selftests/bpf/xdpxceiver.c:954:28-30: WARNING !A || A && > B is equivalent to !A || B. > > ./tools/testing/selftests/bpf/xdpxceiver.c:932:28-30: WARNING !A || A && > B is equivalent

Re: FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-08 Thread Andrii Nakryiko
On Mon, Feb 8, 2021 at 7:44 PM Nathan Chancellor wrote: > > Hi all, > > Recently, an issue with CONFIG_DEBUG_INFO_BTF was reported for arm64: > https://groups.google.com/g/clang-built-linux/c/de_mNh23FOc/m/E7cu5BwbBAAJ > > $ make -skj"$(nproc)" ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- \ >

Re: [PATCH RFC v2 2/4] virtio-net: support receive timestamp

2021-02-08 Thread Jason Wang
On 2021/2/9 上午2:55, Willem de Bruijn wrote: From: Willem de Bruijn Add optional PTP hardware rx timestamp offload for virtio-net. Accurate RTT measurement requires timestamps close to the wire. Introduce virtio feature VIRTIO_NET_F_RX_TSTAMP. If negotiated, the virtio-net header is expanded

RE: [PATCH net-next v2 7/7] netdevsim: Add netdevsim port add test cases

2021-02-08 Thread Parav Pandit
> From: Jakub Kicinski > Sent: Tuesday, February 9, 2021 2:51 AM > > On Sun, 7 Feb 2021 10:44:12 +0200 Parav Pandit wrote: > > + RET=0 > > + USR_PF_PORT_INDEX=600 > > + USR_PFNUM_A=2 > > + USR_PFNUM_B=3 > > + USR_SF_PORT_INDEX=601 > > + USR_SFNUM_A=44 > > + USR_SFNUM_B=55 > > + >

FAILED unresolved symbol vfs_truncate on arm64 with LLVM

2021-02-08 Thread Nathan Chancellor
Hi all, Recently, an issue with CONFIG_DEBUG_INFO_BTF was reported for arm64: https://groups.google.com/g/clang-built-linux/c/de_mNh23FOc/m/E7cu5BwbBAAJ $ make -skj"$(nproc)" ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- \ LLVM=1 O=build/aarch64 defconfig $ scripts/config \

Re: [PATCH net-next 7/8] mld: convert ip6_sf_socklist to list macros

2021-02-08 Thread Taehee Yoo
On Tue, 9 Feb 2021 at 11:56, Jakub Kicinski wrote: > > On Mon, 8 Feb 2021 19:18:40 -0700 David Ahern wrote: > > On 2/8/21 7:05 PM, Taehee Yoo wrote: > > > Thanks, I understand why the arrays have been using. > > > I will send a v2 patch, which contains only the necessary changes. > > > > please se

[RFC PATCH] mld: mld_check_leave_group() can be static

2021-02-08 Thread kernel test robot
Reported-by: kernel test robot Signed-off-by: kernel test robot --- mcast.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/mcast.c b/net/ipv6/mcast.c index 5fd87659dcefa..c9862a647a4b6 100644 --- a/net/ipv6/mcast.c +++ b/net/ipv6/mcast.c @@ -330,7 +330,7 @@ voi

Re: [PATCH 3/3] mlx5_vdpa: defer clear_virtqueues to until DRIVER_OK

2021-02-08 Thread Jason Wang
On 2021/2/6 下午8:29, Si-Wei Liu wrote: While virtq is stopped, get_vq_state() is supposed to be called to get sync'ed with the latest internal avail_index from device. The saved avail_index is used to restate the virtq once device is started. Commit b35ccebe3ef7 introduced the clear_vir

Re: [PATCH net-next 8/8] mld: change context of mld module

2021-02-08 Thread kernel test robot
Hi Taehee, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Taehee-Yoo/mld-change-context-from-atomic-to-sleepable/20210209-072339 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/ne

Re: [PATCH v5 1/1] iio/scmi: Adding support for IIO SCMI Based Sensors

2021-02-08 Thread kernel test robot
Hi Jyoti, I love your patch! Perhaps something to improve: [auto build test WARNING on iio/togreg] [also build test WARNING on linus/master sparc-next/master v5.11-rc6 next-20210125] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to

Re: [PATCH net] virtio-net: suppress bad irq warning for tx napi

2021-02-08 Thread Jason Wang
On 2021/2/9 上午3:08, Willem de Bruijn wrote: On Sun, Feb 7, 2021 at 10:29 PM Jason Wang wrote: On 2021/2/5 上午4:50, Willem de Bruijn wrote: On Wed, Feb 3, 2021 at 10:06 PM Jason Wang wrote: On 2021/2/4 上午2:28, Willem de Bruijn wrote: On Wed, Feb 3, 2021 at 12:33 AM Jason Wang wrote: On 2

Re: [PATCH net-next RESEND 3/5] net: stmmac: dwmac-sun8i: Use reset_control_reset

2021-02-08 Thread Samuel Holland
On 2/8/21 10:29 AM, Alexander Duyck wrote: > On Sun, Feb 7, 2021 at 10:32 PM Samuel Holland wrote: >> >> Use the appropriate function instead of reimplementing it, >> and update the error message to match the code. >> >> Reviewed-by: Chen-Yu Tsai >> Signed-off-by: Samuel Holland >> --- >> drive

Re: [PATCH v1] vdpa/mlx5: Restore the hardware used index after change map

2021-02-08 Thread Jason Wang
On 2021/2/8 下午6:04, Eli Cohen wrote: On Mon, Feb 08, 2021 at 05:04:27PM +0800, Jason Wang wrote: On 2021/2/8 下午2:37, Eli Cohen wrote: On Mon, Feb 08, 2021 at 12:27:18PM +0800, Jason Wang wrote: On 2021/2/6 上午7:07, Si-Wei Liu wrote: On 2/3/2021 11:36 PM, Eli Cohen wrote: When a change of me

Re: [net-next v2] tcp: Explicitly mark reserved field in tcp_zerocopy_receive args.

2021-02-08 Thread David Ahern
On 2/8/21 7:53 PM, Jakub Kicinski wrote: > On Mon, 8 Feb 2021 19:24:05 -0700 David Ahern wrote: >> On 2/8/21 11:41 AM, Jakub Kicinski wrote: >>> On Sun, 7 Feb 2021 10:26:54 +0200 Leon Romanovsky wrote: There is a check that len is not larger than zs and users can't give large buffer. >>

Re: [PATCH net-next 8/8] mld: change context of mld module

2021-02-08 Thread kernel test robot
Hi Taehee, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Taehee-Yoo/mld-change-context-from-atomic-to-sleepable/20210209-072339 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/ne

[PATCH] rtlwifi: rtl8821ae: phy: Simplify bool comparison

2021-02-08 Thread Jiapeng Chong
Fix the following coccicheck warning: ./drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:3853:7-17: WARNING: Comparison of 0/1 to bool variable. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c | 2 +- 1 file changed, 1 insertio

Re: [PATCH] i2c: mv64xxx: Fix check for missing clock

2021-02-08 Thread Samuel Holland
On 2/8/21 7:20 AM, Andrew Lunn wrote: > On Mon, Feb 08, 2021 at 12:31:34AM -0600, Samuel Holland wrote: >> On 2/8/21 12:28 AM, Samuel Holland wrote: >>> In commit e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support"), error >>> pointers to optional clocks were replaced by NULL to simplify the resum

Re: [PATCH net-next 11/12] ice: Improve MSI-X fallback logic

2021-02-08 Thread Jakub Kicinski
On Mon, 8 Feb 2021 17:16:35 -0800 Tony Nguyen wrote: > Currently if the driver is unable to get all the MSI-X vectors it wants, it > falls back to the minimum configuration which equates to a single Tx/Rx > traffic queue pair. Instead of using the minimum configuration, if given > more vectors tha

Re: [PATCH net-next 7/8] mld: convert ip6_sf_socklist to list macros

2021-02-08 Thread Jakub Kicinski
On Mon, 8 Feb 2021 19:18:40 -0700 David Ahern wrote: > On 2/8/21 7:05 PM, Taehee Yoo wrote: > > Thanks, I understand why the arrays have been using. > > I will send a v2 patch, which contains only the necessary changes. > > please send v2 as a patch series and not 8 individual patches + cover >

[PATCH] rtlwifi: rtl8192se: Simplify bool comparison

2021-02-08 Thread Jiapeng Chong
Fix the follow coccicheck warnings: ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:2305:6-27: WARNING: Comparison of 0/1 to bool variable. ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1376:5-26: WARNING: Comparison of 0/1 to bool variable. Reported-by: Abaci Robot Signed-off-by:

Re: [net-next v2] tcp: Explicitly mark reserved field in tcp_zerocopy_receive args.

2021-02-08 Thread Jakub Kicinski
On Mon, 8 Feb 2021 19:24:05 -0700 David Ahern wrote: > On 2/8/21 11:41 AM, Jakub Kicinski wrote: > > On Sun, 7 Feb 2021 10:26:54 +0200 Leon Romanovsky wrote: > >> There is a check that len is not larger than zs and users can't give > >> large buffer. > >> > >> I would say that is pretty safe to w

Re: [PATCH net-next v2 0/5][pull request] 40GbE Intel Wired LAN Driver Updates 2021-02-08

2021-02-08 Thread Jakub Kicinski
On Mon, 8 Feb 2021 18:23:18 -0800 Tony Nguyen wrote: > This series contains updates to i40e driver only. > > Cristian makes improvements to driver XDP path. Avoids writing > next-to-clean pointer on every update, removes redundant updates of > cleaned_count and buffer info, creates a helper funct

Re: [PATCH V2 net-next 00/11] net: hns3: some cleanups for -next

2021-02-08 Thread Jakub Kicinski
On Tue, 9 Feb 2021 10:41:50 +0800 Huazhong Tan wrote: > There are some cleanups for the HNS3 ethernet driver. > > change log: > V2: remove previous #3 which should target net. > > previous version: > V1: > https://patchwork.kernel.org/project/netdevbpf/cover/1612784382-27262-1-git-send-email-tan

[PATCH V2 net-next 11/11] net: hns3: cleanup for endian issue for VF RSS

2021-02-08 Thread Huazhong Tan
From: Jian Shen Currently the RSS commands of VF are using host byte order. According to the user manual, it should use little endian in the command to firmware. For the host and firmware are both using little endian, so it can work well in this case. Do cleanup to make it more explicitly. Sign

[PATCH V2 net-next 04/11] net: hns3: clean up unnecessary parentheses in macro definitions

2021-02-08 Thread Huazhong Tan
From: Yufeng Mo In macro definitions, parentheses are unnecessary in some cases, such as the calling parameter of a function, the left variable of the equal sign, and so on. So remove these unnecessary parentheses according to these rules. Signed-off-by: Yufeng Mo Signed-off-by: Huazhong Tan -

[PATCH V2 net-next 00/11] net: hns3: some cleanups for -next

2021-02-08 Thread Huazhong Tan
There are some cleanups for the HNS3 ethernet driver. change log: V2: remove previous #3 which should target net. previous version: V1: https://patchwork.kernel.org/project/netdevbpf/cover/1612784382-27262-1-git-send-email-tanhuazh...@huawei.com/ Huazhong Tan (2): net: hns3: remove redundant

[PATCH V2 net-next 09/11] net: hns3: remove an unused parameter in hclge_vf_rate_param_check()

2021-02-08 Thread Huazhong Tan
Parameter vf in hclge_vf_rate_param_check() is unused now, so remove it. Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/driv

[PATCH V2 net-next 06/11] net: hns3: change hclge_parse_speed() param type

2021-02-08 Thread Huazhong Tan
From: Peng Li The type of parameters in hclge_parse_speed() should be unsigned type, so change them. Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/e

[PATCH V2 net-next 07/11] net: hns3: change hclge_query_bd_num() param type

2021-02-08 Thread Huazhong Tan
From: Peng Li The type of parameter mpf_bd_num and pf_bd_num in hclge_query_bd_num() should be u32* instead of int*, so change them. Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c | 4 ++-- 1 file changed, 2 insertions(+), 2 delet

[PATCH V2 net-next 08/11] net: hns3: remove redundant return value of hns3_uninit_all_ring()

2021-02-08 Thread Huazhong Tan
Since hns3_uninit_all_ring() only returns 0, so remove this redundant return value and function declaration in hns3_enet.h. Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 12 +++- drivers/net/ethernet/hisilicon/hns3/hns3_enet.h | 1 - 2 files changed,

[PATCH V2 net-next 01/11] net: hns3: clean up some incorrect variable types in hclge_dbg_dump_tm_map()

2021-02-08 Thread Huazhong Tan
From: Yonglong Liu queue_id, qset_id and other IDs are unsigned type, so modify the corresponding local variables' type in hclge_dbg_dump_tm_map() from signed to unsigned. kstrtouint() and the print format should be updated as well. Signed-off-by: Yonglong Liu Signed-off-by: Huazhong Tan ---

[PATCH V2 net-next 10/11] net: hns3: remove unused macro definition

2021-02-08 Thread Huazhong Tan
From: Peng Li Some macros are defined but unused, so remove them. Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h | 3 --- drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.h | 1 - 2 files changed, 4 deletions(-) diff --gi

[PATCH V2 net-next 03/11] net: hns3: remove the shaper param magic number

2021-02-08 Thread Huazhong Tan
From: Peng Li To make the code more readable, this patch adds a definition for the magic number 126 used for the default shaper param ir_b, and rename macro DIVISOR_IR_B_126. No functional change. Signed-off-by: Peng Li Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3

[PATCH V2 net-next 05/11] net: hns3: modify some unmacthed types print parameter

2021-02-08 Thread Huazhong Tan
From: Jiaran Zhang Fix an issue where the formatting symbol of the formatting input and output function does not match the actual type. Signed-off-by: Jiaran Zhang Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c| 2 +- drivers/net/ethernet/hisilicon/

[PATCH V2 net-next 02/11] net: hns3: remove redundant client_setup_tc handle

2021-02-08 Thread Huazhong Tan
From: Jian Shen Since the real tx queue number and real rx queue number always be updated when netdev opens, it's redundant to call hclge_client_setup_tc to do the same thing. So remove it. Signed-off-by: Jian Shen Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hnae3.h

Re: [PATCH net-next 8/8] mld: change context of mld module

2021-02-08 Thread kernel test robot
Hi Taehee, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Taehee-Yoo/mld-change-context-from-atomic-to-sleepable/20210209-072339 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/ne

Re: [net-next v2] tcp: Explicitly mark reserved field in tcp_zerocopy_receive args.

2021-02-08 Thread David Ahern
On 2/8/21 11:41 AM, Jakub Kicinski wrote: > On Sun, 7 Feb 2021 10:26:54 +0200 Leon Romanovsky wrote: >> On Sat, Feb 06, 2021 at 03:28:28PM -0800, Jakub Kicinski wrote: >>> On Sat, 6 Feb 2021 12:36:48 -0800 Arjun Roy wrote: From: Arjun Roy Explicitly define reserved field and requ

[PATCH net-next v2 3/5] i40e: remove the redundant buffer info updates

2021-02-08 Thread Tony Nguyen
From: Cristian Dumitrescu For performance reasons, remove the redundant buffer info updates (*bi = NULL). The buffers ready to be cleaned can easily be tracked based on the ring next-to-clean variable, which is consistently updated. Signed-off-by: Cristian Dumitrescu Tested-by: Kiran Bhandare

[PATCH net-next v2 1/5] i40e: remove unnecessary memory writes of the next to clean pointer

2021-02-08 Thread Tony Nguyen
From: Cristian Dumitrescu For performance reasons, avoid writing the ring next-to-clean pointer value back to memory on every update, as it is not really necessary. Instead, simply read it at initialization into a local copy, update the local copy as necessary and write the local copy back to mem

[PATCH net-next v2 5/5] i40e: Log error for oversized MTU on device

2021-02-08 Thread Tony Nguyen
From: Eryk Rybak When attempting to link XDP prog with MTU larger than supported, user is not informed why XDP linking fails. Adding proper error message: "MTU too large to enable XDP". Signed-off-by: Aleksandr Loktionov Signed-off-by: Eryk Rybak Tested-by: Kiran Bhandare Signed-off-by: Tony

[PATCH net-next v2 0/5][pull request] 40GbE Intel Wired LAN Driver Updates 2021-02-08

2021-02-08 Thread Tony Nguyen
This series contains updates to i40e driver only. Cristian makes improvements to driver XDP path. Avoids writing next-to-clean pointer on every update, removes redundant updates of cleaned_count and buffer info, creates a helper function to consolidate XDP actions and simplifies some of the behavi

[PATCH net-next v2 4/5] i40e: consolidate handling of XDP program actions

2021-02-08 Thread Tony Nguyen
From: Cristian Dumitrescu Consolidate the actions performed on the packet based on the XDP program result into a separate function that is easier to read and maintain. Simplify the i40e_construct_skb_zc function, so that the input xdp buffer is always freed, regardless of whether the output skb i

[PATCH net-next v2 2/5] i40e: remove unnecessary cleaned_count updates

2021-02-08 Thread Tony Nguyen
From: Cristian Dumitrescu For performance reasons, remove the redundant updates of the cleaned_count variable, as its value can be computed based on the ring next-to-clean variable, which is consistently updated. Signed-off-by: Cristian Dumitrescu Tested-by: Kiran Bhandare Signed-off-by: Tony

Re: [PATCH net-next 7/8] mld: convert ip6_sf_socklist to list macros

2021-02-08 Thread Taehee Yoo
On Tue, 9 Feb 2021 at 11:18, David Ahern wrote: > > On 2/8/21 7:05 PM, Taehee Yoo wrote: > > Thanks, I understand why the arrays have been using. > > I will send a v2 patch, which contains only the necessary changes. > > please send v2 as a patch series and not 8 individual patches + cover > lette

Re: [PATCH net-next 7/8] mld: convert ip6_sf_socklist to list macros

2021-02-08 Thread David Ahern
On 2/8/21 7:05 PM, Taehee Yoo wrote: > Thanks, I understand why the arrays have been using. > I will send a v2 patch, which contains only the necessary changes. please send v2 as a patch series and not 8 individual patches + cover letter. Thanks,

Re: [PATCH net-next 0/8] mld: change context from atomic to sleepable

2021-02-08 Thread Taehee Yoo
On Tue, 9 Feb 2021 at 10:50, Cong Wang wrote: > Hi Cong! Thank you for your review. > On Mon, Feb 8, 2021 at 9:50 AM Taehee Yoo wrote: > > > > This patchset changes context of MLD module. > > Before this patch, MLD functions are atomic context so it couldn't use > > sleepable functions and flag

Re: [PATCH net-next 7/8] mld: convert ip6_sf_socklist to list macros

2021-02-08 Thread Taehee Yoo
On Tue, 9 Feb 2021 at 03:31, Eric Dumazet wrote: > Hi Eric, Thank you for the review! > > > On 2/8/21 6:58 PM, Taehee Yoo wrote: > > Currently, struct ip6_sf_socklist doesn't use list API so that code > > shape is a little bit different from others. > > So it converts ip6_sf_socklist to use list

Re: [PATCH] selftests: bpf: remove unneeded semicolon

2021-02-08 Thread Andrii Nakryiko
On Mon, Feb 8, 2021 at 2:30 AM Yang Li wrote: > > Eliminate the following coccicheck warning: > ./tools/testing/selftests/bpf/test_flow_dissector.c:506:2-3: Unneeded > semicolon > > Reported-by: Abaci Robot > Signed-off-by: Yang Li > --- Applied to bpf-next, changing subject to have more canoni

Re: [PATCH] bpf: Simplify bool comparison

2021-02-08 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Mon, 8 Feb 2021 17:43:36 +0800 you wrote: > Fix the following coccicheck warning: > > ./tools/bpf/bpf_dbg.c:893:32-36: WARNING: Comparison to bool. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > > [...]

Re: [PATCH net-next 7/8] mld: convert ip6_sf_socklist to list macros

2021-02-08 Thread kernel test robot
Hi Taehee, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Taehee-Yoo/mld-change-context-from-atomic-to-sleepable/20210209-072339 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/ne

Re: [PATCH net-next 0/8] mld: change context from atomic to sleepable

2021-02-08 Thread Cong Wang
On Mon, Feb 8, 2021 at 9:50 AM Taehee Yoo wrote: > > This patchset changes context of MLD module. > Before this patch, MLD functions are atomic context so it couldn't use > sleepable functions and flags. > This patchset also contains other refactoring patches, which is to use > list macro, etc. >

Re: [Patch bpf-next 01/19] bpf: rename BPF_STREAM_PARSER to BPF_SOCK_MAP

2021-02-08 Thread Cong Wang
On Mon, Feb 8, 2021 at 12:21 AM John Fastabend wrote: > > Cong Wang wrote: > > From: Cong Wang > > > > Before we add non-TCP support, it is necessary to rename > > BPF_STREAM_PARSER as it will be no longer specific to TCP, > > and it does not have to be a parser either. > > > > This patch renames

Re: [Patch bpf-next 01/19] bpf: rename BPF_STREAM_PARSER to BPF_SOCK_MAP

2021-02-08 Thread Cong Wang
On Fri, Feb 5, 2021 at 2:32 AM Jakub Sitnicki wrote: > > On Wed, Feb 03, 2021 at 05:16 AM CET, Cong Wang wrote: > > From: Cong Wang > > > > Before we add non-TCP support, it is necessary to rename > > BPF_STREAM_PARSER as it will be no longer specific to TCP, > > and it does not have to be a pars

Re: [PATCH 3/3] mlx5_vdpa: defer clear_virtqueues to until DRIVER_OK

2021-02-08 Thread Si-Wei Liu
On 2/7/2021 9:48 PM, Eli Cohen wrote: On Sat, Feb 06, 2021 at 04:29:24AM -0800, Si-Wei Liu wrote: While virtq is stopped, get_vq_state() is supposed to be called to get sync'ed with the latest internal avail_index from device. The saved avail_index is used to restate the virtq once de

[PATCH net] Documentation: networking: ip-sysctl: Document src_valid_mark sysctl

2021-02-08 Thread Jay Vosburgh
Provide documentation for src_valid_mark sysctl, which was added in commit 28f6aeea3f12 ("net: restore ip source validation"). Signed-off-by: Jay Vosburgh --- Documentation/networking/ip-sysctl.rst | 19 +++ 1 file changed, 19 insertions(+) diff --git a/Documentation/ne

Re: [Patch bpf-next 08/19] udp: implement ->read_sock() for sockmap

2021-02-08 Thread Cong Wang
On Mon, Feb 8, 2021 at 1:48 AM Lorenz Bauer wrote: > > On Wed, 3 Feb 2021 at 04:17, Cong Wang wrote: > > > > From: Cong Wang > > > > Cc: John Fastabend > > Cc: Daniel Borkmann > > Cc: Jakub Sitnicki > > Cc: Lorenz Bauer > > Signed-off-by: Cong Wang > > --- > > include/net/udp.h | 2 ++ >

Re: [PATCH net-next v2] net: phy: broadcom: remove BCM5482 1000Base-BX support

2021-02-08 Thread Andrew Lunn
On Tue, Feb 09, 2021 at 12:17:06AM +0100, Michael Walle wrote: > It is nowhere used in the kernel. It also seems to be lacking the > proper fiber advertise flags. Remove it. Maybe also remove the #define for PHY_BCM_FLAGS_MODE_1000BX? Maybe there is an out of tree driver using this? By removing th

Re: [PATCH net-next 03/12] net: hns3: check cmdq message parameters sent from VF

2021-02-08 Thread Huazhong Tan
On 2021/2/9 5:34, Jakub Kicinski wrote: On Mon, 8 Feb 2021 19:39:33 +0800 Huazhong Tan wrote: From: Yufeng Mo The parameters sent from VF may be unreliable. If these parameters are used directly, memory overwriting may occur. Therefore, we need to check parameters before using. Signed-off-b

Re: [PATCH net-next] net: phy: drop explicit genphy_read_status() op

2021-02-08 Thread Andrew Lunn
On Tue, Feb 09, 2021 at 02:00:18AM +0100, Michael Walle wrote: > genphy_read_status() is already the default for the .read_status() op. > Drop the unnecessary references. > > Signed-off-by: Michael Walle Reviewed-by: Andrew Lunn Andrew

Re: [PATCH 2/3] mlx5_vdpa: fix feature negotiation across device reset

2021-02-08 Thread Si-Wei Liu
On 2/7/2021 9:35 PM, Eli Cohen wrote: On Sat, Feb 06, 2021 at 04:29:23AM -0800, Si-Wei Liu wrote: The mlx_features denotes the capability for which set of virtio features is supported by device. In principle, this field needs not be cleared during virtio device reset, as this capability is st

[PATCH net-next 06/12] ice: Use PSM clock frequency to calculate RL profiles

2021-02-08 Thread Tony Nguyen
From: Ben Shelton The core clock frequency is currently hardcoded at 446 MHz for the RL profile calculations. This causes issues since not all devices use that clock frequency. Read the GLGEN_CLKSTAT_SRC register to determine which PSM clock frequency is selected. This ensures that the rate limi

[PATCH net-next 07/12] ice: fix writeback enable logic

2021-02-08 Thread Tony Nguyen
From: Jesse Brandeburg The writeback enable logic was incorrectly implemented (due to misunderstanding what the side effects of the implementation would be during polling). Fix this logic issue, while implementing a new feature allowing the user to control the writeback frequency using the knobs

[PATCH net-next 05/12] ice: create scheduler aggregator node config and move VSIs

2021-02-08 Thread Tony Nguyen
From: Kiran Patil Create set scheduler aggregator node and move for VSIs into respective scheduler node. Max children per aggregator node is 64. There are two types of aggregator node(s) created. 1. dedicated node for PF and _CTRL VSIs 2. dedicated node(s) for VFs. As part of reset and rebuild,

[PATCH net-next 12/12] Documentation: ice: update documentation

2021-02-08 Thread Tony Nguyen
The ice documentation has not been updated since the initial commits of the driver. Update the documentation with features and information that are now available. Signed-off-by: Tony Nguyen --- .../device_drivers/ethernet/intel/ice.rst | 1027 - 1 file changed, 1006 insertion

[PATCH net-next 04/12] ice: Add initial support framework for LAG

2021-02-08 Thread Tony Nguyen
From: Dave Ertman Add the framework and initial implementation for receiving and processing netdev bonding events. This is only the software support and the implementation of the HW offload for bonding support will be coming at a later time. There are some architectural gaps that need to be clo

[PATCH net-next 10/12] ice: Fix trivial error message

2021-02-08 Thread Tony Nguyen
From: Mitch Williams This message indicates an error on close, not open. Signed-off-by: Mitch Williams Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/i

[PATCH net-next 00/12][pull request] 100GbE Intel Wired LAN Driver Updates 2021-02-08

2021-02-08 Thread Tony Nguyen
This series contains updates to the ice driver and documentation. Brett adds a log message when a trusted VF goes in and out of promiscuous for consistency with i40e driver. Dave implements a new LLDP command that allows adding VSI destinations to existing filters and adds support for netdev bond

[PATCH net-next 03/12] ice: Remove xsk_buff_pool from VSI structure

2021-02-08 Thread Tony Nguyen
From: Michal Swiatkowski Current implementation of netdev already contains xsk_buff_pools. We no longer have to contain these structures in ice_vsi. Refactor the code to operate on netdev-provided xsk_buff_pools. Move scheduling napi on each queue to a separate function to simplify setup functi

[PATCH net-next 11/12] ice: Improve MSI-X fallback logic

2021-02-08 Thread Tony Nguyen
Currently if the driver is unable to get all the MSI-X vectors it wants, it falls back to the minimum configuration which equates to a single Tx/Rx traffic queue pair. Instead of using the minimum configuration, if given more vectors than the minimum, utilize those vectors for additional traffic qu

[PATCH net-next 01/12] ice: log message when trusted VF goes in/out of promisc mode

2021-02-08 Thread Tony Nguyen
From: Brett Creeley Currently there is no message printed on the host when a VF goes in and out of promiscuous mode. This is causing confusion because this is the expected behavior based on i40e. Fix this. Signed-off-by: Brett Creeley Tested-by: Tony Brelinski Signed-off-by: Tony Nguyen ---

  1   2   3   4   5   >