Re: [PATCH 2/4] batman-adv: Update copyright years for 2021

2021-02-04 Thread Sven Eckelmann
On Thursday, 4 February 2021 20:58:36 CET Jakub Kicinski wrote: > Back when I was working for a vendor I had a script which used git to > find files touched in current year and then a bit of sed to update the > dates. Instead of running your current script every Jan, you can run > that one every De

[PATCH 2/2] can: m_can: m_can_class_allocate_dev(): remove impossible error return judgment

2021-02-04 Thread Xulin Sun
If the previous can_net device has been successfully allocated, its private data structure is impossible to be empty, remove this redundant error return judgment. Otherwise, memory leaks for alloc_candev() will be triggered. Signed-off-by: Xulin Sun --- drivers/net/can/m_can/m_can.c | 5 - 1

[PATCH 1/2] can: m_can: m_can_plat_probe(): free can_net device in case probe fails

2021-02-04 Thread Xulin Sun
The can_net device is allocated through kvzalloc(), if the subsequent probe cases fail to initialize, it should free the can_net device that has been successfully allocated before. To fix below memory leaks call trace: unreferenced object 0xfc08418b (size 32768): comm "kworker/0:1", pid 2

[PATCH net v3] net/sched: cls_flower: Reject invalid ct_state flags rules

2021-02-04 Thread wenxu
From: wenxu Reject the unsupported and invalid ct_state flags of cls flower rules. Fixes: e0ace68af2ac ("net/sched: cls_flower: Add matching on conntrack info") Signed-off-by: wenxu --- v3: using NLA_POLICY_MASK and NL_SET_ERR_MSG_ATTR include/uapi/linux/pkt_cls.h | 7 +++ net/sched/cls_

Re: [PATCH][next] net/mlx5e: Fix spelling mistake "Unknouwn" -> "Unknown"

2021-02-04 Thread Saeed Mahameed
On Wed, 2021-02-03 at 14:57 -0800, Jesse Brandeburg wrote: > Colin King wrote: > > > From: Colin Ian King > > > > There is a spelling mistake in a netdev_warn message. Fix it. > > > > Signed-off-by: Colin Ian King > > Trivial patch, looks fine! > > Reviewed-by: Jesse Brandeburg Applied to

Re: [PATCH][next] net/mlx5e: Fix spelling mistake "channles" -> "channels"

2021-02-04 Thread Saeed Mahameed
On Thu, 2021-02-04 at 09:32 +, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a netdev_warn message. Fix it. > > Signed-off-by: Colin Ian King > --- Applied to net-next-mlx5 thanks!

[net-next 16/17] net/mlx5e: Rename some encap-specific API to generic names

2021-02-04 Thread Saeed Mahameed
From: Vlad Buslov Some of the encap-specific functions and fields will also be used by route update infrastructure in following patches. Rename them to generic names. Signed-off-by: Vlad Buslov Signed-off-by: Dmytro Linkin Reviewed-by: Roi Dayan Signed-off-by: Saeed Mahameed --- drivers/net

[net-next 07/17] net/mlx5: E-Switch, Indirect table infrastructure

2021-02-04 Thread Saeed Mahameed
From: Vlad Buslov Indirect table infrastructure is used to allow fully processing VF tunnel traffic in hardware. Kernel software model uses two TC rules for such traffic: UL rep to tunnel device, then tunnel VF rep to destination VF rep. To implement such pipeline driver needs to program the hard

[net-next 17/17] net/mlx5e: Handle FIB events to update tunnel endpoint device

2021-02-04 Thread Saeed Mahameed
From: Vlad Buslov Process FIB route update events to dynamically update the stack device rules when tunnel routing changes. Use rtnl lock to prevent FIB event handler from running concurrently with neigh update and neigh stats workqueue tasks. Use encap_tbl_lock mutex to synchronize with TC rule

[net-next 15/17] net/mlx5e: TC preparation refactoring for routing update event

2021-02-04 Thread Saeed Mahameed
From: Vlad Buslov Following patch in series implement routing update event which requires ability to modify rule match_to_reg modify header actions dynamically during rule lifetime. In order to accommodate such behavior, refactor and extend TC infrastructure in following ways: - Modify mod_hdr i

[net-next 14/17] net/mlx5e: Refactor neigh update infrastructure

2021-02-04 Thread Saeed Mahameed
From: Vlad Buslov Following patches in series implements route update which can cause encap entries to migrate between routing devices. Consecutively, their parent nhe's need to be also transferable between devices instead of having neigh device as a part of their immutable key. Move neigh device

[net-next 10/17] net/mlx5e: Refactor reg_c1 usage

2021-02-04 Thread Saeed Mahameed
From: Vlad Buslov Following patch in series uses reg_c1 in eswitch code. To use reg_c1 helpers in both TC and eswitch code, refactor existing helpers according to similar use case of reg_c0 and move the functionality into eswitch.h. Calculate reg mappings length from new defines to ensure that th

[net-next 13/17] net/mlx5e: Create route entry infrastructure

2021-02-04 Thread Saeed Mahameed
From: Vlad Buslov Implement dedicated route entry infrastructure to be used in following patch by route update event. Both encap (indirectly through their corresponding encap entries) and decap (directly) flows are attached to routing entry. Since route update also requires updating encap (route

[net-next 09/17] net/mlx5e: VF tunnel RX traffic offloading

2021-02-04 Thread Saeed Mahameed
From: Vlad Buslov When tunnel endpoint is on VF the encapsulated RX traffic is exposed on the representor of the VF without any further processing of rules installed on the VF. Detect such case by checking if the device returned by route lookup in decap rule handling code is a mlx5 VF and handle

[net-next 12/17] net/mlx5e: Extract tc tunnel encap/decap code to dedicated file

2021-02-04 Thread Saeed Mahameed
From: Vlad Buslov Following patches in series extend the extracted code with routing infrastructure. To improve code modularity created a dedicated tc_tun_encap.c source file and move encap/decap related code to the new file. Export code that is used by both regular TC code and encap/decap code i

[net-next 11/17] net/mlx5e: Match recirculated packet miss in slow table using reg_c1

2021-02-04 Thread Saeed Mahameed
From: Vlad Buslov Previous patch in series that implements stack devices RX path implements indirect table rules that match on tunnel VNI. After such rule is created all tunnel traffic is recirculated to root table. However, recirculated packet might not match on any rules installed in the table

[net-next 08/17] net/mlx5e: Remove redundant match on tunnel destination mac

2021-02-04 Thread Saeed Mahameed
From: Vlad Buslov Remove hardcoded match on tunnel destination MAC address. Such match is no longer required and would be wrong for stacked devices topology where encapsulation destination MAC address will be the address of tunnel VF that can change dynamically on route change (implemented in fol

[net-next 05/17] net/mlx5e: VF tunnel TX traffic offloading

2021-02-04 Thread Saeed Mahameed
From: Vlad Buslov When tunnel endpoint is on VF, driver still assumes that endpoint is on uplink and incorrectly configures encap rule offload according to that assumption. As a result, traffic is sent directly to the uplink and rules installed on representor of tunnel endpoint VF are ignored. I

[pull request][net-next 00/17] mlx5 updates 2021-02-04

2021-02-04 Thread Saeed Mahameed
From: Saeed Mahameed Hi Jakub, This series adds support for VF tunneling from Vlad, For more information please see tag log below. Please pull and let me know if there is any problem. Thanks, Saeed. --- The following changes since commit 4d469ec8ec05e1fa4792415de1a95b28871ff2fa: Merge bran

[net-next 06/17] net/mlx5e: Refactor tun routing helpers

2021-02-04 Thread Saeed Mahameed
From: Vlad Buslov Refactor tun routing helpers to use dedicated struct mlx5e_tc_tun_route_attr instead of multiple output arguments. This simplifies the callers (no need to keep track of bunch of output param pointers) and allows to unify struct release code in new mlx5e_tc_tun_route_attr_cleanup

[net-next 04/17] net/mlx5: E-Switch, Refactor rule offload forward action processing

2021-02-04 Thread Saeed Mahameed
From: Vlad Buslov Following patches in the series extend forwarding functionality with VF tunnel TX and RX handling. Extract action forwarding processing code into dedicated functions to simplify further extensions: - Handle every forwarding case with dedicated function instead of inline code.

[net-next 03/17] net/mlx5e: Always set attr mdev pointer

2021-02-04 Thread Saeed Mahameed
From: Vlad Buslov Eswitch offloads extensions in following patches in the series require attr->esw_attr->in_mdev pointer to always be set. This is already the case for all code paths except mlx5_tc_ct_entry_add_rule() function. Fix the function to assign mdev pointer with priv->mdev value. Signe

[net-next 02/17] net/mlx5e: E-Switch, Maintain vhca_id to vport_num mapping

2021-02-04 Thread Saeed Mahameed
From: Vlad Buslov Following patches in the series need to be able to map VF netdev to vport. Since it is trivial to obtain vhca_id from netdev, maintain mapping from vhca_id to vport_num inside eswitch offloads using xarray. Provide function mlx5_eswitch_vhca_id_to_vport() to be used by TC code i

[net-next 01/17] net/mlx5: E-Switch, Refactor setting source port

2021-02-04 Thread Saeed Mahameed
From: Mark Bloch Setting the source port requires only the E-Switch and vport number. Refactor the function to get those parameters instead of passing the full attribute. Signed-off-by: Mark Bloch Reviewed-by: Saeed Mahameed Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/eswitch_of

[PATCH] net: core: Clean code style issues in `neighbour.c`

2021-02-04 Thread Zheng Yongjun
Do code format alignment to clean code style issues. Signed-off-by: Zheng Yongjun --- net/core/neighbour.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/net/core/neighbour.c b/net/core/neighbour.c index 9500d28a43b0..a742c918a09b 100644 --- a/net/core/neig

[PATCH] selftests/bpf: Simplify the calculation of variables

2021-02-04 Thread Jiapeng Chong
Fix the following coccicheck warnings: ./tools/testing/selftests/bpf/xdpxceiver.c:954:28-30: WARNING !A || A && B is equivalent to !A || B. ./tools/testing/selftests/bpf/xdpxceiver.c:932:28-30: WARNING !A || A && B is equivalent to !A || B. ./tools/testing/selftests/bpf/xdpxceiver.c:909:28-30: W

Re: [PATCH net 1/4] netfilter: xt_recent: Fix attempt to update deleted entry

2021-02-04 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Fri, 5 Feb 2021 01:17:24 +0100 you wrote: > From: Jozsef Kadlecsik > > When both --reap and --update flag are specified, there's a code > path at which the entry to be updated is reaped beforehand, > which then leads to k

Re: [PATCH net-next 00/15][pull request] 1GbE Intel Wired LAN Driver Updates 2021-02-03

2021-02-04 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Wed, 3 Feb 2021 16:42:44 -0800 you wrote: > This series contains updates to igc, igb, e1000e, and e1000 drivers. > > Sasha adds counting of good transmit packets and reporting of NVM version > and gPHY version in etht

Re: [PATCH net-next 7/7] net: marvell: prestera: fix port event handling on init

2021-02-04 Thread Jakub Kicinski
On Wed, 3 Feb 2021 18:54:58 +0200 Vadym Kochan wrote: > For some reason there might be a crash during ports creation if port > events are handling at the same time because fw may send initial > port event with down state. > > The crash points to cancel_delayed_work() which is called when port we

Re: [PATCH net-next 5/7] net: marvell: prestera: add LAG support

2021-02-04 Thread Jakub Kicinski
On Wed, 3 Feb 2021 18:54:56 +0200 Vadym Kochan wrote: > From: Serhiy Boiko > > The following features are supported: > > - LAG basic operations > - create/delete LAG > - add/remove a member to LAG > - enable/disable member in LAG > - LAG Bridge support > - LA

Re: [PATCH net-next 2/7] net: marvell: prestera: disable events interrupt while handling

2021-02-04 Thread Jakub Kicinski
On Wed, 3 Feb 2021 18:54:53 +0200 Vadym Kochan wrote: > There are change in firmware which requires that receiver will > disable event interrupts before handling them and enable them > after finish with handling. Events still may come into the queue > but without receiver interruption. Sounds lik

Re: [PATCH net-next v2 0/4] Fix W=1 compilation warnings in net/* folder

2021-02-04 Thread Jakub Kicinski
On Wed, 3 Feb 2021 15:51:08 +0200 Leon Romanovsky wrote: > From: Leon Romanovsky > > Changelog: > v2: > * Patch 3: Added missing include file. > v1: https://lore.kernel.org/lkml/20210203101612.4004322-1-l...@kernel.org > * Removed Fixes lines. > * Changed target from net to be net-next. > *

Re: [PATCH v2 net-next 2/4] net: dsa: automatically bring user ports down when master goes down

2021-02-04 Thread Jakub Kicinski
On Wed, 3 Feb 2021 18:08:21 +0200 Vladimir Oltean wrote: > From: Vladimir Oltean > > This is not fixing any actual bug that I know of, but having a DSA > interface that is up even when its lower (master) interface is down is > one of those things that just do not sound right. > > Yes, DSA check

Re: [PATCH V2 net-next 5/5] icmp: add response to RFC 8335 PROBE messages

2021-02-04 Thread Andreas Roeseler
On Thu, 2021-02-04 at 14:52 -0500, Willem de Bruijn wrote: > On Wed, Feb 3, 2021 at 6:30 PM Andreas Roeseler > wrote: > > > > Modify the icmp_rcv function to check for PROBE messages and call > > icmp_echo if a PROBE request is detected. > > > > Modify the existing icmp_echo function to respond

Re: [PATCH net-next 0/2] r8152: adjust flow for power cut

2021-02-04 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Wed, 3 Feb 2021 17:14:27 +0800 you wrote: > The two patches are used to adjust the flow about resuming from > the state of power cut. For the purpose, some functions have to > be updated first. > > Hayes Wang (2): >

Re: [PATCH net-next 0/2] Amend "hv_netvsc: Copy packets sent by Hyper-V out of the receive buffer"

2021-02-04 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Wed, 3 Feb 2021 12:35:11 +0100 you wrote: > Patch #2 also addresses the Smatch complaint reported here: > >https://lkml.kernel.org/r/YBp2oVIdMe+G%2FliJ@mwanda/ > > Thanks, > Andrea > > [...] Here is the summa

Re: [PATCH iproute2/net-next] tc: flower: Add support for ct_state reply flag

2021-02-04 Thread David Ahern
On 2/2/21 5:24 AM, Paul Blakey wrote: > Matches on conntrack rpl ct_state. > > Example: > $ tc filter add dev ens1f0_0 ingress prio 1 chain 1 proto ip flower \ > ct_state +trk+est+rpl \ > action mirred egress redirect dev ens1f0_1 > $ tc filter add dev ens1f0_1 ingress prio 1 chain 1 proto ip

Re: [PATCH iproute2-next v3] tc/htb: Hierarchical QoS hardware offload

2021-02-04 Thread David Ahern
On 2/4/21 7:51 AM, Maxim Mikityanskiy wrote: > This commit adds support for configuring HTB in offload mode. HTB > offload eliminates the single qdisc lock in the datapath and offloads > the algorithm to the NIC. The new 'offload' parameter is added to > enable this mode: > > # tc qdisc replac

Re: [PATCH ip-route2-next v2] ss: always prefer family as part of host condition to default family

2021-02-04 Thread David Ahern
On 2/1/21 8:32 PM, Thayne McCombs wrote: > I've fixed the indentation to use tabs instead of spaces. > > -- >8 -- > ss accepts an address family both with the -f option and as part of a > host condition. However, if the family in the host condition is > different than the the last -f option, then

Re: [PATCH net-next 2/7] net: ipa: synchronize NAPI only for suspend

2021-02-04 Thread Jakub Kicinski
On Wed, 3 Feb 2021 09:28:50 -0600 Alex Elder wrote: > int gsi_channel_suspend(struct gsi *gsi, u32 channel_id, bool stop) > { > struct gsi_channel *channel = &gsi->channel[channel_id]; > + int ret; > > - return __gsi_channel_stop(channel, stop); > + /* Synchronize NAPI if suc

Re: [PATCH net-next 1/7] net: ipa: restructure a few functions

2021-02-04 Thread Jakub Kicinski
On Wed, 3 Feb 2021 09:28:49 -0600 Alex Elder wrote: > Make __gsi_channel_start() and __gsi_channel_stop() more structurally > and semantically similar to each other: > - Restructure __gsi_channel_start() to always return at the end of > the function, similar to the way __gsi_channel_stop() d

Re: [net v4] selftests: txtimestamp: fix compilation issue

2021-02-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 4 Feb 2021 20:50:34 +0300 you wrote: > PACKET_TX_TIMESTAMP is defined in if_packet.h but it is not included in > test. Include it instead of otherwise the error of > redefinition arrives. > Also fix the compiler warnin

Re: [PATCH net] net: enetc: initialize the RFS and RSS memories

2021-02-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 4 Feb 2021 15:45:11 +0200 you wrote: > Michael tried to enable Advanced Error Reporting through the ENETC's > Root Complex Event Collector, and the system started spitting out single > bit correctable ECC errors coming

Re: [PATCH net] net: dsa: call teardown method on probe failure

2021-02-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 4 Feb 2021 18:33:51 +0200 you wrote: > Since teardown is supposed to undo the effects of the setup method, it > should be called in the error path for dsa_switch_setup, not just in > dsa_switch_teardown. > > Fixes: 5e3

Re: [PATCH iproute2-next V3] devlink: add support for port params get/set

2021-02-04 Thread David Ahern
Jiri/Parav: does this look ok to you?

Re: [PATCH V3] drivers: net: ethernet: i825xx: Fix couple of spellings in the file ether1.c

2021-02-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 4 Feb 2021 08:46:48 +0530 you wrote: > s/initialsation/initialisation/ > s/specifiing/specifying/ > > Signed-off-by: Bhaskar Chowdhury > --- > Changes from V2: >Adjust and make changes which are obvious as pe

Re: [PATCH RESEND net-next] net: dsa: bcm_sf2: Check egress tagging of CFP rule with proper accessor

2021-02-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 3 Feb 2021 21:39:18 +0200 you wrote: > The flow steering struct ethtool_flow_ext::data field is __be32, so when > the CFP code needs to check the VLAN egress tagging attribute in bit 0, > it does this in CPU native

Re: [PATCH net v2] net: ipa: set error code in gsi_channel_setup()

2021-02-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 3 Feb 2021 19:06:55 -0600 you wrote: > In gsi_channel_setup(), we check to see if the configuration data > contains any information about channels that are not supported by > the hardware. If one is found, we abort the

Re: [PATCH net] hv_netvsc: Reset the RSC count if NVSP_STAT_FAIL in netvsc_receive()

2021-02-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 3 Feb 2021 12:36:02 +0100 you wrote: > Commit 44144185951a0f ("hv_netvsc: Add validation for untrusted Hyper-V > values") added validation to rndis_filter_receive_data() (and > rndis_filter_receive()) which introduced N

Re: [PATCH net v2] udp: fix skb_copy_and_csum_datagram with odd segment sizes

2021-02-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 3 Feb 2021 14:29:52 -0500 you wrote: > From: Willem de Bruijn > > When iteratively computing a checksum with csum_block_add, track the > offset "pos" to correctly rotate in csum_block_add when offset is odd. > > The

Re: [PATCH v1] vdpa/mlx5: Restore the hardware used index after change map

2021-02-04 Thread Jason Wang
On 2021/2/4 下午3:36, Eli Cohen wrote: When a change of memory map occurs, the hardware resources are destroyed and then re-created again with the new memory map. In such case, we need to restore the hardware available and used indices. The driver failed to restore the used index which is added h

[PATCH] perf tools: Simplify the calculation of variables

2021-02-04 Thread Jiapeng Chong
Fix the following coccicheck warnings: ./tools/perf/util/header.c:3809:18-20: WARNING !A || A && B is equivalent to !A || B. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- tools/perf/util/header.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/he

Re: [PATCH iproute2-next v3 0/5] Add vdpa device management tool

2021-02-04 Thread Jason Wang
On 2021/2/4 下午7:15, Adrian Moreno wrote: Sorry I have not followed this work as close as I would have wanted. Some questions below. On 2/4/21 4:16 AM, Jason Wang wrote: On 2021/2/2 下午6:35, Parav Pandit wrote: Linux vdpa interface allows vdpa device management functionality. This includes add

答复: [PATCH net-next] net: core: Remove extra spaces

2021-02-04 Thread zhengyongjun
Thank you, I will do this code style cleanup in ` net/core/neighbour.c` to fix the worse style issues you said :) -邮件原件- 发件人: Jakub Kicinski [mailto:k...@kernel.org] 发送时间: 2021年2月5日 11:05 收件人: zhengyongjun 抄送: da...@davemloft.net; netdev@vger.kernel.org; linux-ker...@vger.kernel.org 主题:

Re: [PATCH net-next] net: dsa: xrs700x: Correctly address device over I2C

2021-02-04 Thread Jakub Kicinski
On Tue, 2 Feb 2021 14:05:20 -0600 George McCollister wrote: > On Tue, Feb 2, 2021 at 1:17 PM Tobias Waldekranz > wrote: > [snip] > > > > George, have you used the chip in I2C mode with the code that is on > > net-next now? I was not able to get the driver to even read the ID > > register correctl

Re: [PATCHv17 bpf-next 0/6] xdp: add a new helper for dev map multicast support

2021-02-04 Thread Hangbin Liu
Hi John, On Thu, Feb 04, 2021 at 09:03:23AM -0800, Jakub Kicinski wrote: > New patchwork can actually find messages by Message-ID header. > > Just slap message ID of one of the patches at the end of: > > https://patchwork.kernel.org/project/netdevbpf/patch/ > > And there is a link to entire seri

Re: [PATCH net-next] net: core: Remove extra spaces

2021-02-04 Thread Jakub Kicinski
On Thu, 4 Feb 2021 11:06:39 +0800 Zheng Yongjun wrote: > Do codingstyle clean up to remove extra spaces. > > Signed-off-by: Zheng Yongjun > --- > net/core/neighbour.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/core/neighbour.c b/net/core/neighbour.c > index 950

Re: [PATCH][next] net: hns3: remove redundant null check of an array

2021-02-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 3 Feb 2021 13:10:40 + you wrote: > From: Colin Ian King > > The null check of filp->f_path.dentry->d_iname is redundant because > it is an array of DNAME_INLINE_LEN chars and cannot be a null. Fix > this by r

Re: [PATCH] nfc: pn533: Fix typo issue

2021-02-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 3 Feb 2021 17:38:42 +0800 you wrote: > From: wengjianfeng > > change 'piority' to 'priority' > change 'succesfult' to 'successful' > > Signed-off-by: wengjianfeng > > [...] Here is the summary with links: -

Re: [PATCHv5 net-next 0/2] net: enable udp v6 sockets receiving v4 packets with UDP

2021-02-04 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Wed, 3 Feb 2021 16:54:21 +0800 you wrote: > Currently, udp v6 socket can not process v4 packets with UDP GRO, as > udp_encap_needed_key is not increased when udp_tunnel_encap_enable() > is called for v6 socket. > > Th

Re: [PATCH] net: hns3: avoid -Wpointer-bool-conversion warning

2021-02-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 4 Feb 2021 16:38:06 +0100 you wrote: > From: Arnd Bergmann > > clang points out a redundant sanity check: > > drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c:497:28: error: address of > array 'filp->f_path.d

Re: [PATCH net-next v3] net-loopback: set lo dev initial state to UP

2021-02-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Mon, 1 Feb 2021 15:34:45 -0800 you wrote: > From: Jian Yang > > Traditionally loopback devices come up with initial state as DOWN for > any new network-namespace. This would mean that anyone needing this > device woul

[PATCH v2] seccomp: Improve performace by optimizing rmb()

2021-02-04 Thread wanghongzhe
According to kees's suggest, we started with the patch that just replaces rmb() with smp_rmb() and did a performace test with UnixBench. The results showed the overhead about 2.53% in rmb() test compared to the smp_rmb() one, in a x86-64 kernel with CONFIG_SMP enabled running inside a qemu-kvm v

Re: [PATCH RESEND v3 net-next 0/5] net: consolidate page_is_pfmemalloc() usage

2021-02-04 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Tue, 02 Feb 2021 13:30:43 + you wrote: > page_is_pfmemalloc() is used mostly by networking drivers to test > if a page can be considered for reusing/recycling. > It doesn't write anything to the struct page itself,

Re: [PATCH net-next 1/2] net: add EXPORT_INDIRECT_CALLABLE wrapper

2021-02-04 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Thu, 4 Feb 2021 18:18:38 + you wrote: > When a static function is annotated with INDIRECT_CALLABLE_SCOPE and > CONFIG_RETPOLINE is set, the static keyword is removed. Sometimes the > function needs to be exported b

Re: [PATCH net-next v2] netlink: add tracepoint at NL_SET_ERR_MSG

2021-02-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 3 Feb 2021 22:48:16 -0300 you wrote: > From: Marcelo Ricardo Leitner > > Often userspace won't request the extack information, or they don't log it > because of log level or so, and even when they do, sometimes i

Re: [PATCH net] net: hdlc_x25: Return meaningful error code in x25_open

2021-02-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 2 Feb 2021 23:15:41 -0800 you wrote: > It's not meaningful to pass on LAPB error codes to HDLC code or other > parts of the system, because they will not understand the error codes. > > Instead, use system-wide recogni

Re: [PATCH net-next] cxgb4: Add new T6 PCI device id 0x6092

2021-02-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 2 Feb 2021 23:55:11 +0530 you wrote: > Signed-off-by: Raju Rangoju > --- > drivers/net/ethernet/chelsio/cxgb4/t4_pci_id_tbl.h | 1 + > 1 file changed, 1 insertion(+) Here is the summary with links: - [net-next] cxg

Re: [PATCH net] rxrpc: Fix clearance of Tx/Rx ring when releasing a call

2021-02-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 03 Feb 2021 08:47:56 + you wrote: > At the end of rxrpc_release_call(), rxrpc_cleanup_ring() is called to clear > the Rx/Tx skbuff ring, but this doesn't lock the ring whilst it's accessing > it. Unfortunately, rxrp

Re: [PATCH] xen/netback: avoid race in xenvif_rx_ring_slots_available()

2021-02-04 Thread Jakub Kicinski
On Thu, 4 Feb 2021 06:32:32 +0100 Jürgen Groß wrote: > On 04.02.21 00:48, Jakub Kicinski wrote: > > On Tue, 2 Feb 2021 08:09:38 +0100 Juergen Gross wrote: > >> Since commit 23025393dbeb3b8b3 ("xen/netback: use lateeoi irq binding") > >> xenvif_rx_ring_slots_available() is no longer called only f

Re: [PATCH bpf-next] bpf: clean up for 'const static' in bpf_lsm.c

2021-02-04 Thread Alexei Starovoitov
On Thu, Feb 4, 2021 at 5:40 PM Xu Jia wrote: > > Prefer 'static const' over 'const static' here > > Signed-off-by: Xu Jia > --- > kernel/bpf/bpf_lsm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/bpf/bpf_lsm.c b/kernel/bpf/bpf_lsm.c > index 1622a44d1617..75

[PATCH bpf-next] bpf: clean up for 'const static' in bpf_lsm.c

2021-02-04 Thread Xu Jia
Prefer 'static const' over 'const static' here Signed-off-by: Xu Jia --- kernel/bpf/bpf_lsm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/bpf/bpf_lsm.c b/kernel/bpf/bpf_lsm.c index 1622a44d1617..75b1c678d558 100644 --- a/kernel/bpf/bpf_lsm.c +++ b/kernel/bpf/bp

Re: [PATCH bpf-next 3/4] tools/resolve_btfids: Set srctree variable unconditionally

2021-02-04 Thread Andrii Nakryiko
On Thu, Feb 4, 2021 at 1:21 PM Jiri Olsa wrote: > > We want this clean to be called from tree's root Makefile, > which defines same srctree variable and that will screw > the make setup. > > We actually do not use srctree being passed from outside, > so we can solve this by setting current srctree

RE: [PATCH net-next 2/2] net: stmmac: slightly adjust the order of the codes in stmmac_resume()

2021-02-04 Thread Joakim Zhang
> -Original Message- > From: Willem de Bruijn > Sent: 2021年2月4日 21:20 > To: Joakim Zhang > Cc: Giuseppe Cavallaro ; Alexandre Torgue > ; Jose Abreu ; David > Miller ; Jakub Kicinski ; Network > Development ; Andrew Lunn ; > Florian Fainelli ; Willem de Bruijn > > Subject: Re: [PATCH net

Re: [PATCH net] net: enetc: initialize the RFS and RSS memories

2021-02-04 Thread Jesse Brandeburg
Vladimir Oltean wrote: > Discussion with the hardware design engineers reveals that on LS1028A, > the hardware does not do initialization of that RFS/RSS memory, and that > software should clear/initialize the entire table before starting to > operate. That comes as a bit of a surprise, since the d

Re: [PATCH net 1/1] net: stmmac: set TxQ mode back to DCB after disabling CBS

2021-02-04 Thread Jesse Brandeburg
Song Yoong Siang wrote: > From: Mohammad Athari Bin Ismail > > When disable CBS, mode_to_use parameter is not updated even the operation > mode of Tx Queue is changed to Data Centre Bridging (DCB). Therefore, > when tc_setup_cbs() function is called to re-enable CBS, the operation > mode of Tx Q

[PATCH ethtool] gitignore: Ignore .dirstamp

2021-02-04 Thread Florian Fainelli
Signed-off-by: Florian Fainelli --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index c4df588c37ea..0b7a71b58b7e 100644 --- a/.gitignore +++ b/.gitignore @@ -30,3 +30,4 @@ test-*.trs .*.swp *.patch +.dirstamp -- 2.25.1

[PATCH 3/3] net: fix iteration for sctp transport seq_files

2021-02-04 Thread NeilBrown
The sctp transport seq_file iterators take a reference to the transport in the ->start and ->next functions and releases the reference in the ->show function. The preferred handling for such resources is to release them in the subsequent ->next or ->stop function call. Since Commit 1f4aace60b0e (

[PATCH 0/3] Fix some seq_file users that were recently broken

2021-02-04 Thread NeilBrown
A recent change to seq_file broke some users which were using seq_file in a non-"standard" way ... though the "standard" isn't documented, so they can be excused. The result is a possible leak - of memory in one case, of references to a 'transport' in the other. These three patches: 1/ document

Re: [PATCH bpf-next 2/4] tools/resolve_btfids: Check objects before removing

2021-02-04 Thread Andrii Nakryiko
On Thu, Feb 4, 2021 at 1:20 PM Jiri Olsa wrote: > > We want this clean to be called from tree's root clean > and that one is silent if there's nothing to clean. > > Adding check for all object to clean and display CLEAN > messages only if there are objects to remove. > > Signed-off-by: Jiri Olsa

Re: [PATCH bpf-next 1/4] tools/resolve_btfids: Build libbpf and libsubcmd in separate directories

2021-02-04 Thread Andrii Nakryiko
On Thu, Feb 4, 2021 at 1:20 PM Jiri Olsa wrote: > > Setting up separate build directories for libbpf and libpsubcmd, > so it's separated from other objects and we don't get them mixed > in the future. > > It also simplifies cleaning, which is now simple rm -rf. > > Also there's no need for FEATURE

Re: [PATCHv4 net-next 0/2] net: enable udp v6 sockets receiving v4 packets with UDP GRO

2021-02-04 Thread David Howells
Xin Long wrote: > > If you could arrange for a random port to be assigned in such a case (and > > indicated back to the caller), that would be awesome. Possibly I just don't > > need to actually use bind in this case. > > > The patch is attached (based on this patch): Initial testing seems to s

[PATCH net 1/4] netfilter: xt_recent: Fix attempt to update deleted entry

2021-02-04 Thread Pablo Neira Ayuso
From: Jozsef Kadlecsik When both --reap and --update flag are specified, there's a code path at which the entry to be updated is reaped beforehand, which then leads to kernel crash. Reap only entries which won't be updated. Fixes kernel bugzilla #207773. Link: https://bugzilla.kernel.org/show_b

[PATCH net 2/4] selftests: netfilter: fix current year

2021-02-04 Thread Pablo Neira Ayuso
From: Fabian Frederick use date %Y instead of %G to read current year Problem appeared when running lkp-tests on 01/01/2021 Fixes: 48d072c4e8cd ("selftests: netfilter: add time counter check") Reported-by: kernel test robot Signed-off-by: Fabian Frederick Signed-off-by: Pablo Neira Ayuso ---

[PATCH net 3/4] netfilter: nftables: fix possible UAF over chains from packet path in netns

2021-02-04 Thread Pablo Neira Ayuso
Although hooks are released via call_rcu(), chain and rule objects are immediately released while packets are still walking over these bits. This patch adds the .pre_exit callback which is invoked before synchronize_rcu() in the netns framework to stay safe. Remove a comment which is not valid an

[PATCH net 0/4] Netfilter fixes for net

2021-02-04 Thread Pablo Neira Ayuso
Hi, The following patchset contains Netfilter fixes for net: 1) Fix combination of --reap and --update in xt_recent that triggers UAF, from Jozsef Kadlecsik. 2) Fix current year in nft_meta selftest, from Fabian Frederick. 3) Fix possible UAF in the netns destroy path of nftables. 4) Fix in

[PATCH net 4/4] netfilter: flowtable: fix tcp and udp header checksum update

2021-02-04 Thread Pablo Neira Ayuso
From: Sven Auhagen When updating the tcp or udp header checksum on port nat the function inet_proto_csum_replace2 with the last parameter pseudohdr as true. This leads to an error in the case that GRO is used and packets are split up in GSO. The tcp or udp checksum of all packets is incorrect. T

Re: [PATCH bpf-next V15 2/7] bpf: fix bpf_fib_lookup helper MTU check for SKB ctx

2021-02-04 Thread Daniel Borkmann
On 2/2/21 5:26 PM, Jesper Dangaard Brouer wrote: BPF end-user on Cilium slack-channel (Carlo Carraro) wants to use bpf_fib_lookup for doing MTU-check, but *prior* to extending packet size, by adjusting fib_params 'tot_len' with the packet length plus the expected encap size. (Just like the bpf_ch

Re: [net-next v2 2/2] tcp: Add receive timestamp support for receive zerocopy.

2021-02-04 Thread Jakub Kicinski
On Thu, 4 Feb 2021 15:03:40 -0800 Arjun Roy wrote: > But, if it's an IN or IN-OUT field, it seems like mandating that the > application set it to 0 could break the case where a future > application sets it to some non-zero value and runs on an older > kernel. That usually works fine in practice, 0

Re: [PATCH bpf-next 2/4] tools/resolve_btfids: Check objects before removing

2021-02-04 Thread Song Liu
> On Feb 4, 2021, at 1:18 PM, Jiri Olsa wrote: > > We want this clean to be called from tree's root clean > and that one is silent if there's nothing to clean. > > Adding check for all object to clean and display CLEAN > messages only if there are objects to remove. > > Signed-off-by: Jiri O

Re: [PATCH bpf-next] samples/bpf: Add hello world sample for newbies

2021-02-04 Thread Andrii Nakryiko
On Thu, Feb 4, 2021 at 11:27 AM Song Liu wrote: > > On Thu, Feb 4, 2021 at 3:42 AM Tiezhu Yang wrote: > > > > The program is made in a way that everytime an execve syscall > > is executed it prints Hello, BPF World! > > > > This is inspired and based on the code example for the book > > Linux Obs

Re: [PATCH bpf-next 4/4] kbuild: Add resolve_btfids clean to root clean target

2021-02-04 Thread Song Liu
> On Feb 4, 2021, at 1:18 PM, Jiri Olsa wrote: > > The resolve_btfids tool is used during the kernel build, > so we should clean it on kernel's make clean. > > Invoking the the resolve_btfids clean as part of root > 'make clean'. > > Signed-off-by: Jiri Olsa Acked-by: Song Liu > --- > Ma

Re: [PATCH bpf-next 3/4] tools/resolve_btfids: Set srctree variable unconditionally

2021-02-04 Thread Song Liu
> On Feb 4, 2021, at 1:18 PM, Jiri Olsa wrote: > > We want this clean to be called from tree's root Makefile, > which defines same srctree variable and that will screw > the make setup. > > We actually do not use srctree being passed from outside, > so we can solve this by setting current src

Re: [PATCH bpf-next 1/4] tools/resolve_btfids: Build libbpf and libsubcmd in separate directories

2021-02-04 Thread Song Liu
> On Feb 4, 2021, at 1:18 PM, Jiri Olsa wrote: > > Setting up separate build directories for libbpf and libpsubcmd, > so it's separated from other objects and we don't get them mixed > in the future. > > It also simplifies cleaning, which is now simple rm -rf. > > Also there's no need for FE

[PATCH net-next 2/2] mptcp: pm: add lockdep assertions

2021-02-04 Thread Mat Martineau
From: Florian Westphal Add a few assertions to make sure functions are called with the needed locks held. Two functions gain might_sleep annotations because they contain conditional calls to functions that sleep. Signed-off-by: Florian Westphal Signed-off-by: Mat Martineau --- net/mptcp/pm.c

[PATCH net-next 1/2] selftests: mptcp: add command line arguments for mptcp_join.sh

2021-02-04 Thread Mat Martineau
From: Geliang Tang Since the mptcp_join script is becoming too big, this patch splits it into several smaller chunks, each of them has been defined in a function as a individual test group for several related testcases. Using bash getopts function to parse command line arguments, and invoke each

[PATCH net-next 0/2] mptcp: Misc. updates for tests & lock annotation

2021-02-04 Thread Mat Martineau
Here are two fixes we've collected in the mptcp tree. Patch 1 refactors a MPTCP selftest script to allow running a subset of the tests. Patch 2 adds some locking & might_sleep assertations. Florian Westphal (1): mptcp: pm: add lockdep assertions Geliang Tang (1): selftests: mptcp: add comm

Re: [PATCH] staging: qlge/qlge_main: Use min_t instead of min

2021-02-04 Thread Nathan Chancellor
On Fri, Feb 05, 2021 at 03:24:51AM +0530, ameynarkhed...@gmail.com wrote: > From: Amey Narkhede > > Use min_t instead of min function in qlge/qlge_main.c > Fixes following checkpatch.pl warning: > WARNING: min() should probably be min_t(int, MAX_CPUS, num_online_cpus()) > > Signed-off-by: Amey N

Re: [PATCH] net/vmw_vsock: fix NULL pointer deref and improve locking

2021-02-04 Thread Norbert Slusarek
> We request Fixes: tag for patches targeting net tree. > > You could also mention the vsock_connect_timeout() > issue was found by a reviewer and give some credits ;) You're right, Eric Dumazet spotted the locking problem in vsock_cancel_timeout(). I am not too familiar how I should format my re

Re: [PATCH net-next v10 3/3] net: add sysfs attribute to control napi threaded mode

2021-02-04 Thread Alexander Duyck
On Thu, Feb 4, 2021 at 1:35 PM Wei Wang wrote: > > This patch adds a new sysfs attribute to the network device class. > Said attribute provides a per-device control to enable/disable the > threaded mode for all the napi instances of the given network device, > without the need for a device up/down

  1   2   3   4   >