Re: [PATCH net 1/1] netfilter: conntrack: Check offload bit on table dump

2021-01-31 Thread Roi Dayan
On 2021-02-01 5:08 AM, Pablo Neira Ayuso wrote: Hi Roi, On Sun, Jan 31, 2021 at 03:18:34PM +0200, Roi Dayan wrote: [...] Hi Pablo, We did more tests with just updating the timeout in the 2 callers and it's not enough. We reproduce the issue of rules being timed out just now frim different p

Re: [PATCH 2/2] vdpa/mlx5: Restore the hardware used index after change map

2021-01-31 Thread Jason Wang
On 2021/2/1 下午2:38, Eli Cohen wrote: On Mon, Feb 01, 2021 at 02:00:35PM +0800, Jason Wang wrote: On 2021/2/1 下午1:52, Eli Cohen wrote: On Mon, Feb 01, 2021 at 11:36:23AM +0800, Jason Wang wrote: On 2021/2/1 上午2:55, Eli Cohen wrote: On Fri, Jan 29, 2021 at 11:49:45AM +0800, Jason Wang wrote:

[PATCH] mwifiex: Report connected BSS with cfg80211_connect_bss()

2021-01-31 Thread Yen-lin Lai
When a network is moved or reconfigured on the different channel, there can be multiple BSSes with the same BSSID and SSID in scan result before the old one expires. Then, it can cause cfg80211_connect_result to map current_bss to a bss with the wrong channel. Let mwifiex_cfg80211_assoc return the

linux-next: build warning after merge of the net-next tree

2021-01-31 Thread Stephen Rothwell
Hi all, After merging the net-next tree, today's linux-next build (htmldocs) produced this warning: Documentation/networking/device_drivers/ethernet/mellanox/mlx5.rst:16: WARNING: Unknown target name: "mlx5 port function". Introduced by commit 142d93d12dc1 ("net/mlx5: Add devlink subfunction

[Patch v3 net-next 4/7] octeontx2-af: Physical link configuration support

2021-01-31 Thread Hariprasad Kelam
From: Christina Jacob CGX LMAC, the physical interface support link configuration parameters like speed, auto negotiation, duplex etc. Firmware saves these into memory region shared between firmware and this driver. This patch adds mailbox handler set_link_mode, fw_data_get to configure and rea

Re: [PATCH 2/2] vdpa/mlx5: Restore the hardware used index after change map

2021-01-31 Thread Eli Cohen
On Mon, Feb 01, 2021 at 02:00:35PM +0800, Jason Wang wrote: > > On 2021/2/1 下午1:52, Eli Cohen wrote: > > On Mon, Feb 01, 2021 at 11:36:23AM +0800, Jason Wang wrote: > > > On 2021/2/1 上午2:55, Eli Cohen wrote: > > > > On Fri, Jan 29, 2021 at 11:49:45AM +0800, Jason Wang wrote: > > > > > On 2021/1/28

[Patch v3 net-next 2/7] octeontx2-af: Add new CGX_CMD to get PHY FEC statistics

2021-01-31 Thread Hariprasad Kelam
From: Felix Manlunas This patch adds support to fetch fec stats from PHY. The stats are put in the shared data struct fwdata. A PHY driver indicates that it has FEC stats by setting the flag fwdata.phy.misc.has_fec_stats Besides CGX_CMD_GET_PHY_FEC_STATS, also add CGX_CMD_PRBS and CGX_CMD_DISPL

[Patch v3 net-next 5/7] octeontx2-af: advertised link modes support on cgx

2021-01-31 Thread Hariprasad Kelam
From: Christina Jacob CGX supports setting advertised link modes on physical link. This patch adds support to derive cgx mode from ethtool link mode and pass it to firmware to configure the same. Signed-off-by: Christina Jacob Signed-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam ---

[Patch v3 net-next 0/7] ethtool support for fec and link configuration

2021-01-31 Thread Hariprasad Kelam
This series of patches add support for forward error correction(fec) and physical link configuration. Patches 1&2 adds necessary mbox handlers for fec mode configuration request and to fetch stats. Patch 3 registers driver callbacks for fec mode configuration and display. Patch 4&5 adds support of

[Patch v3 net-next 1/7] octeontx2-af: forward error correction configuration

2021-01-31 Thread Hariprasad Kelam
From: Christina Jacob CGX block supports forward error correction modes baseR and RS. This patch adds support to set encoding mode and to read corrected/uncorrected block counters Adds new mailbox handlers set_fec to configure encoding modes and fec_stats to read counters and also increase mbox

Re: [RFC net-next 7/7] net: dsa: mv88e6xxx: Request assisted learning on CPU port

2021-01-31 Thread DENG Qingfang
Hi Tobias, I've tested your patch series on kernel 5.4 and found that it only works when VLAN filtering is enabled. After some debugging, I noticed DSA will add static entries to ATU 0 if VLAN filtering is disabled, regardless of default_pvid of the bridge, which is also the ATU# used by the bridg

Re: [RFC PATCH bpf-next] bpf, xdp: per-map bpf_redirect_map functions for XDP

2021-01-31 Thread Björn Töpel
On 2021-01-29 17:45, Toke Høiland-Jørgensen wrote: Björn Töpel writes: From: Björn Töpel Currently the bpf_redirect_map() implementation dispatches to the correct map-lookup function via a switch-statement. To avoid the dispatching, this change adds one bpf_redirect_map() implementation per

Re: [PATCH 07/22] RDMA/irdma: Register an auxiliary driver and implement private channel OPs

2021-01-31 Thread Leon Romanovsky
On Sat, Jan 30, 2021 at 01:19:36AM +, Saleem, Shiraz wrote: > > Subject: Re: [PATCH 07/22] RDMA/irdma: Register an auxiliary driver and > > implement private channel OPs > > > > On Wed, Jan 27, 2021 at 07:16:41PM -0400, Jason Gunthorpe wrote: > > > On Wed, Jan 27, 2021 at 10:17:56PM +, Sale

Re: [PATCH 2/2] vdpa/mlx5: Restore the hardware used index after change map

2021-01-31 Thread Jason Wang
On 2021/2/1 下午1:52, Eli Cohen wrote: On Mon, Feb 01, 2021 at 11:36:23AM +0800, Jason Wang wrote: On 2021/2/1 上午2:55, Eli Cohen wrote: On Fri, Jan 29, 2021 at 11:49:45AM +0800, Jason Wang wrote: On 2021/1/28 下午9:41, Eli Cohen wrote: When a change of memory map occurs, the hardware resources

[PATCH net] net: lapb: Copy the skb before sending a packet

2021-01-31 Thread Xie He
When sending a packet, we will prepend it with an LAPB header. This modifies the shared parts of a cloned skb, so we should copy the skb rather than just clone it, before we prepend the header. In "Documentation/networking/driver.rst" (the 2nd point), it states that drivers shouldn't modify the sh

Re: [PATCH 2/2] vdpa/mlx5: Restore the hardware used index after change map

2021-01-31 Thread Eli Cohen
On Mon, Feb 01, 2021 at 11:36:23AM +0800, Jason Wang wrote: > > On 2021/2/1 上午2:55, Eli Cohen wrote: > > On Fri, Jan 29, 2021 at 11:49:45AM +0800, Jason Wang wrote: > > > On 2021/1/28 下午9:41, Eli Cohen wrote: > > > > When a change of memory map occurs, the hardware resources are destroyed > > > >

[Patch v3 net-next 3/7] octeontx2-pf: ethtool fec mode support

2021-01-31 Thread Hariprasad Kelam
From: Christina Jacob Add ethtool support to configure fec modes baser/rs and support to fecth FEC stats from CGX as well PHY. Configure fec mode - ethtool --set-fec eth0 encoding rs/baser/off/auto Query fec mode - ethtool --show-fec eth0 Signed-off-by: Christina Jacob Signed-o

[Patch v3 net-next 6/7] octeontx2-pf: ethtool physical link status

2021-01-31 Thread Hariprasad Kelam
From: Christina Jacob Register get_link_ksettings callback to get link status information from the driver. As virtual function (vf) shares same physical link same API is used for both the drivers and for loop back drivers simply returns the fixed values as its does not have physical link. ethtoo

[Patch v3 net-next 7/7] octeontx2-pf: ethtool physical link configuration

2021-01-31 Thread Hariprasad Kelam
From: Christina Jacob Register set_link_ksetting callback with driver such that link configurations parameters like advertised mode,speed, duplex and autoneg can be configured. below command ethtool -s eth0 advertise 0x1 speed 10 duplex full autoneg on Signed-off-by: Christina Jacob Signed-off

WARNING in sta_info_insert_check

2021-01-31 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:bec4c296 Merge tag 'ecryptfs-5.11-rc6-setxattr-fix' of git.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=11991778d0 kernel config: https://syzkaller.appspot.com/x/.config?x=f75d66d6d359ef2f das

Re: [PATCH 2/2] vdpa/mlx5: Restore the hardware used index after change map

2021-01-31 Thread Jason Wang
On 2021/2/1 上午2:55, Eli Cohen wrote: On Fri, Jan 29, 2021 at 11:49:45AM +0800, Jason Wang wrote: On 2021/1/28 下午9:41, Eli Cohen wrote: When a change of memory map occurs, the hardware resources are destroyed and then re-created again with the new memory map. In such case, we need to restore t

Re: [PATCH net 1/1] netfilter: conntrack: Check offload bit on table dump

2021-01-31 Thread Pablo Neira Ayuso
Hi Roi, On Sun, Jan 31, 2021 at 03:18:34PM +0200, Roi Dayan wrote: [...] > Hi Pablo, > > We did more tests with just updating the timeout in the 2 callers > and it's not enough. We reproduce the issue of rules being timed > out just now frim different place. Thanks for giving it a try to my sugg

[PATCH net-next v6] net: psample: Introduce stubs to remove NIC driver dependency

2021-01-31 Thread Chris Mi
In order to send sampled packets to userspace, NIC driver calls psample api directly. But it creates a hard dependency on module psample. Introduce psample_ops to remove the hard dependency. It is initialized when psample module is loaded and set to NULL when the module is unloaded. Reported-by: k

Re: [PATCH net-next v5] net: psample: Introduce stubs to remove NIC driver dependency

2021-01-31 Thread Chris Mi
On 1/30/2021 10:52 PM, Ido Schimmel wrote: On Sat, Jan 30, 2021 at 10:33:19AM +0800, Chris Mi wrote: In order to send sampled packets to userspace, NIC driver calls psample api directly. But it creates a hard dependency on module psample. Introduce psample_ops to remove the hard dependency. It i

Re: [patch net-next RFC 00/10] introduce line card support for modular switch

2021-01-31 Thread Andrew Lunn
> Platform line card driver is aware of line card I2C topology, its > responsibility is to detect line card basic hardware type, create I2C > topology (mux), connect all the necessary I2C devices, like hotswap > devices, voltage and power regulators devices, iio/a2d devices and line > card EEPROMs,

Re: [PATCH net-next v4] net: psample: Introduce stubs to remove NIC driver dependency

2021-01-31 Thread Chris Mi
Hi Ido, On 1/30/2021 10:42 PM, Ido Schimmel wrote: On Fri, Jan 29, 2021 at 12:30:09PM -0800, Jakub Kicinski wrote: On Fri, 29 Jan 2021 14:08:39 +0800 Chris Mi wrote: Instead of discussing it several days, maybe it's better to review current patch, so that we can move forward :) It took you 4

Re: [PATCH net-next 9/9] net: ipa: don't disable NAPI in suspend

2021-01-31 Thread Willem de Bruijn
On Sun, Jan 31, 2021 at 10:32 AM Alex Elder wrote: > > On 1/31/21 8:52 AM, Willem de Bruijn wrote: > > On Sat, Jan 30, 2021 at 11:29 PM Alex Elder wrote: > >> > >> On 1/30/21 9:25 AM, Willem de Bruijn wrote: > >>> On Fri, Jan 29, 2021 at 3:29 PM Alex Elder wrote: > > The channel stop a

Re: [PATCH net-next v5] net: psample: Introduce stubs to remove NIC driver dependency

2021-01-31 Thread Chris Mi
On 1/30/2021 2:59 PM, Jakub Kicinski wrote: On Sat, 30 Jan 2021 10:33:19 +0800 Chris Mi wrote: +// SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB +/* Copyright (c) 2021 Mellanox Technologies. */ + +const struct psample_ops __rcu *psample_ops __read_mostly; +EXPORT_SYMBOL_GPL(psample_ops); Ple

[no subject]

2021-01-31 Thread Gopal Raman
Hi Aquantia PHY experts This is a very specific question about programming the MACSEC component of the Aquantia PHY (specifically AQR114C). I'm using the C API ( AQ_API_3_0_4_AQRATE) provided by Aquantia to read/write the registers over MDIO and have compiled it into a kernel module. I'm running on

Re: [PATCH v3 bpf-next 1/4] bpf: enable task local storage for tracing programs

2021-01-31 Thread KP Singh
On Thu, Jan 28, 2021 at 1:20 AM Song Liu wrote: > > To access per-task data, BPF programs usually creates a hash table with > pid as the key. This is not ideal because: > 1. The user need to estimate the proper size of the hash table, which may > be inaccurate; > 2. Big hash tables are slow;

Re: [Patch v3 net-next 0/7] ethtool support for fec and link configuration

2021-01-31 Thread Willem de Bruijn
On Sun, Jan 31, 2021 at 8:11 AM Hariprasad Kelam wrote: > > This series of patches add support for forward error correction(fec) and > physical link configuration. Patches 1&2 adds necessary mbox handlers for fec > mode configuration request and to fetch stats. Patch 3 registers driver > callbacks

Re: [net-next 00/14] Add Marvell CN10K support

2021-01-31 Thread Willem de Bruijn
On Sat, Jan 30, 2021 at 12:04 PM Geetha sowjanya wrote: > > The current admin function (AF) driver and the netdev driver supports > OcteonTx2 silicon variants. The same OcteonTx2's Resource Virtualization Unit > (RVU) > is carried forward to the next-gen silicon ie OcteonTx3, with some changes >

Re: [PATCH net] igb: Enable RSS for Intel I211 Ethernet Controller

2021-01-31 Thread Matt Corallo
Given this fixes a major (albeit ancient) performance regression, is it not a candidate for backport? It landed on Tony's dev-queue branch with a Fixes tag but no stable CC. Thanks, Matt On 12/21/20 5:25 PM, Nick Lowe wrote: The Intel I211 Ethernet Controller supports 2 Receive Side Scaling (R

Re: [PATCH net] net: dsa: mv88e6xxx: override existent unicast portvec in port_fdb_add

2021-01-31 Thread Vladimir Oltean
On Sun, Jan 31, 2021 at 09:13:15AM +0800, DENG Qingfang wrote: > This bug is exposed when I try your patch series on kernel 5.4 > https://lore.kernel.org/netdev/20210106095136.224739-1-olte...@gmail.com/ > https://lore.kernel.org/netdev/20210116012515.3152-1-tob...@waldekranz.com/ > > Without this

Re: [PATCH net-next 1/2] net: dsa: hellcreek: Report VLAN table occupancy

2021-01-31 Thread Florian Fainelli
On 1/30/2021 5:59 AM, Kurt Kanzenbach wrote: > The VLAN membership configuration is cached in software already. So, it can be > reported via devlink. Add support for it: > > |root@tsn:~# devlink resource show platform/ff24.switch > |platform/ff24.switch: > | name VLAN size 4096 occ 4 u

Re: [PATCH net-next 2/2] net: dsa: hellcreek: Report FDB table occupancy

2021-01-31 Thread Florian Fainelli
On 1/30/2021 5:59 AM, Kurt Kanzenbach wrote: > Report the FDB table size and occupancy via devlink. The actual size depends > on > the used Hellcreek version: > > |root@tsn:~# devlink resource show platform/ff24.switch > |platform/ff24.switch: > | name VLAN size 4096 occ 2 unit entry

Re: [PATCH net-next 0/2] net: dsa: hellcreek: Report tables sizes

2021-01-31 Thread Vladimir Oltean
On Sat, Jan 30, 2021 at 02:59:32PM +0100, Kurt Kanzenbach wrote: > Florian, Andrew and Vladimir suggested at some point to use devlink for > reporting tables, features and debugging counters instead of using debugfs and > printk. > > So, start by reporting the VLAN and FDB table sizes. I don't re

Re: [Patch bpf-next v5 1/3] bpf: introduce timeout hash map

2021-01-31 Thread Jamal Hadi Salim
On 2021-01-29 10:14 p.m., Alexei Starovoitov wrote: On Fri, Jan 29, 2021 at 6:14 AM Jamal Hadi Salim wrote: On 2021-01-29 9:06 a.m., Jamal Hadi Salim wrote: Which leads to: Why not extend the general feature so one can register for optional callbacks not just for expire but also add/del/upda

Re: [PATCH 2/2] vdpa/mlx5: Restore the hardware used index after change map

2021-01-31 Thread Eli Cohen
On Fri, Jan 29, 2021 at 11:49:45AM +0800, Jason Wang wrote: > > On 2021/1/28 下午9:41, Eli Cohen wrote: > > When a change of memory map occurs, the hardware resources are destroyed > > and then re-created again with the new memory map. In such case, we need > > to restore the hardware available and

Re: [PATCH iproute2-next 5/5] devlink: Support set of port function state

2021-01-31 Thread David Ahern
On 1/29/21 9:56 AM, Parav Pandit wrote: > @@ -1420,6 +1423,22 @@ static int port_flavour_parse(const char *flavour, > uint16_t *value) > } > } > > +static int port_function_state_parse(const char *statestr, uint8_t *state) > +{ > + if (!statestr) > + return -EINVAL; > + >

Re: [PATCH iproute2-next 3/5] devlink: Supporting add and delete of devlink port

2021-01-31 Thread David Ahern
On 1/29/21 9:56 AM, Parav Pandit wrote: > @@ -1383,6 +1389,37 @@ static int reload_limit_get(struct dl *dl, const char > *limitstr, > return 0; > } > > +static int port_flavour_parse(const char *flavour, uint16_t *value) > +{ > + if (!flavour) > + return -EINVAL; > + > +

Re: [PATCH] NET: SRv6: seg6_local: Fixed SRH processing when segments left is 0

2021-01-31 Thread David Ahern
[ cc David Lebrun, author of the original code ] On 1/31/21 6:08 AM, Suprit Japagal wrote: > From: "Suprit.Japagal" > > According to the standard IETF RFC 8754, section 4.3.1.1 > (https://tools.ietf.org/html/rfc8754#section-4.3.1.1) > When the segments left in SRH equals to 0, proceed to process

Re: [PATCH 1/1] vsock: fix the race conditions in multi-transport support

2021-01-31 Thread Linus Torvalds
[ I'm checking lkml for at least some of the emails that I'm cc'd on ] On Sun, Jan 31, 2021 at 2:59 AM Alexander Popov wrote: > > There are multiple similar bugs implicitly introduced by the > commit [...] Note: this got eaten or delayed by the mailing list issues that seem to be plaguing lkml -

Re: [PATCH net-next v3 2/7] ethtool: Get link mode in use instead of speed and duplex parameters

2021-01-31 Thread Edwin Peer
On Sun, Jan 31, 2021 at 7:33 AM Danielle Ratson wrote: > Edwin, adding the a new parameter requires a new patchset in my opinion. > Implementing the symmetrical side of the link_mode get, however can be a > part of this set. But, the problem with that would be that, as Michal said, > speed lanes

Re: [PATCH v6 bpf-next 0/8] mvneta: introduce XDP multi-buffer support

2021-01-31 Thread Lorenzo Bianconi
> Hi Lorenzo, Hi Daniel, sorry for the delay. > > On 1/19/21 9:20 PM, Lorenzo Bianconi wrote: > > This series introduce XDP multi-buffer support. The mvneta driver is > > the first to support these new "non-linear" xdp_{buff,frame}. Reviewers > > please focus on how these new types of xdp_{buff

Re: [PATCH v2 net-next 02/21] net: Introduce direct data placement tcp offload

2021-01-31 Thread Boris Pismenny
On 14/01/2021 22:43, Eric Dumazet wrote: > On Thu, Jan 14, 2021 at 9:19 PM Boris Pismenny > wrote: >> >> >> >> On 14/01/2021 17:57, Eric Dumazet wrote: >>> On Thu, Jan 14, 2021 at 4:10 PM Boris Pismenny wrote: This commit introduces direct data placement offload for TCP. This c

RE: [EXT] Re: Phylink flow control support on ports with MLO_AN_FIXED auto negotiation

2021-01-31 Thread Stefan Chulski
> > Hi, > > > > Armada has options for 1G/10G ports without PHY's(for example > community board Macchiato single shot). > > This port doesn't have PHY's and cannot negotiate Flow Control support, > but we can for example connect two ports without PHY's and manually(by > ethtool) configure FC. >

[PATCH v3 net-next 4/5] net: use the new dev_page_is_reusable() instead of private versions

2021-01-31 Thread Alexander Lobakin
Now we can remove a bunch of identical functions from the drivers and make them use common dev_page_is_reusable(). All {,un}likely() checks are omitted since it's already present in this helper. Also update some comments near the call sites. Suggested-by: David Rientjes Suggested-by: Jakub Kicins

Re: [PATCH v3 net-next 5/5] net: page_pool: simplify page recycling condition tests

2021-01-31 Thread Matthew Wilcox
On Sun, Jan 31, 2021 at 12:12:11PM +, Alexander Lobakin wrote: > pool_page_reusable() is a leftover from pre-NUMA-aware times. For now, > this function is just a redundant wrapper over page_is_pfmemalloc(), > so inline it into its sole call site. Why doesn't this want to use {dev_}page_is_reus

Re: [PATCH v3 net-next 3/5] net: introduce common dev_page_is_reusable()

2021-01-31 Thread Alexander Lobakin
From: Matthew Wilcox Date: Sun, 31 Jan 2021 12:22:05 + > On Sun, Jan 31, 2021 at 12:11:52PM +, Alexander Lobakin wrote: > > A bunch of drivers test the page before reusing/recycling for two > > common conditions: > > - if a page was allocated under memory pressure (pfmemalloc page); > >

RE: [PATCH net-next v3 2/7] ethtool: Get link mode in use instead of speed and duplex parameters

2021-01-31 Thread Danielle Ratson
> -Original Message- > From: Michal Kubecek > Sent: Thursday, January 28, 2021 10:27 PM > To: Danielle Ratson > Cc: Edwin Peer ; netdev ; > David S . Miller ; Jakub > Kicinski ; Jiri Pirko ; Andrew Lunn > ; f.faine...@gmail.com; mlxsw > ; Ido Schimmel > Subject: Re: [PATCH net-next

Re: [PATCH net-next 9/9] net: ipa: don't disable NAPI in suspend

2021-01-31 Thread Alex Elder
On 1/31/21 8:52 AM, Willem de Bruijn wrote: > On Sat, Jan 30, 2021 at 11:29 PM Alex Elder wrote: >> >> On 1/30/21 9:25 AM, Willem de Bruijn wrote: >>> On Fri, Jan 29, 2021 at 3:29 PM Alex Elder wrote: The channel stop and suspend paths both call __gsi_channel_stop(), which quiesces

Re: [PATCH net-next v1 2/6] lan743x: support rx multi-buffer packets

2021-01-31 Thread Sven Van Asbroeck
On Sun, Jan 31, 2021 at 2:06 AM wrote: > > > static int lan743x_rx_process_packet(struct lan743x_rx *rx) { > It looks like this function no longer processes a packet, but rather only > processes a single buffer. > So perhaps it should be renamed to lan743x_rx_process_buffer, so it is not > mis

[Patch v3 net-next 0/7] ethtool support for fec and link configuration

2021-01-31 Thread Hariprasad Kelam
This series of patches add support for forward error correction(fec) and physical link configuration. Patches 1&2 adds necessary mbox handlers for fec mode configuration request and to fetch stats. Patch 3 registers driver callbacks for fec mode configuration and display. Patch 4&5 adds support of

Re: [PATCH v3 bpf-next] net: veth: alloc skb in bulk for ndo_xdp_xmit

2021-01-31 Thread Toshiaki Makita
On 2021/01/30 7:04, Lorenzo Bianconi wrote: Split ndo_xdp_xmit and ndo_start_xmit use cases in veth_xdp_rcv routine in order to alloc skbs in bulk for XDP_PASS verdict. Introduce xdp_alloc_skb_bulk utility routine to alloc skb bulk list. The proposed approach has been tested in the following scen

[Patch v3 net-next 6/7] octeontx2-pf: ethtool physical link status

2021-01-31 Thread Hariprasad Kelam
From: Christina Jacob Register get_link_ksettings callback to get link status information from the driver. As virtual function (vf) shares same physical link same API is used for both the drivers and for loop back drivers simply returns the fixed values as its does not have physical link. ethtoo

[PATCH v7 net-next 02/15] dts: marvell: add CM3 SRAM memory to cp115 ethernet device tree

2021-01-31 Thread stefanc
From: Konstantin Porotchkin CM3 SRAM address space would be used for Flow Control configuration. Signed-off-by: Stefan Chulski Signed-off-by: Konstantin Porotchkin --- arch/arm64/boot/dts/marvell/armada-cp11x.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot

[PATCH v7 net-next 11/15] net: mvpp2: add ethtool flow control configuration support

2021-01-31 Thread stefanc
From: Stefan Chulski This patch add ethtool flow control configuration support. Tx flow control retrieved correctly by ethtool get function. FW per port ethtool configuration capability added. Patch also takes care about mtu change procedure, if PPv2 switch BM pools during mtu change. Signed-o

[PATCH v7 net-next 10/15] net: mvpp2: add RXQ flow control configurations

2021-01-31 Thread stefanc
From: Stefan Chulski This patch adds RXQ flow control configurations. Flow control disabled by default. Minimum ring size limited to 1024 descriptors. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 35 +- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c

RE: [EXT] Re: [PATCH v5 net-next 00/18] net: mvpp2: Add TX Flow Control support

2021-01-31 Thread Stefan Chulski
> > Ok, kernel.org has now dropped spamcop.net, so email should flow normally > now. > > Are you sure all your emails are being received by vger.kernel.org? No, I get Undeliverable Email response. I probably would wait till tomorrow and repost them again as v8. Regards, Stefan.

Re: [EXT] Re: [PATCH v5 net-next 00/18] net: mvpp2: Add TX Flow Control support

2021-01-31 Thread Russell King - ARM Linux admin
On Sun, Jan 31, 2021 at 02:45:24PM +, Russell King - ARM Linux admin wrote: > On Sun, Jan 31, 2021 at 02:23:20PM +, Stefan Chulski wrote: > > I still don't see all patches in > > https://patchwork.kernel.org/project/netdevbpf/list/?series=424949 > > I would reduce patch series to 15 patche

Re: [EXT] Re: [PATCH v5 net-next 00/18] net: mvpp2: Add TX Flow Control support

2021-01-31 Thread Russell King - ARM Linux admin
On Sun, Jan 31, 2021 at 02:23:20PM +, Stefan Chulski wrote: > I still don't see all patches in > https://patchwork.kernel.org/project/netdevbpf/list/?series=424949 > I would reduce patch series to 15 patches and repost again. kernel.org email is currently broken for everyone due to the spamco

Re: [PATCH net-next 9/9] net: ipa: don't disable NAPI in suspend

2021-01-31 Thread Willem de Bruijn
On Sat, Jan 30, 2021 at 11:29 PM Alex Elder wrote: > > On 1/30/21 9:25 AM, Willem de Bruijn wrote: > > On Fri, Jan 29, 2021 at 3:29 PM Alex Elder wrote: > >> > >> The channel stop and suspend paths both call __gsi_channel_stop(), > >> which quiesces channel activity, disables NAPI, and (on other

[PATCH v7 net-next 15/15] net: mvpp2: add TX FC firmware check

2021-01-31 Thread stefanc
From: Stefan Chulski Patch check that TX FC firmware is running in CM3. If not, global TX FC would be disabled. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 1 + drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 42 2 files changed,

[PATCH v7 net-next 12/15] net: mvpp2: add BM protection underrun feature support

2021-01-31 Thread stefanc
From: Stefan Chulski Feature double size of BPPI by decreasing number of pools from 16 to 8. Increasing of BPPI size protect BM drop from BPPI underrun. Underrun could occurred due to stress on DDR and as result slow buffer transition from BPPE to BPPI. New BPPI threshold recommended by spec is:

[PATCH v7 net-next 13/15] net: mvpp2: add PPv23 RX FIFO flow control

2021-01-31 Thread stefanc
From: Stefan Chulski New FIFO flow control feature were added in PPv23. PPv2 FIFO polled by HW and trigger pause frame if FIFO fill level is below threshold. FIFO HW flow control enabled with CM3 RXQ&BM flow control with ethtool. Current FIFO thresholds is: 9KB for port with maximum speed 10Gb/s

[PATCH v7 net-next 14/15] net: mvpp2: set 802.3x GoP Flow Control mode

2021-01-31 Thread stefanc
From: Stefan Chulski This patch fix GMAC TX flow control autoneg. Flow control autoneg wrongly were disabled with enabled TX flow control. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[PATCH v7 net-next 06/15] net: mvpp2: increase BM pool and RXQ size

2021-01-31 Thread stefanc
From: Stefan Chulski BM pool and RXQ size increased to support Firmware Flow Control. Minimum depletion thresholds to support FC are 1024 buffers. BM pool size increased to 2048 to have some 1024 buffers space between depletion thresholds and BM pool size. Jumbo frames require a 9888B buffer, so

[PATCH v7 net-next 07/15] net: mvpp2: add FCA periodic timer configurations

2021-01-31 Thread stefanc
From: Stefan Chulski Flow Control periodic timer would be used if port in XOFF to transmit periodic XOFF frames. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 13 +- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 45 2 files cha

[PATCH v7 net-next 08/15] net: mvpp2: add FCA RXQ non occupied descriptor threshold

2021-01-31 Thread stefanc
From: Stefan Chulski The firmware needs to monitor the RX Non-occupied descriptor bits for flow control to move to XOFF mode. These bits need to be unmasked to be functional, but they will not raise interrupts as we leave the RX exception summary bit in MVPP2_ISR_RX_TX_MASK_REG clear. Signed-off

[PATCH v7 net-next 09/15] net: mvpp2: enable global flow control

2021-01-31 Thread stefanc
From: Stefan Chulski This patch enables global flow control in FW and in the phylink validate mask. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 13 ++--- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 30 +++- 2 files changed, 38 i

[PATCH v7 net-next 05/15] net: mvpp2: always compare hw-version vs MVPP21

2021-01-31 Thread stefanc
From: Stefan Chulski Currently we have PP2v1 and PP2v2 hw-versions, with some different handlers depending upon condition hw_version = MVPP21/MVPP22. In a future there will be also PP2v3. Let's use now the generic "if equal/notEqual MVPP21" for all cases instead of "if MVPP22". This patch does n

[PATCH v7 net-next 04/15] net: mvpp2: add PPv23 version definition

2021-01-31 Thread stefanc
From: Stefan Chulski This patch add PPv23 version definition. PPv23 is new packet processor in CP115. Everything that supported by PPv22, also supported by PPv23. No functional changes in this stage. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 24 +++

[PATCH v7 net-next 00/15] net: mvpp2: Add TX Flow Control support

2021-01-31 Thread stefanc
From: Stefan Chulski Armada hardware has a pause generation mechanism in GOP (MAC). The GOP generate flow control frames based on an indication programmed in Ports Control 0 Register. There is a bit per port. However assertion of the PortX Pause bits in the ports control 0 register only sends a

[PATCH v7 net-next 03/15] net: mvpp2: add CM3 SRAM memory map

2021-01-31 Thread stefanc
From: Stefan Chulski This patch adds CM3 memory map and CM3 read/write callbacks. No functionality changes. Signed-off-by: Stefan Chulski --- drivers/net/ethernet/marvell/mvpp2/mvpp2.h | 7 +++ drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 63 +++- 2 files changed, 67

[PATCH v7 net-next 01/15] doc: marvell: add cm3-mem and PPv2.3 description

2021-01-31 Thread stefanc
From: Stefan Chulski Patch introduce cm3-mem device tree bindings and add PPv2.3 description. Signed-off-by: Stefan Chulski --- Documentation/devicetree/bindings/net/marvell-pp2.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/mar

RE: [EXT] Re: [PATCH v5 net-next 00/18] net: mvpp2: Add TX Flow Control support

2021-01-31 Thread Stefan Chulski
> > > > Hi Stefan, looks like patchwork and lore didn't get all the emails: > > > > https://urldefense.proofpoint.com/v2/url?u=https- > > 3A__lore.kernel.org_r_1611858682-2D9845-2D1-2Dgit-2Dsend-2Demail- > > 2Dstefanc- > > > 40marvell.com&d=DwICAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=DDQ3dKwkTIx > > > KAl6_B

Re: [PATCH net 1/1] netfilter: conntrack: Check offload bit on table dump

2021-01-31 Thread Roi Dayan
On 2021-01-31 12:01 PM, Roi Dayan wrote: On 2021-01-30 2:01 PM, Pablo Neira Ayuso wrote: Hi Roi, On Thu, Jan 28, 2021 at 09:40:52AM +0200, Roi Dayan wrote: Currently, offloaded flows might be deleted when executing conntrack -L or cat /proc/net/nf_conntrack while rules being offloaded. Ct

[PATCH] NET: SRv6: seg6_local: Fixed SRH processing when segments left is 0

2021-01-31 Thread Suprit Japagal
From: "Suprit.Japagal" According to the standard IETF RFC 8754, section 4.3.1.1 (https://tools.ietf.org/html/rfc8754#section-4.3.1.1) When the segments left in SRH equals to 0, proceed to process the next header in the packet, whose type is identified by the Next header field of the routing heade

Re: [PATCH mlx5-next v1] RDMA/mlx5: Cleanup the synchronize_srcu() from the ODP flow

2021-01-31 Thread Yishai Hadas
On 1/29/2021 2:23 PM, Saeed Mahameed wrote: diff --git a/drivers/net/ethernet/mellanox/mlx5/core/mr.c b/drivers/net/ethernet/mellanox/mlx5/core/mr.c index 9eb51f06d3ae..50af84e76fb6 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/mr.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/mr.c @@ -56

[Patch v3 net-next 4/7] octeontx2-af: Physical link configuration support

2021-01-31 Thread Hariprasad Kelam
From: Christina Jacob CGX LMAC, the physical interface support link configuration parameters like speed, auto negotiation, duplex etc. Firmware saves these into memory region shared between firmware and this driver. This patch adds mailbox handler set_link_mode, fw_data_get to configure and rea

[Patch v3 net-next 2/7] octeontx2-af: Add new CGX_CMD to get PHY FEC statistics

2021-01-31 Thread Hariprasad Kelam
From: Felix Manlunas This patch adds support to fetch fec stats from PHY. The stats are put in the shared data struct fwdata. A PHY driver indicates that it has FEC stats by setting the flag fwdata.phy.misc.has_fec_stats Besides CGX_CMD_GET_PHY_FEC_STATS, also add CGX_CMD_PRBS and CGX_CMD_DISPL

[Patch v3 net-next 7/7] octeontx2-pf: ethtool physical link configuration

2021-01-31 Thread Hariprasad Kelam
From: Christina Jacob Register set_link_ksetting callback with driver such that link configurations parameters like advertised mode,speed, duplex and autoneg can be configured. below command ethtool -s eth0 advertise 0x1 speed 10 duplex full autoneg on Signed-off-by: Christina Jacob Signed-off

[Patch v3 net-next 1/7] octeontx2-af: forward error correction configuration

2021-01-31 Thread Hariprasad Kelam
From: Christina Jacob CGX block supports forward error correction modes baseR and RS. This patch adds support to set encoding mode and to read corrected/uncorrected block counters Adds new mailbox handlers set_fec to configure encoding modes and fec_stats to read counters and also increase mbox

[Patch v3 net-next 3/7] octeontx2-pf: ethtool fec mode support

2021-01-31 Thread Hariprasad Kelam
From: Christina Jacob Add ethtool support to configure fec modes baser/rs and support to fecth FEC stats from CGX as well PHY. Configure fec mode - ethtool --set-fec eth0 encoding rs/baser/off/auto Query fec mode - ethtool --show-fec eth0 Signed-off-by: Christina Jacob Signed-o

[Patch v3 net-next 5/7] octeontx2-af: advertised link modes support on cgx

2021-01-31 Thread Hariprasad Kelam
From: Christina Jacob CGX supports setting advertised link modes on physical link. This patch adds support to derive cgx mode from ethtool link mode and pass it to firmware to configure the same. Signed-off-by: Christina Jacob Signed-off-by: Sunil Goutham Signed-off-by: Hariprasad Kelam ---

Re: [PATCH net-next 9/9] net: ipa: don't disable NAPI in suspend

2021-01-31 Thread Alex Elder
On 1/30/21 10:29 PM, Alex Elder wrote: > On 1/30/21 9:25 AM, Willem de Bruijn wrote: >> On Fri, Jan 29, 2021 at 3:29 PM Alex Elder wrote: >>> >>> The channel stop and suspend paths both call __gsi_channel_stop(), >>> which quiesces channel activity, disables NAPI, and (on other than >>> SDM845) st

[PATCH v3 net-next 5/5] net: page_pool: simplify page recycling condition tests

2021-01-31 Thread Alexander Lobakin
pool_page_reusable() is a leftover from pre-NUMA-aware times. For now, this function is just a redundant wrapper over page_is_pfmemalloc(), so inline it into its sole call site. Signed-off-by: Alexander Lobakin Acked-by: Jesper Dangaard Brouer Reviewed-by: Ilias Apalodimas Reviewed-by: Jesse Br

Re: [PATCH v3 net-next 5/5] net: page_pool: simplify page recycling condition tests

2021-01-31 Thread Alexander Lobakin
From: Matthew Wilcox Date: Sun, 31 Jan 2021 12:23:48 + > On Sun, Jan 31, 2021 at 12:12:11PM +, Alexander Lobakin wrote: > > pool_page_reusable() is a leftover from pre-NUMA-aware times. For now, > > this function is just a redundant wrapper over page_is_pfmemalloc(), > > so inline it into

Re: [PATCH v3 net-next 3/5] net: introduce common dev_page_is_reusable()

2021-01-31 Thread Matthew Wilcox
On Sun, Jan 31, 2021 at 12:11:52PM +, Alexander Lobakin wrote: > A bunch of drivers test the page before reusing/recycling for two > common conditions: > - if a page was allocated under memory pressure (pfmemalloc page); > - if a page was allocated at a distant memory node (to exclude >sl

Re: [PATCH v3 net-next 1/5] mm: constify page_is_pfmemalloc() argument

2021-01-31 Thread Matthew Wilcox
On Sun, Jan 31, 2021 at 12:11:30PM +, Alexander Lobakin wrote: > The function only tests for page->index, so its argument should be > const. > > Signed-off-by: Alexander Lobakin > Reviewed-by: Jesse Brandeburg > Acked-by: David Rientjes Reviewed-by: Matthew Wilcox (Oracle)

Re: [EXT] Re: Phylink flow control support on ports with MLO_AN_FIXED auto negotiation

2021-01-31 Thread Russell King - ARM Linux admin
On Sun, Jan 31, 2021 at 11:12:14AM +, Russell King - ARM Linux admin wrote: > I discussed it with Andrew earlier last year, and his response was: > > DT configuration of pause for fixed link probably is sufficient. I don't > remember it ever been really discussed for DSA. It was a Melanox >

[PATCH] dt-bindings: ethernet-controller: fix fixed-link specification

2021-01-31 Thread Russell King
The original fixed-link.txt allowed a pause property for fixed link. This has been missed in the conversion to yaml format. Fixes: 9d3de3c58347 ("dt-bindings: net: Add YAML schemas for the generic Ethernet options") Signed-off-by: Russell King --- .../devicetree/bindings/net/ethernet-controller

[PATCH v3 net-next 3/5] net: introduce common dev_page_is_reusable()

2021-01-31 Thread Alexander Lobakin
A bunch of drivers test the page before reusing/recycling for two common conditions: - if a page was allocated under memory pressure (pfmemalloc page); - if a page was allocated at a distant memory node (to exclude slowdowns). Introduce a new common inline for doing this, with likely() alread

[PATCH v3 net-next 2/5] skbuff: constify skb_propagate_pfmemalloc() "page" argument

2021-01-31 Thread Alexander Lobakin
The function doesn't write anything to the page struct itself, so this argument can be const. Misc: align second argument to the brace while at it. Signed-off-by: Alexander Lobakin Reviewed-by: Jesse Brandeburg Acked-by: David Rientjes --- include/linux/skbuff.h | 4 ++-- 1 file changed, 2 in

[PATCH v3 net-next 1/5] mm: constify page_is_pfmemalloc() argument

2021-01-31 Thread Alexander Lobakin
The function only tests for page->index, so its argument should be const. Signed-off-by: Alexander Lobakin Reviewed-by: Jesse Brandeburg Acked-by: David Rientjes --- include/linux/mm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/mm.h b/include/linux/mm.h i

[PATCH v3 net-next 0/5] net: consolidate page_is_pfmemalloc() usage

2021-01-31 Thread Alexander Lobakin
page_is_pfmemalloc() is used mostly by networking drivers to test if a page can be considered for reusing/recycling. It doesn't write anything to the struct page itself, so its sole argument can be constified, as well as the first argument of skb_propagate_pfmemalloc(). In Page Pool core code, it c

Re: [EXT] Re: Phylink flow control support on ports with MLO_AN_FIXED auto negotiation

2021-01-31 Thread Russell King - ARM Linux admin
On Sun, Jan 31, 2021 at 10:51:46AM +, Stefan Chulski wrote: > > > > Hi, > > > > > > Armada has options for 1G/10G ports without PHY's(for example > > community board Macchiato single shot). > > > This port doesn't have PHY's and cannot negotiate Flow Control support, > > but we can for example

[PATCH 1/1] vsock: fix the race conditions in multi-transport support

2021-01-31 Thread Alexander Popov
There are multiple similar bugs implicitly introduced by the commit c0cfa2d8a788fcf4 ("vsock: add multi-transports support") and commit 6a2c0962105ae8ce ("vsock: prevent transport modules unloading"). The bug pattern: [1] vsock_sock.transport pointer is copied to a local variable, [2] lock_sock(

Re: Phylink flow control support on ports with MLO_AN_FIXED auto negotiation

2021-01-31 Thread Russell King - ARM Linux admin
On Sun, Jan 31, 2021 at 10:12:25AM +, Stefan Chulski wrote: > Hi, > > Armada has options for 1G/10G ports without PHY's(for example community board > Macchiato single shot). > This port doesn't have PHY's and cannot negotiate Flow Control support, but > we can for example connect two ports w

  1   2   >