On Thu, 28 Jan 2021 22:51:23 -0800
John Fastabend wrote:
> Jesper Dangaard Brouer wrote:
> > This BPF-helper bpf_check_mtu() works for both XDP and TC-BPF programs.
> >
> > The SKB object is complex and the skb->len value (accessible from
> > BPF-prog) also include the length of any extra GRO/GS
Thu, Jan 28, 2021 at 03:17:13PM CET, and...@lunn.ch wrote:
>On Thu, Jan 28, 2021 at 09:14:34AM +0100, Jiri Pirko wrote:
>> Wed, Jan 27, 2021 at 03:14:34PM CET, and...@lunn.ch wrote:
>> >> >There are Linux standard APIs for controlling the power to devices,
>> >> >the regulator API. So i assume mlxr
Jesper Dangaard Brouer wrote:
> This demonstrate how bpf_check_mtu() helper can easily be used together
> with bpf_skb_adjust_room() helper, prior to doing size adjustment, as
> delta argument is already setup.
>
> Hint: This specific test can be selected like this:
> ./test_progs -t cls_redirect
Jesper Dangaard Brouer wrote:
> The use-case for dropping the MTU check when TC-BPF does redirect to
> ingress, is described by Eyal Birger in email[0]. The summary is the
> ability to increase packet size (e.g. with IPv6 headers for NAT64) and
> ingress redirect packet and let normal netstack frag
Jesper Dangaard Brouer wrote:
> This BPF-helper bpf_check_mtu() works for both XDP and TC-BPF programs.
>
> The SKB object is complex and the skb->len value (accessible from
> BPF-prog) also include the length of any extra GRO/GSO segments, but
> without taking into account that these GRO/GSO segm
On Thu, Jan 28, 2021 at 02:27:00PM +0100, Rafael J. Wysocki wrote:
> On Thu, Jan 28, 2021 at 2:12 PM Calvin Johnson
> wrote:
> >
> > On Thu, Jan 28, 2021 at 01:00:40PM +0100, Rafael J. Wysocki wrote:
> > > On Thu, Jan 28, 2021 at 12:27 PM Calvin Johnson
> > > wrote:
> > > >
> > > > Hi Rafael,
> >
Fixes checkpatch warnings for usage of strlcpy.
Signed-off-by: Kumar Kartikeya Dwivedi
---
drivers/staging/qlge/qlge_ethtool.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/qlge/qlge_ethtool.c
b/drivers/staging/qlge/qlge_ethtool.c
index a28f0254c..635
On 28.01.2021 20:19, Stefano Garzarella wrote:
> Hi Arseny,
> I reviewed a part, tomorrow I hope to finish the other patches.
>
> Just a couple of comments in the TODOs below.
>
> On Mon, Jan 25, 2021 at 02:09:00PM +0300, Arseny Krasnov wrote:
>> This patchset impelements support of SOCK_SEQ
Hi David, Stephen,
> From: Parav Pandit
> Sent: Tuesday, January 26, 2021 6:54 PM
>
> Hi Stephen,
>
> > From: Parav Pandit
> > Sent: Friday, January 22, 2021 10:32 AM
> >
> > Extended devlink-port man page for synopsis, description and example
> > for setting devlink port function attribute.
>
On 28.01.2021 19:55, Stefano Garzarella wrote:
> On Mon, Jan 25, 2021 at 02:12:36PM +0300, Arseny Krasnov wrote:
>> This adds receive loop for SEQPACKET. It looks like receive loop for
>> SEQPACKET, but there is a little bit difference:
>> 1) It doesn't call notify callbacks.
>> 2) It doesn't car
On 1/28/21 9:57 PM, Cong Wang wrote:
On Thu, Jan 28, 2021 at 6:54 PM Alexei Starovoitov
wrote:
I meant it would look like:
noinline per_elem_callback(map, key, value, ...)
{
if (value->foo > ...)
bpf_delete_map_elem(map, key);
}
noinline timer_callback(timer, ctx)
{
map = ctx->
From: wengjianfeng
define ret and then assign value to it, which we should do one time.
Signed-off-by: wengjianfeng
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8
On 1/29/2021 1:14 PM, Cong Wang wrote:
On Wed, Jan 27, 2021 at 5:48 PM Chris Mi wrote:
In order to send sampled packets to userspace, NIC driver calls
psample api directly. But it creates a hard dependency on module
psample. Introduce psample_ops to remove the hard dependency.
It is initialized
Jesper Dangaard Brouer wrote:
> The BPF-helpers for FIB lookup (bpf_xdp_fib_lookup and bpf_skb_fib_lookup)
> can perform MTU check and return BPF_FIB_LKUP_RET_FRAG_NEEDED. The BPF-prog
> don't know the MTU value that caused this rejection.
>
> If the BPF-prog wants to implement PMTU (Path MTU Disc
Jesper Dangaard Brouer wrote:
> BPF end-user on Cilium slack-channel (Carlo Carraro) wants to use
> bpf_fib_lookup for doing MTU-check, but *prior* to extending packet size,
> by adjusting fib_params 'tot_len' with the packet length plus the expected
> encap size. (Just like the bpf_check_mtu helpe
On 2021-01-28 23:06, Xie He wrote:
On Thu, Jan 28, 2021 at 11:47 AM Jakub Kicinski
wrote:
Noob question - could you point at or provide a quick guide to
layering
here? I take there is only one netdev, and something maintains an
internal queue which is not stopped when HW driver stops the qdi
On Thu, Jan 28, 2021 at 6:54 PM Alexei Starovoitov
wrote:
>
> I meant it would look like:
>
> noinline per_elem_callback(map, key, value, ...)
> {
> if (value->foo > ...)
> bpf_delete_map_elem(map, key);
> }
>
> noinline timer_callback(timer, ctx)
> {
> map = ctx->map;
> bpf_for_each_map
On Thu, Jan 28, 2021 at 9:21 PM Jakub Kicinski wrote:
>
> On Thu, 28 Jan 2021 21:08:05 -0800 Cong Wang wrote:
> > On Thu, Jan 28, 2021 at 12:55 PM Jakub Kicinski wrote:
> > >
> > > On Sat, 23 Jan 2021 17:30:49 -0800 Cong Wang wrote:
> > > > From: Cong Wang
> > > >
> > > > dev_ifsioc_locked() is
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Wed, 27 Jan 2021 10:28:01 +0800 you wrote:
> From: dingsenjie
>
> allocted -> allocated
>
> Signed-off-by: dingsenjie
> ---
> include/linux/qed/qed_chain.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
He
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Wed, 27 Jan 2021 12:13:59 -0600 you wrote:
> From: Bjorn Helgaas
>
> Fix misspellings of "physical".
>
> Signed-off-by: Bjorn Helgaas
> ---
> Thanks, Willem!
>
> [...]
Here is the summary with links:
- [v2] octeo
On Thu, 28 Jan 2021 21:08:05 -0800 Cong Wang wrote:
> On Thu, Jan 28, 2021 at 12:55 PM Jakub Kicinski wrote:
> >
> > On Sat, 23 Jan 2021 17:30:49 -0800 Cong Wang wrote:
> > > From: Cong Wang
> > >
> > > dev_ifsioc_locked() is called with only RCU read lock, so when
> > > there is a parallel wri
On Wed, Jan 27, 2021 at 5:48 PM Chris Mi wrote:
>
> In order to send sampled packets to userspace, NIC driver calls
> psample api directly. But it creates a hard dependency on module
> psample. Introduce psample_ops to remove the hard dependency.
> It is initialized when psample module is loaded a
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Thu, 28 Jan 2021 13:49:12 +0100 you wrote:
> At this moment, there is only one type of next-hop group: an mpath group.
> Mpath groups implement the hash-threshold algorithm, described in RFC
> 2992[1].
>
> To select a
On Thu, Jan 28, 2021 at 12:55 PM Jakub Kicinski wrote:
>
> On Sat, 23 Jan 2021 17:30:49 -0800 Cong Wang wrote:
> > From: Cong Wang
> >
> > dev_ifsioc_locked() is called with only RCU read lock, so when
> > there is a parallel writer changing the mac address, it could
> > get a partially updated m
syzbot has found a reproducer for the following issue on:
HEAD commit:d03154e8 Add linux-next specific files for 20210128
git tree: linux-next
console output: https://syzkaller.appspot.com/x/log.txt?x=1243cbc8d0
kernel config: https://syzkaller.appspot.com/x/.config?x
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Thu, 28 Jan 2021 12:25:46 +0100 you wrote:
> Hi Dave & Jakub,
>
> please apply the following patch series for qeth to netdev's net-next tree.
>
> Nothing special, mostly fine-tuning and follow-on cleanups for earlier
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Thu, 28 Jan 2021 12:41:03 +0100 you wrote:
> Hi Dave & Jakub,
>
> please apply the following patch series for iucv to netdev's net-next tree.
>
> This reworks & simplifies the TX notification path in af_iucv, so that
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Tue, 26 Jan 2021 12:56:57 -0600 you wrote:
> Version 2 of this series fixes a "restricted __le16 degrades to
> integer" warning from sparse in the third patch. The normal host
> architecture is little-endian, so the pr
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Tue, 26 Jan 2021 18:39:39 +0100 you wrote:
> The current layout of net_device is not optimal for cacheline usage.
>
> The member adj_list.lower linked list is split between cacheline 2 and 3.
> The ifindex is placed tog
Returning -EBUSY in ibmvnic_remove() does not actually hold the
removal procedure since driver core doesn't care for the return
value (see __device_release_driver() in drivers/base/dd.c
calling dev->bus->remove()) though vio_bus_remove
(in arch/powerpc/platforms/pseries/vio.c) records the
return va
On Thu, 28 Jan 2021 20:33:22 -0700 David Ahern wrote:
> On 1/28/21 8:04 PM, Jakub Kicinski wrote:
> > On Tue, 26 Jan 2021 15:23:06 +0200 Ido Schimmel wrote:
> >> Emit RTM_NEWROUTE notifications whenever RTM_F_OFFLOAD/RTM_F_TRAP flags
> >> are changed. The aim is to provide an indication to user-s
On 1/26/21 10:39 AM, Jesper Dangaard Brouer wrote:
> The current layout of net_device is not optimal for cacheline usage.
>
> The member adj_list.lower linked list is split between cacheline 2 and 3.
> The ifindex is placed together with stats (struct net_device_stats),
> although most modern driv
On 2021/1/28 下午9:41, Eli Cohen wrote:
When a change of memory map occurs, the hardware resources are destroyed
and then re-created again with the new memory map. In such case, we need
to restore the hardware available and used indices. The driver failed to
restore the used index which is added
On 2021/1/28 下午9:41, Eli Cohen wrote:
suspend_vq should only suspend the VQ on not save the current available
index. This is done when a change of map occurs when the driver calls
save_channel_info().
Signed-off-by: Eli Cohen
Acked-by: Jason Wang
---
drivers/vdpa/mlx5/net/mlx5_vnet.c
__ibmvnic_reset() currently reads the adapter->state before getting the
rtnl and saves that state as the "target state" for the reset. If this
read occurs when adapter is in PROBED state, the target state would be
PROBED.
Just after the target state is saved, and before the actual reset process
is
If two or more instances of 'ip link set' commands race and first one
already brings the interface up (or down), the subsequent instances
can simply return without redoing the up/down operation.
Fixes: ed651a10875f ("ibmvnic: Updated reset handling")
Reported-by: Abdul Haleem
Tested-by: Abdul Hal
On 1/28/21 8:04 PM, Jakub Kicinski wrote:
> On Tue, 26 Jan 2021 15:23:06 +0200 Ido Schimmel wrote:
>> Emit RTM_NEWROUTE notifications whenever RTM_F_OFFLOAD/RTM_F_TRAP flags
>> are changed. The aim is to provide an indication to user-space
>> (e.g., routing daemons) about the state of the route in
Hi David,
> From: Parav Pandit
> Sent: Friday, January 29, 2021 12:13 AM
[..]
> ---
> changelog:
> v1->v2:
> - added and used library helpers for socket communication
> - added and used library functions for string processing helpers
> - added and used library functions indent processing hel
On 1/28/21 5:49 AM, Petr Machata wrote:
> At this moment, there is only one type of next-hop group: an mpath group.
> Mpath groups implement the hash-threshold algorithm, described in RFC
> 2992[1].
>
> To select a next hop, hash-threshold algorithm first assigns a range of
> hashes to each next h
On 1/28/21 5:49 AM, Petr Machata wrote:
> Validation of messages for get / del of a next hop is the same as will be
> validation of messages for get of a resilient next hop group bucket. The
> difference is that policy for resilient next hop group buckets is a
> superset of that used for next-hop g
On 1/28/21 5:49 AM, Petr Machata wrote:
> In order to allow different handling for next-hop tree dumper and for
> bucket dumper, parameterize the next-hop tree walker with a callback. Add
> rtm_dump_nexthop_cb() with just the bits relevant for next-hop tree
> dumping.
>
> Signed-off-by: Petr Macha
On 1/28/21 5:49 AM, Petr Machata wrote:
> Extract from rtm_dump_nexthop() a helper to walk the next hop tree. A
> separate function for this will be reusable from the bucket dumper.
>
> Signed-off-by: Petr Machata
> Reviewed-by: Ido Schimmel
> ---
> net/ipv4/nexthop.c | 52 +
On 1/28/21 5:49 AM, Petr Machata wrote:
> The dump operations need to keep state from one invocation to another. A
> scratch area is dedicated for this purpose in the passed-in argument, cb,
> namely via two aliased arrays, struct netlink_callback.args and .ctx.
>
> Dumping of buckets will end up
On 1/28/21 5:49 AM, Petr Machata wrote:
> Requests to dump nexthops have many attributes in common with those that
> requests to dump buckets of resilient NH groups will have. In order to make
> reuse of this code simpler, convert the code to use a single structure with
> filtering configuration in
On 1/28/21 5:49 AM, Petr Machata wrote:
> Requests to dump nexthops have many attributes in common with those that
> requests to dump buckets of resilient NH groups will have. However, they
> have different policies. To allow reuse of this code, extract a
> policy-agnostic wrapper out of nh_valid_d
On 1/28/21 5:49 AM, Petr Machata wrote:
> After there are several next-hop group types, initialization and
> finalization of notifier type needs to reflect the actual type. Transform
> nh_notifier_grp_info_init() and _fini() to make extending them easier.
>
> Signed-off-by: Petr Machata
> Reviewe
On 1/28/21 5:49 AM, Petr Machata wrote:
> From: Ido Schimmel
>
> Currently there are only two types of in-kernel nexthop notification.
> The two are distinguished by the 'is_grp' boolean field in 'struct
> nh_notifier_info'.
>
> As more notification types are introduced for more next-hop group t
On 1/28/21 5:49 AM, Petr Machata wrote:
> Most of the code that deals with nexthop groups relies on the fact that the
> group is of exactly one well-known type. Currently there is only one type,
> "mpath", but as more next-hop group types come, it becomes desirable to
> have a central place where t
On 1/28/21 5:49 AM, Petr Machata wrote:
> The values that a next-hop group needs to keep track of depend on the group
> type. Introduce a union to separate fields specific to the mpath groups
> from fields specific to other group types.
>
> Signed-off-by: Petr Machata
> Reviewed-by: Ido Schimmel
On 1/28/21 5:49 AM, Petr Machata wrote:
> The logic for selecting path depends on the next-hop group type. Adapt the
> nexthop_select_path() to dispatch according to the group type.
>
> Signed-off-by: Petr Machata
> Reviewed-by: Ido Schimmel
> ---
> net/ipv4/nexthop.c | 22 -
On 1/28/21 5:49 AM, Petr Machata wrote:
> From: David Ahern
>
> nexthop_free_mpath really should be nexthop_free_group. Rename it.
>
> Signed-off-by: David Ahern
> Reviewed-by: Ido Schimmel
> Signed-off-by: Petr Machata
> ---
> net/ipv4/nexthop.c | 4 ++--
> 1 file changed, 2 insertions(+),
On Tue, 26 Jan 2021 15:23:06 +0200 Ido Schimmel wrote:
> Emit RTM_NEWROUTE notifications whenever RTM_F_OFFLOAD/RTM_F_TRAP flags
> are changed. The aim is to provide an indication to user-space
> (e.g., routing daemons) about the state of the route in hardware.
What does the daemon in the user spa
On Wed, Jan 27, 2021 at 10:28:15PM -0800, Cong Wang wrote:
> On Wed, Jan 27, 2021 at 10:00 AM Alexei Starovoitov
> wrote:
> >
> > On Tue, Jan 26, 2021 at 11:00 PM Cong Wang wrote:
> > > > > ret = PTR_ERR(l_new);
> > > > > + if (ret == -EAGAIN) {
> > > > > +
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Thu, 28 Jan 2021 09:48:59 +0500 you wrote:
> TX/RX descriptor ring fields are always little-endian, but conversion
> wasn't performed for big-endian CPUs, so the driver failed to work.
>
> This patch makes the driver wo
On Thu, Jan 28, 2021 at 9:21 PM Willem de Bruijn
wrote:
>
> On Thu, Jan 28, 2021 at 8:02 PM Vadim Fedorenko wrote:
> >
> > dev->hard_header_len for tunnel interface is set only when header_ops
> > are set too and already contains full overhead of any tunnel encapsulation.
> > That's why there is
On Thu, 28 Jan 2021 21:45:02 + Nguyen, Anthony L wrote:
> > drivers/net/ethernet/intel/e100.c | 92 -
>
> My apologies, this patch slipped through the cracks for me. I will send
> it in my next net-next 1GbE series or Jakub you can take it directly if
> you'd like.
On Thu, 28 Jan 2021 20:31:04 +0200 stef...@marvell.com wrote:
> From: Stefan Chulski
>
> Armada hardware has a pause generation mechanism in GOP (MAC).
> The GOP generate flow control frames based on an indication programmed in
> Ports Control 0 Register. There is a bit per port.
> However asser
On Thu, Jan 28, 2021 at 8:02 PM Vadim Fedorenko wrote:
>
> dev->hard_header_len for tunnel interface is set only when header_ops
> are set too and already contains full overhead of any tunnel encapsulation.
> That's why there is not need to use this overhead twice in mtu calc.
>
> Fixes: fdafed459
On Mon, 25 Jan 2021 08:45:28 -0800 t...@redhat.com wrote:
> From: Tom Rix
>
> This change fixes the checkpatch warning described in this commit
> commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of
> unnecessary %h[xudi] and %hh[xudi]")
>
> Standard integer promotion is already
On Thu, 28 Jan 2021 22:07:50 +0200 Vladimir Oltean wrote:
> On Wed, Jan 27, 2021 at 05:30:44PM -0800, Jakub Kicinski wrote:
> > > +const struct dsa_device_ops *dsa_find_tagger_by_name(const char *buf)
> > > +{
> > > + const struct dsa_device_ops *ops = NULL;
> > > + struct dsa_tag_driver *dsa_tag_d
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Mon, 25 Jan 2021 00:33:35 -0700 you wrote:
> Pass through mode is to allow packets in MAP format to be passed
> on to the stack. rmnet driver can be used to process and demultiplex
> these packets.
>
> Pass through mode
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Wed, 27 Jan 2021 16:34:31 +0100 you wrote:
> Hello,
>
> this patch series add a sysfs file to let userspace know which mux
> id has been used to create a qmimux network interface.
>
> I'm aware that adding new sysfs f
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Sun, 24 Jan 2021 11:08:04 -0800 you wrote:
> From: Tom Rix
>
> This change fixes the checkpatch warning described in this commit
> commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of
> unnecessary %h[
Hi,
Thank you.
Regards,
Athari
-Original Message-
From: patchwork-bot+netdev...@kernel.org
Sent: Friday, January 29, 2021 5:20 AM
To: Ismail, Mohammad Athari
Cc: peppe.cavall...@st.com; alexandre.tor...@st.com; joab...@synopsys.com;
da...@davemloft.net; k...@kernel.org; mcoquelin.st.
On Wed, 27 Jan 2021 08:26:13 +0100 Bjørn Mork wrote:
> Jakub Kicinski writes:
> > We got two patches adding new sysfs files for QMI in close succession -
> > is there a sense of how much this interface will grow over time?
>
> The honest answer is no.
>
> I do not expect this interface to grow
Hi John,
On Thu, Jan 28, 2021 at 03:37:09PM -0800, John Fastabend wrote:
> Otherwise, its not the most elegant, but testing XDP at the moment
> doesn't fit into the normal test framework very well either.
Thanks a lot for your help in reviewing the patches. I will add updating
XDP test in my todo
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
On Fri, 22 Jan 2021 11:36:45 -0800 you wrote:
> From: Parav Pandit
>
> Prepare code to fill zero or more port function optional attributes.
> Subsequent patch makes use of this to fill more port function
> attributes.
>
On Thu, 28 Jan 2021 00:33:20 -0800 Saeed Mahameed wrote:
> On Thu, 2021-01-28 at 03:30 +, patchwork-bot+netdev...@kernel.org
> wrote:
> > Hello:
> >
> > This series was applied to netdev/net.git (refs/heads/master):
> >
> >
> ...
>
> > https://git.kernel.org/netdev/net/c/89e394675818
Hello:
This patch was applied to bpf/bpf-next.git (refs/heads/master):
On Wed, 27 Jan 2021 18:46:15 +0100 you wrote:
> !perfmon_capable() is checked before the last switch(func_id) in
> bpf_base_func_proto. Thus, the cases BPF_FUNC_trace_printk and
> BPF_FUNC_snprintf_btf can be moved to that las
From: Geliang Tang
This patch adds testcases for ADD_ADDR with port and the related MIB
counters check in chk_add_nr. The output looks like this:
24 signal address with port syn[ ok ] - synack[ ok ] - ack[ ok ]
add[ ok ] - echo [ ok ] - pt [ ok
From: Geliang Tang
Since the mptcp_join script is becoming too big, this patch splits it
into several smaller chunks, each of them has been defined in a function
as a individual test group for several related testcases.
Using bash getopts function to parse command line arguments, and invoke
each
Hello:
This series was applied to bpf/bpf-next.git (refs/heads/master):
On Wed, 27 Jan 2021 15:28:49 -0800 you wrote:
> We'd like to use the SENDMSG ones, Daniel suggested to
> expose to more hooks while are here.
>
> Stanislav Fomichev (4):
> bpf: enable bpf_{g,s}etsockopt in BPF_CGROUP_UDP{4
From: Geliang Tang
This patch adds the mibs for ADD_ADDR with port:
MPTCP_MIB_PORTADD for received ADD_ADDR suboption with a port number.
MPTCP_MIB_PORTSYNRX, MPTCP_MIB_PORTSYNACKRX, MPTCP_MIB_PORTACKRX, for
received MP_JOIN's SYN or SYN/ACK or ACK with a port number which is
different from the
From: Geliang Tang
This patch adds a new argument for pm_nl_ctl tool. We can use it like
this:
# pm_nl_ctl add 10.0.2.1 flags signal port 10100
# pm_nl_ctl dump
id 1 flags signal 10.0.2.1 10100
Signed-off-by: Geliang Tang
Signed-off-by: Mat Martineau
---
tools/testing/selftests/net/mptcp/
From: Geliang Tang
When dealing with the addresses list local_addr_list or anno_list, we
should enable the function addresses_equal's parameter use_port. And
enable it in address_zero too.
Signed-off-by: Geliang Tang
Signed-off-by: Mat Martineau
---
net/mptcp/pm_netlink.c | 8
1 file
From: Geliang Tang
This patch adds MPTCP_PM_ADDR_ATTR_PORT filling and parsing in PM
netlink.
Signed-off-by: Geliang Tang
Signed-off-by: Mat Martineau
---
net/mptcp/pm_netlink.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index 5b04
From: Geliang Tang
This patch adds two new helpers, subflow_use_different_sport and
subflow_use_different_dport, to check whether the subflow's source or
destination port number is different from the msk's port number. When
receiving the MP_JOIN's SYN/SYNACK/ACK, we do these port number checks
an
From: Geliang Tang
This patch adds testcases to create subflows or signal addresses for the
newly added IPv4 or IPv6 addresses.
Signed-off-by: Geliang Tang
Signed-off-by: Mat Martineau
---
.../testing/selftests/net/mptcp/mptcp_join.sh | 73 ++-
1 file changed, 71 insertions(+)
From: Geliang Tang
This patch creates a listening socket when an address with a port-number
is added by PM netlink. Then binds the new port to the socket, and
listens for new connections.
When the address is removed or the addresses are flushed by PM netlink,
release the listening socket.
Signe
From: Geliang Tang
This patch adds a new helper named subflow_req_create_thmac, which is
extracted from subflow_token_join_request. It initializes subflow_req's
local_nonce and thmac fields, those are the more expensive to populate.
Signed-off-by: Geliang Tang
Signed-off-by: Mat Martineau
---
From: Geliang Tang
This patch drops the unused parameter skb in subflow_token_join_request.
Signed-off-by: Geliang Tang
Signed-off-by: Mat Martineau
---
net/mptcp/subflow.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c
index
From: Geliang Tang
Currently, when a new MPTCP endpoint is added, the existing MPTCP
sockets are not affected.
This patch implements a new function mptcp_nl_add_subflow_or_signal_addr,
invoked when an address is added from PM netlink. This function traverses
the MPTCP sockets list and invokes mp
From: Geliang Tang
This patch changes the removing addresses numbers to minus values, left
the plus values for the adding addresses numbers.
Signed-off-by: Geliang Tang
Signed-off-by: Mat Martineau
---
.../testing/selftests/net/mptcp/mptcp_join.sh | 32 ++-
1 file changed, 17
From: Geliang Tang
This patch changes the sending ACK conditions for the ADD_ADDR, send an
ACK packet for any ADD_ADDR, not just when ipv6 addresses or port
numbers are included.
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/139
Acked-by: Paolo Abeni
Signed-off-by: Geliang Tang
This patch series from the MPTCP tree contains enhancements and
associated tests for the ADD_ADDR ("add address") MPTCP option. This
option allows already-connected MPTCP peers to share additional IP
addresses with each other, which can then be used to create additional
subflows within those MPTCP
From: Geliang Tang
This patch drops the per-msk values add_addr_signal_max,
add_addr_accept_max, local_addr_max and subflows_max fields in struct
mptcp_pm_data, uses the pernet *_max values instead. And adds four new
helpers to get the pernet *_max values separately.
Co-developed-by: Matthieu Ba
From: Geliang Tang
This patch uses WRITE_ONCE() and READ_ONCE for all the pernet
add_addr_signal_max, add_addr_accept_max, local_addr_max and
subflows_max fields in struct pm_nl_pernet to avoid concurrency
issues.
Signed-off-by: Geliang Tang
Signed-off-by: Mat Martineau
---
net/mptcp/pm_netli
> + /* For T1 PHY */
> + if (lan937x_is_internal_t1_phy_port(dev, port)) {
> + phylink_set(mask, 100baseT_Full);
> + phylink_set_port_modes(mask);
Since this is a T1 PHY, you should be using 100baseT1_Full.
This might be the first user of this for phylink, so pleas
> +bool lan937x_is_internal_phy_port(struct ksz_device *dev, int port)
> +{
> + /* Check if the port is RGMII */
> + if (port == LAN937X_RGMII_1_PORT || port == LAN937X_RGMII_2_PORT)
> + return false;
> +
> + /* Check if the port is SGMII */
> + if (port == LAN937X_SGMII
On 1/29/21 1:59 AM, Stanislav Fomichev wrote:
On Thu, Jan 28, 2021 at 4:52 PM Daniel Borkmann wrote:
On 1/28/21 12:28 AM, Stanislav Fomichev wrote:
Those hooks run as BPF_CGROUP_RUN_SA_PROG_LOCK and operate on
a locked socket.
Signed-off-by: Stanislav Fomichev
---
net/core/filter.c
From: Vladimir Oltean
There are use cases for which the existing tagger, based on the NPI
(Node Processor Interface) functionality, is insufficient.
Namely:
- Frames injected through the NPI port bypass the frame analyzer, so no
source address learning is performed, no TSN stream classificatio
From: Vladimir Oltean
Unlike sja1105, the only other user of the software-defined tag_8021q.c
tagger format, the implementation we choose for the Felix DSA switch
driver preserves full functionality under a vlan_filtering bridge
(i.e. IP termination works through the DSA user ports under all
circ
From: Vladimir Oltean
In expectation of the new tag_ocelot_8021q tagger implementation, we
need to be able to do runtime switchover between one tagger and another.
So we must structure the existing code for the current NPI-based tagger
in a certain way.
We move the felix_npi_port_init function i
From: Vladimir Oltean
Applying the bridge forwarding mask currently is done only on the STP
state changes for any port. But it depends on both STP state changes,
and bonding interface state changes. Export the bit that recalculates
the forwarding mask so that it could be reused, and call it when
From: Vladimir Oltean
We will be adding some private VCAP filters that should not interfere in
any way with the filters added using tc-flower. So we need to allocate
some IDs which will not be used by tc.
Currently ocelot uses an u32 id derived from the flow cookie, which in
itself is an unsigne
From: Vladimir Oltean
The existence of dsa_broadcast has generated some confusion in the past:
https://www.mail-archive.com/netdev@vger.kernel.org/msg365042.html
So let's document the existing dsa_port_notify and dsa_broadcast
functions and explain when each of them should be used.
Also, in fac
From: Vladimir Oltean
Currently DSA exposes the following sysfs:
$ cat /sys/class/net/eno2/dsa/tagging
ocelot
which is a read-only device attribute, introduced in the kernel as
commit 98cdb4807123 ("net: dsa: Expose tagging protocol to user-space"),
and used by libpcap since its commit 993db3800
From: Vladimir Oltean
Context: Ocelot switches put the injection/extraction frame header in
front of the Ethernet header. When used in NPI mode, a DSA master would
see junk instead of the destination MAC address, and it would most
likely drop the packets. So the Ocelot frame header can have an op
From: Vladimir Oltean
Cascading DSA switches can be done multiple ways. There is the brute
force approach / tag stacking, where one upstream switch, located
between leaf switches and the host Ethernet controller, will just
happily transport the DSA header of those leaf switches as payload.
For th
From: Vladimir Oltean
The sja1105 implementation can be blind about this, but the felix driver
doesn't do exactly what it's being told, so it needs to know whether it
is a TX or an RX VLAN, so it can install the appropriate type of TCAM
rule.
Signed-off-by: Vladimir Oltean
Reviewed-by: Florian
1 - 100 of 334 matches
Mail list logo
